Re: [PATCH v2 7/8] xen/xenbus: Fix typo "notifer"

2025-07-18 Thread Jürgen Groß
On 15.07.25 15:44, WangYuli wrote: There is a spelling mistake of 'notifer' in the comment which should be 'notifier'. Link: https://lore.kernel.org/all/b3c019b63c93846f+20250715071245.398846-1-wangy...@uniontech.com/ Signed-off-by: WangYuli Reviewed-by: Juergen Gross Juergen OpenPGP_0x

Re: [patch 27/30] xen/events: Only force affinity mask for percpu interrupts

2020-12-11 Thread Jürgen Groß
On 11.12.20 00:20, boris.ostrov...@oracle.com wrote: On 12/10/20 2:26 PM, Thomas Gleixner wrote: All event channel setups bind the interrupt on CPU0 or the target CPU for percpu interrupts and overwrite the affinity mask with the corresponding cpumask. That does not make sense. The XEN impleme

Re: [patch 27/30] xen/events: Only force affinity mask for percpu interrupts

2020-12-11 Thread Jürgen Groß
On 11.12.20 11:13, Thomas Gleixner wrote: On Fri, Dec 11 2020 at 07:17, Jürgen Groß wrote: On 11.12.20 00:20, boris.ostrov...@oracle.com wrote: On 12/10/20 2:26 PM, Thomas Gleixner wrote: All event channel setups bind the interrupt on CPU0 or the target CPU for percpu interrupts and

Re: [patch 27/30] xen/events: Only force affinity mask for percpu interrupts

2020-12-11 Thread Jürgen Groß
On 11.12.20 00:20, boris.ostrov...@oracle.com wrote: On 12/10/20 2:26 PM, Thomas Gleixner wrote: All event channel setups bind the interrupt on CPU0 or the target CPU for percpu interrupts and overwrite the affinity mask with the corresponding cpumask. That does not make sense. The XEN impleme

Re: [PATCH] Revert "xen: add helpers to allocate unpopulated memory"

2020-12-07 Thread Jürgen Groß
On 06.12.20 18:22, Marek Marczykowski-Górecki wrote: This reverts commit 9e2369c06c8a181478039258a4598c1ddd2cadfa. On a Xen PV dom0, with NVME disk, this makes the dom0 crash when starting a domain. This looks like some bad interaction between xen-blkback and xen-scsiback has the same use patt

Re: [PATCH v5 3/3] xen: add helpers to allocate unpopulated memory

2020-09-04 Thread Jürgen Groß
On 04.09.20 10:42, Roger Pau Monné wrote: On Fri, Sep 04, 2020 at 09:00:18AM +0200, Jürgen Groß wrote: On 03.09.20 18:38, Roger Pau Monné wrote: On Thu, Sep 03, 2020 at 05:30:07PM +0200, Jürgen Groß wrote: On 01.09.20 10:33, Roger Pau Monne wrote: To be used in order to create foreign

Re: [PATCH v5 3/3] xen: add helpers to allocate unpopulated memory

2020-09-04 Thread Jürgen Groß
On 03.09.20 18:38, Roger Pau Monné wrote: On Thu, Sep 03, 2020 at 05:30:07PM +0200, Jürgen Groß wrote: On 01.09.20 10:33, Roger Pau Monne wrote: To be used in order to create foreign mappings. This is based on the ZONE_DEVICE facility which is used by persistent memory devices in order to

Re: [PATCH v5 3/3] xen: add helpers to allocate unpopulated memory

2020-09-03 Thread Jürgen Groß
On 01.09.20 10:33, Roger Pau Monne wrote: To be used in order to create foreign mappings. This is based on the ZONE_DEVICE facility which is used by persistent memory devices in order to create struct pages and kernel virtual mappings for the IOMEM areas of such devices. Note that on kernels with

Re: [PATCH v5 3/3] xen: add helpers to allocate unpopulated memory

2020-09-01 Thread Jürgen Groß
On 01.09.20 16:45, Roger Pau Monné wrote: On Tue, Sep 01, 2020 at 10:33:26AM +0200, Roger Pau Monne wrote: +static int fill_list(unsigned int nr_pages) +{ + struct dev_pagemap *pgmap; + void *vaddr; + unsigned int i, alloc_pages = round_up(nr_pages, PAGES_PER_SECTION); +

Re: [PATCH v4 2/2] xen: add helpers to allocate unpopulated memory

2020-08-14 Thread Jürgen Groß
On 14.08.20 15:35, Roger Pau Monné wrote: On Fri, Aug 14, 2020 at 02:54:38PM +0200, Jürgen Groß wrote: On 14.08.20 14:47, Roger Pau Monné wrote: On Fri, Aug 14, 2020 at 12:27:32PM +0200, Jürgen Groß wrote: On 14.08.20 11:56, Roger Pau Monné wrote: On Fri, Aug 14, 2020 at 08:29:20AM +0100

Re: [PATCH v4 2/2] xen: add helpers to allocate unpopulated memory

2020-08-14 Thread Jürgen Groß
On 14.08.20 14:47, Roger Pau Monné wrote: On Fri, Aug 14, 2020 at 12:27:32PM +0200, Jürgen Groß wrote: On 14.08.20 11:56, Roger Pau Monné wrote: On Fri, Aug 14, 2020 at 08:29:20AM +0100, Christoph Hellwig wrote: On Thu, Aug 13, 2020 at 09:54:20AM +0200, Roger Pau Monn?? wrote: On Thu, Aug 13

Re: [PATCH v4 2/2] xen: add helpers to allocate unpopulated memory

2020-08-14 Thread Jürgen Groß
On 14.08.20 11:56, Roger Pau Monné wrote: On Fri, Aug 14, 2020 at 08:29:20AM +0100, Christoph Hellwig wrote: On Thu, Aug 13, 2020 at 09:54:20AM +0200, Roger Pau Monn?? wrote: On Thu, Aug 13, 2020 at 08:33:37AM +0100, Christoph Hellwig wrote: On Tue, Aug 11, 2020 at 11:44:47AM +0200, Roger Pau

Re: [PATCH v2 0/5] Fixes and improvements for Xen pvdrm

2020-08-13 Thread Jürgen Groß
On 13.08.20 17:10, Oleksandr Andrushchenko wrote: On 8/13/20 6:02 PM, Jürgen Groß wrote: On 13.08.20 08:21, Oleksandr Andrushchenko wrote: From: Oleksandr Andrushchenko Series pushed to: xen/tip.git for-linus-5.9 The top patch has strange title though: "Subject: [PATCH v2 5/5] dr

Re: [PATCH v2 0/5] Fixes and improvements for Xen pvdrm

2020-08-13 Thread Jürgen Groß
On 13.08.20 08:21, Oleksandr Andrushchenko wrote: From: Oleksandr Andrushchenko Series pushed to: xen/tip.git for-linus-5.9 Juergen ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2 0/5] Fixes and improvements for Xen pvdrm

2020-08-13 Thread Jürgen Groß
On 13.08.20 08:32, Oleksandr Andrushchenko wrote: Juergen, Boris, can we please merge these via Xen Linux tree as I have collected enough Ack/R-b? The series has DRM patches, but those anyway are Xen related, so I think this should be fine from DRI point of view. Yes, fine with me. Juergen

Re: [PATCH v4 2/2] xen: add helpers to allocate unpopulated memory

2020-08-12 Thread Jürgen Groß
On 11.08.20 11:44, Roger Pau Monne wrote: To be used in order to create foreign mappings. This is based on the ZONE_DEVICE facility which is used by persistent memory devices in order to create struct pages and kernel virtual mappings for the IOMEM areas of such devices. Note that on kernels with

Re: [PATCH 2/6] drm/xen-front: Fix misused IS_ERR_OR_NULL checks

2020-08-03 Thread Jürgen Groß
On 04.08.20 08:35, Oleksandr Andrushchenko wrote: On 8/4/20 9:12 AM, Jürgen Groß wrote: On 31.07.20 14:51, Oleksandr Andrushchenko wrote: From: Oleksandr Andrushchenko The patch c575b7eeb89f: "drm/xen-front: Add support for Xen PV display frontend" from Apr 3, 2018, leads to the

Re: [PATCH 4/6] xen: Sync up with the canonical protocol definition in Xen

2020-08-03 Thread Jürgen Groß
On 31.07.20 14:51, Oleksandr Andrushchenko wrote: From: Oleksandr Andrushchenko This is the sync up with the canonical definition of the display protocol in Xen. 1. Add protocol version as an integer Version string, which is in fact an integer, is hard to handle in the code that supports diff

Re: [PATCH 2/6] drm/xen-front: Fix misused IS_ERR_OR_NULL checks

2020-08-03 Thread Jürgen Groß
On 31.07.20 14:51, Oleksandr Andrushchenko wrote: From: Oleksandr Andrushchenko The patch c575b7eeb89f: "drm/xen-front: Add support for Xen PV display frontend" from Apr 3, 2018, leads to the following static checker warning: drivers/gpu/drm/xen/xen_drm_front_gem.c:140 xen_drm_front_ge

Re: [PATCH 1/6] xen/gntdev: Fix dmabuf import with non-zero sgt offset

2020-08-03 Thread Jürgen Groß
On 31.07.20 14:51, Oleksandr Andrushchenko wrote: From: Oleksandr Andrushchenko It is possible that the scatter-gather table during dmabuf import has non-zero offset of the data, but user-space doesn't expect that. Fix this by failing the import, so user-space doesn't access wrong data. Fixes:

Re: [PATCH v3 4/4] xen: add helpers to allocate unpopulated memory

2020-07-27 Thread Jürgen Groß
On 27.07.20 11:13, Roger Pau Monne wrote: To be used in order to create foreign mappings. This is based on the ZONE_DEVICE facility which is used by persistent memory devices in order to create struct pages and kernel virtual mappings for the IOMEM areas of such devices. Note that on kernels with

Re: [PATCH v2 4/4] xen: add helpers to allocate unpopulated memory

2020-07-24 Thread Jürgen Groß
On 24.07.20 14:42, Roger Pau Monne wrote: To be used in order to create foreign mappings. This is based on the ZONE_DEVICE facility which is used by persistent memory devices in order to create struct pages and kernel virtual mappings for the IOMEM areas of such devices. Note that on kernels with

Re: [PATCH] efi: avoid error message when booting under Xen

2020-07-10 Thread Jürgen Groß
On 10.07.20 15:27, Ard Biesheuvel wrote: On Fri, 10 Jul 2020 at 13:17, Bartlomiej Zolnierkiewicz wrote: [ added EFI Maintainer & ML to Cc: ] Hi, On 7/9/20 11:17 AM, Jürgen Groß wrote: On 28.06.20 10:50, Jürgen Groß wrote: Ping? On 10.06.20 16:10, Juergen Gross wrote: efifb_probe()

Re: [PATCH] efi: avoid error message when booting under Xen

2020-07-09 Thread Jürgen Groß
On 28.06.20 10:50, Jürgen Groß wrote: Ping? On 10.06.20 16:10, Juergen Gross wrote: efifb_probe() will issue an error message in case the kernel is booted as Xen dom0 from UEFI as EFI_MEMMAP won't be set in this case. Avoid that message by calling efi_mem_desc_lookup() only if EFI_PAR

Re: [PATCH] efi: avoid error message when booting under Xen

2020-06-28 Thread Jürgen Groß
Ping? On 10.06.20 16:10, Juergen Gross wrote: efifb_probe() will issue an error message in case the kernel is booted as Xen dom0 from UEFI as EFI_MEMMAP won't be set in this case. Avoid that message by calling efi_mem_desc_lookup() only if EFI_PARAVIRT isn't set. Fixes: 38ac0287b7f4 ("fbdev/efi

Re: [PATCH v5 27/38] xen: gntdev: fix common struct sg_table related issues

2020-05-17 Thread Jürgen Groß
On 13.05.20 15:32, Marek Szyprowski wrote: The Documentation/DMA-API-HOWTO.txt states that the dma_map_sg() function returns the number of the created entries in the DMA address space. However the subsequent calls to the dma_sync_sg_for_{device,cpu}() and dma_unmap_sg must be called with the orig

Re: [PATCH 13/15] xen/gntdev-dmabuf: Ditch dummy map functions

2019-11-18 Thread Jürgen Groß
On 18.11.19 11:35, Daniel Vetter wrote: There's no in-kernel users for the k(un)map stuff. And the mmap one is actively harmful - return 0 and then _not_ actually mmaping can't end well. Signed-off-by: Daniel Vetter Cc: Boris Ostrovsky Cc: Juergen Gross Cc: Stefano Stabellini Cc: xen-de...@l

Re: [PATCH v2 08/15] xen/gntdev: Use select for DMA_SHARED_BUFFER

2019-11-07 Thread Jürgen Groß
On 28.10.19 21:10, Jason Gunthorpe wrote: From: Jason Gunthorpe DMA_SHARED_BUFFER can not be enabled by the user (it represents a library set in the kernel). The kconfig convention is to use select for such symbols so they are turned on implicitly when the user enables a kconfig that needs them

Re: [PATCH v2 08/15] xen/gntdev: Use select for DMA_SHARED_BUFFER

2019-11-05 Thread Jürgen Groß
On 01.11.19 19:26, Jason Gunthorpe wrote: On Mon, Oct 28, 2019 at 05:10:25PM -0300, Jason Gunthorpe wrote: From: Jason Gunthorpe DMA_SHARED_BUFFER can not be enabled by the user (it represents a library set in the kernel). The kconfig convention is to use select for such symbols so they are tu

Re: [PATCH hmm 08/15] xen/gntdev: Use select for DMA_SHARED_BUFFER

2019-10-16 Thread Jürgen Groß
On 15.10.19 20:12, Jason Gunthorpe wrote: From: Jason Gunthorpe DMA_SHARED_BUFFER can not be enabled by the user (it represents a library set in the kernel). The kconfig convention is to use select for such symbols so they are turned on implicitly when the user enables a kconfig that needs them