Re: [PATCH v1] drm/amd/powerplay: Fix NULL dereference in lock_bus() on Vega20 w/o RAS

2020-06-26 Thread Ivan Mironov
Issue still reproduces on latest 5.8.0-rc2+ (8be3a53e18e0e1a98f288f6c7f5e9da3adbe9c49). ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH v1] drm/amd/powerplay: Fix NULL dereference in lock_bus() on Vega20 w/o RAS

2020-06-26 Thread Ivan Mironov
ny sense when there is no HW support. Cc: sta...@vger.kernel.org Fixes: 9015d60c9ee1 ("drm/amdgpu: Move EEPROM I2C adapter to amdgpu_device") Signed-off-by: Ivan Mironov Tested-by: Bjorn Nostvold --- Changelog: v1: - Added "Tested-by" for another user who used this pa

[PATCH] drm/amd/powerplay: Fix NULL dereference in lock_bus() on Vega20 w/o RAS

2020-06-17 Thread Ivan Mironov
ny sense when there is no HW support. Cc: sta...@vger.kernel.org Fixes: 9015d60c9ee1 ("drm/amdgpu: Move EEPROM I2C adapter to amdgpu_device") Signed-off-by: Ivan Mironov --- drivers/gpu/drm/amd/powerplay/smumgr/vega20_smumgr.c | 11 +++ 1 file changed, 7 insertions(+), 4

Re: [PATCH v2 2/2] drm/fb-helper: Ignore the value of fb_var_screeninfo.pixclock

2019-01-11 Thread Ivan Mironov
On Wed, 2019-01-09 at 15:52 +, Sasha Levin wrote: > Hi, > > [This is an automated email] > > This commit has been processed because it contains a "Fixes:" tag, > fixing commit: 79e539453b34 DRM: i915: add mode setting support. > > The bot has tested the following trees: v4.20.0, v4.19.13, v4

[PATCH v2 2/2] drm/fb-helper: Ignore the value of fb_var_screeninfo.pixclock

2019-01-08 Thread Ivan Mironov
with[2], remove /etc/fb.modes file if it exists, and then try to run sopwith from console without X. At least in Fedora 29, sopwith may be simply installed from standard repositories. [1] SDL 1.2.15 source code, src/video/fbcon/SDL_fbvideo.c, vesa_timings [2] http://sdl-sopwith.sourceforge.net/ Signed-

[PATCH v2 1/2] drm/fb-helper: Partially bring back workaround for bugs of SDL 1.2

2019-01-08 Thread Ivan Mironov
src/video/fbcon/SDL_fbvideo.c, FB_SetVideoMode() [2] http://www.fceux.com [3] Example ROM: https://github.com/bokuweb/rustynes/blob/master/roms/color_test.nes Reported-by: saahriktu Suggested-by: saahriktu Cc: sta...@vger.kernel.org Fixes: db05c48197759 ("drm: fb-helper: Reject all pixel format chang

Re: [PATCH v1 1/2] drm/fb-helper: Bring back workaround for bugs of SDL 1.2

2019-01-08 Thread Ivan Mironov
On Mon, 2019-01-07 at 11:08 +0100, Daniel Vetter wrote: > > > > @@ -1654,6 +1712,40 @@ int drm_fb_helper_check_var(struct > > > > fb_var_screeninfo *var, > > > > return -EINVAL; > > > > } > > > > > > > > + /* > > > > +* Workaround for SDL 1.2, which is known

Re: [PATCH v1 2/2] drm/fb-helper: Ignore the value of fb_var_screeninfo.pixclock

2019-01-07 Thread Ivan Mironov
On Fri, 2018-12-28 at 13:06 +0100, Daniel Vetter wrote: > On Fri, Dec 28, 2018 at 04:13:08AM +0500, Ivan Mironov wrote: > > Strict requirement of pixclock to be zero breaks support of SDL 1.2 > > which contains hardcoded table of supported video modes with non-zero > &

Re: [PATCH v1 1/2] drm/fb-helper: Bring back workaround for bugs of SDL 1.2

2019-01-07 Thread Ivan Mironov
On Fri, 2018-12-28 at 13:15 +0100, Daniel Vetter wrote: > On Fri, Dec 28, 2018 at 04:13:07AM +0500, Ivan Mironov wrote: > > SDL 1.2 sets all fields related to the pixel format to zero in some > > cases[1]. Prior to commit db05c48197759 ("drm: fb-helper: Reject all >

Re: [RFC PATCH 1/2] drm/fb-helper: Bring back workaround for bugs of SDL 1.2

2018-12-27 Thread Ivan Mironov
On Thu, 2018-12-27 at 13:00 +0100, Daniel Vetter wrote: > > + /* > > +* Workaround for SDL 1.2, which is known to be setting all pixel format > > +* fields values to zero in some cases. We treat this situation as a > > +* kind of "use some reasonable autodetected values". > > +*/

[PATCH v1 1/2] drm/fb-helper: Bring back workaround for bugs of SDL 1.2

2018-12-27 Thread Ivan Mironov
src/video/fbcon/SDL_fbvideo.c, FB_SetVideoMode() [2] http://www.fceux.com [3] Example ROM: https://github.com/bokuweb/rustynes/blob/master/roms/color_test.nes Reported-by: saahriktu Suggested-by: saahriktu Cc: sta...@vger.kernel.org Fixes: db05c48197759 ("drm: fb-helper: Reject all pixel format chang

[PATCH v1 2/2] drm/fb-helper: Ignore the value of fb_var_screeninfo.pixclock

2018-12-27 Thread Ivan Mironov
/fbcon/SDL_fbvideo.c, vesa_timings [2] http://sdl-sopwith.sourceforge.net/ Signed-off-by: Ivan Mironov --- drivers/gpu/drm/drm_fb_helper.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c index aff576c3c4fb.

[RFC PATCH 1/2] drm/fb-helper: Bring back workaround for bugs of SDL 1.2

2018-12-26 Thread Ivan Mironov
saahriktu Suggested-by: saahriktu Fixes: db05c48197759 ("drm: fb-helper: Reject all pixel format changing requests") Signed-off-by: Ivan Mironov --- drivers/gpu/drm/drm_fb_helper.c | 146 1 file changed, 93 insertions(+), 53 deletions(-) diff --g

[RFC PATCH 2/2] drm/fb-helper: Ignore the value of fb_var_screeninfo.pixclock

2018-12-26 Thread Ivan Mironov
ported. It seems that any portable fbdev application which was not written only for one specific device working under one specific kernel version should not rely on any particular behaviour of pixclock anyway. [1] SDL 1.2.15 source code, src/video/fbcon/SDL_fbvideo.c, vesa_timings Signed-off-by: Iv

[RFC PATCH 0/2] Fix SDL 1.2 on emulated fbdev devices (broken in kernels >=4.19)

2018-12-26 Thread Ivan Mironov
positories. [1] http://sdl-sopwith.sourceforge.net/ Ivan Mironov (2): drm/fb-helper: Bring back workaround for bugs of SDL 1.2 drm/fb-helper: Ignore the value of fb_var_screeninfo.pixclock drivers/gpu/drm/drm_fb_helper.c | 153 +--- 1 file changed, 99 inserti