[PATCH libdrm] meson: do not use cairo/valgrind if disabled

2018-02-19 Thread Igor Gnatenko
om Signed-off-by: Igor Gnatenko --- meson.build | 24 ++-- 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/meson.build b/meson.build index 166559e8..7f786a8c 100644 --- a/meson.build +++ b/meson.build @@ -32,8 +32,6 @@ pkg = import('pkgconfig') with_ude

Re: [PATCH libdrm] meson: do not use cairo/valgrind if disabled

2018-02-19 Thread Igor Gnatenko
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On Mon, 2018-02-19 at 12:15 +, Eric Engestrom wrote: > On Sunday, 2018-02-18 14:00:50 +0100, Igor Gnatenko wrote: > > -Dcairo-tests=false currently results into enabling cairo support if it > > was found. Same for valgrind. >

[PATCH libdrm] meson: do not use cairo/valgrind if disabled

2018-02-19 Thread Igor Gnatenko
-Dcairo-tests=false currently results into enabling cairo support if it was found. Same for valgrind. v2: * Use underscore-prefixed variables to not change type of variable * Use empty array for "fake" dependency instead of real empty object Signed-off-by: Igor Gnatenko --- meson.

[PATCH libdrm] meson: do not use cairo/valgrind if disabled

2018-02-18 Thread Igor Gnatenko
-Dcairo-tests=false currently results into enabling cairo support if it was found. Same for valgrind. Signed-off-by: Igor Gnatenko --- meson.build | 20 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/meson.build b/meson.build index 166559e8..695f89b3 100644

Re: [Mesa-dev] [PATCH v4 1/3] Add meson build system

2018-01-04 Thread Igor Gnatenko
. Builds fine on all architectures supported by Fedora, boots fine on my laptop (x86_64). All nitpicks are inline. > Signed-off-by: Dylan Baker Reviewed-and-tested-by: Igor Gnatenko > diff --git a/meson_options.txt b/meson_options.txt > new file mode 100644 > index 000..08

Re: [Mesa-dev] [PATCH 1/3] Add meson build system

2018-01-03 Thread Igor Gnatenko
ombo', value : 'false', choices : ['true', > 'false', 'auto']) > +option('vc4', type : 'combo', value : 'auto', choices : ['true', > 'false', 'auto']) > +option('etnaviv&#

[PATCH v3] ACPI / video: Add systems that should favor native backlight interface

2014-01-18 Thread Igor Gnatenko
51231 Thinkpad X230: Reported-and-tested-by: Igor Gnatenko Reference: https://bugzilla.kernel.org/show_bug.cgi?id=51231 ThinkPad X1 Carbon: Reported-and-tested-by: Igor Gnatenko Lenovo Yoga 13: Reported-by: Lennart Poettering Reported-and-tested-by: Kevin Smith Reference: https://bugzilla.kerne

[PATCH v2 rebased] ACPI / video: Add systems that should favor native backlight interface

2013-12-24 Thread Igor Gnatenko
Hi, add some updates to the patch ;) On Thu, 2013-11-21 at 13:29 +0800, Aaron Lu wrote: > On 11/21/2013 04:56 AM, Igor Gnatenko wrote: > > Any news here? If no - I think we need re-send patch as new.. > > Since the v2 patch can't apply cleanly on top of pm's -next tre

[PATCH v2 rebased] ACPI / video: Add systems that should favor native backlight interface

2013-12-24 Thread Igor Gnatenko
Hi, please add some updates ;) On Thu, 2013-11-21 at 13:29 +0800, Aaron Lu wrote: > On 11/21/2013 04:56 AM, Igor Gnatenko wrote: > > Any news here? If no - I think we need re-send patch as new.. > > Since the v2 patch can't apply cleanly on top of pm's -next tree, I >

[PATCH v2] ACPI / video: Add systems that should favor native backlight interface

2013-11-21 Thread Igor Gnatenko
ported-and-tested-by: Peter Weber > Reference: https://bugzilla.kernel.org/show_bug.cgi?id=51231 > Thinkpad X230: > Reported-and-tested-by: Igor Gnatenko > Reference: https://bugzilla.kernel.org/show_bug.cgi?id=51231 > Lenovo Yoga 13: > Reported-by: Lennart Poettering > Reported-and-tes

[PATCH v5 0/4] Fix Win8 backlight issue

2013-10-25 Thread Igor Gnatenko
> > I've added this series to my queue for 3.13. > > > > Since the next step will be to introduce a list of systems that need > > video.use_native_backlight=1 *and* don't break in that configuration, I > > don't > > see much point adding

Re: [PATCH v5 0/4] Fix Win8 backlight issue

2013-10-12 Thread Igor Gnatenko
; > Of course, distro kernels may always change the default to true if they > > > want. > > > > They can, but they'd need to either patch the kernel to do so, or code > > it in userspace bootloader configs. Having a config option they can > > set to chan

Re: [PATCH v5 0/4] Fix Win8 backlight issue

2013-10-12 Thread Igor Gnatenko
issue impact > far more people? Shouldn't it be defaulted to true? > > If nothing else, can you add a config option for the default so > distros can use that to decide which way to default it and then work > on fixing the remaining users that have troubles? > > josh I

Re: [PATCH v3 0/4] Fix Win8 backlight issue

2013-09-25 Thread Igor Gnatenko
4 + > 7 files changed, 324 insertions(+), 205 deletions(-) > Excellent! I've tested this patch-set on ThinkPad X230 and backlight issue is exhausted. Thanks. -- Igor Gnatenko Fedora release 20 (Heisenbug) Linux 3.11.1-300.fc20.x86_64 ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2 0/3] Fix Win8 backlight issue

2013-09-23 Thread Igor Gnatenko
On Sun, 2013-09-22 at 17:10 +0800, Aaron Lu wrote: > On 09/18/2013 08:36 PM, Igor Gnatenko wrote: > > On Wed, 2013-09-18 at 20:31 +0800, Aaron Lu wrote: > >> On 09/18/2013 02:30 PM, Igor Gnatenko wrote: > >>> On Wed, 2013-09-18 at 09:03 +0800, Aaron Lu wrote: >

Re: [PATCH v2 0/3] Fix Win8 backlight issue

2013-09-19 Thread Igor Gnatenko
On Wed, 2013-09-18 at 20:31 +0800, Aaron Lu wrote: > On 09/18/2013 02:30 PM, Igor Gnatenko wrote: > > On Wed, 2013-09-18 at 09:03 +0800, Aaron Lu wrote: > >> On 09/17/2013 09:34 PM, Igor Gnatenko wrote: > >>> > >>> Aaron, how about fix indicator on ThinkPa

Re: [PATCH v2 0/3] Fix Win8 backlight issue

2013-09-18 Thread Igor Gnatenko
On Wed, 2013-09-18 at 09:03 +0800, Aaron Lu wrote: > On 09/17/2013 09:34 PM, Igor Gnatenko wrote: > > On Tue, 2013-09-17 at 17:23 +0800, Aaron Lu wrote: > >> v1 has the subject of "Rework ACPI video driver" and is posted here: > >> http://lkml.org/lkml/20

Re: [PATCH v2 1/3] backlight: introduce backlight_device_registered

2013-09-17 Thread Igor Gnatenko
face created by i915) is available and then do > things accordingly(e.g. avoid register its own on Win8 systems). > > Signed-off-by: Aaron Lu Tested-by: Igor Gnatenko > --- > drivers/video/backlight/backlight.c | 31 +++ > include/linux/backlight.h

Re: [PATCH v2 0/3] Fix Win8 backlight issue

2013-09-17 Thread Igor Gnatenko
5 +- > drivers/acpi/video.c| 442 > > drivers/acpi/video_detect.c | 14 +- > drivers/video/backlight/backlight.c | 31 +++ > include/acpi/video.h| 2 + > include/linux/backlight.h |

Re: [PATCH v2 3/3] ACPI / video: Do not register backlight if win8 and native interface exists

2013-09-17 Thread Igor Gnatenko
ous work done by Matthew Garrett, > Chun-Yi Lee, Seth Forshee and Rafael J. Wysocki. > > Signed-off-by: Aaron Lu Tested-by: Igor Gnatenko > --- > drivers/acpi/internal.h | 5 ++--- > drivers/acpi/video.c| 27 +-- > drivers/acpi/video

Re: [PATCH v2 2/3] ACPI / video: seperate backlight control and event interface

2013-09-17 Thread Igor Gnatenko
ty without affecting the other one. > > APIs to selectively remove backlight control interface and/or event > delivery functionality can be easily added once needed. > > Signed-off-by: Aaron Lu Tested-by: Igor Gnatenko > --- > drivers/acpi/video.c | 451 > ++

Re: [PATCH 2/2] ACPI / video / i915: Remove ACPI backlight if firmware expects Windows 8

2013-09-11 Thread Igor Gnatenko
s of Matthew Garrett, > Chun-Yi Lee and Seth Forshee and is heavily based on two patches > from Rafael: > https://lkml.org/lkml/2013/7/17/720 > https://lkml.org/lkml/2013/7/24/806 > > Signed-off-by: Aaron Lu Tested-by: Igor Gnatenko > --- > drivers/acpi/internal.h

Re: [PATCH 1/2] ACPI / video: seperate backlight control and event interface

2013-09-11 Thread Igor Gnatenko
eo devices belonging to stored video buses. > > Currently, there is no need to unregister ACPI video's event delivery > functionality alone so the function acpi_video_remove_notify_handler is > not introduced, it can be easily added when needed. > > Signed-off-by: Aaron Lu Te

Re: [PATCH 2/2] ACPI / video / i915: Remove ACPI backlight if firmware expects Windows 8

2013-09-11 Thread Igor Gnatenko
On Tue, 2013-09-10 at 13:16 +0800, Aaron Lu wrote: > On 09/10/2013 01:13 PM, Igor Gnatenko wrote: > > On Tue, 2013-09-10 at 11:27 +0800, Aaron Lu wrote: > >> On 09/09/2013 07:44 PM, Igor Gnatenko wrote: > >>> On Mon, 2013-09-09 at 16:42 +0800, Aaron Lu wrote: >

Re: [PATCH 2/2] ACPI / video / i915: Remove ACPI backlight if firmware expects Windows 8

2013-09-11 Thread Igor Gnatenko
On Tue, 2013-09-10 at 11:27 +0800, Aaron Lu wrote: > On 09/09/2013 07:44 PM, Igor Gnatenko wrote: > > On Mon, 2013-09-09 at 16:42 +0800, Aaron Lu wrote: > >> diff --git a/drivers/gpu/drm/i915/i915_dma.c > >> b/drivers/gpu/drm/i915/i915_dma.c > >> index f46698

Re: [PATCH 2/2] ACPI / video / i915: Remove ACPI backlight if firmware expects Windows 8

2013-09-09 Thread Igor Gnatenko
gpu/drm] Error 2 DEBUG: make[1]: *** [drivers/gpu] Error 2 DEBUG: make: *** [drivers] Error 2 -- Igor Gnatenko Fedora release 20 (Heisenbug) Linux 3.11.0-3.fc20.x86_64 ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [Update][PATCH 0/3] Fix backlight issues on some Windows 8 systems

2013-08-01 Thread Igor Gnatenko
gt; (that may take a while) and flip the defailt for that option to set when > we > think we're ready. > (4) If there still are problem reports, flip the default back to unset and > repeat (3). > > If this converges, everyone will be using the native backligh

[Update][PATCH 0/3] Fix backlight issues on some Windows 8 systems

2013-07-31 Thread Igor Gnatenko
gt; (that may take a while) and flip the defailt for that option to set when > we > think we're ready. > (4) If there still are problem reports, flip the default back to unset and > repeat (3). > > If this converges, everyone will be using the native backlight control by > default and the original problem will go away automatically. > > Thoughts? > > Rafael > > Good idea. I have 3-4 laptops with this problem. I can test, but I don't have devices, on which found regressions (in backlight) in previous patch. -- Igor Gnatenko Fedora release 19 (Schr?dinger?s Cat) Linux 3.10.3-300.fc19.x86_64

[PATCH 2/3] ACPI / video: Always call acpi_video_init_brightness() on init

2013-07-18 Thread Igor Gnatenko
ed by acpi_video_init_brightness() if we are not going to use it.] Signed-off-by: Matthew Garrett Signed-off-by: Rafael J. Wysocki Tested-by: Igor Gnatenko --- drivers/acpi/video.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) Index: linux-pm/drivers/acpi/vi

[PATCH 1/3] ACPICA: expose OSI version

2013-07-18 Thread Igor Gnatenko
an earlier patch from Seth Forshee. [rjw: Changelog] Signed-off-by: Aaron Lu Signed-off-by: Rafael J. Wysocki Tested-by: Igor Gnatenko --- drivers/acpi/acpica/aclocal.h | 13 - include/acpi/acpixf.h | 1 + include/acpi/actypes.h| 15 +++ 3 files changed

Re: [PATCH 2/3] ACPI / video: Always call acpi_video_init_brightness() on init

2013-07-17 Thread Igor Gnatenko
ed by acpi_video_init_brightness() if we are not going to use it.] Signed-off-by: Matthew Garrett Signed-off-by: Rafael J. Wysocki Tested-by: Igor Gnatenko --- drivers/acpi/video.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) Index: linux-pm/drivers/acpi/vi

Re: [PATCH 1/3] ACPICA: expose OSI version

2013-07-17 Thread Igor Gnatenko
an earlier patch from Seth Forshee. [rjw: Changelog] Signed-off-by: Aaron Lu Signed-off-by: Rafael J. Wysocki Tested-by: Igor Gnatenko --- drivers/acpi/acpica/aclocal.h | 13 - include/acpi/acpixf.h | 1 + include/acpi/actypes.h| 15 +++ 3 files changed

Re: [Update][PATCH] ACPI / video / i915: Remove ACPI backlight if firmware expects Windows 8

2013-07-17 Thread Igor Gnatenko
On Wed, 2013-07-17 at 13:38 +0200, Rafael J. Wysocki wrote: > On Wednesday, July 17, 2013 09:16:38 AM Igor Gnatenko wrote: > > On Wed, 2013-07-17 at 00:01 +0200, Rafael J. Wysocki wrote: > > > On Tuesday, July 16, 2013 05:08:16 PM Matthew Garrett wrote: > > > > On

[Update][PATCH] ACPI / video / i915: Remove ACPI backlight if firmware expects Windows 8

2013-07-17 Thread Igor Gnatenko
On Wed, 2013-07-17 at 13:38 +0200, Rafael J. Wysocki wrote: > On Wednesday, July 17, 2013 09:16:38 AM Igor Gnatenko wrote: > > On Wed, 2013-07-17 at 00:01 +0200, Rafael J. Wysocki wrote: > > > On Tuesday, July 16, 2013 05:08:16 PM Matthew Garrett wrote: > > > > On

[Update][PATCH] ACPI / video / i915: Remove ACPI backlight if firmware expects Windows 8

2013-07-17 Thread Igor Gnatenko
On Wed, 2013-07-17 at 00:01 +0200, Rafael J. Wysocki wrote: > On Tuesday, July 16, 2013 05:08:16 PM Matthew Garrett wrote: > > On Tue, 2013-07-16 at 17:32 +0400, Igor Gnatenko wrote: > > > Hmm. I found regression in user-space. In GNOME (maybe and other DEs) we > > >

Re: [Update][PATCH] ACPI / video / i915: Remove ACPI backlight if firmware expects Windows 8

2013-07-17 Thread Igor Gnatenko
On Wed, 2013-07-17 at 00:01 +0200, Rafael J. Wysocki wrote: > On Tuesday, July 16, 2013 05:08:16 PM Matthew Garrett wrote: > > On Tue, 2013-07-16 at 17:32 +0400, Igor Gnatenko wrote: > > > Hmm. I found regression in user-space. In GNOME (maybe and other DEs) we > > >

Re: [Update][PATCH] ACPI / video / i915: Remove ACPI backlight if firmware expects Windows 8

2013-07-17 Thread Igor Gnatenko
Hmm. I found regression in user-space. In GNOME (maybe and other DEs) we no longer see switch status of backlight. -- Igor Gnatenko Fedora release 19 (Schrödinger’s Cat) Linux 3.11.0-0.rc0.git7.1.fc20.x86_64 ___ dri-devel mailing list dri-devel

Re: [Update][PATCH] ACPI / video / i915: Remove ACPI backlight if firmware expects Windows 8

2013-07-17 Thread Igor Gnatenko
On Tue, 2013-07-16 at 01:53 +0200, Rafael J. Wysocki wrote: > On Monday, July 15, 2013 05:06:09 PM Igor Gnatenko wrote: > > On Sat, 2013-07-13 at 02:46 +0200, Rafael J. Wysocki wrote: > > [...] > > > > > I can't build it. Where did I go wrong? > > Prob

[Update][PATCH] ACPI / video / i915: Remove ACPI backlight if firmware expects Windows 8

2013-07-16 Thread Igor Gnatenko
Hmm. I found regression in user-space. In GNOME (maybe and other DEs) we no longer see switch status of backlight. -- Igor Gnatenko Fedora release 19 (Schr?dinger?s Cat) Linux 3.11.0-0.rc0.git7.1.fc20.x86_64

[Update][PATCH] ACPI / video / i915: Remove ACPI backlight if firmware expects Windows 8

2013-07-16 Thread Igor Gnatenko
On Tue, 2013-07-16 at 01:53 +0200, Rafael J. Wysocki wrote: > On Monday, July 15, 2013 05:06:09 PM Igor Gnatenko wrote: > > On Sat, 2013-07-13 at 02:46 +0200, Rafael J. Wysocki wrote: > > [...] > > > > > I can't build it. Where did I go wrong? > > Prob

Re: [Update][PATCH] ACPI / video / i915: Remove ACPI backlight if firmware expects Windows 8

2013-07-15 Thread Igor Gnatenko
:41:0: drivers/acpi/internal.h:174:60: note: previous definition of 'acpi_video_backlight_quirks' was here static inline bool acpi_video_backlight_quirks(void) { return false; } ^ drivers/acpi/video_dete

[Update][PATCH] ACPI / video / i915: Remove ACPI backlight if firmware expects Windows 8

2013-07-15 Thread Igor Gnatenko
:41:0: drivers/acpi/internal.h:174:60: note: previous definition of 'acpi_video_backlight_quirks' was here static inline bool acpi_video_backlight_quirks(void) { return false; } ^ drivers/acpi/video_detect.c: In function 'acpi_video_backlight_quirks': drivers/acpi/video_detect.c:241:6: error: 'acpi_gbl_osi_data' undeclared (first use in this function) if (acpi_gbl_osi_data >= ACPI_OSI_WIN_8) { ^ drivers/acpi/video_detect.c:241:6: note: each undeclared identifier is reported only once for each function it appears in drivers/acpi/video_detect.c:241:27: error: 'ACPI_OSI_WIN_8' undeclared (first use in this function) if (acpi_gbl_osi_data >= ACPI_OSI_WIN_8) { ^ drivers/acpi/video_detect.c: At top level: drivers/acpi/video_detect.c:295:6: error: redefinition of 'acpi_video_verify_backlight_support' bool acpi_video_verify_backlight_support(void) ^ In file included from drivers/acpi/video_detect.c:41:0: drivers/acpi/internal.h:175:60: note: previous definition of 'acpi_video_verify_backlight_support' was here static inline bool acpi_video_verify_backlight_support(void) { return false; } ^ -- Igor Gnatenko Fedora release 19 (Schr?dinger?s Cat) Linux 3.9.9-302.fc19.x86_64