Re: [PATCH v4 1/2] dt-bindings: arm: mediatek: Add MT8186 Ponyta Chromebook

2024-09-06 Thread Hsin-Yi Wang
On Fri, Sep 6, 2024 at 1:57 AM Jianeng Ceng wrote: > > Ponyta is a custom label Chromebook based on MT8186. It is a > self-developed project of Huaqin and has no fixed OEM. > > Signed-off-by: Jianeng Ceng > --- > Changes in v4: > - PATCH 1/2: Add more info for Ponyta custom label in commit. > - L

[PATCH] drm/panel-edp: Add BOE NV140WUM-N41

2024-07-10 Thread Hsin-Yi Wang
20 00 00 00 fe 00 42 4f 45 20 43 51 0a 20 20 20 20 20 20 00 00 00 fe 00 4e 56 31 34 30 57 55 4d 2d 4e 34 31 0a 00 26 Signed-off-by: Hsin-Yi Wang --- drivers/gpu/drm/panel/panel-edp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel

Re: [PATCH] drm/panel-edp: Add ID for KD KD116N09-30NH-A016

2024-05-02 Thread Hsin-Yi Wang
55901018 > > 00fe > 004b443131364e3039333041313600f6 > > We use the ASCII string from decoding the EDID ("KD116N0930A16") as > the panel name. > > Signed-off-by: Douglas Anderson Reviewed

Re: [PATCH v1 2/2] drm/panel: kd101ne3: add new panel driver

2024-04-24 Thread Hsin-Yi Wang
4 at 01:41:59PM -0700, Doug Anderson wrote: > > > > Hi, > > > > > > > > On Tue, Apr 23, 2024 at 11:10 AM Hsin-Yi Wang wrote: > > > > > > > > > > > > > > +#define _INIT_DCS_CMD(...) { \ > > > > > > &g

Re: [PATCH v1 2/2] drm/panel: kd101ne3: add new panel driver

2024-04-24 Thread Hsin-Yi Wang
On Wed, Apr 24, 2024 at 2:05 PM Doug Anderson wrote: > > Hi, > > On Tue, Apr 23, 2024 at 2:20 PM Dmitry Baryshkov > wrote: > > > > On Tue, Apr 23, 2024 at 01:41:59PM -0700, Doug Anderson wrote: > > > Hi, > > > > > >

Re: [PATCH v1 2/2] drm/panel: kd101ne3: add new panel driver

2024-04-23 Thread Hsin-Yi Wang
On Thu, Apr 18, 2024 at 7:11 AM Dmitry Baryshkov wrote: > > On Thu, Apr 18, 2024 at 09:11:37PM +0800, Hsin-Yi Wang wrote: > > On Thu, Apr 18, 2024 at 7:46 PM Dmitry Baryshkov > > wrote: > > > > > > On Thu, Apr 18, 2024 at 04:15:48PM +0800, lvzhaoxiong wro

Re: [PATCH v1 2/2] drm/panel: kd101ne3: add new panel driver

2024-04-18 Thread Hsin-Yi Wang
On Thu, Apr 18, 2024 at 7:46 PM Dmitry Baryshkov wrote: > > On Thu, Apr 18, 2024 at 04:15:48PM +0800, lvzhaoxiong wrote: > > The kingdisplay panel is based on JD9365DA controller. > > Add a driver for it. > > > > Signed-off-by: lvzhaoxiong > > --- > > drivers/gpu/drm/panel/Kconfig

Re: [PATCH 3/3] drm-panel: If drm_panel_dp_aux_backlight() fails, don't fail panel probe

2024-03-25 Thread Hsin-Yi Wang
20 I tested) is > better than having no panel at all. > > Signed-off-by: Douglas Anderson Reviewed-by: Hsin-Yi Wang > --- > If needed, I could split this into two patches: one for each of the > two panels that use drm_panel_dp_aux_backlight(). Since they both go > through

Re: [PATCH 2/3] drm/panel-edp: If we fail to powerup/get EDID, use conservative timings

2024-03-25 Thread Hsin-Yi Wang
some sense. > - It turns out that this makes panel-edp behave more similarly for > users of the generic "edp-panel" compatible string and the old fixed > panel compatible string. With the old fixed panel compatible string > we don't talk to the panel during probe

Re: [PATCH 1/3] drm/panel-edp: Abstract out function to set conservative timings

2024-03-25 Thread Hsin-Yi Wang
for > setting these timings so it can be used in future patches. > > No functional change expected--just code movement. > > Signed-off-by: Douglas Anderson Reviewed-by: Hsin-Yi Wang > --- > > drivers/gpu/drm/panel/panel-edp.c | 40 +++---

Re: [PATCH v6 2/5] drm/edid: Add a function to match EDID with identity

2024-03-08 Thread Hsin-Yi Wang
On Fri, Mar 8, 2024 at 12:07 AM Jani Nikula wrote: > > On Thu, 07 Mar 2024, Hsin-Yi Wang wrote: > > Create a type drm_edid_ident as the identity of an EDID. Currently it > > contains panel id and monitor name. > > > > Create a function that can match a given EDID

[PATCH v6 2/5] drm/edid: Add a function to match EDID with identity

2024-03-07 Thread Hsin-Yi Wang
locks. Note that some panel vendors put the monitor name after EDID_DETAIL_MONITOR_STRING. Signed-off-by: Hsin-Yi Wang --- v5->v6: finalize the trailing white space and/or NUL decision: Allow only white space before \n. --- drivers/gpu/drm/drm_edi

[PATCH v6 4/5] drm/panel-edp: Match edp_panels with panel identity

2024-03-07 Thread Hsin-Yi Wang
igned-off-by: Hsin-Yi Wang Reviewed-by: Douglas Anderson --- v5->v6: add some comments. --- drivers/gpu/drm/panel/panel-edp.c | 50 +++ 1 file changed, 31 insertions(+), 19 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp

[PATCH v6 5/5] drm/panel-edp: Fix AUO 0x405c panel naming and add a variant

2024-03-07 Thread Hsin-Yi Wang
There are 2 different AUO panels using the same panel id. One of the variants requires using overridden modes to resolve glitching issue as described in commit 70e0d5550f5c ("drm/panel-edp: Add auo_b116xa3_mode"). Other variants should use the modes parsed from EDID. Signed-off-by: Hs

[PATCH v6 3/5] drm/edid: Match edid quirks with identity

2024-03-07 Thread Hsin-Yi Wang
Currently edid quirks are matched by panel id only. Modify it to match with identity so it's easier to be extended for more complex matching if required. Signed-off-by: Hsin-Yi Wang Reviewed-by: Jani Nikula Reviewed-by: Douglas Anderson --- drivers/gpu/drm/drm_edid.c | 13 ---

[PATCH v6 1/5] drm_edid: Add a function to get EDID base block

2024-03-07 Thread Hsin-Yi Wang
which is wrapped in struct drm_edid. Caller can further use it to get panel id or check if the block contains certain strings, such as panel name. Merge drm_edid_get_panel_id() and edid_extract_panel_id() into one function. Signed-off-by: Hsin-Yi Wang Reviewed-by: Douglas Anderson Reviewed-by:

[PATCH v6 0/5] Match panel with identity

2024-03-07 Thread Hsin-Yi Wang
: https://lore.kernel.org/lkml/20240306004347.974304-1-hsi...@chromium.org/ v5: https://lore.kernel.org/lkml/20240306200353.1436198-1-hsi...@chromium.org/ Hsin-Yi Wang (5): drm_edid: Add a function to get EDID base block drm/edid: Add a function to match EDID with identity drm/edid: Match

Re: [PATCH v5 6/6] drm/panel-edp: Fix AUO 0x405c panel naming and add a variant

2024-03-07 Thread Hsin-Yi Wang
On Thu, Mar 7, 2024 at 5:28 AM Jani Nikula wrote: > > On Wed, 06 Mar 2024, Doug Anderson wrote: > > Hi, > > > > On Wed, Mar 6, 2024 at 12:04 PM Hsin-Yi Wang wrote: > >> > >> @@ -1009,6 +1009,19 @@ static const struct panel_desc auo_b101ean01 = { > &

Re: [PATCH v5 3/6] drm/edid: Add a function to match EDID with identity

2024-03-07 Thread Hsin-Yi Wang
On Thu, Mar 7, 2024 at 5:20 AM Jani Nikula wrote: > > On Wed, 06 Mar 2024, Doug Anderson wrote: > > Hi, > > > > On Wed, Mar 6, 2024 at 4:20 PM Hsin-Yi Wang wrote: > >> > >> On Wed, Mar 6, 2024 at 3:30 PM Doug Anderson wrote: > >> > > &g

Re: [PATCH v5 3/6] drm/edid: Add a function to match EDID with identity

2024-03-06 Thread Hsin-Yi Wang
On Wed, Mar 6, 2024 at 3:30 PM Doug Anderson wrote: > > Hi, > > On Wed, Mar 6, 2024 at 12:04 PM Hsin-Yi Wang wrote: > > > > +static void > > +match_identity(const struct detailed_timing *timing, void *data) > > +{ > > + struct drm_edid_match_clo

[PATCH v5 5/6] drm/panel-edp: Match edp_panels with panel identity

2024-03-06 Thread Hsin-Yi Wang
igned-off-by: Hsin-Yi Wang --- v5: no change --- drivers/gpu/drm/panel/panel-edp.c | 45 --- 1 file changed, 24 insertions(+), 21 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c index fe51680feb61..772bf6011d79 100644

[PATCH v5 4/6] drm/edid: Match edid quirks with identity

2024-03-06 Thread Hsin-Yi Wang
Currently edid quirks are matched by panel id only. Modify it to match with identity so it's easier to be extended for more complex matching if required. Suggested-by: Jani Nikula Signed-off-by: Hsin-Yi Wang Reviewed-by: Jani Nikula --- v5: no change --- drivers/gpu/drm/drm_edid.c

[PATCH v5 6/6] drm/panel-edp: Fix AUO 0x405c panel naming and add a variant

2024-03-06 Thread Hsin-Yi Wang
There are 2 different AUO panels using the same panel id. One of the variants requires using overridden modes to resolve glitching issue as described in commit 70e0d5550f5c ("drm/panel-edp: Add auo_b116xa3_mode"). Other variants should use the modes parsed from EDID. Signed-off-by: Hs

[PATCH v5 3/6] drm/edid: Add a function to match EDID with identity

2024-03-06 Thread Hsin-Yi Wang
locks. Note that some panel vendors put the monitor name after EDID_DETAIL_MONITOR_STRING. Signed-off-by: Hsin-Yi Wang --- v4->v5: use strncmp, change function/variable names. --- drivers/gpu/drm/drm_edid.c | 65 ++ include/drm/drm_edid.h | 8 +

[PATCH v5 2/6] drm/edid: Clean up drm_edid_get_panel_id()

2024-03-06 Thread Hsin-Yi Wang
drm_edid_get_panel_id() now just directly call edid_extract_panel_id(). Merge them into one function. Signed-off-by: Hsin-Yi Wang --- v4->v5: new --- drivers/gpu/drm/drm_edid.c | 39 ++ 1 file changed, 18 insertions(+), 21 deletions(-) diff --git a/driv

[PATCH v5 1/6] drm_edid: Add a function to get EDID base block

2024-03-06 Thread Hsin-Yi Wang
which is wrapped in struct drm_edid. Caller can further use it to get panel id or check if the block contains certain strings, such as panel name. Signed-off-by: Hsin-Yi Wang --- v4->v5: use _drm_edid_alloc --- drivers/gpu/drm/drm_edid.c| 63 +++ drivers

[PATCH v5 0/6] Match panel with identity

2024-03-06 Thread Hsin-Yi Wang
: https://lore.kernel.org/lkml/20240306004347.974304-1-hsi...@chromium.org/ Hsin-Yi Wang (6): drm_edid: Add a function to get EDID base block drm/edid: Clean up drm_edid_get_panel_id() drm/edid: Add a function to match EDID with identity drm/edid: Match edid quirks with identity drm/panel-e

Re: [PATCH v4 2/5] drm/edid: Add a function to match EDID with identity

2024-03-06 Thread Hsin-Yi Wang
On Wed, Mar 6, 2024 at 1:17 AM Jani Nikula wrote: > > On Tue, 05 Mar 2024, Hsin-Yi Wang wrote: > > Create a type drm_edid_ident as the identity of an EDID. Currently it > > contains panel id and monitor name. > > > > Create a function that can match a given EDID and

Re: [PATCH v4 4/5] drm/panel-edp: Match edp_panels with panel identity

2024-03-06 Thread Hsin-Yi Wang
On Wed, Mar 6, 2024 at 1:23 AM Jani Nikula wrote: > > On Tue, 05 Mar 2024, Hsin-Yi Wang wrote: > > It's found that some panels have variants that they share the same panel id > > although their EDID and names are different. When matching generic edp > > panels, we

Re: [PATCH v3 2/4] drm/edid: Add a function to check monitor string

2024-03-05 Thread Hsin-Yi Wang
On Tue, Mar 5, 2024 at 11:25 AM Doug Anderson wrote: > > Hi, > > On Tue, Mar 5, 2024 at 12:17 AM Jani Nikula > wrote: > > > > On Mon, 04 Mar 2024, Doug Anderson wrote: > > > Hi, > > > > > > On Mon, Mar 4, 2024 at 4:19 PM Hsin-Yi

[PATCH v4 5/5] drm/panel-edp: Fix AUO 0x405c panel naming and add a variant

2024-03-05 Thread Hsin-Yi Wang
There are 2 different AUO panels using the same panel id. One of the variants requires using overridden modes to resolve glitching issue as described in commit 70e0d5550f5c ("drm/panel-edp: Add auo_b116xa3_mode"). Other variants should use the modes parsed from EDID. Signed-off-by: Hs

[PATCH v4 4/5] drm/panel-edp: Match edp_panels with panel identity

2024-03-05 Thread Hsin-Yi Wang
igned-off-by: Hsin-Yi Wang --- v3->v4: combine name and id to identity. --- drivers/gpu/drm/panel/panel-edp.c | 45 --- 1 file changed, 24 insertions(+), 21 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c index d094

[PATCH v4 3/5] drm/edid: Match edid quirks with identity

2024-03-05 Thread Hsin-Yi Wang
Currently edid quirks are matched by panel id only. Modify it to match with identity so it's easier to be extended for more complex matching if required. Suggested-by: Jani Nikula Signed-off-by: Hsin-Yi Wang --- v4: new Per discussion https://lore.kernel.org/lkml/87a5nd4tsg@inte

[PATCH v4 2/5] drm/edid: Add a function to match EDID with identity

2024-03-05 Thread Hsin-Yi Wang
locks. Note that some panel vendors put the monitor name after EDID_DETAIL_MONITOR_STRING. Signed-off-by: Hsin-Yi Wang --- v3->v4: 1. add a type drm_edid_ident 2. match name -> match identity. Modify function to use edid iterators. --- drivers/gpu/drm/drm_

[PATCH v4 0/5] Match panel with identity

2024-03-05 Thread Hsin-Yi Wang
for identity (id and name). If not found, fallback to match id. v1: https://lore.kernel.org/lkml/20240223223958.3887423-1-hsi...@chromium.org v2: https://lore.kernel.org/lkml/20240228011133.1238439-1-hsi...@chromium.org v3: https://lore.kernel.org/lkml/20240304195214.14563-1-hsi...@chromium.org Hsi

[PATCH v4 1/5] drm_edid: Add a function to get EDID base block

2024-03-05 Thread Hsin-Yi Wang
which is wrapped in struct drm_edid. Caller can further use it to get panel id or check if the block contains certain strings, such as panel name. Signed-off-by: Hsin-Yi Wang --- v3->v4: change drm_edid_read_base_block return type to drm_edid. --- drivers/gpu/drm/drm_edid.c

Re: [PATCH v3 2/4] drm/edid: Add a function to check monitor string

2024-03-04 Thread Hsin-Yi Wang
On Mon, Mar 4, 2024 at 4:09 PM Jani Nikula wrote: > > On Mon, 04 Mar 2024, Hsin-Yi Wang wrote: > > On Mon, Mar 4, 2024 at 12:38 PM Jani Nikula > > wrote: > >> > >> On Mon, 04 Mar 2024, Hsin-Yi Wang wrote: > >> > Add a function to chec

Re: [PATCH v3 2/4] drm/edid: Add a function to check monitor string

2024-03-04 Thread Hsin-Yi Wang
On Mon, Mar 4, 2024 at 4:09 PM Jani Nikula wrote: > > On Mon, 04 Mar 2024, Hsin-Yi Wang wrote: > > On Mon, Mar 4, 2024 at 12:38 PM Jani Nikula > > wrote: > >> > >> On Mon, 04 Mar 2024, Hsin-Yi Wang wrote: > >> > Add a function to chec

Re: [PATCH v3 2/4] drm/edid: Add a function to check monitor string

2024-03-04 Thread Hsin-Yi Wang
On Mon, Mar 4, 2024 at 12:38 PM Jani Nikula wrote: > > On Mon, 04 Mar 2024, Hsin-Yi Wang wrote: > > Add a function to check if the EDID base block contains a given string. > > > > One of the use cases is fetching panel from a list of panel names, since > > some pane

Re: [PATCH v2 3/3] drm/panel: panel-edp: Fix AUO 0x405c panel naming and add a variant

2024-03-04 Thread Hsin-Yi Wang
On Wed, Feb 28, 2024 at 4:22 PM Doug Anderson wrote: > > Hi, > > On Tue, Feb 27, 2024 at 5:11 PM Hsin-Yi Wang wrote: > > > > There are 2 different AUO panels using the same panel id. One of the > > variants requires using overridden modes to resolve glitching is

Re: [PATCH 1/2] drm_edid: Add a function to get EDID base block

2024-03-04 Thread Hsin-Yi Wang
On Mon, Mar 4, 2024 at 8:17 AM Doug Anderson wrote: > > Hi, > > On Sun, Mar 3, 2024 at 1:30 PM Dmitry Baryshkov > wrote: > > > > > The problem is that Dmitry didn't like the idea of using a hash and in > > > v2 Hsin-Yi has moved to using the name of the display. ...except of > > > course that eDP

[PATCH v3 4/4] drm/panel: panel-edp: Fix AUO 0x405c panel naming and add a variant

2024-03-04 Thread Hsin-Yi Wang
There are 2 different AUO panels using the same panel id. One of the variants requires using overridden modes to resolve glitching issue as described in commit 70e0d5550f5c ("drm/panel-edp: Add auo_b116xa3_mode"). Other variants should use the modes parsed from EDID. Signed-off-by: Hs

[PATCH v3 3/4] drm/panel: panel-edp: Match edp_panels with panel name

2024-03-04 Thread Hsin-Yi Wang
only. Signed-off-by: Hsin-Yi Wang --- v2->v3: move string matching to drm_edid --- drivers/gpu/drm/panel/panel-edp.c | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c index fc2d

[PATCH v3 1/4] drm_edid: Add a function to get EDID base block

2024-03-04 Thread Hsin-Yi Wang
which is introduced as a new type edid_base_block with the same layout as edid. Caller can further use it to get panel id or check if the block contains certain strings, such as panel name. Signed-off-by: Hsin-Yi Wang --- v2->v3: change back to return only the first block. --- drivers

[PATCH v3 2/4] drm/edid: Add a function to check monitor string

2024-03-04 Thread Hsin-Yi Wang
Add a function to check if the EDID base block contains a given string. One of the use cases is fetching panel from a list of panel names, since some panel vendors put the monitor name after EDID_DETAIL_MONITOR_STRING instead of EDID_DETAIL_MONITOR_NAME. Signed-off-by: Hsin-Yi Wang --- v2->

[PATCH v3 0/4] Match panel with id and name

2024-03-04 Thread Hsin-Yi Wang
for both name and id. If not found, fallback to match id. v1: https://lore.kernel.org/lkml/20240223223958.3887423-1-hsi...@chromium.org v2: https://lore.kernel.org/lkml/20240228011133.1238439-1-hsi...@chromium.org Hsin-Yi Wang (4): drm_edid: Add a function to get EDID base block drm/edid

Re: [PATCH v2 3/3] drm/panel: panel-edp: Fix AUO 0x405c panel naming and add a variant

2024-02-28 Thread Hsin-Yi Wang
On Wed, Feb 28, 2024 at 5:13 PM Dmitry Baryshkov wrote: > > On Thu, 29 Feb 2024 at 03:05, Hsin-Yi Wang wrote: > > > > On Wed, Feb 28, 2024 at 4:22 PM Doug Anderson wrote: > > > > > > Hi, > > > > > > On Tue, Feb 27, 2024 at 5:11 PM Hsin-Yi

Re: [PATCH v2 3/3] drm/panel: panel-edp: Fix AUO 0x405c panel naming and add a variant

2024-02-28 Thread Hsin-Yi Wang
On Wed, Feb 28, 2024 at 4:22 PM Doug Anderson wrote: > > Hi, > > On Tue, Feb 27, 2024 at 5:11 PM Hsin-Yi Wang wrote: > > > > There are 2 different AUO panels using the same panel id. One of the > > variants requires using overridden modes to resolve glitching is

Re: [PATCH v2 1/3] drm_edid: Support getting EDID through ddc without connector

2024-02-28 Thread Hsin-Yi Wang
On Wed, Feb 28, 2024 at 4:21 PM Doug Anderson wrote: > > Hi, > > On Tue, Feb 27, 2024 at 5:11 PM Hsin-Yi Wang wrote: > > > > Some panels are interested in the EDID during early probe when connector > > is still unknown. > > > > Add a function drm_g

Re: [PATCH v2 1/3] drm_edid: Support getting EDID through ddc without connector

2024-02-27 Thread Hsin-Yi Wang
On Tue, Feb 27, 2024 at 5:11 PM Hsin-Yi Wang wrote: > > Some panels are interested in the EDID during early probe when connector > is still unknown. > > Add a function drm_get_edid_no_connector() to get edid without connector. > No functional change for existing usage. > >

Re: [PATCH 1/2] drm_edid: Add a function to get EDID base block

2024-02-27 Thread Hsin-Yi Wang
On Tue, Feb 27, 2024 at 1:09 AM Jani Nikula wrote: > > On Fri, 23 Feb 2024, Hsin-Yi Wang wrote: > > It's found that some panels have variants that they share the same panel id > > although their EDID and names are different. Besides panel id, now we need > > the hash

[PATCH v2 1/3] drm_edid: Support getting EDID through ddc without connector

2024-02-27 Thread Hsin-Yi Wang
Some panels are interested in the EDID during early probe when connector is still unknown. Add a function drm_get_edid_no_connector() to get edid without connector. No functional change for existing usage. Signed-off-by: Hsin-Yi Wang --- v1->v2: add a function to return the entire edid with

[PATCH v2 2/3] drm/panel: panel-edp: Match edp_panels with panel name

2024-02-27 Thread Hsin-Yi Wang
only. Signed-off-by: Hsin-Yi Wang --- v1->v2: match with panel name instead of crc hash. Note that we can't directly use drm_edid_get_monitor_name(), because some panel store the name after EDID_DETAIL_MONITOR_STRING instead of EDID_DETAIL_MONITOR_NAME. --- drivers/gpu/drm/drm_edid.

[PATCH v2 0/3] Match panel with id and name

2024-02-27 Thread Hsin-Yi Wang
for both name and id. If not found, fallback to match id. v1: https://lore.kernel.org/lkml/20240223223958.3887423-1-hsi...@chromium.org/T/ Hsin-Yi Wang (3): drm_edid: Support getting EDID through ddc without connector drm/panel: panel-edp: Match edp_panels with panel name drm/panel: panel-

[PATCH v2 3/3] drm/panel: panel-edp: Fix AUO 0x405c panel naming and add a variant

2024-02-27 Thread Hsin-Yi Wang
There are 2 different AUO panels using the same panel id. One of the variants requires using overridden modes to resolve glitching issue as described in commit 70e0d5550f5c ("drm/panel-edp: Add auo_b116xa3_mode"). Other variants should use the modes parsed from EDID. Signed-off-by: Hs

Re: [PATCH 0/2] Match panel hash for overridden mode

2024-02-26 Thread Hsin-Yi Wang
On Mon, Feb 26, 2024 at 4:37 PM Dmitry Baryshkov wrote: > > On Sat, 24 Feb 2024 at 00:40, Hsin-Yi Wang wrote: > > > > This series is a follow up for 1a5e81de180e ("Revert "drm/panel-edp: Add > > auo_b116xa3_mode""). It's found that 2 different AU

Re: [PATCH 2/2] drm/panel: panel-edp: Match with panel hash for overridden modes

2024-02-26 Thread Hsin-Yi Wang
On Mon, Feb 26, 2024 at 2:29 PM Doug Anderson wrote: > > Hi, > > On Fri, Feb 23, 2024 at 2:40 PM Hsin-Yi Wang wrote: > > > > It's found that some panels have variants that they share the same panel id > > although their EDID and names are different. One

[PATCH 2/2] drm/panel: panel-edp: Match with panel hash for overridden modes

2024-02-23 Thread Hsin-Yi Wang
nd use the hash of the EDID to match the panel needs the overridden modes. Signed-off-by: Hsin-Yi Wang --- drivers/gpu/drm/panel/panel-edp.c | 52 +++ 1 file changed, 46 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/pa

[PATCH 1/2] drm_edid: Add a function to get EDID base block

2024-02-23 Thread Hsin-Yi Wang
r can further use it to get panel id and/or the hash. Signed-off-by: Hsin-Yi Wang --- drivers/gpu/drm/drm_edid.c| 55 +-- drivers/gpu/drm/panel/panel-edp.c | 8 +++-- include/drm/drm_edid.h| 3 +- 3 files changed, 38 insertions(+), 28 deletions(-)

[PATCH 0/2] Match panel hash for overridden mode

2024-02-23 Thread Hsin-Yi Wang
uct id match is no longer sufficient, EDP_PANEL_ENTRY2 is extended to check the crc hash of the entire edid base block. Hsin-Yi Wang (2): drm_edid: Add a function to get EDID base block drm/panel: panel-edp: Match with panel hash for overridden modes drivers/gpu/d

[PATCH] drm/mediatek: Fix a null pointer crash in mtk_drm_crtc_finish_page_flip

2024-02-23 Thread Hsin-Yi Wang
flush(), it's more efficient to just check if mtk_crtc->event is null before use. Signed-off-by: Hsin-Yi Wang Fixes: 119f5173628a ("drm/mediatek: Add DRM Driver for Mediatek SoC MT8173.") --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 12 +++- 1 file changed, 7 insertions

[PATCH] Revert "drm/panel-edp: Add auo_b116xa3_mode"

2024-02-13 Thread Hsin-Yi Wang
-by: Hsin-Yi Wang --- drivers/gpu/drm/panel/panel-edp.c | 19 ++- 1 file changed, 2 insertions(+), 17 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c index 7d556b1bfa82..bd71d239272a 100644 --- a/drivers/gpu/drm/panel/panel-edp.c

Re: [PATCH] drm/dp: Don't attempt AUX transfers when eDP panels are not powered

2024-02-13 Thread Hsin-Yi Wang
n AUX transfer code not to attempt a transfer in > this case. > > Signed-off-by: Douglas Anderson > --- Reviewed-by: Hsin-Yi Wang > > drivers/gpu/drm/display/drm_dp_helper.c | 35 +++ > drivers/gpu/drm/panel/panel-edp.c | 3 ++ > ..

[PATCH] drm/bridge: anx7625: Ensure bridge is suspended in disable()

2024-01-17 Thread Hsin-Yi Wang
nc_suspend() to suspend the bridge instead of idle with pm_runtime_put_sync(). Fixes: 3203e497eb76 ("drm/bridge: anx7625: Synchronously run runtime suspend.") Fixes: adca62ec370c ("drm/bridge: anx7625: Support reading edid through aux channel") Signed-off-by: Hsin-Yi Wang T

Re: [PATCH] drm/bridge: parade-ps8640: Make sure we drop the AUX mutex in the error case

2024-01-17 Thread Hsin-Yi Wang
mit not be there for long, if I can > get a quick Reviewed-by tag on this patch I'll land it without the > typical stewing period. > Reviewed-by: Hsin-Yi Wang > drivers/gpu/drm/bridge/parade-ps8640.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --g

[PATCH] drm/panel-edp: use put_sync in unprepare

2023-12-20 Thread Hsin-Yi Wang
uses autosuspend. Suggested-by: Douglas Anderson Fixes: 5f04e7ce392d ("drm/panel-edp: Split eDP panels out of panel-simple") Signed-off-by: Hsin-Yi Wang --- drivers/gpu/drm/panel/panel-edp.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/panel/p

Re: [PATCH v7 2/3] drm/panel-edp: Add auo_b116xa3_mode

2023-11-17 Thread Hsin-Yi Wang
On Fri, Nov 17, 2023 at 1:51 PM Hsin-Yi Wang wrote: > > Add auo_b116xa3_mode to override the original modes parsed from edid > of the panels 0x405c B116XAK01.0 and 0x615c B116XAN06.1 which result > in glitches on panel. > > Signed-off-by: Hsin-Yi Wang > --- > v6->v

Re: [PATCH v7 1/3] drm/panel-edp: Add override_edid_mode quirk for generic edp

2023-11-17 Thread Hsin-Yi Wang
On Fri, Nov 17, 2023 at 2:06 PM Greg KH wrote: > > On Fri, Nov 17, 2023 at 01:46:32PM -0800, Hsin-Yi Wang wrote: > > Generic edp gets mode from edid. However, some panels report incorrect > > mode in this way, resulting in glitches on panel. Introduce a new quirk > >

[PATCH v7 3/3] drm/panel-edp: Avoid adding multiple preferred modes

2023-11-17 Thread Hsin-Yi Wang
If a non generic edp-panel is under aux-bus, the mode read from edid would still be selected as preferred and results in multiple preferred modes, which is ambiguous. If both hard-coded mode and edid exists, only add mode from hard-coded. Signed-off-by: Hsin-Yi Wang Reviewed-by: Douglas

[PATCH v7 2/3] drm/panel-edp: Add auo_b116xa3_mode

2023-11-17 Thread Hsin-Yi Wang
Add auo_b116xa3_mode to override the original modes parsed from edid of the panels 0x405c B116XAK01.0 and 0x615c B116XAN06.1 which result in glitches on panel. Signed-off-by: Hsin-Yi Wang --- v6->v7: split usecase to another patch. --- drivers/gpu/drm/panel/panel-edp.c |

[PATCH v7 1/3] drm/panel-edp: Add override_edid_mode quirk for generic edp

2023-11-17 Thread Hsin-Yi Wang
Generic edp gets mode from edid. However, some panels report incorrect mode in this way, resulting in glitches on panel. Introduce a new quirk additional_mode to the generic edid to pick a correct hardcoded mode. Signed-off-by: Hsin-Yi Wang Reviewed-by: Douglas Anderson --- v6->v7: sp

[PATCH v7 0/3] Use correct mode for edp panel

2023-11-17 Thread Hsin-Yi Wang
/20231106210337.2900034-1-hsi...@chromium.org/ v5: https://patchwork.kernel.org/project/dri-devel/cover/2023110723.2928195-1-hsi...@chromium.org/ v6: https://lore.kernel.org/lkml/20231107204611.3082200-2-hsi...@chromium.org/ Hsin-Yi Wang (3): drm/panel-edp: Add override_edid_mode quirk for

Re: [PATCH v6 3/5] drm/panel-edp: drm/panel-edp: Add several generic edp panels

2023-11-07 Thread Hsin-Yi Wang
On Tue, Nov 7, 2023 at 12:57 PM Greg KH wrote: > > On Tue, Nov 07, 2023 at 12:41:53PM -0800, Hsin-Yi Wang wrote: > > Add a few generic edp panels used by mt8186 chromebooks. > > > > Signed-off-by: Hsin-Yi Wang > > Reviewed-by: Douglas Anderson > > --- > &g

[PATCH v6 3/5] drm/panel-edp: drm/panel-edp: Add several generic edp panels

2023-11-07 Thread Hsin-Yi Wang
Add a few generic edp panels used by mt8186 chromebooks. Signed-off-by: Hsin-Yi Wang Reviewed-by: Douglas Anderson --- no change. --- drivers/gpu/drm/panel/panel-edp.c | 51 +++ 1 file changed, 51 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-edp.c b

[PATCH v6 5/5] drm/panel-edp: Avoid adding multiple preferred modes

2023-11-07 Thread Hsin-Yi Wang
If a non generic edp-panel is under aux-bus, the mode read from edid would still be selected as preferred and results in multiple preferred modes, which is ambiguous. If both hard-coded mode and edid exists, only add mode from hard-coded. Signed-off-by: Hsin-Yi Wang Reviewed-by: Douglas

[PATCH v6 4/5] drm/panel-edp: Add override_edid_mode quirk for generic edp

2023-11-07 Thread Hsin-Yi Wang
Generic edp gets mode from edid. However, some panels report incorrect mode in this way, resulting in glitches on panel. Introduce a new quirk additional_mode to the generic edid to pick a correct hardcoded mode. Signed-off-by: Hsin-Yi Wang Reviewed-by: Douglas Anderson --- no change

[PATCH v6 1/5] drm/panel-edp: drm/panel-edp: Fix AUO B116XAK01 name and timing

2023-11-07 Thread Hsin-Yi Wang
Rename AUO 0x405c B116XAK01 to B116XAK01.0 and adjust the timing of auo_b116xak01: T3=200, T12=500, T7_max = 50 according to decoding edid and datasheet. Fixes: da458286a5e2 ("drm/panel: Add support for AUO B116XAK01 panel") Cc: sta...@vger.kernel.org Signed-off-by: Hsin-Yi Wang R

[PATCH v6 2/5] drm/panel-edp: drm/panel-edp: Fix AUO B116XTN02 name

2023-11-07 Thread Hsin-Yi Wang
Rename AUO 0x235c B116XTN02 to B116XTN02.3 according to decoding edid. Fixes: 3db2420422a5 ("drm/panel-edp: Add AUO B116XTN02, BOE NT116WHM-N21,836X2, NV116WHM-N49 V8.0") Cc: sta...@vger.kernel.org Signed-off-by: Hsin-Yi Wang Reviewed-by: Douglas Anderson --- v5->v6: split

[PATCH v6 0/5] Add a few panels and use correct modes

2023-11-07 Thread Hsin-Yi Wang
/dri-devel/cover/20231106210337.2900034-1-hsi...@chromium.org/ v5: https://patchwork.kernel.org/project/dri-devel/cover/2023110723.2928195-1-hsi...@chromium.org/ Hsin-Yi Wang (5): drm/panel-edp: drm/panel-edp: Fix AUO B116XAK01 name and timing drm/panel-edp: drm/panel-edp: Fix AUO

Re: [PATCH v5 1/4] drm/panel-edp: drm/panel-edp: Fix AUO B116XTN02, B116XAK01 name and timing

2023-11-06 Thread Hsin-Yi Wang
On Mon, Nov 6, 2023 at 4:00 PM Hsin-Yi Wang wrote: > > According to decoding edid and datahseet: > - Rename AUO 0x235c B116XTN02 to B116XTN02.3 > - Rename AUO 0x405c B116XAK01 to B116XAK01.0 and adjust the timing of > auo_b116xak01: T3=200, T12=500, T7_max = 50. > > Fixe

[PATCH v5 4/4] drm/panel-edp: Avoid adding multiple preferred modes

2023-11-06 Thread Hsin-Yi Wang
If a non generic edp-panel is under aux-bus, the mode read from edid would still be selected as preferred and results in multiple preferred modes, which is ambiguous. If both hard-coded mode and edid exists, only add mode from hard-coded. Signed-off-by: Hsin-Yi Wang --- v4->v5: rem

[PATCH v5 1/4] drm/panel-edp: drm/panel-edp: Fix AUO B116XTN02, B116XAK01 name and timing

2023-11-06 Thread Hsin-Yi Wang
M-N49 V8.0") Fixes: da458286a5e2 ("drm/panel: Add support for AUO B116XAK01 panel") Signed-off-by: Hsin-Yi Wang Reviewed-by: Douglas Anderson --- v4->v5: separate fixes patch. --- drivers/gpu/drm/panel/panel-edp.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff

[PATCH v5 3/4] drm/panel-edp: Add override_edid_mode quirk for generic edp

2023-11-06 Thread Hsin-Yi Wang
Generic edp gets mode from edid. However, some panels report incorrect mode in this way, resulting in glitches on panel. Introduce a new quirk additional_mode to the generic edid to pick a correct hardcoded mode. Signed-off-by: Hsin-Yi Wang Reviewed-by: Douglas Anderson --- v4->v5: fix cod

[PATCH v5 2/4] drm/panel-edp: drm/panel-edp: Add several generic edp panels

2023-11-06 Thread Hsin-Yi Wang
Add a few generic edp panels used by mt8186 chromebooks. Signed-off-by: Hsin-Yi Wang Reviewed-by: Douglas Anderson --- v4->v5: seperate fixes patch --- drivers/gpu/drm/panel/panel-edp.c | 51 +++ 1 file changed, 51 insertions(+) diff --git a/drivers/gpu/drm/pa

[PATCH v5 0/4] Add a few panels and use correct modes

2023-11-06 Thread Hsin-Yi Wang
-hsi...@chromium.org/ Hsin-Yi Wang (4): drm/panel-edp: drm/panel-edp: Fix AUO B116XTN02, B116XAK01 name and timing drm/panel-edp: drm/panel-edp: Add several generic edp panels drm/panel-edp: Add override_edid_mode quirk for generic edp drm/panel-edp: Avoid adding multiple preferred modes

[PATCH v4 3/3] drm/panel-edp: Avoid adding multiple preferred modes

2023-11-06 Thread Hsin-Yi Wang
If a non generic edp-panel is under aux-bus, the mode read from edid would still be selected as preferred and results in multiple preferred modes, which is ambiguous. If both hard-coded mode and edid exists, only add mode from hard-coded. Signed-off-by: Hsin-Yi Wang --- v3->v4: don't s

[PATCH v4 2/3] drm/panel-edp: Add override_edid_mode quirk for generic edp

2023-11-06 Thread Hsin-Yi Wang
Generic edp gets mode from edid. However, some panels report incorrect mode in this way, resulting in glitches on panel. Introduce a new quirk additional_mode to the generic edid to pick a correct hardcoded mode. Signed-off-by: Hsin-Yi Wang Reviewed-by: Douglas Anderson --- v3->v4: no cha

[PATCH v4 1/3] drm/panel-edp: drm/panel-edp: Add several generic edp panels

2023-11-06 Thread Hsin-Yi Wang
Add a few generic edp panels used by mt8186 chromebooks. Besides, modify the following panel: - AUO 0x235c B116XTN02 renamed to B116XTN02.3. - AUO 0x405c B116XAK01 adjust the timing of auo_b116xak01. According to the datasheet: T3=200, T12=500, T7_max = 50. Signed-off-by: Hsin-Yi Wang Reviewed

[PATCH v4 0/3] Add a few panels and use correct modes

2023-11-06 Thread Hsin-Yi Wang
...@chromium.org/ v2: https://patchwork.kernel.org/project/dri-devel/cover/20231102221309.1971910-1-hsi...@chromium.org/ v3: https://patchwork.kernel.org/project/dri-devel/cover/20231106202718.2770821-1-hsi...@chromium.org/ Hsin-Yi Wang (3): drm/panel-edp: drm/panel-edp: Add several generic edp panels

Re: [PATCH v3 3/3] drm/panel-edp: Avoid adding multiple preferred modes

2023-11-06 Thread Hsin-Yi Wang
On Mon, Nov 6, 2023 at 12:33 PM Doug Anderson wrote: > > Hi, > > On Mon, Nov 6, 2023 at 12:27 PM Hsin-Yi Wang wrote: > > > > diff --git a/drivers/gpu/drm/panel/panel-edp.c > > b/drivers/gpu/drm/panel/panel-edp.c > > index 0fb439b5efb1..54dbbdf62ec0 100644 &

[PATCH v3 3/3] drm/panel-edp: Avoid adding multiple preferred modes

2023-11-06 Thread Hsin-Yi Wang
If a non generic edp-panel is under aux-bus, the mode read from edid would still be selected as preferred and results in multiple preferred modes, which is ambiguous. If both hard-coded mode and edid exists, only add mode from hard-coded. Signed-off-by: Hsin-Yi Wang --- v2->v3: if hard-co

[PATCH v3 2/3] drm/panel-edp: Add override_edid_mode quirk for generic edp

2023-11-06 Thread Hsin-Yi Wang
Generic edp gets mode from edid. However, some panels report incorrect mode in this way, resulting in glitches on panel. Introduce a new quirk additional_mode to the generic edid to pick a correct hardcoded mode. Signed-off-by: Hsin-Yi Wang Reviewed-by: Douglas Anderson --- v2->v3: no cha

[PATCH v3 1/3] drm/panel-edp: drm/panel-edp: Add several generic edp panels

2023-11-06 Thread Hsin-Yi Wang
Add a few generic edp panels used by mt8186 chromebooks. Besides, modify the following panel: - AUO 0x235c B116XTN02 renamed to B116XTN02.3. - AUO 0x405c B116XAK01 adjust the timing of auo_b116xak01. According to the datasheet: T3=200, T12=500, T7_max = 50. Signed-off-by: Hsin-Yi Wang Reviewed

[PATCH v3 0/3] Add a few panels and use correct modes

2023-11-06 Thread Hsin-Yi Wang
...@chromium.org/ v2: https://patchwork.kernel.org/project/dri-devel/cover/20231102221309.1971910-1-hsi...@chromium.org/ Hsin-Yi Wang (3): drm/panel-edp: drm/panel-edp: Add several generic edp panels drm/panel-edp: Add override_edid_mode quirk for generic edp drm/panel-edp: Avoid adding multiple

Re: [PATCH 3/3] drm/panel-edp: Choose correct preferred mode

2023-11-06 Thread Hsin-Yi Wang
itry Baryshkov > > > wrote: > > > > > > > > On Wed, 1 Nov 2023 at 23:26, Hsin-Yi Wang wrote: > > > > > > > > > > If a non generic edp-panel is under aux-bus, the mode read from edid > > > > > would > > > >

Re: [PATCH v2 4/4] drm/panel-edp: Choose correct preferred mode

2023-11-03 Thread Hsin-Yi Wang
On Fri, Nov 3, 2023 at 9:03 AM Doug Anderson wrote: > > Hi, > > On Thu, Nov 2, 2023 at 3:13 PM Hsin-Yi Wang wrote: > > > > If a non generic edp-panel is under aux-bus, the mode read from edid would > > still be selected as preferred and results in multiple preferred

Re: [PATCH v2 1/4] drm/panel-edp: Add several AUO/BOE panels

2023-11-03 Thread Hsin-Yi Wang
On Fri, Nov 3, 2023 at 9:02 AM Doug Anderson wrote: > > Hi, > > On Thu, Nov 2, 2023 at 3:13 PM Hsin-Yi Wang wrote: > > > > Add a few generic edp panels used by mt8186 chromebooks. > > Besides, modify the following panel: > > - AUO 0x235c B116XTN02 rena

[PATCH v2 3/4] drm/modes: Add a function to clear preferred modes

2023-11-02 Thread Hsin-Yi Wang
Add a function to clear the preferred bit of a connector's existing modes. This is useful for edp panel to unset the preferred modes read from edid if the panel has hard-coded modes. Signed-off-by: Hsin-Yi Wang --- v1->v2: - fix doc string (reported by kernel test robot). - split mode a

[PATCH v2 4/4] drm/panel-edp: Choose correct preferred mode

2023-11-02 Thread Hsin-Yi Wang
If a non generic edp-panel is under aux-bus, the mode read from edid would still be selected as preferred and results in multiple preferred modes, which is ambiguous. If a hard-coded mode is present, unset the preferred bit of the modes read from edid. Signed-off-by: Hsin-Yi Wang --- v1->

[PATCH v2 2/4] drm/panel-edp: Add override_edid_mode quirk for generic edp

2023-11-02 Thread Hsin-Yi Wang
Generic edp gets mode from edid. However, some panels report incorrect mode in this way, resulting in glitches on panel. Introduce a new quirk additional_mode to the generic edid to pick a correct hardcoded mode. Signed-off-by: Hsin-Yi Wang Reviewed-by: Douglas Anderson --- v1->v2: no cha

  1   2   3   4   5   6   >