Re: question about replacing legacy_cursor_flag by async_update

2019-02-16 Thread Helen Koike via dri-devel
On 2/15/19 2:45 PM, Daniel Vetter wrote: > On Fri, Feb 15, 2019 at 10:25:03AM -0200, Helen Koike wrote: >> Hello, >> >> The legacy_cursor_update flag in the drm_atomic_state struct was being >> used to track if the update was asyncronous or not for the cursor plane. >> Which is really similar to

question about replacing legacy_cursor_flag by async_update

2019-02-15 Thread Helen Koike via dri-devel
Hello, The legacy_cursor_update flag in the drm_atomic_state struct was being used to track if the update was asyncronous or not for the cursor plane. Which is really similar to what the async_update flag do, so I was trying to get rid of the legacy_cursor_update flag (just for cleanup). So I did

Re: [PATCH v2] drm: Block fb changes for async plane updates

2019-02-14 Thread Helen Koike via dri-devel
On 2/14/19 6:21 AM, Daniel Vetter wrote: > On Wed, Feb 13, 2019 at 09:32:43PM -0200, Helen Koike wrote: >> >> >> On 2/13/19 7:21 PM, Helen Koike wrote: >>> >>> >>> On 2/13/19 5:18 PM, Nicholas Kazlauskas wrote: The prepare_fb call always happens on new_plane_state. The drm_atomic_h

Re: [PATCH v2] drm: Block fb changes for async plane updates

2019-02-13 Thread Helen Koike via dri-devel
On 2/13/19 7:21 PM, Helen Koike wrote: > > > On 2/13/19 5:18 PM, Nicholas Kazlauskas wrote: >> The prepare_fb call always happens on new_plane_state. >> >> The drm_atomic_helper_cleanup_planes checks to see if >> plane state pointer has changed when deciding to call cleanup_fb on >> either the

Re: [PATCH v2] drm: Block fb changes for async plane updates

2019-02-13 Thread Helen Koike via dri-devel
On 2/13/19 5:18 PM, Nicholas Kazlauskas wrote: > The prepare_fb call always happens on new_plane_state. > > The drm_atomic_helper_cleanup_planes checks to see if > plane state pointer has changed when deciding to call cleanup_fb on > either the new_plane_state or the old_plane_state. > > For a