Re: [PATCH 1/3] drm/bridge: dw-hdmi-qp: Return 0 in audio prepare when disconnected

2025-07-18 Thread Heiko Stuebner
Am Donnerstag, 17. Juli 2025, 23:56:18 Mitteleuropäische Sommerzeit schrieb Detlev Casanova: > To configure audio registers, the clock of the video port in use must be > enabled. > As those clocks are managed by the VOP driver, they can't be enabled here > to write the registers even when the HDMI

Re: [PATCH] drm/rockchip: Use dev_err_probe() to simplify code

2025-07-08 Thread Heiko Stuebner
ough debugfs. > > Applied, thanks! [1/1] drm/rockchip: Use dev_err_probe() to simplify code commit: 52008d6fe7fa84ecf23864c5cc373beb085f30b9 Best regards, -- Heiko Stuebner

Re: [PATCH] drm/rockchip: vop2: fail cleanly if missing a primary plane for a video-port

2025-07-08 Thread Heiko Stuebner
On Tue, 10 Jun 2025 23:27:48 +0200, Heiko Stuebner wrote: > Each window of a vop2 is usable by a specific set of video ports, so while > binding the vop2, we look through the list of available windows trying to > find one designated as primary-plane and usable by that specific port.

Re: [PATCH v4] drm/rockchip: cdn-dp: Convert to drm bridge

2025-07-08 Thread Heiko Stuebner
y, the bpc data will be used in > cdn_dp_bridge_atomic_enable(). > - Switch to use DRM_BRIDGE_OP_DP_AUDIO helpers. > > [...] Applied, thanks! [1/1] drm/rockchip: cdn-dp: Convert to drm bridge commit: afbbca25d06e2d361016da43dbb90f3a6034913b Best regards, -- Heiko Stuebner

Re: [PATCH] drm/rockchip: vop2: Fix the update of LAYER/PORT select registers when there are multi display output on rk3588/rk3568

2025-07-08 Thread Heiko Stuebner
] drm/rockchip: vop2: Fix the update of LAYER/PORT select registers when there are multi display output on rk3588/rk3568 commit: 3e89a8c6835476aa782da80585dee9ddae651eea Best regards, -- Heiko Stuebner

Re: [PATCH] drm/rockchip: lvds: Convert to drm bridge

2025-07-08 Thread Heiko Stuebner
commit: 40a382aae1d4a4ca07fe19b0d16b4fbc1eeace9f Best regards, -- Heiko Stuebner

Re: (subset) [PATCH v5 00/10] Convert inno hdmi to drm bridge

2025-07-08 Thread Heiko Stuebner
viewer:DRM DRIVERS FOR BRIDGE CHIPS) Jernej Skrabec (reviewer:DRM DRIVERS FOR BRIDGE CHIPS) and not all of them are in the recipient list. Best regards, -- Heiko Stuebner

[PATCH 12/13] arm64: dts: rockchip: add vcc3v3-lcd-s0 regulator to roc-rk3576-pc

2025-07-07 Thread Heiko Stuebner
This fixed regulator is described by the schematics as being part of the baseboard and its output supply is then routed to the 30pin DSI connector on the board. Signed-off-by: Heiko Stuebner --- arch/arm64/boot/dts/rockchip/rk3576-roc-pc.dts | 16 1 file changed, 16 insertions

[PATCH 10/13] arm64: dts: rockchip: add mipi-dcphy to rk3576

2025-07-07 Thread Heiko Stuebner
Add the MIPI-DC-phy node to the RK3576, that will be used by the one DSI2 controller and hopefully in some future also for camera input. Signed-off-by: Heiko Stuebner --- arch/arm64/boot/dts/rockchip/rk3576.dtsi | 22 ++ 1 file changed, 22 insertions(+) diff --git a/arch

[PATCH 13/13] arm64: dts: rockchip: add dm-m10r800-v3s overlay for roc-rk3576-pc

2025-07-07 Thread Heiko Stuebner
Add DT-overlay for the DM-M10R800-V3S display module when connected to the ROC-RK3576-PC board. It contains a bestar,bsd1218-a101kl68 display and a Goodix GT911 touchscreen in one enclosed case. Signed-off-by: Heiko Stuebner --- arch/arm64/boot/dts/rockchip/Makefile | 5 + .../rk3576

[PATCH 11/13] arm64: dts: rockchip: add the dsi controller to rk3576

2025-07-07 Thread Heiko Stuebner
The RK3576 comes with one DSI2 controllers based on the same newer Synopsis IP as the ones on the RK3588. Add the necessary node for it. Signed-off-by: Heiko Stuebner --- arch/arm64/boot/dts/rockchip/rk3576.dtsi | 28 1 file changed, 28 insertions(+) diff --git a/arch

[PATCH 06/13] drm/panel: ilitek-ili9881c: Add Bestar BSD1218-A101KL68 support

2025-07-07 Thread Heiko Stuebner
Add support for the Bestar BSD1218-A101KL68 panel. The init table comes from the Firefly BSP ([1]). [1] https://gitlab.com/firefly-linux/kernel/-/blob/rk3588/firefly/arch/arm64/boot/dts/rockchip/aio-3588l-mipi101-BSD1218-A101KL68.dtsi Signed-off-by: Heiko Stuebner --- drivers/gpu/drm/panel

[PATCH 09/13] drm/rockchip: dsi2: add support rk3576

2025-07-07 Thread Heiko Stuebner
From: Guochun Huang Add the necessary specific bits to support the rk3576-variant of the DW-DSI2 controller. Signed-off-by: Guochun Huang [adapted from the vendor-kernel for mainline] Signed-off-by: Heiko Stuebner --- .../gpu/drm/rockchip/dw-mipi-dsi2-rockchip.c | 21 +++ 1

[PATCH 08/13] dt-bindings: display: rockchip: Add rk3576 to RK3588 DW DSI2 controller schema

2025-07-07 Thread Heiko Stuebner
The rk3576 controller is based on the same newer Synopsis IP as the one found in the rk3588. Its external setting bits in the GRF are different though, so it needs its own distinct compatible. Signed-off-by: Heiko Stuebner --- .../bindings/display/rockchip/rockchip,rk3588-mipi-dsi2.yaml

[PATCH 07/13] dt-bindings: soc: rockchip: add rk3576 mipi dcphy syscon

2025-07-07 Thread Heiko Stuebner
RK3576 CSI and DSI support requires the GRF for its DC-PHY. The "general register files" provide additional setting-bits outside the regular ip-block reg-space. Signed-off-by: Heiko Stuebner --- Documentation/devicetree/bindings/soc/rockchip/grf.yaml | 1 + 1 file changed, 1 insertio

[PATCH 01/13] drm/panel: ilitek-ili9881c: turn off power-supply when init fails

2025-07-07 Thread Heiko Stuebner
The prepare function turns on the power-supply regulator first, when preparing the display. But in an error case, just returns the error code, but does not power off the regulator again, fix that. Signed-off-by: Heiko Stuebner --- drivers/gpu/drm/panel/panel-ilitek-ili9881c.c | 12

[PATCH 03/13] drm/panel: ilitek-ili9881c: convert (un-)prepare to mipi_dsi_multi_context

2025-07-07 Thread Heiko Stuebner
This saves some lines for error handling. For the address mode change, that value is always an u8, so switching to dcs_write_buffer function should be appropriate. Signed-off-by: Heiko Stuebner --- drivers/gpu/drm/panel/panel-ilitek-ili9881c.c | 66 ++- 1 file changed, 21

[PATCH 04/13] dt-bindings: vendor-prefixes: Add prefix for Shenzhen Bestar Electronic

2025-07-07 Thread Heiko Stuebner
Add the prefix for Bestar, named in full both on Panelook.com and their display datasheets as Shenzhen Bestar Electronic Technology Co., Ltd. which produces at least DSI displays and maybe more. Signed-off-by: Heiko Stuebner --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1

[PATCH 05/13] dt-bindings: display: ili9881c: Add Bestar BSD1218-A101KL68 LCD panel

2025-07-07 Thread Heiko Stuebner
Document the compatible value for Bestar BSD1218-A101KL68 LCD panels that are based around the ili9881c controller. Signed-off-by: Heiko Stuebner --- .../devicetree/bindings/display/panel/ilitek,ili9881c.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree

[PATCH 02/13] drm/panel: ilitek-ili9881c: move display_on/_off dcs calls to (un-)prepare

2025-07-07 Thread Heiko Stuebner
play using this controller. Therefore move the display_on/off calls the more appropriate prepare/unprepare callbacks. Signed-off-by: Heiko Stuebner --- drivers/gpu/drm/panel/panel-ilitek-ili9881c.c | 27 +-- 1 file changed, 7 insertions(+), 20 deletions(-) diff --git a/drivers/gpu

[PATCH 00/13] Support DSI output on rk3576 and roc-rk3576-pc board

2025-07-07 Thread Heiko Stuebner
4b0ce...@collabora.com/ Guochun Huang (1): drm/rockchip: dsi2: add support rk3576 Heiko Stuebner (12): drm/panel: ilitek-ili9881c: turn off power-supply when init fails drm/panel: ilitek-ili9881c: move display_on/_off dcs calls to (un-)prepare drm/panel: ilitek-ili9881c: convert (un-)pr

Re: (subset) [PATCH 0/3] arm64: dts: rockchip: Fix HDMI output on RK3576

2025-06-30 Thread Heiko Stuebner
equence of the system CRU limitations. > > [...] Applied, thanks! [2/3] arm64: dts: rockchip: Enable HDMI PHY clk provider on rk3576 commit: aba7987a536cee67fb0cb724099096fd8f8f5350 [3/3] arm64: dts: rockchip: Add HDMI PHY PLL clock source to VOP2 on rk3576 commit: 4ab8b8ac952fb08d03655e

Re: (subset) [PATCH 0/3] arm64: dts: rockchip: Fix HDMI output on RK3576

2025-06-30 Thread Heiko Stuebner
equence of the system CRU limitations. > > [...] Applied, thanks! [1/3] dt-bindings: display: vop2: Add optional PLL clock property for rk3576 commit: 3832dc42aed9b047ccecebf5917d008bd2dac940 Best regards, -- Heiko Stuebner

Re: (subset) [PATCH 0/3] rockchip: Add GPU support for RK3528

2025-06-20 Thread Heiko Stuebner
U node for RK3528 commit: 6b88b8a640fa5d2169e0ce47b88dc30727fc1105 [3/3] arm64: dts: rockchip: Enable GPU on Radxa E20C commit: 669080eb7f7c4720aa4e640a49f7490cd928cfcc Best regards, -- Heiko Stuebner

Re: [PATCH v7 00/10] New DRM accel driver for Rockchip's RKNN NPU

2025-06-20 Thread Heiko Stuebner
Am Freitag, 6. Juni 2025, 08:28:20 Mitteleuropäische Sommerzeit schrieb Tomeu Vizoso: > This series adds a new driver for the NPU that Rockchip includes in its > newer SoCs, developed by them on the NVDLA base. > > In its current form, it supports the specific NPU in the RK3588 SoC. > > The user

Re: [PATCH v7 00/10] New DRM accel driver for Rockchip's RKNN NPU

2025-06-19 Thread Heiko Stuebner
eem to be using ;-) - on a rk3588-tiger board. NPU needed like 30ms per frame or so and also detected the expected things, so Tested-by: Heiko Stuebner

[PATCH] drm/rockchip: vop2: fail cleanly if missing a primary plane for a video-port

2025-06-10 Thread Heiko Stuebner
exist for a video-port, add a check at the end of the window-iteration and fail probing if none was found. Fixes: 604be85547ce ("drm/rockchip: Add VOP2 driver") Signed-off-by: Heiko Stuebner --- drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 4 1 file changed, 4 insertions(+) di

Re: (subset) [PATCH 0/4] Add DSI Panel for Gameforce Ace

2025-06-09 Thread Heiko Stuebner
for gameforce-ace commit: 6b28769116971a4427ea09ed2cb1cf1afa79ab82 Best regards, -- Heiko Stuebner

[PATCH] drm/bridge: analogix_dp: Fix clk-disable removal

2025-05-27 Thread Heiko Stuebner
roducing another goto err_clk_disable there. So remove that one too and return an error pointer, to not create build breakage. Fixes: 6579a03e68ff ("drm/bridge: analogix_dp: Remove the unnecessary calls to clk_disable_unprepare() during probing") Signed-off-by: Heiko Stuebner --

Re: [PATCH] drm/rockchip: cleanup fb when drm_gem_fb_afbc_init failed

2025-05-19 Thread Heiko Stuebner
afbc_init fails. > > Directly call drm_framebuffer_put to ensure that all fb related > resources are cleanup. > > [...] Applied, thanks! [1/1] drm/rockchip: cleanup fb when drm_gem_fb_afbc_init failed commit: 099593a28138b48feea5be8ce700e5bc4565e31d Best regards, -- Heiko Stuebner

Re: (subset) [PATCH 0/3] rockchip: Add GPU support for RK3528

2025-05-19 Thread Heiko Stuebner
RK3528 compatible commit: 6f446bbe412ab3d75651d1cc52e31aaf801dbea8 Best regards, -- Heiko Stuebner

Re: (subset) [PATCH v4 0/7] Convert inno hdmi to drm bridge

2025-05-05 Thread Heiko Stuebner
1c40af51d4a8cd804eaaf9 [6/7] Revert "ARM: dts: rockchip: drop grf reference from rk3036 hdmi" commit: dd6c77864aa69ba1079998c590b552e35649d51b Best regards, -- Heiko Stuebner

Re: (subset) [PATCH v4 0/7] Convert inno hdmi to drm bridge

2025-05-04 Thread Heiko Stuebner
ca75c6cfe1478ab [4/7] drm/rockchip: inno-hdmi: Fix video timing HSYNC/VSYNC polarity setting for rk3036 commit: ad10b82c2bcac7f87ac6eaecfca33378b43425ee Best regards, -- Heiko Stuebner

Re: [PATCH] drm/rockchip: rk3066_hdmi: switch to drm bridge

2025-05-04 Thread Heiko Stuebner
the compilation test. > > > [...] Applied, thanks! [1/1] drm/rockchip: rk3066_hdmi: switch to drm bridge commit: 57d6811e8a6d179aeadb7f102369d1ddefe5aae0 Best regards, -- Heiko Stuebner

Re: [PATCH] drm/rockchip: add CONFIG_OF dependency

2025-05-01 Thread Heiko Stuebner
; OF [=n] > Selected by [y]: > - DRM_ROCKCHIP [=y] && HAS_IOMEM [=y] && DRM [=y] && ROCKCHIP_IOMMU [=y] && > ROCKCHIP_ANALOGIX_DP [=y] > > [...] Applied, thanks! [1/1] drm/rockchip: add CONFIG_OF dependency commit: 4f1a965d592a0ca7d4ee2125f54d19ba8292295a Best regards, -- Heiko Stuebner

[PATCH 1/2] dt-bindings: display: ltk050h3146w: add port property

2025-04-30 Thread Heiko Stuebner
From: Heiko Stuebner The panel can be connected to via graph nodes, so allow the port property. This fixes dtc checker warnings like: >> arch/arm64/boot/dts/rockchip/rk3588-tiger-haikou-haikou-video-demo.dtb: >> panel@0 (leadtek,ltk050h3148w): 'port' does not ma

[PATCH 0/2] Allow port dt-property on two leadtek dsi displays

2025-04-30 Thread Heiko Stuebner
Working on an upcoming board dts, I noticed a dtc check warning about the port node and at the same time the kernel-test-robot noticed the same warning with a overlay I added recently. So allow the port node in the binding of two leadtek displays to fix that. Heiko Stuebner (2): dt-bindings

[PATCH 2/2] dt-bindings: display: ltk500hd1829: add port property

2025-04-30 Thread Heiko Stuebner
From: Heiko Stuebner The panel can be connected to via graph nodes, so allow the port property. Signed-off-by: Heiko Stuebner --- .../devicetree/bindings/display/panel/leadtek,ltk500hd1829.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/display

Re: (subset) [PATCH v8 00/13] Add eDP support for RK3588

2025-04-22 Thread Heiko Stuebner
ble eDP0 display on RK3588S EVB1 board commit: 53862b991e79d8816d5ff54b5954d6a0fe1dcd4c Best regards, -- Heiko Stuebner

Re: (subset) [PATCH 1/2] drm/rockchip: vop: remove redundant condition check

2025-04-10 Thread Heiko Stuebner
1c0285e06eeb Andy suggested a name change for a function in patch2. Best regards, -- Heiko Stuebner

Re: [PATCH] drm/rockchip: vop2: Fix interface enable/mux setting of DP1 on rk3588

2025-04-10 Thread Heiko Stuebner
On Wed, 12 Mar 2025 14:42:10 +0800, Andy Yan wrote: > This is a copy-paste error, which affects DP1 usage. > > Applied, thanks! [1/1] drm/rockchip: vop2: Fix interface enable/mux setting of DP1 on rk3588 commit: 210db264cf87da8908c395b44170f04469009035 Best regards, -- Heiko Stuebner

Re: [PATCH v2] drm/rockchip: dw_hdmi_qp: Fix io init for dw_hdmi_qp_rockchip_resume

2025-04-10 Thread Heiko Stuebner
hip_resume commit: 1d34597a1e23004c7dd0ab5f58ba1ef95fd9ded5 Best regards, -- Heiko Stuebner

Re: [PATCH] drm/rockchip: vop2: Make overlay layer select register configuration take effect by vsync

2025-04-10 Thread Heiko Stuebner
inconsistent display contents may be seen on the screen. > > Applied, thanks! [1/1] drm/rockchip: vop2: Make overlay layer select register configuration take effect by vsync commit: c5996e4ab109c8bb5541453b20647eaaf9350f41 Best regards, -- Heiko Stuebner

Re: [PATCH RESEND] (drm/rockchip): Consistently use rk3399 registers consts

2025-04-10 Thread Heiko Stuebner
hanks! [1/1] (drm/rockchip): Consistently use rk3399 registers consts commit: d74cc229cfbbc5a96139825c297f34accd670bce Best regards, -- Heiko Stuebner

Re: [PATCH] dt-bindings: display: rockchip,vop: Drop assigned-clocks

2025-04-10 Thread Heiko Stuebner
Applied, thanks! [1/1] dt-bindings: display: rockchip,vop: Drop assigned-clocks commit: 64e6121dc1b18a8208faf5b26efb50206722fd8e Best regards, -- Heiko Stuebner

Re: [PATCH v3 0/3] drm/rockchip: lvds: probe logging improvements

2025-03-04 Thread Heiko Stuebner
On Tue, 04 Mar 2025 13:44:15 +0100, Heiko Stuebner wrote: > Getting the panel already uses dev_err_probe to stay silent, when > the panel just probes later, and the lvds defers. > > But the phy needed on px30, also has the capability to probe after > the lvds. So make the rest of

[PATCH v3 2/3] drm/rockchip: lvds: Hide scary error messages on probe deferral

2025-03-04 Thread Heiko Stuebner
From: Heiko Stuebner Commit 52d11c863ac9 ("drm/rockchip: lvds: do not print scary message when probing defer") already started hiding scary messages that are not relevant if the requested supply just returned EPROBE_DEFER, but there are more possible sources - like the phy. So mod

[PATCH v3 3/3] drm/rockchip: lvds: lower log severity for missing pinctrl settings

2025-03-04 Thread Heiko Stuebner
From: Heiko Stuebner While missing lvds pinctrl is unexpected and is reported, we nevertheless don't fail setting up the device and instead continue without explicit pinctrl handling. So lower the log-level from error to warning to reflect that. Signed-off-by: Heiko Stuebner --- driver

[PATCH v3 0/3] drm/rockchip: lvds: probe logging improvements

2025-03-04 Thread Heiko Stuebner
(Quentin) Heiko Stuebner (3): drm/rockchip: lvds: move pclk preparation in with clk_get drm/rockchip: lvds: Hide scary error messages on probe deferral drm/rockchip: lvds: lower log severity for missing pinctrl settings drivers/gpu/drm/rockchip/rockchip_lvds.c | 80

[PATCH v3 1/3] drm/rockchip: lvds: move pclk preparation in with clk_get

2025-03-04 Thread Heiko Stuebner
From: Heiko Stuebner The LVDS block needs a separate pclk only on some socs, so currently requests and prepares it in the soc-specific probe function, but common code is required to unprepare it in the error path or on driver remove. While this works because clk_unprepare just does nothing if

Re: [PATCH] drm/rockchip: vop2: add missing bitfield.h include

2025-03-03 Thread Heiko Stuebner
On Mon, 03 Mar 2025 19:22:56 +0100, Heiko Stuebner wrote: > Commit 328e6885996c ("drm/rockchip: vop2: Add platform specific callback") > moved per soc configuration code to the other per-soc data into > rockchip_vop2_reg.c, but forgot to also include bitfield.h for the used

Re: [PATCH v16 0/7] VOP Support for rk3576

2025-03-03 Thread Heiko Stuebner
50fb51933d0608117599db71 Best regards, -- Heiko Stuebner

[PATCH] drm/rockchip: vop2: add missing bitfield.h include

2025-03-03 Thread Heiko Stuebner
/rockchip: vop2: Add platform specific callback") Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202503040135.fgoywdlb-...@intel.com/ Signed-off-by: Heiko Stuebner --- drivers/gpu/drm/rockchip/rockchip_vop2_reg.c | 1 + 1 file changed, 1 insertion(+) diff --g

Re: (subset) [PATCH v15 00/13] VOP Support for rk3576

2025-03-02 Thread Heiko Stuebner
rm/rockchip: vop2: Support for different layer select configuration between VPs commit: 5439c4f3cb0ec11a3f3cb70be2b019770f6d183c [06/13] drm/rockchip: vop2: Introduce vop hardware version commit: 301618ed1d8ab7cfaec39b107eded9f263da2299 Best regards, -- Heiko Stuebner

[PATCH v2 0/2] drm/rockchip: lvds: probe logging improvements

2025-03-01 Thread Heiko Stuebner
deprecated anyway. changes in v2: - reword the messages about getting (and preparing) pclk (Quentin) - use a ret = dev_err_probe(dev, -EINVAL, ...) pattern in some (additional) places (Quentin) Heiko Stuebner (2): drm/rockchip: lvds: move pclk preparation in with clk_get drm/rockchip: lvds

[PATCH v2 2/2] drm/rockchip: lvds: Hide scary error messages on probe deferral

2025-03-01 Thread Heiko Stuebner
From: Heiko Stuebner Commit 52d11c863ac9 ("drm/rockchip: lvds: do not print scary message when probing defer") already started hiding scary messages that are not relevant if the requested supply just returned EPROBE_DEFER, but there are more possible sources - like the phy. So mod

[PATCH v2 1/2] drm/rockchip: lvds: move pclk preparation in with clk_get

2025-03-01 Thread Heiko Stuebner
From: Heiko Stuebner The LVDS block needs a separate pclk only on some socs, so currently requests and prepares it in the soc-specific probe function, but common code is required to unprepare it in the error path or on driver remove. While this works because clk_unprepare just does nothing if

Re: (subset) [PATCH v3 00/15] rockchip: Add rk3562 SoC and evb support

2025-02-28 Thread Heiko Stuebner
mali compatible commit: 049e7ac203d51fdc3a739f5f28906788e8eeea03 Best regards, -- Heiko Stuebner

[PATCH 2/2] drm/rockchip: lvds: Hide scary error messages on probe deferral

2025-02-28 Thread Heiko Stuebner
From: Heiko Stuebner Commit 52d11c863ac9 ("drm/rockchip: lvds: do not print scary message when probing defer") already started hiding scary messages that are not relevant if the requested supply just returned EPROBE_DEFER, but there are more possible sources - like the phy. So mod

[PATCH 1/2] drm/rockchip: lvds: move pclk preparation in with clk_get

2025-02-28 Thread Heiko Stuebner
From: Heiko Stuebner The LVDS block needs a separate pclk only on some socs, so currently requests and prepares it in the soc-specific probe function, but common code is required to unprepare it in the error path or on driver remove. While this works because clk_unprepare just does nothing if

[PATCH 0/2] drm/rockchip: lvds: probe logging improvements

2025-02-28 Thread Heiko Stuebner
deprecated anyway. Heiko Stuebner (2): drm/rockchip: lvds: move pclk preparation in with clk_get drm/rockchip: lvds: Hide scary error messages on probe deferral drivers/gpu/drm/rockchip/rockchip_lvds.c | 76 +--- 1 file changed, 28 insertions(+), 48 deletions(-) -- 2.47.2

Re: [PATCH 0/2] Fix the shutdown callback of a drm component device

2025-02-27 Thread Heiko Stuebner
On Fri, 21 Feb 2025 00:41:39 +0100, Heiko Stuebner wrote: > Probe deferral can cause the platform-data we access to be freed already > causing ugly splats on system shutdown. > > Fix this via a small component-helper and adapting the rockchip-drm > shutdown handler. > &

Re: (subset) [PATCH v7 0/3] Add HDMI audio on the rk3588 SoC

2025-02-27 Thread Heiko Stuebner
for rk3588 SoC commit: b8c6c136971c0e9750eec89f367529b2854d3a3c [3/3] arm64: dts: rockchip: Enable HDMI audio outputs for Rock 5B commit: 97aa62ed1e970bf8aa9f57e87c946a95fa3d5bef Best regards, -- Heiko Stuebner

Re: (subset) [PATCH v2 0/5] Improve Rockchip VOP2 display modes handling on RK3588 HDMI1

2025-02-27 Thread Heiko Stuebner
ock source to VOP2 on RK3588 commit: b2e668a60ed866ba960acb5310d1fb6bf81d154f [5/5] arm64: dts: rockchip: Enable HDMI1 on rk3588-evb1 commit: 5c2d6181ae830e02856c603b8c08e80e9d419874 Best regards, -- Heiko Stuebner

Re: (subset) [PATCH v7 0/3] Add HDMI audio on the rk3588 SoC

2025-02-27 Thread Heiko Stuebner
for dw-hdmi-qp commit: fd0141d1a8a2a26675ee88df75615c05a55044de Best regards, -- Heiko Stuebner

Re: (subset) [PATCH v2 0/5] Improve Rockchip VOP2 display modes handling on RK3588 HDMI1

2025-02-27 Thread Heiko Stuebner
istently use dev_err_probe() commit: b06d1ef3355571383cdb463cf0195b7a02efdfbf Best regards, -- Heiko Stuebner

Re: (subset) [PATCH v7 00/15] Add eDP support for RK3588

2025-02-27 Thread Heiko Stuebner
] drm/rockchip: analogix_dp: Expand device data to support multiple edp display commit: 718b3bb9c0ab87bc90914799e6999bf4b1ecc67b Best regards, -- Heiko Stuebner

[PATCH 1/2] drivers: base: component: add function to query the bound status

2025-02-20 Thread Heiko Stuebner
up and running, but may run into problems if that drm-device has never been set up before, for example because the binding deferred. So add a little helper that returns the bound status for a componet device. Signed-off-by: Heiko Stuebner --- drivers/base/component.c | 14

[PATCH 0/2] Fix the shutdown callback of a drm component device

2025-02-20 Thread Heiko Stuebner
Probe deferral can cause the platform-data we access to be freed already causing ugly splats on system shutdown. Fix this via a small component-helper and adapting the rockchip-drm shutdown handler. Heiko Stuebner (2): drivers: base: component: add function to query the bound status drm

[PATCH 2/2] drm/rockchip: Fix shutdown when no drm-device is set up

2025-02-20 Thread Heiko Stuebner
new component helper to check whether the drm-device is up and only then call the drm-atomic helper to release all the drm magic. This prevents failures when the drm-device is never set, or has been freed up already for example by a probe-defer during the component bind. Signed-off-by: Heiko

Re: (subset) [PATCH v2 0/4] Add support for HDMI1 output on RK3588 SoC

2025-02-11 Thread Heiko Stuebner
: dts: rockchip: Enable HDMI1 on rock-5b commit: 77cea7ca13680e14119a3b9635c7ef16cd7ee44e Best regards, -- Heiko Stuebner

Re: (subset) [PATCH v3 0/5] Improve Rockchip VOP2 display modes handling on RK3588 HDMI0

2025-02-06 Thread Heiko Stuebner
ock source to VOP2 on RK3588 commit: eb4262203d7d85eb7b6f2696816db272e41f5464 Best regards, -- Heiko Stuebner

Re: (subset) [PATCH v7 0/2] Fix label name of hdptxphy for RK3588

2025-02-06 Thread Heiko Stuebner
phy0 other than > hdptxphy_hdmi0, which will be referenced by both hdmi0 and edp0 nodes. > > [...] Applied, thanks! [2/2] arm64: dts: rockchip: Fix label name of hdptxphy for RK3588 commit: 2efdb041019fd6c58abefba3eb6fdc4d659e576c Best regards, -- Heiko Stuebner

Re: (subset) [PATCH v7 0/2] Fix label name of hdptxphy for RK3588

2025-02-06 Thread Heiko Stuebner
phy0 other than > hdptxphy_hdmi0, which will be referenced by both hdmi0 and edp0 nodes. > > [...] Applied, thanks! [1/2] dt-bindings: display: rockchip: Fix label name of hdptxphy for RK3588 HDMI TX Controller commit: 81dde32e7266e7132076b886337bd29b4648e542 Best regards, -- Heiko Stuebner

Re: (subset) [PATCH v3 0/5] Improve Rockchip VOP2 display modes handling on RK3588 HDMI0

2025-02-06 Thread Heiko Stuebner
y if_pixclk_rate computation commit: 9f40d7a94427a503e303b2a2d8db227d615e32c1 [3/5] drm/rockchip: vop2: Improve display modes handling on RK3588 HDMI0 commit: 2c1268e7aad0819f38e56134bbc2095fd95fde1b Best regards, -- Heiko Stuebner

Re: [PATCH] drm/rockchip: Don't change hdmi reference clock rate

2025-01-09 Thread Heiko Stuebner
o incorrect timings for > DDC, CEC, and HDCP signal generation. > > [...] Applied, thanks! [1/1] drm/rockchip: Don't change hdmi reference clock rate commit: 1854df7087be70ad54e24b2e308d7558ebea9f27 Best regards, -- Heiko Stuebner

Re: [PATCH v2 0/3] Add HDMI support for rk3576

2025-01-06 Thread Heiko Stuebner
re checkpatch warnings Best regards, -- Heiko Stuebner

Re: (subset) [PATCH v8 0/9] VOP Support for rk3576

2025-01-05 Thread Heiko Stuebner
chip: vop2: Support 32x8 superblock afbc commit: 938fbb16aba8f7b88e0fdcf56f315a5bbad41aad Best regards, -- Heiko Stuebner

Re: [PATCH v2 06/17] dt-bindings: gpu: Add rockchip, rk3562-mali compatible

2024-12-25 Thread Heiko Stuebner
Am Dienstag, 24. Dezember 2024, 10:49:09 CET schrieb Kever Yang: > rk3562 has 1 ARM Mali-G52 GPU,. > > Signed-off-by: Kever Yang > --- > > Changes in v2: None > > Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --g

Re: (subset) [PATCH v6 00/16] VOP Support for rk3576

2024-12-18 Thread Heiko Stuebner
ster windows on rk3566/8 commit: df063c0b8ffbdca486ab2f802e716973985d8f86 [06/16] drm/rockchip: vop2: Add check for 32 bpp format for rk3588 commit: 7e8a56c703c67bfa8d3f71a0c1c297bb1252b897 [07/16] drm/rockchip: vop2: include rockchip_drm_drv.h commit: 77b1ccb2a27c7b3b118a03bf1730def92070d31b Best regards, -- Heiko Stuebner

Re: [PATCH v2] drm/rockchip: Fix Copyright description

2024-12-14 Thread Heiko Stuebner
yright description commit: 041c664da0691a72aca67f72ab6a13789631358e Best regards, -- Heiko Stuebner

Re: (subset) [PATCH v6 00/16] VOP Support for rk3576

2024-12-14 Thread Heiko Stuebner
hanks! [01/16] drm/rockchip: vop2: Add debugfs support commit: 779964556c64cd3d76ddfeb34738ef78020fae84 [02/16] drm/rockchip: vop2: Fix the windows switch between different layers commit: 0ca953ac226eaffbe1a795f5e517095a8d494921 Best regards, -- Heiko Stuebner

Re: [PATCH drm-misc-next] rockchip/drm: vop2: don't check color_mgmt_changed in atomic_enable

2024-12-11 Thread Heiko Stuebner
anged in atomic_enable commit: 9c22b6ece2e5c2308f41ba4bec27cfa158397fa7 Best regards, -- Heiko Stuebner

Re: [PATCH] drm/rockchip: dw_hdmi_qp: Simplify clock handling

2024-12-11 Thread Heiko Stuebner
commit: 19851fa2ba9824bede16f55234f63d9423897c3d Best regards, -- Heiko Stuebner

Re: [PATCH] drm/rockchip: Remove unnecessary checking

2024-12-11 Thread Heiko Stuebner
On Fri, 06 Dec 2024 19:42:33 +0800, Guoqing Jiang wrote: > It is not needed since drm_atomic_helper_shutdown checks it. > > Applied, thanks! [1/1] drm/rockchip: Remove unnecessary checking commit: 8ddc8dfb8329349d5efb0418c9f20025333e2d98 Best regards, -- Heiko Stuebner

Re: (subset) [PATCH v2 0/4] Add support for HDMI1 output on RK3588 SoC

2024-12-11 Thread Heiko Stuebner
s. > > ** IMPORTANT ** > > [...] Applied, thanks! [1/4] drm/rockchip: dw_hdmi_qp: Add support for RK3588 HDMI1 output commit: 0f818db20c77506ddd870761785740f8230a4207 Best regards, -- Heiko Stuebner

Re: [PATCH v4 0/3] drm/rockchip: Add driver for the new DSI2 controller

2024-12-10 Thread Heiko Stuebner
On Tue, 10 Dec 2024 00:10:18 +0100, Heiko Stuebner wrote: > This series adds a bridge and glue driver for the DSI2 controller found > in the rk3588 soc from Rockchip, that is based on a Synopsis IP block. > > As the manual states: > The Display Serial Interface 2 (DSI-2) is par

Re: (subset) [PATCH v5 00/18] VOP Support for rk3576

2024-12-10 Thread Heiko Stuebner
hanks! [02/18] drm/rockchip: vop2: Fix cluster windows alpha ctrl regsiters offset commit: 17b4b10a0df1a1421d5fbdc03bad0bd3799bc966 [03/18] drm/rockchip: vop2: Fix the mixer alpha setup for layer 0 commit: 6b4dfdcde3573a12b72d2869dabd4ca37ad7e9c7 Best regards, -- Heiko Stuebner

Re: [PATCH v5 04/18] drm/rockchip: vop2: Fix the windows switch between different layers

2024-12-10 Thread Heiko Stuebner
Hi Andy, Am Montag, 9. Dezember 2024, 13:29:17 CET schrieb Andy Yan: > From: Andy Yan > > Every layer of vop2 should bind a window, and we also need to make > sure that this window is not used by other layer. > > 0x5 is a reserved layer sel value on rk3568, but it will select > Cluster3 on rk35

[PATCH v4 2/3] dt-bindings: display: rockchip: Add schema for RK3588 DW DSI2 controller

2024-12-09 Thread Heiko Stuebner
From: Heiko Stuebner The Display Serial Interface 2 (DSI-2) is part of a group of communication protocols defined by the MIPI Alliance. The RK3588 implements this specification in its two MIPI DSI-2 Host Controllers that are based on a new Synopsys IP. Tested-by: Dmitry Yashin Reviewed-by: Rob

[PATCH v4 3/3] drm/rockchip: Add MIPI DSI2 glue driver for RK3588

2024-12-09 Thread Heiko Stuebner
From: Heiko Stuebner This adds the glue code for the MIPI DSI2 bridge on Rockchip SoCs and enables its use on the RK3588. Right now the DSI2 controller is always paired with a DC-phy based on a Samsung IP, so the interface values are set statically for now. This stays true for the upcoming

[PATCH v4 0/3] drm/rockchip: Add driver for the new DSI2 controller

2024-12-09 Thread Heiko Stuebner
nges in v2: - clean up includes (Diederik) - fix Kconfig description (Diederik) - constant naming (Diederik) - binding fixes (paths, sorting, labels) (Rob) - move to use regmap - drop custom UPDATE macro and use FIELD_PREP instead - use dev_err instead of DRM_DEV_ERROR Heiko Stuebner (3): drm/bridge/syn

[PATCH v4 1/3] drm/bridge/synopsys: Add MIPI DSI2 host controller bridge

2024-12-09 Thread Heiko Stuebner
From: Heiko Stuebner Add a Synopsys Designware MIPI DSI host DRM bridge driver for their DSI2 host controller, based on the Rockchip version from the driver rockchip/dw-mipi-dsi2.c in their vendor-kernel with phy & bridge APIs. While the driver is heavily modelled after the previous IP,

[PATCH v3 1/3] drm/bridge/synopsys: Add MIPI DSI2 host controller bridge

2024-12-03 Thread Heiko Stuebner
From: Heiko Stuebner Add a Synopsys Designware MIPI DSI host DRM bridge driver for their DSI2 host controller, based on the Rockchip version from the driver rockchip/dw-mipi-dsi2.c in their vendor-kernel with phy & bridge APIs. While the driver is heavily modelled after the previous IP,

[PATCH v3 3/3] drm/rockchip: Add MIPI DSI2 glue driver for RK3588

2024-12-03 Thread Heiko Stuebner
From: Heiko Stuebner This adds the glue code for the MIPI DSI2 bridge on Rockchip SoCs and enables its use on the RK3588. Right now the DSI2 controller is always paired with a DC-phy based on a Samsung IP, so the interface values are set statically for now. This stays true for the upcoming

[PATCH v3 2/3] dt-bindings: display: rockchip: Add schema for RK3588 DW DSI2 controller

2024-12-03 Thread Heiko Stuebner
From: Heiko Stuebner The Display Serial Interface 2 (DSI-2) is part of a group of communication protocols defined by the MIPI Alliance. The RK3588 implements this specification in its two MIPI DSI-2 Host Controllers that are based on a new Synopsis IP. Reviewed-by: Rob Herring (Arm) Signed-off

[PATCH v3 0/3] drm/rockchip: Add driver for the new DSI2 controller

2024-12-03 Thread Heiko Stuebner
_DEV_ERROR Heiko Stuebner (3): drm/bridge/synopsys: Add MIPI DSI2 host controller bridge dt-bindings: display: rockchip: Add schema for RK3588 DW DSI2 controller drm/rockchip: Add MIPI DSI2 glue driver for RK3588 .../rockchip/rockchip,rk3588-mipi-dsi2.yaml | 119 ++ drivers/gpu/drm/bridg

Re: [PATCH v2] drm/rockchip: vop2: fix rk3588 dp+dsi maxclk verification

2024-11-28 Thread Heiko Stuebner
On Fri, 15 Nov 2024 16:11:31 +0100, Heiko Stuebner wrote: > The clock is in Hz while the value checked against is in kHz, so > actual frequencies will never be able to be below to max value. > Fix this by specifying the max-value in Hz too. > > Applied, thanks! [1/1] drm/rock

[PATCH v2 0/3] drm/rockchip: Add driver for the new DSI2 controller

2024-11-26 Thread Heiko Stuebner
and use FIELD_PREP instead - use dev_err instead of DRM_DEV_ERROR Heiko Stuebner (3): drm/bridge/synopsys: Add MIPI DSI2 host controller bridge dt-bindings: display: rockchip: Add schema for RK3588 DW DSI2 controller drm/rockchip: Add MIPI DSI2 glue driver for RK3588 .../rockchip

[PATCH v2 1/3] drm/bridge/synopsys: Add MIPI DSI2 host controller bridge

2024-11-26 Thread Heiko Stuebner
From: Heiko Stuebner Add a Synopsys Designware MIPI DSI host DRM bridge driver for their DSI2 host controller, based on the Rockchip version from the driver rockchip/dw-mipi-dsi2.c in their vendor-kernel with phy & bridge APIs. While the driver is heavily modelled after the previous IP,

  1   2   3   4   5   6   7   8   9   >