Re: [PATCH v5] drm/i915: Replace *_reference/unreference() or *_ref/unref with _get/put()

On Tue, Oct 17, 2017 at 12:15 AM, Sean Paul wrote: > On Sat, Oct 14, 2017 at 2:36 PM, Harsha Sharma > wrote: >> Replace instances of drm_framebuffer_reference/unreference() with >> *_get/put() suffixes and drm_dev_unref with *_put() suffix >> because get/put is shorter

[PATCH v4] drm/amd/powerplay: Remove unnecessary cast on void pointer

Done with following coccinelle patch @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T*)x)->f | - (T*) e ) Signed-off-by: Harsha Sharma --- Changes in v4: -Removed git diff warning "No newline at end of file" Changes in v3: -Remove

[PATCH] drm/omap: Replace list_for_each with list_for_each_entry

@ identifier s.i,s.f; expression s.e; statement S; @@ list_for_each_entry(i,e,f) - { S - } Signed-off-by: Harsha Sharma --- drivers/gpu/drm/omapdrm/dss/display.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/dss/display.c b/dri

[PATCH] drm/tinydrm: Replace list_for_each with list_for_each_entry

@ identifier s.i,s.f; expression s.e; statement S; @@ list_for_each_entry(i,e,f) - { S - } Signed-off-by: Harsha Sharma --- drivers/gpu/drm/tinydrm/core/tinydrm-helpers.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/tinydrm/core/tinydrm-helpers.c b

[PATCH v5] drm/i915: Replace *_reference/unreference() or *_ref/unref with _get/put()

; @@ ( -drm_framebuffer_unreference(ex); +drm_framebuffer_put(ex); | -drm_dev_unref(ex); +drm_dev_put(ex); | -drm_framebuffer_reference(ex); +drm_framebuffer_get(ex); ) Signed-off-by: Harsha Sharma --- Changes in v5: -rebase drm_dev_put change on drm-tip Changes in v4: -change one instance of *_put to *_get Changes in

[PATCH v2] drm/amd/powerplay: Remove unnecessary cast on void pointer

Done with following coccinelle patch @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T*)x)->f | - (T*) e ) Signed-off-by: Harsha Sharma --- Changes in v2: -Remove unnecessary parentheses -Remove one more useless cast drivers/gpu/drm/

[PATCH v2] drm: Replace kzalloc with kcalloc

Prefer kcalloc over kzalloc to allocate an array. This patch fixes checkcpatch issue. Signed-off-by: Harsha Sharma --- Changes in v2: -kcalloc will take 3 arguments drivers/gpu/drm/drm_crtc_helper.c | 4 ++-- drivers/gpu/drm/drm_fb_helper.c| 2 +- drivers/gpu/drm/drm_plane_helper.c | 2

[PATCH v3] drm/amd/powerplay: Remove unnecessary cast on void pointer

Done with following coccinelle patch @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T*)x)->f | - (T*) e ) Signed-off-by: Harsha Sharma --- Changes in v3: -Removed unnecessary lines -Remove more useless casts Changes in v2: -Remove unnecess

Re: [PATCH v4] drm/i915: Replace *_reference/unreference() or *_ref/unref with _get/put()

On Mon, Oct 9, 2017 at 5:36 PM, Harsha Sharma wrote: > Replace instances of drm_framebuffer_reference/unreference() with > *_get/put() suffixes and drm_dev_unref with *_put() suffix > because get/put is shorter and consistent with the > kernel use of *_get/put suffixes. > Done

[PATCH] drm/amd/powerplay: Remove unnecessary cast on void pointer

Done with following coccinelle patch @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T*)x)->f | - (T*) e ) Signed-off-by: Harsha Sharma --- drivers/gpu/drm/amd/powerplay/hwmgr/cz_hwmgr.c| 6 +++--- drivers/gpu/drm/amd/powerplay/hw

[PATCH] drm: Replace kzalloc with kcalloc

Prefer kcalloc over kzalloc to allocate an array. This patch fixes checkcpatch issue. Signed-off-by: Harsha Sharma --- drivers/gpu/drm/drm_crtc_helper.c | 4 ++-- drivers/gpu/drm/drm_fb_helper.c| 2 +- drivers/gpu/drm/drm_plane_helper.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions

[PATCH v4] drm/i915: Replace *_reference/unreference() or *_ref/unref with _get/put()

; @@ ( -drm_framebuffer_unreference(ex); +drm_framebuffer_put(ex); | -drm_dev_unref(ex); +drm_dev_put(ex); | -drm_framebuffer_reference(ex); +drm_framebuffer_get(ex); ) Signed-off-by: Harsha Sharma --- Changes in v4: -change one instance of *_put to *_get Changes in v3: -Removed changes in selftests Changes in v2

[PATCH v3] drm/tinydrm: Replace dev_error with DRM_DEV_ERROR

Convert instances of dev_error to DRM_DEV_ERROR as we have DRM_DEV_ERROR variants of drm print macros. Signed-off-by: Harsha Sharma --- Changes in v3: -Solve merge conflicts Changes in v2: -Fix alignment issues drivers/gpu/drm/tinydrm/mi0283qt.c | 8 drivers/gpu/drm/tinydrm

[PATCH v3] drm/i915: Replace *_reference/unreference() or *_ref/unref with _get/put()

; @@ ( -drm_framebuffer_unreference(ex); +drm_framebuffer_put(ex); | -drm_dev_unref(ex); +drm_dev_put(ex); | -drm_framebuffer_reference(ex); +drm_framebuffer_get(ex); ) Signed-off-by: Harsha Sharma --- Changes in v3: -Removed changes in selftests Changes in v2: -Added cocinelle patch in log message -cc to all driver

Re: [PATCH v2] drm/i915: Replace *_reference/unreference() or *_ref/unref with _get/put()

On Fri, Sep 29, 2017 at 10:00 AM, Harsha Sharma wrote: > Replace instances of drm_framebuffer_reference/unreference() with > *_get/put() suffixes and drm_dev_unref with *_put() suffix > because get/put is shorter and consistent with the > kernel use of *_get/put suffixes. > Done

[PATCH v2] drm/tinydrm: Replace dev_error with DRM_DEV_ERROR

Convert instances of dev_error to DRM_DEV_ERROR as we have DRM_DEV_ERROR variants of drm print macros. Signed-off-by: Harsha Sharma --- Changes in v2: -Fix alignment issues drivers/gpu/drm/tinydrm/mi0283qt.c | 8 drivers/gpu/drm/tinydrm/repaper.c | 26

[PATCH] drm/i915: Replace *_reference/unreference() or *_ref/unref with _get/put()

Replace instances of drm_framebuffer_reference/unreference() with *_get/put() suffixes and drm_dev_unref with *_put() suffix because get/put is shorter and consistent with the kernel use of *_get/put suffixes . Signed-off-by: Harsha Sharma --- drivers/gpu/drm/i915/i915_pci.c

[PATCH v2] drm/i915: Replace *_reference/unreference() or *_ref/unref with _get/put()

; @@ ( -drm_framebuffer_unreference(ex); +drm_framebuffer_put(ex); | -drm_dev_unref(ex); +drm_dev_put(ex); | -drm_framebuffer_reference(ex); +drm_framebuffer_get(ex); ) Signed-off-by: Harsha Sharma --- Changes in v2: -Added coccinelle patch in log message -cc to all driver-specific mailing lists

Kernel GPU subsytem: Better manual upload for atomic

you can suggest something. Thanks a lot for your time. Regards, Harsha Sharma ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [Outreachy kernel] [PATCH v2] drm/tegra: Replace dev_* with DRM_DEV_*

Hi, Thanks a lot for your feedback. I will send another version for this patch. Thanks for your time. Regards, Harsha Sharma On Sun, Sep 24, 2017 at 10:30 PM, Julia Lawall wrote: > > > On Sun, 24 Sep 2017, Harsha Sharma wrote: > > > Replace all occurences of dev_info/err/dbg

[PATCH v2] drm/tegra: Replace dev_* with DRM_DEV_*

Replace all occurences of dev_info/err/dbg with DRM_DEV_INFO/ ERROR/DEBUG as we have DRM_DEV_* variants of drm print macros Done using following coccinelle semantic patch @r@ @@ ( -dev_info +DRM_DEV_INFO | -dev_err +DRM_DEV_ERROR | -dev_dbg +DRM_DEV_DEBUG ) Signed-off-by: Harsha Sharma

[PATCH] drm/tinydrm: Replace dev_error with DRM_DEV_ERROR

Convert instances of dev_error to DRM_DEV_ERROR as we have DRM_DEV_ERROR variants of drm print macros. Signed-off-by: Harsha Sharma --- drivers/gpu/drm/tinydrm/mi0283qt.c | 8 drivers/gpu/drm/tinydrm/repaper.c | 26 +- drivers/gpu/drm/tinydrm/st7586.c | 6

[PATCH] drm/tegra: Replace dev_* with DRM_DEV_*

Replace all occurences of dev_info/err/dbg with DRM_DEV_INFO/ ERROR/DEBUG as we have DRM_DEV_* variants of drm print macros Done using following coccinelle semantic patch @r@ @@ ( -dev_info +DRM_DEV_INFO | -dev_err +DRM_DEV_ERROR | -dev_dbg +DRM_DEV_DEBUG ) Signed-off-by: Harsha Sharma