Re: [PATCH] agp/amd64: Bind to unsupported devices only if AGP is present

2025-06-25 Thread Hans de Goede
Hi, On 25-Jun-25 4:33 PM, Lukas Wunner wrote: > On Wed, Jun 25, 2025 at 04:08:38PM +0200, Hans de Goede wrote: >> Lukas made me aware of this attempt to fix the KERN_CRIT msg, because >> I wrote a slightly different patch to fix this: >> >> https://lore.kernel.org/dri-

[PATCH] agp/amd64: Only try host-bridges when agp_try_unsupported is set

2025-06-25 Thread Hans de Goede
that the IOMMU will no longer get probed with the agpgart-amd64 driver. This not only fixes the troublesome dev_crit() logging it should also speed up things in general. Signed-off-by: Hans de Goede --- Given how old AGP is I would expect the agp_amd64_pci_table[] to be complete and I wonder if mayb

Re: [PATCH] agp/amd64: Only try host-bridges when agp_try_unsupported is set

2025-06-25 Thread Hans de Goede
Hi, On 25-Jun-25 3:38 PM, Lukas Wunner wrote: > On Wed, Jun 25, 2025 at 01:24:11PM +0200, Hans de Goede wrote: >> On modern AMD Ryzen systems the IOMMU code initializes early on adding >> resources to the "00:00.2 IOMMU" PCI-device without binding a driver to >> it

Re: [PATCH] agp/amd64: Bind to unsupported devices only if AGP is present

2025-06-25 Thread Hans de Goede
Hi, On 24-Jun-25 11:54 PM, Ben Hutchings wrote: > On Sat, 2025-06-21 at 16:05 +0200, Lukas Wunner wrote: >> On Sat, Jun 21, 2025 at 03:51:44PM +0200, Ben Hutchings wrote: >>> On Sat, 2025-06-21 at 14:29 +0200, Lukas Wunner wrote: On Sat, Jun 21, 2025 at 02:07:40PM +0200, Ben Hutchings wrote:

Re: [PATCH] agp/amd64: Only try host-bridges when agp_try_unsupported is set

2025-06-25 Thread Hans de Goede
Hi Alex, On 25-Jun-25 3:11 PM, Alex Deucher wrote: > + Suravee and Vasant > > On Wed, Jun 25, 2025 at 7:24 AM Hans de Goede wrote: >> >> On modern AMD Ryzen systems the IOMMU code initializes early on adding >> resources to the "00:00.2 IOMMU" PCI-dev

Re: [PATCH v2 0/5] Add interconnent support for simpledrm/simplefb

2025-06-23 Thread Hans de Goede
cc-v1-0-d92142e8f...@fairphone.com Thanks, the entire series looks good to me: Reviewed-by: Hans de Goede for the series. Regards, Hans > > --- > Luca Weiss (5): > dt-bindings: display: simple-framebuffer: Add interconnects property > drm/sysfb: simpledrm: Sort he

Re: [PATCH 01/12] platform/x86: dell-uart-backlight: Use blacklight power constant

2025-06-18 Thread Hans de Goede
Hi, On 18-Jun-25 2:16 PM, Thomas Zimmermann wrote: > The backlight subsystem has gotten its own power constants. Replace > FB_BLANK_UNBLANK with BACKLIGHT_POWER_ON. > > Signed-off-by: Thomas Zimmermann Thanks, patch looks good to me: Reviewed-by: Hans de Goede Re

[PATCH v2 1/1] MAINTAINERS: .mailmap: Update Hans de Goede's email address

2025-06-09 Thread Hans de Goede
I'm moving all my kernel work over to using my kernel.org email address. Update .mailmap and MAINTAINER entries still using hdego...@redhat.com. Signed-off-by: Hans de Goede --- .mailmap| 1 + MAINTAINERS | 72 ++--- 2 files change

[PATCH v2 0/1] MAINTAINERS: .mailmap: Update Hans de Goede's email address

2025-06-09 Thread Hans de Goede
ystem maintainers. But when I tried to implement that it became a bit messy. So now this is just one patch updating all entries in one go. Regards, Hans Hans de Goede (1): MAINTAINERS: .mailmap: Update Hans de Goede's email address .mailmap| 1 + MAINTA

Re: [PATCH 5/5] drm: panel-orientation-quirks: Add Zotac Gaming Zone quirk

2025-03-17 Thread Hans de Goede
Hi, On 22-Feb-25 17:43, Antheas Kapenekakis wrote: > The Zotac Gaming Zone handheld features a 1080p portrait OLED screen. > Add the rotation to the panel orientation quirks. > > Signed-off-by: Antheas Kapenekakis > --- > drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++ > 1 file chang

Re: [PATCH 3/5] drm: panel-orientation-quirks: Add OneXPlayer F1Pro quirk

2025-03-17 Thread Hans de Goede
> Signed-off-by: Antheas Kapenekakis Thanks, patch looks good to me: Reviewed-by: Hans de Goede drm-misc maintainers, I'm dealing with a huge backlog of patch-review, bugs and other work. So I would appreciate it if one of you can merge patches 1-3 into drm-misc. Regards, Hans &

Re: [PATCH 2/5] drm: panel-orientation-quirks: Add OneXPlayer X1 Mini (AMD) quirk

2025-03-17 Thread Hans de Goede
ooks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c > b/drivers/gpu/drm/drm_panel_orientation_quirks.c &

Re: [PATCH 1/5] drm: panel-orientation-quirks: Add OneXPlayer X1 AMD and Intel quirk

2025-03-17 Thread Hans de Goede
ks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > drivers/gpu/drm/drm_panel_orientation_quirks.c | 18 ++ > 1 file changed, 18 insertions(+) > > diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c > b/drivers/gpu/drm/drm_p

Re: [PATCH] drm: panel-orientation-quirks: Add ZOTAC Gaming Zone

2025-03-15 Thread Hans de Goede
Hi, On 13-Mar-25 10:16 PM, Vicki Pfau wrote: > Add a panel orientation quirk for the ZOTAC Gaming Zone handheld gaming > device. > > Signed-off-by: Vicki Pfau Thanks, patch looks good to me: Reviewed-by: Hans de Goede drm-misc maintainers, I'm dealing with a huge backlo

Re: [PATCH v2 0/5] Handheld gaming PC panel orientation quirks

2025-02-12 Thread Hans de Goede
Hi, On 12-Feb-25 12:11 PM, Thomas Zimmermann wrote: > Hi > > Am 12.02.25 um 11:51 schrieb Hans de Goede: >> Hi Thomas, >> >> On 11-Feb-25 2:55 PM, Thomas Zimmermann wrote: >>> Hi >>> >>> Am 24.01.25 um 21:46 schrieb John Edwards: >>>

Re: [PATCH v2 2/5] drm: panel-orientation-quirks: Add quirks for AYA NEO Flip DS and KB

2025-02-12 Thread Hans de Goede
Hi, Thank you for your patches and sorry for being slow to respond. On 24-Jan-25 9:46 PM, John Edwards wrote: > From: Andrew Wyatt > > The AYA NEO Flip DS and KB both use a 1080x1920 portrait LCD panel. The > Flip DS additionally uses a 640x960 portrait LCD panel as a second display. > > Add

Re: [PATCH v2 0/5] Handheld gaming PC panel orientation quirks

2025-02-12 Thread Hans de Goede
rk for 3 new entries added in patches 2/5 + 3/5: "Since this '}' is closing the .matches initializer it should be indented 2 tabs" With that fixed, you can add my: Reviewed-by: Hans de Goede to the entire series. > for the series. Let me know if you need assistance fo

Re: [PATCH v2 3/5] drm: panel-orientation-quirks: Add quirk for AYA NEO Slide

2025-02-12 Thread Hans de Goede
Hi, On 24-Jan-25 9:46 PM, John Edwards wrote: > From: Andrew Wyatt > > The AYANEO Slide uses a 1080x1920 portrait LCD panel. This is the same > panel used on the AYANEO Air Plus, but the DMI data is too different to > match both with one entry. > > Add a DMI match to correctly rotate the panel

Re: [PATCH v3] vbox: Enable VBOXGUEST and VBOXSF_FS on ARM64

2025-01-07 Thread Hans de Goede
MacBook Pro with the latest Virtualbox 7.1.4 r165100 installed. > > Signed-off-by: Christian Kujau > Reviewed-by: Hans de Goede Thank you for the new version, note that v2 has already been applied to the vfs tree though. This is fine, the missing changelog is really not a big deal a

Re: [PATCH v2] vbox: Enable VBOXGUEST and VBOXSF_FS on ARM64

2025-01-06 Thread Hans de Goede
Pro with the latest Virtualbox 7.1.4 r165100 installed. > > Signed-off-by: Christian Kujau Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > drivers/virt/vboxguest/Kconfig | 2 +- > fs/vboxsf/Kconfig | 2 +- > 2 files changed

Re: [PATCH] vbox: arm64 support for vboxguest

2025-01-06 Thread Hans de Goede
Hi Christian, Thank you for your patch. On 15-Dec-24 8:52 PM, Christian Kujau wrote: > My last email[0] still had "RFC" in the subject line, but no comments were > received. So, in an attempt of stupi^W boldness, this is the same patch > again, with RFC removed and ready for mainline, maybe? >

Re: [PATCH] drm/vboxvideo: Remove unused hgsmi_cursor_position

2024-12-16 Thread Hans de Goede
Remove it. > > Signed-off-by: Dr. David Alan Gilbert Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > drivers/gpu/drm/vboxvideo/hgsmi_base.c | 37 - > drivers/gpu/drm/vboxvideo/vboxvideo_guest.h | 2 -- > 2 files chan

[PATCH] drm/i915/bios: Apply vlv_fixup_mipi_sequences() to v2 mipi-sequences too

2024-11-16 Thread Hans de Goede
ng on the Acer Iconia One 8 A1-840. Signed-off-by: Hans de Goede --- drivers/gpu/drm/i915/display/intel_bios.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c index bed4853

Re: [PATCH 1/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO NB04 devices

2024-10-22 Thread Hans de Goede
Hi Armin, On 21-Oct-24 10:26 PM, Armin Wolf wrote: > Am 11.10.24 um 17:26 schrieb Pavel Machek: > >> Hi! >> 1. https://lore.kernel.org/all/6b32fb73-0544-4a68-95ba-e82406a4b...@gmx.de/ -> Should be no problem? Because this is not generally exposing wmi calls, just mapping two e

Re: [PATCH] drm/radeon: add late_register for connector

2024-10-03 Thread Hans de Goede
igned-off-by: Wu Hoi Pok Thank you both for the Cc and the patch. I can confirm that this fixes the crash which I was seeing. Also IHMO this should have a fixes tag for the original commit introducing the problem: Fixes: 90985660ba48 ("drm/radeon: remove load callback from kms_driver") Te

[PATCH 6.12 regression fix 2/2] drm/radeon: Revert: "use GEM references instead of TTMs"

2024-10-03 Thread Hans de Goede
29.315381] __fput+0xfc/0x2c0 Revert the change to restore things back to working order. Fixes: fd69ef05029f ("drm/radeon: use GEM references instead of TTMs") Signed-off-by: Hans de Goede --- drivers/gpu/drm/radeon/radeon_gem.c| 2 +- drivers/gpu/drm/radeon/radeon_object.c | 7 +--

[PATCH 6.12 regression fix 1/2] drm/radeon: Revert: "remove load callback from kms_driver"

2024-10-03 Thread Hans de Goede
Revert the change to avoid this crash. Fixes: 90985660ba48 ("drm/radeon: remove load callback from kms_driver") Signed-off-by: Hans de Goede --- Cc: Thomas Zimmermann Cc: Wu Hoi Pok --- drivers/gpu/drm/radeon/radeon_drv.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --g

[PATCH 6.12 regression fix 0/2] drm/radeon regression fixes

2024-10-03 Thread Hans de Goede
cases. Both patches have a stacktrace in their commit message and I'm willing to try other ways of fixing things. Regards, Hans Hans de Goede (2): drm/radeon: Revert: "remove load callback from kms_driver" drm/radeon: Revert: "use GEM references instead of TTMs"

Re: [PATCH 1/3] drm: panel-orientation-quirks: Add quirk for AYA NEO 2 model

2024-09-22 Thread Hans de Goede
x27;t > seem really sorted It is sorted but it is sorted by the Vendor - Model in the comments, not by the DMI strings since sometimes those are e.g. "SYS_VENDOR", "Default String" and stuff like that. The entire series looks good to me: Reviewed-by: Hans de Goede for t

[PATCH resend] drm/vboxvideo: Replace fake VLA at end of vbva_mouse_pointer_shape with real VLA

2024-08-27 Thread Hans de Goede
ote as mentioned in the added comment it seems the original length calculation for the allocated and send hgsmi buffer is 4 bytes too large. Changing this is not the goal of this patch, so this behavior is kept. Signed-off-by: Hans de Goede --- Resend, can I get an ack from someone to push this

[PATCH] drm: panel-orientation-quirks: Make Lenovo Yoga Tab 3 X90F DMI match less strict

2024-08-25 Thread Hans de Goede
ct-name check is not necessary. Drop the product-name check so that the existing DMI match for the 4G RAM version also matches the 2G RAM version. Signed-off-by: Hans de Goede --- drivers/gpu/drm/drm_panel_orientation_quirks.c | 1 - 1 file changed, 1 deletion(-) diff --g

Re: [PATCH] drm/i915/dsi: Make Lenovo Yoga Tab 3 X90F DMI match less strict

2024-08-24 Thread Hans de Goede
Hi, On 8/23/24 9:41 PM, Rodrigo Vivi wrote: > On Fri, Aug 23, 2024 at 07:34:39PM +0200, Hans de Goede wrote: >> Hi, >> >> On 8/23/24 10:22 AM, Jani Nikula wrote: >>> On Fri, 23 Aug 2024, Hans de Goede wrote: >>>> There are 2G and 4G RAM versions of th

Re: [PATCH] drm/i915/dsi: Make Lenovo Yoga Tab 3 X90F DMI match less strict

2024-08-23 Thread Hans de Goede
Hi, On 8/23/24 10:22 AM, Jani Nikula wrote: > On Fri, 23 Aug 2024, Hans de Goede wrote: >> There are 2G and 4G RAM versions of the Lenovo Yoga Tab 3 X90F and it >> turns out that the 2G version has a DMI product name of >> "CHERRYVIEW D1 PLATFORM" where as the 4

[PATCH] drm/i915/dsi: Make Lenovo Yoga Tab 3 X90F DMI match less strict

2024-08-23 Thread Hans de Goede
ct-name check is not necessary. Drop the product-name check so that the existing DMI match for the 4G RAM version also matches the 2G RAM version. Signed-off-by: Hans de Goede --- drivers/gpu/drm/i915/display/vlv_dsi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/i915/

[PATCH 3/3] ACPI: video: Add backlight=native quirk for Dell OptiPlex 7760 AIO

2024-08-14 Thread Hans de Goede
ess and the GPU's native backlight control method does work. Add a quirk to use the GPU's native backlight control method on this model. Fixes: 484bae9e4d6a ("platform/x86: Add new Dell UART backlight driver") Closes: https://bugzilla.redhat.com/show_bug.cgi?id=2303936 C

[PATCH 0/3] ACPI/video / platform/x86: Add backlight=native quirk for Dell OptiPlex 7760 AIO

2024-08-14 Thread Hans de Goede
any other drivers/apci/video_detect.c DMI quirks show up this cycle. Regards, Hans Hans de Goede (3): ACPI: video: Add Dell UART backlight controller detection platform/x86: dell-uart-backlight: Use acpi_video_get_backlight_type() ACPI: video: Add backlight=native quirk for Dell OptiPlex

[PATCH 2/3] platform/x86: dell-uart-backlight: Use acpi_video_get_backlight_type()

2024-08-14 Thread Hans de Goede
tually be used. This allows reusing the existing ACPI video-detect infra to override the backlight control method on the commandline or with DMI quirks. Fixes: 484bae9e4d6a ("platform/x86: Add new Dell UART backlight driver") Cc: sta...@vger.kernel.org Signed-off-by: Hans de Goede --- dri

[PATCH 1/3] ACPI: video: Add Dell UART backlight controller detection

2024-08-14 Thread Hans de Goede
light control. Add support to acpi_video_get_backlight_type() for a new dell_uart backlight type. So that the existing infra to override the backlight control method on the commandline or with DMI quirks can be used. Fixes: 484bae9e4d6a ("platform/x86: Add new Dell UART backlight driver") Cc: sta...@vger

Re: [PATCH RESEND 0/2] drm: panel-orientation-quirks: Add quirks for AYN loki zero/max

2024-08-12 Thread Hans de Goede
quirk for Ayn Loki Max > > drivers/gpu/drm/drm_panel_orientation_quirks.c | 12 > 1 file changed, 12 insertions(+) Thanks, both patches look good to me: Reviewed-by: Hans de Goede I have pushed this to drm-misc-fixes now, sorry for being a bit slow with picking these up. Regards, Hans

Re: [PATCH v2 0/3] drm: backlight quirk infrastructure and lower minimum for Framework AMD 13

2024-08-05 Thread Hans de Goede
Hi Thomas, On 6/23/24 10:51 AM, Thomas Weißschuh wrote: > The value of "min_input_signal" returned from ATIF on a Framework AMD 13 > is "12". This leads to a fairly bright minimum display backlight. > > Add a generic quirk infrastructure for backlight configuration to > override the settings prov

Re: [PATCH 0/2] Use pcim_request_region() in vboxvideo

2024-08-01 Thread Hans de Goede
ions(-) > > Given an ack from the vboxvideo maintainers, I can apply both of these > via the PCI tree so there's no race during the merge window. I'm the vboxvideo maintainer, merging both through the PCI tree sounds good to me: Acked-by: Hans de Goede Regards, Hans

Re: [PATCH 0/2] Use pcim_request_region() in vboxvideo

2024-08-01 Thread Hans de Goede
region request, so it is a suitable > first user. I have given both patches a test-run on top of 6.11-rc1 in a VirtualBox VM using the vboxsvga virtual vga card: Tested-by: Hans de Goede Also both patches look good to me: Reviewed-by: Hans de Goede for the series. Regards, Hans

Re: [PATCH v3 0/2] drm: minimum backlight overrides and implementation for amdgpu

2024-08-01 Thread Hans de Goede
Hi, On 7/31/24 10:55 PM, Daniel Vetter wrote: > On Wed, Jul 31, 2024 at 08:40:12PM +0300, Jani Nikula wrote: >> On Wed, 31 Jul 2024, Thomas Weißschuh wrote: >>> The value of "min_input_signal" returned from ATIF on a Framework AMD 13 >>> is "12". This leads to a fairly bright minimum display back

Re: [PATCH v2 0/3] drm: backlight quirk infrastructure and lower minimum for Framework AMD 13

2024-07-22 Thread Hans de Goede
Hi Thomas, On 7/20/24 9:31 AM, Thomas Weißschuh wrote: > Hi Hans, > > On 2024-07-18 10:25:18+0000, Hans de Goede wrote: >> On 6/24/24 6:15 PM, Thomas Weißschuh wrote: >>> On 2024-06-24 11:11:40+, Hans de Goede wrote: >>>> On 6/23/24 10:51 AM, Thomas

Re: [PATCH v2 0/3] drm: backlight quirk infrastructure and lower minimum for Framework AMD 13

2024-07-18 Thread Hans de Goede
Hi Thomas, On 6/24/24 6:15 PM, Thomas Weißschuh wrote: > Hi Hans! > > thanks for your feedback! > > On 2024-06-24 11:11:40+, Hans de Goede wrote: >> On 6/23/24 10:51 AM, Thomas Weißschuh wrote: >>> The value of "min_input_signal" returned from ATIF

Re: [PATCH] drm: panel-orientation-quirks: Add quirk for OrangePi Neo

2024-07-15 Thread Hans de Goede
Hi, On 7/15/24 6:57 AM, Philip Mueller wrote: > This adds a DMI orientation quirk for the OrangePi Neo Linux Gaming Handheld. > > Signed-off-by: Philip Mueller Thanks, patch looks good to me: Reviewed-by: Hans de Goede I have pushed this to drm-misc-fixes now. Regar

Re: [PATCH v2 0/3] drm: backlight quirk infrastructure and lower minimum for Framework AMD 13

2024-06-24 Thread Hans de Goede
Hi Thomas, On 6/23/24 10:51 AM, Thomas Weißschuh wrote: > The value of "min_input_signal" returned from ATIF on a Framework AMD 13 > is "12". This leads to a fairly bright minimum display backlight. > > Add a generic quirk infrastructure for backlight configuration to > override the settings prov

Re: [PATCH v2 1/3] drm: Add panel backlight quirks

2024-06-24 Thread Hans de Goede
Hi Thomas, On 6/23/24 10:51 AM, Thomas Weißschuh wrote: > Panels using a PWM-controlled backlight source without an do not have a > standard way to communicate their valid PWM ranges. > On x86 the ranges are read from ACPI through driver-specific tables. > The built-in ranges are not necessarily c

Re: [PATCH v2 1/3] drm: Add panel backlight quirks

2024-06-23 Thread Hans de Goede
Hi, On 6/23/24 10:20 PM, Mario Limonciello wrote: > On 6/23/2024 03:51, Thomas Weißschuh wrote: >> Panels using a PWM-controlled backlight source without an do not have a >> standard way to communicate their valid PWM ranges. >> On x86 the ranges are read from ACPI through driver-specific tables.

Re: [PATCH RESEND] drm: panel-orientation-quirks: Add quirk for Aya Neo KUN

2024-06-10 Thread Hans de Goede
> > Trying yet another ping! Also adding Hans to the list of recipients, as he > committed the last quirk for an Ayaneo device. Someone pick this up, pretty > please! :-) Thank you for Cc-ing me and thank you for your patch. This looks good to me: Reviewed-by: Hans de Goede I&#x

Re: [PATCH] drm/tiny: add missing MODULE_DESCRIPTION() macros

2024-06-10 Thread Hans de Goede
RNING: modpost: missing MODULE_DESCRIPTION() in > drivers/gpu/drm/tiny/gm12u320.o > > Add the missing invocations of the MODULE_DESCRIPTION() macro. > > Signed-off-by: Jeff Johnson Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > drivers/gpu/drm/t

Re: [PATCH v1 1/1] treewide: Align match_string() with sysfs_match_string()

2024-06-04 Thread Hans de Goede
v6.10-rcX, or in Linux Next. > > But if you think differently, tell me. Thanks, the drivers/platform/x86 bits look good to me: Acked-by: Hans de Goede Regards, Hans > arch/powerpc/xmon/xmon.c | 5 ++-- > arch/x86/kernel/cpu/mtrr/if.c | 4 +

Re: [PATCH] arch: Fix name collision with ACPI's video.o

2024-05-17 Thread Hans de Goede
s") > Cc: Arnd Bergmann > Cc: linux-a...@vger.kernel.org > Cc: linux-fb...@vger.kernel.org > Cc: dri-devel@lists.freedesktop.org Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > arch/sparc/video/Makefile| 2 +- >

Re: [PATCH] ACPI: video: Fix name collision with architecture's video.o

2024-05-16 Thread Hans de Goede
Hi, On 5/16/24 5:11 PM, Thomas Zimmermann wrote: > Hi > > Am 16.05.24 um 17:03 schrieb Hans de Goede: >> Hi, >> >> On 5/16/24 3:04 PM, Rafael J. Wysocki wrote: >>> CC Hans who has been doing the majority of the ACPI video work. >>> >>

Re: [PATCH] ACPI: video: Fix name collision with architecture's video.o

2024-05-16 Thread Hans de Goede
Hi, On 5/16/24 3:04 PM, Rafael J. Wysocki wrote: > CC Hans who has been doing the majority of the ACPI video work. > > On Thu, May 16, 2024 at 2:43 PM Thomas Zimmermann wrote: >> >> Commit 2fd001cd3600 ("arch: Rename fbdev header and source files") >> renames the video source files under arch/ s

Re: Safety of opening up /dev/dma_heap/* to physically present users (udev uaccess tag) ?

2024-05-07 Thread Hans de Goede
Hi Dmitry, On 5/7/24 3:32 PM, Dmitry Baryshkov wrote: > On Mon, May 06, 2024 at 01:49:17PM +0200, Hans de Goede wrote: >> Hi dma-buf maintainers, et.al., >> >> Various people have been working on making complex/MIPI cameras work OOTB >> with mainline Linux kernels

Re: Safety of opening up /dev/dma_heap/* to physically present users (udev uaccess tag) ?

2024-05-06 Thread Hans de Goede
Hi Sima, On 5/6/24 3:38 PM, Daniel Vetter wrote: > On Mon, May 06, 2024 at 02:05:12PM +0200, Maxime Ripard wrote: >> Hi, >> >> On Mon, May 06, 2024 at 01:49:17PM GMT, Hans de Goede wrote: >>> Hi dma-buf maintainers, et.al., >>> >>> Various people

Re: Safety of opening up /dev/dma_heap/* to physically present users (udev uaccess tag) ?

2024-05-06 Thread Hans de Goede
Hi Maxime, On 5/6/24 2:05 PM, Maxime Ripard wrote: > Hi, > > On Mon, May 06, 2024 at 01:49:17PM GMT, Hans de Goede wrote: >> Hi dma-buf maintainers, et.al., >> >> Various people have been working on making complex/MIPI cameras work OOTB >> with mainline Linux ke

Safety of opening up /dev/dma_heap/* to physically present users (udev uaccess tag) ?

2024-05-06 Thread Hans de Goede
Hi dma-buf maintainers, et.al., Various people have been working on making complex/MIPI cameras work OOTB with mainline Linux kernels and an opensource userspace stack. The generic solution adds a software ISP (for Debayering and 3A) to libcamera. Libcamera's API guarantees that buffers handed to

Re: [PATCH v2 15/43] drm/tiny/gm12u320: Use fbdev-shmem

2024-04-10 Thread Hans de Goede
Hi, On 4/10/24 3:02 PM, Thomas Zimmermann wrote: > Implement fbdev emulation with fbdev-shmem. Avoids the overhead of > fbdev-generic's additional shadow buffering. No functional changes. > > Signed-off-by: Thomas Zimmermann > Cc: Hans de Goede Thanks, patch looks good

[PATCH] drm/vboxvideo: Replace fake VLA at end of vbva_mouse_pointer_shape with real VLA

2024-04-03 Thread Hans de Goede
ote as mentioned in the added comment it seems the original length calculation for the allocated and send hgsmi buffer is 4 bytes too large. Changing this is not the goal of this patch, so this behavior is kept. Signed-off-by: Hans de Goede --- drivers/gpu/drm/vboxvideo/hgsmi_base.c | 10

Re: [PATCH v4 10/10] drm/vboxvideo: fix mapping leaks

2024-04-02 Thread Hans de Goede
Hi, On 4/2/24 3:50 PM, Philipp Stanner wrote: > On Thu, 2024-03-28 at 12:55 -0500, Bjorn Helgaas wrote: >> On Fri, Mar 01, 2024 at 12:29:58PM +0100, Philipp Stanner wrote: >>> When the PCI devres API was introduced to this driver, it was >>> wrongly >>> assumed that initializing the device with pc

Re: In kernel virtual HID devices (was Future handling of complex RGB devices on Linux v3)

2024-03-27 Thread Hans de Goede
Hi, On 3/26/24 4:39 PM, Benjamin Tissoires wrote: > On Mar 26 2024, Werner Sembach wrote: >> Hi all, >> >> Am 25.03.24 um 19:30 schrieb Hans de Goede: >> >> [snip] >>>>> If the kernel already handles the custom protocol into generic HID, the >&

Re: In kernel virtual HID devices (was Future handling of complex RGB devices on Linux v3)

2024-03-25 Thread Hans de Goede
Hi Werner, On 3/25/24 5:48 PM, Werner Sembach wrote: > Hi Benjamin, > > Am 25.03.24 um 16:56 schrieb Benjamin Tissoires: >> On Mar 25 2024, Hans de Goede wrote: >>> +Cc: Bentiss, Jiri >>> >>> Hi Werner, >>> >>> On 3/20/24 12:16 PM, Wer

In kernel virtual HID devices (was Future handling of complex RGB devices on Linux v3)

2024-03-25 Thread Hans de Goede
+Cc: Bentiss, Jiri Hi Werner, On 3/20/24 12:16 PM, Werner Sembach wrote: > Hi Hans and the others, > > Am 22.02.24 um 14:14 schrieb Werner Sembach: >> Hi, >> >> Thanks everyone for the exhaustive feedback. And at least this thread is a >> good comprehesive reference for the future ^^. >> >> To

Re: Future handling of complex RGB devices on Linux v3

2024-03-25 Thread Hans de Goede
Hi Werner, On 3/19/24 4:18 PM, Werner Sembach wrote: > Hi Hans, > > Am 18.03.24 um 12:11 schrieb Hans de Goede: >> Hi Werner, >> >> Sorry for the late reply. > np >> >> On 2/22/24 2:14 PM, Werner Sembach wrote: >>> Hi, >>> >>>

Re: Future handling of complex RGB devices on Linux v3

2024-03-18 Thread Hans de Goede
Hi Werner, Sorry for the late reply. On 2/22/24 2:14 PM, Werner Sembach wrote: > Hi, > > Thanks everyone for the exhaustive feedback. And at least this thread is a > good comprehesive reference for the future ^^. > > To recap the hopefully final UAPI for complex RGB lighting devices: > > - By

Re: [PATCH v4 10/10] drm/vboxvideo: fix mapping leaks

2024-03-03 Thread Hans de Goede
; Fixes: 8558de401b5f ("drm/vboxvideo: use managed pci functions") > Signed-off-by: Philipp Stanner Thanks, patch looks good to me: Reviewed-by: Hans de Goede Since this depends on the pcim_iomap_range() function which is new in this series and since the vboxvideo code does not see

Re: [PATCH 2/2] fbcon: Defer console takeover for splash screens to first switch

2024-02-28 Thread Hans de Goede
Hi Daniel, On 2/28/24 03:00, Daniel van Vugt wrote: > On 27/2/24 21:47, Hans de Goede wrote: > I think some boot failures also take you to the grub menu automatically next > time? In Fedora all boot failures will unhide the grub menu on the next boot. This unfortunately relies on d

Re: [PATCH 2/2] fbcon: Defer console takeover for splash screens to first switch

2024-02-27 Thread Hans de Goede
Hi, On 2/27/24 02:06, Daniel van Vugt wrote: > On 27/2/24 02:23, Hans de Goede wrote: >> Hi All, >> >> On 2/2/24 09:53, Daniel van Vugt wrote: >>> Until now, deferred console takeover only meant defer until there is >>> output. But that risks stepping

Re: [PATCH 2/2] fbcon: Defer console takeover for splash screens to first switch

2024-02-26 Thread Hans de Goede
Hi All, On 2/2/24 09:53, Daniel van Vugt wrote: > Until now, deferred console takeover only meant defer until there is > output. But that risks stepping on the toes of userspace splash screens, > as console messages may appear before the splash screen. So check for the > "splash" parameter (as use

Re: [PATCH 1/2] devm-helpers: Add resource managed version of mutex init

2024-02-22 Thread Hans de Goede
Hi, On 2/22/24 17:44, Matthew Auld wrote: > On 22/02/2024 14:58, Marek Behún wrote: >> A few drivers are doing resource-managed mutex initialization by >> implementing ad-hoc one-liner mutex dropping functions and using them >> with devm_add_action_or_reset(). Help drivers avoid these repeated >>

Re: Future handling of complex RGB devices on Linux v2

2024-02-22 Thread Hans de Goede
Hi, On 2/22/24 12:38, Gregor Riepl wrote: >> This certainly is the most KISS approach. This proposal >> in essence is just an arbitrary command multiplexer / >> demultiplexer and ioctls already are exactly that. >> >> With the added advantage of being able to directly use >> pass the vendor-cmd-sp

Re: Future handling of complex RGB devices on Linux v2

2024-02-22 Thread Hans de Goede
Hi, On 2/21/24 23:17, Pavel Machek wrote: > Hi! > >> so after more feedback from the OpenRGB maintainers I came up with an even >> more generic proposal: >> https://gitlab.com/CalcProgrammer1/OpenRGB/-/issues/3916#note_1753072869 > >>> evaluate-set-command ioctl taking: >>> { >>>     enum comman

Re: Implement per-key keyboard backlight as auxdisplay?

2024-01-30 Thread Hans de Goede
Hi, On 1/30/24 20:08, Werner Sembach wrote: > Hi, > > Am 30.01.24 um 19:35 schrieb Hans de Goede: >> Hi, >> >> On 1/30/24 19:09, Werner Sembach wrote: >>> Hi Hans, >>> >>> resend because Thunderbird htmlified the mail :/ >> I use thunde

Re: Implement per-key keyboard backlight as auxdisplay?

2024-01-30 Thread Hans de Goede
sages in HTML format" I think that should do the trick. > Am 30.01.24 um 18:10 schrieb Hans de Goede: >> Hi Werner, >> >> On 1/30/24 12:12, Werner Sembach wrote: >>> Hi Hans, >>> >>> Am 29.01.24 um 14:24 schrieb Hans de Goede: > >>>

Re: Implement per-key keyboard backlight as auxdisplay?

2024-01-30 Thread Hans de Goede
Hi Werner, On 1/30/24 12:12, Werner Sembach wrote: > Hi Hans, > > Am 29.01.24 um 14:24 schrieb Hans de Goede: >> That sounds workable OTOH combined with your remarks about also supporting >> lightbars. I'm starting to think that we need to just punt this to use

Re: Implement per-key keyboard backlight as auxdisplay?

2024-01-29 Thread Hans de Goede
Hi Werner, On 1/19/24 17:04, Werner Sembach wrote: > Am 19.01.24 um 09:44 schrieb Hans de Goede: >> So my proposal would be an ioctl interface (ioctl only no r/w) >> using /dev/rgbkbd0 /dev/rgbkdb1, etc. registered as a misc chardev. >> >> For per key controllable rg

Re: Implement per-key keyboard backlight as auxdisplay?

2024-01-29 Thread Hans de Goede
Hi, On 1/19/24 21:15, Pavel Machek wrote: > Hi! > 2. Implement per-key keyboards as auxdisplay     - Pro:         - Already has a concept for led positions         - Is conceptually closer to "multiple leds forming a singular entity"     - Con: >

Re: [PATCH v2 10/10] drm/vboxvideo: fix mapping leaks

2024-01-29 Thread Hans de Goede
Hi Philipp, On 1/23/24 10:43, Philipp Stanner wrote: > When the PCI devres API was introduced to this driver, it was wrongly > assumed that initializing the device with pcim_enable_device() instead > of pci_enable_device() will make all PCI functions managed. > > This is wrong and was caused by t

Re: Implement per-key keyboard backlight as auxdisplay?

2024-01-19 Thread Hans de Goede
Hi, On 1/18/24 18:45, Pavel Machek wrote: > Hi! > >> We have an upcoming device that has a per-key keyboard backlight, but does >> the control completely via a wmi/acpi interface. So no usable hidraw here >> for a potential userspace driver implementation ... >> >> So a quick summary for the idea

Re: Userspace API for per key backlight for non HID (no hidraw) keyboards

2024-01-17 Thread Hans de Goede
Hi All, On 11/27/23 11:59, Werner Sembach wrote: > I also stumbled across a new Problem: > > We have an upcoming device that has a per-key keyboard backlight, but does > the control completely via a wmi/acpi interface. So no usable hidraw here for > a potential userspace driver implementatio

Re: Implement per-key keyboard backlight as auxdisplay?

2024-01-17 Thread Hans de Goede
Hi Werner, Once again, sorry for the very slow response here. On 11/27/23 11:59, Werner Sembach wrote: > Hi Hans, > > Am 22.11.23 um 19:34 schrieb Hans de Goede: >> Hi Werner, > [snip] >>>>> Another idea I want to throw in the mix: >>>>>

Re: [PATCH] fbdev/simplefb: change loglevel when the power domains cannot be parsed

2023-12-14 Thread Hans de Goede
Hi, On 12/12/23 20:57, Brian Masney wrote: > When the power domains cannot be parsed, the message is incorrectly > logged as an info message. Let's change this to an error since an error > is returned. > > Fixes: 92a511a568e4 ("fbdev/simplefb: Add support for generic power-domains") > Signed-off-

[PATCH] drm/i915/dsi: Use devm_gpiod_get() for all GPIOs

2023-12-01 Thread Hans de Goede
soc_gpio_set_value() already uses devm_gpiod_get(), lets be consistent and use devm_gpiod_get() for all GPIOs. This allows removing the intel_dsi_vbt_gpio_cleanup() function, which only function was to put the GPIO-descriptors. Signed-off-by: Hans de Goede --- Note this applies on top of Andy&#

Re: Implement per-key keyboard backlight as auxdisplay?

2023-11-22 Thread Hans de Goede
Hi Werner, On 11/21/23 14:29, Werner Sembach wrote: > > Am 21.11.23 um 13:20 schrieb Hans de Goede: >> Hi Werner, >> >> On 11/21/23 12:33, Werner Sembach wrote: >>> Hi, >>> >>> Am 20.11.23 um 21:52 schrieb Pavel Machek: >>>> Hi! >

Re: [PATCH] fbdev/simplefb: Suppress error on missing power domains

2023-11-22 Thread Hans de Goede
Hi, On 11/22/23 01:54, Richard Acayan wrote: > When the power domains are missing, the call to of_count_phandle_with_args > fails with -ENOENT. The power domains are not required and there are > some device trees that do not specify them. Suppress this error to fix > devices without power domains

Re: [PATCH v2 2/2] fbdev/simplefb: Add support for generic power-domains

2023-11-22 Thread Hans de Goede
Hi, On 11/22/23 01:01, Richard Acayan wrote: > On Tue, Nov 21, 2023 at 10:01:18AM +0100, Hans de Goede wrote: >> Hi, >> >> On 11/21/23 02:17, Richard Acayan wrote: >>> Hello, >>> >>> On Wed, Nov 01, 2023 at 06:20:17PM +0100, Thierry Reding wrote:

Re: Implement per-key keyboard backlight as auxdisplay?

2023-11-21 Thread Hans de Goede
Hi Werner, On 11/21/23 12:33, Werner Sembach wrote: > Hi, > > Am 20.11.23 um 21:52 schrieb Pavel Machek: >> Hi! >> > So... a bit of rationale. The keyboard does not really fit into the > LED subsystem; LEDs are expected to be independent ("hdd led") and not > a matrix of them. Ma

Re: [PATCH v2 2/2] fbdev/simplefb: Add support for generic power-domains

2023-11-21 Thread Hans de Goede
Hi, On 11/21/23 02:17, Richard Acayan wrote: > Hello, > > On Wed, Nov 01, 2023 at 06:20:17PM +0100, Thierry Reding wrote: >> From: Thierry Reding >> >> The simple-framebuffer device tree bindings document the power-domains >> property, so make sure that simplefb supports it. This ensures that th

Re: [rft, PATCH v4 00/16] drm/i915/dsi: 4th attempt to get rid of IOSF GPIO

2023-11-16 Thread Hans de Goede
s series is: Tested-by: Hans de Goede And the code of the entire series also looks good to me: Reviewed-by: Hans de Goede for the series. Regards, Hans > In v4: > - fixed compile time errors in patch 14 (Hans, LKP) > - fixed cover letter Subject > - added patch 15 (as suggeste

Re: [PATCH] drm/panel-orientation-quirks: add Lenovo Legion Go

2023-11-15 Thread Hans de Goede
Hi Brenton, On 11/15/23 16:52, Brenton Simpson wrote: > Yes, thanks! > > That's the email attached to my public git work, so it should be the > one here as well. Ok, I've pushed this to drm-misc-fixes now, thank you for the patch. > Sorry for the hassle. Very new to sending PRs over email, and

Re: [PATCH] drm/panel-orientation-quirks: add Lenovo Legion Go

2023-11-15 Thread Hans de Goede
Hi, On 11/15/23 16:48, Brenton Simpson wrote: > Resending from the email address linked to my GitHub account. Ok, this doesn't really help. I'll just fix-up the author field of the original patch. Do understand correctly that both the author and the Signed-off-by should be set to: Brenton Simps

Re: [REGRESSION]: acpi/nouveau: Hardware unavailable upon resume or suspend fails

2023-11-12 Thread Hans de Goede
Hi, On 11/10/23 17:58, Owen T. Heisler wrote: > Hi everyone, > > On 11/10/23 06:52, Kai-Heng Feng wrote: >> On Fri, Nov 10, 2023 at 2:19 PM Hans de Goede wrote: >>> On 11/10/23 07:09, Kai-Heng Feng wrote: >>>> On Fri, Nov 10, 2023 at 5:55 AM Owen T. Heisl

Re: [REGRESSION]: acpi/nouveau: Hardware unavailable upon resume or suspend fails

2023-11-10 Thread Hans de Goede
can you build a v6.6 kernel with these 2 patches added on top please and see if that fixes things ? Kai-Heng can you test that the issue on the HP ZBook Fury 16 G10 is still resolved after applying these patches ? Regards, Hans From 68a819101c580bb89f34a31196ace81244ca8eb5 Mon Sep 17 00:00:00

Re: [PATCH v2 6/9] PCI: Rename is_thunderbolt to is_tunneled

2023-11-03 Thread Hans de Goede
`is_tunneled`. > > Signed-off-by: Mario Limonciello Here is my ack for the trivial drivers/platform/x86/apple-gmux.c change: Acked-by: Hans de Goede Bjorn, feel free to route this through the PCI tree. Regards, Hans > --- > drivers/pci/pci.c | 2 +

Re: [PATCH v3 14/15] drm/i915/dsi: Replace poking of CHV GPIOs behind the driver's back

2023-11-02 Thread Hans de Goede
Hi, On 11/2/23 16:12, Andy Shevchenko wrote: > It's a dirty hack in the driver that pokes GPIO registers behind > the driver's back. Moreoever it might be problematic as simultaneous > I/O may hang the system, see the commit 0bd50d719b00 ("pinctrl: > cherryview: prevent concurrent access to GPIO c

Re: [PATCH v2 6/7] drm/i915/dsi: Replace poking of CHV GPIOs behind the driver's back

2023-11-02 Thread Hans de Goede
Hi, On 11/2/23 15:19, Andy Shevchenko wrote: > On Wed, Nov 01, 2023 at 11:20:23AM +0100, Hans de Goede wrote: >> On 11/1/23 10:32, Andy Shevchenko wrote: >>> On Tue, Oct 31, 2023 at 10:15:52PM +0100, Hans de Goede wrote: >>>> On 10/31/23 17:07, Hans de Goede wrote:

Re: [PATCH v2 0/2] fbdev/simplefb: Add missing simple-framebuffer features

2023-11-02 Thread Hans de Goede
Hi, On 11/1/23 18:54, Hans de Goede wrote: > Hi, > > On 11/1/23 18:20, Thierry Reding wrote: >> From: Thierry Reding >> >> Hi, >> >> This contains two patches that bring simplefb up to feature parity with >> simpledrm. The patches add support for the

Re: [PATCH v2 0/2] fbdev/simplefb: Add missing simple-framebuffer features

2023-11-01 Thread Hans de Goede
ges in v2: > - remove unnecessary call to simplefb_detach_genpds() since that's > already done automatically by devres > - fix crash if power-domains property is missing in DT Thanks, the new version looks good to me: Reviewed-by: Hans de Goede for the series. Helge, wil

  1   2   3   4   5   6   7   8   9   10   >