Re: [PATCH v2 2/3] accel/amdpk: add driver for AMD PKI accelerator

2025-04-17 Thread Gupta, Nipun
On 12-04-2025 06:53, Herbert Xu wrote: On Fri, Apr 11, 2025 at 11:50:54PM +0530, Gupta, Nipun wrote: AFAIU after looking into it, the keyring subsystem is not to perform the data operations, but for managing keys for these operations. Kindly correct me if I am wrong here. Have a look at

Re: [PATCH v2 2/3] accel/amdpk: add driver for AMD PKI accelerator

2025-04-16 Thread Gupta, Nipun
On 14-04-2025 00:22, Lukas Wunner wrote: On Fri, Apr 11, 2025 at 10:21:03AM +0530, Gupta, Nipun wrote: On 10-04-2025 13:06, Krzysztof Kozlowski wrote: On Wed, Apr 09, 2025 at 11:00:32PM GMT, Nipun Gupta wrote: The AMD PKI accelerator driver provides a accel interface to interact with the

Re: [PATCH v2 2/3] accel/amdpk: add driver for AMD PKI accelerator

2025-04-11 Thread Gupta, Nipun
On 11-04-2025 10:47, Herbert Xu wrote: On Fri, Apr 11, 2025 at 10:21:03AM +0530, Gupta, Nipun wrote: added crypto maintainers for comments. IMO, as accel framework is designed to support any type of compute accelerators, the PKI crypto accelerator in accel framework is not completely out of

Re: [PATCH v2 1/3] dt-bindings: accel: add device tree for AMD PKI accelerator

2025-04-11 Thread Gupta, Nipun
On 10-04-2025 12:59, Krzysztof Kozlowski wrote: On Wed, Apr 09, 2025 at 11:00:31PM GMT, Nipun Gupta wrote: + interrupts: +maxItems: 1 + And the resets? I understand from previous email that there is a reset controller. It was not reset controller, those were register from clock cont

Re: [PATCH v2 2/3] accel/amdpk: add driver for AMD PKI accelerator

2025-04-10 Thread Gupta, Nipun
On 10-04-2025 13:06, Krzysztof Kozlowski wrote: On Wed, Apr 09, 2025 at 11:00:32PM GMT, Nipun Gupta wrote: The AMD PKI accelerator driver provides a accel interface to interact with the device for offloading and accelerating asymmetric crypto operations. For me this is clearly a crypto dri