Re: [PATCH v7 1/2] drm/display/dp: Export fn to calculate link symbol cycles

On Thu, 2025-04-24 at 20:45 +0530, Arun R Murthy wrote: > Unify the function to calculate the link symbol cycles for both dsc and > non-dsc case and export the function so that it can be used in the > respective platform display drivers for other calculations. > > v2: unify the fn for both dsc and

Re: [PATCH v6 1/2] drm/display/dp: Export fn to calculate link symbol cycles

Hi, On Thu, 2025-04-24 at 13:52 +0530, Arun R Murthy wrote: > Unify the function to calculate the link symbol cycles for both dsc and > non-dsc case and export the function so that it can be used in the > respective platform display drivers for other calculations. > > v2: unify the fn for both d

Re: [PATCH v3 3/3] drm/i915/display: move min_hblank from dp_mst.c to dp.c

On Tue, 2025-04-22 at 04:49 +, Murthy, Arun R wrote: > > > -Original Message- > > From: Govindapillai, Vinod > > Sent: Tuesday, April 22, 2025 4:17 AM > > To: Murthy, Arun R ; dri- > > de...@lists.freedesktop.org; intel...@lists.freedesktop.org; inte

Re: [PATCH v3 3/3] drm/i915/display: move min_hblank from dp_mst.c to dp.c

Hi Arun I was trying to use this series for the underrun issue! But this patch didnt apply cleanly! And had some compilation issues because of an unused variable! Also I did not get expected traces on min hblank! Not sure if there was any issue on my conflicts resolution to get this applied on m

Re: [PATCH v10 2/9] drm/damage-helper: add const qualifier in drm_atomic_helper_damage_merged()

Hello drm maintainers, Could you please Ack this patch to get this merged through drm-intel-next.. Thanks Vinod On Fri, 2025-02-28 at 11:37 +0200, Vinod Govindapillai wrote: > Add a const qualifier for the "state" parameter as well as we could > use this helper to get the combined damage in case

Re: [PATCH v7 5/7] drm/i915/xe3: avoid calling fbc activate if fbc is active

On Wed, 2025-02-12 at 20:30 +0200, Ville Syrjälä wrote: > On Wed, Feb 12, 2025 at 03:14:18PM +0200, Vinod Govindapillai wrote: > > If FBC is already active, we don't need to call FBC activate > > routine again. This is more relevant in case of dirty rect > > support in FBC. Xe doesn't support legac

Re: [PATCH v7 2/7] drm/i915/xe3: update and store the plane damage clips

On Wed, 2025-02-12 at 20:35 +0200, Ville Syrjälä wrote: > On Wed, Feb 12, 2025 at 03:14:15PM +0200, Vinod Govindapillai wrote: > > Userspace can pass damage area clips per plane to track > > changes in a plane and some display components can utilze > > these damage clips for efficiently handling us

Re: [PATCH 4/4] drm/i915: Add DSC support to MST path

On Thu, 2022-09-01 at 13:11 +0300, Stanislav Lisovskiy wrote: > Whenever we are not able to get enough timeslots > for required PBN, let's try to allocate those > using DSC, just same way as we do for SST. > > v2: Removed intel_dp_mst_dsc_compute_config and refactored >     intel_dp_dsc_compute_co

Re: [PATCH 3/4] drm/i915: Extract drm_dp_atomic_find_vcpi_slots cycle to separate function

Reviewed-by: Vinod Govindapillai Vinod On Thu, 2022-09-01 at 13:11 +0300, Stanislav Lisovskiy wrote: > We would be using almost same code to loop through bpps while calling > drm_dp_atomic_find_vcpi_slots - lets remove this duplication by > introducing a new

Re: [PATCH 4/4] drm/i915: Extract drm_dp_atomic_find_vcpi_slots cycle to separate function

Hi Stan, I wonder if it is better if you reorder the 3 and 4 patches in this - move this 4/4 before the 3rd one and modify the 3rd one accordingly. Also, instead of getting rid of limits, keep limits and populate the limits according to dsc or normal dp_mst. What do you think? BR vinod On Mo

Re: [PATCH 2/4] drm/i915: Fix intel_dp_mst_compute_link_config

Reviewed-by: Vinod Govindapillai On Mon, 2022-08-29 at 12:58 +0300, Stanislav Lisovskiy wrote: > We currently always exit that bpp loop because drm_dp_atomic_find_vcpi_slots > doesn't care if we actually can fit those or not. > I think that wasn't the initial intention here, especially when > we

Re: [Intel-gfx] [PATCH 1/2] drm: Add missing DP DSC extended capability definitions.

Reviewed-by: Vinod Govindapillai On Mon, 2022-08-22 at 12:40 +0300, Stanislav Lisovskiy wrote: > Adding DP DSC register definitions, we might need for further > DSC implementation, supporting MST and DP branch pass-through mode. > > v2: - Fixed checkpatch comment warning > v3: - Removed function

Re: [PATCH 2/2] drm/i915: Add DSC support to MST path

On Thu, 2022-08-25 at 18:17 +0300, Lisovskiy, Stanislav wrote: > On Thu, Aug 25, 2022 at 05:58:19PM +0300, Govindapillai, Vinod wrote: > > Hi Stan, > > > > Some comments inline.. > > > > On Mon, 2022-08-22 at 12:40 +0300, Stanislav Lisovskiy wrote: > > &

Re: [PATCH 2/2] drm/i915: Add DSC support to MST path

Hi Stan, Some comments inline.. On Mon, 2022-08-22 at 12:40 +0300, Stanislav Lisovskiy wrote: > Whenever we are not able to get enough timeslots > for required PBN, let's try to allocate those > using DSC, just same way as we do for SST. > > v2: Removed intel_dp_mst_dsc_compute_config and refact

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Add DSC support to MST path

Hi Stan, Please find my comments inline On Mon, 2022-04-11 at 19:25 +0300, Stanislav Lisovskiy wrote: > Whenever we are not able to get enough timeslots > for required PBN, let's try to allocate those > using DSC, just same way as we do for SST. > > v2: Removed intel_dp_mst_dsc_compute_config a

Re: [PATCH RESEND v6] drm/i915/display: disable HPD workers before display driver unregister

On Fri, 2022-05-20 at 00:35 +0200, Andrzej Hajda wrote: > Handling HPD during driver removal is pointless, and can cause different > use-after-free/concurrency issues: > 1. Setup of deferred fbdev after fbdev unregistration. > 2. Access to DP-AUX after DP-AUX removal. Thanks. Reviewed-by: Vinod G