Re: amdgpu_dm_connector_mode_valid regression

2025-04-24 Thread Gergo Koteles
Hi Marek, On Thu, 2025-04-24 at 10:48 +0200, Marek Marczykowski-Górecki wrote: > On Fri, Apr 11, 2025 at 12:01:28PM +0200, Marek Marczykowski-Górecki wrote: > > > > Hi, > > > > On Wed, Apr 02, 2025 at 04:35:05PM +0200, Gergo Koteles wrote: > > > Hi Dmitry, &

[PATCH] drm/amd/display: do not copy invalid CRTC timing info

2025-04-04 Thread Gergo Koteles
ge mode in amdgpu_dm_connector_mode_valid()") Closes: https://lore.kernel.org/all/ed09edb167e74167a694f4854102a3de6d2f1433.ca...@irl.hu/ Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/4085 Signed-off-by: Gergo Koteles --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 12 +

Re: amdgpu_dm_connector_mode_valid regression

2025-04-02 Thread Gergo Koteles
Hi Dmitry, On Wed, 2025-04-02 at 17:40 +0300, Dmitry Baryshkov wrote: > On Wed, 2 Apr 2025 at 17:35, Gergo Koteles wrote: > > > > Hi Dmitry, > > > > On Wed, 2025-04-02 at 16:36 +0300, Dmitry Baryshkov wrote: > > > > > > > > > > I

Re: amdgpu_dm_connector_mode_valid regression

2025-04-02 Thread Gergo Koteles
Hi Dmitry, On Wed, 2025-04-02 at 16:36 +0300, Dmitry Baryshkov wrote: > > > > > > It works if I call > > > drm_mode_set_crtcinfo((struct drm_display_mode *)mode, 0) before > > > create_validate_stream_for_sink() > > > in amdgpu_dm_connector_mode_valid() > > > > > > or > > > > > > if I comment o

Re: amdgpu_dm_connector_mode_valid regression

2025-04-02 Thread Gergo Koteles
to: Dmitry's new address cc: regressions On Wed, 2025-04-02 at 12:40 +0200, Gergo Koteles wrote: > Hi, > > While playing with > https://lore.kernel.org/all/61c3df83ab73aba0bc7a941a443cd7faf4cf7fb0.1743195250.git.so...@irl.hu/ > > I found a regression that prevented so

amdgpu_dm_connector_mode_valid regression

2025-04-02 Thread Gergo Koteles
Hi, While playing with https://lore.kernel.org/all/61c3df83ab73aba0bc7a941a443cd7faf4cf7fb0.1743195250.git.so...@irl.hu/ I found a regression that prevented some EDID DTDs from being selected in some specific cases. This is the first bad commit: b255ce4 ("drm/amdgpu: don't change mode in amdgpu_

[RFC PATCH] drm/amd/display: Disable panel_power_savings sysfs entry for OLED displays

2024-05-07 Thread Gergo Koteles
The panel_power_savings sysfs entry sets the Adaptive Backlight Management level (abm_level). OLED displays work without backlight, so it is unnecessary for them. Before creating the sysfs entry, make sure the display is not an OLED display. Signed-off-by: Gergo Koteles --- drivers/gpu/drm/amd

Re: [PATCH] drm/amd: Only allow one entity to control ABM

2024-04-13 Thread Gergo Koteles
Hi> > ABM will reduce the backlight and compensate by adjusting brightness and > contrast of the image. It has 5 levels: 0, 1, 2, 3, 4. 0 means off. 4 means > maximum backlight reduction. IMO, 1 and 2 look okay. 3 and 4 can be quite > impactful, both to power and visual fidelity. I tried this