Hsin-Yi Wang writes:
> On Tue, Feb 15, 2022 at 9:17 AM Gabriel Krisman Bertazi
> wrote:
>>
>> Hsin-Yi Wang writes:
>>
>> > drm_dev_register() sets connector->registration_state to
>> > DRM_CONNECTOR_REGISTERED and dev->registered to true. If
>
ect_property_set_value() will be called with a NULL second argument
and Oops the kernel.
> - drm_object_attach_property(&connector->base, prop,
> -info->panel_orientation);
> + drm_object_property_set_value(&connector->base, prop,
> + info->panel_orientation);
--
Gabriel Krisman Bertazi
Hans de Goede writes:
> Hi,
>
> On 18-10-18 21:31, Gabriel Krisman Bertazi wrote:
>> I just got a new GDP Win2 device with an updated firmware, which still
>> requires this quirk to get the rotation right, so add the new firmware
>> date to the quirk matching table.
I just got a new GDP Win2 device with an updated firmware, which still
requires this quirk to get the rotation right, so add the new firmware
date to the quirk matching table.
This should go to drm-misc-next.
Signed-off-by: Gabriel Krisman Bertazi
---
drivers/gpu/drm
Wei Yongjun writes:
> In case of error, the function of_graph_get_remote_node() returns NULL
> pointer not ERR_PTR(). The IS_ERR() test in the return value check
> should be replaced with NULL test..
Looks good.
Reviewed-by: Gabriel Krisman Bertazi
--
Gabriel Krisma
#x27;t rmmod qxl.
>
> I agree that "rmmod qxl" should be fixed, but IMHO this is independent
> from this bugfix, and I'd like to get it out of the door ASAP. Can I
> get your reviewed-by?
Yes, getting this out of the door asap makes total sense to me. Please
add my rev
I can simply disable X, lightdm or whatever is using it and then rmmod.
--
Gabriel Krisman Bertazi
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Gerd Hoffmann writes:
> On Tue, 2017-09-19 at 11:35 -0300, Gabriel Krisman Bertazi wrote:
>> Gerd Hoffmann writes:
>>
>> > qxl_plane_cleanup_fb() unpins the just activated framebuffer
>> > instead of the old one. Oops. Fix it.
>> >
&g
Gerd Hoffmann writes:
> qxl_plane_cleanup_fb() unpins the just activated framebuffer
> instead of the old one. Oops. Fix it.
>
> Cc: Gabriel Krisman Bertazi
> Fixes: 1277eed5fecb8830c8cc414ad70c1ef640464bc0
> Signed-off-by: Gerd Hoffmann
> ---
> drivers/gpu/d
on't try to update the primary surface in case
> it already has the state we want it being in.
>
Reviewed-by: Gabriel Krisman Bertazi
--
Gabriel Krisman Bertazi
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
plane_formats,
> +ARRAY_SIZE(cirrus_plane_formats),
> +DRM_PLANE_TYPE_PRIMARY, NULL);
> + if (ret)
> + goto cleanup;
If this fails early enough, you can't call drm_pla
lidate(&bo->bo, &bo->placement, false, false);
> if (ret) {
> DRM_ERROR("pushing to VRAM failed\n");
> - return ret;
> + goto out;
> }
> - return 0;
> +
> +out:
>
Mike Galbraith writes:
> On Thu, 2017-05-18 at 17:40 -0300, Gabriel Krisman Bertazi wrote:
>> > Mike Galbraith writes:
>>
>> >
>> > On Mon, 2017-05-08 at 16:48 -0300, Gabriel Krisman Bertazi wrote:
>> >
>> > >
>> > > Tha
R14: 0040 R15:
7ffcd3e5062c
Reported-by: Mike Galbraith
Signed-off-by: Gabriel Krisman Bertazi
---
drivers/gpu/drm/qxl/qxl_display.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/qxl/qxl_display.c
b/drivers/gpu/drm/qxl/qxl_display.c
in
Daniel Vetter writes:
> On Wed, May 17, 2017 at 03:43:18PM -0300, Gabriel Krisman Bertazi wrote:
>> Daniel Vetter writes:
>>
>> > On Thu, Apr 20, 2017 at 09:38:19PM -0300, Gabriel Krisman Bertazi wrote:
>> >> While reading drm_for_each_co
Mike Galbraith writes:
> On Mon, 2017-05-08 at 16:48 -0300, Gabriel Krisman Bertazi wrote:
>
>> Thanks for reporting this. Can you confirm the following patch prevents
>> the issue?
>
> Nope, it still gripes.
Oops... Thanks for checking. The following patch fixes th
Daniel Vetter writes:
> On Thu, Apr 20, 2017 at 09:38:19PM -0300, Gabriel Krisman Bertazi wrote:
>> While reading drm_for_each_connector_iter, I noticed a mention to
>> drm_connector_begin which doesn't exist. It should be
>> drm_connector_get.
>>
>>
against Mesa Security team?
This is stopping me from replying, since I don't have access to Mesa
Security bugs.
It feels like you should have reported it against the DRI product and
DRM/Intel component, since it looks like a DRM driver bug.
--
Gabriel Krisman Bertazi
Mike Galbraith writes:
> On Tue, 2017-05-09 at 04:37 +0200, Mike Galbraith wrote:
>> On Mon, 2017-05-08 at 16:48 -0300, Gabriel Krisman Bertazi wrote:
>>
>> > Thanks for reporting this. Can you confirm the following patch prevents
>> > the issue?
>>
&
Thanks for reporting this. Can you confirm the following patch prevents
the issue?
>8
From 407213129ef4a687378563cbb6ca78faa23f33bd Mon Sep 17 00:00:00 2001
From: Gabriel Krisman Bertazi
Date: Mon, 8 May 2017 16:47:22 -0300
Subject: [PATCH] drm: qxl: Suffle allocations in atomic cursor u
Masahiro Yamada writes:
> Include instead of relative path from include/drm, then
> remove the -Iinclude/drm compiler flag.
>
> Signed-off-by: Masahiro Yamada
Please add
Reviewed-by: Gabriel Krisman Bertazi
for this and patch 1.
Thanks,
--
Gabriel Kri
While reading drm_for_each_connector_iter, I noticed a mention to
drm_connector_begin which doesn't exist. It should be
drm_connector_get.
Signed-off-by: Gabriel Krisman Bertazi
---
include/drm/drm_connector.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/includ
land/commit/?id=0eefe99fe0683ae409b665a8b18cc7eb648c6c0c
>
> Cc: Daniel Stone
> Cc: Keith Packard
> Cc: tfh...@err.no
> Signed-off-by: Daniel Vetter
Acked-by: Gabriel Krisman Bertazi
--
Gabriel Krisman Bertazi
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Jani Nikula writes:
>> +
>> +git commit --amend -s
>
> I think the intention is to just add the signoff, but this ends up
> trying to fire up the editor, which is really not good for piping.
>
You probably want --no-edit for that.
--
at
>>0620
>>[ 195.349309] IP: __lock_acquire+0xc8/0xfe6
>
>
> Sorry that looks like an old bug. While the below soft lockup
> call trace looks more related to the code change.
>
Hi,
For the record, I suspect the Null point
00 00 00 48 39 c2 74 46 48 8b 83 d8 00 00 00 48 8b 93 d0 00 00 00 <48> 89
42 08 48 89 10 48 b8 00 01 00 00 ad de 48 89 83 d0
[ 17.652101] RIP: drm_fb_helper_fini+0x8e/0x110 RSP: c9d87ad0
[ 17.653331] ---[ end trace 542fd75a2e60a6a4 ]---
Signed-off-by: Gabriel Krisman B
kernel test robot writes:
> FYI, we noticed the following commit:
>
> commit: f04f7e3e041aab12abbf3ed7b854446af5a624a9 ("drm: bochs: Don't
> remove uninitialized fbdev framebuffer")
> url:
> https://github.com/0day-ci/linux/commits/Gabriel-Krisman-Bertazi/drm
*, void*);
> + /** @driver_features: Required driver features for this entry */
> + u32 driver_features;
> + /** @data: Driver-private data, should not be device-specific. */
> void *data;
> };
>
> /**
> - * debugfs node structure. This structure represe
Daniel Vetter writes:
> It's the default storage class for functions, entirely redundant. And
> a lot of these headers are a bit inconsistent due to organically
> grown.
>
Reviewed-by: Gabriel Krisman Bertazi
--
Gabriel Krisman Bertazi
__
CONFIG_DRM_VM, for instance, which
hid some of the code for legacy drivers is the downside of requiring
recompilation of drm.ko before using a legacy driver.
Anyway, if you agree with this change, can you keep this entry until
that is done?
--
Gabriel Krisman Bertazi
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
ff ff 5b 5d c3
[ 112.176009] RIP: mutex_lock+0x18/0x30 RSP: c9b5fc78
[ 112.176009] CR2: 0260
[ 112.205622] ---[ end trace 76189cd7a9bdd155 ]---
Signed-off-by: Gabriel Krisman Bertazi
---
drivers/gpu/drm/bochs/bochs_fbdev.c | 9 -
1 file changed, 4 insertions(+), 5 del
/drivers/gpu/drm/drm_dp_helper.c:1165: warning: No description found
for parameter 'crtc'
./drivers/gpu/drm/drm_dp_helper.c:1166: warning: No description found
for parameter 'crtc'
--
Gabriel Krisman Bertazi
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
riel Krisman Bertazi
--
Gabriel Krisman Bertazi
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
e8 66 fd ff ff 5b 5d c3
[ 24.313182] RIP: mutex_lock+0x18/0x30 RSP: c90001b5bcb0
[ 24.313811] CR2: 02e0
[ 24.314208] ---[ end trace 29669c1593cae14b ]---
Signed-off-by: Gabriel Krisman Bertazi
---
drivers/gpu/drm/qxl/qxl_fb.c | 11 +++
1 file changed, 7 insertions(+), 4 dele
num_crtc' description in 'drm_fbdev_cma_init'
./drivers/gpu/drm/drm_fb_cma_helper.c:558: warning: Excess function parameter
'num_crtc' description in 'drm_fbdev_cma_init'
Fixes: be7f735cd5ea ("drm: Rely on mode_config data for fb_helper
initializatio
Gerd Hoffmann writes:
> Hi,
>
> This little series has some fixes and cleanups for the qxl driver.
> Based on drm-misc-next branch.
>
Hi Gerd,
Please add a reviewed-by for series.
Reviewed-by: Gabriel Krisman Bertazi
> cheers,
> Gerd
>
> Gerd Hoffmann (4):
&g
rm_device node, the second cluster will be pushed to the third rank
and do what I think you want.
Something like:
"duplicated drm_plane_state A" -> "drm_device"[style=invis]
This is the result for me:
https://people.collabora.com/~krisman/atomic_modes
Daniel Vetter writes:
> Resulted in confusion a few times in the past.
>
Reviewed-by: Gabriel Krisman Bertazi
--
Gabriel Krisman Bertazi
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listin
Daniel Vetter writes:
> Oh, the shiny and pretties!
>
Very nice!
Reviewed-by: Gabriel Krisman Bertazi
--
Gabriel Krisman Bertazi
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
(src_fname, dst_fname)
> +
> +elif in_ext == '.svg':
> +verbose('convert SVG to: {out}/' + name)
> +svg2pdf(src_fname, dst_fname)
Small nit, but, shouldn't you add dst_fname to img_node only if
dot2format or svg2pdf w
Now that atomic support is implemented, enable the atomic flag.
Signed-off-by: Gabriel Krisman Bertazi
---
drivers/gpu/drm/qxl/qxl_drv.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/qxl/qxl_drv.c b/drivers/gpu/drm/qxl/qxl_drv.c
index 67e94f4f3ce8
Signed-off-by: Gabriel Krisman Bertazi
---
drivers/gpu/drm/qxl/qxl_display.c | 47 +--
1 file changed, 1 insertion(+), 46 deletions(-)
diff --git a/drivers/gpu/drm/qxl/qxl_display.c
b/drivers/gpu/drm/qxl/qxl_display.c
index f86e194ed797..2cd14bebc49c 100644
In the qxl atomic model, the primary doesn't stay pinned all the time,
instead it is only pinned/unpinned between prepare_fb and cleanup_fb.
So, we no longer need a final unpin of the primary framebuffer when
disabling the crtc.
Signed-off-by: Gabriel Krisman Bertazi
---
drivers/gpu/dr
Now that the state objects are wired up, we can move to the final atomic
handlers.
Signed-off-by: Gabriel Krisman Bertazi
---
drivers/gpu/drm/qxl/qxl_display.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/qxl/qxl_display.c
b/drivers/gpu/drm/qxl
Signed-off-by: Gabriel Krisman Bertazi
---
drivers/gpu/drm/qxl/qxl_display.c | 11 +--
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/qxl/qxl_display.c
b/drivers/gpu/drm/qxl/qxl_display.c
index 52c4e643331a..f86e194ed797 100644
--- a/drivers/gpu/drm/qxl
Signed-off-by: Gabriel Krisman Bertazi
---
drivers/gpu/drm/qxl/qxl_display.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/qxl/qxl_display.c
b/drivers/gpu/drm/qxl/qxl_display.c
index d5a00b6a07ea..d1c12ac222b7 100644
--- a/drivers/gpu/drm/qxl
Signed-off-by: Gabriel Krisman Bertazi
---
drivers/gpu/drm/qxl/qxl_display.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/drivers/gpu/drm/qxl/qxl_display.c
b/drivers/gpu/drm/qxl/qxl_display.c
index 09c076f5a792..d5a00b6a07ea 100644
--- a/drivers/gpu/drm/qxl/qxl_display.c
Signed-off-by: Gabriel Krisman Bertazi
---
drivers/gpu/drm/qxl/qxl_display.c | 88 +++
1 file changed, 16 insertions(+), 72 deletions(-)
diff --git a/drivers/gpu/drm/qxl/qxl_display.c
b/drivers/gpu/drm/qxl/qxl_display.c
index 8ccf62ae0efd..b23979fad1e2
There are no device specific flags that we need to keep track of here.
Let it vanish.
Signed-off-by: Gabriel Krisman Bertazi
Reviewed-by: Gustavo Padovan
---
drivers/gpu/drm/qxl/qxl_drv.c | 2 +-
drivers/gpu/drm/qxl/qxl_drv.h | 3 +--
drivers/gpu/drm/qxl/qxl_kms.c | 5 +
3 files changed, 3
In preparation for atomic conversion, let's use the transitional atomic
helpers drm_plane_helper_update/disable.
Signed-off-by: Gabriel Krisman Bertazi
---
drivers/gpu/drm/qxl/qxl_display.c | 441 +-
drivers/gpu/drm/qxl/qxl_drv.h | 5 -
2 files ch
qxl don't have support for hardware vblanks so we can't initialize it
here, otherwise we risk getting stuck in drm_wait_one_vblank.
Signed-off-by: Gabriel Krisman Bertazi
---
drivers/gpu/drm/qxl/qxl_display.c | 20
drivers/gpu/drm/qxl/qxl_drv.c | 8 +--
Signed-off-by: Gabriel Krisman Bertazi
---
drivers/gpu/drm/qxl/qxl_display.c | 101 +-
1 file changed, 100 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/qxl/qxl_display.c
b/drivers/gpu/drm/qxl/qxl_display.c
index fef464730c9b..8ccf62ae0efd 100644
.
Signed-off-by: Gabriel Krisman Bertazi
Reviewed-by: Gustavo Padovan
---
drivers/gpu/drm/qxl/qxl_display.c | 52 ++-
drivers/gpu/drm/qxl/qxl_fb.c | 25 ++-
drivers/gpu/drm/qxl/qxl_object.c | 41 --
3 files changed, 54
Let's expose the primary plane initialization inside the qxl driver in
preparation for universal planes and atomic.
Signed-off-by: Gabriel Krisman Bertazi
---
drivers/gpu/drm/qxl/qxl_display.c | 71 ++-
1 file changed, 70 insertions(+), 1 deletion(-)
port-for-kms-drivers.html>
Gabriel Krisman Bertazi (14):
drm: qxl: Drop device flags attribute
drm: qxl: Consolidate bo reservation when pinning
drm: qxl: Don't initialize vblank support
drm: qxl: Expose creation of universal primary plane
drm: qxl: Atomic phase 1: convert cur
b e8 83 e8 ff ff 65 48 8b 14 25 40 c4 00 00 31 c0 <3e>
48 0f b1 13 48 85 c0 74 08 48 89 df e8 66 fd ff ff 5b 5d c3
[ 24.313182] RIP: mutex_lock+0x18/0x30 RSP: c90001b5bcb0
[ 24.313811] CR2: 02e0
[ 24.314208] ---[ end trace 29669c1593cae14b ]---
Signed-off-by: Gabriel Kr
tly inside the prepare_fb hook is
atmel_hlcdc, so we take special care to make sure we don't break
anything there.
Signed-off-by: Gabriel Krisman Bertazi
---
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 3 +++
drivers/gpu/drm/drm_plane_helper.c | 3 +--
2 files changed, 4 i
Now that the state objects are wired up, we can move to the final atomic
handlers.
Signed-off-by: Gabriel Krisman Bertazi
---
drivers/gpu/drm/qxl/qxl_display.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/qxl/qxl_display.c
b/drivers/gpu/drm/qxl
Signed-off-by: Gabriel Krisman Bertazi
---
drivers/gpu/drm/qxl/qxl_display.c | 47 +--
1 file changed, 1 insertion(+), 46 deletions(-)
diff --git a/drivers/gpu/drm/qxl/qxl_display.c
b/drivers/gpu/drm/qxl/qxl_display.c
index f86e194ed797..2cd14bebc49c 100644
Now that atomic support is implemented, enable the atomic flag.
Signed-off-by: Gabriel Krisman Bertazi
---
drivers/gpu/drm/qxl/qxl_drv.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/qxl/qxl_drv.c b/drivers/gpu/drm/qxl/qxl_drv.c
index 67e94f4f3ce8
Signed-off-by: Gabriel Krisman Bertazi
---
drivers/gpu/drm/qxl/qxl_display.c | 11 +--
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/qxl/qxl_display.c
b/drivers/gpu/drm/qxl/qxl_display.c
index 52c4e643331a..f86e194ed797 100644
--- a/drivers/gpu/drm/qxl
Signed-off-by: Gabriel Krisman Bertazi
---
drivers/gpu/drm/qxl/qxl_display.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/drivers/gpu/drm/qxl/qxl_display.c
b/drivers/gpu/drm/qxl/qxl_display.c
index 09c076f5a792..d5a00b6a07ea 100644
--- a/drivers/gpu/drm/qxl/qxl_display.c
Signed-off-by: Gabriel Krisman Bertazi
---
drivers/gpu/drm/qxl/qxl_display.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/qxl/qxl_display.c
b/drivers/gpu/drm/qxl/qxl_display.c
index d5a00b6a07ea..d1c12ac222b7 100644
--- a/drivers/gpu/drm/qxl
Signed-off-by: Gabriel Krisman Bertazi
---
drivers/gpu/drm/qxl/qxl_display.c | 88 +++
1 file changed, 16 insertions(+), 72 deletions(-)
diff --git a/drivers/gpu/drm/qxl/qxl_display.c
b/drivers/gpu/drm/qxl/qxl_display.c
index 8ccf62ae0efd..b23979fad1e2
Signed-off-by: Gabriel Krisman Bertazi
---
drivers/gpu/drm/qxl/qxl_display.c | 101 +-
1 file changed, 100 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/qxl/qxl_display.c
b/drivers/gpu/drm/qxl/qxl_display.c
index fef464730c9b..8ccf62ae0efd 100644
In the qxl atomic model, the primary doesn't stay pinned all the time,
instead it is only pinned/unpinned between prepare_fb and cleanup_fb.
So, we no longer need a final unpin of the primary framebuffer when
disabling the crtc.
Signed-off-by: Gabriel Krisman Bertazi
---
drivers/gpu/dr
In preparation for atomic conversion, let's use the transitional atomic
helpers drm_plane_helper_update/disable.
Signed-off-by: Gabriel Krisman Bertazi
---
drivers/gpu/drm/qxl/qxl_display.c | 442 +-
drivers/gpu/drm/qxl/qxl_drv.h | 5 -
2 files ch
Let's expose the primary plane initialization inside the qxl driver in
preparation for universal planes and atomic.
Signed-off-by: Gabriel Krisman Bertazi
---
drivers/gpu/drm/qxl/qxl_display.c | 71 ++-
1 file changed, 70 insertions(+), 1 deletion(-)
t and some
custom code that I can share if requested. I hope this covers the main
use cases.
[1] <http://blog.ffwll.ch/2014/11/atomic-modeset-support-for-kms-drivers.html>
Gabriel Krisman Bertazi (14):
drm: qxl: Drop device flags attribute
drm: qxl: Consolidate bo reservation when pi
There are no device specific flags that we need to keep track of here.
Let it vanish.
Signed-off-by: Gabriel Krisman Bertazi
---
drivers/gpu/drm/qxl/qxl_drv.c | 2 +-
drivers/gpu/drm/qxl/qxl_drv.h | 3 +--
drivers/gpu/drm/qxl/qxl_kms.c | 5 +
3 files changed, 3 insertions(+), 7 deletions
qxl don't have support for hardware vblanks so we can't initialize it
here, otherwise we risk getting stuck in drm_wait_one_vblank.
Signed-off-by: Gabriel Krisman Bertazi
---
drivers/gpu/drm/qxl/qxl_display.c | 3 ---
drivers/gpu/drm/qxl/qxl_drv.c | 26 +
.
Signed-off-by: Gabriel Krisman Bertazi
---
drivers/gpu/drm/qxl/qxl_display.c | 52 ++-
drivers/gpu/drm/qxl/qxl_fb.c | 25 ++-
drivers/gpu/drm/qxl/qxl_object.c | 41 --
3 files changed, 54 insertions(+), 64 deletions
g data for fb_helper
initialization")
Signed-off-by: Gabriel Krisman Bertazi
---
include/drm/drm_fb_helper.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h
index 278820ee17ad..6f5acebb266a 100644
--- a/include/drm/drm_fb_h
tion to sti since a proper fix got merged.
Suggested-by: Daniel Vetter
Signed-off-by: Gabriel Krisman Bertazi
Reviewed-by: Eric Anholt
---
drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c| 1 -
drivers/gpu/drm/arc/arcpgu_drv.c | 3 +--
drivers/gpu/drm/arm/
Gabriel Krisman Bertazi writes:
> Scheduling the output_poll_work before calling bind_all to create the
> crtcs can race the fbdev initialization with the components
> initialization (i.e. crtc initialization). One side effect is that we
> may call drm_fbdev_cma_init with a zer
A,B,D)
)
@@
identifier r.C;
type T;
expression V;
@@
- T C;
<...
when != p
- C = V;
...>
//
Suggested-by: Daniel Vetter
Signed-off-by: Gabriel Krisman Bertazi
---
drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c| 1 -
drivers/gpu/drm/arc/arcpgu_drv.c | 3 +--
drivers/
ned-off-by: Gabriel Krisman Bertazi
Cc: Benjamin Gaignard
Cc: Vincent Abriou
---
drivers/gpu/drm/sti/sti_drv.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/sti/sti_drv.c b/drivers/gpu/drm/sti/sti_drv.c
index d3db22488f96..516296010735 100644
--- a/drive
Jyri Sarha writes:
> Fix badly hardcoded return return value under fail-label. All goto
> branches to the label set the "ret"-variable accordingly.
>
> Signed-off-by: Jyri Sarha
Thanks. Looks good.
Reviewed-by: Gabriel Krisman Bertazi
--
G
Gerd Hoffmann writes:
> On Fr, 2017-01-27 at 14:53 +0100, Daniel Vetter wrote:
>> On Fri, Jan 27, 2017 at 09:20:42AM +0100, Gerd Hoffmann wrote:
>> > On Do, 2017-01-26 at 23:05 -0200, Gabriel Krisman Bertazi wrote:
>> > > No longer true since commit 07f8d9bdb235
lcdc_crtc_create(struct drm_device *dev)
>
> fail:
> tilcdc_crtc_destroy(crtc);
> - return -ENOMEM;
> + return -ret;
Hi,
Shouldn't it read ret instead of -ret? The places that set ret
already make it negative, while turning it positive looks like would
Daniel Vetter writes:
> On Fri, Jan 27, 2017 at 09:20:42AM +0100, Gerd Hoffmann wrote:
>> On Do, 2017-01-26 at 23:05 -0200, Gabriel Krisman Bertazi wrote:
>> > No longer true since commit 07f8d9bdb235 ("drm/qxl: add support for > 1
>> > output"). qxl_nu
No longer true since commit 07f8d9bdb235 ("drm/qxl: add support for > 1
output"). qxl_num_crtc defaults to 4 and is configurable as a module
parameter.
Signed-off-by: Gabriel Krisman Bertazi
---
drivers/gpu/drm/qxl/qxl_fb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
qxl_device duplicates the pointer to struct pci_dev, which is not
needed since we already have it in the drm_device structure. Clean it
up.
Signed-off-by: Gabriel Krisman Bertazi
---
drivers/gpu/drm/qxl/qxl_drv.h | 1 -
drivers/gpu/drm/qxl/qxl_ioctl.c | 2 +-
drivers/gpu/drm/qxl/qxl_kms.c
This is the recommended way to create the drm_device structure,
according to DRM documentation.
Signed-off-by: Gabriel Krisman Bertazi
---
drivers/gpu/drm/qxl/qxl_debugfs.c | 6 +++---
drivers/gpu/drm/qxl/qxl_display.c | 32
drivers/gpu/drm/qxl/qxl_drv.c
qxl_device duplicates a pointer to struct device, which is not needed
since we already have it in the drm_device structure. Clean it up.
Signed-off-by: Gabriel Krisman Bertazi
---
drivers/gpu/drm/qxl/qxl_drv.h| 1 -
drivers/gpu/drm/qxl/qxl_kms.c| 1 -
drivers/gpu/drm/qxl/qxl_object.c
prototypes to drm_cache header
> file")
> Signed-off-by: Chris Wilson
> Cc: Gabriel Krisman Bertazi
> Cc: Alex Deucher
> Cc: Daniel Vetter
Patch is good, though I'm Embarrassed that I didn't have -Wmissing-prototypes
enabled when testing this. Thanks Chris
> Please group this declaration together with the other qxl debugfs
> declarations.
Thanks for the review. Just submitted a v3 that adds this
modification. Please, take a look when you have the time.
--
Gabriel Krisman Bertazi
___
dri-devel m
running a WM on top of X.
Changes since v1:
- Drop verification for primary minor in qxl_debugsfs_init.
Changes since V2:
- Put new header together with other debugfs headers.
Signed-off-by: Gabriel Krisman Bertazi
Cc: Dave Airlie
Cc: Daniel Vetter
Cc: Gustavo Padovan
---
drivers/gpu/drm
This avoids using the deprecated drm_put_dev() and unload() hook
interfaces in the qxl driver.
Signed-off-by: Gabriel Krisman Bertazi
Cc: Dave Airlie
Cc: Daniel Vetter
Cc: Gustavo Padovan
---
drivers/gpu/drm/qxl/qxl_drv.c | 11 +--
drivers/gpu/drm/qxl/qxl_drv.h | 2 --
drivers/gpu
running a WM on top of X.
Changes since v1:
- Drop verification for primary minor in qxl_debugsfs_init
Signed-off-by: Gabriel Krisman Bertazi
Cc: Dave Airlie
Cc: Daniel Vetter
Cc: Gustavo Padovan
---
drivers/gpu/drm/qxl/qxl_debugfs.c | 10 +++
drivers/gpu/drm/qxl/qxl_drv.c | 58
This avoids using the deprecated drm_put_dev() and unload() hook
interfaces in the qxl driver.
Signed-off-by: Gabriel Krisman Bertazi
Cc: Dave Airlie
Cc: Daniel Vetter
Cc: Gustavo Padovan
---
drivers/gpu/drm/qxl/qxl_drv.c | 11 +--
drivers/gpu/drm/qxl/qxl_drv.h | 2 --
drivers/gpu
ed files. Wouldn't that or some modification around work for
> this?
Thanks for your review, Gustavo.
As I mentioned on IRC, I verified the check is not needed at all,
since qxl only implements one minor. I'll resend without this bit.
--
Gabriel Krisman Bertazi
__
() hook removal, because the connector interface cannot be
published prior to registering the minors.
Signed-off-by: Gabriel Krisman Bertazi
CC: Dave Airlie
CC: Daniel Vetter
CC: dri-devel@lists.freedesktop.org
---
drivers/gpu/drm/qxl/qxl_display.c | 1 -
1 file changed, 1 deletion(-)
diff --git a
times
for each minor function, we make sure it is only executed for the
primary minor.
Tested on qemu with igt and running a WM on top of X.
Signed-off-by: Gabriel Krisman Bertazi
CC: Dave Airlie
CC: Daniel Vetter
CC: dri-devel@lists.freedesktop.org
---
drivers/gpu/drm/qxl/qxl_debugfs.c | 12
This avoids using the deprecated drm_put_dev() and unload() hook
interfaces in the qxl driver.
Signed-off-by: Gabriel Krisman Bertazi
CC: Dave Airlie
CC: Daniel Vetter
CC: dri-devel@lists.freedesktop.org
---
drivers/gpu/drm/qxl/qxl_drv.c | 11 +--
drivers/gpu/drm/qxl/qxl_drv.h | 2
Continue to clean up drmP.h by moving the cache flushing functions into
it's own header file.
Compile-tested only
Signed-off-by: Gabriel Krisman Bertazi
---
drivers/gpu/drm/i915/i915_drv.h | 1 +
drivers/gpu/drm/vgem/vgem_drv.h | 1 +
include/drm/drmP.h | 5 -
includ
nce v1:
- Add section to drm-mm.rst.
- Fix kernel-doc style issues.
- s/memory/kernel memory/.
Signed-off-by: Gabriel Krisman Bertazi
---
Documentation/gpu/drm-mm.rst | 6 ++
drivers/gpu/drm/drm_cache.c | 23 +++
2 files changed, 29 insertions(+)
diff --git a/Documen
uggested-by: Daniel Vetter
Signed-off-by: Gabriel Krisman Bertazi
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 5 ++---
drivers/gpu/drm/ast/ast_drv.h | 2 +-
drivers/gpu/drm/ast/ast_main.c| 3 +--
drivers/gpu/drm/bochs/
of this vfunc to void?
>
> Applied this one here meanwhile to drm-misc, thanks a lot.
Thanks, Daniel. sure, I can do it, it's going to be a good way for
me to learn coccinelle.
--
Gabriel Krisman Bertazi
with the jobfile just to be sure on top of
drm-misc-next, and I couldn't reproduce the error anymore after applying
Chris' patch (but I could reproduce the Oops when trying only with my
patch).
Also, sorry for the noise and lesson learned about virtual devices :(
--
Gabriel Krisman Bertazi
1 - 100 of 116 matches
Mail list logo
