[PATCH] drm/radeon/kms: add support for internal thermal sensors (v3)

Hi, Am 02.06.2010 18:59, schrieb Alex Deucher: > +/* get temperature in millidegrees */ > +u32 evergreen_get_temp(struct radeon_device *rdev) Could it be named evergreen_get_temp_mcelsius_clipped_to_above_zero ?^) Seriously: would it make sense to have: u32 evergreen_get_temp_mkelvin(struct rad

Re: [PATCH] drm/radeon/kms: add support for internal thermal sensors (v3)

Hi, Am 02.06.2010 18:59, schrieb Alex Deucher: > +/* get temperature in millidegrees */ > +u32 evergreen_get_temp(struct radeon_device *rdev) Could it be named evergreen_get_temp_mcelsius_clipped_to_above_zero ?^) Seriously: would it make sense to have: u32 evergreen_get_temp_mkelvin(struct rad

[PATCH 1/3] r600: add span support for 2D tiling

Hi, Am 28.05.2010 00:04, schrieb Conn Clark: > On Thu, May 27, 2010 at 8:51 AM, Brian Paul wrote: > > This code could be written with a faster algorithm requiring just 13 > operations > > + pixel_number |= ((x >> 0) & 1) << 0; // pn[0] = x[0] > + pixel_number |= ((

Re: [PATCH 1/3] r600: add span support for 2D tiling

Hi, Am 28.05.2010 00:04, schrieb Conn Clark: > On Thu, May 27, 2010 at 8:51 AM, Brian Paul wrote: > > This code could be written with a faster algorithm requiring just 13 > operations > > + pixel_number |= ((x >> 0) & 1) << 0; // pn[0] = x[0] > + pixel_number |= ((

[PATCH 1/3] r600: add span support for 2D tiling

Hi Alex, not tested (admittedly I haven't compiled it), and probably not really relevant but these switch cases could be more compact: +static inline GLint r600_2d_tile_helper(const struct radeon_renderbuffer * rrb, +GLint x, GLint y, GLint is_depth, GLint is_stencil) ... +

Re: [PATCH 1/3] r600: add span support for 2D tiling

Hi Alex, not tested (admittedly I haven't compiled it), and probably not really relevant but these switch cases could be more compact: +static inline GLint r600_2d_tile_helper(const struct radeon_renderbuffer * rrb, +GLint x, GLint y, GLint is_depth, GLint is_stencil) ... +