Re: [PATCH] drm/tilcdc: Set preferred depth

Hi, Jyri sa...@kapsi.fi writes: > So the trouble here is the 16bpp and 24/32bpp color wiring being > crossed, right? I'd just like to remind that there is another option > to overcome the issue by editing device tree files. The current > configuration from some 8 years back supports RG16, BG24, a

Re: [PATCH] drm/tilcdc: Set preferred depth

Hi, Kevin Kevin Hao writes: > I had also thought about a similar modification before, but personally, > I considered such changes a bit aggressive for a patch that needs to be > backported to a stable kernel (especially for a LTS kernel such as v6.6 > which I am working on). That's why I opted f

Re: [PATCH] drm/tilcdc: Set preferred depth

Hi Kevin, Kevin Hao writes: > But after kernel commit c91acda3a380, the FB will not be created > successfully due to the check of the valid pixel format. Then the bpp > is set to 24, but the 'depth = 16' and 'bpp = 24' combo is not a valid > pixel format. > > Fix this issue by explicitly setting

[PATCH 11/11] drm/xe: Use drm_driver_legacy_fb_format() for fbdev

Switch to using drm_driver_legacy_fb_format() instead of drm_mode_legacy_fb_format() to use the same logic as for the DRM_IOCTL_MODE_ADDFB ioctl when selecting a framebuffer format. Signed-off-by: Frej Drejhammar Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Cc: David Airlie

[PATCH 10/11] drm/tegra: Use drm_driver_legacy_fb_format() for fbdev

Switch to using drm_driver_legacy_fb_format() instead of drm_mode_legacy_fb_format() to use the same logic as for the DRM_IOCTL_MODE_ADDFB ioctl when selecting a framebuffer format. Signed-off-by: Frej Drejhammar Cc: David Airlie Cc: Daniel Vetter Cc: linux-te...@vger.kernel.org --- This is

[PATCH 09/11] drm/radeon: Use drm_driver_legacy_fb_format() for fbdev

Switch to using drm_driver_legacy_fb_format() instead of drm_mode_legacy_fb_format() to use the same logic as for the DRM_IOCTL_MODE_ADDFB ioctl when selecting a framebuffer format. Signed-off-by: Frej Drejhammar Cc: David Airlie Cc: Daniel Vetter Cc: amd-...@lists.freedesktop.org --- This

[PATCH 07/11] drm/msm: Use drm_driver_legacy_fb_format() for fbdev

Switch to using drm_driver_legacy_fb_format() instead of drm_mode_legacy_fb_format() to use the same logic as for the DRM_IOCTL_MODE_ADDFB ioctl when selecting a framebuffer format. Signed-off-by: Frej Drejhammar Cc: Rob Clark Cc: Abhinav Kumar Cc: Dmitry Baryshkov Cc: Sean Paul Cc: Marijn

[PATCH 06/11] drm/i915: Use drm_driver_legacy_fb_format() for fbdev

Switch to using drm_driver_legacy_fb_format() instead of drm_mode_legacy_fb_format() to use the same logic as for the DRM_IOCTL_MODE_ADDFB ioctl when selecting a framebuffer format. Signed-off-by: Frej Drejhammar Cc: David Airlie Cc: Daniel Vetter Cc: intel-...@lists.freedesktop.org Cc: intel

[PATCH 03/11] drm/armada: Use drm_driver_legacy_fb_format() for fbdev

Switch to using drm_driver_legacy_fb_format() instead of drm_mode_legacy_fb_format() to use the same logic as for the DRM_IOCTL_MODE_ADDFB ioctl when selecting a framebuffer format. Signed-off-by: Frej Drejhammar Cc: Russell King Cc: David Airlie Cc: Daniel Vetter --- This is an evolved

[PATCH 04/11] drm/exynos: Use drm_driver_legacy_fb_format() for fbdev

Switch to using drm_driver_legacy_fb_format() instead of drm_mode_legacy_fb_format() to use the same logic as for the DRM_IOCTL_MODE_ADDFB ioctl when selecting a framebuffer format. Signed-off-by: Frej Drejhammar Cc: David Airlie Cc: Daniel Vetter Cc: Krzysztof Kozlowski Cc: Alim Akhtar Cc

[PATCH 08/11] drm/omapdrm: Use drm_driver_legacy_fb_format() for fbdev

Switch to using drm_driver_legacy_fb_format() instead of drm_mode_legacy_fb_format() to use the same logic as for the DRM_IOCTL_MODE_ADDFB ioctl when selecting a framebuffer format. Signed-off-by: Frej Drejhammar Cc: Tomi Valkeinen Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann

[PATCH 05/11] drm/gma500: Use drm_driver_legacy_fb_format() for fbdev

Switch to using drm_driver_legacy_fb_format() instead of drm_mode_legacy_fb_format() to use the same logic as for the DRM_IOCTL_MODE_ADDFB ioctl when selecting a framebuffer format. Signed-off-by: Frej Drejhammar Cc: Patrik Jakobsson Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas

[PATCH 02/11] drm/fbdev_generic: Use drm_driver_legacy_fb_format() for fbdev

Switch to using drm_driver_legacy_fb_format() instead of drm_mode_legacy_fb_format() to use the same logic as for the DRM_IOCTL_MODE_ADDFB ioctl when selecting a framebuffer format. Signed-off-by: Frej Drejhammar Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Cc: David Airlie

[PATCH 01/11] drm: Only return supported formats from drm_driver_legacy_fb_format

ers on an Intel HD Graphics 4000 chipset. Signed-off-by: Frej Drejhammar Fixes: c91acda3a380 ("drm/gem: Check for valid formats") Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Cc: David Airlie Cc: Daniel Vetter Cc: "Maíra Canal" Cc: "Ville Syrjälä&qu

[PATCH 00/11] drm: Only try to set formats supported by the hardware

uijten Cc: Maxime Ripard Cc: Patrik Jakobsson Cc: Rob Clark Cc: Russell King Cc: Sean Paul Cc: sta...@vger.kernel.org Cc: Thomas Zimmermann Cc: Tomi Valkeinen Cc: "Ville Syrjälä" [1] https://lore.kernel.org/all/20240310152803.3315-1-frej.drejham...@gmail.com/ Frej Drejhammar

Re: [PATCH] drm: Don't return unsupported formats in drm_mode_legacy_fb_format

Hi Thomas, Thomas Zimmermann writes: > Am 11.03.24 um 20:34 schrieb Frej Drejhammar: > >> What I can't really see is what "switch all fbdev code over to >> drm_driver_legacy_fb_format" would entail [...] > > Your patch modifies drm_mode_legacy_fb_format()

Re: [PATCH] drm: Don't return unsupported formats in drm_mode_legacy_fb_format

Hi Thomas, Thanks for the review and suggestions. My experience with the drm parts of the kernel is limited to some weekends trying to fix the regression, so I'm afraid I have some questions to check my understanding before making a v2 of the patch. Thomas Zimmermann writes: > I suggest to swit

[PATCH] drm: Don't return unsupported formats in drm_mode_legacy_fb_format

ntel and modesetting drivers on an intel HD Graphics 4000 chipset. Signed-off-by: Frej Drejhammar Fixes: c91acda3a380 ("drm/gem: Check for valid formats") Cc: sta...@vger.kernel.org Cc: Russell King Cc: David Airlie Cc: Daniel Vetter Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thom