gpu/amdgpu_drv.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> >
> > +#include "amdgpu_criu.h"
> > +
>
> Why is this header file needed here? None of the new ioctls will be
> implemented in kfd_chardev.c.
amdgpu_drv.c needs the header with the ioct
the mapping rb tree but rather the list in the bo_va.
>
Do you mean the invalids and valids lists? I remember you having objections to
using those in a previous patch.
David
____
From: Koenig, Christian
Sent: Monday, June 16, 2025 5:01 AM
To: Francis, David ; dri-d
;aux;
>> + }
>
>I would've put the quirk definition from patch 5 and the quirk handling
>above together into a separate patch. The current patch would be about
>how things should work in theory, and another patch on top would be
>about how reality interferes with theor
Received offline review from AMD MST DSC (Non-Linux) expert Wenjing Liu, giving
me permission to mark this patch
Reviewed-by: Wenjing Liu
From: David Francis
Sent: August 26, 2019 2:05 PM
To: dri-devel@lists.freedesktop.org
Cc: Francis, David; Lyude
@@ -1434,6 +1434,13 @@ enum drm_dp_quirk {
>> * The driver should ignore SINK_COUNT during detection.
>> */
>>DP_DPCD_QUIRK_NO_SINK_COUNT,
>> + /**
>> + * @DP_DPCD_QUIRK_DSC_WITHOUT_VIRTUAL_DPCD:
>> + *
>> + * Th
gust 22, 2019 8:03 PM
To: Francis, David; dri-devel@lists.freedesktop.org; Manasi Navare
Subject: Re: [PATCH v4 0/5] MST DSC support in drm-mst
OK-done reviewing, but there's some stuff missing here. The PBN bandwidth
checks in https://patchwork.freedesktop.org/patch/325604/?series=65423&am
I was building against amd-staging-drm-next (commit e4a67e6cf14c).
v4 will contain just the drm-mst patches and will apply on latest
drm-tip/drm-tip (commit 018886de4726)
From: Lyude Paul
Sent: August 21, 2019 5:20 PM
To: Francis, David; dri-devel
Whoops, left in a test print. Ignore this patch
From: David Francis
Sent: August 21, 2019 4:01 PM
To: dri-devel@lists.freedesktop.org; amd-...@lists.freedesktop.org
Cc: Francis, David; Liu, Wenjing; Cornij, Nikola
Subject: [PATCH v3 13/16] drm/amd
is
clear what functionality is common between drivers
From: dri-devel on behalf of David
Francis
Sent: August 21, 2019 4:01 PM
To: dri-devel@lists.freedesktop.org; amd-...@lists.freedesktop.org
Cc: Li, Sun peng (Leo); Francis, David; Kazlauskas
>> @@ -7178,6 +7249,15 @@ static int amdgpu_dm_atomic_check(struct drm_device
>> *dev,
>>goto fail;
>>}
>>
>> +#ifdef CONFIG_DRM_AMD_DC_DSC_SUPPORT
>> + for_each_oldnew_crtc_in_state(state, crtc, old_crtc_state,
ng already takes bpp into
>> account */
>> + pbn = drm_dp_calc_pbn_mode(clock, 1);
>>
>> - slots = drm_dp_find_vcpi_slots(mst_mgr, pbn);
>> + /* Convert kilobits per second / 64 (for 64 timeslots) to pbn
>> (54/64 me
11 matches
Mail list logo
