Re: [PATCH v4 3/3] dt-bindings: interrupt-controller: brcm,bcm2836-l1-intc: Drop interrupt-controller requirement

2024-12-18 Thread Florian Fainelli
ler. Drop the binding requirement for interrupt-controller and interrupt-cells to satisfy validation on this platform. Signed-off-by: Dave Stevenson Acked-by: Krzysztof Kozlowski Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v3 6/7] arm64: dts: broadcom: Correct hdmi device node names

2024-12-17 Thread Florian Fainelli
From: Florian Fainelli On Thu, 12 Dec 2024 18:36:33 +, Dave Stevenson wrote: > The names of the hdmi0 and hdmi1 nodes had addresses that > didn't match the reg properties for the nodes. > > Fixes: f66b382affd8 ("arm64: dts: broadcom: Add display pipeline support to

Re: [PATCH v3 0/7] drm/vc4: Fixup DT and DT binding issues from recent patchset

2024-12-17 Thread Florian Fainelli
On 12/12/24 10:36, Dave Stevenson wrote: I missed the DT errors from the recent patchset[1] (DT patches in linux-next via Florian, DRM bindings patches on dri-misc-next) as Rob's bot report got spam filtered, so this is a fixup set. Largely it was changes to number of interrupts or clocks in the

Re: [PATCH v3 7/7] arm64: dts: broadcom: Remove intc controller on BCM2712.

2024-12-17 Thread Florian Fainelli
From: Florian Fainelli On Thu, 12 Dec 2024 18:36:34 +, Dave Stevenson wrote: > The brcm,bcm2836-l1-intc controller isn't used on this platform. > It is used on 32-bit kernels for the smp_boot_secondary hook, but > BCM2712 can't run a 32-bit kernel. > > Re

Re: [PATCH v3 5/7] arm64: dts: broadcom: Rename bcm2712 interrupt controllers

2024-12-17 Thread Florian Fainelli
From: Florian Fainelli On Thu, 12 Dec 2024 18:36:32 +, Dave Stevenson wrote: > CHECK_DTBS produces errors on bcm2712-rpi-5-b.dtb and bcm2712-d-rpi-5-b.dtb > of: > intc@7d508380: $nodename:0: 'intc@7d508380' does not match > '^interrupt-controller(@[0-9a-f,]+)*$

Re: [PATCH v3 3/7] dt-bindings: gpio: brcmstb: permit gpio-line-names property

2024-12-12 Thread Florian Fainelli
items based on current users. Signed-off-by: Dave Stevenson Acked-by: Florian Fainelli -- Florian

Re: [PATCH 7/7] arm64: dts: broadcom: Fix device tree errors on BCM2712.

2024-12-04 Thread Florian Fainelli
On 12/2/24 07:24, Krzysztof Kozlowski wrote: On 02/12/2024 15:32, Dave Stevenson wrote: Resolves the issues on clocks and power nodes Which issues? Be specific. Such commit is unprecise and not really helpful. We see it from the diff that this is "some issue". What we do not see is WHY and WHA

Re: [PATCH 4/7] arm64: dts: broadcom: Fix device tree warnings for BCM2712 display pipeline

2024-12-04 Thread Florian Fainelli
On 12/2/24 07:20, Krzysztof Kozlowski wrote: On 02/12/2024 15:31, Dave Stevenson wrote: Fixes up errors on HDMI and interrupt controllers that weren't What errors? I can't find anything in the commit. Describe the error. noticed before merging. Fixes: de9bc2dba3db ("arm64: dts: broadcom: Ad

Re: [PATCH v2 35/36] arm64: dts: broadcom: Add display pipeline support to BCM2712

2024-11-24 Thread Florian Fainelli
From: Florian Fainelli On Fri, 25 Oct 2024 18:16:06 +0100, Dave Stevenson wrote: > Adds the HVS and associated hardware blocks to support the HDMI > and writeback connectors on BCM2712 / Pi5. > > Signed-off-by: Dave Stevenson > --- Applied to https://github.com/Broadcom/s

Re: [PATCH v2 34/36] arm64: dts: broadcom: Add firmware clocks and power nodes to Pi5 DT

2024-11-24 Thread Florian Fainelli
From: Florian Fainelli On Fri, 25 Oct 2024 18:16:05 +0100, Dave Stevenson wrote: > BCM2712 still uses the firmware clocks and power drivers, so add > them to the base device tree. > > Signed-off-by: Dave Stevenson > --- Applied to https://github.com/Broadcom/stblinux/com

Re: [PATCH v2 36/36] arm64: dts: broadcom: Add DT for D-step version of BCM2712

2024-11-24 Thread Florian Fainelli
From: Florian Fainelli On Fri, 25 Oct 2024 18:16:07 +0100, Dave Stevenson wrote: > The D-Step has some minor variations in the hardware, so needs > matching changes to DT. > > Add a new DTS file that modifies the existing (C-step) devicetree. > > Signed-off-by: Dave Stevens

Re: [PATCH 00/37] drm/vc4: Add support for BCM2712 / Pi5 display hardware

2024-11-24 Thread Florian Fainelli
On 11/22/2024 12:06 AM, Maxime Ripard wrote: On Thu, Nov 21, 2024 at 03:37:00PM +, Dave Stevenson wrote: On Wed, 23 Oct 2024 at 17:50, Dave Stevenson wrote: This series adds the required DRM, clock, and DT changes required to support the display hardware on Pi5. There are a couple of m

Re: [PATCH V2 01/16] firmware: raspberrypi: Improve timeout warning

2024-08-13 Thread Florian Fainelli
From: Florian Fainelli On Sun, 28 Jul 2024 13:41:45 +0200, Stefan Wahren wrote: > Recent work on raspberry-power driver showed that even the > stacktrace on firmware property timeout doesn't provide > enough information. So add the first tag name to the warning > to be in l

Re: [PATCH 09/11] usb: dwc2: Skip clock gating on Broadcom SoCs

2024-07-04 Thread Florian Fainelli
On 6/30/2024 4:36 PM, Stefan Wahren wrote: On resume of the Raspberry Pi the dwc2 driver fails to enable HCD_FLAG_HW_ACCESSIBLE before re-enabling the interrupts. This causes a situation where both handler ignore a incoming port interrupt and force the upper layers to disable the dwc2 interrupt

Re: [PATCH 08/11] usb: dwc2: debugfs: Print parameter no_clock_gating

2024-07-04 Thread Florian Fainelli
ke this more visible also print this in show parameters of debugfs. Signed-off-by: Stefan Wahren Reviewed-by: Florian Fainelli -- Florian smime.p7s Description: S/MIME Cryptographic Signature

Re: [PATCH 11/11] ARM: bcm2835_defconfig: Enable SUSPEND

2024-07-04 Thread Florian Fainelli
On 6/30/2024 6:19 PM, Stefan Wahren wrote: Since the Raspberry Pi supports Suspend-To-Idle now, this option should be enabled. This should make power management testing easier. Signed-off-by: Stefan Wahren Reviewed-by: Florian Fainelli -- Florian smime.p7s Description: S/MIME

Re: [PATCH RFT 10/11] serial: 8250_bcm2835aux: add PM suspend/resume support

2024-07-04 Thread Florian Fainelli
On 6/30/2024 5:53 PM, Stefan Wahren wrote: This adds suspend/resume support for the 8250_bcm2835aux driver to provide power management support on attached devices. Signed-off-by: Stefan Wahren --- Since i don't have a RS485 setup, any test feedback would be great. drivers/tty/serial/8250/

Re: [PATCH 05/11] irqchip/bcm2835: Enable SKIP_SET_WAKE and MASK_ON_SUSPEND

2024-07-04 Thread Florian Fainelli
this prevent us from properly entering power management states like "suspend to idle". So enable the flags IRQCHIP_SKIP_SET_WAKE and IRQCHIP_MASK_ON_SUSPEND to let the irqchip core allows and handles the power management. Signed-off-by: Stefan Wahren Reviewed-by: Florian Fainelli -- Flor

Re: [PATCH 03/11] pmdomain: raspberrypi-power: Adjust packet definition

2024-07-04 Thread Florian Fainelli
prepare the driver for further changes. Link: https://github.com/raspberrypi/firmware/wiki/Mailbox-property-interface Signed-off-by: Stefan Wahren Reviewed-by: Florian Fainelli -- Florian smime.p7s Description: S/MIME Cryptographic Signature

Re: [PATCH 02/11] mailbox: bcm2835: Fix timeout during suspend mode

2024-07-04 Thread Florian Fainelli
ption stack(0xcc93dfa8 to 0xcc93dff0) [...] PM: noirq suspend of devices complete after 3095.584 msecs Link: https://github.com/raspberrypi/firmware/issues/1894 Fixes: 0bae6af6d704 ("mailbox: Enable BCM2835 mailbox support") Signed-off-by: Stefan Wahren Reviewed-by: Florian Faine

Re: [PATCH 01/11] firmware: raspberrypi: Improve timeout warning

2024-07-04 Thread Florian Fainelli
ahren Reviewed-by: Florian Fainelli -- Florian smime.p7s Description: S/MIME Cryptographic Signature

Re: [PATCH 00/18] BCM2835 DMA mapping cleanups and fixes

2024-06-05 Thread Florian Fainelli
On 5/24/2024 8:26 PM, Dave Stevenson wrote: Hi All This series initially cleans up the BCM2835 DMA driver in preparation for supporting the 40bit version. It then fixes up the incorrect mapping behaviour we've had to date. The cleanups are based on Stefan Wahren's RFC [1], with a couple of mi

Re: [PATCH 13/18] arm: dt: Add dma-ranges to the bcm283x platforms

2024-06-05 Thread Florian Fainelli
to those files. With that: Acked-by: Florian Fainelli -- Florian smime.p7s Description: S/MIME Cryptographic Signature

Re: [PATCH 03/18] ARM: dts: bcm283x: Update to use dma-channel-mask

2024-06-05 Thread Florian Fainelli
On 5/24/2024 8:26 PM, Dave Stevenson wrote: Now the driver looks for the common dma-channel-mask property rather than the vendor-specific brcm,dma-channel-mask, update the dt files to follow suit. Signed-off-by: Dave Stevenson Acked-by: Florian Fainelli -- Florian smime.p7s Description

Re: [PATCH] fbdev: Have CONFIG_FB_NOTIFY be tristate

2024-05-08 Thread Florian Fainelli
On 5/7/24 04:44, Arnd Bergmann wrote: On Tue, May 7, 2024, at 13:10, Daniel Vetter wrote: On Mon, May 06, 2024 at 04:53:47PM +0200, Arnd Bergmann wrote: On Mon, May 6, 2024, at 15:14, Daniel Vetter wrote: On Fri, May 03, 2024 at 01:22:10PM -0700, Florian Fainelli wrote: On 5/3/24 12:45, Arnd

Re: [PATCH] fbdev: Have CONFIG_FB_NOTIFY be tristate

2024-05-03 Thread Florian Fainelli
On 5/3/24 12:45, Arnd Bergmann wrote: On Fri, May 3, 2024, at 21:28, Florian Fainelli wrote: Android devices in recovery mode make use of a framebuffer device to provide an user interface. In a GKI configuration that has CONFIG_FB=m, but CONFIG_FB_NOTIFY=y, loading the fb.ko module will fail

[PATCH] fbdev: Have CONFIG_FB_NOTIFY be tristate

2024-05-03 Thread Florian Fainelli
like CONFIG_FB such that both can be loaded as module with fb_notify.ko first, and fb.ko second. Signed-off-by: Florian Fainelli --- drivers/video/fbdev/core/Kconfig | 2 +- drivers/video/fbdev/core/fb_notify.c | 3 +++ include/linux/fb.h | 2 +- 3 files changed, 5

Re: [PATCH v2] ARM: dts: bcm2835: Enable 3D rendering through V3D

2024-04-16 Thread Florian Fainelli
On 4/16/24 10:21, Conor Dooley wrote: On Tue, Apr 16, 2024 at 07:13:51AM -0300, Maíra Canal wrote: On 4/16/24 02:30, Stefan Wahren wrote: Hi Maíra, Am 16.04.24 um 03:02 schrieb Maíra Canal: On 4/15/24 13:54, Andre Przywara wrote: On Mon, 15 Apr 2024 13:00:39 -0300 Maíra Canal wrote: Hi,

Re: [PATCH] phy: constify of_phandle_args in xlate

2024-02-21 Thread Florian Fainelli
On 2/17/24 01:39, Krzysztof Kozlowski wrote: The xlate callbacks are supposed to translate of_phandle_args to proper provider without modifying the of_phandle_args. Make the argument pointer to const for code safety and readability. Signed-off-by: Krzysztof Kozlowski Acked-by: Florian

Re: [PATCH v5 003/111] pwm: Provide a macro to get the parent device of a given chip

2024-01-25 Thread Florian Fainelli
On 1/25/24 04:08, Uwe Kleine-König wrote: Currently a pwm_chip stores in its struct device *dev member a pointer to the parent device. Preparing a change that embeds a full struct device in struct pwm_chip, this accessor macro should be used in all drivers directly accessing chip->dev now. This w

Re: [PATCH] MAINTAINERS: Change vmware.com addresses to broadcom.com

2023-12-24 Thread Florian Fainelli
: Martin Krastev Cc: Maaz Mombasawala Cc: Broadcom internal kernel review list Cc: dri-devel@lists.freedesktop.org Cc: linux-ker...@vger.kernel.org Acked-by: Florian Fainelli -- Florian smime.p7s Description: S/MIME Cryptographic Signature

Re: [PATCH v2 1/2] pwm: Manage owner assignment implicitly for drivers

2023-08-04 Thread Florian Fainelli
ivers/pwm/pwm-bcm-iproc.c | 1 - drivers/pwm/pwm-bcm-kona.c| 1 - drivers/pwm/pwm-bcm2835.c | 1 - drivers/pwm/pwm-brcmstb.c | 1 - Reviewed-by: Florian Fainelli # pwm-{bcm,brcm}*.c -- Florian smime.p7s Description: S/MIME Cryptographic Signature

Re: [PATCH net-next v6 3/6] net: bcmasp: Add support for ASP2.0 Ethernet controller

2023-06-05 Thread Florian Fainelli
On 6/2/2023 11:58 PM, Jakub Kicinski wrote: On Thu, 1 Jun 2023 15:12:28 -0700 Justin Chen wrote: + /* general stats */ + STAT_NETDEV(rx_packets), + STAT_NETDEV(tx_packets), + STAT_NETDEV(rx_bytes), + STAT_NETDEV(tx_bytes), + STAT_NETDEV(rx_errors), +

Re: [PATCH net-next v5 3/6] net: bcmasp: Add support for ASP2.0 Ethernet controller

2023-05-31 Thread Florian Fainelli
operations (link, counters, message level) - MAC destination address filtering (promiscuous, ALL_MULTI, etc.) Reviewed-by: Simon Horman Signed-off-by: Florian Fainelli Signed-off-by: Justin Chen --- [snip] +static const struct net_device_ops bcmasp_netdev_ops = { + .ndo_open

Re: [PATCH net-next v5 2/6] dt-bindings: net: Brcm ASP 2.0 Ethernet controller

2023-05-31 Thread Florian Fainelli
On 5/31/23 12:31, Krzysztof Kozlowski wrote: On 31/05/2023 21:29, Florian Fainelli wrote: +required: + - reg + - brcm,channel + +additionalProperties: false + +patternProperties: + "^mdio@[0-9a-f]+$": Isn't mdio a property of each ethernet port?

Re: [PATCH net-next v5 2/6] dt-bindings: net: Brcm ASP 2.0 Ethernet controller

2023-05-31 Thread Florian Fainelli
On 5/31/23 12:18, Krzysztof Kozlowski wrote: On 25/05/2023 01:01, Justin Chen wrote: From: Florian Fainelli Add a binding document for the Broadcom ASP 2.0 Ethernet controller. Signed-off-by: Florian Fainelli Signed-off-by: Justin Chen --- v5 - Fix compatible string yaml format to

Re: [PATCH net-next v3 1/6] dt-bindings: net: brcm,unimac-mdio: Add asp-v2.0

2023-05-23 Thread Florian Fainelli
On 5/22/23 11:17, Conor Dooley wrote: On Fri, May 19, 2023 at 02:19:39PM -0700, Justin Chen wrote: > The ASP 2.0 Ethernet controller uses a brcm unimac. > > Signed-off-by: Florian Fainelli > Signed-off-by: Justin Chen > --- >  Documentation/devicetree/bindings/net/brc

Re: [PATCH v2 net-next 1/6] dt-bindings: net: brcm,unimac-mdio: Add asp-v2.0

2023-04-27 Thread Florian Fainelli
On 4/27/23 10:03, Rob Herring wrote: On Wed, Apr 26, 2023 at 11:54:27AM -0700, Justin Chen wrote: The ASP 2.0 Ethernet controller uses a brcm unimac. Signed-off-by: Florian Fainelli Signed-off-by: Justin Chen --- Documentation/devicetree/bindings/net/brcm,unimac-mdio.yaml | 2 ++ 1 file

Re: [PATCH net-next 1/6] dt-bindings: net: Brcm ASP 2.0 Ethernet controller

2023-04-24 Thread Florian Fainelli
On 4/24/23 11:14, Justin Chen wrote: On Fri, Apr 21, 2023 at 12:29 AM Krzysztof Kozlowski wrote: On 19/04/2023 02:10, Justin Chen wrote: From: Florian Fainelli Add a binding document for the Broadcom ASP 2.0 Ethernet controller. Signed-off-by: Florian Fainelli Signed-off-by: Justin Chen

Re: [PATCH net-next 3/6] net: bcmasp: Add support for ASP2.0 Ethernet controller

2023-04-19 Thread Florian Fainelli
On 4/18/23 23:35, Heiner Kallweit wrote: On 19.04.2023 02:10, Justin Chen wrote: Add support for the Broadcom ASP 2.0 Ethernet controller which is first introduced with 72165. This controller features two distinct Ethernet ports that can be independently operated. This patch supports: [snip]

Re: [PATCH v5 0/7] drm/vc4: Fix the core clock behaviour

2022-10-27 Thread Florian Fainelli
On 10/27/2022 7:59 AM, Maxime Ripard wrote: Hi Florian, On Thu, Oct 27, 2022 at 02:52:40PM +0200, Maxime Ripard wrote: Hi, Those patches used to be part of a larger clock fixes series: https://lore.kernel.org/linux-clk/20220715160014.2623107-1-max...@cerno.tech/ However, that series doesn'

Re: [PATCH v5 3/7] firmware: raspberrypi: Provide a helper to query a clock max rate

2022-10-27 Thread Florian Fainelli
ephen Boyd Reviewed-by: Florian Fainelli Signed-off-by: Maxime Ripard Acked-by: Florian Fainelli -- Florian

Re: [PATCH v4 1/7] firmware: raspberrypi: Introduce rpi_firmware_find_node()

2022-10-24 Thread Florian Fainelli
d. Signed-off-by: Maxime Ripard Acked-by: Florian Fainelli Thanks for re-ordering the rpi_firmware_of_match array and avoiding a forward declaration that I was initially confused about in v3. -- Florian

Re: [PATCH v3 3/7] firmware: raspberrypi: Provide a helper to query a clock max rate

2022-10-14 Thread Florian Fainelli
yd Signed-off-by: Maxime Ripard Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v3 2/7] firmware: raspberrypi: Move the clock IDs to the firmware header

2022-10-14 Thread Florian Fainelli
On 10/13/22 02:13, Maxime Ripard wrote: We'll need the clock IDs in more drivers than just the clock driver from now on, so let's move them in the firmware header. Signed-off-by: Maxime Ripard Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v3 1/7] firmware: raspberrypi: Introduce rpi_firmware_find_node()

2022-10-14 Thread Florian Fainelli
On 10/13/22 02:13, Maxime Ripard wrote: A significant number of RaspberryPi drivers using the firmware don't have a phandle to it, so end up scanning the device tree to find a node with the firmware compatible. That code is duplicated everywhere, so let's introduce a helper instead. Signed-off-

Re: [PATCH v2 0/7] drm/vc4: Fix the core clock behaviour

2022-10-10 Thread Florian Fainelli
On 10/10/22 04:44, Maxime Ripard wrote: Hi Florian, On Tue, Sep 20, 2022 at 02:50:19PM +0200, Maxime Ripard wrote: Those patches used to be part of a larger clock fixes series: https://lore.kernel.org/linux-clk/20220715160014.2623107-1-max...@cerno.tech/ However, that series doesn't seem to be

Re: [PATCH 23/33] drm/vc4: hdmi: Move HDMI reset to pm_resume

2022-08-15 Thread Florian Fainelli
On 8/15/22 07:12, Maxime Ripard wrote: On Wed, Aug 10, 2022 at 10:33:48PM +0200, Stefan Wahren wrote: Hi Florian, Am 09.08.22 um 21:02 schrieb Florian Fainelli: On 8/4/22 16:11, Florian Fainelli wrote: On 6/13/22 07:47, Maxime Ripard wrote: From: Dave Stevenson The BCM2835-37 found in the

Re: [PATCH 23/33] drm/vc4: hdmi: Move HDMI reset to pm_resume

2022-08-09 Thread Florian Fainelli
Hallo Stefan, On 8/9/22 13:16, Stefan Wahren wrote: Hi Florian, Am 05.08.22 um 01:11 schrieb Florian Fainelli: On 6/13/22 07:47, Maxime Ripard wrote: From: Dave Stevenson The BCM2835-37 found in the RaspberryPi 0 to 3 have a power domain attached to the HDMI block, handled in Linux through

Re: [PATCH 23/33] drm/vc4: hdmi: Move HDMI reset to pm_resume

2022-08-09 Thread Florian Fainelli
On 8/4/22 16:11, Florian Fainelli wrote: On 6/13/22 07:47, Maxime Ripard wrote: From: Dave Stevenson The BCM2835-37 found in the RaspberryPi 0 to 3 have a power domain attached to the HDMI block, handled in Linux through runtime_pm. That power domain is shared with the VEC block, so even if

Re: [PATCH 23/33] drm/vc4: hdmi: Move HDMI reset to pm_resume

2022-08-04 Thread Florian Fainelli
On 6/13/22 07:47, Maxime Ripard wrote: From: Dave Stevenson The BCM2835-37 found in the RaspberryPi 0 to 3 have a power domain attached to the HDMI block, handled in Linux through runtime_pm. That power domain is shared with the VEC block, so even if we put our runtime_pm reference in the HDMI

Re: [PATCH v6 6/6] arm64: config: Enable DRM_V3D

2022-06-13 Thread Florian Fainelli
On Fri, 3 Jun 2022 10:26:10 +0100, Peter Robinson wrote: > From: Nicolas Saenz Julienne > > BCM2711, the SoC used on the Raspberry Pi 4 has a different GPU than its > predecessors. Enable it. > > Signed-off-by: Nicolas Saenz Julienne > Signed-off-by: Peter Robinson > Reviewed-by: Stefan Wahr

Re: [PATCH v6 5/6] ARM: configs: Enable DRM_V3D

2022-06-13 Thread Florian Fainelli
On Fri, 3 Jun 2022 10:26:09 +0100, Peter Robinson wrote: > BCM2711, the SoC used on the Raspberry Pi 4 has a different 3D > render GPU IP than its predecessors. Enable it it on multi v7 > and bcm2835 configs. > > Signed-off-by: Nicolas Saenz Julienne > Signed-off-by: Peter Robinson > Reviewed-

Re: [PATCH v6 4/6] ARM: dts: bcm2711: Enable V3D

2022-06-13 Thread Florian Fainelli
On Fri, 3 Jun 2022 10:26:08 +0100, Peter Robinson wrote: > This adds the entry for V3D for bcm2711 (used in the Raspberry Pi 4) > and the associated firmware clock entry. > > Signed-off-by: Nicolas Saenz Julienne > Signed-off-by: Peter Robinson > Reviewed-by: Javier Martinez Canillas > --- A

Re: [PATCH v6 0/6] Raspberry PI 4 V3D enablement

2022-06-08 Thread Florian Fainelli
On 6/3/2022 11:26 AM, Peter Robinson wrote: This is a follow up from my v4 patchset. The power management pieces have been split out to a separate independent set of patches by Stefan [1]. This version 5 of the DRM patches are independent and given the V3D driver has been upstream for some tim

Re: [PATCH net-next 3/5] net: bcmasp: Add support for ASP2.0 Ethernet controller

2021-09-25 Thread Florian Fainelli
On 9/25/2021 9:45 AM, Andrew Lunn wrote: [snip] + priv->clk = devm_clk_get(dev, "sw_asp"); + if (IS_ERR(priv->clk)) { + if (PTR_ERR(priv->clk) == -EPROBE_DEFER) + return -EPROBE_DEFER; + dev_warn(dev, "failed to request clock\n");

Re: [PATCH net-next 0/5] brcm ASP 2.0 Ethernet controller

2021-09-25 Thread Florian Fainelli
Hi Andrew, On 9/25/2021 7:25 AM, Andrew Lunn wrote: On Fri, Sep 24, 2021 at 02:44:46PM -0700, Justin Chen wrote: This patch set adds support for Broadcom's ASP 2.0 Ethernet controller. Hi Justin Does the hardware support L2 switching between the two ports? I'm just wondering if later this i

Re: [PATCH v2 12/12] ARM: dts: bcm2711: Tune DMA parameters for HDMI audio

2021-05-25 Thread Florian Fainelli
On 5/25/2021 6:23 AM, Maxime Ripard wrote: > From: Dom Cobley > > Enable NO_WAIT_RESP, DMA_WIDE_SOURCE, DMA_WIDE_DEST, and bump the DMA > panic and AXI priorities to avoid any DMA transfer error with HBR audio > (8 channel, 192Hz). > > Signed-off-by: Dom Cobley > Signed-off-by: Maxime Ripard

Re: [PATCH v7 02/15] swiotlb: Refactor swiotlb_create_debugfs

2021-05-19 Thread Florian Fainelli
On 5/17/2021 11:42 PM, Claire Chang wrote: > Split the debugfs creation to make the code reusable for supporting > different bounce buffer pools, e.g. restricted DMA pool. > > Signed-off-by: Claire Chang Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v7 07/15] swiotlb: Update is_swiotlb_active to add a struct device argument

2021-05-19 Thread Florian Fainelli
On 5/17/2021 11:42 PM, Claire Chang wrote: > Update is_swiotlb_active to add a struct device argument. This will be > useful later to allow for restricted DMA pool. > > Signed-off-by: Claire Chang Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v7 06/15] swiotlb: Update is_swiotlb_buffer to add a struct device argument

2021-05-19 Thread Florian Fainelli
On 5/17/2021 11:42 PM, Claire Chang wrote: > Update is_swiotlb_buffer to add a struct device argument. This will be > useful later to allow for restricted DMA pool. > > Signed-off-by: Claire Chang Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v7 05/15] swiotlb: Add a new get_io_tlb_mem getter

2021-05-19 Thread Florian Fainelli
On 5/17/2021 11:42 PM, Claire Chang wrote: > Add a new getter, get_io_tlb_mem, to help select the io_tlb_mem struct. > The restricted DMA pool is preferred if available. > > Signed-off-by: Claire Chang Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v7 03/15] swiotlb: Add DMA_RESTRICTED_POOL

2021-05-19 Thread Florian Fainelli
On 5/17/2021 11:42 PM, Claire Chang wrote: > Add a new kconfig symbol, DMA_RESTRICTED_POOL, for restricted DMA pool. > > Signed-off-by: Claire Chang Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v7 11/15] dma-direct: Add a new wrapper __dma_direct_free_pages()

2021-05-19 Thread Florian Fainelli
On 5/17/2021 11:42 PM, Claire Chang wrote: > Add a new wrapper __dma_direct_free_pages() that will be useful later > for swiotlb_free(). > > Signed-off-by: Claire Chang Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v7 04/15] swiotlb: Add restricted DMA pool initialization

2021-05-19 Thread Florian Fainelli
(!mem) > + return -ENOMEM; > + > + if (PageHighMem(pfn_to_page(PHYS_PFN(rmem->base { > + kfree(mem); > + return -EINVAL; This could probably deserve a warning here to indicate that the reserved area must be accessible within the linear mapping as I would expect a lot of people to trip over that. Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v7 01/15] swiotlb: Refactor swiotlb init functions

2021-05-19 Thread Florian Fainelli
On 5/17/2021 11:42 PM, Claire Chang wrote: > Add a new function, swiotlb_init_io_tlb_mem, for the io_tlb_mem struct > initialization to make the code reusable. > > Note that we now also call set_memory_decrypted in swiotlb_init_with_tbl. > > Signed-off-by: Claire Chang > --- > kernel/dma/swi

Re: [PATCH] Revert "ARM: dts: bcm2711: Add the BSC interrupt controller"

2021-02-16 Thread Florian Fainelli
On 2/12/2021 11:11 AM, Florian Fainelli wrote: > As Dave reported: > > This seems to have unintended side effects. GIC interrupt 117 is shared > between the standard I2C controllers (i2c-bcm2835) and the l2-intc block > handling the HDMI I2C interrupts. > > There is not

[PATCH] Revert "ARM: dts: bcm2711: Add the BSC interrupt controller"

2021-02-12 Thread Florian Fainelli
IRQ handler which is an interrupt flow and another driver like i2c-bcm2835 which uses an interrupt handler (although it specifies IRQF_SHARED). Simply revert this change for now which will mean that HDMI I2C will be polled, like it was before. Reported-by: Dave Stevenson Signed-off-by: Florian

Re: [PATCH v2 14/15] ARM: dts: bcm2711: Add the BSC interrupt controller

2021-02-10 Thread Florian Fainelli
On 2/10/21 7:49 AM, Dave Stevenson wrote: > Hi Marc. > > On Wed, 10 Feb 2021 at 15:30, Marc Zyngier wrote: >> >> Hi Maxime, >> >> On 2021-02-10 14:40, Maxime Ripard wrote: >>> Hi Dave, >>> >>> On Tue, Feb 09, 2021 at 09:49:05AM +, Dave Stevenson wrote: On Mon, 11 Jan 2021 at 14:23, Maxim

Re: [PATCH v2 01/15] ARM: bcm: Select BRCMSTB_L2_IRQ for bcm2835

2021-01-11 Thread Florian Fainelli
; Signed-off-by: Maxime Ripard Acked-by: Florian Fainelli Nicolas, I suppose you will be taking patches 1 and 14, 15 through the SoC pull request, right? -- Florian ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.o

Re: [PATCH] dt-bindings: bcm2835-vec: Add power-domains property

2021-01-08 Thread Florian Fainelli
On 1/7/2021 6:42 PM, Rob Herring wrote: > On Wed, 23 Dec 2020 20:24:33 +0100, Stefan Wahren wrote: >> Adding the missing property power-domains to the bcm2835-vec schema to fix >> the following dtbs_check issue: >> >> vec@7e806000: 'power-domains' does not match any of the regexes: ... >> >> Sig

Re: [PATCH] dt-bindings: bcm2835-vec: Add power-domains property

2020-12-25 Thread Florian Fainelli
On 12/23/2020 11:24 AM, Stefan Wahren wrote: > Adding the missing property power-domains to the bcm2835-vec schema to fix > the following dtbs_check issue: > > vec@7e806000: 'power-domains' does not match any of the regexes: ... > > Signed-off-by: Stefan Wahren

Re: [PATCH 0/4] drm/v3d: Minor improvements

2020-12-25 Thread Florian Fainelli
On 12/23/2020 1:39 PM, Florian Fainelli wrote: > > > On 12/23/2020 12:27 PM, Stefan Wahren wrote: >> This small series of v3d patches is a preparation for the upcoming bcm2711 >> support. The bcm2711 support will be send separate, because it involves >> bigger chang

Re: [PATCH 0/4] drm/v3d: Minor improvements

2020-12-25 Thread Florian Fainelli
On 12/23/2020 12:27 PM, Stefan Wahren wrote: > This small series of v3d patches is a preparation for the upcoming bcm2711 > support. The bcm2711 support will be send separate, because it involves > bigger changes. > > I'm not sure that the schema conversion patch is sufficient. > > Patch 2,3 a

Re: [PATCH 15/15] ARM: dts: bcm2711: Add the CEC interrupt controller

2020-12-11 Thread Florian Fainelli
axime Ripard Reviewed-by: Florian Fainelli -- Florian ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 01/15] irqchip: Allow to compile bcmstb on other platforms

2020-12-11 Thread Florian Fainelli
On 12/10/2020 5:46 AM, Maxime Ripard wrote: > The BCM2711 uses a number of instances of the bcmstb-l2 controller in its > display engine. Let's allow the driver to be enabled through KConfig. > > Signed-off-by: Maxime Ripard Acked-by: Florian Fain

Re: [PATCH 14/15] ARM: dts: bcm2711: Add the BSC interrupt controller

2020-12-11 Thread Florian Fainelli
On 12/10/2020 5:46 AM, Maxime Ripard wrote: > The BSC controllers used for the HDMI DDC have an interrupt controller > shared between both instances. Let's add it to avoid polling. > > Signed-off-by: Maxime Ripard Reviewed-by: Florian Fain

Re: [PATCH v11 00/11] PCI: brcmstb: enable PCIe for STB chips

2020-09-08 Thread Florian Fainelli
On 9/7/2020 10:43 AM, Jim Quinlan wrote: On Mon, Sep 7, 2020 at 5:16 AM Lorenzo Pieralisi wrote: On Thu, Aug 27, 2020 at 09:29:59AM -0400, Jim Quinlan wrote: On Thu, Aug 27, 2020 at 2:35 AM Christoph Hellwig wrote: On Tue, Aug 25, 2020 at 10:40:27AM -0700, Florian Fainelli wrote: Hi

Re: [PATCH v11 07/11] device-mapping: Introduce DMA range map, supplanting dma_pfn_offset

2020-09-03 Thread Florian Fainelli
On 9/2/2020 3:38 PM, Nathan Chancellor wrote: [snip] Hello Nathan, Can you tell me how much memory your RPI has and if all of it is This is the 4GB version. accessible by the PCIe device? Could you also please include the DTS of the PCIe node? IIRC, the RPI firmware does some mangling o

Re: [PATCH v11 00/11] PCI: brcmstb: enable PCIe for STB chips

2020-08-26 Thread Florian Fainelli
Hi, On 8/24/2020 12:30 PM, Jim Quinlan wrote: Patchset Summary: Enhance a PCIe host controller driver. Because of its unusual design we are foced to change dev->dma_pfn_offset into a more general role allowing multiple offsets. See the 'v1' notes below for more info. We are version

Re: [PATCH v8 00/12] PCI: brcmstb: enable PCIe for STB chips

2020-07-21 Thread Florian Fainelli
On 7/15/20 7:35 AM, Jim Quinlan wrote: > Patchset Summary: > Enhance a PCIe host controller driver. Because of its unusual design > we are foced to change dev->dma_pfn_offset into a more general role > allowing multiple offsets. See the 'v1' notes below for more info. Christoph, Robin, are

Re: [PATCH v4 1/5] mtd: rawnand: brcmnand: rename v4 registers

2020-05-23 Thread Florian Fainelli
On 5/22/2020 5:15 AM, Álvaro Fernández Rojas wrote: > These registers are also used on v3.3. > > Signed-off-by: Álvaro Fernández Rojas > Reviewed-by: Miquel Raynal Acked-by: Florian Fainelli -- Florian ___ dri-devel mailing li

Re: [PATCH v4 3/5] mtd: rawnand: brcmnand: rename page sizes

2020-05-23 Thread Florian Fainelli
On 5/22/2020 5:15 AM, Álvaro Fernández Rojas wrote: > Current pages sizes apply to controllers after v3.4 > > Signed-off-by: Álvaro Fernández Rojas Acked-by: Florian Fainelli -- Florian ___ dri-devel mailing list dri-devel@lists.freede

Re: [PATCH v4 5/5] mtd: rawnand: brcmnand: support v2.1-v2.2 controllers

2020-05-23 Thread Florian Fainelli
On 5/22/2020 5:15 AM, Álvaro Fernández Rojas wrote: > v2.1: tested on Netgear DGND3700v1 (BCM6368) > v2.2: tested on Netgear DGND3700v2 (BCM6362) > > Signed-off-by: Álvaro Fernández Rojas Acked-by: Florian Fainelli -- Florian ___ dri-d

Re: [PATCH v4 4/5] dt: bindings: brcmnand: add v2.1 and v2.2 support

2020-05-23 Thread Florian Fainelli
On 5/22/2020 5:15 AM, Álvaro Fernández Rojas wrote: > Added brcm,brcmnand-v2.1 and brcm,brcmnand-v2.2 as possible compatible > strings to support brcmnand controllers v2.1 and v2.2. > > Signed-off-by: Álvaro Fernández Rojas Acked-by: Florian Fainelli

Re: [PATCH v4 2/5] mtd: rawnand: brcmnand: fix CS0 layout

2020-05-23 Thread Florian Fainelli
) > Signed-off-by: Álvaro Fernández Rojas Acked-by: Florian Fainelli -- Florian ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 3/3] nand: brcmnand: support v2.1-v2.2 controllers

2020-05-11 Thread Florian Fainelli
On 5/10/2020 8:14 AM, Álvaro Fernández Rojas wrote: > Tested on Netgear DGND3700v2 (BCM6362 with v2.2 controller). > > Signed-off-by: Álvaro Fernández Rojas Can you fix a couple of things for your future submissions: - for patch count > 1, please provide a cover letter introducing your patche

Re: [PATCH] nand: brcmnand: correctly verify erased pages

2020-05-05 Thread Florian Fainelli
On 5/4/2020 2:29 AM, Álvaro Fernández Rojas wrote: > The current code checks that the whole OOB area is erased. > This is a problem when JFFS2 cleanmarkers are added to the OOB, since it will > fail due to the usable OOB bytes not being 0xff. > Correct this by only checking that the ECC aren't 0x

Re: [PATCH v2 01/91] i2c: brcmstb: Allow to compile it on BCM2835

2020-04-24 Thread Florian Fainelli
On 4/24/2020 9:13 AM, Wolfram Sang wrote: > >> config I2C_BRCMSTB >> tristate "BRCM Settop/DSL I2C controller" >> -depends on ARCH_BRCMSTB || BMIPS_GENERIC || ARCH_BCM_63XX || \ >> - COMPILE_TEST >> +depends on ARCH_BCM2835 || ARCH_BRCMSTB || BMIPS_GENERIC || \ >> +

Re: [PATCH 02/89] dt-bindings: i2c: brcmstb: Add BCM2711 BSC/AUTO-I2C binding

2020-02-25 Thread Florian Fainelli
gister range, > which will allow us to use or or the other in the driver without > changing anything in the DT. > > Cc: Kamal Dasu > Cc: Florian Fainelli > Cc: Rob Herring > Cc: Wolfram Sang > Cc: bcm-kernel-feedback-l...@broadcom.com > Cc: linux-...@vger.kernel.org &

Re: [PATCH 22/89] clk: bcm: rpi: Discover the firmware clocks

2020-02-25 Thread Florian Fainelli
On 2/24/20 1:06 AM, Maxime Ripard wrote: > The firmware has an interface to discover the clocks it exposes. > > Let's use it to discover, register the clocks in the clocks framework and > then expose them through the device tree for consumers to use them. > > Cc: Michael Turquette > Cc: Stephen

Re: [PATCH 03/89] i2c: brcmstb: Support BCM2711 HDMI BSC controllers

2020-02-25 Thread Florian Fainelli
tie the AUTO_I2C registers with a > separate compatible so that we can enable AUTO_I2C if needed in the > future. > > The AUTO_I2C is enabled by default at boot though, so we first need to > release the BSC from the AUTO_I2C control. > > Cc: Kamal Dasu > Cc: Florian Fainelli

Re: [PATCH 01/89] dt-bindings: i2c: brcmstb: Convert the BRCMSTB binding to a schema

2020-02-25 Thread Florian Fainelli
On 2/24/20 1:06 AM, Maxime Ripard wrote: > Switch the DT binding to a YAML schema to enable the DT validation. > > Cc: Kamal Dasu > Cc: Florian Fainelli > Cc: Rob Herring > Cc: Wolfram Sang > Cc: bcm-kernel-feedback-l...@broadcom.com > Cc: linux-...@vger.

Re: [PATCH 04/89] i2c: brcmstb: Allow to compile it on BCM2835

2020-02-25 Thread Florian Fainelli
On 2/24/20 1:06 AM, Maxime Ripard wrote: > The BCM2711, supported by ARCH_BCM2835, also has a controller by the > brcmstb driver so let's allow it to be compiled on that platform. > > Cc: Kamal Dasu > Cc: Florian Fainelli > Cc: Wolfram Sang > Cc: bcm-kernel-feedb

Re: [PATCH] MIPS: c-r4k: Invalidate BMIPS5000 ZSCM prefetch lines

2020-02-07 Thread Florian Fainelli
essor access. Add support to inavalidate BMIPS5000 cpu zephyr s/inavalidate/invalidate/ > secondary cache module (ZSCM) on DMA from device so that data returned is > coherent during DMA read operations. Just a few nits, see below, with those addressed: Reviewed-by: Florian Fainelli

Re: [PATCH] gpu/drm/v3d: Add ARCH_BCM2835 to DRM_V3D Kconfig

2019-12-19 Thread Florian Fainelli
On 12/18/19 6:39 AM, Nicolas Saenz Julienne wrote: > Hi Peter, > > On Wed, 2019-12-18 at 08:43 +, Peter Robinson wrote: >> On arm64 the config ARCH_BCM doesn't exist so to be able to >> build for platforms such as the Raspberry Pi 4 we need to add >> ARCH_BCM2835 similar to what has been done

Re: [PATCH] Revert "ARM: bcm283x: Switch V3D over to using the PM driver instead of firmware."

2019-10-09 Thread Florian Fainelli
On 10/9/19 2:33 PM, Stefan Wahren wrote: > Hi Florian, > > Am 23.09.19 um 20:56 schrieb Florian Fainelli: >> >> On 9/8/2019 8:44 AM, Stefan Wahren wrote: >>> Since release of the new BCM2835 PM driver there has been several reports >>> of V3D probing is

Re: [PATCH 00/11] of: Fix DMA configuration for non-DT masters

2019-10-02 Thread Florian Fainelli
On 9/26/2019 4:20 AM, Robin Murphy wrote: > On 2019-09-26 11:44 am, Nicolas Saenz Julienne wrote: >> Robin, have you looked into supporting multiple dma-ranges? It's the >> next thing >> we need for BCM STB's PCIe. I'll have a go at it myself if nothing >> is in >> the >>

Re: [PATCH] Revert "ARM: bcm283x: Switch V3D over to using the PM driver instead of firmware."

2019-09-24 Thread Florian Fainelli
On 9/8/2019 8:44 AM, Stefan Wahren wrote: > Since release of the new BCM2835 PM driver there has been several reports > of V3D probing issues. This is caused by timeouts during powering-up the > GRAFX PM domain: > > bcm2835-power: Timeout waiting for grafx power OK > > I was able to reproduce

Re: [PATCH] Revert "ARM: bcm283x: Switch V3D over to using the PM driver instead of firmware."

2019-09-20 Thread Florian Fainelli
On 9/8/19 8:44 AM, Stefan Wahren wrote: > Since release of the new BCM2835 PM driver there has been several reports > of V3D probing issues. This is caused by timeouts during powering-up the > GRAFX PM domain: > > bcm2835-power: Timeout waiting for grafx power OK > > I was able to reproduce thi

  1   2   >