Re: [PATCH v6 1/6] fbdev/matrox: Remove trailing whitespaces

2023-05-12 Thread Finn Thain
On Thu, 11 May 2023, Thomas Zimmermann wrote: > But I'd really like to see most of these drivers being moved into > staging and deleted soon afterwards. Users will complain about those > drivers that are really still required. Those might be worth to spend > effort on. > That strategy is not

Re: [PATCH v2 05/10] drm/fourcc: Add DRM_FORMAT_C[124]

2022-03-15 Thread Finn Thain
Hi Geert, On Mon, 14 Mar 2022, Geert Uytterhoeven wrote: > On Mon, Mar 14, 2022 at 4:05 PM Pekka Paalanen wrote: > > On Mon, 14 Mar 2022 14:30:18 +0100 > > Geert Uytterhoeven wrote: > > > On Mon, Mar 7, 2022 at 9:53 PM Geert Uytterhoeven > > > wrote: > > > > Introduce fourcc codes for color-i

Re: [Intel-wired-lan] [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-26 Thread Finn Thain
On Wed, 25 Nov 2020, Nick Desaulniers wrote: > On Wed, Nov 25, 2020 at 1:33 PM Finn Thain > wrote: > > > > Or do you think that a codebase can somehow satisfy multiple checkers > > and their divergent interpretations of the language spec? > > Have we found any c

Re: [Intel-wired-lan] [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-26 Thread Finn Thain
On Wed, 25 Nov 2020, Nick Desaulniers wrote: > On Wed, Nov 25, 2020 at 1:33 PM Finn Thain wrote: > > > > Or do you think that a codebase can somehow satisfy multiple checkers > > and their divergent interpretations of the language spec? > > Have we found any case

Re: [Intel-wired-lan] [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-26 Thread Finn Thain
On Wed, 25 Nov 2020, Nick Desaulniers wrote: > So developers and distributions using Clang can't have > -Wimplicit-fallthrough enabled because GCC is less strict (which has > been shown in this thread to lead to bugs)? We'd like to have nice > things too, you know. > Apparently the GCC devel

Re: [Intel-wired-lan] [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-25 Thread Finn Thain
On Tue, 24 Nov 2020, Kees Cook wrote: > On Mon, Nov 23, 2020 at 08:31:30AM -0800, James Bottomley wrote: > > Really, no ... something which produces no improvement has no value at > > all ... we really shouldn't be wasting maintainer time with it because > > it has a cost to merge. I'm not sure

Re: [Intel-wired-lan] [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-25 Thread Finn Thain
On Wed, 25 Nov 2020, Miguel Ojeda wrote: > > The C standard has nothing to do with this. We use compiler extensions > of several kinds, for many years. Even discounting those extensions, the > kernel is not even conforming to C due to e.g. strict aliasing. I am not > sure what you are trying

Re: [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-24 Thread Finn Thain
On Mon, 23 Nov 2020, Miguel Ojeda wrote: > On Mon, 23 Nov 2020, Finn Thain wrote: > > > On Sun, 22 Nov 2020, Miguel Ojeda wrote: > > > > > > > > It isn't that much effort, isn't it? Plus we need to take into > > > account the future

Re: [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-24 Thread Finn Thain
On Mon, 23 Nov 2020, Joe Perches wrote: > On Tue, 2020-11-24 at 11:58 +1100, Finn Thain wrote: > > it's not for me to prove that such patches don't affect code > > generation. That's for the patch author and (unfortunately) for > > reviewers. > > Id

Re: [RFC] clang tooling cleanups

2020-10-28 Thread Finn Thain
On Tue, 27 Oct 2020, t...@redhat.com wrote: > This rfc will describe > An upcoming treewide cleanup. > How clang tooling was used to programatically do the clean up. > Solicit opinions on how to generally use clang tooling. > This tooling is very impressive. It makes possible an idea that I ha

Re: [PATCH v2 1/2] video: fbdev: amifb: add FIXME about dead APUS support

2020-06-03 Thread Finn Thain
On Tue, 2 Jun 2020, Al Viro wrote: > I have done that on aranym (which is how I'd been doing all testing for > e.g. signal-related m68k patches) and I've seen references to some > out-of-tree qemu variant doing quadra, but nothing for amiga > emulators... > Laurent Vivier's Quadra 800 emulati

Re: [PATCH 1/3] fbdev/g364fb: Fix build failure

2020-02-07 Thread Finn Thain
On Fri, 7 Feb 2020, Philippe Mathieu-Daudé wrote: > On Wed, Feb 5, 2020 at 11:18 PM Finn Thain > wrote: > > On Wed, 5 Feb 2020, Philippe Mathieu-Daudé wrote: > > > On Sun, Feb 2, 2020 at 3:41 AM Finn Thain > > > wrote: > > > > > > > >

[PATCH v2 1/3] fbdev/g364fb: Fix build failure

2020-02-07 Thread Finn Thain
ble 'j' [-Wunused-variable] drivers/video/fbdev/g364fb.c:197:25: warning: unused variable 'pal_ptr' [-Wunused-variable] The MIPS Magnum framebuffer console now works when tested in QEMU. Cc: Bartlomiej Zolnierkiewicz Fixes: 1da177e4c3f4 ("Linux-

[PATCH v2 0/3] Improve MIPS Magnum support

2020-02-07 Thread Finn Thain
vents the Linux jazzsonic driver from probing the chip. I have fixed the bugs that I know of in a series of patches at, https://github.com/fthain/qemu/commits/sonic Changed since v1: - Added reviewed-by and tested-by tags from Philippe Mathieu-Daudé. - Rebased. Finn Thain (3): fbdev/g364fb: Fi

Re: [PATCH 1/3] fbdev/g364fb: Fix build failure

2020-02-06 Thread Finn Thain
On Wed, 5 Feb 2020, Philippe Mathieu-Daudé wrote: > Note, you need to rebase your series due to: > > commit 8a48ac339398f21282985bff16552447d41dcfb2 > Author: Jani Nikula > Date: Tue Dec 3 18:38:50 2019 +0200 > > video: constify fb ops across all drivers > OK. Thanks for your r

Re: [PATCH 1/3] fbdev/g364fb: Fix build failure

2020-02-06 Thread Finn Thain
On Wed, 5 Feb 2020, Philippe Mathieu-Daudé wrote: > On Sun, Feb 2, 2020 at 3:41 AM Finn Thain wrote: > > > > This patch resolves these compiler errors and warnings -- > > > > CC drivers/video/fbdev/g364fb.o > > drivers/video/fbdev/g364fb.c: In function &

[PATCH 0/3] Improve MIPS Magnum support

2020-02-03 Thread Finn Thain
vents the Linux jazzsonic driver from probing the chip. I have fixed the bugs that I know of in a series of patches at, https://github.com/fthain/qemu/commits/sonic Finn Thain (3): fbdev/g364fb: Fix build failure mips/jazz: Remove redundant settings and shrink jazz_defconfig mips/jazz: Update

[PATCH 1/3] fbdev/g364fb: Fix build failure

2020-02-03 Thread Finn Thain
ble 'j' [-Wunused-variable] drivers/video/fbdev/g364fb.c:197:25: warning: unused variable 'pal_ptr' [-Wunused-variable] The MIPS Magnum framebuffer console now works when tested in QEMU. Cc: Bartlomiej Zolnierkiewicz Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signe

Re: [PATCH AUTOSEL 4.4 44/56] video: imsttfb: fix potential NULL pointer dereferences

2019-06-01 Thread Finn Thain
e: Mon, 1 Apr 2019 17:46:58 +0200 Subject: [PATCH] video: imsttfb: fix potential NULL pointer dereferences In case ioremap fails, the fix releases resources and returns -ENOMEM to avoid NULL pointer dereferences. Signed-off-by: Kangjie Lu Cc: Aditya Pakki Cc: Finn Thain Cc: Rob Herring Cc: Greg

[PATCH] video/macfb: Always initialize DAFB colour table pointer register

2019-02-19 Thread Finn Thain
Don't skip the framebuffer CLUT pointer register initialization when the first dafb_setpalette() invocation has regno equal to zero. Cc: linux-m...@lists.linux-m68k.org Suggested-by: Geert Uytterhoeven Signed-off-by: Finn Thain --- drivers/video/fbdev/macfb.c | 2 +- 1 file chang

[PATCH] video/macfb: Call fb_invert_cmaps()

2019-02-18 Thread Finn Thain
The 'inverse' parameter has no effect otherwise. Remove set-but-unused variable. Cc: linux-m...@lists.linux-m68k.org Signed-off-by: Finn Thain --- drivers/video/fbdev/macfb.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/video/fbdev/macfb.c b/drivers/v

[PATCH] video/macfb: Remove redundant code

2019-02-18 Thread Finn Thain
get assigned unconditionally. Remove redundant initializers. Cc: linux-m...@lists.linux-m68k.org Tested-by: Stan Johnson Signed-off-by: Finn Thain --- drivers/video/fbdev/macfb.c | 24 1 file changed, 24 deletions(-) diff --git a/drivers/video/fbdev/macfb.c b/drivers/vi

Re: [PATCH v9 00/22] Re-use nvram module

2019-01-23 Thread Finn Thain
On Tue, 22 Jan 2019, Greg Kroah-Hartman wrote: > On Tue, Jan 15, 2019 at 03:18:56PM +1100, Finn Thain wrote: > > The "generic" NVRAM module, drivers/char/generic_nvram.c, implements a > > /dev/nvram misc device. This module is used only by 32-bit PowerPC > > pl

[PATCH v9 06/22] powerpc: Replace nvram_* extern declarations with standard header

2019-01-14 Thread Finn Thain
Remove the nvram_read_byte() and nvram_write_byte() declarations in powerpc/include/asm/nvram.h and use the cross-platform static functions in linux/nvram.h instead. Tested-by: Stan Johnson Signed-off-by: Finn Thain --- Changed since v8: - Added nvram_read_byte() and nvram_write_byte

[PATCH v9 19/22] powerpc, fbdev: Use NV_CMODE and NV_VMODE only when CONFIG_PPC32 && CONFIG_PPC_PMAC && CONFIG_NVRAM

2019-01-14 Thread Finn Thain
* See GetPreferredConfiguration and SavePreferredConfiguration in "Designing PCI Cards and Drivers for Power Macintosh Computers". ** See SetDefaultMode and GetDefaultMode in "Designing Cards and Drivers for the Macintosh Family". Signed-off-by: Finn Thain --- Changed sinc

[PATCH v9 00/22] Re-use nvram module

2019-01-14 Thread Finn Thain
- Changed the CONFIG_NVRAM default to better approximate the present code. In particular, the CONFIG_GENERIC_NVRAM default and use of "select NVRAM". - Added more tested-by tags. For older change logs, please refer to, https://lore.kernel.org/lkml/20151101104202.301856...@telegraphics.com.a

Re: [PATCH v8 20/25] powerpc, fbdev: Use arch_nvram_ops methods instead of nvram_read_byte() and nvram_write_byte()

2019-01-07 Thread Finn Thain
On Sun, 30 Dec 2018, I wrote: > On Sat, 29 Dec 2018, LEROY Christophe wrote: > > > Finn Thain a ?crit?: > > > > > Make use of arch_nvram_ops in device drivers so that the nvram_* function > > > exports can be removed. > > > > > > Sin

Re: [PATCH v8 20/25] powerpc, fbdev: Use arch_nvram_ops methods instead of nvram_read_byte() and nvram_write_byte()

2019-01-01 Thread Finn Thain
On Mon, 31 Dec 2018, Arnd Bergmann wrote: > On Sun, Dec 30, 2018 at 12:43 AM Finn Thain > wrote: > > > > > Is there some benefit, or is that just personal taste? > > > > Avoiding changes to call sites avoids code review, but I think 1) the > > thinkpad_

Re: [PATCH v8 20/25] powerpc, fbdev: Use arch_nvram_ops methods instead of nvram_read_byte() and nvram_write_byte()

2019-01-01 Thread Finn Thain
On Sat, 29 Dec 2018, LEROY Christophe wrote: > Finn Thain a ?crit?: > > > Make use of arch_nvram_ops in device drivers so that the nvram_* function > > exports can be removed. > > > > Since they are no longer global symbols, rename the PPC32 nvram_* functions >

[PATCH v8 20/25] powerpc, fbdev: Use arch_nvram_ops methods instead of nvram_read_byte() and nvram_write_byte()

2018-12-26 Thread Finn Thain
Make use of arch_nvram_ops in device drivers so that the nvram_* function exports can be removed. Since they are no longer global symbols, rename the PPC32 nvram_* functions appropriately. Signed-off-by: Finn Thain --- arch/powerpc/kernel/setup_32.c | 8 drivers/char

[PATCH v8 19/25] powerpc, fbdev: Use NV_CMODE and NV_VMODE only when CONFIG_PPC32 && CONFIG_PPC_PMAC && CONFIG_NVRAM

2018-12-26 Thread Finn Thain
Macintosh Computers". ** See SetDefaultMode and GetDefaultMode in "Designing Cards and Drivers for the Macintosh Family". Signed-off-by: Finn Thain --- drivers/video/fbdev/Kconfig| 2 +- drivers/video/fbdev/imsttfb.c | 12 +--- drivers/video/fbd

[PATCH v8 15/25] powerpc: Clean up nvram includes

2018-12-26 Thread Finn Thain
The nvram_read_byte() and nvram_write_byte() definitions in asm/nvram.h duplicate those in linux/nvram.h. Get rid of the former to prepare for adoption of struct arch_nvram_ops (which is defined in linux/nvram.h for general use). Signed-off-by: Finn Thain Tested-by: Stan Johnson --- arch

Re: [PATCH 09/12] nubus: use for_each_if

2018-07-09 Thread Finn Thain
On Mon, 9 Jul 2018, Daniel Vetter wrote: > Avoids the inverted check compared to the open-coded version. > > Signed-off-by: Daniel Vetter > Cc: Finn Thain > Cc: linux-m...@lists.linux-m68k.org Acked-by: Finn Thain > --- > include/linux/nubus.h | 2 +- > 1 file ch

[RFC v5]update broken web addresses in the kernel.

2010-09-28 Thread Finn Thain
tch to fix broken web addresses in the kernel. > > > Please let me know if I missed anything, and I'll go back and fix it. > > > and lastly Thanks for all the help with this... > > > > > > Signed-off-by: Justin P. Mattock > > > Cc: Maciej W. Rozycki &g

[RFC v5]update broken web addresses in the kernel.

2010-09-28 Thread Finn Thain
ned-off-by: Justin P. Mattock > Cc: Maciej W. Rozycki > Cc: Geert Uytterhoeven > Cc: Finn Thain > Cc: Randy Dunlap > Cc: Matt Turner > Cc: Dimitry Torokhov > Cc: Mike Frysinger > Acked-by: Ben Pfaff > Acked-by: Hans J. Koch > > --- > drivers/ata/pata_i

[RFC v4]update broken web addresses in the kernel.

2010-09-28 Thread Finn Thain
On Mon, 27 Sep 2010, Justin P. Mattock wrote: > alright.. I'll redu this... remove the brackets, and fix up the rest.. > one note is: > http://dri.freedesktop.org/wiki/Documentation > this address is already there.. Right you are. > probably best to just leave the sourceforge > address and use

[RFC v4]update broken web addresses in the kernel.

2010-09-28 Thread Finn Thain
On Sun, 26 Sep 2010, Justin P. Mattock wrote: > diff --git a/drivers/char/apm-emulation.c b/drivers/char/apm-emulation.c > index 033e150..d7d9a78 100644 > --- a/drivers/char/apm-emulation.c > +++ b/drivers/char/apm-emulation.c > @@ -8,7 +8,7 @@ > * (APM) BIOS Interface Specification, Revision

[RFC v4]update broken web addresses in the kernel.

2010-09-28 Thread Finn Thain
On Mon, 27 Sep 2010, Justin P. Mattock wrote: > On 09/27/2010 09:03 AM, Joe Perches wrote: > > On Mon, 2010-09-27 at 11:10 -0400, John W. Linville wrote: > > > On Sun, Sep 26, 2010 at 11:31:15AM -0700, Justin P. Mattock wrote: > > > > Below is an updated patch from the original fixing broken web

Re: [RFC v4]update broken web addresses in the kernel.

2010-09-27 Thread Finn Thain
On Mon, 27 Sep 2010, Justin P. Mattock wrote: > alright.. I'll redu this... remove the brackets, and fix up the rest.. > one note is: > http://dri.freedesktop.org/wiki/Documentation > this address is already there.. Right you are. > probably best to just leave the sourceforge > address and use

Re: [RFC v4]update broken web addresses in the kernel.

2010-09-27 Thread Finn Thain
On Sun, 26 Sep 2010, Justin P. Mattock wrote: > diff --git a/drivers/char/apm-emulation.c b/drivers/char/apm-emulation.c > index 033e150..d7d9a78 100644 > --- a/drivers/char/apm-emulation.c > +++ b/drivers/char/apm-emulation.c > @@ -8,7 +8,7 @@ > * (APM) BIOS Interface Specification, Revision

Re: [RFC v4]update broken web addresses in the kernel.

2010-09-27 Thread Finn Thain
On Mon, 27 Sep 2010, Justin P. Mattock wrote: > On 09/27/2010 09:03 AM, Joe Perches wrote: > > On Mon, 2010-09-27 at 11:10 -0400, John W. Linville wrote: > > > On Sun, Sep 26, 2010 at 11:31:15AM -0700, Justin P. Mattock wrote: > > > > Below is an updated patch from the original fixing broken web