Re: [PATCH 2/2] dt-bindings: samsung, mipi-dsim: Add imx7d specific compatible

2025-01-08 Thread Fabio Estevam
On Tue, Jan 7, 2025 at 8:21 PM Rob Herring (Arm) wrote: > Fabio is clearly confused, and I prefer this patch over his. As > it is probably past the drm-misc cutoff, I applied it to DT tree. You are right. I am sorry for the confusion.

Re: [PATCH 2/2] dt-bindings: samsung, mipi-dsim: Add imx7d specific compatible

2025-01-07 Thread Fabio Estevam
Hi Alexander, On Tue, Jan 7, 2025 at 6:50 AM Alexander Stein wrote: > > This add a imx7(d) specific compatible which is compatible to imx8mm. > This silences the dtbs_check warning: > arch/arm/boot/dts/nxp/imx/imx7s-mba7.dtb: dsi@3076: compatible: 'oneOf' > conditional failed, one must be fi

Re: [PATCH 1/2] ARM: dts: imx7s: Move csi-mux to below root

2025-01-07 Thread Fabio Estevam
4: 'csi-mux' does > not match any of the regexes: 'pinctrl-[0-9]+' > from schema $id: > http://devicetree.org/schemas/soc/imx/fsl,imx-iomuxc-gpr.yaml# > > Signed-off-by: Alexander Stein Reviewed-by: Fabio Estevam

Re: [PATCH v4 1/3] dt-bindings: lcdif: Document a imx6sx-lcdif fallback

2024-12-17 Thread Fabio Estevam
Rob, On Mon, Nov 4, 2024 at 12:42 PM Rob Herring (Arm) wrote: > > > On Fri, 01 Nov 2024 10:54:04 -0300, Fabio Estevam wrote: > > From: Fabio Estevam > > > > imx6sx.dtsi has the following lcdif entries: > > > > compatible = "fsl,imx6sx-lcdif", &qu

[PATCH] dt-bindings: samsung,mipi-dsim: Document fsl,imx7d-mipi-dsim

2024-12-17 Thread Fabio Estevam
From: Fabio Estevam The i.MX7D MIPI DSIM block is compatible with i.MX8MM. imx7s.dtsi uses the following compatible string: compatible = "fsl,imx7d-mipi-dsim", "fsl,imx8mm-mipi-dsim"; Document "fsl,imx7d-mipi-dsim" to fix the following dt-schema warning: [

Re: [PATCH v2 1/2] dt-bindings: display: panel-lvds: Add compatible for AUO G084SN05 V9

2024-12-11 Thread Fabio Estevam
Hi Neil, On Wed, Dec 11, 2024 at 6:31 AM Krzysztof Kozlowski wrote: > > On Tue, Dec 10, 2024 at 07:57:04AM -0300, Fabio Estevam wrote: > > From: Fabio Estevam > > > > The AUO G084SN05 V9 is an 8.4" 800x600 LVDS display. > > > > Add a compatible entry fo

[PATCH v2 1/2] dt-bindings: display: panel-lvds: Add compatible for AUO G084SN05 V9

2024-12-10 Thread Fabio Estevam
From: Fabio Estevam The AUO G084SN05 V9 is an 8.4" 800x600 LVDS display. Add a compatible entry for this LVDS display model. Signed-off-by: Fabio Estevam --- Changes since v1: - Added devicet...@vger.kernel.org on Cc. Documentation/devicetree/bindings/display/panel/panel-lvds.yaml | 2

[PATCH v2 2/2] arm64: dts: imx8mm-phg: Add LVDS compatible string

2024-12-10 Thread Fabio Estevam
From: Fabio Estevam The imx8mm-phg board has an AUO G084SN05 V9 8.4" 800x600 LVDS panel. Improve the devicetree description by passing the LVDS compatible string to fix the following dt-schema warning: imx8mm-phg.dtb: panel: compatible:0: 'panel-lvds' is not one of ['ad

[PATCH 2/2] arm64: dts: imx8mm-phg: Add LVDS compatible string

2024-12-09 Thread Fabio Estevam
From: Fabio Estevam The imx8mm-phg board has an AUO G084SN05 V9 8.4" 800x600 LVDS panel. Improve the devicetree description by passing the LVDS compatible string to fix the following dt-schema warning: imx8mm-phg.dtb: panel: compatible:0: 'panel-lvds' is not one of ['ad

[PATCH] dt-bindings: display: panel-lvds: Add compatible for AUO G084SN05 V9

2024-12-09 Thread Fabio Estevam
From: Fabio Estevam The AUO G084SN05 V9 is a 8.4" 800x600 LVDS display. Add a compatible entry for this LVDS display model. Signed-off-by: Fabio Estevam --- Documentation/devicetree/bindings/display/panel/panel-lvds.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Document

[PATCH v4 1/3] dt-bindings: lcdif: Document a imx6sx-lcdif fallback

2024-11-01 Thread Fabio Estevam
From: Fabio Estevam imx6sx.dtsi has the following lcdif entries: compatible = "fsl,imx6sx-lcdif", "fsl,imx28-lcdif"; This causes the following dt-schema warning: ['fsl,imx6sx-lcdif', 'fsl,imx28-lcdif'] is too long To keep DT compatibility, document &#x

[PATCH v4 2/3] dt-bindings: lcdif: Expand the imx6sl/imx6sll fallbacks

2024-11-01 Thread Fabio Estevam
From: Fabio Estevam mx6sl.dtsi and imx6sll.dtsi have the following lcdif entries: compatible = "fsl,imx6sl-lcdif", "fsl,imx28-lcdif"; This causes dt-schema warnings as the current binding only allow 'fsl,imx6sx-lcdif' as fallback. ['fsl,imx6sl-lcdif

[PATCH v4 3/3] ARM: dts: imx6sl: Provide a more specific lcdif compatible

2024-11-01 Thread Fabio Estevam
From: Fabio Estevam The LCDIF IP on i.MX6SL and i.MX6SLL is compatible with i.MX6SX. Provide a more specific "fsl,imx6sx-lcdif" compatible and still keep "fsl,imx28-lcdif" for DT compatibility. Signed-off-by: Fabio Estevam --- Changes since v3: - None. arch/arm/boot/dts

Re: [PATCH v3 2/3] dt-bindings: lcdif: Expand the imx6sl/imx6sll fallbacks

2024-10-29 Thread Fabio Estevam
Hi Marek, On Tue, Oct 29, 2024 at 5:16 PM Marek Vasut wrote: > So you wouldn't have to write three compatible strings for the 6sl/sll , > but only two ? I.e. this: > > compatible = "fsl,imx6sl-lcdif", "fsl,imx28-lcdif"; > compatible = "fsl,imx6sll-lcdif", "fsl,imx28-lcdif"; i.MX6SL and i.MX6SLL

[PATCH v3 1/3] dt-bindings: lcdif: Document a imx6sx-lcdif fallback

2024-10-29 Thread Fabio Estevam
From: Fabio Estevam imx6sx.dtsi has the following lcdif entries: compatible = "fsl,imx6sx-lcdif", "fsl,imx28-lcdif"; This causes the following dt-schema warning: ['fsl,imx6sx-lcdif', 'fsl,imx28-lcdif'] is too long To keep DT compatibility, document &#x

[PATCH v3 3/3] ARM: dts: imx6sl: Provide a more specific lcdif compatible

2024-10-29 Thread Fabio Estevam
From: Fabio Estevam The LCDIF IP on i.MX6SL and i.MX6SLL is compatible with i.MX6SX. Provide a more specific "fsl,imx6sx-lcdif" compatible and still keep "fsl,imx28-lcdif" for DT compatibility. Signed-off-by: Fabio Estevam --- Changes since v2: - None. arch/arm/boot/dts

[PATCH v3 2/3] dt-bindings: lcdif: Expand the imx6sl/imx6sll fallbacks

2024-10-29 Thread Fabio Estevam
From: Fabio Estevam mx6sl.dtsi and imx6sll.dtsi have the following lcdif entries: compatible = "fsl,imx6sl-lcdif", "fsl,imx28-lcdif"; This causes dt-schema warnings as the current binding only allow 'fsl,imx6sx-lcdif' as fallback. ['fsl,imx6sl-lcdif

[PATCH v2 2/3] dt-bindings: lcdif: Expand the imx6sl/imx6sll fallbacks

2024-10-29 Thread Fabio Estevam
From: Fabio Estevam imx6sl.dtsi and imx6sll.dtsi have the following lcdif entries: compatible = "fsl,imx6sl-lcdif", "fsl,imx28-lcdif"; This causes dt-schema warnings as the current binding only allow 'fsl,imx6sx-lcdif' as fallback. ['fsl,imx6sl-lcdif

[PATCH v2 3/3] ARM: dts: imx6sl: Provide a more specific lcdif compatible

2024-10-29 Thread Fabio Estevam
From: Fabio Estevam The LCDIF IP on i.MX6SL and i.MX6SLL is compatible with i.MX6SX. Provide a more specific "fsl,imx6sx-lcdif" compatible and still keep "fsl,imx28-lcdif" for DT compatibility. Signed-off-by: Fabio Estevam --- Changes since v1: - Add 3 entries for keep

[PATCH v2 1/3] dt-bindings: lcdif: Document a imx6sx-lcdif fallback

2024-10-29 Thread Fabio Estevam
From: Fabio Estevam imx6sx.dtsi has the following lcdif entries: compatible = "fsl,imx6sx-lcdif", "fsl,imx28-lcdif"; This causes the following dt-schema warning: ['fsl,imx6sx-lcdif', 'fsl,imx28-lcdif'] is too long To keep DT compatibility, document &#x

[PATCH] staging: fbtft: Changed calls to udelays() functions for usleep_range()

2024-09-22 Thread Fabio
Replaced two lines of calling udelays by usleep_range() functions, adding more efficiency due to the need of long-lasting delays of more than 10us. Signed-off-by: Fabio Bareiro --- drivers/staging/fbtft/fb_ra8875.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH v2] dt-bindings: lcdif: Document the dmas/dma-names properties

2024-09-04 Thread Fabio Estevam
From: Fabio Estevam i.MX28 has an RX DMA channel associated with the LCDIF controller. Document the 'dmas' and 'dma-names' properties to fix the following dt-schema warnings: lcdif@8003: 'dma-names', 'dmas' do not match any of the regexes: '

Re: [PATCH] dt-bindings: lcdif: Document the dmas/dma-names properties

2024-09-03 Thread Fabio Estevam
Hi Marek, On Tue, Sep 3, 2024 at 1:51 PM Marek Vasut wrote: > This also applies to MX23 , that one also has the support for > command-mode LCDs which are then driven by pumping commands via DMA. I > don't think Linux actually supports this mode of operation, but I do > recall using it some long

[PATCH] dt-bindings: lcdif: Document the dmas/dma-names properties

2024-09-03 Thread Fabio Estevam
From: Fabio Estevam i.MX28 has an RX DMA channel associated with the LCDIF controller. Document the 'dmas' and 'dma-names' properties to fix the following dt-schema warnings: lcdif@8003: 'dma-names', 'dmas' do not match any of the regexes: '

Re: [PATCH 1/6] drm/bridge: imx8mp-hdmi-tx: Switch to SYSTEM_SLEEP_PM_OPS()

2024-08-28 Thread Fabio Estevam
A gentle ping on this series. Thanks On Wed, Jun 26, 2024 at 8:07 PM Fabio Estevam wrote: > > From: Fabio Estevam > > Replace SET_SYSTEM_SLEEP_PM_OPS with its modern SYSTEM_SLEEP_PM_OPS() > alternative. > > The combined usage of pm_ptr() and SYSTEM_SLEEP_PM_OPS() >

[PATCH 6/6] drm/bridge: imx8qxp-ldb: Switch to RUNTIME_PM_OPS()

2024-06-26 Thread Fabio Estevam
From: Fabio Estevam Replace SET_RUNTIME_PM_OPS with its modern RUNTIME_PM_OPS() alternative. The combined usage of pm_ptr() and RUNTIME_PM_OPS() allows the compiler to evaluate if the runtime suspend/resume() functions are used at build time or are simply dead code. This allows removing the

[PATCH 5/6] drm/bridge: dw-hdmi-cec: Switch to SYSTEM_SLEEP_PM_OPS()

2024-06-26 Thread Fabio Estevam
From: Fabio Estevam Replace SET_SYSTEM_SLEEP_PM_OPS with its modern SYSTEM_SLEEP_PM_OPS() alternative. The combined usage of pm_ptr() and SYSTEM_SLEEP_PM_OPS() allows the compiler to evaluate if the runtime suspend/resume() functions are used at build time or are simply dead code. This allows

[PATCH 4/6] drm/bridge: samsung-dsim: Switch to RUNTIME_PM_OPS()

2024-06-26 Thread Fabio Estevam
From: Fabio Estevam Replace SET_RUNTIME_PM_OPS with its modern RUNTIME_PM_OPS() alternative. The combined usage of pm_ptr() and RUNTIME_PM_OPS() allows the compiler to evaluate if the runtime suspend/resume() functions are used at build time or are simply dead code. This allows removing the

[PATCH 3/6] drm/bridge: imx8qxp-pixel-combiner: Switch to RUNTIME_PM_OPS()

2024-06-26 Thread Fabio Estevam
From: Fabio Estevam Replace SET_RUNTIME_PM_OPS with its modern RUNTIME_PM_OPS() alternative. The combined usage of pm_ptr() and RUNTIME_PM_OPS() allows the compiler to evaluate if the runtime suspend/resume() functions are used at build time or are simply dead code. This allows removing the

[PATCH 2/6] drm/bridge: imx8qm-ldb: Switch to RUNTIME_PM_OPS()

2024-06-26 Thread Fabio Estevam
From: Fabio Estevam Replace SET_RUNTIME_PM_OPS with its modern RUNTIME_PM_OPS() alternative. The combined usage of pm_ptr() and RUNTIME_PM_OPS() allows the compiler to evaluate if the runtime suspend/resume() functions are used at build time or are simply dead code. This allows removing the

[PATCH 1/6] drm/bridge: imx8mp-hdmi-tx: Switch to SYSTEM_SLEEP_PM_OPS()

2024-06-26 Thread Fabio Estevam
From: Fabio Estevam Replace SET_SYSTEM_SLEEP_PM_OPS with its modern SYSTEM_SLEEP_PM_OPS() alternative. The combined usage of pm_ptr() and SYSTEM_SLEEP_PM_OPS() allows the compiler to evaluate if the runtime suspend/resume() functions are used at build time or are simply dead code. This allows

Re: [PATCH] drm/bridge: imx8mp-hdmi-pvi: Fix build warnings

2024-02-07 Thread Fabio Estevam
Hi Adam, On Tue, Feb 6, 2024 at 9:23 PM Adam Ford wrote: > > Two separate build warnings were reported. One from an > uninitialized variable, and the other from returning 0 > instead of NULL from a pointer. > > Fixes: 059c53e877ca ("drm/bridge: imx: add driver for HDMI TX Parallel Video > Inter

Re: [PATCH V5 1/2] dt-bindings: display: imx: add binding for i.MX8MP HDMI PVI

2024-01-05 Thread Fabio Estevam
Hi Adam, Thanks for moving this forward. On Fri, Jan 5, 2024 at 10:56 PM Adam Ford wrote: > > From: Lucas Stach > > Add binding for the i.MX8MP HDMI parallel video interface block. > > Signed-off-by: Lucas Stach > Reviewed-by: Laurent Pinchart > Reviewed-by: Conor Dooley You missed your own

Re: [PATCH 2/6] drm/panel: Add driver for BOE TH101MB31IG002-28A panel

2023-12-22 Thread Fabio Estevam
On Fri, Dec 22, 2023 at 2:32 PM Manuel Traut wrote: > > From: Segfault > > The BOE TH101MB31IG002-28A panel is a WXGA panel. > It is used in Pine64 Pinetab2 and PinetabV. > > Signed-off-by: Segfault Please use a real name instead... > +MODULE_AUTHOR("Alexander Warnecke "); like here.

Re: [PATCH v3 2/2] drm/bridge: imx: add driver for HDMI TX Parallel Video Interface

2023-12-15 Thread Fabio Estevam
On Fri, Dec 15, 2023 at 4:01 PM Adam Ford wrote: > Thanks for the list. I was able to successfully build the stable 6.6 > branch with those patches applied and I have the HDMI working. > Unfortunately, I get build errors on the linux-next, so it's going to > take me a little time to sort through

Re: [PATCH v3 2/2] drm/bridge: imx: add driver for HDMI TX Parallel Video Interface

2023-12-15 Thread Fabio Estevam
Hi Adam, On Fri, Dec 15, 2023 at 1:40 PM Adam Ford wrote: > I started looking into this today, but there appears to be some > dependencies missing because the PVI is just one small portion of > this. The PVI needs to interact with the hdmi_blk_ctrl and the hdmi > transmitter itself. > > It looks

Re: [PATCH v3 2/2] drm/bridge: imx: add driver for HDMI TX Parallel Video Interface

2023-12-15 Thread Fabio Estevam
Hi Adam, On Sun, Dec 10, 2023 at 2:35 PM Adam Ford wrote: > Lucas, > > It's been a few months since there has been any action. If you want, > I can help apply the suggestions that Laurent has and re-submit with > both of our names if you want. It would be nice to get this > integrated. It wou

Re: [PATCH 1/3] drm/mxsfb: Add an entry for "fsl,imx8mq-lcdif"

2023-12-12 Thread Fabio Estevam
Hi Lucas, On Tue, Dec 12, 2023 at 3:19 PM Lucas Stach wrote: > I don't really like this series. While we don't make any strong > guarantees in this way, it breaks booting older kernels with a new DT. I thought we needed only to guarantee that old DTs still run with newer kernels, not the other

[PATCH 3/3] arm64: dts: imx8mq: Exclude "fsl,imx6sx-lcdif"

2023-12-11 Thread Fabio Estevam
From: Fabio Estevam On i.MX6SX, the LCDIF has an associated power domain. i.MX8MQ does not have an LCDIF power domain, so pass only "fsl,imx8mq-lcdif" as compatible string to fix the following dt-schema warning: imx8mq-evk.dtb: lcd-controller@3032: 'power-domains' is

[PATCH 2/3] dt-bindings: lcdif: Decouple imx8mq from imx6sx

2023-12-11 Thread Fabio Estevam
From: Fabio Estevam On i.MX6SX, the LCDIF has an associated power domain. i.MX8MQ does not have an LCDIF power domain, so allow passing only "fsl,imx8mq-lcdif" as compatible string to fix the following dt-schema warning: imx8mq-evk.dtb: lcd-controller@3032: 'power-domains

[PATCH 1/3] drm/mxsfb: Add an entry for "fsl,imx8mq-lcdif"

2023-12-11 Thread Fabio Estevam
From: Fabio Estevam On i.MX6SX, the LCDIF has an associated power domain. However, i.MX8MQ does not have an LCDIF power domain. imx8mq.dtsi has the following compatible string: compatible = "fsl,imx8mq-lcdif", "fsl,imx6sx-lcdif"; which causes the following dt-schema warn

Re: Question about device links between supplier and consumer

2023-12-07 Thread Fabio Estevam
Hi Richard, On Thu, Dec 7, 2023 at 10:43 AM Rafael J. Wysocki wrote: > > Otherwise, the mmc driver will be defer probed after the init > > executed, as you can imagine, the init will complain it can not find > > the dev node specified by the 'root=/dev/xxx' in the kernel. command > > line. Have

[PATCH v2] dt-bindings: lcdif: Properly describe the i.MX23 interrupts

2023-12-06 Thread Fabio Estevam
From: Fabio Estevam i.MX23 has two LCDIF interrupts instead of a single one like other i.MX devices. Take this into account for properly describing the i.MX23 LCDIF interrupts. This fixes the following dt-schema warning: imx23-olinuxino.dtb: lcdif@8003: interrupts: [[46], [45]] is too

[PATCH v2] dt-bindings: display: adi, adv75xx: Document #sound-dai-cells

2023-12-06 Thread Fabio Estevam
From: Fabio Estevam When using audio from ADV7533 or ADV7535 and describing the audio card via simple-audio-card, the '#sound-dai-cells' needs to be passed. Document the '#sound-dai-cells' property to fix the following dt-schema warning: imx8mn-beacon-kit.dtb: hdmi@3d: &#x

[PATCH] dt-bindings: display: adi,adv75xx: Document #sound-dai-cells

2023-12-05 Thread Fabio Estevam
From: Fabio Estevam When using audio from ADV7533 or ADV7535 and describing the audio card via simple-audio-card, the '#sound-dai-cells' needs to be passed. Document the '#sound-dai-cells' property to fix the following dt-schema warning: imx8mn-beacon-kit.dtb: hdmi@3d: &#x

[PATCH v2] dt-bindings: lcdif: Properly describe the i.MX23 interrupts

2023-12-05 Thread Fabio Estevam
From: Fabio Estevam i.MX23 has two LCDIF interrupts instead of a single one like other i.MX devices. Take this into account for properly describing the i.MX23 LCDIF interrupts. This fixes the following dt-schema warning: imx23-olinuxino.dtb: lcdif@8003: interrupts: [[46], [45]] is too

[PATCH] dt-bindings: lcdif: Properly describe the i.MX23 interrupts

2023-12-05 Thread Fabio Estevam
From: Fabio Estevam i.MX23 has two i.MX23 interrupts instead of a single one like other i.MX devices. Take this into account for properly describing the i.MX23 LCDIF interrupts. This fixes the following dt-schema warning: imx23-olinuxino.dtb: lcdif@8003: interrupts: [[46], [45]] is too

Re: [PATCH v4 2/2] drm/bridge: imx: add driver for HDMI TX Parallel Video Interface

2023-11-23 Thread Fabio Estevam
) > Tested-by: Frieder Schrempf (v2) > Reviewed-by: Laurent Pinchart (v3) Tested-by: Fabio Estevam Could someone apply this series, please?

Re: [PATCH] drm/rockchip: lvds: do not print error message when deferring probe

2023-11-17 Thread Fabio Estevam
Hi Quentin, On Fri, Nov 17, 2023 at 3:31 PM Quentin Schulz wrote: > > From: Quentin Schulz > > This scary message may happen if the panel or bridge is not probed > before the LVDS controller is, resulting in some head scratching because > the LVDS panel is actually working, since a later try wil

Re: [PATCH] drm: bridge: adv7511: fix reading edid segments

2023-10-26 Thread Fabio Estevam
Hi Emil, On Thu, Oct 26, 2023 at 11:47 AM Emil Abildgaard Svendsen wrote: > > Currently reading EDID only works because usually only two EDID blocks > of 128 bytes is used. Where an EDID segment holds 256 bytes or two EDID > blocks. And the first EDID segment read works fine but E-EDID specifies

[PATCH] dt-bindings: display: fsl, imx6-hdmi: Change to 'unevaluatedProperties: false'

2023-09-30 Thread Fabio Estevam
From: Fabio Estevam fsl,imx6-hdmi.yaml makes a reference to synopsys,dw-hdmi.yaml. The 'interrupts'and 'reg' properties are described in synopsys,dw-hdmi.yaml, so use 'unevaluatedProperties: false' so that these two properties can be accepted. This fixes the fo

Re: [PATCH] drm/imx: Add error handling in dw_hdmi_imx_probe()

2023-09-24 Thread Fabio Estevam
On Sun, Sep 24, 2023 at 11:36 AM liuhaoran wrote: > > This patch adds error-handling for the of_match_node() > inside the dw_hdmi_imx_probe(). > > Signed-off-by: liuhaoran > --- > drivers/gpu/drm/imx/ipuv3/dw_hdmi-imx.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/

Re: [PATCH 4/5] drm/bridge: samsung-dsim: adjust porches by rounding up

2023-08-28 Thread Fabio Estevam
Hi Michael, On Mon, Aug 28, 2023 at 12:59 PM Michael Tretter wrote: > > The porches must be rounded up to make the samsung-dsim work. The commit log could be improved here. The way it is written gives the impression that samsung-dsim does not work currently.

Re: [PATCH 0/7] ADV7511 driver enhancements

2023-08-18 Thread Fabio Estevam
tested with[1] on RZ/G2L SMARC EVK which embeds > ADV7535. I have successfully tested this series on a imx8mm-evk, which has an ADV7535: Tested-by: Fabio Estevam

Re: [PATCH v2] drm: bridge: samsung-dsim: Fix init during host transfer

2023-08-17 Thread Fabio Estevam
Hi Tim, On Thu, Aug 17, 2023 at 5:53 PM Tim Harvey wrote: > Frieder, > > Sorry for the delay. Yes this resolves the regression I ran into. I > tested it on top of v6.5-rc6 on a gw72xx-0x with a DFROBOT DRF0678 7in > 800x480 (Raspberry Pi) display which has the Toshiba TC358762 > compatible DSI t

Re: [PATCH v3] drm/msm/a2xx: Call adreno_gpu_init() earlier

2023-08-11 Thread Fabio Estevam
Hi Rob, Any comments, please? On Mon, Jul 24, 2023 at 5:28 PM Fabio Estevam wrote: > > Hi Rob, > > A gentle ping. > > On Thu, Jun 22, 2023 at 3:37 PM Dmitry Baryshkov > wrote: > > > > On 21/06/2023 02:23, Fabio Estevam wrote: > > > From: Fabio Est

Re: [PATCH v3] drm/msm/a2xx: Call adreno_gpu_init() earlier

2023-07-24 Thread Fabio Estevam
Hi Rob, A gentle ping. On Thu, Jun 22, 2023 at 3:37 PM Dmitry Baryshkov wrote: > > On 21/06/2023 02:23, Fabio Estevam wrote: > > From: Fabio Estevam > > > > The adreno_is_a20x() and adreno_is_a225() functions rely on the > > GPU revision, but such i

Re: [PATCH v2] drm: bridge: samsung-dsim: Fix waiting for empty cmd transfer FIFO on older Exynos

2023-07-21 Thread Fabio Estevam
On Fri, Jul 21, 2023 at 8:28 AM Marek Szyprowski wrote: > > Samsung DSIM used in older Exynos SoCs (like Exynos 4210, 4x12, 3250) > doesn't report empty level of packer header FIFO. In case of those SoCs, > use the old way of waiting for empty command tranfsfer FIFO, removed > recently by commit 1

Re: [PATCH] drm: adv7511: Fix low refresh rate register for ADV7533/5

2023-07-13 Thread Fabio Estevam
On Wed, May 17, 2023 at 4:08 AM Alexandru Ardelean wrote: > > From: Bogdan Togorean > > For ADV7533 and ADV7535 low refresh rate is selected using > bits [3:2] of 0x4a main register. > So depending on ADV model write 0xfb or 0x4a register. > > Signed-off-by: Bogdan Togorean > Signed-off-by: Alex

Re: [PATCH v2] drm/i915: Replace kmap() with kmap_local_page()

2023-06-23 Thread Fabio M. De Francesco
gt; --- > > Changes in v2: > - Replace kmap() with kmap_local_page(). > - Change commit subject and message. With the changes that Ira suggested and the minor fix I'm proposing to the commit message, it looks good to me too, so this patch is... Reviewed-by: Fabio M. De Francesco

Re: [PATCH v2] drm/i915: Replace kmap() with kmap_local_page()

2023-06-21 Thread Fabio M. De Francesco
led interrupts. I don't know the code, however, everything cited above could be the subject of a subsequent patch. Regards, Fabio > I figured, while page compression is probably to be considered "slow" > it's probably not slow enough to motivate kmap() instead of > kmap_loca

[PATCH v3] drm/msm/a2xx: Call adreno_gpu_init() earlier

2023-06-20 Thread Fabio Estevam
From: Fabio Estevam The adreno_is_a20x() and adreno_is_a225() functions rely on the GPU revision, but such information is retrieved inside adreno_gpu_init(), which is called afterwards. Fix this problem by caling adreno_gpu_init() earlier, so that the GPU information revision is available when

Re: [PATCH] drm/gma500: Replace kmap{,_atomic}() with page_address()

2023-06-20 Thread Fabio M. De Francesco
the sections don't depend on the mentioned side effects, you should write something like what I wrote in "[PATCH] NFS: Convert kmap_atomic() to kmap_local_folio()" that you can find at https://lore.kernel.org/lkml/ 20230503172411.3356-1-fmdefrance...@gmail.com/ or, by by us

Re: [PATCH 1/3] drm/msm/a3xx: Pass the revision information

2023-06-20 Thread Fabio Estevam
On 20/06/2023 14:40, Dmitry Baryshkov wrote: This looks like a boilerplate being added to all aYxx drivers (and then these fields are also set in adreno_gpu_init()). Can we remove duplication somehow? Sorry, I missed this comment prior to sending v2. Maybe a simpler fix for a2xx_gpu would be:

[PATCH v2 4/4] drm/msm/a5xx: Pass the revision information

2023-06-20 Thread Fabio Estevam
From: Fabio Estevam Commit cc943f43ece7 ("drm/msm/adreno: warn if chip revn is verified before being set") exposes the need of setting the GPU revision fields prior to using the adreno_is_xxx() functions. Pass the GPU revision information to avoid run-time warning. Signed-off-by: Fab

[PATCH v2 2/4] drm/msm/a3xx: Pass the revision information

2023-06-20 Thread Fabio Estevam
From: Fabio Estevam Commit cc943f43ece7 ("drm/msm/adreno: warn if chip revn is verified before being set") exposes the need of setting the GPU revision fields prior to using the adreno_is_xxx() functions. Pass the GPU revision information to avoid run-time warning. Signed-off-by: Fab

[PATCH v2 3/4] drm/msm/a4xx: Pass the revision information

2023-06-20 Thread Fabio Estevam
From: Fabio Estevam Commit cc943f43ece7 ("drm/msm/adreno: warn if chip revn is verified before being set") exposes the need of setting the GPU revision fields prior to using the adreno_is_xxx() functions. Pass the GPU revision information to avoid run-time warning. Signed-off-by: Fab

[PATCH v2 1/4] drm/msm/a2xx: Pass the revision information

2023-06-20 Thread Fabio Estevam
From: Fabio Estevam Commit cc943f43ece7 ("drm/msm/adreno: warn if chip revn is verified before being set") exposes the need of setting the GPU revision fields prior to using the adreno_is_xxx() functions: [ cut here ] WARNING: CPU: 0 PID: 1 at drivers/gpu/drm/

[PATCH 3/3] drm/msm/a5xx: Pass the revision information

2023-06-20 Thread Fabio Estevam
From: Fabio Estevam Commit cc943f43ece7 ("drm/msm/adreno: warn if chip revn is verified before being set") exposes the need of setting the GPU revision fields prior to using the adreno_is_xxx() functions. Pass the GPU revision information to avoid run-time warning. Signed-off-by: Fab

[PATCH 2/3] drm/msm/43xx: Pass the revision information

2023-06-20 Thread Fabio Estevam
From: Fabio Estevam Commit cc943f43ece7 ("drm/msm/adreno: warn if chip revn is verified before being set") exposes the need of setting the GPU revision fields prior to using the adreno_is_xxx() functions. Pass the GPU revision information to avoid run-time warning. Signed-off-by: Fab

[PATCH 1/3] drm/msm/a3xx: Pass the revision information

2023-06-20 Thread Fabio Estevam
From: Fabio Estevam Commit cc943f43ece7 ("drm/msm/adreno: warn if chip revn is verified before being set") exposes the need of setting the GPU revision fields prior to using the adreno_is_xxx() functions. Pass the GPU revision information to avoid run-time warning. Signed-off-by: Fab

[PATCH] drm/msm/a2xx: Pass the revision information

2023-06-20 Thread Fabio Estevam
From: Fabio Estevam Since commit cc943f43ece7 ("drm/msm/adreno: warn if chip revn is verified before being set") the following run-time warning is observed: [ cut here ] WARNING: CPU: 0 PID: 1 at drivers/gpu/drm/msm/adreno/adreno_gpu.h:171 a2xx_gpu_init+0

[PATCH v2] drm/panel: simple: Add connector_type for innolux_at043tn24

2023-06-20 Thread Fabio Estevam
From: Fabio Estevam The innolux at043tn24 display is a parallel LCD. Pass the 'connector_type' information to avoid the following warning: panel-simple panel: Specify missing connector_type Signed-off-by: Fabio Estevam Fixes: 41bcceb4de9c ("drm/panel: simple: Add support for In

[PATCH] drm/panel: simple: Add connector_type for innolux_at043tn24

2023-06-19 Thread Fabio Estevam
From: Fabio Estevam The innolux at043tn24 display is a parallel LCD. Pass the 'connector_type' information to avoid the following warning: panel-simple panel: Specify missing connector_type Signed-off-by: Fabio Estevam --- drivers/gpu/drm/panel/panel-simple.c | 1 + 1 file

[PATCH v2] dt-bindings: samsung,mipi-dsim: Use port-base reference

2023-05-31 Thread Fabio Estevam
From: Fabio Estevam Use port-base reference for port@1. This fixes the following schema warning: imx8mp-dhcom-pdk3.dtb: dsi@32e6: ports:port@1:endpoint: Unevaluated properties are not allowed ('data-lanes' was unexpected) >From schema: >Documentation/devicetree/binding

Re: [PATCH] dt-bindings: samsung,mipi-dsim: Use port-base reference

2023-05-31 Thread Fabio Estevam
On 31/05/2023 15:56, Krzysztof Kozlowski wrote: This would have sense if you kept original intention, so additionalProperties: false Without it - you just break bindings to hide warning. I am not sure I understood your suggestion. Is this what you mean? diff --git a/Documentation/devicetre

[PATCH] dt-bindings: samsung,mipi-dsim: Use port-base reference

2023-05-30 Thread Fabio Estevam
From: Fabio Estevam Use port-base reference for port@0 and port@1. This fixes the following schema warning: imx8mm-evk.dtb: dsi@32e1: ports:port@1:endpoint: Unevaluated properties are not allowed ('data-lanes' was unexpected) >From schema: >Documentation/devicetree/

Re: [PATCH V2] dt-bindings: bridge: samsung-dsim: Make some flags optional

2023-05-28 Thread Fabio Estevam
they are equal, this flag is not needed since the driver > will use the sclk_mipi rate as a fallback. > > Signed-off-by: Adam Ford > Reviewed-by: Conor Dooley > --- > V2: Split from driver series. Re-word updates for burst > and pll-clock frequency. Reviewed-by: Fabio Estevam

Re: [PATCH V7 0/6] drm: bridge: samsung-dsim: Support variable clocking

2023-05-24 Thread Fabio Estevam
Hi Adam, On Tue, May 23, 2023 at 8:49 PM Adam Ford wrote: > Inki, > > I haven't heard back from you on whether or not you want the bindings > patch to be included with me resending the series as V7 or if you're > OK with a single, stand-alone patch. > Will you let me know? I have the patch stan

Re: [PATCH v4 1/2] dt-bindings: samsung, mipi-dsim: Add 'lane-polarities'

2023-05-22 Thread Fabio Estevam
Hi Neil, On Sun, May 14, 2023 at 9:29 AM Krzysztof Kozlowski wrote: > > On 14/05/2023 13:46, Fabio Estevam wrote: > > From: Fabio Estevam > > > > The Samsung DSIM IP block allows the inversion of the clock and > > data lanes. > > > > Add an optio

Re: [PATCH V7 0/6] drm: bridge: samsung-dsim: Support variable clocking

2023-05-18 Thread Fabio Estevam
Hi Adam, On Thu, May 18, 2023 at 8:06 PM Adam Ford wrote: > > This series fixes the blanking pack size and the PMS calculation. It then > adds support to allows the DSIM to dynamically DPHY clocks, and support > non-burst mode while allowing the removal of the hard-coded clock values > for the P

Re: [PATCH v2 2/2] drm/bridge: ti-sn65dsi83: Fix enable/disable flow to meet spec

2023-05-16 Thread Fabio Estevam
On Thu, May 4, 2023 at 6:12 AM Alexander Stein wrote: > > Am Mittwoch, 3. Mai 2023, 18:33:07 CEST schrieb Frieder Schrempf: > > From: Frieder Schrempf > > > > The datasheet describes the following initialization flow including > > minimum delay times between each step: > > > > 1. DSI data lanes n

[PATCH v4 2/2] drm: bridge: samsung-dsim: Implement support for clock/data polarity swap

2023-05-14 Thread Fabio Estevam
les, add a check which verifies all data lanes have the same polarity. This has been validated on an imx8mm board that actually has the MIPI DSI clock lanes inverted. Signed-off-by: Marek Vasut Signed-off-by: Fabio Estevam Reviewed-by: Jagan Teki --- Changes since v3: - None drivers/gpu/drm/brid

[PATCH v4 1/2] dt-bindings: samsung,mipi-dsim: Add 'lane-polarities'

2023-05-14 Thread Fabio Estevam
From: Fabio Estevam The Samsung DSIM IP block allows the inversion of the clock and data lanes. Add an optional property called 'lane-polarities' that describes the polarities of the MIPI DSI clock and data lanes. This property is useful for properly describing the hardware when

[PATCH v3 2/2] drm: bridge: samsung-dsim: Implement support for clock/data polarity swap

2023-05-09 Thread Fabio Estevam
les, add a check which verifies all data lanes have the same polarity. This has been validated on an imx8mm board that actually has the MIPI DSI clock lanes inverted. Signed-off-by: Marek Vasut Signed-off-by: Fabio Estevam Reviewed-by: Jagan Teki --- Changes since v2: - None drivers/gpu/drm/brid

[PATCH v3 1/2] dt-bindings: samsung,mipi-dsim: Add 'lane-polarities'

2023-05-09 Thread Fabio Estevam
From: Fabio Estevam The Samsung DSIM IP block allows the inversion of the clock and data lanes. Add an optional property called 'lane-polarities' that describes the polarities of the MIPI DSI clock and data lanes. This property is useful for properly describing the hardware when

[PATCH v2 2/3] drm/i915/gt: Replace kmap() with kmap_local_page()

2023-04-17 Thread Fabio M. De Francesco
break the above-mentioned constraint, so it should be preferred to kmap(). Therefore, replace kmap() with kmap_local_page() in i915/gt. Suggested-by: Ira Weiny Signed-off-by: Fabio M. De Francesco --- drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c | 4 ++-- drivers/gpu/drm/i915/gt/shmem_ut

[PATCH v2 3/3] drm/i915/gem: Replace kmap() with kmap_local_page()

2023-04-17 Thread Fabio M. De Francesco
k the above-mentioned constraint, so it should be preferred to kmap(). Therefore, replace kmap() with kmap_local_page() in i915/gem and use memcpy_to_page() where it is possible to avoid the open coding of mapping + memcpy() + un-mapping. Suggested-by: Ira Weiny Signed-off-by: Fabio M. De Fran

[PATCH v2 1/3] drm/i915: Replace kmap() with kmap_local_page()

2023-04-17 Thread Fabio M. De Francesco
break the above-mentioned constraint, so it should be preferred to kmap(). Therefore, replace kmap() with kmap_local_page() in i915_gem.c Suggested-by: Ira Weiny Signed-off-by: Fabio M. De Francesco --- drivers/gpu/drm/i915/i915_gem.c | 8 1 file changed, 4 insertions(+), 4 deletions(-)

[PATCH v2 0/3] drm/i915: Replace kmap() with kmap_local_page()

2023-04-17 Thread Fabio M. De Francesco
: Fabio M. De Francesco v1->v2: Do some changes in the text of the cover letter and in the commit messages. There are no changes in the code of any of the three patches. Fabio M. De Francesco (3): drm/i915: Replace kmap() with kmap_local_page() drm/i915/gt: Replace kmap() with kmap_local_p

Re: [PATCH v2 1/2] dt-bindings: samsung,mipi-dsim: Add 'lane-polarities'

2023-04-12 Thread Fabio Estevam
anes): lane-polarities = <1 0 0 0 0>; If the board has no inversion on the clock lane, and has the data lanes inverted: lane-polarities = <0 1 1 1 1>; Should I keep the data-lanes and lane-polarities description as in this patch? Please advise. Thanks, Fabio Estevam

[PATCH] dt-bindings: drm/bridge: ti-sn65dsi86: Fix the video-interfaces.yaml references

2023-04-12 Thread Fabio Estevam
From: Fabio Estevam video-interface.txt does not exist anymore, as it has been converted to video-interfaces.yaml. Instead of referencing video-interfaces.yaml multiple times, pass it as a $ref to the schema. Signed-off-by: Fabio Estevam --- Changes since v1: - Pass video-interfaces.yaml as

[PATCH] dt-bindings: drm/bridge: ti-sn65dsi86: Fix the video-interfaces.yaml references

2023-04-08 Thread Fabio Estevam
From: Fabio Estevam video-interface.txt does not exist anymore, as it has been converted to video-interfaces.yaml. Update the references to the new file name. Signed-off-by: Fabio Estevam --- .../devicetree/bindings/display/bridge/ti,sn65dsi86.yaml | 8 1 file changed, 4 insertions

[PATCH v2 2/2] drm: bridge: samsung-dsim: Implement support for clock/data polarity swap

2023-04-06 Thread Fabio Estevam
les, add a check which verifies all data lanes have the same polarity. This has been validated on an imx8mm board that actually has the MIPI DSI clock lanes inverted. Signed-off-by: Marek Vasut Signed-off-by: Fabio Estevam Reviewed-by: Jagan Teki --- Changes since v1: - Use 'drm: bridge: sa

[PATCH v2 1/2] dt-bindings: samsung,mipi-dsim: Add 'lane-polarities'

2023-04-06 Thread Fabio Estevam
From: Fabio Estevam The Samsung DSIM IP block allows the inversion of the clock and data lanes. Add an optional property called 'lane-polarities' that describes the polarities of the MIPI DSI clock and data lanes. This property is useful for properly describing the hardware when

[PATCH v3] dt-bindings: bridge: Convert Samsung MIPI DSIM bridge to yaml

2023-04-03 Thread Fabio Estevam
From: Jagan Teki Samsung MIPI DSIM bridge can be found on Exynos and NXP's i.MX8M Mini/Nano/Plus SoCs. Convert exynos_dsim.txt to yaml. Used the example node from exynos5433.dtsi instead of the one used in the legacy exynos_dsim.txt. Signed-off-by: Jagan Teki Signed-off-by: Fabio Es

[PATCH v3 2/2] drm/bridge: fsl-ldb: Add i.MX6SX support

2023-04-03 Thread Fabio Estevam
From: Fabio Estevam i.MX6SX has a single LVDS port and share a similar LDB_CTRL register layout with i.MX8MP and i.MX93. There is no LVDS CTRL register on the i.MX6SX, so only write to this register on the appropriate SoCs. Add support for the i.MX6SX LDB. Tested on a imx6sx-sdb board with a

[PATCH v3 1/2] dt-bindings: display: bridge: ldb: Add an i.MX6SX entry

2023-04-03 Thread Fabio Estevam
From: Fabio Estevam i.MX6SX has a single LVDS port and share a similar LDB_CTRL register layout with i.MX8MP and i.MX93. Signed-off-by: Fabio Estevam Reviewed-by: Krzysztof Kozlowski Reviewed-by: Marek Vasut --- Changes since v2: - Collected Reviewed-by tags. - Improved the Subject by not

[PATCH v3] dt-bindings: bridge: Convert Samsung MIPI DSIM bridge to yaml

2023-04-03 Thread Fabio Estevam
From: Jagan Teki Samsung MIPI DSIM bridge can be found on Exynos and NXP's i.MX8M Mini/Nano/Plus SoCs. Convert exynos_dsim.txt to yaml. Used the example node from exynos5433.dtsi instead of the one used in the legacy exynos_dsim.txt. Signed-off-by: Jagan Teki Signed-off-by: Fabio Es

Re: [PATCH v2] dt-bindings: bridge: Convert Samsung MIPI DSIM bridge to yaml

2023-04-03 Thread Fabio Estevam
Hi Krzysztof, On 03/04/2023 09:49, Krzysztof Kozlowski wrote: Signed-off-by: Jagan Teki Signed-off-by: Fabio Estevam --- Changes since v1: - Added samsung,mipi-dsim.yaml entry to MAINTAINERS file (Jagan) - Added Marek Szyprowski entry to the samsung,mipi-dsim.yaml maintainers section (Jagan

  1   2   3   4   5   6   7   >