Re: [PATCH] drm/tidss: Use dev_err_probe() over dev_dbg() when failing to probe the port

2024-02-28 Thread Enric Balletbo i Serra
to have that information there. > > Reviewed-by: Javier Martinez Canillas > Logging in /sys/kernel/debug/devices_deferred was useful for me, so Tested-by: Enric Balletbo i Serra Cheers, Enric > -- > Best regards, > > Javier Martinez Canillas > Core Platforms > Red Hat >

[PATCH v4 7/7] drm/mediatek: mtk_dsi: Reset the dsi0 hardware

2021-09-30 Thread Enric Balletbo i Serra
with all boards. Cc: Jitao Shi Suggested-by: Chun-Kuang Hu Signed-off-by: Enric Balletbo i Serra Acked-by: Chun-Kuang Hu Reviewed-by: Matthias Brugger --- (no changes since v3) Changes in v3: - Fix typo in the commit description drivers/gpu/drm/mediatek/mtk_dsi.c | 5 - 1 file changed

[PATCH v4 3/7] dt-bindings: display: mediatek: add dsi reset optional property

2021-09-30 Thread Enric Balletbo i Serra
Update device tree binding documentation for the dsi to add the optional property to reset the dsi controller. Signed-off-by: Enric Balletbo i Serra Acked-by: Rob Herring --- (no changes since v2) Changes in v2: - Added a new patch to describe the dsi reset optional property. .../devicetree

[PATCH v4 0/7] Add support to the mmsys driver to be a reset controller

2021-09-30 Thread Enric Balletbo i Serra
es in v2: - Fix build test ERROR Reported-by: kernel test robot - Added a new patch to describe the dsi reset optional property. Enric Balletbo i Serra (7): arm64: dts: mediatek: Move reset controller constants into common location dt-bindings: mediatek: Add #reset-cells to mmsys s

Re: [PATCH v10 01/17] dt-bindings: arm: mediatek: mmsys: add power and gce properties

2021-09-08 Thread Enric Balletbo i Serra
Hi Jason, Thank you for your patch. One small comment below. On 8/9/21 8:02, jason-jh.lin wrote: > Power: > 1. Add description for power-domains property. > > GCE: > 1. Add description for mboxes property. > 2. Add description for mediatek,gce-client-reg property. > > Signed-off-by: jason-jh.li

[PATCH v3 3/7] dt-bindings: display: mediatek: add dsi reset optional property

2021-08-25 Thread Enric Balletbo i Serra
Update device tree binding documentation for the dsi to add the optional property to reset the dsi controller. Signed-off-by: Enric Balletbo i Serra Acked-by: Rob Herring --- (no changes since v2) Changes in v2: - Added a new patch to describe the dsi reset optional property. .../devicetree

[PATCH v3 7/7] drm/mediatek: mtk_dsi: Reset the dsi0 hardware

2021-08-25 Thread Enric Balletbo i Serra
with all boards. Cc: Jitao Shi Suggested-by: Chun-Kuang Hu Signed-off-by: Enric Balletbo i Serra Acked-by: Chun-Kuang Hu Reviewed-by: Matthias Brugger --- Changes in v3: - Fix typo in the commit description drivers/gpu/drm/mediatek/mtk_dsi.c | 5 - 1 file changed, 4 insertions(+), 1

[PATCH v3 0/7] Add support to the mmsys driver to be a reset controller

2021-08-25 Thread Enric Balletbo i Serra
robot - Added a new patch to describe the dsi reset optional property. Enric Balletbo i Serra (7): arm64: dts: mediatek: Move reset controller constants into common location dt-bindings: mediatek: Add #reset-cells to mmsys system controller dt-bindings: display: mediatek: add dsi reset opt

Re: [PATCH v5 0/6] Add Mediatek Soc DRM (vdosys0) support for mt8195

2021-07-30 Thread Enric Balletbo i Serra
Hi Jason, Thank you for your patch. On 29/7/21 19:07, jason-jh.lin wrote: > The hardware path of vdosys0 with eDP panel output need to go through > by several modules, such as, OVL, RDMA, COLOR, CCORR, AAL, GAMMA, > DITHER, DSC and MERGE. > You said in other discussions that vdosys0 has eDP pa

Re: [PATCH v5 2/6] soc: mediatek: add mtk-mmsys support for mt8195 vdosys0

2021-07-30 Thread Enric Balletbo i Serra
Hi Jason, Thank you for your patch. On 29/7/21 19:07, jason-jh.lin wrote: > Add mt8195 vdosys0 clock driver name and routing table to > the driver data of mtk-mmsys. > This patch is the one that is really introducing mt8195 mmsys support. It is a bit confusing sent the binding on another patchs

[PATCH v2 7/7] drm/mediatek: mtk_dsi: Reset the dsi0 hardware

2021-07-14 Thread Enric Balletbo i Serra
with all boards. Cc: Jitao Shi Suggested-by: Chun-Kuang Hu Signed-off-by: Enric Balletbo i Serra --- (no changes since v1) drivers/gpu/drm/mediatek/mtk_dsi.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek

[PATCH v2 3/7] dt-bindings: display: mediatek: add dsi reset optional property

2021-07-14 Thread Enric Balletbo i Serra
Update device tree binding documentation for the dsi to add the optional property to reset the dsi controller. Signed-off-by: Enric Balletbo i Serra --- Changes in v2: - Added a new patch to describe the dsi reset optional property. .../devicetree/bindings/display/mediatek/mediatek,dsi.txt

[PATCH v2 0/7] Add support to the mmsys driver to be a reset controller

2021-07-14 Thread Enric Balletbo i Serra
Best regards, Enric [1] https://lore.kernel.org/linux-arm-kernel/20210420132614.150242-4-jitao@mediatek.com/ Changes in v2: - Fix build test ERROR Reported-by: kernel test robot - Added a new patch to describe the dsi reset optional property. Enric Balletbo i Serra (7): arm64

[PATCH 6/6] drm/mediatek: mtk_dsi: Reset the dsi0 hardware

2021-06-30 Thread Enric Balletbo i Serra
with all boards. Cc: Jitao Shi Suggested-by: Chun-Kuang Hu Signed-off-by: Enric Balletbo i Serra --- drivers/gpu/drm/mediatek/mtk_dsi.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c index

[PATCH 0/6] Add support to the mmsys driver to be a reset controller

2021-06-30 Thread Enric Balletbo i Serra
Best regards, Enric [1] https://lore.kernel.org/linux-arm-kernel/20210420132614.150242-4-jitao@mediatek.com/ Enric Balletbo i Serra (6): arm64: dts: mediatek: Move reset controller constants into common location dt-bindings: mediatek: Add #reset-cells to mmsys system controller

Re: [PATCH] drm/bridge: DRM_CROS_EC_ANX7688 should depend on I2C_CROS_EC_TUNNEL

2021-05-27 Thread Enric Balletbo i Serra
o prevent > asking the user about this driver when configuring a kernel without > support for the ChromeOS EC tunnel I2C bus. > > Fixes: 44602b10d7f2a5f7 ("drm/bridge: Add ChromeOS EC ANX7688 bridge driver > support") > Signed-off-by: Geert Uytterhoeven Reviewed-by: Enri

Re: [PATCH v5 1/2] dt-bindings: usb: add analogix,anx7688.yaml

2021-04-06 Thread Enric Balletbo i Serra
Hi Laurent and Dafna, On 31/3/21 22:40, Laurent Pinchart wrote: > On Tue, Mar 30, 2021 at 05:14:44PM +0200, Enric Balletbo i Serra wrote: >> On 30/3/21 15:35, Dafna Hirschfeld wrote: >>> On 05.03.21 16:19, Laurent Pinchart wrote: >>>> On Fri, Mar 05, 2021 at 04:1

Re: [PATCH v5 2/2] drm/bridge: anx7688: Add ANX7688 bridge driver support

2021-03-30 Thread Enric Balletbo i Serra
Hi Dafna, Thank you for your patch and to work on this. On 5/3/21 13:43, Dafna Hirschfeld wrote: > From: Enric Balletbo i Serra > > This driver adds support for the ANX7688 HDMI to DP converter block of the > ANX7688 device. > > For our use case, the only reason the Linu

Re: [PATCH v5 1/2] dt-bindings: usb: add analogix,anx7688.yaml

2021-03-30 Thread Enric Balletbo i Serra
logix,anx7688.yaml >>>>> b/Documentation/devicetree/bindings/usb/analogix,anx7688.yaml >>>>> new file mode 100644 >>>>> index ..6c4dd6b4b28b >>>>> --- /dev/null >>>>> +++ b/Documentation/devicetree/bindings

Re: [PATCH] drm/mediatek: Add missing MODULE_DEVICE_TABLE()

2021-03-30 Thread Enric Balletbo i Serra
Hi, On 3/2/21 12:07, Enric Balletbo i Serra wrote: > From: Boris Brezillon > > This patch adds the missing MODULE_DEVICE_TABLE definitions on different > Mediatek drivers which generates correct modalias for automatic loading > when these drivers are compiled as an external modu

Re: [PATCH 1/2] drm/mediatek: Switch the hdmi bridge ops to the atomic versions

2021-03-25 Thread Enric Balletbo i Serra
Hi Dafna, Thank you for your patch. It'd be nice if you can cc the linux-mediatek ML for next version, so Mediatek people is more aware of this change. IMHO cc'ing the lkml is also a good practice. On 24/3/21 20:12, Dafna Hirschfeld wrote: > The bridge operation '.enable' and the audio cb '.get_e

[PATCH] drm/mediatek: Add missing MODULE_DEVICE_TABLE()

2021-02-04 Thread Enric Balletbo i Serra
From: Boris Brezillon This patch adds the missing MODULE_DEVICE_TABLE definitions on different Mediatek drivers which generates correct modalias for automatic loading when these drivers are compiled as an external module. Signed-off-by: Boris Brezillon Signed-off-by: Enric Balletbo i Serra

[PATCH] phy: mediatek: Add missing MODULE_DEVICE_TABLE()

2021-02-04 Thread Enric Balletbo i Serra
From: Boris Brezillon This patch adds the missing MODULE_DEVICE_TABLE definitions on different Mediatek phy drivers which generates correct modalias for automatic loading when these drivers are compiled as an external module. Signed-off-by: Boris Brezillon Signed-off-by: Enric Balletbo i Serra

[PATCH] drm/mediatek: Use correct aliases name for ovl

2020-11-29 Thread Enric Balletbo i Serra
dd component OVL_2L1") Fixes: b17bdd0d7a73 ("drm/mediatek: add component OVL_2L0") Signed-off-by: Enric Balletbo i Serra --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b

Re: [PATCH 0/4] soc: mediatek: Prepare MMSYS for DDP routing using tables

2020-11-04 Thread Enric Balletbo i Serra
Hi Matthias, On 6/10/20 21:33, Enric Balletbo i Serra wrote: > Dear all, > > The following series are intended to prepare the mtk-mmsys driver to > allow different DDP (Data Display Path) routing tables per SoC. Note > that the series has been tested only on MT8173 platform and co

Re: [PATCH] drm/mediatek: mtk_dpi: Fix unused variable 'mtk_dpi_encoder_funcs'

2020-11-04 Thread Enric Balletbo i Serra
Hi On 5/10/20 18:22, Enric Balletbo i Serra wrote: > Commit f89c696e7f63 ("drm/mediatek: mtk_dpi: Convert to bridge driver") > introduced the following build warning with W=1 > > drivers/gpu/drm/mediatek/mtk_dpi.c:530:39: warning: unused variable > 'mtk_dpi_

[PATCH 1/4] soc / drm: mediatek: Move DDP component defines into mtk-mmsys.h

2020-10-07 Thread Enric Balletbo i Serra
From: Yongqiang Niu MMSYS is the driver which controls the routing of these DDP components, so the definition of the mtk_ddp_comp_id enum should be placed in mtk-mmsys.h Signed-off-by: Yongqiang Niu Reviewed-by: Chun-Kuang Hu Signed-off-by: Enric Balletbo i Serra --- This patch was

[PATCH 0/4] soc: mediatek: Prepare MMSYS for DDP routing using tables

2020-10-07 Thread Enric Balletbo i Serra
reate struct mtk_mmsys to store context data soc: mediatek: mmsys: Use an array for setting the routing registers Enric Balletbo i Serra (1): soc: mediatek: mmsys: Use devm_platform_ioremap_resource() Yongqiang Niu (1): soc / drm: mediatek: Move DDP component defines into mtk-mmsys.h driver

[PATCH] drm/mediatek: mtk_dpi: Fix unused variable 'mtk_dpi_encoder_funcs'

2020-10-06 Thread Enric Balletbo i Serra
ct drm_encoder_funcs mtk_dpi_encoder_funcs = { This struct is and the 'mtk_dpi_encoder_destroy()' are not needed anymore, so remove them. Fixes: f89c696e7f63 ("drm/mediatek: mtk_dpi: Convert to bridge driver") Reported-by: kernel test robot Signed-off-by: Enric Balletbo i Serra ---

Re: [PATCH v1 2/2] drm/rockchip: fix warning from cdn_dp_resume

2020-09-29 Thread Enric Balletbo i Serra
ume’ defined but not used > 1124 | static int cdn_dp_resume(struct device *dev) > |^ > > Fix this by defining cdn_dp_resume __maybe_unused > > Signed-off-by: Sam Ravnborg > Fixes: 7c49abb4c2f8 ("drm/rockchip: cdn-dp-core: Make > cdn_dp_cor

Re: [PATCH v3 0/1] drm/bridge: ps8640: Make sure all needed is powered to get the EDID

2020-09-15 Thread Enric Balletbo i Serra
Hi Sam, On 27/8/20 10:59, Enric Balletbo i Serra wrote: > The first 4 patches of the series version 2: > - drm/bridge_connector: Set default status connected for eDP connectors > - drm/bridge: ps8640: Get the EDID from eDP control > - drm/bridge: ps8640: Return an error for inco

Re: [PATCH v3 1/1] drm/bridge: ps8640: Rework power state handling

2020-09-01 Thread Enric Balletbo i Serra
Hi Bilal, On 31/8/20 11:32, Bilal Wasim wrote: > > Hi Enric, > > On Thu, 27 Aug 2020 10:59:11 +0200 > Enric Balletbo i Serra wrote: > >> The get_edid() callback can be triggered anytime by an ioctl, i.e >> >> drm_mode_getconnector (ioctl) >>

[PATCH v3 0/1] drm/bridge: ps8640: Make sure all needed is powered to get the EDID

2020-08-28 Thread Enric Balletbo i Serra
failed as explained in the third patch. [1] https://lkml.org/lkml/2020/6/15/1208 Changes in v3: - Make poweron/poweroff and pre_enable/post_disable reverse one to each other (Sam Ravnborg) Changes in v2: - Use drm_bridge_chain_pre_enable/post_disable() helpers (Sam Ravnborg) Enric Balletbo i

[PATCH v3 1/1] drm/bridge: ps8640: Rework power state handling

2020-08-28 Thread Enric Balletbo i Serra
o a power on cycle on this device. Otherwise the device fails to retrieve the EDID. Signed-off-by: Enric Balletbo i Serra --- Changes in v3: - Make poweron/poweroff and pre_enable/post_disable reverse one to each other (Sam Ravnborg) Changes in v2: - Use drm_bridge_chain_pre_enable/pos

Re: [PATCH v2 5/5] drm/bridge: ps8640: Rework power state handling

2020-08-28 Thread Enric Balletbo i Serra
Hi Sam, Thanks for your comments. On 26/8/20 20:46, Sam Ravnborg wrote: > Hi Enric. > > On Wed, Aug 26, 2020 at 10:15:26AM +0200, Enric Balletbo i Serra wrote: >> The get_edid() callback can be triggered anytime by an ioctl, i.e >> >> d

[RESEND PATCH v2 0/2] Convert mtk-dpi to drm_bridge API

2020-08-26 Thread Enric Balletbo i Serra
fails. (Boris) Enric Balletbo i Serra (2): drm/mediatek: mtk_dpi: Rename bridge to next_bridge drm/mediatek: mtk_dpi: Convert to bridge driver drivers/gpu/drm/mediatek/mtk_dpi.c | 77 +- 1 file changed, 45 insertions(+), 32 deletions(-) -- 2.28.0

[PATCH v2 3/5] drm/bridge: ps8640: Return an error for incorrect attach flags

2020-08-26 Thread Enric Balletbo i Serra
Bridge drivers that implement the new model only shall return an error from their attach() handler when the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag is not set. So make sure we return an error because only the new drm_bridge model is supported. Reviewed-by: Sam Ravnborg Signed-off-by: Enric Balletbo

[PATCH v2 2/5] drm/bridge: ps8640: Get the EDID from eDP control

2020-08-26 Thread Enric Balletbo i Serra
The PS8640 DSI-to-eDP bridge can retrieve the EDID, so implement the .get_edid callback and set the flag to indicate the core to use it. Reviewed-by: Laurent Pinchart Acked-by: Sam Ravnborg Signed-off-by: Enric Balletbo i Serra --- Changes in v2: - Included the patch `drm/bridge: ps8640: Get

Re: [PATCH v4 0/7] Convert mtk-dsi to drm_bridge API and get EDID for ps8640 bridge

2020-08-26 Thread Enric Balletbo i Serra
Hi Bilal, On 24/8/20 21:01, Bilal Wasim wrote: > Hi Chun-Kuan, Enric, > > Is there any plan to merge the following commits in this series to the > mainline? > > drm/bridge: ps8640: Get the EDID from eDP control > drm/bridge_connector: Set default status connected for eDP connectors > Just

[PATCH v2 0/5] drm/bridge: ps8640: Make sure all needed is powered to get the EDID

2020-08-26 Thread Enric Balletbo i Serra
/1208 Changes in v2: - Included the patch `drm/bridge_connector: Set default status connected for eDP connectors` - Included the patch `drm/bridge: ps8640: Get the EDID from eDP control` - Use drm_bridge_chain_pre_enable/post_disable() helpers (Sam Ravnborg) Enric Balletbo i Serra (5): drm

[PATCH v2 4/5] drm/bridge: ps8640: Print an error if VDO control fails

2020-08-26 Thread Enric Balletbo i Serra
Print an error message inside ps8640_bridge_vdo_control() function when it fails so we can simplify a bit the callers, they will only need to check the error code. Reviewed-by: Sam Ravnborg Signed-off-by: Enric Balletbo i Serra --- Changes in v2: None drivers/gpu/drm/bridge/parade-ps8640.c

[PATCH v2 5/5] drm/bridge: ps8640: Rework power state handling

2020-08-26 Thread Enric Balletbo i Serra
o a power on cycle on this device. Otherwise the device fails to retrieve the EDID. Signed-off-by: Enric Balletbo i Serra --- Changes in v2: - Use drm_bridge_chain_pre_enable/post_disable() helpers (Sam Ravnborg) drivers/gpu/drm/bridge/parade-ps8640.c | 64 +++--- 1 fil

[RESEND PATCH v2 2/2] drm/mediatek: mtk_dpi: Convert to bridge driver

2020-08-26 Thread Enric Balletbo i Serra
Convert mtk_dpi to a bridge driver with built-in encoder support for compatibility with existing component drivers. Reviewed-by: Chun-Kuang Hu Signed-off-by: Enric Balletbo i Serra --- Changes in v2: - Maintain error message when attach to bridge fails. (Boris) drivers/gpu/drm/mediatek

[RESEND PATCH v2 1/2] drm/mediatek: mtk_dpi: Rename bridge to next_bridge

2020-08-26 Thread Enric Balletbo i Serra
This is really a cosmetic change just to make a bit more readable the code after convert the driver to drm_bridge. The bridge variable name will be used by the encoder drm_bridge, and the chained bridge will be named next_bridge. Reviewed-by: Chun-Kuang Hu Signed-off-by: Enric Balletbo i Serra

[PATCH v2 1/5] drm/bridge_connector: Set default status connected for eDP connectors

2020-08-26 Thread Enric Balletbo i Serra
-off-by: Enric Balletbo i Serra --- Changes in v2: - Included the patch `drm/bridge_connector: Set default status connected for eDP connectors` drivers/gpu/drm/drm_bridge_connector.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/drm_bridge_connector.c b/drivers/gpu/drm

Re: [PATCH 3/3] drm/bridge: ps8640: Rework power state handling

2020-08-22 Thread Enric Balletbo i Serra
Dear drm_bridge maintainers, It's been a while since I send these patches, and I'd like to find a proper solution. On 25/6/20 11:21, Enric Balletbo i Serra wrote: > Hi Sam, > > On 24/6/20 9:07, Sam Ravnborg wrote: >> Hi Enric. >> >> On Tue, Jun 23, 2020

[PATCH v2 1/2] drm/mediatek: mtk_dpi: Rename bridge to next_bridge

2020-07-10 Thread Enric Balletbo i Serra
This is really a cosmetic change just to make a bit more readable the code after convert the driver to drm_bridge. The bridge variable name will be used by the encoder drm_bridge, and the chained bridge will be named next_bridge. Signed-off-by: Enric Balletbo i Serra Reviewed-by: Chun-Kuang Hu

[PATCH v2 2/2] drm/mediatek: mtk_dpi: Convert to bridge driver

2020-07-10 Thread Enric Balletbo i Serra
Convert mtk_dpi to a bridge driver with built-in encoder support for compatibility with existing component drivers. Signed-off-by: Enric Balletbo i Serra Reviewed-by: Chun-Kuang Hu --- Changes in v2: - Maintain error message when attach to bridge fails. (Boris) drivers/gpu/drm/mediatek

Re: [RESEND PATCH 3/3] drm/mediatek: mtk_dpi: Use simple encoder

2020-07-10 Thread Enric Balletbo i Serra
Hi again, On 8/7/20 17:12, Enric Balletbo i Serra wrote: > Hi Boris, > > Thank you to spend some time to review the patches. > > On 1/7/20 13:41, Boris Brezillon wrote: >> On Mon, 18 May 2020 19:39:09 +0200 >> Enric Balletbo i Serra wrote: >> >>> The m

[PATCH v2 0/2] Convert mtk-dpi to drm_bridge API

2020-07-10 Thread Enric Balletbo i Serra
. (Boris) - Drop the third patch. Enric Balletbo i Serra (2): drm/mediatek: mtk_dpi: Rename bridge to next_bridge drm/mediatek: mtk_dpi: Convert to bridge driver drivers/gpu/drm/mediatek/mtk_dpi.c | 77 +- 1 file changed, 45 insertions(+), 32 deletions

Re: [RESEND PATCH 3/3] drm/mediatek: mtk_dpi: Use simple encoder

2020-07-09 Thread Enric Balletbo i Serra
Hi Boris, Thank you to spend some time to review the patches. On 1/7/20 13:41, Boris Brezillon wrote: > On Mon, 18 May 2020 19:39:09 +0200 > Enric Balletbo i Serra wrote: > >> The mtk_dpi driver uses an empty implementation for its encoder. Replace >> the code with the g

Re: [RESEND PATCH 2/3] drm/mediatek: mtk_dpi: Convert to bridge driver

2020-07-09 Thread Enric Balletbo i Serra
Hi Boris, Thank you for review the patch. On 1/7/20 13:51, Boris Brezillon wrote: > On Mon, 18 May 2020 19:39:08 +0200 > Enric Balletbo i Serra wrote: > >> Convert mtk_dpi to a bridge driver with built-in encoder support for >> compatibility with existing component drivers

Re: [RESEND PATCH v4 0/7] Convert mtk-dsi to drm_bridge API and get EDID for ps8640 bridge

2020-07-01 Thread Enric Balletbo i Serra
Hi Sam, Chun-Kuan, On 20/6/20 23:33, Sam Ravnborg wrote: > Hi Enric > > On Mon, Jun 15, 2020 at 10:31:01PM +0200, Enric Balletbo i Serra wrote: >> (This resend is to fix some trivial conflicts due the merge window) >> >> The PS8640 dsi-to-eDP bridge driver is

Re: [RESEND PATCH v4 0/7] Convert mtk-dsi to drm_bridge API and get EDID for ps8640 bridge

2020-07-01 Thread Enric Balletbo i Serra
Hi Chun-Kuang, On 30/6/20 18:26, Chun-Kuang Hu wrote: > Hi, Enric: > > Enric Balletbo i Serra 於 2020年6月30日 週二 > 下午10:34寫道: >> >> Hi Sam, Chun-Kuan, >> >> On 20/6/20 23:33, Sam Ravnborg wrote: >>> Hi Enric >>> >>> On Mon,

Re: [PATCH 3/3] drm/bridge: ps8640: Rework power state handling

2020-06-26 Thread Enric Balletbo i Serra
Hi Sam, On 24/6/20 9:07, Sam Ravnborg wrote: > Hi Enric. > > On Tue, Jun 23, 2020 at 05:16:43PM +0200, Enric Balletbo i Serra wrote: >> Hi Sam, >> >> Many thanks for your feedback. See my answers below. >> >> On 20/6/20 23:42, Sam Ravnborg wrote: >>&

Re: [PATCH 3/3] drm/bridge: ps8640: Rework power state handling

2020-06-23 Thread Enric Balletbo i Serra
Hi Sam, Many thanks for your feedback. See my answers below. On 20/6/20 23:42, Sam Ravnborg wrote: > Hi Enric. > > On Mon, Jun 15, 2020 at 10:53:20PM +0200, Enric Balletbo i Serra wrote: >> The get_edid() callback can be triggered anytime by an ioctl, i.e >> >> d

[PATCH 0/3] drm/bridge: ps8640: Make sure all needed is powered to get the EDID

2020-06-16 Thread Enric Balletbo i Serra
patch. Note that this series depends on: https://lore.kernel.org/patchwork/project/lkml/list/?series=448525 to apply cleanly. Enric Balletbo i Serra (3): drm/bridge: ps8640: Return an error for incorrect attach flags drm/bridge: ps8640: Print an error if VDO control fails drm/bridge: ps8640

[RESEND PATCH v4 2/7] drm/bridge_connector: Set default status connected for eDP connectors

2020-06-16 Thread Enric Balletbo i Serra
In an eDP application, HPD is not required and on most bridge chips useless. If HPD is not used, we need to set initial status as connected, otherwise the connector created by the drm_bridge_connector API remains in an unknown state. Signed-off-by: Enric Balletbo i Serra Reviewed-by: Laurent

[RESEND PATCH v4 3/7] drm/mediatek: mtk_dsi: Rename bridge to next_bridge

2020-06-16 Thread Enric Balletbo i Serra
This is really a cosmetic change just to make a bit more readable the code after convert the driver to drm_bridge. The bridge variable name will be used by the encoder drm_bridge, and the chained bridge will be named next_bridge. Signed-off-by: Enric Balletbo i Serra Reviewed-by: Laurent

[RESEND PATCH v4 7/7] drm/mediatek: mtk_dsi: Create connector for bridges

2020-06-16 Thread Enric Balletbo i Serra
. Signed-off-by: Enric Balletbo i Serra Acked-by: Sam Ravnborg --- Changes in v4: None Changes in v3: - Move the bridge.type line to the patch that adds drm_bridge support. (Laurent Pinchart) Changes in v2: None drivers/gpu/drm/mediatek/mtk_dsi.c | 13 - 1 file changed, 12 insertions

[RESEND PATCH v4 0/7] Convert mtk-dsi to drm_bridge API and get EDID for ps8640 bridge

2020-06-16 Thread Enric Balletbo i Serra
in v2: - Do not set connector_type for panel here. (Sam Ravnborg) Enric Balletbo i Serra (7): drm/bridge: ps8640: Get the EDID from eDP control drm/bridge_connector: Set default status connected for eDP connectors drm/mediatek: mtk_dsi: Rename bridge to next_bridge drm/mediatek: mtk_dsi: Co

[RESEND PATCH v4 1/7] drm/bridge: ps8640: Get the EDID from eDP control

2020-06-16 Thread Enric Balletbo i Serra
The PS8640 DSI-to-eDP bridge can retrieve the EDID, so implement the .get_edid callback and set the flag to indicate the core to use it. Signed-off-by: Enric Balletbo i Serra Reviewed-by: Laurent Pinchart Acked-by: Sam Ravnborg --- Changes in v4: None Changes in v3: None Changes in v2: None

[RESEND PATCH v4 6/7] drm/mediatek: mtk_dsi: Use the drm_panel_bridge API

2020-06-16 Thread Enric Balletbo i Serra
Replace the manual panel handling code by a drm_panel_bridge. This simplifies the driver and allows all components in the display pipeline to be treated as bridges, paving the way to generic connector handling. Signed-off-by: Enric Balletbo i Serra Reviewed-by: Laurent Pinchart Acked-by: Sam

[RESEND PATCH v4 5/7] drm/mediatek: mtk_dsi: Use simple encoder

2020-06-16 Thread Enric Balletbo i Serra
The mtk_dsi driver uses an empty implementation for its encoder. Replace the code with the generic simple encoder. Signed-off-by: Enric Balletbo i Serra Reviewed-by: Laurent Pinchart Acked-by: Sam Ravnborg Reviewed-by: Chun-Kuang Hu --- Changes in v4: None Changes in v3: None Changes in v2

[PATCH 2/3] drm/bridge: ps8640: Print an error if VDO control fails

2020-06-16 Thread Enric Balletbo i Serra
Print an error message inside ps8640_bridge_vdo_control() function when it fails so we can simplify a bit the callers, they will only need to check the error code. Signed-off-by: Enric Balletbo i Serra --- drivers/gpu/drm/bridge/parade-ps8640.c | 13 ++--- 1 file changed, 6 insertions

[PATCH 1/3] drm/bridge: ps8640: Return an error for incorrect attach flags

2020-06-16 Thread Enric Balletbo i Serra
Bridge drivers that implement the new model only shall return an error from their attach() handler when the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag is not set. So make sure we return an error because only the new drm_bridge model is supported. Signed-off-by: Enric Balletbo i Serra --- drivers/gpu

[PATCH 3/3] drm/bridge: ps8640: Rework power state handling

2020-06-16 Thread Enric Balletbo i Serra
o a power on cycle on this device. Otherwise the device fails to retrieve the EDID. Signed-off-by: Enric Balletbo i Serra --- drivers/gpu/drm/bridge/parade-ps8640.c | 79 -- 1 file changed, 73 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/bridge/parade-ps

[RESEND PATCH v4 4/7] drm/mediatek: mtk_dsi: Convert to bridge driver

2020-06-16 Thread Enric Balletbo i Serra
Convert mtk_dsi to a bridge driver with built-in encoder support for compatibility with existing component drivers. Signed-off-by: Enric Balletbo i Serra Acked-by: Sam Ravnborg Reviewed-by: Chun-Kuang Hu --- Changes in v4: - Remove double call to drm_encoder_init(). (Chun-Kuang Hu) - Cleanup

Re: [RESEND PATCH 0/3] Convert mtk-dpi to drm_bridge API

2020-06-13 Thread Enric Balletbo i Serra
Hi, On 18/5/20 19:39, Enric Balletbo i Serra wrote: > The reason for this resend is because I forget to add some bridge > maintainers. So adding them and collect the actual tags. > > The mtk-dpi driver still uses the drm_encoder API which is now somewhat > deprecated. We started

[PATCH] drm/mediatek: mtk_mt8173_hdmi_phy: Remove unnused const variables

2020-05-20 Thread Enric Balletbo i Serra
There are some `static const u8` variables that are not used, this triggers a warning building with `make W=1`, it is safe to remove them, so do it and make the compiler more happy. Signed-off-by: Enric Balletbo i Serra --- .../gpu/drm/mediatek/mtk_mt8173_hdmi_phy.c| 48

[PATCH] drm/mediatek: mtk_hdmi: Remove debug messages for function calls

2020-05-20 Thread Enric Balletbo i Serra
Equivalent information can be nowadays obtained using function tracer Signed-off-by: Enric Balletbo i Serra --- drivers/gpu/drm/mediatek/mtk_hdmi.c| 12 +--- drivers/gpu/drm/mediatek/mtk_mt8173_hdmi_phy.c | 4 2 files changed, 1 insertion(+), 15 deletions(-) diff

[RESEND PATCH 2/3] drm/mediatek: mtk_dpi: Convert to bridge driver

2020-05-19 Thread Enric Balletbo i Serra
Convert mtk_dpi to a bridge driver with built-in encoder support for compatibility with existing component drivers. Signed-off-by: Enric Balletbo i Serra Reviewed-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/mtk_dpi.c | 66 +++--- 1 file changed, 34 insertions(+), 32

[RESEND PATCH 3/3] drm/mediatek: mtk_dpi: Use simple encoder

2020-05-19 Thread Enric Balletbo i Serra
The mtk_dpi driver uses an empty implementation for its encoder. Replace the code with the generic simple encoder. Signed-off-by: Enric Balletbo i Serra Reviewed-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/mtk_dpi.c | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions

[RESEND PATCH 1/3] drm/mediatek: mtk_dpi: Rename bridge to next_bridge

2020-05-19 Thread Enric Balletbo i Serra
This is really a cosmetic change just to make a bit more readable the code after convert the driver to drm_bridge. The bridge variable name will be used by the encoder drm_bridge, and the chained bridge will be named next_bridge. Signed-off-by: Enric Balletbo i Serra Reviewed-by: Chun-Kuang Hu

[RESEND PATCH 0/3] Convert mtk-dpi to drm_bridge API

2020-05-19 Thread Enric Balletbo i Serra
://lore.kernel.org/patchwork/project/lkml/list/?series=441559 Enric Balletbo i Serra (3): drm/mediatek: mtk_dpi: Rename bridge to next_bridge drm/mediatek: mtk_dpi: Convert to bridge driver drm/mediatek: mtk_dpi: Use simple encoder drivers/gpu/drm/mediatek/mtk_dpi.c | 84

Re: [PATCH] drm/mediatek: Delete not used of_device_get_match_data

2020-05-19 Thread Enric Balletbo i Serra
done later already, just delete the call to > of_device_get_match_data. > > Signed-off-by: Matthias Brugger Reviewed-by: Enric Balletbo i Serra > --- > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/m

Re: [PATCH v4 7/7] drm/mediatek: mtk_dsi: Create connector for bridges

2020-05-14 Thread Enric Balletbo i Serra
Hi again, On 14/5/20 19:12, Enric Balletbo i Serra wrote: > Hi Chun-Kuang, > > On 14/5/20 18:44, Chun-Kuang Hu wrote: >> Hi, Enric: >> >> Enric Balletbo i Serra 於 2020年5月14日 週四 >> 下午11:42寫道: >>> >>> Hi Chun-Kuang, >>> >>> O

Re: [PATCH v4 7/7] drm/mediatek: mtk_dsi: Create connector for bridges

2020-05-14 Thread Enric Balletbo i Serra
Hi Chun-Kuang, On 14/5/20 16:28, Chun-Kuang Hu wrote: > Hi, Enric: > > Enric Balletbo Serra 於 2020年5月14日 週四 上午12:41寫道: >> >> Hi Chun-Kuang, >> >> Missatge de Enric Balletbo i Serra del >> dia dv., 1 de maig 2020 a les 17:25: >>> >>> Use

Re: [PATCH v4 7/7] drm/mediatek: mtk_dsi: Create connector for bridges

2020-05-14 Thread Enric Balletbo i Serra
Hi Chun-Kuang, On 14/5/20 18:44, Chun-Kuang Hu wrote: > Hi, Enric: > > Enric Balletbo i Serra 於 2020年5月14日 週四 > 下午11:42寫道: >> >> Hi Chun-Kuang, >> >> On 14/5/20 16:28, Chun-Kuang Hu wrote: >>> Hi, Enric: >>> >>> Enric Bal

[PATCH 0/3] Convert mtk-dpi to drm_bridge API

2020-05-05 Thread Enric Balletbo i Serra
dummy drm_encoder is maintained in the mtk-dpi driver but the end goal is move all the dummy drm_encoder (mtk-dsi, mtk-dpi, etc) to the main mtk_drm_drv driver. Best regards, Enric [1] https://lore.kernel.org/patchwork/project/lkml/list/?series=441559 Enric Balletbo i Serra (3): drm/mediatek

[PATCH 1/3] drm/mediatek: mtk_dpi: Rename bridge to next_bridge

2020-05-05 Thread Enric Balletbo i Serra
This is really a cosmetic change just to make a bit more readable the code after convert the driver to drm_bridge. The bridge variable name will be used by the encoder drm_bridge, and the chained bridge will be named next_bridge. Signed-off-by: Enric Balletbo i Serra --- drivers/gpu/drm

[PATCH 2/3] drm/mediatek: mtk_dpi: Convert to bridge driver

2020-05-05 Thread Enric Balletbo i Serra
Convert mtk_dpi to a bridge driver with built-in encoder support for compatibility with existing component drivers. Signed-off-by: Enric Balletbo i Serra --- drivers/gpu/drm/mediatek/mtk_dpi.c | 66 +++--- 1 file changed, 34 insertions(+), 32 deletions(-) diff --git a

[PATCH 3/3] drm/mediatek: mtk_dpi: Use simple encoder

2020-05-04 Thread Enric Balletbo i Serra
The mtk_dpi driver uses an empty implementation for its encoder. Replace the code with the generic simple encoder. Signed-off-by: Enric Balletbo i Serra --- drivers/gpu/drm/mediatek/mtk_dpi.c | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm

[PATCH v4 0/7] Convert mtk-dsi to drm_bridge API and get EDID for ps8640 bridge

2020-05-02 Thread Enric Balletbo i Serra
he mediatek dsi driver in mainline, so should be safe to switch to the new chain of drm_bridge API unconditionally. The patches has been tested on a Acer Chromebook R13 (Elm) running a Chrome OS userspace and checking that the valid EDID mode reported by the bridge is selected. Enric Balletbo i Serra (7

[PATCH v4 7/7] drm/mediatek: mtk_dsi: Create connector for bridges

2020-05-02 Thread Enric Balletbo i Serra
. Signed-off-by: Enric Balletbo i Serra Acked-by: Sam Ravnborg --- Changes in v4: None Changes in v3: - Move the bridge.type line to the patch that adds drm_bridge support. (Laurent Pinchart) Changes in v2: None drivers/gpu/drm/mediatek/mtk_dsi.c | 13 - 1 file changed, 12 insertions

[PATCH v4 3/7] drm/mediatek: mtk_dsi: Rename bridge to next_bridge

2020-05-02 Thread Enric Balletbo i Serra
This is really a cosmetic change just to make a bit more readable the code after convert the driver to drm_bridge. The bridge variable name will be used by the encoder drm_bridge, and the chained bridge will be named next_bridge. Signed-off-by: Enric Balletbo i Serra Reviewed-by: Laurent

Re: [PATCH v3 7/7] drm/mediatek: mtk_dsi: Create connector for bridges

2020-05-02 Thread Enric Balletbo i Serra
Hi Chun-Kuang, Thank you for your review. On 1/5/20 16:26, Chun-Kuang Hu wrote: > Hi, Enric: > > Enric Balletbo i Serra 於 2020年4月17日 週五 > 下午11:06寫道: >> >> Use the drm_bridge_connector helper to create a connector for pipelines >> that use drm_bridge. This allows

[PATCH v4 1/7] drm/bridge: ps8640: Get the EDID from eDP control

2020-05-02 Thread Enric Balletbo i Serra
The PS8640 DSI-to-eDP bridge can retrieve the EDID, so implement the .get_edid callback and set the flag to indicate the core to use it. Signed-off-by: Enric Balletbo i Serra Reviewed-by: Laurent Pinchart Acked-by: Sam Ravnborg --- Changes in v4: None Changes in v3: None Changes in v2: None

[PATCH v4 6/7] drm/mediatek: mtk_dsi: Use the drm_panel_bridge API

2020-05-02 Thread Enric Balletbo i Serra
Replace the manual panel handling code by a drm_panel_bridge. This simplifies the driver and allows all components in the display pipeline to be treated as bridges, paving the way to generic connector handling. Signed-off-by: Enric Balletbo i Serra Reviewed-by: Laurent Pinchart Acked-by: Sam

[PATCH v4 2/7] drm/bridge_connector: Set default status connected for eDP connectors

2020-05-02 Thread Enric Balletbo i Serra
In an eDP application, HPD is not required and on most bridge chips useless. If HPD is not used, we need to set initial status as connected, otherwise the connector created by the drm_bridge_connector API remains in an unknown state. Signed-off-by: Enric Balletbo i Serra Reviewed-by: Laurent

[PATCH v4 4/7] drm/mediatek: mtk_dsi: Convert to bridge driver

2020-05-02 Thread Enric Balletbo i Serra
Convert mtk_dsi to a bridge driver with built-in encoder support for compatibility with existing component drivers. Signed-off-by: Enric Balletbo i Serra Acked-by: Sam Ravnborg --- Changes in v4: - Remove double call to drm_encoder_init(). (Chun-Kuang Hu) - Cleanup the encoder in

[PATCH v4 5/7] drm/mediatek: mtk_dsi: Use simple encoder

2020-05-02 Thread Enric Balletbo i Serra
The mtk_dsi driver uses an empty implementation for its encoder. Replace the code with the generic simple encoder. Signed-off-by: Enric Balletbo i Serra Reviewed-by: Laurent Pinchart Acked-by: Sam Ravnborg Reviewed-by: Chun-Kuang Hu --- Changes in v4: None Changes in v3: None Changes in v2

Re: [PATCH v3 4/7] drm/mediatek: mtk_dsi: Convert to bridge driver

2020-05-02 Thread Enric Balletbo i Serra
Hi Chun-Kuang, Thank you for the review. On 1/5/20 15:21, Chun-Kuang Hu wrote: > Hi, Enric: > > Enric Balletbo i Serra 於 2020年4月17日 週五 > 下午11:06寫道: >> >> Convert mtk_dsi to a bridge driver with built-in encoder support for >> compatibility with existing componen

Re: [PATCH v3 -next] drm/mediatek: Fix Kconfig warning

2020-04-30 Thread Enric Balletbo i Serra
9 ("soc / drm: mediatek: Move routing control to mmsys > device") > Signed-off-by: YueHaibing Definitively we shouldn't select the MTK_MMSYS and we should depend on MTK_MMSYS instead, so Reviewed-by: Enric Balletbo i Serra > --- > v3: make DRM_MEDIATEK depends on MTK

Re: [PATCH] drm/rockchip: cdn-dp-core: Make cdn_dp_core_suspend/resume __maybe_unused

2020-04-28 Thread Enric Balletbo i Serra
static") > Signed-off-by: Arnd Bergmann Reviewed-by: Enric Balletbo i Serra > --- > drivers/gpu/drm/rockchip/cdn-dp-core.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.c > b/drivers/gpu/drm/rockchi

Re: [PATCH v3] dt-bindings: display: anx7814.txt: convert to yaml

2020-04-28 Thread Enric Balletbo i Serra
: http://devicetree.org/schemas/display/bridge/analogix,anx7814.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Analogix ANX7814 SlimPort (Full-HD Transmitter) > + > +maintainers: > + - Enric Balletbo i Serra > + > +properties: > + co

Re: [PATCH v8 05/10] drm: imx: Add i.MX 6 MIPI DSI host platform driver

2020-04-28 Thread Enric Balletbo i Serra
Hi Adrian Thank you for your patch. On 27/4/20 10:19, Adrian Ratiu wrote: > This adds support for the Synopsis DesignWare MIPI DSI v1.01 host > controller which is embedded in i.MX 6 SoCs. > > Based on following patches, but updated/extended to work with existing > support found in the kernel: >

Re: [PATCH v8 01/10] drm: bridge: dw_mipi_dsi: add initial regmap infrastructure

2020-04-28 Thread Enric Balletbo i Serra
to the platform drivers. > > Cc: Enric Balletbo Serra > Suggested-by: Ezequiel Garcia > Tested-by: Adrian Pop > Tested-by: Arnaud Ferraris > Signed-off-by: Adrian Ratiu Reviewed-by: Enric Balletbo i Serra > --- > Chnages since v7: > - Minor checkpatch line fix > &

[PATCH] drm/rockchip: cdn-dp-core: Make cdn_dp_core_suspend/resume static

2020-04-27 Thread Enric Balletbo i Serra
‘cdn_dp_resume’ [-Wmissing-prototypes] Signed-off-by: Enric Balletbo i Serra --- drivers/gpu/drm/rockchip/cdn-dp-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.c b/drivers/gpu/drm/rockchip/cdn-dp-core.c index eed594bd38d3

Re: [PATCH] dt-bindings: display: anx7814.txt: convert to yaml

2020-04-24 Thread Enric Balletbo i Serra
new file mode 100644 > index ..53d3c778c893 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/bridge/anx7814.yaml > @@ -0,0 +1,133 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.or

  1   2   3   4   5   >