My understanding is that DRM_MODE_PAGE_FLIP_ASYNC is currently only
supported for the legacy DRM_IOCTL_MODE_PAGE_FLIP ioctl. Comments in
related code suggest that while ASYNC is not currently supported for
DRM_IOCTL_MODE_ATOMIC, there could be support for it at some point in
the future.
Is anyone
suming
that something earlier on would catch and reject a src with zero
width/height.
Drew
>
>
> ...alan
>
> On Mon, 2022-12-26 at 22:53 -0700, Drew Davenport wrote:
> > The error message suggests that the height of the src rect must be at
> > least 1. Rejec
t struct intel_crtc_state
> *crtc_state,
>
>
> What do you think? I'll in any case come up with some test for this in igt.
I see that you've posted your fix to the list already. Adding a
test to cover this in IGT also sounds great. Thanks!
Breadcrumbs to Juha-Pekka's pat
The error message suggests that the height of the src rect must be at
least 1. Reject source with height of 0.
Signed-off-by: Drew Davenport
---
I was investigating some divide-by-zero crash reports on ChromeOS which
pointed to the intel_adjusted_rate function. Further prodding showed
that I
Avoid the panel oscillating on and off during boot. In some cases it
will be more than 1000ms between powering the panel to read the EDID early
during boot, and enabling the panel for display. Extending the
autosuspend delay avoids autosuspending during this interval.
Signed-off-by: Drew
ktime_get_boottime continues while the device is suspended. This change
ensures that the resume path will not be delayed if the power off delay
has already been met while the device is suspended
Signed-off-by: Drew Davenport
---
drivers/gpu/drm/panel/panel-samsung-atna33xc20.c | 8
1
ktime_get_boottime continues while the device is suspended. This change
ensures that the resume path will not be delayed if the power off delay
has already been met while the device is suspended
Signed-off-by: Drew Davenport
---
drivers/gpu/drm/panel/panel-simple.c | 6 +++---
1 file changed
Same change as done for panel-samsung-atna33xc20. Extend the autosuspend
delay to avoid oscillating between power status during boot.
Signed-off-by: Drew Davenport
---
drivers/gpu/drm/bridge/parade-ps8640.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm
sures that the resume path
will not be delayed if the power off delay has already been met while
the device is suspended.
Signed-off-by: Drew Davenport
---
drivers/gpu/drm/panel/panel-edp.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/panel/pane
sures that the resume path
will not be delayed if the power off delay has already been met while
the device is suspended.
Signed-off-by: Drew Davenport
---
drivers/gpu/drm/panel/panel-edp.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/panel/pane
On Tue, Mar 15, 2022 at 03:21:05PM +, Lee, Shawn C wrote:
> On Tuesday, March 15, 2022 8:33 PM, Nikula, Jani
> wrote:
> >On Mon, 14 Mar 2022, Drew Davenport wrote:
> >> On Mon, Mar 14, 2022 at 10:40:47AM +0200, Jani Nikula wrote:
> >>> On Sun
earch available
> > DisplayID block.
> >
> > Cc: Jani Nikula
> > Cc: Ville Syrjala
> > Cc: Ankit Nautiyal
> > Cc: Drew Davenport
> > Cc: intel-gfx
> > Signed-off-by: Lee Shawn C
> > ---
> > drivers/gpu/drm/drm_displayid.c | 10 +
On Fri, Mar 11, 2022 at 09:22:14AM +0800, Lee Shawn C wrote:
> drm_find_cea_extension() always look for a top level CEA block. Pass
> ext_index from caller then this function to search next available
> CEA ext block from a specific EDID block pointer.
>
> v2: save proper extension block index if C
In (40d9b043a89e drm/connector: store tile information from displayid (v3))
this function was changed to find EDID extensions by id, but the comments
still are specific to the CEA extension.
Signed-off-by: Drew Davenport
---
drivers/gpu/drm/drm_edid.c | 4 ++--
1 file changed, 2 insertions
ctx->next_bridge is checked for NULL twice in a row. The second
conditional is redundant, so remove it.
Signed-off-by: Drew Davenport
---
drivers/gpu/drm/bridge/ite-it66121.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/bridge/ite-it66121.c
b/drivers/gpu/drm/bridge/
Make iterator implementation private, and add function to
query resources assigned to an encoder.
Signed-off-by: Drew Davenport
---
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 59 ---
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.h | 10
.../gpu/drm/msm/disp/dpu1
indices in these arrays to replace iteration
with index lookups in several places.
Signed-off-by: Drew Davenport
---
drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 553 +++--
drivers/gpu/drm/msm/disp/dpu1/dpu_rm.h | 22 +-
2 files changed, 255 insertions(+), 320 deletions(-)
di
drm atomic global state, this is not necessary as any changes
to the global state will be discarded if the test fails.
Signed-off-by: Drew Davenport
---
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 65 +--
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 84 ++
drivers/gpu/drm
Several functions arguments in the resource manager are unused, so
remove them.
Signed-off-by: Drew Davenport
---
drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 37 ++
1 file changed, 14 insertions(+), 23 deletions(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c
b
dpu_crtc_mixer.lm_ctl will never be NULL, so don't bother checking
Signed-off-by: Drew Davenport
---
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
b/drivers/gpu/drm/msm/disp
The dpu_encoder_phys * argument passed to these functions will never be
NULL so don't check.
Signed-off-by: Drew Davenport
---
.../drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 69 ---
.../drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 44 +---
2 files changed, 17 inser
dpu_encoder_virt.phys_encs[0:num_phys_encs-1] will not be NULL so don't
check.
Also fix multiline strings that caused checkpatch warning.
Signed-off-by: Drew Davenport
---
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 162
1 file changed, 61 insertions(+), 101 dele
dpu_crtc_mixer.hw_lm will never be NULL, so don't check.
Signed-off-by: Drew Davenport
---
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 13 +++--
1 file changed, 3 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
b/drivers/gpu/drm/msm/disp
The return statement follows another return statement, so will never be
reached.
Signed-off-by: Drew Davenport
---
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c
b/drivers/gpu/drm
dpu_hw_ctl* is checked for NULL when passed as an argument
to several functions. It will never be NULL, so remove the
checks.
Signed-off-by: Drew Davenport
---
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 10 --
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 12
The arguments related to IOMMU port name have been unused since
commit 944fc36c31ed ("drm/msm: use upstream iommu") and can be removed.
Signed-off-by: Drew Davenport
---
Rob, in the original commit the port name stuff was left intentionally.
Would it be alright to remove it now?
d
dpu_kms.dev will never be NULL, so don't bother checking.
Signed-off-by: Drew Davenport
---
drivers/gpu/drm/msm/disp/dpu1/dpu_core_irq.c | 8 -
.../drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 4 ---
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 30 +--
3 files ch
Signed-off-by: Drew Davenport
---
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h
b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h
index 4c889aabdaf9..6ceba33a179e 100644
--- a/drivers/gpu/drm/msm/disp/dpu1
msm_drm_private.kms will only be NULL in the dummy headless case, so
there is no need to check it in the dpu display driver.
Signed-off-by: Drew Davenport
---
drivers/gpu/drm/msm/disp/dpu1/dpu_core_irq.c | 23 ---
drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 12
drm_crtc.dev will never be NULL, so no need to check it.
Signed-off-by: Drew Davenport
---
drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 5 -
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 6 +++---
2 files changed, 3 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/msm/disp
drm_device.dev_private is set to a non-NULL msm_drm_private
struct in msm_drm_init. Successful initialization of msm means
that dev_private is non-NULL so there is no need to check it
everywhere.
Signed-off-by: Drew Davenport
---
drivers/gpu/drm/msm/disp/dpu1/dpu_core_irq.c | 6
Signed-off-by: Drew Davenport
---
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c| 5 -
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 7 ---
2 files changed, 12 deletions(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
index
32 matches
Mail list logo
