Hello Heiko,
On 2025-03-04 13:44, Heiko Stuebner wrote:
diff --git a/drivers/gpu/drm/rockchip/rockchip_lvds.c
b/drivers/gpu/drm/rockchip/rockchip_lvds.c
index 385cf6881504..ecfae8d5da89 100644
--- a/drivers/gpu/drm/rockchip/rockchip_lvds.c
+++ b/drivers/gpu/drm/rockchip/rockchip_lvds.c
@@ -448,1
t != -EPROBE_DEFER)
- DRM_DEV_ERROR(dev,
- "Failed to probe dw_mipi_dsi: %d\n", ret);
- return ret;
- }
+ if (IS_ERR(dsi->dmd))
+ return dev_err_probe(dev, PTR_ERR(dsi->dmd), "Failed to probe
dw_mipi_dsi\n");
return 0;
}
Regardless of the above-suggested split into a patch series
ending up accepted or not, the introduced changes are looking
good to me, so please feel free to include my
Reviewed-by: Dragan Simic
On 2024-11-08 15:30, Dragan Simic wrote:
On 2024-11-08 15:22, Heiko Stübner wrote:
Am Freitag, 8. November 2024, 15:13:33 CET schrieb Dragan Simic:
On 2024-11-08 15:09, Heiko Stübner wrote:
> Am Freitag, 8. November 2024, 15:05:02 CET schrieb Dragan Simic:
>> On 2024-11-08 14:56, Heik
On 2024-11-08 15:22, Heiko Stübner wrote:
Am Freitag, 8. November 2024, 15:13:33 CET schrieb Dragan Simic:
On 2024-11-08 15:09, Heiko Stübner wrote:
> Am Freitag, 8. November 2024, 15:05:02 CET schrieb Dragan Simic:
>> On 2024-11-08 14:56, Heiko Stübner wrote:
>> > Am Freitag
On 2024-11-08 15:09, Heiko Stübner wrote:
Am Freitag, 8. November 2024, 15:05:02 CET schrieb Dragan Simic:
On 2024-11-08 14:56, Heiko Stübner wrote:
> Am Freitag, 8. November 2024, 14:53:57 CET schrieb Dragan Simic:
>> Perform a few trivial code cleanups, to make one logged mess
Hello Sebastian,
On 2024-11-08 15:08, Sebastian Reichel wrote:
On Fri, Nov 08, 2024 at 02:53:58PM +0100, Dragan Simic wrote:
Deferred driver probing shouldn't result in errors or warnings being
logged,
because their presence in the kernel log provides no value and may
actually
cause
Hello Heiko,
On 2024-11-08 14:56, Heiko Stübner wrote:
Am Freitag, 8. November 2024, 14:53:57 CET schrieb Dragan Simic:
Perform a few trivial code cleanups, to make one logged message a bit
more
consistent with the other logged messages by capitalizing its first
word, and
to avoid line
-by: Dragan Simic
---
drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c
b/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c
index 58a44af0e9ad..f451e70efbdd 100644
--- a
i-rockchip fe06.dsi: [drm:dw_mipi_dsi_rockchip_probe \
[rockchipdrm]] *ERROR* failed to get mipi dphy: -517
At the same time, make the adjusted logged message a bit more consistent with
the other logged messages by capitalizing its first word.
Reported-by: Diederik de Haas
Signed-off-by: Dr
read and a bit more consistent.
Dragan Simic (2):
drm/rockchip: dsi: Perform trivial code cleanups
drm/rockchip: dsi: Don't log errors on deferred dphy
drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c | 15 ++-
1 file changed, 6 insertions(+), 9 deletions(-)
: Dragan Simic
---
drivers/gpu/drm/bridge/ite-it66121.c | 2 +-
drivers/gpu/drm/bridge/sii902x.c | 2 +-
drivers/gpu/drm/drm_panel.c | 2 +-
drivers/gpu/drm/msm/dsi/dsi_host.c | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/bridge/ite-it66121
On 2024-07-25 11:33, Dragan Simic wrote:
Hello all,
Just checking, is this patch good enough to be accepted? If not, is
there
some other preferred way for cleaning up the produced messages?
Just a brief reminder...
On 2024-07-04 01:32, Dragan Simic wrote:
Clean up a few logged messages
On 2024-07-26 10:54, Qiang Yu wrote:
On Fri, Jul 26, 2024 at 4:03 PM Dragan Simic
wrote:
On 2024-07-26 08:07, Qiang Yu wrote:
> Yeah, I agree weakdep is a better choice here. It solves the confusion
> of softdep which the depend module is optional.
Thanks, I'm glad that you agre
also describes why using
this alias might save use some time and effort in the future.
[7]
https://lore.kernel.org/linux-modules/0720a516416a92a8f683053d37ee9...@manjaro.org/
On Thu, Jul 25, 2024 at 4:21 PM Dragan Simic
wrote:
Hello Qiang,
On 2024-06-26 08:49, Dragan Simic wrote:
> On 2024-06-
Hello Steven,
On 2024-07-25 11:20, Steven Price wrote:
On 25/07/2024 09:24, Dragan Simic wrote:
Hello Steven and Boris,
Another option has become available for expressing additional module
dependencies, weakdeps. [1][2] Long story short, weakdeps are similar
to softdeps, in the sense of
Hello all,
Just checking, is this patch good enough to be accepted? If not, is
there
some other preferred way for cleaning up the produced messages?
On 2024-07-04 01:32, Dragan Simic wrote:
Clean up a few logged messages, which were previously worded as rather
incomplete sentences separated
Hello Steven and Boris,
On 2024-07-03 16:52, Dragan Simic wrote:
On 2024-07-03 15:20, Steven Price wrote:
On 03/07/2024 13:42, Dragan Simic wrote:
On 2024-06-17 22:17, Dragan Simic wrote:
Panfrost DRM driver uses devfreq to perform DVFS, while using
simple_ondemand
devfreq governor by
Hello Qiang,
On 2024-06-26 08:49, Dragan Simic wrote:
On 2024-06-26 03:11, Qiang Yu wrote:
On Wed, Jun 26, 2024 at 2:15 AM Dragan Simic
wrote:
Just checking, any further thoughts about this patch?
I'm OK with this as a temp workaround because it's simple and do no
harm
eve
h v2 submissions, [1]
and it's the best to produce patch notes using git-notes(1). [2]
[1]
https://lore.kernel.org/linux-rockchip/bdb60f1f793166cd65f58ab7aea025347076019c.1719679068.git.dsi...@manjaro.org/
[2] https://git-scm.com/docs/git-notes
On Monday, July 22nd, 2024 at 8:37 AM, Dragan
Hello Piotr,
Thanks for the patch. Please see a few general comments below.
On 2024-07-21 12:06, Piotr Zalewski wrote:
Add support for gamma LUT in VOP2 driver. The implementation is based
on
the one found in VOP driver and modified to be compatible with VOP2.
Blue
and red channels in gamma L
Hello Ondrej,
On 2024-07-17 09:32, Ondřej Jirman wrote:
On Wed, Jul 17, 2024 at 08:48:29AM GMT, Dragan Simic wrote:
Hello all,
On 2024-07-17 08:29, Dragan Simic wrote:
> From: Ondrej Jirman
>
> After a suspend and resume cycle, ISP1 stops receiving data, as observed
> on the Pine
Hello all,
On 2024-07-17 08:29, Dragan Simic wrote:
From: Ondrej Jirman
After a suspend and resume cycle, ISP1 stops receiving data, as
observed
on the Pine64 PinePhone Pro, which is based on the Rockchip RK3399 SoC.
Re-initializing DPHY during the PHY power-on, if the SoC variant
supports
details to the commit summary and description ]
Signed-off-by: Ondrej Jirman
Signed-off-by: Dragan Simic
---
drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c
b/drivers/gpu/drm/rockchip/dw
Hello Maxime,
On 2024-07-10 09:13, Maxime Ripard wrote:
On Tue, Jul 09, 2024 at 06:36:08PM GMT, Dragan Simic wrote:
> > > > As I already wrote earlier, and as the above-linked discussions
> > > > conclude, solving these issues doesn't belong to any specific
Hello Maxime,
On 2024-07-09 13:09, Maxime Ripard wrote:
On Tue, Jul 09, 2024 at 12:10:51PM GMT, Dragan Simic wrote:
On 2024-07-09 11:10, Andy Yan wrote:
> At 2024-07-09 16:17:06, "Dragan Simic" wrote:
> > On 2024-07-08 09:46, Andy Yan wrote:
> > > At 2024-07-04 18:
Hello Andy,
On 2024-07-09 12:46, Andy Yan wrote:
At 2024-07-09 18:10:51, "Dragan Simic" wrote:
On 2024-07-09 11:10, Andy Yan wrote:
At 2024-07-09 16:17:06, "Dragan Simic" wrote:
On 2024-07-08 09:46, Andy Yan wrote:
At 2024-07-04 18:35:42, "Dragan Simic" wro
On 2024-07-09 11:10, Andy Yan wrote:
At 2024-07-09 16:17:06, "Dragan Simic" wrote:
On 2024-07-08 09:46, Andy Yan wrote:
At 2024-07-04 18:35:42, "Dragan Simic" wrote:
On 2024-07-04 04:10, Andy Yan wrote:
At 2024-07-04 07:32:02, "Dragan Simic" wrote:
After t
Hello Andy,
On 2024-07-08 09:46, Andy Yan wrote:
At 2024-07-04 18:35:42, "Dragan Simic" wrote:
On 2024-07-04 04:10, Andy Yan wrote:
At 2024-07-04 07:32:02, "Dragan Simic" wrote:
After the additional firmware-related module information was
introduced by
the commi
Hello Andy,
On 2024-07-04 04:10, Andy Yan wrote:
At 2024-07-04 07:32:02, "Dragan Simic" wrote:
After the additional firmware-related module information was
introduced by
the commit c0677e41a47f ("drm/rockchip: cdn-dp-core: add
MODULE_FIRMWARE
macro"), there's no lon
.
Signed-off-by: Dragan Simic
---
drivers/gpu/drm/rockchip/cdn-dp-core.c | 16 +++-
1 file changed, 7 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.c
b/drivers/gpu/drm/rockchip/cdn-dp-core.c
index bd7aa891b839..ee9def197095 100644
--- a/drivers/gpu/drm
ware blob being present in the generated initial ramdisks.
Signed-off-by: Dragan Simic
---
drivers/gpu/drm/rockchip/cdn-dp-core.c | 53 +-
1 file changed, 10 insertions(+), 43 deletions(-)
diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.c
b/drivers/gpu/drm/rockchip/cdn-
On 2024-07-03 15:20, Steven Price wrote:
On 03/07/2024 13:42, Dragan Simic wrote:
On 2024-06-17 22:17, Dragan Simic wrote:
Panfrost DRM driver uses devfreq to perform DVFS, while using
simple_ondemand
devfreq governor by default. This causes driver initialization to
fail on
boot when
On 2024-07-03 15:20, Boris Brezillon wrote:
On Wed, 03 Jul 2024 14:42:37 +0200
Dragan Simic wrote:
On 2024-06-17 22:17, Dragan Simic wrote:
> Panfrost DRM driver uses devfreq to perform DVFS, while using
> simple_ondemand
> devfreq governor by default. This causes driver initiali
Hello everyone,
On 2024-06-17 22:17, Dragan Simic wrote:
Panfrost DRM driver uses devfreq to perform DVFS, while using
simple_ondemand
devfreq governor by default. This causes driver initialization to fail
on
boot when simple_ondemand governor isn't built into the kernel
statically,
Hello Qiang,
On 2024-06-26 03:11, Qiang Yu wrote:
On Wed, Jun 26, 2024 at 2:15 AM Dragan Simic
wrote:
Hello everyone,
Just checking, any further thoughts about this patch?
I'm OK with this as a temp workaround because it's simple and do no
harm
even it's not perfect. If
Hello everyone,
Just checking, any further thoughts about this patch?
On 2024-06-18 21:22, Dragan Simic wrote:
On 2024-06-18 12:33, Dragan Simic wrote:
On 2024-06-18 10:13, Maxime Ripard wrote:
On Tue, Jun 18, 2024 at 04:01:26PM GMT, Qiang Yu wrote:
On Tue, Jun 18, 2024 at 12:33 PM Qiang Yu
On 2024-06-18 12:33, Dragan Simic wrote:
Hello Qiang and Maxime,
On 2024-06-18 10:13, Maxime Ripard wrote:
On Tue, Jun 18, 2024 at 04:01:26PM GMT, Qiang Yu wrote:
On Tue, Jun 18, 2024 at 12:33 PM Qiang Yu wrote:
>
> I see the problem that initramfs need to build a module dependency
Hello Qiang and Maxime,
On 2024-06-18 10:13, Maxime Ripard wrote:
On Tue, Jun 18, 2024 at 04:01:26PM GMT, Qiang Yu wrote:
On Tue, Jun 18, 2024 at 12:33 PM Qiang Yu wrote:
>
> I see the problem that initramfs need to build a module dependency chain,
> but lima does not call any symbol from simp
On 2024-06-17 22:50, Jonas Karlman wrote:
On 2024-06-17 22:30, Heiko Stübner wrote:
Am Samstag, 15. Juni 2024, 19:03:53 CEST schrieb Jonas Karlman:
Similar to DCLK_LCDC on RK3328, the DCLK_VOP on RK3228 is typically
parented by the hdmiphy clk and it is expected that the DCLK_VOP and
hdmiphy cl
ernel.org
Fixes: 1996970773a3 ("drm/lima: Add optional devfreq and cooling device
support")
Signed-off-by: Dragan Simic
---
drivers/gpu/drm/lima/lima_drv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/lima/lima_drv.c b/drivers/gpu/drm/lima/lima_drv.c
index 739c865b556f..
de Haas
Cc: Furkan Kardame
Cc: sta...@vger.kernel.org
Fixes: f3ba91228e8e ("drm/panfrost: Add initial panfrost driver")
Signed-off-by: Dragan Simic
---
drivers/gpu/drm/panfrost/panfrost_drv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/panfrost/panfrost_drv
On 2023-10-16 17:52, Chris Morgan wrote:
Confirmed that those pending patches DO fix the panel suspend issues.
Thank you.
Awesome, that's great to hear! Perhaps a "Tested-by" in the original
LKML thread [1] could help with having the patch pulled sooner.
Links:
[1]
https://lore.kernel.org/
42 matches
Mail list logo
