On 2025-07-15 6:59 p.m., Dan Carpenter wrote:
Hello Zhanjun Dong,
Commit b2c4ac219fa4 ("drm/xe/uc: Disable GuC communication on
hardware initialization error") from Jul 7, 2025 (linux-next), leads
to the following Smatch static checker warning:
drivers/gpu/drm/xe/xe_uc.c:167 vf_uc_lo
LGTM
Reviewed-by: Zhanjun Dong
On 2025-02-13 2:51 p.m., Alan Previn wrote:
GuC-Err-Capture should not be storing register snapshot
nodes directly inside of the top level xe_devcoredump_snapshot
structure that it doesn't control. Furthermore, that is
is not right from a driver subsystem layering
If rename is the only change in next revision, that's fine to me.
Reviewed-by: Zhanjun Dong
On 2025-02-11 12:34 p.m., Teres Alexis, Alan Previn wrote:
On Mon, 2025-02-10 at 15:32 -0800, Teres Alexis, Alan Previn wrote:
xe_hw_engine_print is called by debugfs to do an immediate raw
--- a/drive
LGTM
Reviewed-by: Zhanjun Dong
On 2025-02-10 6:32 p.m., Alan Previn wrote:
xe_devcoredump calls xe_engine_snapshot_capture_for_queue() to allocate
and populate the xe_hw_engine_snapshot structure. Move that function
back into xe_hw_engine.c since it doesn't make sense for
GuC-Err-Capture to all
On 2025-02-10 6:32 p.m., Alan Previn wrote:
Update the comments on GuC-Err-Capture flows with the
updated function names.
Signed-off-by: Alan Previn
---
drivers/gpu/drm/xe/xe_guc_capture.c | 19 +++
1 file changed, 11 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu
On 2025-02-10 6:32 p.m., Alan Previn wrote:
Relocate the xe_engine_snapshot_print function from xe_guc_capture.c
into xe_hw_engine.c but split out the GuC-Err-Capture register printing
portion out into a separate helper inside xe_guc_capture.c so that
we can have a clear separation between pri
See my comments inline below.
Regards,
Zhanjun Dong
On 2025-01-28 1:36 p.m., Alan Previn wrote:
GuC-Err-Capture should not be storing register snapshot
nodes directly inside of the top level xe_devcoredump_snapshot
structure that it doesn't control. Furthermore, that is
is not right from a driv
LGTM
Reviewed-by: Zhanjun Dong
Regards,
Zhanjun Dong
On 2025-01-28 1:36 p.m., Alan Previn wrote:
Since '__guc_capture_parsed_output *' is a handle that
is retrieved, stored and relinquished by an entity
external to GuC (i.e. xe_devcoredump), lets rename it to
something formal without the'__'
On 2025-02-03 8:29 a.m., Andi Shyti wrote:
Hi,
Please, next time, do not remove the mailing and the other folks
you cc'ed.
I'm adding back the mailing list and Daniele who has commented
before.
Thanks, I also found my previous response click on "reply", not the
"reply all".
...
Clos
Just found my previous response click on "reply", not the "reply all",
so add Cc list.
Regards,
Zhanjun Dong
Forwarded Message
Subject: Re: [PATCH v1] drm/i915/guc: Always disable interrupt ahead of
synchronize_irq
Date: Mon, 27 Jan 2025 17:17:33 -0500
LGTM
Reviewed-by: Zhanjun Dong
*Previous RB send to coverletter, resend to the patch itself.
Regards,
Zhanjun Dong
On 2024-12-03 12:47 p.m., Alan Previn wrote:
The order of the devcoredump event flow is:
drm-scheduler -> guc-submission-execq-timed-out-job ->
guc-submission-kill-job -> xe-dev
LGTM
Reviewed-by: Zhanjun Dong
On 2024-12-03 12:47 p.m., Alan Previn wrote:
The GuC-Error-Capture is currently reaching into xe_devcoredump
structure to store its own place-holder snaphot to workaround
the race between G2H-Error-Capture-Notification vs Drm-Scheduler
triggering GuC-Submission-e
See my comments inline below:
Regards,
Zhanjun
On 2024-11-17 1:44 p.m., Alan Previn wrote:
The order of the devcoredump event flow is:
drm-scheduler -> guc-submission-execq-timed-out-job ->
guc-submission-kill-job -> xe-devcoredump (once the work
is confirmed to have been killed).
As we are aw
On 2024-11-04 6:20 p.m., Daniele Ceraolo Spurio wrote:
On 10/30/2024 3:38 PM, Zhanjun Dong wrote:
GuC to host communication is interrupt driven, the handling has 3
parts: interrupt context, tasklet and request queue worker.
During GuC reset prepare, interrupt is disabled before destroy
con
Basically follows i915 design
. Sysfs command process.
Xe switched to devcoredump, adopted command line process with
captured list.
Signed-off-by: Zhanjun Dong
Zhanjun Dong (9):
drm/xe/guc: Add register defines for GuC based register capture
drm/xe/guc: Expose dss per group for
On 2023-10-31 5:38 p.m., Teres Alexis, Alan Previn wrote:
On Fri, 2023-10-27 at 10:13 +0300, Jani Nikula wrote:
On Thu, 26 Oct 2023, Zhanjun Dong wrote:
alan:snip
I'll note that nobody checks intel_pxp_init() return status, so this
silently skips PXP.
BR,
Jani.
alan:snip
+ if (inte
See comments inline below.
Zhanjun
On 2023-09-22 6:25 p.m., john.c.harri...@intel.com wrote:
From: Umesh Nerlige Ramappa
In new version of GuC engine busyness, GuC provides engine busyness
ticks as a 64 bit counter. Add a new counter to relay this value to the
user as is.
Signed-off-by: Umes
> -Original Message-
> From: Daniel Vetter
> Sent: August 22, 2023 9:51 AM
> To: Dong, Zhanjun
> Cc: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org;
> Harrison,
> John C ; Andi Shyti ;
> Daniel Vetter
> Subject: Re: [PATCH v5] drm/i
Hi Daniel,
On 2023-08-03 9:03 a.m., Daniel Vetter wrote:
On Thu, 27 Jul 2023 at 22:13, Zhanjun Dong wrote:
This attempts to avoid circular locking dependency between flush delayed work
and intel_gt_reset.
Switched from cancel_delayed_work_sync to cancel_delayed_work, the non-sync
version f
Hi Andi,
On 2023-08-03 8:36 a.m., Andi Shyti wrote:
Hi Zhanjun,
On Thu, Jul 27, 2023 at 01:13:23PM -0700, Zhanjun Dong wrote:
This attempts to avoid circular locking dependency between flush delayed work
and intel_gt_reset.
Switched from cancel_delayed_work_sync to cancel_delayed_work, the n
Hi Fei,
Thanks for review. I put my answers inline below.
Regards,
Zhanjun
On 2023-06-22 6:20 p.m., Yang, Fei wrote:
> The previouse i915_gem_object_create_internal already set it with
proper
> value before function return. This hard coded setting is incorrect for
> platforms like MTL, thus
Resend to restart the CI,
https://patchwork.freedesktop.org/series/119485/
Was stuck.
Regards,
Zhanjun
On 2023-06-22 11:26 a.m., Zhanjun Dong wrote:
The previouse i915_gem_object_create_internal already set it with proper
value before function return. This hard coded setting is incorrect fo
V3 is to follow John's suggestion option 1. The better option is in
discussion and might have boarder impact.
Meanwhile we can start with option 1, check CI system report and see if
issue getting better.
Regards,
Zhanjun Dong
On 2023-06-15 5:15 p.m., Zhanjun Dong wrote:
This attempts to a
ore before moving forward.
Regards,
Zhanjun Dong
From: Harrison, John C
Sent: June 7, 2023 4:17 PM
To: Dong, Zhanjun ; intel-...@lists.freedesktop.org;
dri-devel@lists.freedesktop.org; Nerlige Ramappa, Umesh
; Ceraolo Spurio, Daniele
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Avoid circul
Hi Andi,
Thanks for comments. Info would be updated on next revision, which is on
the way.
Regards,
Zhanjun Dong
On 2023-06-07 8:19 p.m., Andi Shyti wrote:
Hi Dong,
On Wed, Jun 07, 2023 at 12:03:50PM -0700, Zhanjun Dong wrote:
This attempts to avoid circular locking dependency between flu
> -Original Message-
> From: Teres Alexis, Alan Previn
> Sent: June 8, 2023 2:31 PM
> To: Dong, Zhanjun ; intel-
> g...@lists.freedesktop.org
> Cc: dri-devel@lists.freedesktop.org
> Subject: Re: [v2] drm/i915/selftest/gsc: Ensure GSC Proxy init completes
> befo
See my comments below.
> -Original Message-
> From: Alan Previn
> Sent: May 30, 2023 1:01 PM
> To: intel-...@lists.freedesktop.org
> Cc: dri-devel@lists.freedesktop.org; Alan Previn
>
> Subject: [v2] drm/i915/selftest/gsc: Ensure GSC Proxy init completes before
> selftests
>
> On MTL, i
Thanks Jani.
Updated patch sent, let me know if you have any comments.
Regards,
Zhanjun
> -Original Message-
> From: Jani Nikula
> Sent: February 27, 2023 6:30 AM
> To: Dong, Zhanjun ; intel-
> g...@lists.freedesktop.org; dri-devel@lists.freedesktop.org
> Cc: Dong,
> -Original Message-
> From: Dixit, Ashutosh
> Sent: July 12, 2022 3:48 PM
> To: Dong, Zhanjun
> Cc: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org
> Subject: Re: [Intel-gfx] [PATCH] drm/i915/guc: Check for ct enabled while
> waiting for respons
Thanks for all comments, I will update code and prepare for next version.
Regards,
Zhanjun
-Original Message-
From: Dixit, Ashutosh
Sent: June 14, 2022 12:28 PM
To: Dong, Zhanjun
Cc: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; Teres
Alexis, Alan Previn
30 matches
Mail list logo
