[PATCH v2] drm/bridge: imx8mp-hdmi-tx: allow 0.5% margin with selected clock

2024-09-07 Thread Dominique Martinet
From: Dominique Martinet This allows the hdmi driver to pick e.g. 64.8MHz instead of 65Mhz when we cannot output the exact frequency, enabling the imx8mp HDMI output to support more modes Tested-by: Adam Ford #imx8mp-beacon Reviewed-by: Frieder Schrempf Tested-by: Frieder Schrempf Signed-off

[PATCH] drm/bridge: imx8mp-hdmi-tx: allow 0.5% margin with selected clock

2024-09-04 Thread Dominique Martinet
This allows the hdmi driver to pick e.g. 64.8MHz instead of 65Mhz when we cannot output the exact frequency, enabling the imx8mp HDMI output to support more modes Signed-off-by: Dominique Martinet --- This completes the patch series sent by Adam Ford here: https://lkml.kernel.org/r

Re: drm/bridge/imx8mp-hdmi-tx: Allow inexact pixel clock frequencies (Was: [PATCH V8 10/12] drm/bridge: imx: add bridge wrapper driver for i.MX8MP DWC HDMI)

2024-08-27 Thread Dominique MARTINET
Frieder Schrempf wrote on Tue, Aug 27, 2024 at 09:00:34AM +0200: > > Using my PMS calculator and Rev 2 of the Tech Ref Manual, I think I > > can generate you a table entry for 51.2MHz. I don't have the ability > > to test it. I am still working on figuring out an algorithm to > > calculate the fr

Re: drm/bridge/imx8mp-hdmi-tx: Allow inexact pixel clock frequencies (Was: [PATCH V8 10/12] drm/bridge: imx: add bridge wrapper driver for i.MX8MP DWC HDMI)

2024-08-20 Thread Dominique MARTINET
Adam Ford wrote on Tue, Aug 20, 2024 at 09:49:03PM -0500: > > > However, this check is a bit overcautious in that it only allows exact > > > rate matches. IIRC HDMI allows a rate mismatch of +- 0.5%, so this > > > check could be relaxed quite a bit to allow for that. > > > > I checked with a 1080p

Re: drm/bridge/imx8mp-hdmi-tx: Allow inexact pixel clock frequencies (Was: [PATCH V8 10/12] drm/bridge: imx: add bridge wrapper driver for i.MX8MP DWC HDMI)

2024-06-17 Thread Dominique MARTINET
Dominique MARTINET wrote on Tue, Jun 18, 2024 at 08:45:38AM +0900: > I'm thinking the last few values just affect a very small % of the > values, but would need to check with a proper scope if I can get a hold > of the clock line... > Does any of you happen to have any da

Re: drm/bridge/imx8mp-hdmi-tx: Allow inexact pixel clock frequencies (Was: [PATCH V8 10/12] drm/bridge: imx: add bridge wrapper driver for i.MX8MP DWC HDMI)

2024-06-17 Thread Dominique MARTINET
Thanks for the replies, replying to both mails at once. Adam Ford wrote on Mon, Jun 17, 2024 at 08:28:58AM -0500: > > Commit 6ad082bee902 ("phy: freescale: add Samsung HDMI PHY") already > > "fixed" the samsung hdmi phy driver to return the next frequency if an > > exact match hasn't been found (N

drm/bridge/imx8mp-hdmi-tx: Allow inexact pixel clock frequencies (Was: [PATCH V8 10/12] drm/bridge: imx: add bridge wrapper driver for i.MX8MP DWC HDMI)

2024-06-16 Thread Dominique MARTINET
0, 0. White: 0., 0. Established Timings I & II: none Standard Timings: none Detailed Timing Descriptors: DTD 1: 1024x60059.993 Hz 128:75 38.095 kHz 51.200 MHz (154 mm x 86 m m) Hfront 160 Hsync 32 Hback 128 Hpol N Vfront 12 Vsync 8 Vback 15 Vpol N Dummy Descriptor: Dummy Descriptor: Dummy Descriptor: Checksum: 0x9a --- Thanks, -- Dominique Martinet

Re: [PATCH 6/6] treewide: remove check of list iterator against head past the loop body

2022-02-28 Thread Dominique Martinet
c| 11 +++-- This 9p change looks good to me. Reviewed-by: Dominique Martinet # 9p -- Dominique

Re: [RFC v1 PATCH 3/3] driver: update all the code that use soc_device_match

2021-04-19 Thread Dominique MARTINET
Arnd Bergmann wrote on Mon, Apr 19, 2021 at 02:16:36PM +0200: > In some cases, you can use the device_link infrastructure to deal > with dependencies between devices. Not sure if this would help > in your case, but have a look at device_link_add() etc in drivers/base/core.c I'll need to actually t

Re: [RFC v1 PATCH 3/3] driver: update all the code that use soc_device_match

2021-04-19 Thread Dominique MARTINET
Geert Uytterhoeven wrote on Mon, Apr 19, 2021 at 11:03:24AM +0200: > > This is going to need quite some more work to be acceptable, in my > > opinion, but I think it should be possible. > > In general, this is very hard to do, IMHO. Some drivers may be used on > multiple platforms, some of them

Re: [RFC v1 PATCH 3/3] driver: update all the code that use soc_device_match

2021-04-18 Thread Dominique MARTINET
Alice Guo (OSS) wrote on Mon, Apr 19, 2021 at 12:27:22PM +0800: > From: Alice Guo > > Update all the code that use soc_device_match A single patch might be difficult to accept for all components, a each maintainer will probably want to have a say on their subsystem? I would suggest to split the

Re: [RFC v1 PATCH 1/3] drivers: soc: add support for soc_device_match returning -EPROBE_DEFER

2021-04-18 Thread Dominique MARTINET
First comment overall for the whole serie: Since it is the solution I had suggested when I reported the problem[1] I have no qualm on the approach, comments for individual patches follow. [1] http://lore.kernel.org/r/YGGZJjAxA1IO+/v...@atmark-techno.com Alice Guo (OSS) wrote on Mon, Apr 19, 2021

Re: [Intel-gfx] [PATCH] i915/intel_tv_get_modes: fix strncpy truncation warning

2018-07-13 Thread Dominique Martinet
Ville Syrjälä wrote on Thu, Jul 12, 2018: > On Thu, Jul 12, 2018 at 03:55:26PM +0200, Dominique Martinet wrote: > > This could either be 'this commit' as a whole or if you look only at the > > commit message 'this strncpy fix' from the title (which

Re: [Intel-gfx] [PATCH] i915/intel_tv_get_modes: fix strncpy truncation warning

2018-07-13 Thread Dominique Martinet
Ville Syrjälä wrote on Thu, Jul 12, 2018: > On Wed, Jul 11, 2018 at 09:46:15AM +0200, Dominique Martinet wrote: > > This is effectively no-op as the next line writes a nul at the final > > What is "This". Please write self contained commit messages. This could either be

[PATCH 03/18] drm_property: change strncpy+truncation to strlcpy

2018-07-13 Thread Dominique Martinet
LEN); ^~~~ Generated by scripts/coccinelle/misc/strncpy_truncation.cocci Signed-off-by: Dominique Martinet --- Please see https://marc.info/?l=linux-kernel&m=153144450722324&w=2 (the first patch of the serie) for the motivation behind

[PATCH 04/18] nouveau: change strncpy+truncation to strlcpy

2018-07-13 Thread Dominique Martinet
Generated by scripts/coccinelle/misc/strncpy_truncation.cocci Signed-off-by: Dominique Martinet --- Please see https://marc.info/?l=linux-kernel&m=153144450722324&w=2 (the first patch of the serie) for the motivation behind this patch drivers/gpu/drm/nouveau/nvkm/core/firmware.c |

[PATCH v2] i915/intel_tv_get_modes: fix strncpy truncation warning

2018-07-12 Thread Dominique Martinet
Change it to use strlcpy instead Signed-off-by: Dominique Martinet --- drivers/gpu/drm/i915/intel_tv.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_tv.c b/drivers/gpu/drm/i915/intel_tv.c index b55b5c157e38..25fee7dba7e2 100644 --- a/drivers

[PATCH] i915/intel_tv_get_modes: fix strncpy truncation warning

2018-07-12 Thread Dominique Martinet
This is effectively no-op as the next line writes a nul at the final byte of the buffer, so copying one letter less does not change the behaviour. Signed-off-by: Dominique Martinet --- gcc 8 gives the following warning, which I am not sure why is treated as error for this file, thus making me