[PATCH] vmwgfx: add missing mutex_unlocks

2012-08-06 Thread Devendra Naga
ry more reading and analyse the code and then send patch if it needs really. > /Thomas > > > > > On 08/04/2012 07:33 AM, Devendra Naga wrote: >> >> we have done a proper mutex_unlock in the error cases of the >> vmw_fifo_reserve, but >> there are

Re: [PATCH] vmwgfx: add missing mutex_unlocks

2012-08-06 Thread Devendra Naga
ry more reading and analyse the code and then send patch if it needs really. > /Thomas > > > > > On 08/04/2012 07:33 AM, Devendra Naga wrote: >> >> we have done a proper mutex_unlock in the error cases of the >> vmw_fifo_reserve, but >> there are

[PATCH] vmwgfx: add missing mutex_unlocks

2012-08-05 Thread Devendra Naga
we have done a proper mutex_unlock in the error cases of the vmw_fifo_reserve, but there are missing mutex unlocks where we return a valid pointer in vmw_fifo_reserve. Signed-off-by: Devendra Naga --- drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c |7 +-- 1 file changed, 5 insertions(+), 2

[PATCH] vmwgfx: add missing mutex_unlocks

2012-08-04 Thread Devendra Naga
we have done a proper mutex_unlock in the error cases of the vmw_fifo_reserve, but there are missing mutex unlocks where we return a valid pointer in vmw_fifo_reserve. Signed-off-by: Devendra Naga --- drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c |7 +-- 1 file changed, 5 insertions(+), 2

[PATCH] drm/i915: remove unused variable

2012-07-29 Thread Devendra Naga
the following warning was produced, drivers/gpu/drm/i915/i915_gem_context.c: In function ‘i915_switch_context’: drivers/gpu/drm/i915/i915_gem_context.c:454:6: warning: unused variable ‘ret’ [-Wunused-variable] fix up by removing it Signed-off-by: Devendra Naga --- This warning occurs in

[PATCH] drm/i915: remove unused variable

2012-07-28 Thread Devendra Naga
the following warning was produced, drivers/gpu/drm/i915/i915_gem_context.c: In function ?i915_switch_context?: drivers/gpu/drm/i915/i915_gem_context.c:454:6: warning: unused variable ?ret? [-Wunused-variable] fix up by removing it Signed-off-by: Devendra Naga --- This warning occurs in

[PATCH] drm/mgag200: fix null pointer dereference

2012-07-07 Thread Devendra Naga
we are referencing the pointer after doing alloc_apertures, as alloc_apertures kzallocs, the kzalloc may fail and we get a NULL. so we need to check for NULL before we dereference this pointer Signed-off-by: Devendra Naga --- drivers/gpu/drm/mgag200/mgag200_drv.c |3 +++ 1 file changed, 3

[PATCH] drm/mgag200: fix null pointer dereference

2012-07-07 Thread Devendra Naga
we are referencing the pointer after doing alloc_apertures, as alloc_apertures kzallocs, the kzalloc may fail and we get a NULL. so we need to check for NULL before we dereference this pointer Signed-off-by: Devendra Naga --- drivers/gpu/drm/mgag200/mgag200_drv.c |3 +++ 1 file changed, 3