[PATCH] dt-bindings: display: convert sitronix,st7586 to YAML

2025-05-30 Thread David Lechner
Convert the sitronix,st7586 binding documentation from .txt to .yaml. Also added a link to the datasheet while we are touching this. Signed-off-by: David Lechner --- .../bindings/display/sitronix,st7586.txt | 22 .../bindings/display/sitronix,st7586.yaml | 61

Re: [PATCH] drm/tiny: Add driver for displays with ST7365P controller

2025-04-30 Thread David Lechner
On 4/30/25 8:17 AM, Josef Lusticky wrote: > The driver supports 3.5" Kingway HW-035P0Z002 display found > on Braiins Mini Miner BMM 101 product. > > Signed-off-by: Josef Lusticky > --- I haven't really looked at the patch yet, but what about this display makes it not compatible with "panel-mipi-

Re: [PATCH-resent-to-correct-ml 0/8] drm/xe: Convert xe_force_wake calls to guard helpers.

2025-02-04 Thread David Lechner
On 2/4/25 7:22 AM, Maarten Lankhorst wrote: > Ignore my previous series please, it should have been sent to intel-xe, was > sent to intel-gfx. > > Instead of all this repetition of > > { > unsigned fw_ref; > > fw_ref = xe_force_wake_get(fw, domain); > if (!xe_force_wake_ref_ha

Re: [PATCH v2 16/86] drm/ili9225: Run DRM default client setup

2024-08-21 Thread David Lechner
On 8/21/24 7:59 AM, Thomas Zimmermann wrote: > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > Signed-off-by: Thomas Zimmermann > Cc: David L

Re: [PATCH v2 45/86] drm/st7735r: Run DRM default client setup

2024-08-21 Thread David Lechner
On 8/21/24 7:59 AM, Thomas Zimmermann wrote: > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > Signed-off-by: Thomas Zimmermann > Cc: David L

Re: [PATCH v2 44/86] drm/st7586: Run DRM default client setup

2024-08-21 Thread David Lechner
On 8/21/24 7:59 AM, Thomas Zimmermann wrote: > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > Signed-off-by: Thomas Zimmermann > Cc: David L

Re: [RFC PATCH] drm/tiny: Add support for Sitronix ST7539

2024-07-03 Thread David Lechner
On 7/3/24 9:05 AM, Christian Eggers wrote: > Based on the existing ST7586 driver. But the ST7539 ... > - is monochrome only > - has 8 VERTICAL pixels per byte > - doesn't support any MIPI DCS commands > - has (a few) 16 bit commands > - doesn't support setting a clipping rect when writing to the RA

Re: [PATCH 4/4] drm/tiny: st7586: drop driver owner assignment

2024-03-27 Thread David Lechner
On 3/27/24 12:48 PM, Krzysztof Kozlowski wrote: > Core in spi_register_driver() already sets the .owner, so driver > does not need to. > > Signed-off-by: Krzysztof Kozlowski > --- Acked-by: David Lechner

Re: [PATCH 1/4] drm/tiny: ili9225: drop driver owner assignment

2024-03-27 Thread David Lechner
On 3/27/24 12:48 PM, Krzysztof Kozlowski wrote: > Core in spi_register_driver() already sets the .owner, so driver > does not need to. > > Signed-off-by: Krzysztof Kozlowski > --- Acked-by: David Lechner

Re: [PATCH 41/43] drm/tiny/st7735r: Use fbdev-dma

2024-03-12 Thread David Lechner
mas Zimmermann > Cc: David Lechner > --- Acked-by: David Lechner

Re: [PATCH 34/43] drm/tiny/ili9225: Use fbdev-dma

2024-03-12 Thread David Lechner
mas Zimmermann > Cc: David Lechner > --- Acked-by: David Lechner

Re: [PATCH 40/43] drm/tiny/st7586: Use fbdev-dma

2024-03-12 Thread David Lechner
mas Zimmermann > Cc: David Lechner > --- Acked-by: David Lechner

Re: [PATCH] dt-bindings: display: remove backlight node from panel examples

2023-10-11 Thread David Lechner
/20230724143152.ga3430423-r...@kernel.org/ Suggested-by: Rob Herring Signed-off-by: Luca Ceresoli --- Acked-by: David Lechner

Re: [PATCH 0/2] Add st7735s drm driver and Winstar panel

2023-09-07 Thread David Lechner
On 9/6/23 11:22 AM, Stefan x Nilsson wrote: Add a new driver for the Sitronix st7735s display controller together with a 0.96" 80x160 color TFT display by Winstar. The driver is very similar to the st7735r driver, but uses a different pipe_enable sequence and also allows for an optional regulato

Re: [PATCH v3 1/2] drm/mipi-dbi: Lock SPI bus before setting D/C GPIO

2023-07-24 Thread David Lechner
: David Lechner

Re: [PATCH v3 54/65] clk: da8xx: clk48: Switch to determine_rate

2023-04-05 Thread David Lechner
On 4/5/23 10:22 AM, Maxime Ripard wrote: Hi David, On Wed, Apr 05, 2023 at 10:03:24AM -0500, David Lechner wrote: On 4/4/23 5:11 AM, Maxime Ripard wrote: The TI DA8xx USB0 clk48 clocks implements a mux with a set_parent hook, but doesn't provide a determine_rate implementation. This is

Re: [PATCH v3 54/65] clk: da8xx: clk48: Switch to determine_rate

2023-04-05 Thread David Lechner
On 4/4/23 5:11 AM, Maxime Ripard wrote: The TI DA8xx USB0 clk48 clocks implements a mux with a set_parent hook, but doesn't provide a determine_rate implementation. This is a bit odd, since set_parent() is there to, as its name implies, change the parent of a clock. However, the most likely cand

Re: [PATCH v3 21/65] clk: davinci: da8xx-cfgchip: Add a determine_rate hook

2023-04-05 Thread David Lechner
On 4/4/23 5:11 AM, Maxime Ripard wrote: The Davinci DA8xxx cfgchip mux clock implements a mux with a set_parent hook, but doesn't provide a determine_rate implementation. This is a bit odd, since set_parent() is there to, as its name implies, change the parent of a clock. However, the most likel

Re: [PATCH v3 22/65] clk: davinci: da8xx-cfgchip: Add a determine_rate hook

2023-04-05 Thread David Lechner
On 4/4/23 5:11 AM, Maxime Ripard wrote: The Davinci DA8xxx cfgchip "clk48" clock implements a mux with a set_parent hook, but doesn't provide a determine_rate implementation. This is a bit odd, since set_parent() is there to, as its name implies, change the parent of a clock. However, the most l

Re: [PATCH v2 21/65] clk: davinci: da8xx-cfgchip: Add a determine_rate hook

2022-11-07 Thread David Lechner
On 11/7/22 6:06 AM, Maxime Ripard wrote: Hi David, On Fri, Nov 04, 2022 at 11:45:17AM -0500, David Lechner wrote: On 11/4/22 8:17 AM, Maxime Ripard wrote: The Davinci DA8xxx cfgchip mux clock implements a mux with a set_parent hook, but doesn't provide a determine_rate implementation.

Re: [PATCH v2 22/65] clk: davinci: da8xx-cfgchip: Add a determine_rate hook

2022-11-04 Thread David Lechner
On 11/4/22 8:17 AM, Maxime Ripard wrote: The Davinci DA8xxx cfgchip "clk48" clock implements a mux with a set_parent hook, but doesn't provide a determine_rate implementation. This is a bit odd, since set_parent() is there to, as its name implies, change the parent of a clock. However, the most

Re: [PATCH v2 54/65] clk: da8xx: clk48: Switch to determine_rate

2022-11-04 Thread David Lechner
On 11/4/22 8:18 AM, Maxime Ripard wrote: The TI DA8xx USB0 clk48 clocks implements a mux with a set_parent hook, but doesn't provide a determine_rate implementation. This is a bit odd, since set_parent() is there to, as its name implies, change the parent of a clock. However, the most likely can

Re: [PATCH v2 21/65] clk: davinci: da8xx-cfgchip: Add a determine_rate hook

2022-11-04 Thread David Lechner
On 11/4/22 8:17 AM, Maxime Ripard wrote: The Davinci DA8xxx cfgchip mux clock implements a mux with a set_parent hook, but doesn't provide a determine_rate implementation. This is a bit odd, since set_parent() is there to, as its name implies, change the parent of a clock. However, the most like

Re: [PATCH] drm/st7735r: Fix module autoloading for Okaya RH128128T

2022-05-20 Thread David Lechner
H128128T") Signed-off-by: Javier Martinez Canillas --- Acked-by: David Lechner

Re: [PATCH v2 0/3] drm/panel: Add MIPI DBI compatible SPI driver

2022-01-27 Thread David Lechner
On 1/25/22 11:56 AM, Noralf Trønnes wrote: Hi, This patchset adds a driver that will work with most MIPI DBI compatible SPI panels out there. It's a follow up on 'drm/tiny/st7735r: Match up with staging/fbtft driver'[1] which aimed at making the st7735r driver work with all panels adding DT pro

Re: [PATCH v2 3/3] drm/panel: Add MIPI DBI compatible SPI driver

2022-01-27 Thread David Lechner
On 1/25/22 11:57 AM, Noralf Trønnes wrote: Add a driver that will work with most MIPI DBI compatible SPI panels. This avoids adding a driver for every new MIPI DBI compatible controller that is to be used by Linux. The 'compatible' Device Tree property with a '.bin' suffix will be used to load a

Re: [PATCH 0/6] drm/tiny/st7735r: Match up with staging/fbtft driver

2021-12-06 Thread David Lechner
On 12/1/21 8:52 AM, Maxime Ripard wrote: Hi Noralf, On Tue, Nov 30, 2021 at 03:30:11PM +0100, Noralf Trønnes wrote: Den 29.11.2021 10.39, skrev Maxime Ripard: On Wed, Nov 24, 2021 at 04:03:07PM -0600, David Lechner wrote: On 11/24/21 9:07 AM, Noralf Trønnes wrote: I agree that it doesn&#

Re: [PATCH 3/6] dt-bindings: display: sitronix,st7735r: Remove spi-max-frequency limit

2021-12-06 Thread David Lechner
ver driver that runs configuration commands at a low speed and only the pixel data at the maximum speed the configuration can't be messed up by transfer errors and the speed is only limited by the amount of pixel glitches that one is able to tolerate. Signed-off-by: Noralf Trønnes --- Acked-by: David Lechner

Re: [PATCH 2/6] dt-bindings: display: sitronix,st7735r: Make reset-gpios optional

2021-12-06 Thread David Lechner
On 11/24/21 9:07 AM, Noralf Trønnes wrote: There are other ways than using a gpio to reset the controller so make this property optional. Signed-off-by: Noralf Trønnes --- Acked-by: David Lechner

Re: [PATCH 1/6] dt-bindings: display: sitronix, st7735r: Fix backlight in example

2021-12-06 Thread David Lechner
schema") Signed-off-by: Noralf Trønnes --- Acked-by: David Lechner

Re: [PATCH 0/6] drm/tiny/st7735r: Match up with staging/fbtft driver

2021-11-24 Thread David Lechner
On 11/24/21 9:07 AM, Noralf Trønnes wrote: Hi, This patchset adds a missing piece for decommissioning the staging/fbtft/fb_st7735r.c driver namely a way to configure the controller from Device Tree. All fbtft drivers have builtin support for one display panel and all other panels using that con

Re: [PATCH 7/7] drm/st7586: Use framebuffer dma-buf helpers

2021-07-16 Thread David Lechner
On 7/16/21 9:08 AM, Thomas Zimmermann wrote: Replace dma_buf_begin_cpu_access() with drm_gem_fb_begin_cpu_access(); same for _end_cpu_access(). Remove some boiler-plate code. No functional changes. Signed-off-by: Thomas Zimmermann --- Acked-by: David Lechner

Re: [PATCH 11/11] drm/tiny: drm_gem_simple_display_pipe_prepare_fb is the default

2021-05-21 Thread David Lechner
On 5/21/21 4:09 AM, Daniel Vetter wrote: Goes through all the drivers and deletes the default hook since it's the default now. Acked-by: David Lechner

Re: [PATCH v3 0/1] drm/tiny: add support for Waveshare 2inch LCD module

2021-03-30 Thread David Lechner
..df25e8e0deb1 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -5769,6 +5769,14 @@ T: git git://anongit.freedesktop.org/drm/drm-misc F:Documentation/devicetree/bindings/display/sitronix,st7735r.yaml F:drivers/gpu/drm/tiny/st7735r.c +DRM DRIVER FOR SITRONIX ST7789V PANELS +M: David

Re: [PATCH 7/8] drm/mipi-dbi: Remove ->enabled

2020-06-13 Thread David Lechner
when that's the case, so filter that out too. Signed-off-by: Daniel Vetter Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Cc: David Airlie Cc: Daniel Vetter Cc: David Lechner --- Acked-by: David Lechner ___ dri-devel mailin

Re: [PATCH 18/44] drm/st7586: Use devm_drm_dev_alloc

2020-04-03 Thread David Lechner
On 4/3/20 8:58 AM, Daniel Vetter wrote: Already using devm_drm_dev_init, so very simple replacment. Signed-off-by: Daniel Vetter Cc: David Lechner --- Acked-by: David Lechner ___ dri-devel mailing list dri-devel@lists.freedesktop.org https

Re: [PATCH 23/44] drm/ili9225: Use devm_drm_dev_alloc

2020-04-03 Thread David Lechner
On 4/3/20 8:58 AM, Daniel Vetter wrote: Already using devm_drm_dev_init, so very simple replacment. Signed-off-by: Daniel Vetter Cc: David Lechner --- Acked-by: David Lechner ___ dri-devel mailing list dri-devel@lists.freedesktop.org https

Re: [PATCH 17/44] drm/st7735r: Use devm_drm_dev_alloc

2020-04-03 Thread David Lechner
On 4/3/20 8:58 AM, Daniel Vetter wrote: Already using devm_drm_dev_init, so very simple replacment. Aside: There was an oddity in the old code, we allocated priv but in the error path we've freed priv->dbidev ... Signed-off-by: Daniel Vetter Cc: David Lechner --- Acked-by: David

Re: [PATCH 22/44] drm/ili9341: Use devm_drm_dev_alloc

2020-04-03 Thread David Lechner
On 4/3/20 8:58 AM, Daniel Vetter wrote: Already using devm_drm_dev_init, so very simple replacment. Signed-off-by: Daniel Vetter Cc: "Noralf Trønnes" Cc: Sam Ravnborg Cc: Daniel Vetter Cc: Eric Anholt Cc: David Lechner --- Acked-by: Dav

Re: [PATCH v2 1/4] drm/tiny/repaper: Make driver OF-independent

2020-02-05 Thread David Lechner
On 2/5/20 3:31 PM, Sam Ravnborg wrote: Hi David. Are you planning to pick this series and apply it? Unless I get any other info I plan to process it tomorrow. Sam I won't be able to do it before then, so please go ahead. ___ dri-devel ma

Re: [PATCH v1 2/4] drm/tiny/repaper: No need to set ->owner for spi_register_driver()

2020-01-22 Thread David Lechner
On 1/22/20 4:54 AM, Andy Shevchenko wrote: The spi_register_driver() will set the ->owner member to THIS_MODULE. Signed-off-by: Andy Shevchenko --- Reviewed-by: David Lechner ___ dri-devel mailing list dri-devel@lists.freedesktop.org ht

Re: [PATCH v1 4/4] drm/tiny/st7735r: No need to set ->owner for spi_register_driver()

2020-01-22 Thread David Lechner
On 1/22/20 4:54 AM, Andy Shevchenko wrote: The spi_register_driver() will set the ->owner member to THIS_MODULE. Signed-off-by: Andy Shevchenko --- Reviewed-by: David Lechner ___ dri-devel mailing list dri-devel@lists.freedesktop.org ht

Re: [PATCH v1 3/4] drm/tiny/st7735r: Make driver OF-independent

2020-01-22 Thread David Lechner
On 1/22/20 4:54 AM, Andy Shevchenko wrote: There is one OF call in the driver that limits its area of use. Replace it to generic device_get_match_data() and get rid of OF dependency. Signed-off-by: Andy Shevchenko --- Acked-by: David Lechner

Re: [PATCH v2 1/5] dt-bindings: display: sitronix, st7735r: Convert to DT schema

2020-01-20 Thread David Lechner
e.org/meta-schemas/core.yaml# + +title: Sitronix ST7735R Display Panels Device Tree Bindings + +maintainers: + - David Lechner + +description: + This binding is for display panels using a Sitronix ST7735R controller in + SPI mode. + +allOf: + - $ref: panel/panel-common.yaml# not all of these propertie

Re: [PATCH 3/3] drm: tiny: st7735r: Add support for Okaya RH128128T

2020-01-06 Thread David Lechner
On 1/6/20 3:28 AM, Geert Uytterhoeven wrote: Hi Sam, On Sun, Jan 5, 2020 at 10:13 AM Sam Ravnborg wrote: Good to see we add more functionality to the smallest driver in DRM. The patch triggered a few comments - see below. Some comments relates to the original driver - and not your changes. T

Re: [PATCH 1/3] dt-bindings: display: sitronix, st7735r: Add Okaya rh128128t

2020-01-06 Thread David Lechner
On 1/2/20 8:46 AM, Sam Ravnborg wrote: Hi Geert. On Thu, Jan 02, 2020 at 03:12:44PM +0100, Geert Uytterhoeven wrote: Document support for the Okaya RH128128T display, which is a 128x128 1.44" TFT display driven by a Sitronix ST7715R TFT Controller/Driver. ST7715R and ST7735R are very similar.

Re: [PATCH] drm/tilcdc: Switch to using GPIO descriptors

2019-12-03 Thread David Lechner
Jyri Sarha Cc: Tomi Valkeinen Cc: David Lechner Signed-off-by: Linus Walleij --- Reviewed-by: David Lechner ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 4/5] drm/dsi: rename MIPI_DCS_SET_PARTIAL_AREA to MIPI_DCS_SET_PARTIAL_ROWS

2019-10-22 Thread David Lechner
On 10/22/19 5:09 AM, Jani Nikula wrote: The DCS command has been named SET_PARTIAL_ROWS in the DCS spec since v1.02, for more than a decade. Rename the enumeration to match the spec. Cc: David Lechner Cc: Vandita Kulkarni Signed-off-by: Jani Nikula --- I guess all of my documents are old

Re: [PATCH 2/4] drm/tiny/ili9341: Move driver to drm/panel

2019-08-01 Thread David Lechner
On 8/1/19 8:52 AM, Noralf Trønnes wrote: Move the driver to drm/panel and take advantage of the new panel support in drm_mipi_dbi. Change the file name to match the naming standard in drm/panel. The DRM driver name is kept since it is ABI. Add missing MAINTAINERS entry. Cc: David Lechner

Re: [PATCH 3/4] drm/tiny/mi0283qt: Move driver to panel-ilitek-ili9341

2019-08-01 Thread David Lechner
On 8/1/19 8:52 AM, Noralf Trønnes wrote: The MI0283QT panels use a ILI9341 controller so it makes sense to merge it with the other ili9341 code. The DRM driver name is ABI, so that is retained. Cc: David Lechner Signed-off-by: Noralf Trønnes --- ... @@ -216,6 +339,10 @@ static int

Re: [4/4] drm/panel/ili9341: Support DPI panels

2019-08-01 Thread David Lechner
On 8/1/19 8:52 AM, Noralf Trønnes wrote: Add support for panels that use the DPI interface. ILI9341 has onboard RAM so the assumption made here is that all such panels support pixel upload over DBI. The presence/absense of the Device Tree 'port' node decides which interface is used for pixel tra

Re: [PATCH 06/10] drm/tinydrm: Move tinydrm_spi_transfer()

2019-07-25 Thread David Lechner
On 7/25/19 9:16 AM, Noralf Trønnes wrote: Den 18.07.2019 14.14, skrev Noralf Trønnes: Den 17.07.2019 21.48, skrev David Lechner: On 7/17/19 6:58 AM, Noralf Trønnes wrote: This is only used by mipi-dbi drivers so move it there. The reason this isn't moved to the SPI subsystem is th

Re: [1/3] RFT: drm/pl111: Support grayscale

2019-07-23 Thread David Lechner
On 7/23/19 8:37 AM, Linus Walleij wrote: Migrating the TI nspire calculators to use the PL111 driver for framebuffer requires grayscale support for the elder panel which uses 8bit grayscale only. DRM does not support 8bit grayscale framebuffers in memory, but by defining the bus format to be MED

Re: [PATCH v2 7/9] drm/tinydrm/mipi-dbi: Select DRM_KMS_HELPER

2019-07-22 Thread David Lechner
On 7/22/19 5:43 AM, Noralf Trønnes wrote: mipi-dbi uses several KMS helper functions but that build dependency is not expressed. Select DRM_KMS_HELPER to fix that. Reported-by: kbuild test robot Signed-off-by: Noralf Trønnes --- Reviewed-by: David Lechner

Re: [PATCH v2 5/9] drm/tinydrm/mipi-dbi: Remove CMA helper dependency

2019-07-22 Thread David Lechner
oralf Trønnes --- Reviewed-by: David Lechner ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2 6/9] drm/tinydrm/Kconfig: drivers: Select BACKLIGHT_CLASS_DEVICE

2019-07-22 Thread David Lechner
d be to have DRM_KMS_FB_HELPER depend on the user visible symbol FB. That is a can of worms I'm not willing to tackle. I fear that such a change will result in me handling difficult fallouts for the next weeks. So I'm following DRM suite here. Signed-off-by: Noralf T

Re: [PATCH v2 9/9] MAINTAINERS: Remove tinydrm entry

2019-07-22 Thread David Lechner
On 7/22/19 5:43 AM, Noralf Trønnes wrote: tinydrm is just a collection of tiny drivers now. Add T: drm-misc entry for tinydrm drivers that lacks it. Cc: David Lechner Reviewed-by: Sam Ravnborg Signed-off-by: Noralf Trønnes --- Acked-by: David Lechner

Re: [PATCH v2 8/9] drm/tinydrm: Move mipi-dbi

2019-07-22 Thread David Lechner
. Cc: Eric Anholt Cc: David Lechner Reviewed-by: Sam Ravnborg Signed-off-by: Noralf Trønnes --- Acked-by: David Lechner ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2 4/9] drm/tinydrm: Split struct mipi_dbi in two

2019-07-22 Thread David Lechner
o be split out. Rename functions to match the new struct mipi_dbi_dev: - drm_to_mipi_dbi() -> drm_to_mipi_dbi_dev(). - mipi_dbi_init*() -> mipi_dbi_dev_init*(). Cc: Eric Anholt Cc: David Lechner Reviewed-by: Sam Ravnborg Signed-off-by: Noralf Trønnes --- Acked-b

Re: [PATCH v2 3/9] drm/tinydrm: Rename remaining variable mipi -> dbidev

2019-07-22 Thread David Lechner
s the variable name 'mipi' but this is not a good name since MIPI refers to a lot of standards. This patch changes the variable name to 'dbidev' where it refers to the pipeline part of struct mipi_dbi. Cc: Eric Anholt Cc: David Lechner Reviewed-by: Sam Ravnborg Signed-off-by: Noral

Re: [PATCH v2 2/9] drm/tinydrm: Rename variable mipi -> dbi

2019-07-22 Thread David Lechner
o the same structure. Cc: Eric Anholt Cc: David Lechner Reviewed-by: Sam Ravnborg Signed-off-by: Noralf Trønnes --- Acked-by: David Lechner ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2 10/11] drm/tinydrm/mipi-dbi: Add mipi_dbi_init_with_formats()

2019-07-22 Thread David Lechner
since it only supports one format. v2: Forgot to remove the mipi->rotation assignment in st7586, mipi_dbi_init_with_formats() handles it. Cc: David Lechner Acked-by: David Lechner Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/tinydrm/mipi-dbi.c |

Re: [PATCH 10/10] drm/tinydrm: Move tinydrm_display_pipe_init() to mipi-dbi

2019-07-17 Thread David Lechner
On 7/17/19 6:58 AM, Noralf Trønnes wrote: tinydrm_display_pipe_init() has only one user now, so move it to mipi-dbi. Changes: - Remove drm_connector_helper_funcs.detect, it's always connected. - Store the connector and mode in mipi_dbi instead of it's own struct. Otherwise remove some leftover

Re: [PATCH 09/10] drm/tinydrm/mipi-dbi: Add mipi_dbi_init_with_formats()

2019-07-17 Thread David Lechner
edded systems for this format. If I had more free time, I would like to look at adding grayscale support to DRM. Cc: David Lechner Signed-off-by: Noralf Trønnes --- Acked-by: David Lechner ___ dri-devel mailing list dri-devel@lists.freedesktop.org

Re: [PATCH 07/10] drm/tinydrm: Move tinydrm_machine_little_endian()

2019-07-17 Thread David Lechner
On 7/17/19 6:58 AM, Noralf Trønnes wrote: The tinydrm helper is going away so move it into the only user mipi-dbi. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/tinydrm/mipi-dbi.c| 15 --- include/drm/tinydrm/tinydrm-helpers.h | 15 --- 2 files changed, 12 in

Re: [PATCH 06/10] drm/tinydrm: Move tinydrm_spi_transfer()

2019-07-17 Thread David Lechner
h the tinydrm.ko SPI code. Additionally move the mipi_dbi_spi_init() declaration to the other SPI functions. Cc: David Lechner Signed-off-by: Noralf Trønnes --- Acked-by: : David Lechner I assume that the comments here might have something to do with the issue[1] I raised a while back? Should

Re: [PATCH 01/10] drm: Add SPI connector type

2019-07-17 Thread David Lechner
On 7/17/19 6:58 AM, Noralf Trønnes wrote: tinydrm drivers announce DRM_MODE_CONNECTOR_VIRTUAL for its SPI drivers. Stop lying and add a SPI connector type Cc: David Lechner Signed-off-by: Noralf Trønnes --- Acked-by: David Lechner ___ dri-devel

Re: [PATCH 05/10] drm/tinydrm: Clean up tinydrm_spi_transfer()

2019-07-17 Thread David Lechner
Lechner Signed-off-by: Noralf Trønnes --- Acked-by: : David Lechner ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v3 4/5] drm/tinydrm: Use damage helper for dirtyfb

2019-01-15 Thread David Lechner
ili9225_init() equal to mipi_dbi_init() so use it. v3: Include vblank header (Sam) ili9225 and st7586 can't use mipi_dbi_enable_flush() (David) v2: Remove fb check in mipi_dbi_enable_flush() it can't be NULL (kbuild test robot) Cc: David Lechner Cc: Eric Anholt Signed-off-

Re: [PATCH v2 4/5] drm/tinydrm: Use damage helper for dirtyfb

2019-01-14 Thread David Lechner
On 1/14/19 4:53 PM, Noralf Trønnes wrote: Den 14.01.2019 23.33, skrev David Lechner: On 1/14/19 3:50 PM, David Lechner wrote: On 1/14/19 10:13 AM, Noralf Trønnes wrote: I see that you have this call chain: st7586_pipe_enable() -> mipi_dbi_enable_flush() -> mipi_dbi_fb_dirty().

Re: [PATCH v2 4/5] drm/tinydrm: Use damage helper for dirtyfb

2019-01-14 Thread David Lechner
On 1/14/19 4:43 PM, Noralf Trønnes wrote: Den 14.01.2019 23.33, skrev David Lechner: On 1/14/19 3:50 PM, David Lechner wrote: On 1/14/19 10:13 AM, Noralf Trønnes wrote: I see that you have this call chain: st7586_pipe_enable() -> mipi_dbi_enable_flush() -> mipi_dbi_fb_dirty().

Re: [PATCH v2 4/5] drm/tinydrm: Use damage helper for dirtyfb

2019-01-14 Thread David Lechner
On 1/14/19 3:50 PM, David Lechner wrote: On 1/14/19 10:13 AM, Noralf Trønnes wrote: I see that you have this call chain: st7586_pipe_enable() -> mipi_dbi_enable_flush() -> mipi_dbi_fb_dirty(). That doesn't look safe. The st7586 driver allocates a tx_buf with size: size_t bufs

Re: [PATCH v2 4/5] drm/tinydrm: Use damage helper for dirtyfb

2019-01-14 Thread David Lechner
ili9225_init() equal to mipi_dbi_init() so use it. v2: Remove fb check in mipi_dbi_enable_flush() it can't be NULL (kbuild test robot) Cc: David Lechner Cc: Eric Anholt Signed-off-by: Noralf Trønnes Acked-by: Sam Ravnborg Acked-by: Daniel Vetter --- ... diff --git a/drivers/gp

Re: [PATCH v2 4/5] drm/tinydrm: Use damage helper for dirtyfb

2019-01-14 Thread David Lechner
On 1/14/19 10:13 AM, Noralf Trønnes wrote: I see that you have this call chain: st7586_pipe_enable() -> mipi_dbi_enable_flush() -> mipi_dbi_fb_dirty(). That doesn't look safe. The st7586 driver allocates a tx_buf with size: size_t bufsize = (mode->vdisplay + 2) / 3 * mode->hdisplay; wh

Re: [PATCH v2 4/5] drm/tinydrm: Use damage helper for dirtyfb

2019-01-13 Thread David Lechner
On 1/13/19 3:19 PM, David Lechner wrote: On 1/11/19 2:12 PM, Noralf Trønnes wrote: This switches to drm_atomic_helper_dirtyfb() as the framebuffer dirty handler. All flushing will now happen in the pipe functions. Also enable the damage plane property for all except repaper which can only do

Re: [PATCH v2 4/5] drm/tinydrm: Use damage helper for dirtyfb

2019-01-13 Thread David Lechner
ili9225_init() equal to mipi_dbi_init() so use it. v2: Remove fb check in mipi_dbi_enable_flush() it can't be NULL (kbuild test robot) Cc: David Lechner Cc: Eric Anholt Signed-off-by: Noralf Trønnes Acked-by: Sam Ravnborg Acked-by: Daniel Vetter --- Tested-by: David Lechner Review

Re: [PATCH 4/4] drm/tinydrm: Use damage helper for dirtyfb

2019-01-10 Thread David Lechner
ili9225_init() equal to mipi_dbi_init() so use it. Cc: David Lechner Cc: Eric Anholt Signed-off-by: Noralf Trønnes --- ... +static void ili9225_pipe_update(struct drm_simple_display_pipe *pipe, + struct drm_plane_state *old_state) +{ + struct drm_plane_state

Re: [PATCH v2 13/14] drm/tinydrm: do not reply on drmP.h from drm_gem_cma_helper.h

2018-12-31 Thread David Lechner
tinydrm/ for this add dependencies that othwewise was pulled in by drmP.h from drm_gem_cma_helper.h To avoid that tinydrm.h became "include everything", push include files to the individual drivers. Signed-off-by: Sam Ravnborg Cc: "Noralf Trønnes" Cc: David Airlie Cc: Eric Anhol

Re: [PATCH v1 7/7] drm: remove include of drmP.h from drm_gem_cma_helper.h

2018-12-27 Thread David Lechner
On 12/26/18 3:03 PM, Sam Ravnborg wrote: Fix fallout in various files/drivers. What fallout is being fixed? It would be helpful if we received the full patch series for context. It would also be nice to have a more detailed description in this commit message. _

Re: [PATCH v5 5/5] drm/tinydrm: Switch from CMA to shmem buffers

2018-10-28 Thread David Lechner
core can do dma on is_vmalloc() addresses making this >> possible. >> >> Cc: David Lechner >> Signed-off-by: Noralf Trønnes >> Acked-by: David Lechner >> Tested-by: David Lechner >> --- > > David, > FYI This series is scratched. > See the shmem help

Re: [PATCH v3 1/2] drm: Add library for shmem backed GEM objects

2018-09-12 Thread David Lechner
On 09/11/2018 07:43 AM, Noralf Trønnes wrote: This adds a library for shmem backed GEM objects with the necessary drm_driver callbacks. Signed-off-by: Noralf Trønnes --- ... +static int drm_gem_shmem_vmap_locked(struct drm_gem_shmem_object *shmem) +{ + struct drm_gem_object *obj = &s

Re: [PATCH v3 2/2] drm/tinydrm: Switch from CMA to shmem buffers

2018-09-12 Thread David Lechner
On 09/11/2018 07:44 AM, Noralf Trønnes wrote: This move makes tinydrm useful for more drivers. tinydrm doesn't need continuous memory, but at the time it was convenient to use the CMA library. The spi core can do dma on is_vmalloc() addresses making this possible. Cc: David Lechner Signe

Re: [PATCH] drm/tinydrm: add backlight dependency for ili9341

2018-07-12 Thread David Lechner
On 07/09/2018 10:20 AM, Arnd Bergmann wrote: This tinydrm driver fails to link without the backlight support: drivers/gpu/drm/tinydrm/ili9341.o: In function `ili9341_probe': ili9341.c:(.text+0x578): undefined reference to `devm_of_find_backlight' Fixes: 3fa0e8f6f960 ("drm/tinydrm: new driver fo

Re: [PATCH] drm/tinydrm: Fix doc build warnings

2018-07-10 Thread David Lechner
On 07/10/2018 12:09 PM, Noralf Trønnes wrote: Den 10.07.2018 18.40, skrev David Lechner: On 07/10/2018 11:31 AM, Noralf Trønnes wrote: Den 10.07.2018 18.18, skrev David Lechner: On 07/10/2018 10:05 AM, Noralf Trønnes wrote: include/drm/tinydrm/tinydrm.h:34: warning: Function parameter or

Re: [PATCH] drm/tinydrm: Fix doc build warnings

2018-07-10 Thread David Lechner
On 07/10/2018 11:31 AM, Noralf Trønnes wrote: Den 10.07.2018 18.18, skrev David Lechner: On 07/10/2018 10:05 AM, Noralf Trønnes wrote: include/drm/tinydrm/tinydrm.h:34: warning: Function parameter or member 'fb_dirty' not described in 'tinydrm_device' drivers/gpu/drm/ti

Re: [PATCH] drm/tinydrm: Fix doc build warnings

2018-07-10 Thread David Lechner
ibed in 'mipi_dbi_enable_flush' drivers/gpu/drm/tinydrm/mipi-dbi.c:272: warning: Function parameter or member 'plane_state' not described in 'mipi_dbi_enable_flush' Move struct member docs inline so it's not missed next time. Cc: David Lechner Signed-off-

Re: [PATCH] drm/tinydrm: add backlight dependency for ili9341

2018-07-10 Thread David Lechner
On 07/10/2018 10:55 AM, Noralf Trønnes wrote: Anyways, thanks for fixing this: Acked-by: Noralf Trønnes David Lechner do you apply this? Noralf. Yes, I will pick it up. ___ dri-devel mailing list dri-devel@lists.freedesktop.org https

Re: [PATCH v4 9/9] drm/cma-helper: Remove drm_fb_cma_fbdev_init_with_funcs()

2018-07-02 Thread David Lechner
On 07/02/2018 08:54 AM, Noralf Trønnes wrote: Remove drm_fb_cma_fbdev_init_with_funcs(), its only user tinydrm has moved to drm_fbdev_generic_setup(). Cc: Laurent Pinchart Signed-off-by: Noralf Trønnes --- Reviewed-by: David Lechner ___ dri

Re: [PATCH v4 8/9] drm/tinydrm: Use drm_fbdev_generic_setup()

2018-07-02 Thread David Lechner
On 07/02/2018 08:54 AM, Noralf Trønnes wrote: Make full use of the generic fbdev client. Cc: David Lechner Signed-off-by: Noralf Trønnes --- Reviewed-by: David Lechner ___ dri-devel mailing list dri-devel@lists.freedesktop.org https

Re: [PATCH v2 0/4] drm/tinydrm: new dirver for ILI9341 displays

2018-06-27 Thread David Lechner
On 06/27/2018 01:58 AM, Daniel Vetter wrote: On Tue, Jun 26, 2018 at 8:16 PM, David Lechner wrote: On 06/20/2018 04:07 AM, Daniel Vetter wrote: I acked and forwarded the account request, sorry for the delay. Next time around, poking maintainers on irc helps if this stuff is stuck. -Daniel

Re: [PATCH v2 0/4] drm/tinydrm: new dirver for ILI9341 displays

2018-06-26 Thread David Lechner
On 06/20/2018 04:07 AM, Daniel Vetter wrote: I acked and forwarded the account request, sorry for the delay. Next time around, poking maintainers on irc helps if this stuff is stuck. -Daniel The account was supposedly setup, but I am not able to use it for some reason. Are there any particular

Re: [PATCH v2 0/4] drm/tinydrm: new dirver for ILI9341 displays

2018-06-03 Thread David Lechner
On 6/3/18 5:00 PM, Noralf Trønnes wrote: Den 25.05.2018 21.36, skrev David Lechner: This series adds a new tinydrm driver for the Ilitek ILI9341 controller and a 2.4" display panel that uses this controller. David, do you have commit rights now? No. Opened a bug a while back to re

Re: [PATCH v2 3/4] dt-bindings: new binding for Ilitek ILI9341 display panels

2018-05-25 Thread David Lechner
On 05/25/2018 02:36 PM, David Lechner wrote: This adds a new binding for Ilitek ILI9341 display panels. It includes a compatible string for one display (more can be added in the future). The vendor prefix "noname" is used because the vendor is not known. Looks like I forgot to upda

[PATCH v2 2/4] dt-bindings: Add vendor prefix for Adafruit

2018-05-25 Thread David Lechner
This adds a device tree vendor prefix for Adafruit Industries, LLC. Signed-off-by: David Lechner --- Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree

[PATCH v2 3/4] dt-bindings: new binding for Ilitek ILI9341 display panels

2018-05-25 Thread David Lechner
Signed-off-by: David Lechner --- .../bindings/display/ilitek,ili9341.txt | 27 +++ 1 file changed, 27 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/ilitek,ili9341.txt diff --git a/Documentation/devicetree/bindings/display/ilitek,ili9341.txt

[PATCH v2 4/4] drm/tinydrm: new driver for ILI9341 display panels

2018-05-25 Thread David Lechner
fruit/Adafruit_Python_ILI9341 Signed-off-by: David Lechner Reviewed-by: Andy Shevchenko Reviewed-by: Noralf Trønnes --- MAINTAINERS | 6 + drivers/gpu/drm/tinydrm/Kconfig | 10 ++ drivers/gpu/drm/tinydrm/Makefile | 1 + drivers/gpu/drm/tinydrm/ili9341.c

[PATCH v2 1/4] MAINTAINERS: fix path to ilitek, ili9225 device tree bindings

2018-05-25 Thread David Lechner
This fixes the path to the ilitek,ili9225 device tree binding file. Signed-off-by: David Lechner Reviewed-by: Noralf Trønnes --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 334a00350922..bc219de9cbee 100644 --- a/MAINTAINERS

[PATCH v2 0/4] drm/tinydrm: new dirver for ILI9341 displays

2018-05-25 Thread David Lechner
efix * minor style changes * drop regulator from driver (instead of adding to DT bindings) [1]: https://cdn-learn.adafruit.com/assets/assets/000/046/879/original/SPEC-YX240QV29-T_Rev.A__1_.pdf David Lechner (4): MAINTAINERS: fix path to ilitek,ili9225 device tree bindings dt-bindings: Add ve

Re: [PATCH 2/3] dt-bindings: new binding for Ilitek ILI9341 display panels

2018-05-19 Thread David Lechner
On 05/19/2018 08:37 AM, Noralf Trønnes wrote: Den 15.05.2018 03.43, skrev David Lechner: This adds a new binding for Ilitek ILI9341 display panels. It includes a compatible string for one display (more can be added in the future). The vendor prefix "noname" is used because the ven

[PATCH 3/3] drm/tinydrm: new driver for ILI9341 display panels

2018-05-14 Thread David Lechner
fruit/Adafruit_Python_ILI9341 Signed-off-by: David Lechner --- MAINTAINERS | 6 + drivers/gpu/drm/tinydrm/Kconfig | 10 ++ drivers/gpu/drm/tinydrm/Makefile | 1 + drivers/gpu/drm/tinydrm/ili9341.c | 239 ++ 4 files changed, 256 insertions(+) create

  1   2   3   >