Re: [RFC PATCH net-next v6 07/15] page_pool: convert to use netmem

2024-03-04 Thread David Howells
Hi Mina, I recommend you cc linux-mm and Matthew Wilcox on these two patches also. David

Re: [ PATCH ] Documentation: fixed doc-build warnings

2022-03-28 Thread David Howells
kushagra...@outlook.com wrote: > @@ -256,7 +256,6 @@ struct fscache_cookie *fscache_acquire_cookie(struct > fscache_volume *volume, > > /** > * fscache_use_cookie - Request usage of cookie attached to an object > - * @object: Object description > * @will_modify: If cache is expected to be

Re: [Intel-gfx] A panic and a hang in the i915 drm driver

2020-06-08 Thread David Howells
Jani Nikula wrote: > David, please try [1]. Assuming you mean this: https://patchwork.freedesktop.org/patch/366958/?series=77635&rev=1 yes, that works. Tested-by: David Howells ___ dri-devel mailing list dri-devel@lists.freedesktop.or

Re: A panic and a hang in the i915 drm driver

2020-06-06 Thread David Howells
Here's the dmesg from a successful boot (commit f84e1ba336a4f47ae251e4d2d8a694902571b0df). David --- [0.007455] Normal [mem 0x0001-0x00041fdf] [0.007456] Movable zone start for each node [0.007456] Early memory node ranges [0.007457] node 0: [mem 0x0

A panic and a hang in the i915 drm driver

2020-06-06 Thread David Howells
Hi, I'm seeing the attached oops and panic from the i915 drm driver. I've tried bisecting it, but there's a problem in that one of the merged branches causes the machine to hang without output. The oops for commit c41219fda6e04255c44d37fd2c0d898c1c46abf1 looks like: BUG: kernel NULL pointer de

Re: [RFC][PATCH] wake_up_var() memory ordering

2019-06-25 Thread David Howells
Peter Zijlstra wrote: > I tried using wake_up_var() today and accidentally noticed that it > didn't imply an smp_mb() and specifically requires it through > wake_up_bit() / waitqueue_active(). Thinking about it again, I'm not sure why you need to add the barrier when wake_up() (which this is a w

Re: [RFC PATCH 14/68] vfs: Convert drm to use the new mount API

2019-04-10 Thread David Howells
Hi Al, I wonder if it would be possible to extend anon_inodes to return just an anonymous inode, thereby allowing the drm filesystem to be removed in favour of just using an anon_inode. David ___ dri-devel mailing list dri-devel@lists.freedesktop.org ht

[RFC PATCH 00/68] VFS: Convert a bunch of filesystems to the new mount API

2019-03-28 Thread David Howells
nverts a slew of filesystems to use the mount API. (9) Fixes a bug in hypfs. The patches can be found here also: https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git on branch: mount-api-viro David --- Andrew Price (1): gfs2: Convert gfs2 to fs_context

[RFC PATCH 14/68] vfs: Convert drm to use the new mount API

2019-03-27 Thread David Howells
-by: David Howells cc: David Airlie cc: Daniel Vetter cc: dri-devel@lists.freedesktop.org --- drivers/gpu/drm/drm_drv.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c index 381581b01d48..9eead5a478de

[PATCH 11/38] vfs: Convert drm to fs_context

2019-03-14 Thread David Howells
Signed-off-by: David Howells cc: David Airlie cc: Daniel Vetter cc: dri-devel@lists.freedesktop.org --- drivers/gpu/drm/drm_drv.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c index 381581b01d48

[PATCH 00/38] VFS: Convert trivial filesystems and more

2019-03-14 Thread David Howells
be found here also: https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git on branch: mount-api-viro David --- David Howells (38): vfs: Provide sb->s_iflags settings in fs_context struct vfs: Provide a mount_pseudo-replacement for fs_context vfs

[PATCH 01/11] UAPI: drm: Fix use of C++ keywords as structural members [ver #2]

2018-09-06 Thread David Howells
The i810 and msm drm drivers use C++ keywords as structural members. Fix this by inserting an anonymous union that provides an alternative name and then hide the reserved name in C++. Signed-off-by: David Howells cc: Rob Clark cc: David Airlie cc: linux-arm-...@vger.kernel.org cc: dri-devel

[RFC] UAPI: Check headers by compiling all together as C++

2018-09-06 Thread David Howells
eader to fs/coda/. The patches can also be found here: http://git.kernel.org/cgit/linux/kernel/git/dhowells/linux-fs.git/log/?h=uapi-check Thanks, David --- David Howells (11): UAPI: drm: Fix use of C++ keywords as structural members UAPI: keys: Fix use of C++ keywords as struct

Re: [RFC] UAPI: Check headers by compiling all together as C++

2018-09-05 Thread David Howells
Greg KH wrote: > > Here's a set of patches that inserts a step into the build process to make > > sure that the UAPI headers can all be built together with C++ (if the > > compiler being used supports C++). All but the final patch perform fixups, > > including: > > Wait, why do we care? What h

[PATCH 01/11] UAPI: drm: Fix use of C++ keywords as structural members

2018-09-05 Thread David Howells
The i810 and msm drm drivers use C++ keywords as structural members. Fix this by inserting an anonymous union that provides an alternative name and then hide the reserved name in C++. Signed-off-by: David Howells cc: Rob Clark cc: David Airlie cc: linux-arm-...@vger.kernel.org cc: dri-devel

[RFC] UAPI: Check headers by compiling all together as C++

2018-09-05 Thread David Howells
Compile all of the UAPI headers (with a few exceptions) together as C++ to catch new errors occurring as part of the regular build process. The patches can also be found here: http://git.kernel.org/cgit/linux/kernel/git/dhowells/linux-fs.git/log/?h=uapi-check Thanks, David --

Re: [PATCH 00/16] remove eight obsolete architectures

2018-03-15 Thread David Howells
Do we have anything left that still implements NOMMU? David ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v3 00/27] kill devm_ioremap_nocache

2018-01-04 Thread David Howells
Arnd Bergmann wrote: > - mn10300 appears to be wrong, broken by David Howells in > commit 83c2dc15ce82 ("MN10300: Handle cacheable PCI regions > in pci_iomap()") for any driver calling ioremap() by to get uncached > memory, It's not clear what the right thing to

[PATCH] treewide: Make remaining source files non-executable

2016-12-12 Thread David Howells
Joe Perches wrote: > .c and .h source files should not be executable, change > the permissions to 0644. Acked-by: David Howells

[PATCH 19/28] drm: proc: Use remove_proc_subtree() [RFC]

2013-04-16 Thread David Howells
- but that's shared with the debugfs interface where you can't do that, so I don't see an easy way of doing it. Signed-off-by: David Howells cc: dri-devel at lists.freedesktop.org --- drivers/gpu/drm/drm_proc.c | 22 +++--- 1 file changed, 7 insertions(+), 15 del

[PATCH 18/28] drm: proc: Use minor->index to label things, not PDE->name [RFC]

2013-04-16 Thread David Howells
an give you is 10 chars (4294967295) plus a NUL, so round up to 12 as the stack is likely to be 4- or 8-byte aligned. Signed-off-by: David Howells cc: dri-devel at lists.freedesktop.org --- drivers/gpu/drm/drm_proc.c | 13 + drivers/gpu/drm/drm_stub.c |2 +- include/drm/drmP.h

[PATCH 17/28] drm: Constify drm_proc_list[] [RFC]

2013-04-16 Thread David Howells
Constify drm_proc_list[] and related pointers. Signed-off-by: David Howells cc: dri-devel at lists.freedesktop.org --- drivers/gpu/drm/drm_proc.c |6 +++--- include/drm/drmP.h |2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_proc.c b

[PATCH 19/28] drm: proc: Use remove_proc_subtree() [RFC]

2013-04-16 Thread David Howells
- but that's shared with the debugfs interface where you can't do that, so I don't see an easy way of doing it. Signed-off-by: David Howells cc: dri-devel@lists.freedesktop.org --- drivers/gpu/drm/drm_proc.c | 22 +++--- 1 file changed, 7 insertions(+), 15 deletions

[PATCH 18/28] drm: proc: Use minor->index to label things, not PDE->name [RFC]

2013-04-16 Thread David Howells
an give you is 10 chars (4294967295) plus a NUL, so round up to 12 as the stack is likely to be 4- or 8-byte aligned. Signed-off-by: David Howells cc: dri-devel@lists.freedesktop.org --- drivers/gpu/drm/drm_proc.c | 13 + drivers/gpu/drm/drm_stub.c |2 +- include/drm/drmP.h

[PATCH 17/28] drm: Constify drm_proc_list[] [RFC]

2013-04-16 Thread David Howells
Constify drm_proc_list[] and related pointers. Signed-off-by: David Howells cc: dri-devel@lists.freedesktop.org --- drivers/gpu/drm/drm_proc.c |6 +++--- include/drm/drmP.h |2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_proc.c b

[PATCH] gpu: drm/nouveau/nouveau_fence.c: remove unnecessary null pointer check

2013-01-15 Thread David Howells
Cong Ding wrote: > > > the variable sender is dereferenced in line 190, so it is no reason to > > > check > > > null again in line 198. > > > > Did you mean "The variable 'chan'"? > sorry, my fault. so should I send a new version to correct the typo? Yep. David

[PATCH] gpu: drm/nouveau/nouveau_fence.c: remove unnecessary null pointer check

2013-01-15 Thread David Howells
Cong Ding wrote: > the variable sender is dereferenced in line 190, so it is no reason to check > null again in line 198. Did you mean "The variable 'chan'"? David

Re: [PATCH] gpu: drm/nouveau/nouveau_fence.c: remove unnecessary null pointer check

2013-01-15 Thread David Howells
Cong Ding wrote: > > > the variable sender is dereferenced in line 190, so it is no reason to > > > check > > > null again in line 198. > > > > Did you mean "The variable 'chan'"? > sorry, my fault. so should I send a new version to correct the typo? Yep. David ___

Re: [PATCH] gpu: drm/nouveau/nouveau_fence.c: remove unnecessary null pointer check

2013-01-15 Thread David Howells
Cong Ding wrote: > the variable sender is dereferenced in line 190, so it is no reason to check > null again in line 198. Did you mean "The variable 'chan'"? David ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org

Re: [PATCH 1/2] uapi: update includes for drm content when no kernel API exists

2012-10-17 Thread David Howells
Luis R. Rodriguez wrote: > >> The include_next trick can work as well but that'd mean synching the UAPI > >> files regularly into compat. I'd much prefer to have code intact when > >> possible when backporting so the option I stuck with then was to patch > >> the code directly and then as part of

[PATCH 1/2] uapi: update includes for drm content when no kernel API exists

2012-10-17 Thread David Howells
Luis R. Rodriguez wrote: > >> The include_next trick can work as well but that'd mean synching the UAPI > >> files regularly into compat. I'd much prefer to have code intact when > >> possible when backporting so the option I stuck with then was to patch > >> the code directly and then as part of

[git pull] drm merge for rc1 (part 1)

2012-10-04 Thread David Howells
David Howells wrote: > Linus Torvalds wrote: > > > Ok, as usual I actually wanted to do the merge myself despite the > > annoying conflicts (this *really* is the last time I will ever accept > > any header file "cleanups" - they simply aren't worth the

[git pull] drm merge for rc1 (part 1)

2012-10-04 Thread David Howells
Linus Torvalds wrote: > Ok, as usual I actually wanted to do the merge myself despite the > annoying conflicts (this *really* is the last time I will ever accept > any header file "cleanups" - they simply aren't worth the pain). There was a reason I asked you to pull the patches at the *end* of

Re: [git pull] drm merge for rc1 (part 1)

2012-10-04 Thread David Howells
David Howells wrote: > Linus Torvalds wrote: > > > Ok, as usual I actually wanted to do the merge myself despite the > > annoying conflicts (this *really* is the last time I will ever accept > > any header file "cleanups" - they simply aren't worth the

Re: [git pull] drm merge for rc1 (part 1)

2012-10-04 Thread David Howells
Linus Torvalds wrote: > Ok, as usual I actually wanted to do the merge myself despite the > annoying conflicts (this *really* is the last time I will ever accept > any header file "cleanups" - they simply aren't worth the pain). There was a reason I asked you to pull the patches at the *end* of

Re: system_nrt_wq, system suspend, and the freezer

2012-02-16 Thread David Howells
Tejun Heo wrote: > > > My question to all of you: Should system_nrt_wq be made freezable, or > > > should I create a new workqueue that is both freezable and > > > non-reentrant? And if I do, which of the usages above should be > > > converted to the new workqueue? > > > > As far as keys are

Re: system_nrt_wq, system suspend, and the freezer

2012-02-16 Thread David Howells
Alan Stern wrote: > My question to all of you: Should system_nrt_wq be made freezable, or > should I create a new workqueue that is both freezable and > non-reentrant? And if I do, which of the usages above should be > converted to the new workqueue? As far as keys are concerned, it's only f

system_nrt_wq, system suspend, and the freezer

2012-02-16 Thread David Howells
Tejun Heo wrote: > > > My question to all of you: Should system_nrt_wq be made freezable, or > > > should I create a new workqueue that is both freezable and > > > non-reentrant? And if I do, which of the usages above should be > > > converted to the new workqueue? > > > > As far as keys are

system_nrt_wq, system suspend, and the freezer

2012-02-16 Thread David Howells
Alan Stern wrote: > My question to all of you: Should system_nrt_wq be made freezable, or > should I create a new workqueue that is both freezable and > non-reentrant? And if I do, which of the usages above should be > converted to the new workqueue? As far as keys are concerned, it's only f