Re: [PATCH RFC v3 2/4] virtio-pci: extend virtio_pci_cap with page_shift

2025-02-20 Thread Daniel Verkamp
t it to the default 4096?) Also shifting into the sign bit is technically undefined (or implementation-defined? I don't recall) behavior, so perhaps make the constant unsigned, e.g. `1U << (page_shift + 12)`. Other than that, looks reasonable to me: Reviewed-by: Daniel Verkamp Thanks, -- Daniel

Re: [PATCH RFC 3/5] virtio-pci: extend virtio_pci_cap to hold page_size

2025-02-13 Thread Daniel Verkamp
On Thu, Feb 13, 2025 at 11:22 AM Daniel Verkamp wrote: > > On Thu, Feb 13, 2025 at 7:54 AM Sergio Lopez wrote: > > > > Turn the 16 bit padding into a page_size field to allow the device to > > pass its required page size with format PAGE_SIZE >> 12. >

Re: [PATCH RFC 3/5] virtio-pci: extend virtio_pci_cap to hold page_size

2025-02-13 Thread Daniel Verkamp
On Thu, Feb 13, 2025 at 7:54 AM Sergio Lopez wrote: > > Turn the 16 bit padding into a page_size field to allow the device to > pass its required page size with format PAGE_SIZE >> 12. > > Signed-off-by: Sergio Lopez > --- > drivers/virtio/virtio_pci_modern.c | 29 + >