Re: [PATCH RFC v3 6/7] gpu: nova-core: add basic timer device

2025-03-24 Thread Daniel Brooks
"Alexandre Courbot" writes: > Hi Boqun, > > On Fri Mar 21, 2025 at 3:17 AM JST, Boqun Feng wrote: >> Also an Instant type has been proposed and reviewed for a while: >> >> >> https://lore.kernel.org/rust-for-linux/20250220070611.214262-5-fujita.tomon...@gmail.com/ >> >> we should use that t

Re: [PATCH RFC v3 6/7] gpu: nova-core: add basic timer device

2025-03-20 Thread Daniel Brooks
Alexandre Courbot writes: > +impl Add for Timestamp { > +type Output = Self; > + > +fn add(mut self, rhs: Duration) -> Self::Output { > +let mut nanos = rhs.as_nanos(); > +while nanos > u64::MAX as u128 { > +self.0 = self.0.wrapping_add(nanos as u64); > +

Re: [PATCH RFC 3/3] rust: hid: demo the core abstractions for probe and remove

2025-03-16 Thread Daniel Brooks
Rahul Rameshbabu writes: > Rust has the Drop trait[2]. If my understanding is correct, contained > data that also implement the Drop trait cannot be enforced in terms of > the order they are dropped/provide any kind of dependency management > here. It's worth exploring. My concern is some very tr