Re: [PATCH] drm/bridge: tc358767: fix uninitialized variable regression

2025-07-03 Thread Colin King (gmail)
cating the of_graph_parse_endpoint() call which initializes the struct of_endpoint, resulting in an uninitialized read. Fixes: a59a27176914 ("drm/bridge: tc358767: convert to devm_drm_bridge_alloc() API") Reported-by: Colin King (gmail) Closes: https://lore.kernel.org/all/056b34c3-c1ea-4b

Re: [PATCH][next] drm/ttm: remove redundant ternaray operation on ret

2025-07-02 Thread Colin King (gmail)
On 02/07/2025 10:42, Robert P. J. Day wrote: subject has typo, should be "ternary" rday Good catch. Can that be fixed up before applying the patch rather than me sending a V2? Colin OpenPGP_0x68C287DFC6A80226.asc Description: OpenPGP public key OpenPGP_signature.asc Description: Ope

re: drm/bridge: tc358767: convert to devm_drm_bridge_alloc() API

2025-07-02 Thread Colin King (gmail)
Hi, I believe there is a regression in linux-next caused by the following commit: commit a59a271769149f0b8258507276f3d2a24370cbdb Author: Luca Ceresoli Date: Wed May 28 11:29:36 2025 +0200 drm/bridge: tc358767: convert to devm_drm_bridge_alloc() API the issue is as follows: static i

re: drm: panel: Add driver for Himax HX8279 DDIC panels

2025-04-22 Thread Colin King (gmail)
Hi, static analysis on today's linux-next has found two issues with the following commit: commit 38d42c261389985e8dd4739dbd97e2dc855e8dd0 Author: AngeloGioacchino Del Regno Date: Mon Apr 14 10:29:18 2025 +0200 drm: panel: Add driver for Himax HX8279 DDIC panels In the following code,

Re: [PATCH][next] ice: make const read-only array dflt_rules static

2025-03-17 Thread Colin King (gmail)
Ignore, managed to mangle two commits into one. On 17/03/2025 14:46, Colin Ian King wrote: Don't populate the const read-only array dflt_rules on the stack at run time, instead make it static. Signed-off-by: Colin Ian King --- drivers/gpu/drm/i915/intel_memory_region.c| 2 +- driv

re: drm/bridge: it6505: fix HDCP CTS compare V matching

2025-01-07 Thread Colin King (gmail)
Hi, static analysis on Linux-next has found a potential issue with the following commit: commit 0989c02c7a5c887c70deafen80c64d0291624e1a7 Author: Hermes Wu Date: Mon Dec 30 18:51:26 2024 +0800 drm/bridge: it6505: fix HDCP CTS compare V matching The issue is as follows: Source: drive

Re: [PATCH][next] drm/amd/amdgpu: Fix spelling mistake "versoin" -> "version"

2024-11-13 Thread Colin King (gmail)
On 13/11/2024 10:13, Dan Carpenter wrote: On Wed, Nov 13, 2024 at 09:53:49AM +, Colin Ian King wrote: There is a spelling mistake in a dev_err message. Fix it. Signed-off-by: Colin Ian King --- drivers/gpu/drm/amd/amdgpu/mes_v11_0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

shift and mask issue in drivers/gpu/drm/sprd/megacores_pll.c

2024-10-07 Thread Colin King (gmail)
Hi, I noticed a shift/mask issue in dphy_set_pll_reg() in drivers/gpu/drm/sprd/megacores_pll.c, the expression (pll->kint << 4) & 0xf is always zero: ... reg_val[4] = pll->kint >> 12; reg_val[5] = pll->kint >> 4; reg_val[6] = pll->out_sel | ((pll->kint << 4) &

Re: [PATCH][next] drm/tegra: hdmi: make read-only const array possible_nvram_sizes static

2024-08-29 Thread Colin King (gmail)
On 29/08/2024 16:50, Thierry Reding wrote: On Thu, Aug 22, 2024 at 09:50:47PM GMT, Colin Ian King wrote: Don't populate the const read-only array possible_nvram_sizes on the I've changed this (and the occurrence in the subject) to reflect the actual array name ("freqs") that's being changed he

drm/nouveau: fan:

2023-07-28 Thread Colin King (gmail)
Hi, static analysis with cppcheck has detected an issue in function nvkm_fan_update() in drivers/gpu/drm/nouveau/nvkm/subdev/therm/fan.c as follows: /* schedule next fan update, if not at target speed already */ if (target != duty) { u16 bump_period = fan->bios

Re: [PATCH][next] accel/qaic: remove redundant assignment to pointer pexec

2023-07-26 Thread Colin King (gmail)
On 26/07/2023 14:38, Pranjal Ramajor Asha Kanojiya wrote: On 7/26/2023 8:30 AM, Jeffrey Hugo wrote: On 7/25/2023 5:40 AM, Colin Ian King wrote: Pointer pexec is being assigned a value however it is never read. The assignment is redundant and can be removed. Signed-off-by: Colin Ian King ---