Re: [PATCH v2] drm/gem-shmem: When drm_gem_object_init failed, should release object

2022-11-18 Thread Chunyou Tang
Hi Thomas, Can I discard the first two patchs, and pull the new code, then modify and git send-email this patch? ?? Thu, 17 Nov 2022 14:42:36 +0100 Thomas Zimmermann : > Hi > > Am 11.11.22 um 04:38 schrieb ChunyouTang: > > when goto err_free, the object had init, so it should be rele

Re: [PATCH] drm/gem-shmem: When drm_gem_object_init failed, should release object

2022-11-09 Thread Chunyou Tang
Hi, drm_gem_object_init() will do these before failed: void drm_gem_private_object_init(struct drm_device *dev, struct drm_gem_object *obj, size_t size) { BUG_ON((size & (PAGE_SIZE - 1)) != 0); obj->dev = dev; obj->filp = NULL; kr

Re: [PATCH v2] drm/panfrost:report the full raw fault information instead

2021-07-01 Thread Chunyou Tang
river,I only used driver in linux 5.11. Thinks very much! Chunyou. ?? Thu, 1 Jul 2021 11:15:14 +0100 Steven Price : > On 29/06/2021 04:04, Chunyou Tang wrote: > > Hi Steve, > > t

Re: [PATCH v2] drm/panfrost:report the full raw fault information instead

2021-06-28 Thread Chunyou Tang
Hi Robin, thinks for you reply. I had send more detal to Steve in another mail,thinks for your messages. ?? Mon, 28 Jun 2021 15:17:51 +0100 Robin Murphy : > On 2021-06-28 11:48, Steven Price wrote: > > On 25/06/2021 10:49, Chunyou Tang wrote: >

Re: [PATCH v2] drm/panfrost:report the full raw fault information instead

2021-06-28 Thread Chunyou Tang
U Fault. if I set pte to ARM_LPAE_PTE_SH_NS,whether I use singel core GPU or multi core GPU,it will not occur GPU Fault. Thinks Chunyou ?? Mon, 28 Jun 2021 11:48:59 +0100 Steven Price : > On 25/06/2021 10:49, Chunyou Tang wrote: > > Hi Steve, > > Thinks for

Re: [PATCH v2] drm/panfrost:report the full raw fault information instead

2021-06-25 Thread Chunyou Tang
me some suggestions again? Thinks. Chunyou ?? Thu, 24 Jun 2021 14:22:04 +0100 Steven Price : > On 22/06/2021 02:40, Chunyou Tang wrote: > > Hi Steve, > > I will send a new patch with suitable subject/commit > > message. But I send a V3 or a new patch? >

Re: [PATCH v2] drm/panfrost:report the full raw fault information instead

2021-06-21 Thread Chunyou Tang
-peron.c...@gmail.com/ there had a same bug like mine,and I found you at the mail list,I don't know how it fixed? I need your help! thinks very much! Chunyou ?? Mon, 21 Jun 2021 11:45:20 +0100 Steven Price : > On 19/06/2021 04:18, Chunyou Tang wrote: > > Hi Steve, > >

Re: [PATCH] drm/panfrost:modify 'break' to 'continue' to traverse the circulation

2021-06-21 Thread Chunyou Tang
Hi Steve, I make a mistake about the code branch,I will test it later, thinks for your reply. Chunyou ?? Mon, 21 Jun 2021 11:45:18 +0100 Steven Price : > On 19/06/2021 04:09, Chunyou Tang wrote: > > Hi Steve, > > 1, > > from > > https://lore.kernel.

Re: [PATCH v2] drm/panfrost:report the full raw fault information instead

2021-06-18 Thread Chunyou Tang
Hi Steve, 1,Now I know how to write the subject 2,the low 8 bits is the exception type in spec. and you can see prnfrost_exception_name() switch (exception_code) { /* Non-Fault Status code */ case 0x00: return "NOT_STARTED/IDLE/OK"; case 0x01: return "DONE"; case 0

Re: [PATCH] drm/panfrost:modify 'break' to 'continue' to traverse the circulation

2021-06-18 Thread Chunyou Tang
Hi Steve, 1, from https://lore.kernel.org/lkml/31644881-134a-2d6e-dddf-e658a3a81...@arm.com/ I can see what your sent,I used a wrong email address,Now it correct. 2, > >Unless I'm mistaken the situation where some mappings may be NULL is > >caused by the loop in panfrost_lookup_bos(

Re: [PATCH] modified: gpu/drm/panfrost/panfrost_gpu.c

2021-06-15 Thread Chunyou Tang
ost_gem_mapping_put(job->mappings[i]); Thank you! ?? Fri, 11 Jun 2021 11:10:16 +0100 Steven Price : > On 10/06/2021 14:06, Chunyou Tang wrote: > > Hi Steven, > > Hi Chunyou, > > For some reason I'm not directly receiving your emails (only via the > list) - can

Re: [PATCH] modified: gpu/drm/panfrost/panfrost_gpu.c

2021-06-11 Thread Chunyou Tang
?? Fri, 11 Jun 2021 11:10:16 +0100 Steven Price : > On 10/06/2021 14:06, Chunyou Tang wrote: > > Hi Steven, > > Hi Chunyou, > > For some reason I'm not directly receiving your emails (only via the > list) - can you double check your email configuration? >

Re: [PATCH] modified: gpu/drm/panfrost/panfrost_gpu.c

2021-06-10 Thread Chunyou Tang
Hi Steven, > > The GPU exception fault status register(0x3C),the low 8 bit is the > > EXCEPTION_TYPE.We can see the description at P3-78 in spec. You can see the spec . > However this change is correct - panfrost_exception_name() should be > taking only the lower 8 bits. Even bet

Re: [PATCH] drivers/video/fbdev:modify 0 to NULL

2021-03-17 Thread Chunyou Tang
Hi,Gustavo On Wed, 17 Mar 2021 20:54:41 -0500 "Gustavo A. R. Silva" wrote: > On 3/17/21 21:47, Chunyou Tang wrote: > > > I think "if (info == NULL)" is more intuitive,and there have many > > compare likes "if (info == NULL)" in this file.

Re: [PATCH] drivers/video/fbdev:modify 0 to NULL

2021-03-17 Thread Chunyou Tang
HI,Gustavo On Wed, 17 Mar 2021 20:41:15 -0500 "Gustavo A. R. Silva" wrote: > On 3/17/21 21:33, ChunyouTang wrote: > > From: tangchunyou > > > > modify 0 to NULL,info is a pointer,it should be > > > > compared with NULL,not 0 > > > > Signed-off-by: tangchunyou > > --- > > drivers/video/fbde