Re: drivers/gpu/drm/mgag200/mgag200_cursor.c:134:57: sparse: incorrect type in argument 1 (different address spaces)

2013-06-21 Thread Christopher Harvey
Hey Dave, Do we care about these warnings? I'm not sure how to get around them. thanks, Chris P.S, this is my last day at Matrox, but I'll maintain it from another email. On Fri, Jun 21 2013, kbuild test robot wrote: > tree: git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next mast

drivers/gpu/drm/mgag200/mgag200_cursor.c:134:57: sparse: incorrect type in argument 1 (different address spaces)

2013-06-21 Thread Christopher Harvey
Hey Dave, Do we care about these warnings? I'm not sure how to get around them. thanks, Chris P.S, this is my last day at Matrox, but I'll maintain it from another email. On Fri, Jun 21 2013, kbuild test robot wrote: > tree: git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next mast

[PATCH] drm/mgag200: Hardware cursor support

2013-06-12 Thread Christopher Harvey
On Wed, Jun 05 2013, Christopher Harvey wrote: > G200 cards support, at best, 16 colour palleted images for the cursor > so we do a conversion in the cursor_set function, and reject cursors > with more than 16 colours, or cursors with partial transparency. Xorg > falls back gracefully

[PATCH] drm/mgag200: Don't do full cleanup if mgag200_device_init fails

2013-06-12 Thread Christopher Harvey
On Wed, Jun 05 2013, Christopher Harvey wrote: > Running mgag200_driver_unload when the driver init fails early on > causes functions like drm_mode_config_cleanup to be called. The > problem is, drm_mode_config_cleanup crashes because the corresponding > init hasn't happend

Re: [PATCH] drm/mgag200: Hardware cursor support

2013-06-12 Thread Christopher Harvey
On Wed, Jun 05 2013, Christopher Harvey wrote: > G200 cards support, at best, 16 colour palleted images for the cursor > so we do a conversion in the cursor_set function, and reject cursors > with more than 16 colours, or cursors with partial transparency. Xorg > falls back gracefully

Re: [PATCH] drm/mgag200: Don't do full cleanup if mgag200_device_init fails

2013-06-12 Thread Christopher Harvey
On Wed, Jun 05 2013, Christopher Harvey wrote: > Running mgag200_driver_unload when the driver init fails early on > causes functions like drm_mode_config_cleanup to be called. The > problem is, drm_mode_config_cleanup crashes because the corresponding > init hasn't happend

[PATCH] drm/mgag200: Hardware cursor support

2013-06-05 Thread Christopher Harvey
tmap - pixels 0 to 63 // X00 to X63= always 0 - pixels 0 to 63 // A00 to A63= transparent markers - pixels 0 to 63 // 1 means colour, 0 means transparent Signed-off-by: Christopher Harvey Signed-off-by: Mathieu Larouche Acked-by: Julia Lemire Te

[PATCH] drm/mgag200: Hardware cursor support

2013-06-05 Thread Christopher Harvey
tmap - pixels 0 to 63 // X00 to X63= always 0 - pixels 0 to 63 // A00 to A63= transparent markers - pixels 0 to 63 // 1 means colour, 0 means transparent Signed-off-by: Christopher Harvey Signed-off-by: Mathieu Larouche Acked-by: Julia Lemire Te

[PATCH] drm/mgag200: Don't do full cleanup if mgag200_device_init fails

2013-06-05 Thread Christopher Harvey
nit, so we can just pass the error code upwards. Acked-by: Julia Lemire Signed-off-by: Christopher Harvey --- drivers/gpu/drm/mgag200/mgag200_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mgag200/mgag200_main.c b/drivers/gpu/drm/mgag200/mgag200_ma

[PATCH] drm/mgag200: Don't do full cleanup if mgag200_device_init fails

2013-06-05 Thread Christopher Harvey
nit, so we can just pass the error code upwards. Acked-by: Julia Lemire Signed-off-by: Christopher Harvey --- drivers/gpu/drm/mgag200/mgag200_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mgag200/mgag200_main.c b/drivers/gpu/drm/mgag200/mgag200_ma

[PATCH] drm/mgag200: Add missing write to index before accessing data register

2013-05-31 Thread Christopher Harvey
On Fri, May 31 2013, Christopher Harvey wrote: > This is a bug fix for some versions of g200se cards while doing > mode-setting. > > Signed-off-by: Christopher Harvey > Tested-by: Julia Lemire > Acked-by: Julia Lemire Julia Lemire matrox.com> hmmm, feel free to delete th

[PATCH] drm/mgag200: Add missing write to index before accessing data register

2013-05-31 Thread Christopher Harvey
This is a bug fix for some versions of g200se cards while doing mode-setting. Signed-off-by: Christopher Harvey Tested-by: Julia Lemire Acked-by: Julia Lemire Julia Lemire --- drivers/gpu/drm/mgag200/mgag200_mode.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a

Re: [PATCH] drm/mgag200: Add missing write to index before accessing data register

2013-05-31 Thread Christopher Harvey
On Fri, May 31 2013, Christopher Harvey wrote: > This is a bug fix for some versions of g200se cards while doing > mode-setting. > > Signed-off-by: Christopher Harvey > Tested-by: Julia Lemire > Acked-by: Julia Lemire Julia Lemire hmmm, feel free to delete the extra &quo

[PATCH] drm/mgag200: Add missing write to index before accessing data register

2013-05-31 Thread Christopher Harvey
This is a bug fix for some versions of g200se cards while doing mode-setting. Signed-off-by: Christopher Harvey Tested-by: Julia Lemire Acked-by: Julia Lemire Julia Lemire --- drivers/gpu/drm/mgag200/mgag200_mode.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a

picking efifb driver over dri driver

2013-05-27 Thread Christopher Harvey
I'm looking for the mechanism in the kernel that makes the decision to load the efifb driver over a dri one. Any tips? I've got a machine here that loads efifb and prevents dri drivers from loading. thanks, Chris

picking efifb driver over dri driver

2013-05-27 Thread Christopher Harvey
I'm looking for the mechanism in the kernel that makes the decision to load the efifb driver over a dri one. Any tips? I've got a machine here that loads efifb and prevents dri drivers from loading. thanks, Chris ___ dri-devel mailing list dri-devel@list

[PATCH v2 2/4] drm/mgag200: Fix writes into MGA1064_PIX_CLK_CTL register

2013-05-09 Thread Christopher Harvey
want. Signed-off-by: Christopher Harvey Acked-by: Julia Lemire Tested-by: Julia Lemire Acked-by: Mathieu Larouche --- drivers/gpu/drm/mgag200/mgag200_mode.c | 42 +- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/drivers/gpu/drm/mgag200

[PATCH v2 1/4] drm/mgag200: Don't change unrelated registers during modeset

2013-05-09 Thread Christopher Harvey
Registers in indices below 0x18 are totally unrelated to modesetting, so don't write 0's, or anything else into them on modeset. Most of these registers are hardware cursor related, so this existing code interferes with hardware cursor development. Signed-off-by: Christopher Harvey

[PATCH 2/4] drm/mgag200: Fix writes into MGA1064_PIX_CLK_CTL register

2013-05-09 Thread Christopher Harvey
want. Signed-off-by: Christopher Harvey --- drivers/gpu/drm/mgag200/mgag200_mode.c | 42 +- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c b/drivers/gpu/drm/mgag200/mgag200_mode.c index 2d9333d..6f3b9db 100644

[PATCH 1/4] drm/mgag200: Don't change unrelated registers during modeset

2013-05-09 Thread Christopher Harvey
Registers in indices below 0x18 are totally unrelated to modesetting, so don't write 0's, or anything else into them on modeset. Most of these registers are hardware cursor related, so this existing code interferes with hardware cursor development. Signed-off-by: Christopher Harvey --

[PATCH 0/4] mgag200 fixes

2013-05-09 Thread Christopher Harvey
Christopher Harvey writes: > The Following should be CC'd to stable: > * drm/mgag200: Fix writes into MGA1064_PIX_CLK_CTL register > * drm/mgag200: Fix framebuffer base address programming > > The others are bug fixes, but aren't critical. I'm sitting on so

[PATCH v2 0/4] *** SUBJECT HERE ***

2013-05-09 Thread Christopher Harvey
I forgot to include some acked and tested-by lines in v1 of this series. No code changes in v2. thanks, Christopher Harvey (4): drm/mgag200: Don't change unrelated registers during modeset drm/mgag200: Fix writes into MGA1064_PIX_CLK_CTL register drm/mgag200: Convert counter dela

[PATCH 0/4] mgag200 fixes

2013-05-09 Thread Christopher Harvey
s before it can go in. I'm aiming for 3.11 for the hardware cursor support. thanks, Christopher Harvey (4): drm/mgag200: Don't change unrelated registers during modeset drm/mgag200: Fix writes into MGA1064_PIX_CLK_CTL register drm/mgag200: Convert counter delays to jiffies drm/mgag

Re: [PATCH 0/4] mgag200 fixes

2013-05-09 Thread Christopher Harvey
Christopher Harvey writes: > The Following should be CC'd to stable: > * drm/mgag200: Fix writes into MGA1064_PIX_CLK_CTL register > * drm/mgag200: Fix framebuffer base address programming > > The others are bug fixes, but aren't critical. I'm sitting on so

[PATCH v2 4/4] drm/mgag200: Fix framebuffer base address programming

2013-05-09 Thread Christopher Harvey
Higher bits of the base address of framebuffers weren't being programmed properly. This caused framebuffers that didn't happen to be allocated at a low enough address to not be displayed properly. Signed-off-by: Christopher Harvey Signed-off-by: Mathieu Larouche Acked-by: Julia Lemi

[PATCH v2 3/4] drm/mgag200: Convert counter delays to jiffies

2013-05-09 Thread Christopher Harvey
Signed-off-by: Christopher Harvey Acked-by: Julia Lemire Tested-by: Julia Lemire Acked-by: Mathieu Larouche --- drivers/gpu/drm/mgag200/mgag200_mode.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c b/drivers/gpu/drm

[PATCH v2 2/4] drm/mgag200: Fix writes into MGA1064_PIX_CLK_CTL register

2013-05-09 Thread Christopher Harvey
want. Signed-off-by: Christopher Harvey Acked-by: Julia Lemire Tested-by: Julia Lemire Acked-by: Mathieu Larouche --- drivers/gpu/drm/mgag200/mgag200_mode.c | 42 +- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/drivers/gpu/drm/mgag200

[PATCH v2 1/4] drm/mgag200: Don't change unrelated registers during modeset

2013-05-09 Thread Christopher Harvey
Registers in indices below 0x18 are totally unrelated to modesetting, so don't write 0's, or anything else into them on modeset. Most of these registers are hardware cursor related, so this existing code interferes with hardware cursor development. Signed-off-by: Christopher Harvey

[PATCH v2 0/4] *** SUBJECT HERE ***

2013-05-09 Thread Christopher Harvey
I forgot to include some acked and tested-by lines in v1 of this series. No code changes in v2. thanks, Christopher Harvey (4): drm/mgag200: Don't change unrelated registers during modeset drm/mgag200: Fix writes into MGA1064_PIX_CLK_CTL register drm/mgag200: Convert counter dela

[PATCH 4/4] drm/mgag200: Fix framebuffer base address programming

2013-05-09 Thread Christopher Harvey
Higher bits of the base address of framebuffers weren't being programmed properly. This caused framebuffers that didn't happen to be allocated at a low enough address to not be displayed properly. Signed-off-by: Christopher Harvey Signed-off-by: Mathieu Larouche --- drivers/gpu/d

[PATCH 3/4] drm/mgag200: Convert counter delays to jiffies

2013-05-09 Thread Christopher Harvey
Signed-off-by: Christopher Harvey --- drivers/gpu/drm/mgag200/mgag200_mode.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c b/drivers/gpu/drm/mgag200/mgag200_mode.c index 6f3b9db..6dbf6de 100644 --- a/drivers/gpu/drm

[PATCH 2/4] drm/mgag200: Fix writes into MGA1064_PIX_CLK_CTL register

2013-05-09 Thread Christopher Harvey
want. Signed-off-by: Christopher Harvey --- drivers/gpu/drm/mgag200/mgag200_mode.c | 42 +- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c b/drivers/gpu/drm/mgag200/mgag200_mode.c index 2d9333d..6f3b9db 100644

[PATCH 1/4] drm/mgag200: Don't change unrelated registers during modeset

2013-05-09 Thread Christopher Harvey
Registers in indices below 0x18 are totally unrelated to modesetting, so don't write 0's, or anything else into them on modeset. Most of these registers are hardware cursor related, so this existing code interferes with hardware cursor development. Signed-off-by: Christopher Harvey --

[PATCH 0/4] mgag200 fixes

2013-05-09 Thread Christopher Harvey
s before it can go in. I'm aiming for 3.11 for the hardware cursor support. thanks, Christopher Harvey (4): drm/mgag200: Don't change unrelated registers during modeset drm/mgag200: Fix writes into MGA1064_PIX_CLK_CTL register drm/mgag200: Convert counter delays to jiffies drm/mgag

[PATCH 4/4] drm/mgag200: Fix framebuffer base address programming

2013-05-08 Thread Christopher Harvey
Higher bits of the base address of framebuffers weren't being programmed properly. This caused framebuffers that didn't happen to be allocated at a low enough address to not be displayed properly. Signed-off-by: Christopher Harvey Signed-off-by: Mathieu Larouche --- drivers/gpu/d

[PATCH v2 4/4] drm/mgag200: Fix framebuffer base address programming

2013-05-08 Thread Christopher Harvey
Higher bits of the base address of framebuffers weren't being programmed properly. This caused framebuffers that didn't happen to be allocated at a low enough address to not be displayed properly. Signed-off-by: Christopher Harvey Signed-off-by: Mathieu Larouche Acked-by: Julia Lemi

[PATCH 3/4] drm/mgag200: Convert counter delays to jiffies

2013-05-06 Thread Christopher Harvey
Signed-off-by: Christopher Harvey --- drivers/gpu/drm/mgag200/mgag200_mode.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c b/drivers/gpu/drm/mgag200/mgag200_mode.c index 6f3b9db..6dbf6de 100644 --- a/drivers/gpu/drm

[PATCH v2 3/4] drm/mgag200: Convert counter delays to jiffies

2013-05-06 Thread Christopher Harvey
Signed-off-by: Christopher Harvey Acked-by: Julia Lemire Tested-by: Julia Lemire Acked-by: Mathieu Larouche --- drivers/gpu/drm/mgag200/mgag200_mode.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c b/drivers/gpu/drm

[PATCH] drm/mgag200: Remove extra variable assigns

2013-04-29 Thread Christopher Harvey
These two variables are set again immediately in 'mgag200_modeset_init' Signed-off-by: Christopher Harvey --- drivers/gpu/drm/mgag200/mgag200_main.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/mgag200/mgag200_main.c b/drivers/gpu/drm/mgag200/mgag200_ma

[PATCH] drm/mgag200: Pass driver specific mga_device in driver functions

2013-04-29 Thread Christopher Harvey
Signed-off-by: Christopher Harvey --- drivers/gpu/drm/mgag200/mgag200_mode.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c b/drivers/gpu/drm/mgag200/mgag200_mode.c index 78d8e91..f988965 100644 --- a/drivers/gpu/drm/mgag200

[PATCH] drm/mgag200: Remove pointless call to drm_fb_get_bpp_depth

2013-04-29 Thread Christopher Harvey
Signed-off-by: Christopher Harvey --- drivers/gpu/drm/mgag200/mgag200_fb.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/mgag200/mgag200_fb.c b/drivers/gpu/drm/mgag200/mgag200_fb.c index d2253f6..a5a1f34 100644 --- a/drivers/gpu/drm/mgag200/mgag200_fb.c +++ b/drivers/gpu

[PATCH] mgag200 code cleanup patches

2013-04-29 Thread Christopher Harvey
Christopher Harvey writes: > I submitted these a while ago, but I think they got lost in the > mailing list. Just wanted to make sure they get a shot at the merge > window. > > thanks, > > Christopher Harvey (3): > drm/mgag200: Remove pointless call to drm_fb_get_b

[PATCH] mgag200 code cleanup patches

2013-04-29 Thread Christopher Harvey
I submitted these a while ago, but I think they got lost in the mailing list. Just wanted to make sure they get a shot at the merge window. thanks, Christopher Harvey (3): drm/mgag200: Remove pointless call to drm_fb_get_bpp_depth drm/mgag200: Pass driver specific mga_device in driver

Re: [PATCH] mgag200 code cleanup patches

2013-04-29 Thread Christopher Harvey
Christopher Harvey writes: > I submitted these a while ago, but I think they got lost in the > mailing list. Just wanted to make sure they get a shot at the merge > window. > > thanks, > > Christopher Harvey (3): > drm/mgag200: Remove pointless call to drm_fb_get_b

[PATCH] drm/mgag200: Remove extra variable assigns

2013-04-29 Thread Christopher Harvey
These two variables are set again immediately in 'mgag200_modeset_init' Signed-off-by: Christopher Harvey --- drivers/gpu/drm/mgag200/mgag200_main.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/mgag200/mgag200_main.c b/drivers/gpu/drm/mgag200/mgag200_ma

[PATCH] drm/mgag200: Pass driver specific mga_device in driver functions

2013-04-29 Thread Christopher Harvey
Signed-off-by: Christopher Harvey --- drivers/gpu/drm/mgag200/mgag200_mode.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c b/drivers/gpu/drm/mgag200/mgag200_mode.c index 78d8e91..f988965 100644 --- a/drivers/gpu/drm/mgag200

[PATCH] drm/mgag200: Remove pointless call to drm_fb_get_bpp_depth

2013-04-29 Thread Christopher Harvey
Signed-off-by: Christopher Harvey --- drivers/gpu/drm/mgag200/mgag200_fb.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/mgag200/mgag200_fb.c b/drivers/gpu/drm/mgag200/mgag200_fb.c index d2253f6..a5a1f34 100644 --- a/drivers/gpu/drm/mgag200/mgag200_fb.c +++ b/drivers/gpu

[PATCH] mgag200 code cleanup patches

2013-04-29 Thread Christopher Harvey
I submitted these a while ago, but I think they got lost in the mailing list. Just wanted to make sure they get a shot at the merge window. thanks, Christopher Harvey (3): drm/mgag200: Remove pointless call to drm_fb_get_bpp_depth drm/mgag200: Pass driver specific mga_device in driver

confused about a BUG_ON in drm_mm_dump_table

2013-04-19 Thread Christopher Harvey
I've been trying to wrap my head around ttm and gem these last couple of weeks. I found the nice 'drm_mm_dump_table' function and ran it on the mgag200 drm_mm struct. Instant BUG in include/drm/drm_mm.h line 100. static inline unsigned long drm_mm_hole_node_start(struct drm_mm_node *hole_node) {

confused about a BUG_ON in drm_mm_dump_table

2013-04-19 Thread Christopher Harvey
I've been trying to wrap my head around ttm and gem these last couple of weeks. I found the nice 'drm_mm_dump_table' function and ran it on the mgag200 drm_mm struct. Instant BUG in include/drm/drm_mm.h line 100. static inline unsigned long drm_mm_hole_node_start(struct drm_mm_node *hole_node) {

[PATCH 0/3] mgag200: bug fix, cleanup and managed devices

2013-04-05 Thread Christopher Harvey
while. Any testing hints are appreciated. Christopher Harvey (3): drm/mgag200: Index 24 in extended CRTC registers is 24 in hex, not decimal. drm: Misc comment cleanup drm/mgag200: Convert to managed device resources where possible drivers/gpu/drm/mgag200/mgag200_drv.h | 6 +++--- drive

[PATCH 3/3] drm/mgag200: Convert to managed device resources where possible

2013-04-05 Thread Christopher Harvey
Signed-off-by: Christopher Harvey --- drivers/gpu/drm/mgag200/mgag200_fb.c | 9 +++-- drivers/gpu/drm/mgag200/mgag200_main.c | 29 + 2 files changed, 8 insertions(+), 30 deletions(-) diff --git a/drivers/gpu/drm/mgag200/mgag200_fb.c b/drivers/gpu/drm/mgag200

[PATCH 2/3] drm: Misc comment cleanup

2013-04-05 Thread Christopher Harvey
Signed-off-by: Christopher Harvey --- drivers/gpu/drm/mgag200/mgag200_drv.h | 6 +++--- include/drm/drm_crtc.h| 2 +- include/uapi/drm/drm_mode.h | 6 +++--- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/mgag200/mgag200_drv.h b/drivers

[PATCH 1/3] drm/mgag200: Index 24 in extended CRTC registers is 24 in hex, not decimal.

2013-04-05 Thread Christopher Harvey
This change properly enables the "requester" in G200ER cards that is responsible for getting pixels out of memory and clocking them out to the screen. Signed-off-by: Christopher Harvey --- drivers/gpu/drm/mgag200/mgag200_mode.c | 13 +++-- 1 file changed, 3 insertions(+), 10

[PATCH 3/3] drm/mgag200: Convert to managed device resources where possible

2013-04-05 Thread Christopher Harvey
Signed-off-by: Christopher Harvey --- drivers/gpu/drm/mgag200/mgag200_fb.c | 9 +++-- drivers/gpu/drm/mgag200/mgag200_main.c | 29 + 2 files changed, 8 insertions(+), 30 deletions(-) diff --git a/drivers/gpu/drm/mgag200/mgag200_fb.c b/drivers/gpu/drm/mgag200

[PATCH 2/3] drm: Misc comment cleanup

2013-04-05 Thread Christopher Harvey
Signed-off-by: Christopher Harvey --- drivers/gpu/drm/mgag200/mgag200_drv.h | 6 +++--- include/drm/drm_crtc.h| 2 +- include/uapi/drm/drm_mode.h | 6 +++--- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/mgag200/mgag200_drv.h b/drivers

[PATCH 1/3] drm/mgag200: Index 24 in extended CRTC registers is 24 in hex, not decimal.

2013-04-05 Thread Christopher Harvey
This change properly enables the "requester" in G200ER cards that is responsible for getting pixels out of memory and clocking them out to the screen. Signed-off-by: Christopher Harvey --- drivers/gpu/drm/mgag200/mgag200_mode.c | 13 +++-- 1 file changed, 3 insertions(+), 10

[PATCH 0/3] mgag200: bug fix, cleanup and managed devices

2013-04-05 Thread Christopher Harvey
while. Any testing hints are appreciated. Christopher Harvey (3): drm/mgag200: Index 24 in extended CRTC registers is 24 in hex, not decimal. drm: Misc comment cleanup drm/mgag200: Convert to managed device resources where possible drivers/gpu/drm/mgag200/mgag200_drv.h | 6 +++--- drive

colour pallete utilities

2013-03-19 Thread Christopher Harvey
On Tue, Mar 19, 2013 at 03:15:14PM -0400, Christopher Harvey wrote: > Does the Linux kernel have functions to convert images to palleted > images? I want to display a 4bit palleted cursor, not too sure how to > handle that in DRM. Some ideas I have: > > * change DRM to handle p

colour pallete utilities

2013-03-19 Thread Christopher Harvey
Does the Linux kernel have functions to convert images to palleted images? I want to display a 4bit palleted cursor, not too sure how to handle that in DRM. Some ideas I have: * change DRM to handle palleted cursors * convert 32bit images in drivers * write library functions do convert * requi

Re: colour pallete utilities

2013-03-19 Thread Christopher Harvey
On Tue, Mar 19, 2013 at 03:15:14PM -0400, Christopher Harvey wrote: > Does the Linux kernel have functions to convert images to palleted > images? I want to display a 4bit palleted cursor, not too sure how to > handle that in DRM. Some ideas I have: > > * change DRM to handle p

colour pallete utilities

2013-03-19 Thread Christopher Harvey
Does the Linux kernel have functions to convert images to palleted images? I want to display a 4bit palleted cursor, not too sure how to handle that in DRM. Some ideas I have: * change DRM to handle palleted cursors * convert 32bit images in drivers * write library functions do convert * requi

[PATCH 3/4] drm/mgag200: Remove extra variable assigns

2013-03-18 Thread Christopher Harvey
These two variables are set again immediately in 'mgag200_modeset_init' Signed-off-by: Christopher Harvey --- drivers/gpu/drm/mgag200/mgag200_main.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/mgag200/mgag200_main.c b/drivers/gpu/drm/mgag200/mgag200_ma

[PATCH 2/4] drm/mgag200: Pass driver specific mga_device in driver functions

2013-03-18 Thread Christopher Harvey
Signed-off-by: Christopher Harvey --- drivers/gpu/drm/mgag200/mgag200_mode.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c b/drivers/gpu/drm/mgag200/mgag200_mode.c index a274b99..6b5db83 100644 --- a/drivers/gpu/drm/mgag200

[PATCH 1/4] drm/mgag200: Remove pointless call to drm_fb_get_bpp_depth

2013-03-18 Thread Christopher Harvey
Signed-off-by: Christopher Harvey --- drivers/gpu/drm/mgag200/mgag200_fb.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/mgag200/mgag200_fb.c b/drivers/gpu/drm/mgag200/mgag200_fb.c index d2253f6..a5a1f34 100644 --- a/drivers/gpu/drm/mgag200/mgag200_fb.c +++ b/drivers/gpu

[PATCH 0/4] mgag200 fix and cleanup

2013-03-18 Thread Christopher Harvey
Just a bit of cleanup from me (resubmitted). The important patch comes from Julia. Julia's patch conflicts with the following: 1363594270-22137-1-git-send-email-airlied at gmail.com it fixes https://bugzilla.kernel.org/show_bug.cgi?id=46591 Christopher Harvey (3): drm/mgag200: Remove poin

[PATCH 3/4] drm/mgag200: Remove extra variable assigns

2013-03-18 Thread Christopher Harvey
These two variables are set again immediately in 'mgag200_modeset_init' Signed-off-by: Christopher Harvey --- drivers/gpu/drm/mgag200/mgag200_main.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/mgag200/mgag200_main.c b/drivers/gpu/drm/mgag200/mgag200_ma

[PATCH 2/4] drm/mgag200: Pass driver specific mga_device in driver functions

2013-03-18 Thread Christopher Harvey
Signed-off-by: Christopher Harvey --- drivers/gpu/drm/mgag200/mgag200_mode.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c b/drivers/gpu/drm/mgag200/mgag200_mode.c index a274b99..6b5db83 100644 --- a/drivers/gpu/drm/mgag200

[PATCH 1/4] drm/mgag200: Remove pointless call to drm_fb_get_bpp_depth

2013-03-18 Thread Christopher Harvey
Signed-off-by: Christopher Harvey --- drivers/gpu/drm/mgag200/mgag200_fb.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/mgag200/mgag200_fb.c b/drivers/gpu/drm/mgag200/mgag200_fb.c index d2253f6..a5a1f34 100644 --- a/drivers/gpu/drm/mgag200/mgag200_fb.c +++ b/drivers/gpu

[PATCH 0/4] mgag200 fix and cleanup

2013-03-18 Thread Christopher Harvey
Just a bit of cleanup from me (resubmitted). The important patch comes from Julia. Julia's patch conflicts with the following: 1363594270-22137-1-git-send-email-airl...@gmail.com it fixes https://bugzilla.kernel.org/show_bug.cgi?id=46591 Christopher Harvey (3): drm/mgag200: Remove poin

[PATCH 2/2] drm: Documentation typo fixes

2013-03-07 Thread Christopher Harvey
Signed-off-by: Christopher Harvey --- include/drm/drm_crtc.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h index 00d78b5..7294403 100644 --- a/include/drm/drm_crtc.h +++ b/include/drm/drm_crtc.h @@ -429,12 +429,12

[PATCH 0/2] mgag200 fix plus documentation typo fixes

2013-03-07 Thread Christopher Harvey
This is a fix for mgag200 cards that is well documented in the commit message. Also includes some typo fixes that were bugging me. Christopher Harvey (1): drm: Documentation typo fixes Julia Lemire (1): drm/mgag200: Bug fix: Renesas board now selects native resolution. drivers/gpu/drm

[PATCH 2/2] drm: Documentation typo fixes

2013-03-07 Thread Christopher Harvey
Signed-off-by: Christopher Harvey --- include/drm/drm_crtc.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h index 00d78b5..7294403 100644 --- a/include/drm/drm_crtc.h +++ b/include/drm/drm_crtc.h @@ -429,12 +429,12

[PATCH 0/2] mgag200 fix plus documentation typo fixes

2013-03-07 Thread Christopher Harvey
This is a fix for mgag200 cards that is well documented in the commit message. Also includes some typo fixes that were bugging me. Christopher Harvey (1): drm: Documentation typo fixes Julia Lemire (1): drm/mgag200: Bug fix: Renesas board now selects native resolution. drivers/gpu/drm

[PATCH] mgag200: some cleanup and a fix for corrupted output

2013-03-06 Thread Christopher Harvey
On Tue, Feb 26, 2013 at 10:52:55AM -0500, Christopher Harvey wrote: > Patches 1 to 4 are just cleanup. Maybe these should should be rolled > into one patch? > > Patch 5 is a bit more complicated. > On cards with very little video memory, (e.g 8MB) higher resolutions > at 32bit

Re: [PATCH] mgag200: some cleanup and a fix for corrupted output

2013-03-06 Thread Christopher Harvey
On Tue, Feb 26, 2013 at 10:52:55AM -0500, Christopher Harvey wrote: > Patches 1 to 4 are just cleanup. Maybe these should should be rolled > into one patch? > > Patch 5 is a bit more complicated. > On cards with very little video memory, (e.g 8MB) higher resolutions > at 32bit

[PATCH] drm/mgag200: Reject modes that are too big for VRAM

2013-02-26 Thread Christopher Harvey
= parameter. Signed-off-by: Christopher Harvey --- drivers/gpu/drm/mgag200/mgag200_mode.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c b/drivers/gpu/drm/mgag200/mgag200_mode.c index 3abf197..6b5db83 100644 --- a/drivers/gpu/drm

[PATCH] drm/mgag200: Cleanup: Remove extra variable assigns

2013-02-26 Thread Christopher Harvey
These two variables are set again immediately in 'mgag200_modeset_init' Signed-off-by: Christopher Harvey --- drivers/gpu/drm/mgag200/mgag200_main.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/mgag200/mgag200_main.c b/drivers/gpu/drm/mgag200/mgag200_ma

[PATCH] drm/mgag200: Cleanup: Pass driver specific mga_device in driver functions

2013-02-26 Thread Christopher Harvey
Signed-off-by: Christopher Harvey --- drivers/gpu/drm/mgag200/mgag200_mode.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c b/drivers/gpu/drm/mgag200/mgag200_mode.c index d3d99a2..3abf197 100644 --- a/drivers/gpu/drm/mgag200

[PATCH] drm/mgag200: Cleanup: 'fbdev_list' in 'struct mga_fbdev' is not used

2013-02-26 Thread Christopher Harvey
Signed-off-by: Christopher Harvey --- drivers/gpu/drm/mgag200/mgag200_drv.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/mgag200/mgag200_drv.h b/drivers/gpu/drm/mgag200/mgag200_drv.h index 5ea5033..4d932c4 100644 --- a/drivers/gpu/drm/mgag200/mgag200_drv.h +++ b/drivers

[PATCH] drm/mgag200: Cleanup: Remove pointless call to drm_fb_get_bpp_depth

2013-02-26 Thread Christopher Harvey
Signed-off-by: Christopher Harvey --- drivers/gpu/drm/mgag200/mgag200_fb.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/mgag200/mgag200_fb.c b/drivers/gpu/drm/mgag200/mgag200_fb.c index 2f48648..d46bd2c 100644 --- a/drivers/gpu/drm/mgag200/mgag200_fb.c +++ b/drivers/gpu

[PATCH] mgag200: some cleanup and a fix for corrupted output

2013-02-26 Thread Christopher Harvey
t;max_bytes" in the DRM core and then do these checks there. I'm also wondering, did I miss the 3.9.0 merge window? Thanks, Christopher Harvey (5): drm/mgag200: Cleanup: Remove pointless call to drm_fb_get_bpp_depth drm/mgag200: Cleanup: 'fbdev_list' in 'struct mg

[PATCH] drm/mgag200: Cleanup: Pass driver specific mga_device in driver functions

2013-02-26 Thread Christopher Harvey
Signed-off-by: Christopher Harvey --- drivers/gpu/drm/mgag200/mgag200_mode.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c b/drivers/gpu/drm/mgag200/mgag200_mode.c index d3d99a2..3abf197 100644 --- a/drivers/gpu/drm/mgag200

[PATCH] mgag200: some cleanup and a fix for corrupted output

2013-02-26 Thread Christopher Harvey
t;max_bytes" in the DRM core and then do these checks there. I'm also wondering, did I miss the 3.9.0 merge window? Thanks, Christopher Harvey (5): drm/mgag200: Cleanup: Remove pointless call to drm_fb_get_bpp_depth drm/mgag200: Cleanup: 'fbdev_list' in 'struct mg

[PATCH] drm/mgag200: Cleanup: 'fbdev_list' in 'struct mga_fbdev' is not used

2013-02-26 Thread Christopher Harvey
Signed-off-by: Christopher Harvey --- drivers/gpu/drm/mgag200/mgag200_drv.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/mgag200/mgag200_drv.h b/drivers/gpu/drm/mgag200/mgag200_drv.h index 5ea5033..4d932c4 100644 --- a/drivers/gpu/drm/mgag200/mgag200_drv.h +++ b/drivers

[PATCH] drm/mgag200: Cleanup: Remove extra variable assigns

2013-02-26 Thread Christopher Harvey
These two variables are set again immediately in 'mgag200_modeset_init' Signed-off-by: Christopher Harvey --- drivers/gpu/drm/mgag200/mgag200_main.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/mgag200/mgag200_main.c b/drivers/gpu/drm/mgag200/mgag200_ma

[PATCH] drm/mgag200: Cleanup: Remove pointless call to drm_fb_get_bpp_depth

2013-02-26 Thread Christopher Harvey
Signed-off-by: Christopher Harvey --- drivers/gpu/drm/mgag200/mgag200_fb.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/mgag200/mgag200_fb.c b/drivers/gpu/drm/mgag200/mgag200_fb.c index 2f48648..d46bd2c 100644 --- a/drivers/gpu/drm/mgag200/mgag200_fb.c +++ b/drivers/gpu

[PATCH] drm/mgag200: Reject modes that are too big for VRAM

2013-02-26 Thread Christopher Harvey
= parameter. Signed-off-by: Christopher Harvey --- drivers/gpu/drm/mgag200/mgag200_mode.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c b/drivers/gpu/drm/mgag200/mgag200_mode.c index 3abf197..6b5db83 100644 --- a/drivers/gpu/drm