Re: [PATCH 2/2] drm/meson: vclk: fix precision in vclk calculations

2025-01-10 Thread Christian Hewitt
> On 10 Jan 2025, at 12:36 pm, Maxime Ripard wrote: > > Hi, > > On Fri, Jan 10, 2025 at 07:44:58AM +0000, Christian Hewitt wrote: >> Playing YUV420 @ 59.94 media causes HDMI output to lose sync >> with a fatal error reported: >> >> [ 89.610280] Fat

[PATCH 0/2] drm/meson: vclk: revert and re-fix vclk calculations

2025-01-09 Thread Christian Hewitt
. This time the maths checks out. Apologies to the stable team as the original patch has been applied to a wide range of older and LTS kernels (as far as 5.10). Please let me know if combining the two patches into a single 'fix the previous fix' patch would be preferred? Christian

[PATCH 2/2] drm/meson: vclk: fix precision in vclk calculations

2025-01-09 Thread Christian Hewitt
values instead of int MHz. As values for phy_freq are now more accurate we also need to handle an additional match scenario in meson_vclk_setup. Fixes: e5fab2ec9ca4 ("drm/meson: vclk: add support for YUV420 setup") Signed-off-by: Christian Hewitt --- drivers/gpu/drm/meson/meson_enco

[PATCH 1/2] Revert "drm/meson: vclk: fix calculation of 59.94 fractional rates"

2025-01-09 Thread Christian Hewitt
: Signed-off-by: Christian Hewitt --- drivers/gpu/drm/meson/meson_vclk.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/meson/meson_vclk.c b/drivers/gpu/drm/meson/meson_vclk.c index 2a942dc6a6dc..2a82119eb58e 100644 --- a/drivers/gpu/drm/meson

Re: [PATCH 0/8] drm: bridge: dw_hdmi: Misc enable/disable, CEC and EDID cleanup

2024-06-21 Thread Christian Hewitt
or. I’m not sure my level of kernel fiddling counts as proper validation (Neil would be a more authoritative tester) but FWIW, I picked the series to my 6.10-rc4 dev branch (for Amlogic devices supported by the LibreELEC distro) and AFAICT everything is still working. Tested with Amlogic GXBB, GXL an

Re: [PATCH 1/2] dt-bindings: panel-simple-dsi: add New Khadas TS050 panel bindings

2024-04-09 Thread Christian Hewitt
> On 9 Apr 2024, at 12:26 PM, Jacobe Zang wrote: > > This add the bindings for the New Khadas TS050 1080x1920 5" LCD DSI panel > designed to work with the Khadas VIM3 and VIM3L Single Board Computers. > > Signed-off-by: Jacobe Zang > --- > .../devicetree/bindings/display/panel/panel-simple-dsi.

Re: [PATCH v5 00/10] drm/ci: Add support for GPU and display testing

2024-04-01 Thread Christian Hewitt
> On 1 Apr 2024, at 10:12 am, Vignesh Raman wrote: > > Some ARM SOCs have a separate display controller and GPU, each with > different drivers. For mediatek mt8173, the GPU driver is powervr, > and the display driver is mediatek. In the case of mediatek mt8183, > the GPU driver is panfrost, and t

Re: [PATCH] drm/panfrost: fix power transition timeout warnings

2024-03-25 Thread Christian Hewitt
> On 25 Mar 2024, at 2:28 pm, Steven Price wrote: > > On 22/03/2024 16:45, Christian Hewitt wrote: >> Increase the timeout value to prevent system logs on Amlogic boards flooding >> with power transition warnings: >> >> [ 13.047638] panfrost ffe4.gpu

[PATCH] drm/panfrost: fix power transition timeout warnings

2024-03-22 Thread Christian Hewitt
[39949.509405] panfrost ffe4.gpu: l2 power transition timeout The 2000 value has been found through trial and error testing with devices using G52 and G31 GPUs. Fixes: 22aa1a209018 ("drm/panfrost: Really power off GPU cores in panfrost_gpu_power_off()") Signed-off-by: Christian Hewitt --

[PATCH] drm/meson: vclk: fix calculation of 59.94 fractional rates

2024-01-09 Thread Christian Hewitt
Signed-off-by: Christian Hewitt --- I'm unable to give a better mathematical description of the fix as I can barely read code. The change was inspired by [0] which I chanced upon while looking at how other dw-hdmi drivers handle fractional rates. [0] https://github.com/torval

[PATCH v2] drm/meson: fix 1px pink line on GXM when scaling video overlay

2023-03-03 Thread Christian Hewitt
prevents the 1px pink line from being seen. [0] https://github.com/endlessm/linux-s905x/blob/master/drivers/amlogic/amports/video.c#L7869 Fixes: bbbe775ec5b5 ("drm: Add support for Amlogic Meson Graphic Controller") Suggested-by: Martin Blumenstingl Signed-off-by: Christian Hewitt

[PATCH] drm/meson: fix 1px pink line on GXM when scaling video overlay

2023-03-03 Thread Christian Hewitt
(17) | BIT(13) for VPP_DOLBY_CTRL - The vendor driver sets VPP_DUMMY_DATA Setting those values prevents the 1px pink line from being seen. Fixes: bbbe775ec5b5 ("drm: Add support for Amlogic Meson Graphic Controller") Suggested-by: Martin Blumenstingl Signed-off-by: Christian Hewitt --

[PATCH v2] drm/lima: add governor data with pre-defined thresholds

2021-01-27 Thread Christian Hewitt
://patchwork.kernel.org/project/dri-devel/patch/20210121170445.19761-1-lukasz.l...@arm.com/ Signed-off-by: Christian Hewitt --- Change since v1: increased upthreshold from 20 to 30, with a soft dependency on Lukasz delayed timer patch [0] [0] https://lore.kernel.org/lkml/20210127105121.20345-1

Re: [PATCH] drm/lima: add governor data with pre-defined thresholds

2021-01-27 Thread Christian Hewitt
> On 27 Jan 2021, at 3:11 pm, Lukasz Luba wrote: > > On 1/27/21 10:24 AM, Lukasz Luba wrote: >> Hi Christian, >> On 1/25/21 8:18 AM, Christian Hewitt wrote: >>> This patch adapts the panfrost pre-defined thresholds change [0] to the >>> lima driver

[PATCH] drm/lima: add governor data with pre-defined thresholds

2021-01-25 Thread Christian Hewitt
://patchwork.kernel.org/project/dri-devel/patch/20210121170445.19761-1-lukasz.l...@arm.com/ Signed-off-by: Christian Hewitt --- I have been using Kodi as my test application. If you scroll in library views with hundreds of list items and the panfrost values the slow GPU ramp up is quite noticeable

[PATCH] drm/panfrost: increase readl_relaxed_poll_timeout values

2020-10-08 Thread Christian Hewitt
by: Steven Price Signed-off-by: Christian Hewitt --- drivers/gpu/drm/panfrost/panfrost_gpu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/panfrost/panfrost_gpu.c b/drivers/gpu/drm/panfrost/panfrost_gpu.c index e1b2a3376624..2aae636f1cf5 100644 --- a/drive

[PATCH] drm/meson: add support for 1080p25 mode

2018-11-22 Thread Christian Hewitt
This essential mode for PAL users is missing, so add it. Signed-off-by: Christian Hewitt --- drivers/gpu/drm/meson/meson_venc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/meson/meson_venc.c b/drivers/gpu/drm/meson/meson_venc.c index acbbad3..ab16046 100644 --- a