On Sun, Sep 18, 2022 at 3:22 AM Han Jingoo wrote:
>
> On Mon, Aug 29, 2022 ChiaEn Wu wrote:
...
> > +#define MT6370_ITORCH_MIN_uA 25000
> > +#define MT6370_ITORCH_STEP_uA 12500
> > +#define MT6370_ITORCH_MAX_uA 40
> > +#defi
From: ChiaEn Wu
MediaTek MT6370 is a SubPMIC consisting of a single cell battery charger
with ADC monitoring, RGB LEDs, dual channel flashlight, WLED backlight
driver, display bias voltage supply, one general purpose LDO, and the
USB Type-C & PD controller complies with the latest USB Type-C
play bias driver and a general LDO for portable devices.
Add support for the MT6370 Flash LED driver. Flash LED in MT6370
has 2 channels and support torch/strobe mode.
Signed-off-by: Alice Chen
Signed-off-by: ChiaEn Wu
---
v9
- Revise the format of the comments.
---
drivers/leds/flash/Kco
lice Chen
Signed-off-by: Alice Chen
Signed-off-by: ChiYuan Huang
Signed-off-by: ChiaEn Wu
---
drivers/leds/rgb/Kconfig | 13 +
drivers/leds/rgb/Makefile |1 +
drivers/leds/rgb/leds-mt6370-rgb.c | 1010
3 files changed, 1024 insert
From: ChiaEn Wu
MediaTek MT6370 is a SubPMIC consisting of a single cell battery charger
with ADC monitoring, RGB LEDs, dual channel flashlight, WLED backlight
driver, display bias voltage supply, one general purpose LDO, and the
USB Type-C & PD controller complies with the latest USB Type-C
From: ChiaEn Wu
MediaTek MT6370 is a SubPMIC consisting of a single cell battery charger
with ADC monitoring, RGB LEDs, dual channel flashlight, WLED backlight
driver, display bias voltage supply, one general purpose LDO, and the
USB Type-C & PD controller complies with the latest USB Type-C
From: ChiaEn Wu
Add linear_range_idx macro for declaring the linear_range struct simply.
Signed-off-by: ChiaEn Wu
---
v9
- Revise LINEAR_RANGE() and LINEAR_RANGE_IDX()
---
include/linux/linear_range.h | 11 +++
1 file changed, 11 insertions(+)
diff --git a/include/linux
From: ChiYuan Huang
Add MT6370 backlight binding documentation.
Reviewed-by: Rob Herring
Reviewed-by: Daniel Thompson
Signed-off-by: ChiYuan Huang
Signed-off-by: ChiaEn Wu
---
.../leds/backlight/mediatek,mt6370-backlight.yaml | 121 +
1 file changed, 121 insertions
From: Alice Chen
Add MediaTek MT6370 flashlight binding documentation.
Reviewed-by: Krzysztof Kozlowski
Signed-off-by: Alice Chen
Signed-off-by: ChiaEn Wu
---
.../bindings/leds/mediatek,mt6370-flashlight.yaml | 41 ++
1 file changed, 41 insertions(+)
create mode 100644
From: ChiYuan Huang
Add MediaTek MT6370 current sink type LED indicator binding documentation.
Reviewed-by: Krzysztof Kozlowski
Signed-off-by: ChiYuan Huang
Signed-off-by: ChiaEn Wu
---
.../bindings/leds/mediatek,mt6370-indicator.yaml | 81 ++
1 file changed, 81
From: ChiaEn Wu
Add MediaTek MT6370 Charger binding documentation.
Reviewed-by: Krzysztof Kozlowski
Signed-off-by: ChiaEn Wu
---
.../power/supply/mediatek,mt6370-charger.yaml | 88 ++
1 file changed, 88 insertions(+)
create mode 100644
Documentation/devicetree
From: ChiaEn Wu
This patch series add MediaTek MT6370 PMIC support and add a index macro
to . The MT6370 is a highly-integrated smart power
management IC, which includes a single cell Li-Ion/Li-Polymer switching
battery charger, a USB Type-C & Power Delivery (PD) controller, dual
Flash
Signed-off-by: ChiaEn Wu
---
drivers/usb/typec/tcpm/Kconfig| 11 ++
drivers/usb/typec/tcpm/Makefile | 1 +
drivers/usb/typec/tcpm/tcpci_mt6370.c | 207 ++
3 files changed, 219 insertions(+)
create mode 100644 drivers/usb/typec/tcpm/tcpci_mt6370.c
diff
From: ChiYuan Huang
Add MediaTek MT6370 current sink type LED indicator binding documentation.
Reviewed-by: Krzysztof Kozlowski
Signed-off-by: ChiYuan Huang
Signed-off-by: ChiaEn Wu
---
.../leds/mediatek,mt6370-indicator.yaml | 81 +++
1 file changed, 81 insertions
From: ChiaEn Wu
MediaTek MT6370 is a SubPMIC consisting of a single cell battery charger
with ADC monitoring, RGB LEDs, dual channel flashlight, WLED backlight
driver, display bias voltage supply, one general purpose LDO, and the
USB Type-C & PD controller complies with the latest USB Type-C
play bias driver and a general LDO for portable devices.
Add support for the MT6370 Flash LED driver. Flash LED in MT6370
has 2 channels and support torch/strobe mode.
Signed-off-by: Alice Chen
Signed-off-by: ChiaEn Wu
---
v8
- Add missing 'dependency config' in Kconfig
- Revise all multi
lice Chen
Signed-off-by: Alice Chen
Signed-off-by: ChiYuan Huang
Signed-off-by: ChiaEn Wu
---
v8
- Add include header file
- Remove useless 'enum mt6370_state' because of using 'enum led_default_state'
- Revise the calculation of 'val' in 'mt6370_gen_bre
From: ChiaEn Wu
MediaTek MT6370 is a SubPMIC consisting of a single cell battery charger
with ADC monitoring, RGB LEDs, dual channel flashlight, WLED backlight
driver, display bias voltage supply, one general purpose LDO, and the
USB Type-C & PD controller complies with the latest USB Type-C
From: ChiaEn Wu
Add linear_range_idx macro for declaring the linear_range struct simply.
Signed-off-by: ChiaEn Wu
---
include/linux/linear_range.h | 8
1 file changed, 8 insertions(+)
diff --git a/include/linux/linear_range.h b/include/linux/linear_range.h
index fd3d0b358f22
From: ChiaEn Wu
MediaTek MT6370 is a SubPMIC consisting of a single cell battery charger
with ADC monitoring, RGB LEDs, dual channel flashlight, WLED backlight
driver, display bias voltage supply, one general purpose LDO, and the
USB Type-C & PD controller complies with the latest USB Type-C
From: ChiYuan Huang
Add MT6370 backlight binding documentation.
Reviewed-by: Rob Herring
Signed-off-by: ChiYuan Huang
Signed-off-by: ChiaEn Wu
---
.../backlight/mediatek,mt6370-backlight.yaml | 121 ++
1 file changed, 121 insertions(+)
create mode 100644
Documentation
From: Alice Chen
Add MediaTek MT6370 flashlight binding documentation.
Reviewed-by: Krzysztof Kozlowski
Signed-off-by: Alice Chen
Signed-off-by: ChiaEn Wu
---
.../leds/mediatek,mt6370-flashlight.yaml | 41 +++
1 file changed, 41 insertions(+)
create mode 100644
From: ChiYuan Huang
Add MediaTek MT6370 TCPC binding documentation.
Reviewed-by: Krzysztof Kozlowski
Signed-off-by: ChiYuan Huang
Signed-off-by: ChiaEn Wu
---
.../bindings/usb/mediatek,mt6370-tcpc.yaml| 36 +++
1 file changed, 36 insertions(+)
create mode 100644
From: ChiaEn Wu
Add MediaTek MT6370 Charger binding documentation.
Reviewed-by: Krzysztof Kozlowski
Signed-off-by: ChiaEn Wu
---
.../power/supply/mediatek,mt6370-charger.yaml | 88 +++
1 file changed, 88 insertions(+)
create mode 100644
Documentation/devicetree/bindings
From: ChiaEn Wu
I apologize for using the wrong mail list to send the wrong emails
for the last v8 patchset...
This patch series add MediaTek MT6370 PMIC support and add a index macro
to . The MT6370 is a highly-integrated smart power management
IC, which includes a single cell Li-Ion/Li
From: Alice Chen
Add MediaTek MT6370 flashlight binding documentation.
Reviewed-by: Krzysztof Kozlowski
Signed-off-by: Alice Chen
Signed-off-by: ChiaEn Wu
---
.../bindings/leds/mediatek,mt6370-flashlight.yaml | 41 ++
1 file changed, 41 insertions(+)
create mode 100644
play bias driver and a general LDO for portable devices.
Add a support for the MT6370 Flash LED driver. Flash LED in MT6370
has 2 channels and support torch/strobe mode.
Signed-off-by: Alice Chen
Signed-off-by: ChiaEn Wu
---
v7
- Fix the indentation.
- For the well defined macro, the parenthesi
& PD controller
complies with the latest USB Type-C and PD standards.
Reviewed-by: Andy Shevchenko
Signed-off-by: ChiYuan Huang
Signed-off-by: ChiaEn Wu
---
v7
- Move '#define MT6370_REG_MAXADDR' to the next line of
'#define MT6370_REG_CHG_MASK1'
- Rename
play bias driver and a general LDO for portable devices.
Add a support for the Type-C & Power Delivery controller in
MediaTek MT6370 IC.
Reviewed-by: AngeloGioacchino Del Regno
Reviewed-by: Guenter Roeck
Signed-off-by: ChiYuan Huang
Signed-off-by: ChiaEn Wu
---
v7
From: ChiYuan Huang
Add MT6370 backlight binding documentation.
Reviewed-by: Rob Herring
Signed-off-by: ChiYuan Huang
Signed-off-by: ChiaEn Wu
---
v7
- Add the second compatible string for 'mt6372'
- Add 'mediatek,bled-exponential-mode-enable' property for enable the
From: ChiYuan Huang
Add MediaTek MT6370 current sink type LED indicator binding documentation.
Reviewed-by: Krzysztof Kozlowski
Signed-off-by: ChiYuan Huang
Signed-off-by: ChiaEn Wu
---
.../bindings/leds/mediatek,mt6370-indicator.yaml | 81 ++
1 file changed, 81
From: ChiYuan Huang
Add MediaTek MT6370 TCPC binding documentation.
Reviewed-by: Krzysztof Kozlowski
Signed-off-by: ChiYuan Huang
Signed-off-by: ChiaEn Wu
---
.../bindings/usb/mediatek,mt6370-tcpc.yaml | 36 ++
1 file changed, 36 insertions(+)
create mode 100644
From: ChiYuan Huang
Add MediaTek MT6370 binding documentation.
Reviewed-by: Krzysztof Kozlowski
Signed-off-by: ChiYuan Huang
Signed-off-by: ChiaEn Wu
---
.../devicetree/bindings/mfd/mediatek,mt6370.yaml | 280 +
include/dt-bindings/iio/adc/mediatek,mt6370_adc.h | 18
From: ChiaEn Wu
Add MediaTek MT6370 Charger binding documentation.
Reviewed-by: Krzysztof Kozlowski
Signed-off-by: ChiaEn Wu
---
.../power/supply/mediatek,mt6370-charger.yaml | 88 ++
1 file changed, 88 insertions(+)
create mode 100644
Documentation/devicetree
From: ChiaEn Wu
This patch series add MediaTek MT6370 PMIC support. The MT6370 is a
highly-integrated smart power management IC, which includes a single
cell Li-Ion/Li-Polymer switching battery charger, a USB
Type-C & Power Delivery (PD) controller, dual Flash LED current sources,
a RGB
d-by: Alice Chen
Signed-off-by: Alice Chen
Signed-off-by: ChiYuan Huang
Signed-off-by: ChiaEn Wu
---
v7
- Add the comment for the union of 'struct mt6370_led'
- Revise the wrong description of 'Authors'
- Revise some typos (e.g. led --> LED)
- Revise 'if (!fwnode_pr
From: ChiaEn Wu
MediaTek MT6370 is a SubPMIC consisting of a single cell battery charger
with ADC monitoring, RGB LEDs, dual channel flashlight, WLED backlight
driver, display bias voltage supply, one general purpose LDO, and the
USB Type-C & PD controller complies with the latest USB Type-C
From: ChiaEn Wu
MediaTek MT6370 is a SubPMIC consisting of a single cell battery charger
with ADC monitoring, RGB LEDs, dual channel flashlight, WLED backlight
driver, display bias voltage supply, one general purpose LDO, and the
USB Type-C & PD controller complies with the latest USB Type-C
From: ChiaEn Wu
MediaTek MT6370 is a SubPMIC consisting of a single cell battery charger
with ADC monitoring, RGB LEDs, dual channel flashlight, WLED backlight
driver, display bias voltage supply, one general purpose LDO, and the
USB Type-C & PD controller complies with the latest USB Type-C
70_VIRTUAL_MULTICOLOR'
will be set as 'struct led_classdev'.
So, maybe the member 'index' of the 'struct mt6370_led' is what you
describe the information of which field of the union is in use?
I will add the proper comment here to describe this thing. I'm so
sorry for misunderstanding your mean last time.
Thanks again for your review.
--
Best Regards,
ChiaEn Wu
s for compatibility
> > > > reasons?
> > >
> > > I'd be curious what the compatiblity reasons are. In other words what
> > > software breaks?
> >
> > The reason is as above. We just hope the users who use this series SubPMIC
> > can
> > directly apply this driver to drive the backlight device without
> > knowing the underlying hardware.
> > Not software breaks.
>
> As above, ignoring the max_brightness property is a bug in the
> userspace. I'm still unclear why sending faked ranges to userspace
> it a better solution than fixing the userspace.
Ok, I got it!
If I add a second compatible string (like 'mediatek,mt6372-backlight')
in the DT section,
and append 'if-then-else' to determine the correct maximum value of
'default-brightness' and 'max-brightness',
Also, I will append 'bled exponential mode' to make user control using
linear or exponential mode.
These changes I will explain to DT's maintainer again.
Back to the driver section,
do I still need to use the register to confirm again whether this
SubPMIC used now is MT6372 and record this information? (using
'mt6370_check_vendor_info()')
I am afraid that the user who uses the MT6370 hardware, but the DT
compatible string is set to 'mediatek,mt6372-backlight'.
This may cause errors when update/get brightness values.
So I hope the driver here can check again to make sure the
'default-brightness', 'max-brightness', can be updated/got correctly.
I don't know if this will make you feel redundant if I do this??
Thank you so much!
--
Best Regards,
ChiaEn Wu
v->ranges + sel_range,
> > +curr->delta_t, &sel);
> > +
> > + val[i / 2] |= sel << (4 * ((i + 1) % 2));
> > + }
> > +
> > + memcpy(pattern_val, val, 3);
>
> Isn't it something like put_unaligned_be24()/put_unaligned_le24()?
OK, we will try to apply this method in the next patch.
Thank you so much for reviewing our patches so many times and
providing so many great suggestions!
--
Best Regards,
ChiaEn Wu
ghtness_val * 8 and then return;
If I do this change, does this meet your requirements?
>
>
> > Or, for the reasons, I have just explained (just one customer has this
> > requirement), then we do not make any changes for compatibility
> > reasons?
>
> I'd be curious what the compatiblity reasons are. In other words what
> software breaks?
The reason is as above. We just hope the users who use this series SubPMIC can
directly apply this driver to drive the backlight device without
knowing the underlying hardware.
Not software breaks.
Thanks!
>
> Normally the userspace backlight code reads the max_brightness property
> and configures things accordingly (and therefore if you the component
> that breaks is something like an Android HAL then fix the HAL instead).
>
>
> Daniel.
--
Best Regards,
ChiaEn Wu
On Mon, Jul 25, 2022 at 6:31 PM Daniel Thompson
wrote:
>
> On Fri, Jul 22, 2022 at 06:24:07PM +0800, ChiaEn Wu wrote:
> > diff --git a/drivers/video/backlight/Kconfig
> > b/drivers/video/backlight/Kconfig
> > index a003e02..846dbe7 100644
> > --- a/drivers/vid
0x1C0
#define MT6370_REG_CHG_MASK1 0x1E0
#define MT6370_REG_MAXADDR 0x1FF // Move it to here
#define MT6370_VENID_MASK GENMASK(7, 4)
#define MT6370_NUM_IRQREGS 16
#define MT6370_USBC_I2CADDR0x4E
#define MT6370_MAX_ADDRLEN 2// Rename
---
Thanks!
--
Best Regards,
ChiaEn Wu
70_REG_CHG_IRQ10x1C0
#define MT6370_REG_CHG_MASK1 0x1E0
#define MT6370_USBC_I2CADDR0x4E
#define MT6370_REG_MAXADDR 0x1FF
#define MT6370_VENID_MASK GENMASK(7, 4)
#define MT6370_NUM_IRQREGS 16
#define MT6370_REG_ADDRLEN 2
-------
Like this?
>
> --
> With Best Regards,
> Andy Shevchenko
--
Best Regards,
ChiaEn Wu
On Mon, Jul 25, 2022 at 3:06 PM Chunfeng Yun wrote:
>
> On Fri, 2022-07-22 at 18:24 +0800, ChiaEn Wu wrote:
> > From: ChiYuan Huang
> >
> > The MediaTek MT6370 is a highly-integrated smart power management IC,
> > which includes a single cell Li-Ion/Li-Polymer sw
From: ChiaEn Wu
MediaTek MT6370 is a SubPMIC consisting of a single cell battery charger
with ADC monitoring, RGB LEDs, dual channel flashlight, WLED backlight
driver, display bias voltage supply, one general purpose LDO, and the
USB Type-C & PD controller complies with the latest USB Type-C
From: Alice Chen
The MediaTek MT6370 is a highly-integrated smart power management IC,
which includes a single cell Li-Ion/Li-Polymer switching battery
charger, a USB Type-C & Power Delivery (PD) controller, dual Flash
LED current sources, a RGB LED driver, a backlight WLED driver,
a display bias
From: ChiYuan Huang
The MediaTek MT6370 is a highly-integrated smart power management IC,
which includes a single cell Li-Ion/Li-Polymer switching battery
charger, a USB Type-C & Power Delivery (PD) controller, dual
Flash LED current sources, a RGB LED driver, a backlight WLED driver,
a display b
From: ChiaEn Wu
MediaTek MT6370 is a SubPMIC consisting of a single cell battery charger
with ADC monitoring, RGB LEDs, dual channel flashlight, WLED backlight
driver, display bias voltage supply, one general purpose LDO, and the
USB Type-C & PD controller complies with the latest USB Type-C
From: ChiaEn Wu
MediaTek MT6370 is a SubPMIC consisting of a single cell battery charger
with ADC monitoring, RGB LEDs, dual channel flashlight, WLED backlight
driver, display bias voltage supply, one general purpose LDO, and the
USB Type-C & PD controller complies with the latest USB Type-C
From: ChiYuan Huang
The MediaTek MT6370 is a highly-integrated smart power management IC,
which includes a single cell Li-Ion/Li-Polymer switching battery
charger, a USB Type-C & Power Delivery (PD) controller, dual
Flash LED current sources, a RGB LED driver, a backlight WLED driver,
a display b
From: ChiYuan Huang
This adds support for the MediaTek MT6370 SubPMIC. MediaTek MT6370 is a
SubPMIC consisting of a single cell battery charger with ADC monitoring,
RGB LEDs, dual channel flashlight, WLED backlight driver, display bias
voltage supply, one general purpose LDO, and the USB Type-C &
From: ChiYuan Huang
Add MediaTek MT6370 binding documentation.
Signed-off-by: ChiYuan Huang
Reviewed-by: Krzysztof Kozlowski
---
.../devicetree/bindings/mfd/mediatek,mt6370.yaml | 280 +
include/dt-bindings/iio/adc/mediatek,mt6370_adc.h | 18 ++
2 files changed, 298 in
#
+
+title: MediaTek MT6370 Backlight
+
+maintainers:
+ - ChiaEn Wu
+
+description: |
+ This module is part of the MT6370 MFD device.
+ The MT6370 Backlight WLED driver supports up to a 29V output voltage for
+ 4 channels of 8 series WLEDs. Each channel supports up to 30mA of current
From: Alice Chen
Add MediaTek MT6370 flashlight binding documentation.
Signed-off-by: Alice Chen
Reviewed-by: Krzysztof Kozlowski
---
.../bindings/leds/mediatek,mt6370-flashlight.yaml | 41 ++
1 file changed, 41 insertions(+)
create mode 100644
Documentation/devicetree/
From: ChiYuan Huang
Add MediaTek MT6370 current sink type LED indicator binding documentation.
Signed-off-by: ChiYuan Huang
Reviewed-by: Krzysztof Kozlowski
---
v6
- Add 'reg' property of led of multi-led to prevent checking error.
---
.../bindings/leds/mediatek,mt6370-indicator.yaml | 81
From: ChiaEn Wu
Add MediaTek MT6370 Charger binding documentation.
Signed-off-by: ChiaEn Wu
Reviewed-by: Krzysztof Kozlowski
---
.../power/supply/mediatek,mt6370-charger.yaml | 88 ++
1 file changed, 88 insertions(+)
create mode 100644
Documentation/devicetree
From: ChiYuan Huang
Add MediaTek MT6370 TCPC binding documentation.
Signed-off-by: ChiYuan Huang
Reviewed-by: Krzysztof Kozlowski
---
.../bindings/usb/mediatek,mt6370-tcpc.yaml | 36 ++
1 file changed, 36 insertions(+)
create mode 100644
Documentation/devicetree/
From: ChiaEn Wu
This patch series add MediaTek MT6370 PMIC support. The MT6370 is a
highly-integrated smart power management IC, which includes a single
cell Li-Ion/Li-Polymer switching battery charger, a USB
Type-C & Power Delivery (PD) controller, dual Flash LED current sources,
a RGB
that.
>
> What I really want to see here is usage of "generic" drivers like led_bl
> and/or pwm_bl as to get some "standardization" around with all the benefits
> that this carries.
>
> > Come to think of it I'm also a little worried also about the whole linear
> > versus exponential curve thing since I thought LED drivers were required
> > to use exponential curves.
> >
>
> That probably depends on how the controller interprets the data, I guess,
> but I agree with you on this thought.
Hi Angelo,
MT6370 is just a SubPMIC, not an SoC, and is applied in cellular
telephones, tablet PCs, and portable instruments.
And the PWM mode of the MT6370 backlight driver is optional, and not
must be enabled.
>From our perspective, this MT6370 backlight driver is not the same as
mtk-pwm-disp related driver.
Thanks!
>
> Regards,
> Angelo
--
Best Regards,
ChiaEn Wu
From: ChiaEn Wu
MediaTek MT6370 is a SubPMIC consisting of a single cell battery charger
with ADC monitoring, RGB LEDs, dual channel flashlight, WLED backlight
driver, display bias voltage supply, one general purpose LDO, and the
USB Type-C & PD controller complies with the latest USB Type-C
From: Alice Chen
The MediaTek MT6370 is a highly-integrated smart power management IC,
whichincludes a single cell Li-Ion/Li-Polymer switching battery
charger, a USB Type-C & Power Delivery (PD) controller, dual Flash
LED current sources, a RGB LED driver, a backlight WLED driver,
a display bias
From: ChiYuan Huang
The MediaTek MT6370 is a highly-integrated smart power management IC,
which includes a single cell Li-Ion/Li-Polymer switching battery
charger, a USB Type-C & Power Delivery (PD) controller, dual
Flash LED current sources, a RGB LED driver, a backlight WLED driver,
a display b
From: ChiaEn Wu
MediaTek MT6370 is a SubPMIC consisting of a single cell battery charger
with ADC monitoring, RGB LEDs, dual channel flashlight, WLED backlight
driver, display bias voltage supply, one general purpose LDO, and the
USB Type-C & PD controller complies with the latest USB Type-C
From: ChiaEn Wu
MediaTek MT6370 is a SubPMIC consisting of a single cell battery charger
with ADC monitoring, RGB LEDs, dual channel flashlight, WLED backlight
driver, display bias voltage supply, one general purpose LDO, and the
USB Type-C & PD controller complies with the latest USB Type-C
From: ChiYuan Huang
The MT6370 is a highly-integrated smart power management IC, which
includes a single cell Li-Ion/Li-Polymer switching battery charger,
a USB Type-C & Power Delivery (PD) controller, dual Flash LED current
sources, a RGB LED driver, a backlight WLED driver, a display bias
drive
From: ChiYuan Huang
This adds support for the MediaTek MT6370 SubPMIC. MediaTek MT6370 is a
SubPMIC consisting of a single cell battery charger with ADC monitoring,
RGB LEDs, dual channel flashlight, WLED backlight driver, display bias
voltage supply, one general purpose LDO, and the USB Type-C &
From: ChiYuan Huang
Add MediaTek MT6370 binding documentation.
Signed-off-by: ChiYuan Huang
Reviewed-by: Krzysztof Kozlowski
---
.../devicetree/bindings/mfd/mediatek,mt6370.yaml | 280 +
include/dt-bindings/iio/adc/mediatek,mt6370_adc.h | 18 ++
2 files changed, 298 in
#
+
+title: MediaTek MT6370 Backlight
+
+maintainers:
+ - ChiaEn Wu
+
+description: |
+ This module is part of the MT6370 MFD device.
+ The MT6370 Backlight WLED driver supports up to a 29V output voltage for
+ 4 channels of 8 series WLEDs. Each channel supports up to 30mA of current
From: Alice Chen
Add MediaTek MT6370 flashlight binding documentation.
Signed-off-by: Alice Chen
Reviewed-by: Krzysztof Kozlowski
---
.../bindings/leds/mediatek,mt6370-flashlight.yaml | 41 ++
1 file changed, 41 insertions(+)
create mode 100644
Documentation/devicetree/
From: ChiYuan Huang
Add MediaTek MT6370 current sink type LED indicator binding documentation.
Signed-off-by: ChiYuan Huang
Reviewed-by: Krzysztof Kozlowski
---
.../bindings/leds/mediatek,mt6370-indicator.yaml | 77 ++
1 file changed, 77 insertions(+)
create mode 100644
From: ChiaEn Wu
Add MediaTek MT6370 Charger binding documentation.
Signed-off-by: ChiaEn Wu
Reviewed-by: Krzysztof Kozlowski
---
.../power/supply/mediatek,mt6370-charger.yaml | 88 ++
1 file changed, 88 insertions(+)
create mode 100644
Documentation/devicetree
From: ChiYuan Huang
Add MediaTek MT6370 TCPC binding documentation.
Signed-off-by: ChiYuan Huang
Reviewed-by: Krzysztof Kozlowski
---
.../bindings/usb/mediatek,mt6370-tcpc.yaml | 36 ++
1 file changed, 36 insertions(+)
create mode 100644
Documentation/devicetree/
From: ChiaEn Wu
This patch series add MediaTek MT6370 PMIC support. The MT6370 is a
highly-integrated smart power management IC, which includes a single
cell Li-Ion/Li-Polymer switching battery charger, a USB
Type-C & Power Delivery (PD) controller, dual Flash LED current sources,
a RGB
Andy Shevchenko 於 2022年7月13日 週三 晚上8:07寫道：
>
> On Wed, Jul 13, 2022 at 12:53 PM ChiaEn Wu wrote:
> > Andy Shevchenko 於 2022年7月5日 週二 清晨5:14寫道：
> > > On Mon, Jul 4, 2022 at 7:43 AM ChiaEn Wu wrote:
>
> Please, remove unneeded context when replying!
>
> ...
>
&g
Hi Andy,
Thanks for your reply! I have some questions want to ask you below.
Andy Shevchenko 於 2022年7月5日 週二 清晨5:14寫道：
>
> On Mon, Jul 4, 2022 at 7:43 AM ChiaEn Wu wrote:
> >
> > From: ChiaEn Wu
> >
> > Add Mediatek MT6370 Backlight support.
>
> ...
>
>
Hi Lee,
Lee Jones 於 2022年7月13日 週三 下午4:04寫道：
>
> On Wed, 13 Jul 2022, ChiaEn Wu wrote:
>
> > Hi Lee,
> >
> > Thanks for your reply.
> >
> > Lee Jones 於 2022年7月12日 週二 晚上11:29寫道：
> > >
> > > On Thu, 23 Jun 2022, ChiaEn Wu wrote:
> &
Hi Lee,
Thanks for your reply.
Lee Jones 於 2022年7月12日 週二 晚上11:29寫道：
>
> On Thu, 23 Jun 2022, ChiaEn Wu wrote:
>
> > From: ChiYuan Huang
> >
> > Add Mediatek MT6370 MFD support.
>
> No such thing as "MFD support".
>
> And you're not getting
From: ChiYuan Huang
Add Mediatek MT6370 TCPC binding documentation.
Signed-off-by: ChiYuan Huang
Reviewed-by: Krzysztof Kozlowski
---
.../bindings/usb/mediatek,mt6370-tcpc.yaml | 36 ++
1 file changed, 36 insertions(+)
create mode 100644
Documentation/devicetree/
From: ChiaEn Wu
Add Mediatek MT6370 Backlight support.
Signed-off-by: ChiaEn Wu
---
v4:
- Replace text "Mediatek" with "MediaTek" in Kconfig
- Add Copyright in the source code
- Revise the comment of "PWM HYS STEPS"
---
drivers/video/backlight/Kconfig
From: ChiYuan Huang
Add chip level mt6370 tcpci driver.
Signed-off-by: ChiYuan Huang
---
v4:
- Replace text "Mediatek" with "MediaTek" in Kconfig
- Replace "first ret=regulator_(dis/en)able and then return"
with "return directly" in "mt6370_tcpc_set_vbus()"
- Replace header file with
- Add
From: ChiaEn Wu
Add Mediatek MT6370 Charger binding documentation.
Signed-off-by: ChiaEn Wu
---
v4:
- Add minItems of "io-channel-names"
- Replace text "Mediatek" with "MediaTek"
---
.../power/supply/mediatek,mt6370-charger.yaml | 88 ++
From: ChiYuan Huang
Add Mediatek mt6370 current sink type LED indicator binding documentation.
Signed-off-by: ChiYuan Huang
Reviewed-by: Krzysztof Kozlowski
---
.../bindings/leds/mediatek,mt6370-indicator.yaml | 77 ++
1 file changed, 77 insertions(+)
create mode 100644
From: Alice Chen
Add Mediatek MT6370 flashlight support.
Signed-off-by: Alice Chen
---
v4:
- Replace text "Mediatek" with "MediaTek" in Kconfig
- Add Copyright in the source code
---
drivers/leds/flash/Kconfig | 12 +
drivers/leds/flash/Makefile| 1 +
drivers/leds/f
From: ChiYuan Huang
Add Mediatek MT6370 MFD support.
Signed-off-by: ChiYuan Huang
---
v4
- Replace text "Mediatek" with "MediaTek" in Kconfig
- Replace "first break and then return" with "return directly"
in
"mt6370_check_vendor_info()"
- Add module name related description in Kconfig help
From: ChiaEn Wu
Add Mediatek MT6370 charger driver.
Signed-off-by: ChiaEn Wu
---
v4:
- Replace text "Mediatek" with "MediaTek" in Kconfig and
MODULE_DESCRIPTION()
- Replace "mt6370_chg_val_to_reg" and "mt6370_chg_reg_to_val"
with
"linear_rang
From: ChiYuan Huang
Add Mediatek MT6370 binding documentation.
Signed-off-by: ChiYuan Huang
---
v4
- Roll back all "$ref: " to v2 patch style (using
"/schemas/...")
---
.../devicetree/bindings/mfd/mediatek,mt6370.yaml | 280 +
include/dt-bindings/iio/adc/mediatek,mt637
From: Alice Chen
Add Mediatek MT6370 flashlight binding documentation.
Signed-off-by: Alice Chen
Reviewed-by: Krzysztof Kozlowski
---
.../bindings/leds/mediatek,mt6370-flashlight.yaml | 41 ++
1 file changed, 41 insertions(+)
create mode 100644
Documentation/devicetree/
From: ChiaEn Wu
Add Mediatek MT6370 ADC support.
Signed-off-by: ChiaEn Wu
---
v4:
- Replace text "Mediatek" with "MediaTek"
- Replace all "first dev_err() and then return" with "return
dev_err_probe()"
- Add Copyright in the source code
- Add module n
#
+
+title: MediaTek MT6370 Backlight
+
+maintainers:
+ - ChiaEn Wu
+
+description: |
+ This module is part of the MT6370 MFD device.
+ The MT6370 Backlight WLED driver supports up to a 29V output voltage for
+ 4 channels of 8 series WLEDs. Each channel supports up to 30mA of current
From: ChiYuan Huang
Add Mediatek MT6370 current sink type LED Indicator driver.
Signed-off-by: ChiYuan Huang
---
v4:
- Replace text "Mediatek" with "MediaTek" in Kconfig
- Replace text "const" with "constant" in Kconfig
- Add Copyright in the source code
---
drivers/leds/Kconfig | 14 +
From: ChiaEn Wu
This patch series add Mediatek MT6370 PMIC support. The MT6370 is a
highly-integrated smart power management IC, which includes a single
cell Li-Ion/Li-Polymer switching battery charger, a USB
Type-C & Power Delivery (PD) controller, dual Flash LED current sources,
a RGB
Hi Andy,
Sorry for the late reply, I have some questions to ask you below. Thanks!
Andy Shevchenko 於 2022年6月24日 週五 凌晨2:56寫道：
>
> On Thu, Jun 23, 2022 at 2:00 PM ChiaEn Wu wrote:
> >
> > From: ChiaEn Wu
> >
> > Add Mediatek MT6370 charger driver.
>
&
Hi Lee,
Thanks for your reply!
Lee Jones 於 2022年6月27日 週一 晚上10:14寫道：
>
> On Sat, 18 Jun 2022, ChiaEn Wu wrote:
>
> > Hi Lee,
> >
> > Thanks for your helpful comments, we have some questions and replies below.
> >
> > Lee Jones 於 2022年6月16日 週四 清晨6:49
Hi Andy,
Thanks for your helpful comments!
Andy Shevchenko 於 2022年6月24日 週五 凌晨2:19寫道：
>
> On Thu, Jun 23, 2022 at 2:00 PM ChiaEn Wu wrote:
> >
> > From: ChiYuan Huang
> >
> > Add mt6370 DisplayBias and VibLDO support.
>
> ...
>
> > +#include
Hi Andy,
Thanks for your helpful comments! We have some questions below.
Andy Shevchenko 於 2022年6月24日 週五 凌晨2:01寫道：
>
> On Thu, Jun 23, 2022 at 1:59 PM ChiaEn Wu wrote:
> >
> > From: ChiYuan Huang
> >
> > Add Mediatek MT6370 MFD support.
>
> ...
>
>
Hi Daniel,
Thanks for your comments!
Daniel Thompson 於 2022年6月23日 週四 晚上9:43寫道：
>
> On Thu, Jun 23, 2022 at 07:56:31PM +0800, ChiaEn Wu wrote:
> > From: ChiaEn Wu
> >
> > Add Mediatek MT6370 Backlight support.
> >
> > Signed-off-by: ChiaEn Wu
>
> >
Hi Joe,
Joe Simmons-Talbott 於 2022年6月23日 週四 晚上9:17寫道：
>
> On Thu, Jun 23, 2022 at 07:56:22PM +0800, ChiaEn Wu wrote:
> > From: ChiYuan Huang
> >
> > Add mt6370 backlight binding documentation.
> >
> > Signed-off-by: ChiYuan Huang
> > ---
> >
1 - 100 of 159 matches
Mail list logo
