kzalloc doesn't return ERR_PTR, delete unneeded IS_ERR test.
Signed-off-by: Chen Ni
---
drivers/gpu/drm/loongson/lsdc_gfxpll.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/loongson/lsdc_gfxpll.c
b/drivers/gpu/drm/loongson/lsdc_gfxpll.c
index 249c09d
Replace comma between expressions with semicolons.
Using a ',' in place of a ';' can have unintended side effects.
Although that is not the case here, it is seems best to use ';'
unless ',' is intended.
Found by inspection.
No functional change intended.
C
clk_prepare_enable() already checked NULL clock parameter.
Remove unneeded NULL check for clk here.
Signed-off-by: Chen Ni
---
drivers/gpu/drm/arm/display/komeda/komeda_dev.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
b
clk_prepare_enable() and clk_disable_unprepare() already checked
NULL clock parameter.Remove unneeded NULL check for clk here.
Signed-off-by: Chen Ni
---
drivers/gpu/drm/omapdrm/dss/venc.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/omapdrm/dss
clk_prepare_enable() and clk_disable_unprepare() already checked
NULL clock parameter.Remove unneeded NULL check for clk here.
Signed-off-by: Chen Ni
---
drivers/gpu/drm/mxsfb/mxsfb_kms.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/mxsfb/mxsfb_kms.c
'destroy_workqueue()' already drains the queue before destroying it, so
there is no need to flush it explicitly.
Remove the redundant 'flush_workqueue()' calls.
This was generated with coccinelle:
@@
expression E;
@@
- flush_workqueue(E);
destroy_workqueue(E);
Si
'destroy_workqueue()' already drains the queue before destroying it, so
there is no need to flush it explicitly.
Remove the redundant 'flush_workqueue()' calls.
This was generated with coccinelle:
@@
expression E;
@@
- flush_workqueue(E);
destroy_workqueue(E);
Si
Fix following coccicheck warning:
./drivers/net/ethernet/sfc/tc.c:1584:29-80: WARNING avoid newline at end
of message in NL_SET_ERR_MSG_MOD
Signed-off-by: Chen Ni
---
drivers/net/ethernet/sfc/tc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/sfc/tc.c
There is no need to call the dev_err() function directly to print a
custom message when handling an error from platform_get_irq() function
as it is going to display an appropriate error message in case of a
failure.
Signed-off-by: Chen Ni
---
drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 4
Replace a comma between expression statements by a semicolon.
Signed-off-by: Chen Ni
---
drivers/gpu/drm/i915/display/intel_hdmi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c
b/drivers/gpu/drm/i915/display/intel_hdmi.c
index
Replace a comma between expression statements by a semicolon.
Signed-off-by: Chen Ni
---
drivers/video/fbdev/imsttfb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/video/fbdev/imsttfb.c b/drivers/video/fbdev/imsttfb.c
index 660499260f46..dc4e659e06af 100644
Replace a comma between expression statements by a semicolon.
Signed-off-by: Chen Ni
---
drivers/video/fbdev/pxa3xx-gcu.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/video/fbdev/pxa3xx-gcu.c b/drivers/video/fbdev/pxa3xx-gcu.c
index 43c80316d84b..489088b4e467
Replace a comma between expression statements by a semicolon.
Fixes: d786e00d19f9 ("drivers: hv, hyperv_fb: Untangle and refactor Hyper-V
panic notifiers")
Signed-off-by: Chen Ni
---
drivers/video/fbdev/hyperv_fb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Add check for the return value of spi_setup() and return the error
if it fails in order to catch the error.
Signed-off-by: Chen Ni
---
Changelog:
v1 -> v2:
1. Use dev_err_probe() to match other error paths
---
drivers/video/backlight/l4f00242t03.c | 5 -
1 file changed, 4 insertions(+)
Add check for the return value of spi_setup() and return the error
if it fails in order to catch the error.
Signed-off-by: Chen Ni
---
drivers/video/backlight/l4f00242t03.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/video/backlight/l4f00242t03.c
b/drivers
Return clk_prepare_enable() in order to transfer the error if it fails.
Signed-off-by: Chen Ni
---
drivers/video/fbdev/omap2/omapfb/dss/venc.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/video/fbdev/omap2/omapfb/dss/venc.c
b/drivers/video/fbdev/omap2/omapfb
Add check for the return value of drm_cvt_mode() and return the error if
it fails in order to avoid NULL pointer dereference.
Fixes: 1b043677d4be ("drm/qxl: add qxl_add_mode helper function")
Signed-off-by: Chen Ni
---
drivers/gpu/drm/qxl/qxl_display.c | 3 +++
1 file changed, 3
Add check for the return value of mipi_dsi_dcs_enter_sleep_mode() and
return the error if it fails in order to catch the error.
Signed-off-by: Chen Ni
---
drivers/gpu/drm/panel/panel-xinpeng-xpp055c272.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/panel
Add check for the return value of mipi_dsi_dcs_enter_sleep_mode() and
return the error if it fails in order to catch the error.
Signed-off-by: Chen Ni
---
drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/panel
Add check for the return value of of_drm_get_panel_orientation() and
return the error if it fails in order to catch the error.
Fixes: b27c0f6d208d ("drm/panel: sitronix-st7789v: add panel orientation
support")
Signed-off-by: Chen Ni
---
drivers/gpu/drm/panel/panel-sitronix-st7
Add check for the return value of drm_simple_display_pipe_init() and
return the error if it fails in order to catch the error.
Signed-off-by: Chen Ni
---
drivers/gpu/drm/tiny/bochs.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/tiny/bochs.c b/drivers
Add check for the return value of dma_set_max_seg_size() and return
the error if it fails in order to catch the error.
Fixes: ddfd4ab6bb08 ("drm/exynos: Fix dma_parms allocation")
Signed-off-by: Chen Ni
---
drivers/gpu/drm/exynos/exynos_drm_dma.c | 5 -
1 file changed, 4 insert
Add check for the return value of of_find_device_by_node() and return
the error if it fails in order to avoid NULL pointer dereference.
Fixes: e94236cde4d5 ("drm/tegra: dsi: Add ganged mode support")
Signed-off-by: Chen Ni
---
drivers/gpu/drm/tegra/dsi.c | 4 +++-
1 file changed, 3
23 matches
Mail list logo