Re: [PATCH v3 14/65] clk: lochnagar: Add a determine_rate hook

t, then we are at least explicit about our > behavior now and it can be further refined down the line. > > Signed-off-by: Maxime Ripard > --- Tested-by: Charles Keepax Thanks, Charles

Re: [PATCH 30/68] hwmon: lochnagar: constify pointers to hwmon_channel_info

On Thu, Apr 06, 2023 at 10:30:25PM +0200, Krzysztof Kozlowski wrote: > Statically allocated array of pointed to hwmon_channel_info can be made > const for safety. > > Signed-off-by: Krzysztof Kozlowski > --- Acked-by: Charles Keepax Thanks, Charles

Re: [PATCH v2 65/65] clk: Warn if we register a mux without determine_rate

On Fri, Nov 04, 2022 at 02:18:22PM +0100, Maxime Ripard wrote: > The determine_rate hook allows to select the proper parent and its rate > for a given clock configuration. On another hand, set_parent is there to > change the parent of a mux. > > Some clocks provide a set_parent hook but don't impl

Re: [PATCH v2 20/65] clk: wm831x: clkout: Add a determine_rate hook

n oversight, then we are at least explicit about our > behavior now and it can be further refined down the line. > Yeah I don't think there would be anything wrong with this clock changing parents on a rate change, but as you say this can be refined down the line if someone needs the beh

Re: [PATCH v2 09/11] docs: Fix some broken references

removing a few > false-positives. > > Signed-off-by: Mauro Carvalho Chehab > --- > drivers/input/touchscreen/wm97xx-core.c | 2 +- Acked-by: Charles Keepax Thanks, Charles ___ dri-devel mailing list dri-devel@lists.freedesktop.org

[PATCH] drm/exynos: Avoid NULL pointer dereference in resume if bind failed

On Wed, Sep 30, 2015 at 08:26:37PM +0900, Inki Dae wrote: > Hi, > > On 2015년 09월 28일 01:11, Charles Keepax wrote: > > If binding failed calling exynos_dp_enable in exynos_dp_resume will > > result in several NULL pointer dereferences. It is much better to > >

[PATCH] drm/exynos: Avoid NULL pointer dereference in resume if bind failed

If binding failed calling exynos_dp_enable in exynos_dp_resume will result in several NULL pointer dereferences. It is much better to simply skip suspend/resume handling if bind has failed, do so by checking if a drm_dev exists. Signed-off-by: Charles Keepax --- drivers/gpu/drm/exynos

[PATCH] drm/exynos: Check for NULL dereference of crtc

On Fri, Mar 06, 2015 at 10:13:42PM +0900, Inki Dae wrote: > On 2015년 02월 18일 02:14, Charles Keepax wrote: > > The commit "drm/exynos: remove exynos_plane_dpms" (d9ea6256) removed the > > use of the enabled flag, which means that the code may attempt to call >

[PATCH] Revert "drm/exynos: IOMMU support should not be selectable by user"

On Tue, Feb 17, 2015 at 09:18:28PM +0100, Javier Martinez Canillas wrote: > Hello Charles, > > On Tue, Feb 17, 2015 at 5:58 PM, Charles Keepax > wrote: > > This reverts commit 8dcc14f82f06fce997e35f4c77ced9d4ed192f31. > > > > This patch causes this error on Arndale

[PATCH] drm/exynos: Check for NULL dereference of crtc

referenced. Signed-off-by: Charles Keepax --- drivers/gpu/drm/exynos/exynos_drm_plane.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_plane.c b/drivers/gpu/drm/exynos/exynos_drm_plane.c index 2dfb847..78fc0a1 100644 --- a/drivers/gpu/

[PATCH] Revert "drm/exynos: IOMMU support should not be selectable by user"

tree implementation, but not in mainline. Simplest solution seems to be to revert this patch such that the IOMMU driver is not built in on Arndale until it is fixed. Signed-off-by: Charles Keepax --- drivers/gpu/drm/exynos/Kconfig |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-)