s;
> };
>
> But dma heaps are casting both fd_flags and heap_flags into
> unsigned long. This patch makes dma heaps - cma heap and
> system heap have consistent types with UAPI.
>
> Signed-off-by: Barry Song
> ---
Looks good to me, thanks!
Reviewed-by: Carlos Llamas
in offset array to buffer holding the fd array
> * @parent_offset: start offset of fd array in the buffer
> @@ -162,12 +173,16 @@ enum {
> */
> struct binder_fd_array_object {
> struct binder_object_header hdr;
> - __u32 pad;
> + __u32 flags;
> binder_size_t num_fds;
> binder_size_t parent;
> binder_size_t parent_offset;
> };
>
> +enum {
> + BINDER_FDA_FLAG_XFER_CHARGE = BINDER_FD_FLAG_XFER_CHARGE,
> +};
> +
I would prefer to drop this. It should avoid silly mistakes in
userspace similar to the typo in the commit message above.
> /*
> * On 64-bit platforms where user code may run in 32-bits the driver must
> * translate the buffer (and local binder) addresses appropriately.
> --
> 2.39.0.314.g84b9a713c41-goog
>
Thanks,
--
Carlos Llamas
