Re: [PATCH] drm/msm: dpu: Allocate proper amount for dpu_crtc_state

2018-12-05 Thread Bruce Wang
fc > fc fc > [ 10.660571] ^ > [ 10.665774] ffc0d9f06300: fc fc fc fc fc fc fc fc fc fc fc fc fc fc > fc fc > [ 10.673210] ffc0d9f06380: fc fc fc fc fc fc fc fc fc fc fc fc fc fc > fc fc > [ 10.680639] >

Re: [PATCH 09/11] drm/msm/dpu: Debugfs related cleanups

2018-10-23 Thread Bruce Wang
ded null checks. > > Signed-off-by: Jordan Crouse Reviewed-by: Bruce Wang > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_core_irq.c | 30 ++- > drivers/gpu/drm/msm/disp/dpu1/dpu_core_irq.h | 9 +--- > drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 17 --- > driv

Re: [PATCH 01/11] drm/msm/dpu: Remove dpu_dbg

2018-10-22 Thread Bruce Wang
on't error check these */ > - debugfs_create_file("status", 0600, > - dpu_enc->debugfs_root, dpu_enc, &debugfs_status_fops); > + debugfs_create_file("status", 0600, dpu_enc->debugfs_r

Re: [Freedreno] [PATCH 01/11] drm/msm/dpu: Remove dpu_dbg

2018-10-22 Thread Bruce Wang
On 10/18/2018 03:58 PM, Jordan Crouse wrote: The functions in dpu_dbg.c aren't used. The two main dump functions fail after a lookup from dpu_dbg_base.reg_base_list which turns out to never be populated and once those are removed the rest of the file doesn't make any sense. Signed-off-by: Jord

Re: [PATCH 11/11] drm/msm/dpu: Clean up dpu_media_info.h static inline functions

2018-10-19 Thread Bruce Wang
On Thu, Oct 18, 2018 at 3:59 PM Jordan Crouse wrote: > > Do some cleanup in the static inline functions defined in > dpu_media_info.h by cleaning up gotos and unneeded local > variables. > > Signed-off-by: Jordan Crouse Reviewed-by: Bruce Wang > --- > .

Re: [PATCH 07/11] drm/msm: Make irq_postinstall optional

2018-10-19 Thread Bruce Wang
On Thu, Oct 18, 2018 at 3:58 PM Jordan Crouse wrote: > > Allow the KMS operation 'irq_postinstall' to be optional > so that the target display drivers don't need to define > a dummy function if they don't need one. > > Signed-off-by: Jordan Crouse Reviewed

Re: [PATCH 08/11] drm/msm/dpu: Remove dpu_irq and unused functions

2018-10-19 Thread Bruce Wang
/msm/disp/dpu1/dpu_kms.c > index 7e3ba128cbaf..2a91881048c8 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c > @@ -706,10 +706,30 @@ static void _dpu_kms_set_encoder_mode(struct msm_kms > *kms, > enco

Re: [PATCH 04/11] drm/msm/dpu: Remove dpu_crtc_is_enabled()

2018-10-18 Thread Bruce Wang
own. > > Signed-off-by: Jordan Crouse Reviewed-by: Bruce Wang > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 17 ++--- > drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h | 9 - > 2 files changed, 6 insertions(+), 20 deletions(-) > > dif

Re: [PATCH 03/11] drm/msm/dpu: Remove dpu_crtc_get_mixer_height

2018-10-18 Thread Bruce Wang
On Thu, Oct 18, 2018 at 3:59 PM Jordan Crouse wrote: > > dpu_crtc_get_mixer_height() is only used once and the value it > returns can be easily derived from the calling function. > > Signed-off-by: Jordan Crouse Reviewed-by: Bruce Wang > --- > drivers/gpu/drm/msm/disp

Re: [PATCH 02/11] drm/msm/dpu: Use DEFINE_SHOW_ATTRIBUTE

2018-10-18 Thread Bruce Wang
On Thu, Oct 18, 2018 at 3:58 PM Jordan Crouse wrote: > > Use the standard DEFINE_SHOW_ATTRIBUTE macro for seq_file based > debugfs files instead of custom macros and hand-coded functions. > > Signed-off-by: Jordan Crouse Sorry! Suppressed CCs by accident Reviewed