&dispc->base_ovr[i]);
> + dev_dbg(dev, "%s: %u %s %d\n", __func__,
> + i, dispc->feat->ovr_name[i], r);
Same here.
> + if (r)
> + return r;
> +
> + r = dispc_iomap_resourc
Jyri Sarha wrote on Thu [2020-Jan-16 23:06:00 +0200]:
> Add entry for tidss DRM driver.
>
> Version history:
>
> v2: no change
>
> v3: - Move tidss entry after omapdrm
> - Add "T: git git://anongit.freedesktop.org/drm/drm-misc"
>
> v4: no change
>
> v5: no change
>
> v6: no change
>
ge
>
> v5: no change
>
> Signed-off-by: Jyri Sarha
Reviewed-by: Benoit Parrot
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
ef and maxItems
> - Add includes to dts example
> - reindent dts example
>
> v4: - Add descriptions to reg and clocks properties
> - Remove minItems when its value is the same as maxItems value
>
> v5: - itemize reg and clocks properties' descriptions
>
- reindent dts example
>
> v4: - Add descriptions to reg and clocks properties
> - Remove minItems when its value is the same as maxItems value
> - Remove ports node
>
> v5: - itemize reg and clocks properties' descriptions
>
fifo up to high-threshold value to
> minimize possibility of underflows.
>
> Co-developed-by: Tomi Valkeinen
> Signed-off-by: Jyri Sarha
Reviewed-by: Benoit Parrot
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
t; - there is no "vp" reg-name, only "wb" for write back
>
> Signed-off-by: Jyri Sarha
Reviewed-by: Benoit Parrot
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Daniel Vetter wrote on Fri [2019-Mar-15 11:50:57 +0100]:
> On Thu, Mar 14, 2019 at 08:44:45AM -0500, Benoit Parrot wrote:
> > During a suspend cycle the atomic state is saved to be used during the
> > restore cycle.
> >
> > However the current state duplication logic
Ville Syrjälä wrote on Thu [2019-Mar-14
17:31:29 +0200]:
> On Thu, Mar 14, 2019 at 08:44:45AM -0500, Benoit Parrot wrote:
> > During a suspend cycle the atomic state is saved to be used during the
> > restore cycle.
> >
> > However the current state duplication logic
private object state are properly saved and restored.
Signed-off-by: Benoit Parrot
---
drivers/gpu/drm/drm_atomic_helper.c | 16
1 file changed, 16 insertions(+)
diff --git a/drivers/gpu/drm/drm_atomic_helper.c
b/drivers/gpu/drm/drm_atomic_helper.c
index 540a77a2ade9..b108021cc092
Ping.
Benoit
Benoit Parrot wrote on Fri [2018-Oct-12 15:16:55 -0500]:
> This patch series adds virtual-plane support to omapdrm driver to allow the
> use
> of display wider than 2048 pixels.
>
> In order to do so we introduce the concept of hw_overlay which can then be
> dyn
Daniel Vetter wrote on Tue [2018-Oct-16 14:29:46 +0200]:
> On Fri, Oct 12, 2018 at 03:17:00PM -0500, Benoit Parrot wrote:
> > Global shared resources (like hw overlays) for omapdrm are implemented
> > as a part of atomic state using the drm_private_obj infrastructure
> > av
omap_get_existing_global_state() are
the two variants that will be used to access omap_global_state.
Signed-off-by: Benoit Parrot
---
drivers/gpu/drm/omapdrm/omap_drv.c | 97 +-
drivers/gpu/drm/omapdrm/omap_drv.h | 23 +
2 files changed, 119 insertions(+), 1 deletion(-)
diff
Now that we added specific item to our subclassed drm_plane_state
we can add omap_plane_atomic_print_state() helper to dump out our own
driver specific plane state.
Signed-off-by: Benoit Parrot
---
drivers/gpu/drm/omapdrm/omap_plane.c | 18 ++
1 file changed, 18 insertions
second is then allocated if possible to handle
display wider then 2048.
This series replaces an earlier series which was DT based and using statically
allocated resources.
This implementation is inspired from the work done in msm/disp/mdp5
driver.
Benoit Parrot (8):
drm/omap: Add ability to
as export a helper function to retrieve the data so
check can be made dynamically in omap_plane_atomic_check().
Signed-off-by: Benoit Parrot
---
drivers/gpu/drm/omapdrm/dss/dispc.c | 24
drivers/gpu/drm/omapdrm/dss/omapdss.h | 2 ++
drivers/gpu/drm/omapdrm
re-assignment if required.
Signed-off-by: Benoit Parrot
---
drivers/gpu/drm/omapdrm/Makefile | 1 +
drivers/gpu/drm/omapdrm/omap_drv.c | 10 +++-
drivers/gpu/drm/omapdrm/omap_drv.h | 4 ++
drivers/gpu/drm/omapdrm/omap_overlay.c | 87 ++
drivers/gpu/
In preparation to add omap plane state specific extensions we need to
subclass drm_plane_state and add the relevant helpers.
The addition of specific extension will be done separately.
Signed-off-by: Benoit Parrot
---
drivers/gpu/drm/omapdrm/omap_plane.c | 48
cannot
be handled at that time. It is up to user space to make sure the H/W
resource are not over-subscribed.
Signed-off-by: Benoit Parrot
---
drivers/gpu/drm/omapdrm/omap_drv.c | 91 ++-
drivers/gpu/drm/omapdrm/omap_fb.c | 33 -
drivers/gpu/drm/oma
: Benoit Parrot
---
drivers/gpu/drm/omapdrm/dss/dispc.c | 8
drivers/gpu/drm/omapdrm/dss/omapdss.h | 4
2 files changed, 12 insertions(+)
diff --git a/drivers/gpu/drm/omapdrm/dss/dispc.c
b/drivers/gpu/drm/omapdrm/dss/dispc.c
index 70c3e3353947..ea8b57003620 100644
--- a/drivers/gpu
x27;t want
global state to become out of sync with the plane state if an atomic
update fails, we hit deadlock/ backoff scenario, etc. The use of
global_state_lock keeps multiple parallel updates which both re-assign
hwoverlays properly serialized.
Signed-off-by: Benoit Parrot
---
drivers/gp
retrieve the data so check can be made dynamically. We
currently add such a check in the dispc_ovl_setup() which will return an
error along with a WARN in case the required width exceed the overlay's
ability.
Signed-off-by: Benoit Parrot
---
drivers/gpu/drm/omapdrm/dss/dispc.c
reviewer to pay attention and comment on. You can find my
questions just before the omap_overlay_disable_unassigned() function in
drivers/gpu/drm/omapdrm/omap_overlay.c.
Benoit Parrot (3):
drm/omap: Add ability to check if requested plane modes can be
supported
drm/omap: Add ovl checking funcs
of requested planes
exceeds the numbers of overlays required to display them then a failure
would be returned for the plane that cannot be handled at that time. It
is up to user space to make sure the H/W resource are not
over-subscribed.
Signed-off-by: Benoit Parrot
---
drivers/gpu/drm/omapdrm
: Benoit Parrot
---
drivers/gpu/drm/omapdrm/dss/dispc.c | 8
drivers/gpu/drm/omapdrm/dss/omapdss.h | 4
2 files changed, 12 insertions(+)
diff --git a/drivers/gpu/drm/omapdrm/dss/dispc.c
b/drivers/gpu/drm/omapdrm/dss/dispc.c
index 1b7a6ef7897f..80ac1e68a036 100644
--- a/drivers/gpu
Reviewed-by: Benoit Parrot
Tomi Valkeinen wrote on Thu [2018-May-24 10:58:25
+0300]:
>
> On 24/05/18 01:03, Tony Lindgren wrote:
> > Hi all,
> >
> > I bisected the n900 LCD issue to commit 24aac6011f70 ("drm: omapdrm:
> > sdi: Allocate the sdi private data
For the series,
Reviewed-by: Benoit Parrot
Tomi Valkeinen wrote on Wed [2018-May-02 12:11:55
+0300]:
> Hi,
>
> This series has some minor fixes found by a static analysis tool, and one for
> missing linefeeds. As far as I know, we have never hit any of those errors.
>
&g
Laurent Pinchart wrote on Wed [2018-Apr-04
17:29:59 +0300]:
> Hi Benoit,
>
> Thank you for the patch.
>
> On Monday, 26 March 2018 19:21:24 EEST Benoit Parrot wrote:
> > Add common DISPC bindings into the top level bindings file.
> > Move common bindings here instea
Tomi Valkeinen wrote on Wed [2018-Apr-04 14:12:13
+0300]:
> On 26/03/18 19:21, Benoit Parrot wrote:
> > Currently available display mode from a connector are filtered out
> > based only on pixel clock capability. However we also need to filter
> > out wider mode if we cannot
able crtcs.
Physical planes which are not described will essentially be hidden
from the driver.
If no 'plane' child nodes exist then the normal plane
allocation will take place.
Signed-off-by: Benoit Parrot
---
drivers/gpu/drm/omapdrm/omap_drv.c | 127 +++--
dri
adding an optional 'plane' sub-node to
the generic DISPC node.
Signed-off-by: Benoit Parrot
---
.../devicetree/bindings/display/ti/ti,omap-dss.txt | 65 ++
1 file changed, 65 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/ti/ti,omap-dss.txt
b/Doc
ical video-pipeline(s)
and which video-outputs they are available on.
Signed-off-by: Benoit Parrot
---
drivers/gpu/drm/omapdrm/dss/dispc.c | 110 ++
drivers/gpu/drm/omapdrm/dss/omapdss.h | 11
2 files changed, 121 insertions(+)
diff --git a/drivers/gpu/drm/o
Add common DISPC bindings into the top level bindings file.
Move common bindings here instead of having multiple copies of
the same information in all of the variant specific files.
Signed-off-by: Benoit Parrot
Reviewed-by: Rob Herring
---
Documentation/devicetree/bindings/display/ti/ti,dra7
Add an exception case when filtering out display mode so that if
a virtual wide plane is available then display wider than 2048 can be
supported as long as the required timing parameters can also be met.
Signed-off-by: Benoit Parrot
---
drivers/gpu/drm/omapdrm/omap_connector.c | 3 ++-
drivers
Currently available display mode from a connector are filtered out
based only on pixel clock capability. However we also need to filter
out wider mode if we cannot handle them based on available pipeline
capabilities.
Signed-off-by: Benoit Parrot
---
drivers/gpu/drm/omapdrm/dss/dispc.c
d use terminology consistent with the Technical Reference Manual
- Fix the reported zpos issue by reusing and locally extending the
normalized zpos handling.
- Addressed Tomi's review comments
Benoit Parrot (6):
drm/omap: Add ability to filter out modes which can't be supported
dt-bindings: d
Rob Herring wrote on Fri [2018-Mar-02 13:19:13 -0600]:
> On Fri, Mar 2, 2018 at 7:48 AM, Benoit Parrot wrote:
> > Add 'plane' child node to generic DISPC node as an optional
> > property.
>
> Why? What problem are you solving?
Ah yes, I guess on its own it d
ch are not described will essentially be hidden
from the driver.
If no 'plane' child node exist then the existing plane
allocation will take place.
Signed-off-by: Benoit Parrot
---
drivers/gpu/drm/omapdrm/omap_drv.c | 18 +++--
drivers/gpu/drm/omapdrm/omap_fb.c| 66 +++-
Add 'plane' child node to generic DISPC node as an optional
property.
Signed-off-by: Benoit Parrot
---
.../devicetree/bindings/display/ti/ti,omap-dss.txt | 63 ++
1 file changed, 63 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/ti/ti,omap-
This patch series adds virtual-plane support to omapdrm driver
to allow the use of display wider than 2048 pixels.
The DT bindings are also cleaned up to remove duplication when
properties are common to all implementations.
Benoit Parrot (4):
dt-bindings: display/ti: Move common dispc bindings
and
which crtc they are available on.
Signed-off-by: Benoit Parrot
---
drivers/gpu/drm/omapdrm/dss/dispc.c | 110 ++
drivers/gpu/drm/omapdrm/dss/omapdss.h | 11
2 files changed, 121 insertions(+)
diff --git a/drivers/gpu/drm/omapdrm/dss/dispc.c
b/drive
Add common DISPC bindings into the top level bindings file.
Move common bindings here instead of having multiple copies of
the same information in all of the variant specific files.
Signed-off-by: Benoit Parrot
---
Documentation/devicetree/bindings/display/ti/ti,dra7-dss.txt | 5
Hi Benoit,
On Tue, Sep 24, 2013 at 11:29:51AM +0200, Benoit Cousson wrote:
> Hi Benoit,
>
> On 03/09/2013 16:55, Benoit Parrot wrote:
> >Hi,
> >
> >I have not received any feedback on this patch.
> >It has been pending since the end of June (first post).
> &g
Hi,
I have not received any feedback on this patch.
It has been pending since the end of June (first post).
Can I get an estimate when it will be included/accepted?
Thanks,
Benoit
On Fri, Aug 23, 2013 at 11:13:56AM -0500, Benoit Parrot wrote:
> Add LCDC device node in DT for am33xx
> Ad
Add LCDC device node in DT for am33xx
Add LCDC and Panel info in DT for am335x-evm
Changes in v3:
- rebase to 3.11-rc6
Changes in v2:
- remove redundant/unnecessary SoC specific setting in the board dts
Signed-off-by: Benoit Parrot
---
arch/arm/boot/dts/am335x-evm.dts | 72
Add LCDC device node in DT for am33xx
Add LCDC and Panel info in DT for am335x-evm
Changes in v3:
- rebase to 3.11-rc6
Changes in v2:
- remove redundant/unnecessary SoC specific setting in the board dts
Signed-off-by: Benoit Parrot
---
arch/arm/boot/dts/am335x-evm.dts | 72
The preferred_bpp value in currently hard-coded to 16.
This causes color corruption on the am335x-evm lcd panel which
requires 32 bpp instead. This changes attempts to use the configured
bpp value from the DT or built-in panel-info struct.
Signed-off-by: Benoit Parrot
---
drivers/gpu/drm/tilcdc
The preferred_bpp value in currently hard-coded to 16.
This causes color corruption on the am335x-evm lcd panel which
requires 32 bpp instead. This changes attempts to use the configured
bpp value from the DT or built-in panel-info struct.
Signed-off-by: Benoit Parrot
---
drivers/gpu/drm/tilcdc
48 matches
Mail list logo
