Re: [PATCH 1/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO NB04 devices

2024-10-22 Thread Benjamin Tissoires
Sorry I should have answered earlier... On Oct 09 2024, Werner Sembach wrote: > Resend because HTML mail ..., but I think I now know when Thunderbird does > it: Every time I include a link it gets converted. > > Hi > > Am 08.10.24 um 17:21 schrieb Benjamin Tissoires: > >

Re: [PATCH 1/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO NB04 devices

2024-10-22 Thread Benjamin Tissoires
On Oct 22 2024, Hans de Goede wrote: > Hi Armin, > > On 21-Oct-24 10:26 PM, Armin Wolf wrote: > > Am 11.10.24 um 17:26 schrieb Pavel Machek: > > > >> Hi! > >> > 1. > https://lore.kernel.org/all/6b32fb73-0544-4a68-95ba-e82406a4b...@gmx.de/ > -> Should be no problem? Because this is

Re: [PATCH 1/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO NB04 devices

2024-10-08 Thread Benjamin Tissoires
On Oct 08 2024, Werner Sembach wrote: > > Am 08.10.24 um 14:18 schrieb Benjamin Tissoires: > > On Oct 08 2024, Werner Sembach wrote: > > > Am 08.10.24 um 11:53 schrieb Benjamin Tissoires: > > > > On Oct 07 2024, Werner Sembach wrote: > > > > > Hi, &

Re: [PATCH 1/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO NB04 devices

2024-10-08 Thread Benjamin Tissoires
On Oct 08 2024, Werner Sembach wrote: > > Am 08.10.24 um 11:53 schrieb Benjamin Tissoires: > > On Oct 07 2024, Werner Sembach wrote: > > > Hi, > > > > > > Am 02.10.24 um 10:31 schrieb Benjamin Tissoires: > > > > On Oct 01 2024, Werner Sembach wr

Re: [PATCH 1/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO NB04 devices

2024-10-08 Thread Benjamin Tissoires
On Oct 07 2024, Werner Sembach wrote: > Hi, > > Am 02.10.24 um 10:31 schrieb Benjamin Tissoires: > > On Oct 01 2024, Werner Sembach wrote: > > > Hi Benjamin, > > > > > > Am 01.10.24 um 15:41 schrieb Benjamin Tissoires: > > > > [...] > >

Re: [PATCH 1/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO NB04 devices

2024-10-03 Thread Benjamin Tissoires
On Oct 02 2024, Armin Wolf wrote: > Am 02.10.24 um 10:42 schrieb Benjamin Tissoires: > > > On Oct 01 2024, Werner Sembach wrote: > > > Hi Armin, > > > > > > Am 01.10.24 um 18:45 schrieb Armin Wolf: > > [...snipped...] > > > > Why not h

Re: [PATCH 1/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO NB04 devices

2024-10-03 Thread Benjamin Tissoires
On Oct 03 2024, Pavel Machek wrote: > Hi! > > > > (Hint: it is LEDs below regular keyboard.) > > > > Yes, I know, and if you read this email and the few others, you'll read > > that I own a few of them already (for a long time), and I worked on a > > cross vendor userspace API to configure them.

Re: [PATCH 1/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO NB04 devices

2024-10-02 Thread Benjamin Tissoires
On Oct 02 2024, Pavel Machek wrote: > On Wed 2024-10-02 10:13:10, Benjamin Tissoires wrote: > > On Oct 01 2024, Pavel Machek wrote: > > > Hi! > > > > > > > PPS: sorry for pushing that hard on HID-BPF, but I can see that it fits > > > > all of

Re: [PATCH 1/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO NB04 devices

2024-10-02 Thread Benjamin Tissoires
On Oct 01 2024, Werner Sembach wrote: > Hi Armin, > > Am 01.10.24 um 18:45 schrieb Armin Wolf: [...snipped...] > > Why not having a simple led driver for HID LampArray devices which exposes > > the > > whole LampArray as a single LED? > Yes that is my plan, but see my last reply to Benjamin, it m

Re: [PATCH 1/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO NB04 devices

2024-10-02 Thread Benjamin Tissoires
On Oct 01 2024, Werner Sembach wrote: > Hi Benjamin, > > Am 01.10.24 um 15:41 schrieb Benjamin Tissoires: > > On Oct 01 2024, Werner Sembach wrote: > > > (sorry resend because thunderbird made it a html mail) > > > > > > Hi, > > > &g

Re: [PATCH 1/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO NB04 devices

2024-10-02 Thread Benjamin Tissoires
On Oct 01 2024, Pavel Machek wrote: > Hi! > > > PPS: sorry for pushing that hard on HID-BPF, but I can see that it fits > > all of the requirements here: > > - need to be dynamic > > - still unsure of the userspace implementation, meaning that userspace > > might do something wrong, which might

Re: [PATCH 1/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO NB04 devices

2024-10-01 Thread Benjamin Tissoires
On Oct 01 2024, Werner Sembach wrote: > (sorry resend because thunderbird made it a html mail) > > Hi, > > Am 30.09.24 um 19:06 schrieb Benjamin Tissoires: > > On Sep 30 2024, Werner Sembach wrote: > > > [...] > > > Thinking about it, maybe it's

Re: [PATCH 1/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO NB04 devices

2024-09-30 Thread Benjamin Tissoires
On Sep 30 2024, Werner Sembach wrote: > Hi, > > Am 30.09.24 um 18:15 schrieb Benjamin Tissoires: > > On Sep 30 2024, Werner Sembach wrote: > > > Am 28.09.24 um 12:05 schrieb Benjamin Tissoires: > > > > On Sep 28 2024, Werner Sembach wrote: > > > >

Re: [PATCH 1/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO NB04 devices

2024-09-30 Thread Benjamin Tissoires
On Sep 30 2024, Werner Sembach wrote: > Am 28.09.24 um 12:05 schrieb Benjamin Tissoires: > > On Sep 28 2024, Werner Sembach wrote: > > > Hi, > > > > > > Am 28.09.24 um 09:27 schrieb Benjamin Tissoires: > > > > On Sep 28 2024, Armin Wolf wrote: >

Re: [PATCH 1/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO NB04 devices

2024-09-28 Thread Benjamin Tissoires
On Sep 28 2024, Werner Sembach wrote: > Hi, > > Am 28.09.24 um 09:27 schrieb Benjamin Tissoires: > > On Sep 28 2024, Armin Wolf wrote: > > > Am 27.09.24 um 23:01 schrieb Pavel Machek: > > > > > > > Hi! > > > > > > > >

Re: [PATCH 1/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO NB04 devices

2024-09-28 Thread Benjamin Tissoires
On Sep 28 2024, Armin Wolf wrote: > Am 27.09.24 um 23:01 schrieb Pavel Machek: > > > Hi! > > > > > The TUXEDO Sirius 16 Gen1 and TUXEDO Sirius 16 Gen2 devices have a per-key > > > controllable RGB keyboard backlight. The firmware API for it is > > > implemented > > > via WMI. > > Ok. > > > > >

Re: [PATCH v5 7/10] HID: multitouch: allow specifying if a device is direct in a class

2024-09-27 Thread Benjamin Tissoires
On Aug 17 2024, Aditya Garg wrote: > From: Kerem Karabay > > Currently the driver determines the device type based on the > application, but this value is not reliable on Apple Touch Bars, where > the application is HID_DG_TOUCHPAD even though the devices are direct, > so allow setting it in clas

Re: [WHY SUCH DELAY!] Touch Bar support for T2 Macs

2024-09-27 Thread Benjamin Tissoires
On Sep 26 2024, Aditya Garg wrote: > It has been more than a month since I've sent this patch set and I haven't > got a clear yes or not for the same. I understand maintainers are busy > people, but I'd really appreciate if I get some response for this series of > patches from the HID and DRM ma

Re: [PATCH v5 4/10] HID: multitouch: support getting the contact ID from HID_DG_TRANSDUCER_INDEX fields

2024-09-27 Thread Benjamin Tissoires
On Aug 17 2024, Aditya Garg wrote: > From: Kerem Karabay > > This is needed to support Apple Touch Bars, where the contact ID is > contained in fields with the HID_DG_TRANSDUCER_INDEX usage. > > Signed-off-by: Kerem Karabay > Signed-off-by: Aditya Garg > --- > drivers/hid/hid-multitouch.c | 5

Re: [PATCH 0/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO NB04

2024-09-27 Thread Benjamin Tissoires
On Sep 26 2024, Werner Sembach wrote: > Hi, > took some time but now a first working draft of the suggested new way of > handling per-key RGB keyboard backlights is finished. See: > https://lore.kernel.org/all/1fb08a74-62c7-4d0c-ba5d-648e23082...@tuxedocomputers.com/ > First time for me sending a w

Re: [PATCH v5 2/10] HID: hid-appletb-kbd: add driver for the keyboard mode

2024-09-27 Thread Benjamin Tissoires
On Aug 17 2024, Aditya Garg wrote: > From: Kerem Karabay > > The Touch Bars found on x86 Macs support two USB configurations: one > where the device presents itself as a HID keyboard and can display > predefined sets of keys, and one where the operating system has full > control over what is disp

Re: [PATCH v1 1/2] dt-bindings: HID: i2c-hid: elan: Introduce Elan ekth6a12nay

2024-07-12 Thread Benjamin Tissoires
On Jul 04 2024, Zhaoxiong Lv wrote: > The Elan ekth6a12nay touch screen chip same as Elan eKTH6915 controller > has a reset gpio. The difference is that they have different > post_power_delay_ms. > > Signed-off-by: Zhaoxiong Lv > --- > Documentation/devicetree/bindings/input/elan,ekth6915.yaml |

Re: In kernel virtual HID devices (was Future handling of complex RGB devices on Linux v3)

2024-03-27 Thread Benjamin Tissoires
On Mar 26 2024, Werner Sembach wrote: > Hi all, > > Am 26.03.24 um 16:39 schrieb Benjamin Tissoires: > > On Mar 26 2024, Werner Sembach wrote: > > > Hi all, > > > > > > Am 25.03.24 um 19:30 schrieb Hans de Goede: > > > > > > [snip] &

Re: In kernel virtual HID devices (was Future handling of complex RGB devices on Linux v3)

2024-03-26 Thread Benjamin Tissoires
On Mar 26 2024, Werner Sembach wrote: > Hi all, > > Am 25.03.24 um 19:30 schrieb Hans de Goede: > > [snip] > > > > If the kernel already handles the custom protocol into generic HID, the > > > > work for userspace is not too hard because they can deal with a known > > > > protocol and can be cros

Re: In kernel virtual HID devices (was Future handling of complex RGB devices on Linux v3)

2024-03-25 Thread Benjamin Tissoires
On Mar 25 2024, Hans de Goede wrote: > +Cc: Bentiss, Jiri > > Hi Werner, > > On 3/20/24 12:16 PM, Werner Sembach wrote: > > Hi Hans and the others, > > > > Am 22.02.24 um 14:14 schrieb Werner Sembach: > >> Hi, > >> > >> Thanks everyone for the exhaustive feedback. And at least this thread is a

Re: [PATCH v4 00/11] drm/panel and i2c-hid: Allow panels and touchscreens to power sequence together

2023-07-28 Thread Benjamin Tissoires
r as I can tell, as of v4 everyone is on the same page that this > patch series looks like a reasonable solution to the problem and we > just need to get all the nits fixed and figure out how to land it. Thanks a lot for the new version. I like it much more on the HID side: for the HID part: Revie

Re: [PATCH v3 08/10] HID: i2c-hid: Support being a panel follower

2023-07-26 Thread Benjamin Tissoires
On Jul 26 2023, Doug Anderson wrote: > Hi, > > On Wed, Jul 26, 2023 at 1:57 AM Benjamin Tissoires wrote: > > > > > @@ -1143,7 +1208,14 @@ void i2c_hid_core_remove(struct i2c_client *client) > > > struct i2c_hid *ihid = i2c_get_clientdata(client); &

Re: [PATCH v3 08/10] HID: i2c-hid: Support being a panel follower

2023-07-26 Thread Benjamin Tissoires
On Jul 25 2023, Douglas Anderson wrote: > As talked about in the patch ("drm/panel: Add a way for other devices > to follow panel state"), we really want to keep the power states of a > touchscreen and the panel it's attached to in sync with each other. In > that spirit, add support to i2c-hid to b

Re: [PATCH v2 08/10] HID: i2c-hid: Support being a panel follower

2023-07-26 Thread Benjamin Tissoires
On Jul 25 2023, Doug Anderson wrote: > Hi, > > On Mon, Jul 17, 2023 at 11:15 AM Doug Anderson wrote: > > > > Benjamin, > > > > On Mon, Jun 26, 2023 at 3:49 PM Doug Anderson wrote: > > > > > > Benjamin, > > > > >

Re: [PATCH 10/17] hid/picolcd: Remove flag FBINFO_FLAG_DEFAULT from fbdev driver

2023-07-10 Thread Benjamin Tissoires
cleaning > up all occurences of FBINFO_FLAG_DEFAULT, the token can be removed. > > Signed-off-by: Thomas Zimmermann > Cc: "Bruno Prémont" > Cc: Jiri Kosina > Cc: Benjamin Tissoires Acked-by: Benjamin Tissoires Feel free to take this through the DRI tree (or any othe

Re: [PATCH v2 08/10] HID: i2c-hid: Support being a panel follower

2023-06-09 Thread Benjamin Tissoires
On Thu, Jun 8, 2023 at 6:43 PM Doug Anderson wrote: > > Hi, > > On Thu, Jun 8, 2023 at 8:37 AM Benjamin Tissoires > wrote: > > > > > > On Jun 07 2023, Douglas Anderson wrote: > > > > > > As talked about in the patch ("drm/panel: Add a

Re: [PATCH v2 08/10] HID: i2c-hid: Support being a panel follower

2023-06-08 Thread Benjamin Tissoires
On Jun 07 2023, Douglas Anderson wrote: > > As talked about in the patch ("drm/panel: Add a way for other devices > to follow panel state"), we really want to keep the power states of a > touchscreen and the panel it's attached to in sync with each other. In > that spirit, add support to i2c-hid

Re: [PATCH V3 6/13] input: serio: use time_is_before_jiffies() instead of open coding it

2022-02-15 Thread Benjamin Tissoires
On Tue, Feb 15, 2022 at 2:57 AM Qing Wang wrote: > > From: Wang Qing > > Use the helper function time_is_{before,after}_jiffies() to improve > code readability. > > Signed-off-by: Wang Qing > --- Reviewed-by: Benjamin Tissoires Cheers, Benjamin > drivers

Re: [PATCH V3 5/13] hid: use time_is_after_jiffies() instead of open coding it

2022-02-15 Thread Benjamin Tissoires
On Tue, Feb 15, 2022 at 2:56 AM Qing Wang wrote: > > From: Wang Qing > > Use the helper function time_is_{before,after}_jiffies() to improve > code readability. > > Signed-off-by: Wang Qing > Acked-by: Srinivas Pandruvada FWIW, this one is Acked-by: Benjamin Tissoi

Re: [RESEND 00/25] Rid W=1 warnings from HID

2021-04-08 Thread Benjamin Tissoires
On Thu, Apr 8, 2021 at 9:06 AM Lee Jones wrote: > > On Wed, 07 Apr 2021, Benjamin Tissoires wrote: > > > On Tue, Apr 6, 2021 at 10:56 AM Lee Jones wrote: > > > > > > On Fri, 26 Mar 2021, Lee Jones wrote: > > > > > > > This set is part of a l

Re: [RESEND 00/25] Rid W=1 warnings from HID

2021-04-07 Thread Benjamin Tissoires
On Tue, Apr 6, 2021 at 10:56 AM Lee Jones wrote: > > On Fri, 26 Mar 2021, Lee Jones wrote: > > > This set is part of a larger effort attempting to clean-up W=1 > > kernel builds, which are currently overwhelmingly riddled with > > niggly little warnings. > > > > Lee Jones (25): > > HID: intel-is

Re: [PATCH 3/3] video: fbdev: don't print error message on framebuffer_alloc() failure

2019-07-01 Thread Benjamin Tissoires
s > what the majority of framebuffer_alloc() users is doing already). > > Cc: "Bruno Prémont" > Cc: Jiri Kosina > Cc: Benjamin Tissoires > Signed-off-by: Bartlomiej Zolnierkiewicz > --- > drivers/hid/hid-picolcd_fb.c |4 +--- > driv

Re: [git pull] drm tree for 3.12-rc1

2013-09-11 Thread Benjamin Tissoires
On Fri, Sep 6, 2013 at 2:56 AM, Linus Torvalds wrote: > On Thu, Sep 5, 2013 at 4:19 PM, Linus Torvalds > wrote: >> >> So I've decided I'm going to try to bisect this after all. I've done >> enough pulls for today anyway, I guess. Let's see if I can bisect it >> by just trying to boot many times e

[Dual-LVDS Acer Iconia laptop] i915/DRM issue: one screen stays off [3.2-rc4+]

2011-12-08 Thread Benjamin Tissoires
Hi, On Tue, Dec 6, 2011 at 23:31, Baptiste Jonglez wrote: > On Tue, Dec 06, 2011 at 11:12:26PM +0100, Benjamin Tissoires wrote: >> Hi Baptiste, > > Hi, > >> On Tue, Dec 6, 2011 at 22:51, Baptiste Jonglez >> wrote: >> > The second screen works fine with th

Re: [Dual-LVDS Acer Iconia laptop] i915/DRM issue: one screen stays off [3.2-rc4+]

2011-12-08 Thread Benjamin Tissoires
Hi, On Tue, Dec 6, 2011 at 23:31, Baptiste Jonglez wrote: > On Tue, Dec 06, 2011 at 11:12:26PM +0100, Benjamin Tissoires wrote: >> Hi Baptiste, > > Hi, > >> On Tue, Dec 6, 2011 at 22:51, Baptiste Jonglez wrote: >> > The second screen works fine with the atta

Re: [Dual-LVDS Acer Iconia laptop] i915/DRM issue: one screen stays off [3.2-rc4+]

2011-12-07 Thread Benjamin Tissoires
Hi Baptiste, On Tue, Dec 6, 2011 at 22:51, Baptiste Jonglez wrote: > On Mon, Dec 05, 2011 at 11:00:41AM +0800, joeyli wrote: >> Add Cc. to platform-driver-x86 and linux-acpi >> >> Hi Baptiste >> >> 於 日,2011-12-04 於 17:07 +0100,Baptiste Jonglez 提到: >> > Hi, >> > >> > I've got a lot of troubles wit

[Dual-LVDS Acer Iconia laptop] i915/DRM issue: one screen stays off [3.2-rc4+]

2011-12-06 Thread Benjamin Tissoires
Hi Baptiste, On Tue, Dec 6, 2011 at 22:51, Baptiste Jonglez wrote: > On Mon, Dec 05, 2011 at 11:00:41AM +0800, joeyli wrote: >> Add Cc. to platform-driver-x86 and linux-acpi >> >> Hi Baptiste >> >> ? ??2011-12-04 ? 17:07 +0100?Baptiste Jonglez ??? >> > Hi, >> > >> > I've got a lot of troubles wit