On 21/3/25 04:18, Danilo Krummrich wrote:
Hi Mel,
On Wed, Mar 12, 2025 at 05:36:14PM -0400, Mel Henning wrote:
Userspace needs this information to set up zcull correctly.
This is a very brief motivation for the commit, please also describe what the
commit does using imperative form.
Signed-
On 9/1/25 13:42, Ben Skeggs wrote:
On 9/1/25 10:55, Dave Airlie wrote:
From: Dave Airlie
This is the 3rd iteration of this after talking to Ben and
Danilo, I think this makes sense now.
The fence sync logic doesn't handle a fence sync across devices
as it tries to write to a channel o
space,
the channel offsets are therefore okay to pass between sides,
so one channel can sync on the seqnos from the other by using
the offset into it's vma.
Signed-off-by: Dave Airlie
Signed-off-by: Ben Skeggs
Cc: sta...@vger.kernel.org
---
drivers/gpu/drm/nouveau/nouveau_fence.c | 6
uck before this.
Signed-off-by: Dave Airlie
Cc: sta...@vger.kernel.org
Reviewed-by: Ben Skeggs
---
drivers/gpu/drm/nouveau/nouveau_fence.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nouveau_fence.c
b/drivers/gpu/drm/nouveau/nouvea
panels after a suspend/resume cycle.
This works fine on my laptop (though it doesn't fix the issues I see
there unfortunately).
The handling of -EAGAIN can be removed here too, but aside from that:
Reviewed-by: Ben Skeggs
Fixes: eb284f4b3781 ("drm/nouveau/dp: Honor GSP link trai
-off-by: Benjamin Szőke
Reviewed-by: Ben Skeggs
---
drivers/gpu/drm/nouveau/nvkm/subdev/i2c/Kbuild | 2 +-
drivers/gpu/drm/nouveau/nvkm/subdev/i2c/anx9805.c | 2 +-
drivers/gpu/drm/nouveau/nvkm/subdev/i2c/{aux.c => auxch.c} | 2 +-
drivers/gpu/drm/nouveau/nvkm/sub
On 28/8/24 12:37, Dave Airlie wrote:
From: Dave Airlie
This aligns with what open gpu does, the 0x15 hex is just to trick you.
Fixes: 176fdcbddfd2 ("drm/nouveau/gsp/r535: add support for booting GSP-RM")
Reviewed-by: Ben Skeggs
---
drivers/gpu/drm/nouveau/nvkm/subdev/gsp/f
series applied.
Ben.
Reviewed-by: Ben Skeggs
- Danilo
Danilo Krummrich (3):
drm/nouveau: prime: fix refcount underflow
drm/nouveau: bo: remove unused functions
drm/nouveau: use GEM references instead of TTMs
drivers/gpu/drm/nouveau/dispnv04/crtc.c | 43
On 18/6/24 03:30, Danilo Krummrich wrote:
On Fri, Jun 14, 2024 at 03:02:09AM +1000, Ben Skeggs wrote:
NVIDIA has been exploring ways to better support the effort for an
upstream kernel mode driver for GPUs that are capable of running GSP-RM
firmware, since the introduction[1] to Nova.
Use
On 17/6/24 23:55, Daniel Vetter wrote:
On Fri, Jun 14, 2024 at 03:02:09AM +1000, Ben Skeggs wrote:
NVIDIA has been exploring ways to better support the effort for an
upstream kernel mode driver for GPUs that are capable of running GSP-RM
firmware, since the introduction[1] to Nova.
Use cases
in a
busy CPU loop.
Signed-off-by: Dave Airlie
Reviewed-by: Ben Skeggs
---
drivers/gpu/drm/nouveau/nouveau_bo.c| 2 +-
drivers/gpu/drm/nouveau/nouveau_chan.c | 2 +-
drivers/gpu/drm/nouveau/nouveau_dmem.c | 2 +-
drivers/gpu/drm/nouveau/nouveau_fence.c
Signed-off-by: Ben Skeggs
---
drivers/gpu/drm/nouveau/nouveau_vga.c | 27
.../gpu/drm/nouveau/nvkm/subdev/pci/base.c| 32 +++
2 files changed, 32 insertions(+), 27 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nouveau_vga.c
b/drivers/gpu/drm
03-module
*** BLURB HERE ***
Ben Skeggs (2):
drm/nouveau/nvkm: export symbols needed by the drm driver
drm/nouveau/nvkm: separate out into nvkm.ko
drivers/gpu/drm/nouveau/Kbuild | 4 ++--
drivers/gpu/drm/nouveau/include/nvkm/core/module.h | 3 ---
drivers/gpu/drm/n
Signed-off-by: Ben Skeggs
---
drivers/gpu/drm/nouveau/include/nvkm/core/device.h | 1 +
drivers/gpu/drm/nouveau/nouveau_drm.c | 5 -
drivers/gpu/drm/nouveau/nvkm/device/base.c | 6 ++
drivers/gpu/drm/nouveau/nvkm/device/pci.c | 11 +++
4 files
Signed-off-by: Ben Skeggs
---
.../gpu/drm/nouveau/include/nvkm/core/pci.h | 2 +
drivers/gpu/drm/nouveau/nouveau_drm.c | 61 --
drivers/gpu/drm/nouveau/nouveau_drv.h | 2 -
drivers/gpu/drm/nouveau/nvkm/device/pci.c | 62 +++
4 files changed
Moves the PCI-specific portions of nouveau_pmops to NVKM, leaving the
DRM pieces where they are. The NVKM functions are called through the
the nvkm_device_pci_driver struct from DRM for now, but will be fully
separated once the DRM driver is implemented on an auxiliary device.
Signed-off-by: Ben
Signed-off-by: Ben Skeggs
---
drivers/gpu/drm/nouveau/nouveau_drm.c | 3 ---
drivers/gpu/drm/nouveau/nvkm/device/pci.c | 5 +
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nouveau_drm.c
b/drivers/gpu/drm/nouveau/nouveau_drm.c
index 632635c16b88
The DRM driver uses "nouveau_is_optimus() || nouveau_is_v1_dsm()", which
have been moved to NVKM, to determine support for runtime pm.
Replace with a feature flag returned when allocating an nvif_device.
Signed-off-by: Ben Skeggs
---
drivers/gpu/drm/nouveau/include/nvif/drive
ces the event() function pointer that was passed to
nvkm_driver_ctor() during init with a nvif_driver_func struct, that
contains the existing event() callback.
Signed-off-by: Ben Skeggs
---
drivers/gpu/drm/nouveau/include/nvif/driverif.h| 4
drivers/gpu/drm/nouveau/include/nvif/even
Signed-off-by: Ben Skeggs
---
.../gpu/drm/nouveau/include/nvkm/core/pci.h | 1 -
drivers/gpu/drm/nouveau/nouveau_drm.c | 11 +---
drivers/gpu/drm/nouveau/nvkm/device/pci.c | 28 ++-
3 files changed, 3 insertions(+), 37 deletions(-)
diff --git a/drivers/gpu/drm
ctor().
A later patch turns these into pci/platform driver probe() functions,
so they need to learn how to clean up after themselves regardless.
Signed-off-by: Ben Skeggs
---
drivers/gpu/drm/nouveau/nouveau_drm.c | 2 +-
drivers/gpu/drm/nouveau/nvkm/device/pci.c | 26 ++---
d
Return an enum rather than an int from nvif_event callbacks.
Also moves the NVIF_EVENT_* definitions to driverif.h, with the
rest of the DRM<->NVKM interfaces.
Signed-off-by: Ben Skeggs
---
drivers/gpu/drm/nouveau/dispnv04/crtc.c | 4 ++--
drivers/gpu/drm/nouveau/dispnv04/
Signed-off-by: Ben Skeggs
---
drivers/gpu/drm/nouveau/Kbuild | 4 ++--
drivers/gpu/drm/nouveau/include/nvkm/core/module.h | 3 ---
drivers/gpu/drm/nouveau/nouveau_drm.c | 10 +-
drivers/gpu/drm/nouveau/nvkm/module.c | 8 ++--
4 files
The primary interfaces to NVKM are through NVIF, but there are a small
number of functions which are called directly.
Signed-off-by: Ben Skeggs
---
drivers/gpu/drm/nouveau/nvkm/core/driver.c | 1 +
drivers/gpu/drm/nouveau/nvkm/core/gpuobj.c | 2 ++
drivers/gpu/drm/nouveau/nvkm
Signed-off-by: Ben Skeggs
---
drivers/gpu/drm/nouveau/nouveau_acpi.c | 344 -
drivers/gpu/drm/nouveau/nouveau_acpi.h | 7 +-
drivers/gpu/drm/nouveau/nouveau_drm.c | 2 -
drivers/gpu/drm/nouveau/nvkm/device/acpi.c | 339 +++-
drivers/gpu/drm
The move and renames were kept separate for cleaner diffs.
Signed-off-by: Ben Skeggs
---
drivers/gpu/drm/nouveau/nvkm/device/acpi.c | 113 ++--
drivers/gpu/drm/nouveau/nvkm/device/acpi.h | 4 +-
drivers/gpu/drm/nouveau/nvkm/device/pci.c | 8 +-
drivers/gpu/drm/nouveau
mit will help make that switch cleaner.
Signed-off-by: Ben Skeggs
---
drivers/gpu/drm/nouveau/dispnv50/disp.c | 31 ---
drivers/gpu/drm/nouveau/nouveau_connector.c | 12 ++-
drivers/gpu/drm/nouveau/nouveau_connector.h | 1 +
drivers/gpu/drm/nouveau/nouveau_debugfs.c | 24 +++---
drivers
e DRM driver for the rest.
Signed-off-by: Ben Skeggs
---
.../gpu/drm/nouveau/include/nvif/driverif.h | 7 ++
.../gpu/drm/nouveau/include/nvkm/core/pci.h | 2 +
drivers/gpu/drm/nouveau/nouveau_acpi.c| 8 --
drivers/gpu/drm/nouveau/nouveau_acpi.h| 4 -
drivers/gpu/drm/no
t can gain access to the nvkm_device and proceed as it did before.
Signed-off-by: Ben Skeggs
---
drivers/gpu/drm/nouveau/Kbuild| 1 -
drivers/gpu/drm/nouveau/dispnv50/disp.c | 9 +-
drivers/gpu/drm/nouveau/nouveau_display.c | 2 +-
drivers/gpu/drm/nouveau/nou
.
Signed-off-by: Ben Skeggs
---
.../gpu/drm/nouveau/include/nvkm/core/pci.h | 3 +-
.../gpu/drm/nouveau/include/nvkm/core/tegra.h | 5 +--
drivers/gpu/drm/nouveau/nouveau_drm.c | 13 ---
drivers/gpu/drm/nouveau/nouveau_platform.c| 2 +
drivers/gpu/drm/nouveau/nvkm/device
The NVIF/NVKM comments were backwards.
Signed-off-by: Ben Skeggs
---
drivers/gpu/drm/nouveau/Kbuild | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/Kbuild b/drivers/gpu/drm/nouveau/Kbuild
index f99b7b227947..61eeef83847a 100644
--- a
This commit registers a device on the aux bus after core NVKM init
has finished, which will be used by a later commit to have the DRM
driver probe() against an aux device instead of a PCI or platform
device (in the case of Tegra).
Signed-off-by: Ben Skeggs
---
drivers/gpu/drm/nouveau/Kconfig
Add stub init()/exit() functions that subsequent patches will use as
they move the pci/platform-specific code out of the DRM driver.
Signed-off-by: Ben Skeggs
---
.../drm/nouveau/include/nvkm/core/module.h| 8 +
drivers/gpu/drm/nouveau/nouveau_drm.c | 9 +
drivers/gpu/drm
A later patch in this series moves the nvif_event callback function,
but all the callers directly dereference object->client->event().
Add a helper function so this only has to be changed in one place.
Signed-off-by: Ben Skeggs
---
drivers/gpu/drm/nouveau/include/nvkm/core/client
first
nvif_device, which will allow the DRM driver a chance to override
device.{cfg,dbg}opt before they're needed.
Signed-off-by: Ben Skeggs
---
drivers/gpu/drm/nouveau/nouveau_drm.c | 3 +
drivers/gpu/drm/nouveau/nvkm/device/base.c | 112
drivers/gpu/drm/nouveau/nvkm/de
o other steps need
to be taken, greatly reducing resume latency.
A link to a tree containing the patches is below.
[1] https://gitlab.freedesktop.org/bskeggs/nouveau/-/tree/00.02-auxdev
Ben Skeggs (21):
drm/nouveau: fix a couple of KBuild comments
drm/nouveau/nvkm: delay calling subdev ctor()&
1aadb1eb8d ("nouveau: don't fail driver load if no display hw
present.")
Link: https://gitlab.freedesktop.org/drm/nouveau/-/issues/337
Signed-off-by: Vasily Khoruzhick
Reviewed-by: Ben Skeggs
---
v2: drop extra checks in nouveau_display_hpd_work() and
nouveau_connector_hpd()
On 3/6/24 09:27, Szőke Benjamin wrote:
2024. 06. 03. 0:08 keltezéssel, Ben Skeggs írta:
On 2/6/24 07:22, egyszer...@freemail.hu wrote:
From: Benjamin Szőke
The goal is to clean-up Linux repository from AUX file names, because
the use of such file names is prohibited on other operating
ers/gpu/drm/nouveau/nvkm/subdev/i2c/auxg94.c
b/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/auxg94.c
index 47068f6f9c55..9e07ba444ca8 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/auxg94.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/auxg94.c
@@ -22,7 +22,7 @@
* Authors: Ben Skeggs
*
On 29/5/24 07:52, Vasily Khoruzhick wrote:
If the card doesn't have display hardware, hpd_work and hpd_lock are
left uninitialized which causes BUG when attempting to schedule hpd_work
on runtime PM resume.
Hi,
Good catch, thank you for looking at this. A couple of initial comments
below:
On Sat, 8 Jul 2023 at 07:59, Lyude Paul wrote:
>
> Currently we use the drm_dp_dpcd_read_caps() helper in the DRM side of
> nouveau in order to read the DPCD of a DP connector, which makes sure we do
> the right thing and also check for extended DPCD caps. However, it turns
> out we're not current
at least this part.
>
> v2: Only do it for NV11+ GPUs
>
> Closes: https://gitlab.freedesktop.org/drm/nouveau/-/issues/201
> Fixes: 4a16dd9d18a0 ("drm/nouveau/kms: switch to drm fbdev helpers")
> Signed-off-by: Karol Herbst
Reviewed-by: Ben Skeggs
> ---
> driv
On Thu, 13 Jul 2023 at 05:31, Dave Airlie wrote:
>
> On Tue, 23 May 2023 at 19:37, Karol Herbst wrote:
> >
> > On Mon, May 22, 2023 at 10:18 PM Karol Herbst wrote:
> > >
> > > This fixes a NULL pointer access inside nvkm_acr_oneinit in case necessary
> > > firmware files couldn't be loaded.
> >
in a rebase somehow.
Reviewed-by: Ben Skeggs
> ---
> drivers/gpu/drm/nouveau/nvkm/subdev/fb/gf108.c | 1 +
> drivers/gpu/drm/nouveau/nvkm/subdev/fb/gk104.c | 1 +
> drivers/gpu/drm/nouveau/nvkm/subdev/fb/gk110.c | 1 +
> drivers/gpu/drm/nouveau/nvkm/subdev/fb/gm107.c | 1 +
> 4
On Mon, 20 Feb 2023 at 21:27, Karol Herbst wrote:
>
> On Mon, Feb 20, 2023 at 11:51 AM Chris Clayton
> wrote:
> >
> >
> >
> > On 20/02/2023 05:35, Ben Skeggs wrote:
> > > On Sun, 19 Feb 2023 at 04:55, Chris Clayton
> > > wrote:
> > &
are all built as modules, So, by
> >>> the time the devices are configured via udev, the root partition is
> >>> mounted and the drivers can get at the firmware.
> >>>
> >>> I've found, by turning on nouveau debug and taking a video of the screen
> >>>
On Tue, 31 Jan 2023 at 09:09, Chris Clayton wrote:
>
> Hi again.
>
> On 30/01/2023 20:19, Chris Clayton wrote:
> > Thanks, Ben.
>
>
>
> >> Hey,
> >>
> >> This is a complete shot-in-the-dark, as I don't see this behaviour on
> >> *any* of my boards. Could you try the attached patch please?
> >
>
On Tue, 31 Jan 2023 at 09:19, Lyude Paul wrote:
>
> For the whole series:
>
> Reviewed-by: Lyude Paul
>
> Will push to drm-misc-fixes in just a moment
Thank you Lyude! Much appreciated.
Ben.
>
> On Tue, 2023-01-31 at 08:37 +1000, Ben Skeggs wrote:
> > Starting
Missed some Tegra-specific quirks when reworking ACR to support Ampere.
Fixes: 2541626cfb79 ("drm/nouveau/acr: use common falcon HS FW code for ACR
FWs")
Signed-off-by: Ben Skeggs
Tested-by: Diogo Ivo
Tested-By: Nicolas Chauvet
---
drivers/gpu/drm/nouveau/nvkm/core/firmware
Turing apparently needs to use the same register we use on Ampere.
Not executing the scrubber ucode when required would result in large
areas of VRAM being inaccessible to the driver.
Signed-off-by: Ben Skeggs
---
.../gpu/drm/nouveau/include/nvkm/subdev/fb.h | 1 +
.../gpu/drm/nouveau/nvkm
some systems, where we get
control of the HW before it's been fully reinitialised after resume from
suspend.
Signed-off-by: Ben Skeggs
---
.../drm/nouveau/nvkm/subdev/devinit/tu102.c | 23 +++
1 file changed, 23 insertions(+)
diff --git a/drivers/gpu/drm/nouveau/nvkm/s
On Sat, 28 Jan 2023 at 21:29, Chris Clayton wrote:
>
>
>
> On 28/01/2023 05:42, Linux kernel regression tracking (Thorsten Leemhuis)
> wrote:
> > On 27.01.23 20:46, Chris Clayton wrote:
> >> [Resend because the mail client on my phone decided to turn HTML on behind
> >> my back, so my reply got
On Fri, 27 Jan 2023 at 20:42, Diogo Ivo wrote:
>
> On Fri, Jan 27, 2023 at 04:00:59PM +1000, Ben Skeggs wrote:
> > On Fri, 20 Jan 2023 at 21:37, Diogo Ivo
> > wrote:
> > >
> > > On Wed, Jan 18, 2023 at 11:28:49AM +1000, Ben Skeggs wrote:
> > &
On Fri, 20 Jan 2023 at 21:37, Diogo Ivo wrote:
>
> On Wed, Jan 18, 2023 at 11:28:49AM +1000, Ben Skeggs wrote:
> > On Mon, 16 Jan 2023 at 22:27, Diogo Ivo
> > wrote:
> > > On Mon, Jan 16, 2023 at 07:45:05AM +1000, David Airlie wrote:
> > > >
On Mon, 16 Jan 2023 at 22:27, Diogo Ivo wrote:
>
> On Mon, Jan 16, 2023 at 07:45:05AM +1000, David Airlie wrote:
> > On Thu, Dec 29, 2022 at 12:58 AM Diogo Ivo
> > wrote:
> > As a quick check can you try changing
> >
> > drivers/gpu/drm/nouveau/nvkm/core/firmware.c:nvkm_firmware_mem_target
> > f
nges up to 6dd08133e9f705f6565e18f114cfeca3f3a6970a:
drm/nouveau/gr/ga102: initial support (2022-11-08 15:46:01 +1000)
--------
Ben Skeggs (124):
drm/nouveau/disp: move and extend the role of outp acquire/release methods
drm/no
On Sat, 19 Mar 2022 at 04:11, Lyude Paul wrote:
>
> Whoops, sorry! I was unsure of the preference in name we should go with so I
> poked Ben on the side to ask them, but I can see they haven't yet responded.
> I'll poke thme again and see if I can get a response.
Yeah, please keep _prom as opposed
sch
>
> Thanks.
>
> >
> > Please also add a cc for linux-stable, so that this is fixed in 5.15.x
>
> Sure, but I still need some acked-by or rb from one of the Nouveau guys.
> So gentle ping on that.
Acked-by: Ben Skeggs
>
> Regards,
> Christian.
>
>
On Thu, 18 Nov 2021 at 21:13, Dan Carpenter wrote:
>
> The nvkm_acr_lsfw_add() function never returns NULL. It returns error
> pointers on error.
>
> Fixes: 22dcda45a3d1 ("drm/nouveau/acr: implement new subdev to replace
> "secure boot"")
> Signed-off-b
ave push access to drm-misc
> (where changes are pushed to after landing in gitlab) and are known
> nouveau developers.
> We did this already for some trivial changes and critical bug fixes
> already, we just weren't thinking about updating the MAINTAINERS file.
>
> Cc: Ben Skeggs
InfoFrame correctly. Now displays that advertise RGB Selectable
> Quantization Range in their EDID will understand that full range is
> transmitted
> by the HDMI output. This is consistent to how the Nvidia's driver behaves.
>
> Signed-off-by: Hans Verkuil
Reviewed-by: Ben Skeggs
&g
of 1 in the HDMI Vendor
> InfoFrame when transmitting 4kp30.
>
> Signed-off-by: Hans Verkuil
> Fixes: 290ffeafcc1a (drm/nouveau/disp/gv100: initial support)
Reviewed-by: Ben Skeggs
> ---
> diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/disp/hdmigv100.c
> b/drivers/gpu/drm/
so it is way more
> straightforward to evaluate the latter directly instead of passing
> the handle produced by the former to acpi_bus_get_device().
>
> Modify nouveau_acpi_edid() accordingly (no intentional functional
> impact).
>
> Signed-off-by: Rafael J. Wysocki
Reviewed-by: Ben Sk
eeded assignment in the
> if condition.")
> Signed-off-by: Karol Herbst
Reviewed-by: Ben Skeggs
> ---
> drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmmgp100.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/mmu/
On Fri, 8 Oct 2021 at 07:46, Karol Herbst wrote:
>
> Reviewed-by: Karol Herbst
Reviewed-by: Ben Skeggs
>
> I haven't checked if other places need fixing up yet, and I still want
> to test this patch, but I won't get to it until Monday. But if
> everything is in
From: Ben Skeggs
Turns out caller isn't zero-initialised after-all.
Fixes: 6b457230bfa1 ("drm/nouveau/ga102-: support ttm buffer moves via copy
engine")
Reported-by: Karol Herbst
Signed-off-by: Ben Skeggs
---
drivers/gpu/drm/nouveau/nvkm/engine/fifo/ga102.c | 3 +++
1
From: Ben Skeggs
We don't currently have any kind of real acceleration on Ampere GPUs,
but the TTM memcpy() fallback paths aren't really designed to handle
copies between different devices, such as on Optimus systems, and
result in a kernel OOPS.
A few options were investigated to t
On Thu, 9 Sept 2021 at 04:19, Daniel Vetter wrote:
>
> On Mon, Sep 06, 2021 at 10:56:27AM +1000, Ben Skeggs wrote:
> > From: Ben Skeggs
> >
> > We don't currently have any kind of real acceleration on Ampere GPUs,
> > but the TTM memcpy() fallback pat
On Tue, 7 Sept 2021 at 10:28, Karol Herbst wrote:
>
> On Tue, Sep 7, 2021 at 1:28 AM Ben Skeggs wrote:
> >
> > On Tue, 7 Sept 2021 at 09:17, Karol Herbst wrote:
> > >
> > > ."
> > >
> > >
> > > On Mon, Sep 6,
On Tue, 7 Sept 2021 at 09:17, Karol Herbst wrote:
>
> ."
>
>
> On Mon, Sep 6, 2021 at 2:56 AM Ben Skeggs wrote:
> >
> > From: Ben Skeggs
> >
> > We don't currently have any kind of real acceleration on Ampere GPUs,
> > but the TTM m
From: Ben Skeggs
Prevent NVD core channel error code 67 occuring and hanging display,
managed to reproduce on GA102 while testing suspend/resume scenarios.
Required extension of earlier commit to fix interactions with EFI.
Fixes: e78b1b545c6c ("drm/nouveau/kms/nv50: workaround EFI GOP w
From: Ben Skeggs
We don't currently have any kind of real acceleration on Ampere GPUs,
but the TTM memcpy() fallback paths aren't really designed to handle
copies between different devices, such as on Optimus systems, and
result in a kernel OOPS.
A few options were investigated to t
e handed it was subclassed and worse, the original could have
> been freed at this point.
>
> Fix this by using the original struct ttm_resource before it is
> potentially freed in ttm_bo_move_sync_cleanup()
>
> Reported-by: Ben Skeggs
> Reported-by: Dave Airlie
> Cc: Christian
linux-5.14
for you to fetch changes up to 59f216cf04d973b4316761cbf3e7cb9556715b7a:
drm/nouveau: rip out nvkm_client.super (2021-08-18 19:00:15 +1000)
Ben Skeggs (6):
drm/nouveau: recognise GA107
drm/nouveau/disp: power
notifiers to revoke the atomic access. The original page table
> entries are then restored allowing CPU access to proceed.
>
> Signed-off-by: Alistair Popple
The Nouveau bits at least look good to me.
For patches 7/8:
Reviewed-by: Ben Skeggs
>
> ---
>
> v7:
> * Removed magic v
Single regression fix.
Thanks,
Ben.
The following changes since commit d27ce83fa4baa5cb908a42e9878564cad6ea0eb3:
Merge tag 'du-fixes-20210316' of git://linuxtv.org/pinchartl/media
into drm-fixes (2021-03-22 13:49:55 +1000)
are available in the Git repository at:
git://github.com/skeggsb/li
On Mon, 8 Mar 2021 at 03:49, Ilia Mirkin wrote:
>
> The struct is giant, and triggers an order-7 allocation (512K). There is
> no reason for this to be kmalloc-type memory, so switch to vmalloc. This
> should help loading nouveau on low-memory and/or long-running systems.
>
> Reported-by: Nathan E
On Wed, 17 Mar 2021 at 19:51, ChunyouTang wrote:
>
> From: tangchunyou
>
> disable,delete disable and return 0
>
> Signed-off-by: tangchunyou
Thanks!
> ---
> drivers/gpu/drm/nouveau/nvkm/subdev/devinit/mcp89.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/g
On Fri, 19 Mar 2021 at 09:04, Lyude Paul wrote:
>
> Found this while trying to make some changes to the kms_cursor_crc test.
> curs507a_acquire checks that the width and height of the cursor framebuffer
> are equal (asyw->image.{w,h}). This isn't entirely correct though, as the
> height of the cur
On Tue, 23 Mar 2021 at 17:03, Zou Wei wrote:
>
> Fix the following sparse warning:
>
> drivers/gpu/drm/nouveau/nvkm/core/client.c:64:1: warning: symbol
> 'nvkm_uclient_sclass' was not declared. Should it be static?
>
> Signed-off-by: Zou Wei
Applied, thanks.
> ---
> drivers/gpu/drm/nouveau/nvk
)
Ben Skeggs (1):
drm/nouveau/fifo/gk104-gp1xx: fix creation of sw class
drivers/gpu/drm/nouveau/nvkm/engine/fifo/gk104.c | 3 +++
1 file changed, 3 insertions(+)
___
dri-devel mailing list
dri
On Wed, 17 Feb 2021 at 13:30, Alexandre Courbot wrote:
>
> On Wed, Feb 17, 2021 at 1:20 AM Diego Viola wrote:
> >
> > This code times out on GP108, probably because the BIOS puts it into a
> > bad state.
> >
> > Since we reset the PMU on driver load anyway, we are at no risk from
> > missing a re
inux 00.00-inst
for you to fetch changes up to f6df392dddbb9e637b785e7e3d9337a74923dc10:
drm/nouveau/top/ga100: initial support (2021-02-11 11:50:04 +1000)
--------
Ben Skeggs (87):
drm/nouveau/engine: use refcount_t + private
preemption fix
Ben Skeggs (3):
drm/nouveau/kms/nv50-gp1xx: wait for less EVO pushbuf space for
core updates without notify
drm/nouveau/kms/gv100-: wait for less NVD pushbuf space for core
updates without notify
drm/nouveau/kms/nv50-: add module option to select EVO/NVD push
000)
Bastian Beranek (1):
drm/nouveau/dispnv50: Restore pushing of all data.
Ben Skeggs (1):
drm/nouveau/nvif: fix method count when pushing an array
Karol Herbst (1):
drm/nouveau/svm: fail NOUVEAU_SVM_INIT ioctl on unsupported devices
Lyude Paul (3):
drivers/nouv
git://github.com/skeggsb/linux 04.01-ampere-lite
for you to fetch changes up to 8ef23b6f6a79e6fa2a169081d2d76011fffa0482:
drm/nouveau/disp/ga10[24]: initial support (2021-01-15 10:25:24 +1000)
--------
Ben Skeggs (15):
drm/nou
ffer is at offset 0
(2021-01-15 10:25:17 +1000)
--------
Ben Skeggs (7):
drm/nouveau/bios: fix issue shadowing expansion ROMs
drm/nouveau/privring: ack interrupts the same way as RM
drm/nouveau/i2c/gk110: split out from
On Mon, 16 Nov 2020 at 05:19, Karol Herbst wrote:
>
> On Sun, Nov 15, 2020 at 6:43 PM Salvatore Bonaccorso
> wrote:
> >
> > Hi,
> >
> > On Fri, Aug 28, 2020 at 11:28:46AM +0200, Frantisek Hrbata wrote:
> > > Unprivileged user can crash kernel by using
> > > DRM_IOCTL_NOUVEAU_CHANNEL_ALLOC
> > >
I've merged all of these. Sent the first to 5.10-fixes for the
regression there, the rest will go in with a later -next pull request.
Thanks,
Ben.
On Sat, 14 Nov 2020 at 10:14, Lyude Paul wrote:
>
> It turns out that I forgot to go through and make sure that I converted all
> encoder callbacks
)
Ben Skeggs (1):
drm/nouveau/ttm: avoid using nouveau_drm.ttm.type_vram prior to nv50
drivers/gpu/drm/nouveau/nouveau_bo.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https
/kms/nv50-: Use atomic encoder callbacks everywhere
(2020-11-14 14:19:18 +1000)
Alexander Kapshuk (1):
drm/nouveau/kms: Fix NULL pointer dereference in
nouveau_connector_detect_depth
Ben Skeggs (1):
drm/nouveau/ttm: avoid
:
drm/nouveau/ttm: avoid using nouveau_drm.ttm.type_vram prior to nv50
(2020-11-12 14:09:45 +1000)
Alexander Kapshuk (1):
drm/nouveau/kms: Fix NULL pointer dereference in
nouveau_connector_detect_depth
Ben Skeggs (1
; [ 18.785646] __kmalloc_track_caller+0x1be/0x390
> >>> [ 18.792165] kstrdup_const+0x46/0x70
> >>> [ 18.797686] kobject_set_name_vargs+0x2f/0xb0
> >>> [ 18.803992] kobject_init_and_add+0x9d/0xf0
> >>> [ 18.810117] ttm_mem_global_init+0x12c/0
The following changes since commit 3650b228f83adda7e5ee532e2b90429c03f7b9ec:
Linux 5.10-rc1 (2020-10-25 15:14:11 -0700)
are available in the Git repository at:
git://github.com/skeggsb/linux linux-5.10
for you to fetch changes up to d7787cc04e0a1f2043264d1550465081096bd065:
drm/nouveau/k
On Wed, 30 Sep 2020 at 19:37, Daniel Vetter wrote:
>
> On Wed, Sep 30, 2020 at 10:45:05AM +1000, Ben Skeggs wrote:
> > On Wed, 30 Sep 2020 at 00:52, Daniel Vetter wrote:
> > >
> > > On Thu, Sep 17, 2020 at 3:15 PM Daniel Vetter
> > > wrote:
> > >
On Thu, 24 Sep 2020 at 15:20, Dave Airlie wrote:
>
> From: Dave Airlie
>
> Don't use explicit move notify for moves just do it in the driver side.
>
> Signed-off-by: Dave Airlie
> ---
> drivers/gpu/drm/nouveau/nouveau_bo.c | 62
> 1 file changed, 44 insertions(+), 1
27;t get too caught up in each patches changes unless the end result
> is a problem.
I've looked over the nouveau-specific patches, and the ttm ones
(mostly ignoring the changes to other drivers beyond a quick glance
over). For all but 37/45 and the patches that depend on it:
Reviewed-by: Be
e with atomic: With atomic the bo pinning and
> > > > actual modeset commit is completely separated in the code patsh.
> > > >
> > > > This annotation was originally added in
> > > >
> > > > commit 060810d7abaabcab282e062c595871d661561400
>
On Thu, 17 Sep 2020 at 20:06, Christian König
wrote:
>
> Hi guys,
>
> just another TTM feature which is only used by nouveau.
>
> We have this bo->bo.persistent_swap_storage pointer which is only set by
> nouveau to the GEM filp and used when a BO is swapped to a shmem file.
>
> As far as I can se
On Thu, 10 Sep 2020 at 00:07, Jeremy Cline wrote:
>
> On Wed, Sep 09, 2020 at 10:22:14AM +0200, Karol Herbst wrote:
> > On Wed, Sep 9, 2020 at 6:06 AM Ben Skeggs wrote:
> > >
> > > On Thu, 13 Aug 2020 at 06:50, Jeremy Cline wrote:
> > > >
> > &
1 - 100 of 663 matches
Mail list logo
