On Wed, Jun 25, 2025 at 08:42:35PM -0700, Boqun Feng wrote:
Hi,
> Hi Beata,
>
> On Wed, Jun 25, 2025 at 10:13:33AM +0200, Beata Michalska wrote:
> > With the Opaque, the expectations are that Rust should not
> > make any assumptions on the layout or invariants of the wrap
none is actually
needed. This adds needless complexity and maintenance overhead,
brining no safety benefits.
Drop the use of Opaque for ioctl arguments as that is not the best
fit here.
Signed-off-by: Beata Michalska
Acked-by: Danilo Krummrich
Reviewed-by: Boqun Feng
---
Changes in v5:
- Use
none is acually
needed. This adds needless complexity and maintenance overhead,
brining no safety benefits.
Drop the use of Opaque for ioctl arguments as that is not the best
fit here.
Signed-off-by: Beata Michalska
Acked-by: Danilo Krummrich
---
drivers/gpu/drm/nova/file.rs | 23
On Tue, Jun 24, 2025 at 01:20:51PM +0200, Danilo Krummrich wrote:
> On Tue, Jun 24, 2025 at 01:09:12PM +0200, Beata Michalska wrote:
> > On Tue, Jun 24, 2025 at 11:59:25AM +0200, Danilo Krummrich wrote:
> > > On 6/24/25 11:32 AM, Beata Michalska wrote:
> > &g
non is acually
needed. This adds needless complexity and maintenance overhead,
brining no safety benefits.
Drop the use of Opaque for ioctl arguments as that is not the best
fit here.
Signed-off-by: Beata Michalska
[ nova-drm changes: Danilo ]
Signed-off-by: Danilo Krummrich
---
drivers/gpu/drm
On Tue, Jun 24, 2025 at 11:59:25AM +0200, Danilo Krummrich wrote:
> On 6/24/25 11:32 AM, Beata Michalska wrote:
> > From: Danilo Krummrich
> >
> > Following the removal of `Opaque` for ioctl arguments in the DRM
> > framework, this patch updates the affect
non is acually
needed. This adds needless complexity and maintenance overhead,
brining no safety benefits.
Drop the use of Opaque for ioctl arguments as that is not the best
fit here.
Signed-off-by: Beata Michalska
---
rust/kernel/drm/ioctl.rs | 11 +++
1 file changed, 7 insertions(+), 4
From: Danilo Krummrich
Following the removal of `Opaque` for ioctl arguments in the DRM
framework, this patch updates the affected driver code to use typed
references directly.
Signed-off-by: Danilo Krummrich
Signed-off-by: Beata Michalska
---
drivers/gpu/drm/nova/file.rs | 23
Hi All,
This patch series removes the use of `Opaque` for ioctl
arguments in the DRM Rust interface and updates the Nova
code accordingly.
v2:
- Missing Nova changes now included
- Fixed formatting and added comment on safety guarantees
Beata Michalska (1):
rust: drm: Drop the use of Opaque
On Fri, Jun 20, 2025 at 10:42:09AM -0300, Daniel Almeida wrote:
> Hi Beata,
>
> > There is no concurrent access nor shared references, unless the
> > handler decides otherwise
>
> It can’t do so in safe code. There is no way to manufacture a shared
> reference from a mutable one in safe code and
On Thu, Jun 19, 2025 at 09:30:19AM -0300, Daniel Almeida wrote:
> Hi Beata,
>
> > On 19 Jun 2025, at 07:21, Beata Michalska wrote:
> >
> > With the Opaque, the expectations are that Rust should not make any
> > assumptions on the layout or invariants of the wrapped
On Thu, Jun 19, 2025 at 12:55:08PM +0200, Danilo Krummrich wrote:
> On Thu, Jun 19, 2025 at 12:21:02PM +0200, Beata Michalska wrote:
> > With the Opaque, the expectations are that Rust should not make any
> > assumptions on the layout or invariants of the wrapped C types.
>
ch wrote:
> >>> On Thu, Jun 19, 2025 at 12:21:02PM +0200, Beata Michalska wrote:
> >>>> diff --git a/rust/kernel/drm/ioctl.rs b/rust/kernel/drm/ioctl.rs
> >>>> index 445639404fb7..12b296131672 100644
> >>>> --- a/rust/ke
, which adds needless complexity and
maintenance overhead, brining no safety benefits.
Drop the use of Opaque for ioctl arguments as that is not the best
fit here.
Signed-off-by: Beata Michalska
---
Additional comments:
- UAPI types already automatically derive MaybeZeroable,
so it probably makes
14 matches
Mail list logo
