Re: [GIT PULL] Immutable tag between the pwrseq, drm and pmdomain trees for v6.17-rc1

2025-06-25 Thread Bartosz Golaszewski
On Tue, Jun 24, 2025 at 4:10 PM Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski > > Here's an immutable tag containing the thead 1520 power sequencing driver > for the drm and pmdomain trees to pull from. > > Best Regards, > Bartosz Golaszewski Just an FYI

[GIT PULL] Immutable tag between the pwrseq, drm and pmdomain trees for v6.17-rc1

2025-06-24 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Here's an immutable tag containing the thead 1520 power sequencing driver for the drm and pmdomain trees to pull from. Best Regards, Bartosz Golaszewski The following changes since commit 19272b37aa4f83ca52bdf9c16d5d81bdd1354494: Linux 6.16-rc1 (2025-06-08 13:

Re: (subset) [PATCH v6 0/8] Add TH1520 GPU support with power sequencing

2025-06-24 Thread Bartosz Golaszewski
From: Bartosz Golaszewski On Mon, 23 Jun 2025 13:42:38 +0200, Michal Wilczynski wrote: > This patch series introduces support for the Imagination IMG BXM-4-64 > GPU found on the T-HEAD TH1520 SoC. A key aspect of this support is > managing the GPU's complex power-up and power

Re: [PATCH v6 1/8] power: sequencing: Add T-HEAD TH1520 GPU power sequencer driver

2025-06-23 Thread Bartosz Golaszewski
On Mon, Jun 23, 2025 at 1:44 PM Michal Wilczynski wrote: > > Introduce the pwrseq-thead-gpu driver, a power sequencer provider for > the Imagination BXM-4-64 GPU on the T-HEAD TH1520 SoC. This driver > controls an auxiliary device instantiated by the AON power domain. > > The TH1520 GPU requires a

[PATCH] drm/bridge: ti-sn65dsi86: remove unnecessary GPIO line direction check

2025-06-20 Thread Bartosz Golaszewski
From: Bartosz Golaszewski As of commit 92ac7de3175e3 ("gpiolib: don't allow setting values on input lines"), the GPIO core makes sure values cannot be set on input lines. Remove the unnecessary check. Signed-off-by: Bartosz Golaszewski --- drivers/gpu/drm/bridge/ti-sn65dsi86

Re: [PATCH v5 3/8] pmdomain: thead: Instantiate GPU power sequencer via auxiliary bus

2025-06-19 Thread Bartosz Golaszewski
On Thu, Jun 19, 2025 at 12:25 PM Ulf Hansson wrote: > > On Wed, 18 Jun 2025 at 12:22, Michal Wilczynski > wrote: > > > > In order to support the complex power sequencing required by the TH1520 > > GPU, the AON power domain driver must be responsible for initiating the > > corresponding sequencer

Re: [PATCH v5 8/8] drm/imagination: Enable PowerVR driver for RISC-V

2025-06-18 Thread Bartosz Golaszewski
d say that the COMPILE_TEST bit should be a separate commit but it's typically fine with me. > depends on DRM > depends on PM > + depends on MMU > select DRM_EXEC > select DRM_GEM_SHMEM_HELPER > select DRM_SCHED > > -- > 2.34.1 > Reviewed-by: Bartosz Golaszewski

Re: [PATCH v5 7/8] riscv: dts: thead: th1520: Add IMG BXM-4-64 GPU node

2025-06-18 Thread Bartosz Golaszewski
wed-by: Ulf Hansson > Signed-off-by: Michal Wilczynski > --- Reviewed-by: Bartosz Golaszewski

Re: [PATCH v5 6/8] riscv: dts: thead: th1520: Add GPU clkgen reset to AON node

2025-06-18 Thread Bartosz Golaszewski
= "aon"; > + resets = <&rst TH1520_RESET_ID_GPU_CLKGEN>; > + reset-names = "gpu-clkgen"; > #power-domain-cells = <1>; > }; > > > -- > 2.34.1 > Reviewed-by: Bartosz Golaszewski

Re: [PATCH v5 5/8] dt-bindings: gpu: img,powervr-rogue: Add TH1520 GPU compatible

2025-06-18 Thread Bartosz Golaszewski
added to the > list of recognized GPU types. > > The power-domains property requirement for img,img-bxm-4-64 is also > ensured by adding it to the relevant allOf condition. > > Acked-by: Krzysztof Kozlowski > Reviewed-by: Ulf Hansson > Signed-off-by: Michal Wilczynski > --- Reviewed-by: Bartosz Golaszewski

Re: [PATCH v5 4/8] drm/imagination: Use pwrseq for TH1520 GPU power management

2025-06-18 Thread Bartosz Golaszewski
alization. > > The runtime PM callbacks, pvr_power_device_resume() and > pvr_power_device_suspend(), call the power_on and power_off function > pointers. Helper functions for both manual and pwrseq-based sequences > are introduced to support this. > > Reviewed-by: Ulf Hansson > Signed-off-by: Michal Wilczynski > --- IMO it's much better this way, thanks. Reviewed-by: Bartosz Golaszewski

Re: [PATCH v5 3/8] pmdomain: thead: Instantiate GPU power sequencer via auxiliary bus

2025-06-18 Thread Bartosz Golaszewski
device. > This device acts as a proxy that allows the dedicated `pwrseq-thead-gpu` > auxiliary driver to bind and take control of the sequencing logic. > > Signed-off-by: Michal Wilczynski > --- Reviewed-by: Bartosz Golaszewski

Re: [PATCH v5 2/8] dt-bindings: firmware: thead,th1520: Add resets for GPU clkgen

2025-06-18 Thread Bartosz Golaszewski
gt; +maxItems: 1 > + > + reset-names: > +items: > + - const: gpu-clkgen > + >"#power-domain-cells": > const: 1 > > > -- > 2.34.1 > Reviewed-by: Bartosz Golaszewski

Re: [PATCH v5 1/8] power: sequencing: Add T-HEAD TH1520 GPU power sequencer driver

2025-06-18 Thread Bartosz Golaszewski
On Wed, Jun 18, 2025 at 12:22 PM Michal Wilczynski wrote: > > Introduce the pwrseq-thead-gpu driver, a power sequencer provider for > the Imagination BXM-4-64 GPU on the T-HEAD TH1520 SoC. This driver > controls an auxiliary device instantiated by the AON power domain. > > The TH1520 GPU requires

Re: [PATCH v4 4/8] drm/imagination: Use pwrseq for TH1520 GPU power management

2025-06-16 Thread Bartosz Golaszewski
On Sat, Jun 14, 2025 at 8:09 PM Michal Wilczynski wrote: > > Update the Imagination PVR DRM driver to leverage the pwrseq framework > for managing the power sequence of the GPU on the T-HEAD TH1520 SoC. > > To cleanly handle the TH1520's specific power requirements in the > generic driver, this pa

Re: [PATCH v4 8/8] drm/imagination: Enable PowerVR driver for RISC-V

2025-06-16 Thread Bartosz Golaszewski
On Mon, Jun 16, 2025 at 11:09 AM Michal Wilczynski wrote: > > > > On 6/15/25 12:51, kernel test robot wrote: > > Hi Michal, > > > > kernel test robot noticed the following build warnings: > > > > [auto build test WARNING on 4774cfe3543abb8ee98089f535e28ebfd45b975a] > > > > url: > > https://pro

Re: [PATCH v4 3/8] pmdomain: thead: Instantiate GPU power sequencer via auxiliary bus

2025-06-16 Thread Bartosz Golaszewski
On Sat, Jun 14, 2025 at 8:09 PM Michal Wilczynski wrote: > > In order to support the complex power sequencing required by the TH1520 > GPU, the AON power domain driver must be responsible for initiating the > corresponding sequencer driver. This functionality is specific to > platforms where the G

Re: [PATCH v4 1/8] power: sequencing: Add T-HEAD TH1520 GPU power sequencer driver

2025-06-16 Thread Bartosz Golaszewski
On Sat, Jun 14, 2025 at 8:09 PM Michal Wilczynski wrote: > > Introduce the pwrseq-thead-gpu driver, a power sequencer provider for > the Imagination BXM-4-64 GPU on the T-HEAD TH1520 SoC. This driver is > an auxiliary driver instantiated by the AON power domain driver. Just a technicality: this d

Re: [PATCH v3 3/8] drm/imagination: Use pwrseq for TH1520 GPU power management

2025-06-13 Thread Bartosz Golaszewski
On Fri, Jun 13, 2025 at 10:25 AM Michal Wilczynski wrote: > > > Why? You have specific compatible for executing such quirks only for > > given platform. > > This is due to how the pwrseq API works; it constructs a bus on which > provider devices may appear at any time. With the current API, there

Re: [PATCH v3 3/8] drm/imagination: Use pwrseq for TH1520 GPU power management

2025-06-11 Thread Bartosz Golaszewski
On Wed, Jun 11, 2025 at 2:01 PM Michal Wilczynski wrote: > > > > On 6/5/25 10:10, Bartosz Golaszewski wrote: > > On Thu, Jun 5, 2025 at 9:47 AM Michal Wilczynski > > wrote: > >> > >> > >> > >> On 6/4/25 14:07, Krzysztof Kozlows

[PATCH] drm/bridge: ti-sn65dsi86: use new GPIO line value setter callbacks

2025-06-10 Thread Bartosz Golaszewski
From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- Commit 98ce1eb1fd87e ("gpiolib: introduce gpio_chip setters that return v

Re: [PATCH v3 3/8] drm/imagination: Use pwrseq for TH1520 GPU power management

2025-06-05 Thread Bartosz Golaszewski
On Thu, Jun 5, 2025 at 9:47 AM Michal Wilczynski wrote: > > > > On 6/4/25 14:07, Krzysztof Kozlowski wrote: > > On 04/06/2025 13:53, Michal Wilczynski wrote: > > The GPU node will depend on the AON node, which will be the sole > provider for the 'gpu-power' sequencer (based on the d

Re: [PATCH v3 6/8] riscv: dts: thead: Add GPU power sequencer node

2025-06-04 Thread Bartosz Golaszewski
On Tue, Jun 3, 2025 at 8:45 PM Michal Wilczynski wrote: > > > > On 6/3/25 15:22, Krzysztof Kozlowski wrote: > > On Fri, May 30, 2025 at 12:23:53AM GMT, Michal Wilczynski wrote: > >> Add the device tree node for the T-HEAD TH1520 GPU power sequencer > >> (gpu_pwrseq) to the th1520.dtsi file. > >> >

Re: [PATCH v3 1/8] dt-bindings: power: Add T-HEAD TH1520 GPU power sequencer

2025-06-03 Thread Bartosz Golaszewski
On Tue, Jun 3, 2025 at 8:24 PM Michal Wilczynski wrote: > > > > Agreed. And as far as implementation goes, you can have the same > > driver be a PM domain AND pwrseq provider. It just has to bind to the > > device node that represents an actual component, not a made-up > > "convenience" node. > >

Re: [PATCH v3 1/8] dt-bindings: power: Add T-HEAD TH1520 GPU power sequencer

2025-06-03 Thread Bartosz Golaszewski
On Tue, Jun 3, 2025 at 3:35 PM Bartosz Golaszewski wrote: > > > > > > The compatible string could be updated like so: > > > "thead,th1520-aon-pwrseq" > > > > Should not be separate node, you already have one for AON. > > > > Agr

Re: [PATCH v3 1/8] dt-bindings: power: Add T-HEAD TH1520 GPU power sequencer

2025-06-03 Thread Bartosz Golaszewski
On Tue, Jun 3, 2025 at 3:19 PM Krzysztof Kozlowski wrote: > > On Mon, Jun 02, 2025 at 10:29:13PM GMT, Michal Wilczynski wrote: > > >> +description: | > > >> + This binding describes the power sequencer for the T-HEAD TH1520 GPU. > > >> + This sequencer handles the specific power-up and power-dow

Re: [PATCH v3 1/8] dt-bindings: power: Add T-HEAD TH1520 GPU power sequencer

2025-06-02 Thread Bartosz Golaszewski
On Fri, May 30, 2025 at 12:24 AM Michal Wilczynski wrote: > > Introduce device tree bindings for a new power sequencer provider > dedicated to the T-HEAD TH1520 SoC's GPU. > > The thead,th1520-gpu-pwrseq compatible designates a node that will > manage the complex power-up and power-down sequence f

Re: [PATCH v4 05/11] firmware: qcom: scm: add support for object invocation

2025-05-14 Thread Bartosz Golaszewski
On Wed, 14 May 2025 at 11:37, Sumit Garg wrote: > > Hi Amir, > > I am still unable to get the QCOMTEE driver to work on db845c. As I can > see machine: "qcom,sdm845" is not supported for tzmem based on SHM > brigde here: drivers/firmware/qcom/qcom_tzmem.c +81. I am still seeing > following logs fr

Re: [PATCH v4 4/6] gpio: fix potential out-of-bound write

2025-05-09 Thread Bartosz Golaszewski
On Thu, May 8, 2025 at 3:07 PM Markus Burri wrote: > > Check that the input size does not exceed the buffer size. > If a caller write more characters, count is truncated to the max available > space in "simple_write_to_buffer". > Write a zero termination afterwards. > > Signed-off-by: Markus Burri

Re: [PATCH v4 0/6] Fix potential out-of-bounds error in some drivers

2025-05-09 Thread Bartosz Golaszewski
On Thu, May 8, 2025 at 3:06 PM Markus Burri wrote: > > Several drivers are using debugfs and follow the same pattern. > > A buffer is created on the stack with a limited size to copy the given data > from user space. The copy is performed using simple_write_to_buffer. > This function limits the in

Re: [PATCH] fbdev: via: use new GPIO line value setter callbacks

2025-04-23 Thread Bartosz Golaszewski
On Tue, Apr 8, 2025 at 9:42 AM Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski > > struct gpio_chip now has callbacks for setting line values that return > an integer, allowing to indicate failures. Convert the driver to using > them. > > Signed-off

[PATCH] fbdev: via: use new GPIO line value setter callbacks

2025-04-08 Thread Bartosz Golaszewski
From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- Commit 98ce1eb1fd87e ("gpiolib: introduce gpio_chip setters that return v

Re: [PATCH v2 0/2] gpiolib: Make code more robust by using for_each_if()

2025-02-17 Thread Bartosz Golaszewski
From: Bartosz Golaszewski On Thu, 13 Feb 2025 20:23:59 +0200, Andy Shevchenko wrote: > Instead of opencoding with long lines, use for_each_if() macro > which makes intention clearer and less error prone. > > In v2: > - moved original for_each_if() implementation to the glob

Re: [PATCH v2 1/2] drm: Move for_each_if() to util_macros.h for wider use

2025-02-13 Thread Bartosz Golaszewski
On Thu, Feb 13, 2025 at 7:25 PM Andy Shevchenko wrote: > > Other subsystem(s) may want to reuse the for_each_if() macro. > Move it to util_macros.h to make it globally available. > > Suggested-by: Bartosz Golaszewski > Signed-off-by: Andy Shevchenko > --- Reviewed-by: Bart

Re: [PATCH v3 3/7] dt-bindings: gpio: brcmstb: permit gpio-line-names property

2024-12-20 Thread Bartosz Golaszewski
On Fri, Dec 20, 2024 at 2:02 PM Dave Stevenson wrote: > > Hi Linus > > On Fri, 20 Dec 2024 at 12:50, Linus Walleij wrote: > > > > On Thu, Dec 12, 2024 at 7:36 PM Dave Stevenson > > wrote: > > > > > gpio-line-names is a generic property that can be supported by any > > > GPIO controller, so permi

Re: (subset) [PATCH v3 0/7] drm/vc4: Fixup DT and DT binding issues from recent patchset

2024-12-16 Thread Bartosz Golaszewski
From: Bartosz Golaszewski On Thu, 12 Dec 2024 18:36:27 +, Dave Stevenson wrote: > I missed the DT errors from the recent patchset[1] (DT patches > in linux-next via Florian, DRM bindings patches on dri-misc-next) > as Rob's bot report got spam filtered, so this is a fixup set

Re: [PATCH v4 08/11] gpio: sim: Remove gpio_sim_dev_match_fwnode()

2024-12-11 Thread Bartosz Golaszewski
On Wed, Dec 11, 2024 at 1:10 AM Zijun Hu wrote: > > From: Zijun Hu > > gpio_sim_dev_match_fwnode() is a simple wrapper of API > device_match_fwnode(). > > Remove the needless wrapper and use the API instead. > > Signed-off-by: Zijun Hu > --- Acked-by: Bartosz Golaszewski

Re: [PATCH v3 08/11] gpio: sim: Remove gpio_sim_dev_match_fwnode()

2024-12-05 Thread Bartosz Golaszewski
On Thu, Dec 5, 2024 at 1:15 AM Zijun Hu wrote: > > From: Zijun Hu > > gpio_sim_dev_match_fwnode() is a simple wrapper of device_match_fwnode() > Remvoe the unnecessary wrapper. > > Signed-off-by: Zijun Hu > --- > drivers/gpio/gpio-sim.c | 7 +-- > 1 file changed, 1 insertion(+), 6 deletions

[PATCH] fbdev: da8xx: remove the driver

2024-10-14 Thread Bartosz Golaszewski
From: Bartosz Golaszewski This driver is no longer used on any platform. It has been replaced by tilcdc on the two DaVinci boards we still support and can be removed. Signed-off-by: Bartosz Golaszewski --- drivers/video/fbdev/Kconfig| 13 - drivers/video/fbdev/Makefile |1

Re: [PATCH] fbdev/da8xx-fb: unlock on error paths in suspend/resume

2024-10-14 Thread Bartosz Golaszewski
On Mon, Oct 14, 2024 at 9:06 AM Bartosz Golaszewski wrote: > > On Fri, Oct 11, 2024 at 9:42 PM Dan Carpenter > wrote: > > > > Add a missing console_unlock() in the suspend and resume functions on > > the error paths. > > > > Fixes: 611097d5daea (&qu

Re: [PATCH] fbdev/da8xx-fb: unlock on error paths in suspend/resume

2024-10-14 Thread Bartosz Golaszewski
ret = regulator_enable(par->lcd_supply); > - if (ret) > + if (ret) { > + console_unlock(); > return ret; > + } > } > } > > -- > 2.45.2 > Reviewed-by: Bartosz Golaszewski

Re: [PATCH 1/2] dt-bindings: misc: qcom, fastrpc: document new domain ID

2024-08-16 Thread Bartosz Golaszewski
On Fri, Aug 16, 2024 at 1:21 PM Krzysztof Kozlowski wrote: > > On 16/08/2024 12:23, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski > > > > Add "cdsp1" as the new supported label for the CDSP1 fastrpc domain. > > > > Signed-off-by: B

[PATCH 1/2] dt-bindings: misc: qcom,fastrpc: document new domain ID

2024-08-16 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Add "cdsp1" as the new supported label for the CDSP1 fastrpc domain. Signed-off-by: Bartosz Golaszewski --- Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings

[PATCH 2/2] arm64: dts: qcom: sa8775p: fix the fastrpc label

2024-08-16 Thread Bartosz Golaszewski
From: Bartosz Golaszewski The fastrpc driver uses the label to determine the domain ID and create the device nodes. It should be "cdsp1" as this is the engine we use here. Fixes: df54dcb34ff2 ("arm64: dts: qcom: sa8775p: add ADSP, CDSP and GPDSP nodes") Reported-by: Ekansh

[PATCH v4 6/6] arm64: dts: qcom: sa8775p-ride: enable remoteprocs

2024-08-05 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Enable all remoteproc nodes on the sa8775p-ride board and point to the appropriate firmware files. Reviewed-by: Dmitry Baryshkov Signed-off-by: Bartosz Golaszewski --- arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi | 25 + 1 file changed, 25

[PATCH v4 4/6] misc: fastrpc: Add support for cdsp1 remoteproc

2024-08-05 Thread Bartosz Golaszewski
From: Ling Xu The fastrpc supports 4 remoteproc. There are some products which support cdsp1 remoteproc. Add changes to support cdsp1 remoteproc. Signed-off-by: Ling Xu [Bartosz: ported to mainline] Signed-off-by: Bartosz Golaszewski --- drivers/misc/fastrpc.c | 10 ++ 1 file changed

[PATCH v4 2/6] dt-bindings: mailbox: qcom-ipcc: Add GPDSP0 and GPDSP1 clients

2024-08-05 Thread Bartosz Golaszewski
From: Tengfei Fan Add GPDSP0 and GPDSP1 clients for SA8775p platform. Signed-off-by: Tengfei Fan Acked-by: Krzysztof Kozlowski Signed-off-by: Bartosz Golaszewski --- include/dt-bindings/mailbox/qcom-ipcc.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/dt-bindings/mailbox

[PATCH v4 5/6] arm64: dts: qcom: sa8775p: add ADSP, CDSP and GPDSP nodes

2024-08-05 Thread Bartosz Golaszewski
: Bartosz Golaszewski Signed-off-by: Bartosz Golaszewski --- arch/arm64/boot/dts/qcom/sa8775p.dtsi | 548 ++ 1 file changed, 548 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi index ad8e567575e5..50ec4712e39f

[PATCH v4 3/6] remoteproc: qcom_q6v5_pas: Add support for SA8775p ADSP, CDSP and GPDSP

2024-08-05 Thread Bartosz Golaszewski
From: Tengfei Fan Add support for PIL loading on ADSP, CDSP0, CDSP1, GPDSP0 and GPDSP1 on SA8775p SoCs. Signed-off-by: Tengfei Fan Co-developed-by: Bartosz Golaszewski Signed-off-by: Bartosz Golaszewski --- drivers/remoteproc/qcom_q6v5_pas.c | 92 ++ 1

[PATCH v4 1/6] dt-bindings: misc: qcom,fastrpc: increase the max number of iommus

2024-08-05 Thread Bartosz Golaszewski
From: Bartosz Golaszewski The fastrpc components on the SA8775P SoC can require up to 10 IOMMU entries. Bump the maxItems. Signed-off-by: Bartosz Golaszewski --- Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[PATCH v4 0/6] arm64: qcom: sa8775p: enable remoteprocs - ADSP, CDSP and GPDSP

2024-08-05 Thread Bartosz Golaszewski
-...@vger.kernel.org Cc: linux-remotep...@vger.kernel.org Cc: devicet...@vger.kernel.org Cc: linux-ker...@vger.kernel.org Signed-off-by: Bartosz Golaszewski Changes in v4: - add the fastrpc nodes and relevant driver and DT bindings changes - Link to v3: https://lore.kernel.org/r/20240605-topic-sa8775p

Re: [PATCH 09/22] gpio: virtio: drop owner assignment

2024-03-29 Thread Bartosz Golaszewski
On Fri, Mar 29, 2024 at 12:35 PM Krzysztof Kozlowski wrote: > > On 29/03/2024 11:27, Bartosz Golaszewski wrote: > > On Wed, Mar 27, 2024 at 1:45 PM Krzysztof Kozlowski > > wrote: > >> > >> virtio core already sets the .owner, so driver does not need to

Re: [PATCH 09/22] gpio: virtio: drop owner assignment

2024-03-29 Thread Bartosz Golaszewski
On Wed, Mar 27, 2024 at 1:45 PM Krzysztof Kozlowski wrote: > > virtio core already sets the .owner, so driver does not need to. > > Signed-off-by: Krzysztof Kozlowski > > --- > > Depends on the first patch. > --- > drivers/gpio/gpio-virtio.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git

Re: [PATCH 1/2] devm-helpers: Add resource managed version of mutex init

2024-02-22 Thread Bartosz Golaszewski
adding managed version of mutex initialization. > > Use the new function devm_mutex_init() in the following drivers: > drivers/gpio/gpio-pisosr.c > drivers/gpio/gpio-sim.c Yes, please! For GPIO part: Acked-by: Bartosz Golaszewski

Re: [PATCH v4] backlight: gpio_backlight: Drop output GPIO direction check for initial power state

2023-07-21 Thread Bartosz Golaszewski
gpiod_get_value_cansleep(gbl->gpiod) == 0) > + else if (gpiod_get_value_cansleep(gbl->gpiod) == 0) > bl->props.power = FB_BLANK_POWERDOWN; > else > bl->props.power = FB_BLANK_UNBLANK; > -- > 2.37.1 > Acked-by: Bartosz Golaszewski

Re: [PATCH] backlight: gpio_backlight: Drop output gpio direction check for initial power state

2023-07-20 Thread Bartosz Golaszewski
On Thu, Jul 20, 2023 at 3:10 PM Daniel Thompson wrote: > > On Thu, Jul 20, 2023 at 02:56:32PM +0200, Bartosz Golaszewski wrote: > > On Thu, Jul 20, 2023 at 1:27 PM Daniel Thompson > > wrote: > > > > > > On Thu, Jul 20, 2023 at 06:06:27AM +, Ying Liu wrot

Re: [PATCH] backlight: gpio_backlight: Drop output gpio direction check for initial power state

2023-07-20 Thread Bartosz Golaszewski
On Thu, Jul 20, 2023 at 1:27 PM Daniel Thompson wrote: > > On Thu, Jul 20, 2023 at 06:06:27AM +, Ying Liu wrote: > > Bootloader may leave gpio direction as input and gpio value as logical low. > > It hints that initial backlight power state should be FB_BLANK_POWERDOWN > > since the gpio value

Re: [PATCH] dt-bindings: Fix SPI and I2C bus node names in examples

2023-03-06 Thread Bartosz Golaszewski
lay/panel/nec,nl8048hl11.yaml| 2 +- > .../bindings/display/solomon,ssd1307fb.yaml | 4 ++-- > .../devicetree/bindings/eeprom/at25.yaml | 2 +- > .../bindings/extcon/extcon-usbc-cros-ec.yaml | 2 +- > .../bindings/extcon/extcon-usbc-tusb320.yaml | 2 +- > .../devicetree/bindings/gpio/gpio-pca9570.yaml| 2 +- > .../devicetree/bindings/gpio/gpio-pca95xx.yaml| 8 Acked-by: Bartosz Golaszewski

Re: [PATCH] dt-bindings: Add missing (unevaluated|additional)Properties on child node schemas

2023-01-25 Thread Bartosz Golaszewski
ers,axp209-gpio.yaml > @@ -35,6 +35,7 @@ properties: > patternProperties: >"^.*-pins?$": > $ref: /schemas/pinctrl/pinmux-node.yaml# > + additionalProperties: false > > properties: >pins: Acked-by: Bartosz Golaszewski [...]

Re: [PATCH] dt-bindings: Fix properties without any type

2022-05-22 Thread Bartosz Golaszewski
/bindings/serial/8250.yaml| 1 + > .../devicetree/bindings/sound/audio-graph-card2.yaml | 3 +++ > .../devicetree/bindings/sound/imx-audio-hdmi.yaml | 3 +++ > Documentation/devicetree/bindings/usb/smsc,usb3503.yaml | 1 + > 25 files changed, 55 insertions(+), 8 deletions(-) > For GPIO: Acked-by: Bartosz Golaszewski

Re: [PATCH] dt-bindings: Add missing array size constraints

2021-01-06 Thread Bartosz Golaszewski
+++ b/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml > @@ -81,6 +81,7 @@ properties: > const: 2 > >reset-gpios: > +maxItems: 1 > description: >GPIO specification for the RESET input. This is an active low signal to >

[PATCH v3 6/9] edac: ghes: use krealloc_array()

2020-11-10 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Use the helper that checks for overflows internally instead of manually calculating the size of the new array. Signed-off-by: Bartosz Golaszewski Acked-by: Borislav Petkov --- drivers/edac/ghes_edac.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH v3 8/9] hwtracing: intel: use krealloc_array()

2020-11-10 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Use the helper that checks for overflows internally instead of manually calculating the size of the new array. Signed-off-by: Bartosz Golaszewski --- drivers/hwtracing/intel_th/msu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH v3 7/9] drm: atomic: use krealloc_array()

2020-11-10 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Use the helper that checks for overflows internally instead of manually calculating the size of the new array. Signed-off-by: Bartosz Golaszewski Acked-by: Daniel Vetter --- drivers/gpu/drm/drm_atomic.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

[PATCH v3 5/9] pinctrl: use krealloc_array()

2020-11-10 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Use the helper that checks for overflows internally instead of manually calculating the size of the new array. Signed-off-by: Bartosz Golaszewski Reviewed-by: Andy Shevchenko --- drivers/pinctrl/pinctrl-utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH v3 9/9] dma-buf: use krealloc_array()

2020-11-10 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Use the helper that checks for overflows internally instead of manually calculating the size of the new array. Signed-off-by: Bartosz Golaszewski Acked-by: Christian König --- drivers/dma-buf/sync_file.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff

[PATCH v3 4/9] vhost: vringh: use krealloc_array()

2020-11-10 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Use the helper that checks for overflows internally instead of manually calculating the size of the new array. Signed-off-by: Bartosz Golaszewski Acked-by: Michael S. Tsirkin --- drivers/vhost/vringh.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

[PATCH v3 2/9] mm: slab: provide krealloc_array()

2020-11-10 Thread Bartosz Golaszewski
From: Bartosz Golaszewski When allocating an array of elements, users should check for multiplication overflow or preferably use one of the provided helpers like: kmalloc_array(). There's no krealloc_array() counterpart but there are many users who use regular krealloc() to reallocate a

[PATCH v3 3/9] ALSA: pcm: use krealloc_array()

2020-11-10 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Use the helper that checks for overflows internally instead of manually calculating the size of the new array. Signed-off-by: Bartosz Golaszewski Reviewed-by: Takashi Iwai --- sound/core/pcm_lib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH v3 1/9] mm: slab: clarify krealloc()'s behavior with __GFP_ZERO

2020-11-10 Thread Bartosz Golaszewski
From: Bartosz Golaszewski __GFP_ZERO is ignored by krealloc() (unless we fall-back to kmalloc() path, in which case it's honored). Point that out in the kerneldoc. Signed-off-by: Bartosz Golaszewski --- mm/slab_common.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --

[PATCH v3 0/9] slab: provide and use krealloc_array()

2020-11-10 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Andy brought to my attention the fact that users allocating an array of equally sized elements should check if the size multiplication doesn't overflow. This is why we have helpers like kmalloc_array(). However we don't have krealloc_array() equivalent and

Re: [PATCH v2 0/8] slab: provide and use krealloc_array()

2020-11-04 Thread Bartosz Golaszewski
On Tue, Nov 3, 2020 at 5:14 AM Joe Perches wrote: > > On Mon, 2020-11-02 at 16:20 +0100, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski > > > > Andy brought to my attention the fact that users allocating an array of > > equally sized elements should ch

Re: [PATCH v2 1/8] mm: slab: provide krealloc_array()

2020-11-03 Thread Bartosz Golaszewski
On Mon, Nov 2, 2020 at 4:41 PM Matthew Wilcox wrote: > > On Mon, Nov 02, 2020 at 04:20:30PM +0100, Bartosz Golaszewski wrote: > > +Chunks allocated with `kmalloc` can be resized with `krealloc`. Similarly > > +to `kmalloc_array`: a helper for resising arrays is provi

[PATCH v2 6/8] drm: atomic: use krealloc_array()

2020-11-03 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Use the helper that checks for overflows internally instead of manually calculating the size of the new array. Signed-off-by: Bartosz Golaszewski Acked-by: Daniel Vetter --- drivers/gpu/drm/drm_atomic.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

[PATCH v2 8/8] dma-buf: use krealloc_array()

2020-11-03 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Use the helper that checks for overflows internally instead of manually calculating the size of the new array. Signed-off-by: Bartosz Golaszewski Acked-by: Christian König --- drivers/dma-buf/sync_file.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions

[PATCH v2 2/8] ALSA: pcm: use krealloc_array()

2020-11-03 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Use the helper that checks for overflows internally instead of manually calculating the size of the new array. Signed-off-by: Bartosz Golaszewski Reviewed-by: Takashi Iwai --- sound/core/pcm_lib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH v2 4/8] pinctrl: use krealloc_array()

2020-11-03 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Use the helper that checks for overflows internally instead of manually calculating the size of the new array. Signed-off-by: Bartosz Golaszewski Reviewed-by: Andy Shevchenko --- drivers/pinctrl/pinctrl-utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH v2 0/8] slab: provide and use krealloc_array()

2020-11-03 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Andy brought to my attention the fact that users allocating an array of equally sized elements should check if the size multiplication doesn't overflow. This is why we have helpers like kmalloc_array(). However we don't have krealloc_array() equivalent and

[PATCH v2 7/8] hwtracing: intel: use krealloc_array()

2020-11-03 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Use the helper that checks for overflows internally instead of manually calculating the size of the new array. Signed-off-by: Bartosz Golaszewski --- drivers/hwtracing/intel_th/msu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH v2 5/8] edac: ghes: use krealloc_array()

2020-11-03 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Use the helper that checks for overflows internally instead of manually calculating the size of the new array. Signed-off-by: Bartosz Golaszewski Acked-by: Borislav Petkov --- drivers/edac/ghes_edac.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH v2 1/8] mm: slab: provide krealloc_array()

2020-11-03 Thread Bartosz Golaszewski
From: Bartosz Golaszewski When allocating an array of elements, users should check for multiplication overflow or preferably use one of the provided helpers like: kmalloc_array(). There's no krealloc_array() counterpart but there are many users who use regular krealloc() to reallocate a

[PATCH v2 3/8] vhost: vringh: use krealloc_array()

2020-11-03 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Use the helper that checks for overflows internally instead of manually calculating the size of the new array. Signed-off-by: Bartosz Golaszewski Acked-by: Michael S. Tsirkin --- drivers/vhost/vringh.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

[PATCH 2/8] ALSA: pcm: use krealloc_array()

2020-10-28 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Use the helper that checks for overflows internally instead of manually calculating the size of the new array. Signed-off-by: Bartosz Golaszewski --- sound/core/pcm_lib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/core/pcm_lib.c b

[PATCH 0/8] slab: provide and use krealloc_array()

2020-10-28 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Andy brought to my attention the fact that users allocating an array of equally sized elements should check if the size multiplication doesn't overflow. This is why we have helpers like kmalloc_array(). However we don't have krealloc_array() equivalent and

Re: [PATCH 3/8] vhost: vringh: use krealloc_array()

2020-10-28 Thread Bartosz Golaszewski
On Tue, Oct 27, 2020 at 6:08 PM Joe Perches wrote: > > On Tue, 2020-10-27 at 17:58 +0100, Bartosz Golaszewski wrote: > > On Tue, Oct 27, 2020 at 5:50 PM Joe Perches wrote: > > > > > > On Tue, 2020-10-27 at 11:28 -0400, Michael S. Tsirkin wrote: > > > >

[PATCH 1/8] mm: slab: provide krealloc_array()

2020-10-28 Thread Bartosz Golaszewski
From: Bartosz Golaszewski When allocating an array of elements, users should check for multiplication overflow or preferably use one of the provided helpers like: kmalloc_array(). There's no krealloc_array() counterpart but there are many users who use regular krealloc() to reallocate a

[PATCH 8/8] dma-buf: use krealloc_array()

2020-10-28 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Use the helper that checks for overflows internally instead of manually calculating the size of the new array. Signed-off-by: Bartosz Golaszewski --- drivers/dma-buf/sync_file.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/dma-buf

[PATCH 5/8] edac: ghes: use krealloc_array()

2020-10-28 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Use the helper that checks for overflows internally instead of manually calculating the size of the new array. Signed-off-by: Bartosz Golaszewski --- drivers/edac/ghes_edac.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/edac

[PATCH 7/8] hwtracing: intel: use krealloc_array()

2020-10-28 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Use the helper that checks for overflows internally instead of manually calculating the size of the new array. Signed-off-by: Bartosz Golaszewski --- drivers/hwtracing/intel_th/msu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH 4/8] pinctrl: use krealloc_array()

2020-10-28 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Use the helper that checks for overflows internally instead of manually calculating the size of the new array. Signed-off-by: Bartosz Golaszewski --- drivers/pinctrl/pinctrl-utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl

Re: [PATCH 3/8] vhost: vringh: use krealloc_array()

2020-10-28 Thread Bartosz Golaszewski
On Tue, Oct 27, 2020 at 5:50 PM Joe Perches wrote: > > On Tue, 2020-10-27 at 11:28 -0400, Michael S. Tsirkin wrote: > > On Tue, Oct 27, 2020 at 01:17:20PM +0100, Bartosz Golaszewski wrote: > > > From: Bartosz Golaszewski > > > > > > Use the helper that che

[PATCH 3/8] vhost: vringh: use krealloc_array()

2020-10-28 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Use the helper that checks for overflows internally instead of manually calculating the size of the new array. Signed-off-by: Bartosz Golaszewski --- drivers/vhost/vringh.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/vhost/vringh.c b

[PATCH 6/8] drm: atomic: use krealloc_array()

2020-10-28 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Use the helper that checks for overflows internally instead of manually calculating the size of the new array. Signed-off-by: Bartosz Golaszewski --- drivers/gpu/drm/drm_atomic.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm

Re: [PATCH] backlight: pwm_bl: Switch to full GPIO descriptor

2019-12-06 Thread Bartosz Golaszewski
t; and things should work smoothly with the new API. > > Cc: Krzysztof Kozlowski > Cc: Robert Jarzmik > Cc: Guan Xuetao > Cc: Bartosz Golaszewski > Signed-off-by: Linus Walleij > --- > arch/arm/mach-pxa/cm-x300.c | 1 - > arch/arm/mach-pxa/colibri-pxa270-i

Re: [PATCH v7 0/9] backlight: gpio: simplify the driver

2019-11-10 Thread Bartosz Golaszewski
pon., 4 lis 2019 o 10:22 Bartosz Golaszewski napisał(a): > > pt., 1 lis 2019 o 16:39 Jacopo Mondi napisał(a): > > > > Hello, > > as promised... > > > > On Fri, Nov 01, 2019 at 08:58:03AM +, Lee Jones wrote: > > > On Thu, 24 Oct

Re: [PATCH v7 0/9] backlight: gpio: simplify the driver

2019-11-04 Thread Bartosz Golaszewski
47:26AM +0100, Lee Jones wrote: > > > > On Wed, 23 Oct 2019, Daniel Thompson wrote: > > > > > > > > > On Tue, Oct 22, 2019 at 11:29:54AM +0200, Bartosz Golaszewski wrote: > > > > > > wt., 22 paź 2019 o 10:36 Bartosz Golaszewski > > &g

[PATCH v7 9/9] backlight: gpio: pull gpio_backlight_initial_power_state() into probe

2019-10-23 Thread Bartosz Golaszewski
From: Bartosz Golaszewski The probe function in the gpio-backlight driver is quite short. If we pull gpio_backlight_initial_power_state() into probe we can drop two more fields from struct gpio_backlight and shrink the driver code. Signed-off-by: Bartosz Golaszewski Acked-by: Daniel Thompson

dri-devel@lists.freedesktop.org

2019-10-23 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Instead of dereferencing pdev each time, use a helper variable for the associated device pointer. Signed-off-by: Bartosz Golaszewski Reviewed-by: Linus Walleij Reviewed-by: Daniel Thompson Reviewed-by: Andy Shevchenko --- drivers/video/backlight/gpio_backlight.c

[PATCH v7 7/9] backlight: gpio: remove unused fields from platform data

2019-10-23 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Remove the platform data fields that nobody uses. Signed-off-by: Bartosz Golaszewski Reviewed-by: Andy Shevchenko Reviewed-by: Linus Walleij Reviewed-by: Daniel Thompson --- include/linux/platform_data/gpio_backlight.h | 3 --- 1 file changed, 3 deletions(-) diff

[PATCH v7 2/9] backlight: gpio: remove stray newline

2019-10-23 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Remove a double newline from the driver. Signed-off-by: Bartosz Golaszewski Reviewed-by: Andy Shevchenko Reviewed-by: Daniel Thompson --- drivers/video/backlight/gpio_backlight.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/video/backlight

  1   2   3   4   >