Re: [PATCH 2/2] drm: zynqmp_dp: Use scope-based mutex helpers

2025-02-06 Thread Bart Van Assche
On 2/6/25 11:41 AM, Sean Anderson wrote: static int zynqmp_dp_enhanced_set(void *data, u64 val) { struct zynqmp_dp *dp = data; - int ret = 0; - mutex_lock(&dp->lock); + guard(mutex)(&dp->lock); dp->test.enhanced = val; if (dp->test.active) -

Re: [PATCH RESEND v2 08/19] scsi: libfcoe: Include instead of

2024-09-10 Thread Bart Van Assche
#include #include Reviewed-by: Bart Van Assche

Re: [LSF/MM/BPF proposal]: Physr discussion

2023-01-23 Thread Bart Van Assche
On 1/23/23 05:44, Jason Gunthorpe wrote: I've gone from quite a different starting point - I've been working DMA API upwards, so what does the dma_map_XX look like, what APIs do we need to support the dma_map_ops implementations to iterate/etc, how do we form and return the dma mapped list, how d

Re: [PATCH 48/64] drbd: Use struct_group() to zero algs

2021-07-29 Thread Bart Van Assche
On 7/29/21 7:31 PM, Kees Cook wrote: > On Wed, Jul 28, 2021 at 02:45:55PM -0700, Bart Van Assche wrote: >> On 7/27/21 1:58 PM, Kees Cook wrote: >>> In preparation for FORTIFY_SOURCE performing compile-time and run-time >>> field bounds checking for memset(), avoid i

Re: [PATCH 19/64] ip: Use struct_group() for memcpy() regions

2021-07-28 Thread Bart Van Assche
On 7/28/21 2:01 PM, Kees Cook wrote: > On Wed, Jul 28, 2021 at 07:55:53AM +0200, Greg Kroah-Hartman wrote: >>> struct ethhdr { >>> - unsigned char h_dest[ETH_ALEN]; /* destination eth addr */ >>> - unsigned char h_source[ETH_ALEN]; /* source ether addr*/ >>> + union { >>> +

Re: [PATCH 48/64] drbd: Use struct_group() to zero algs

2021-07-28 Thread Bart Van Assche
On 7/27/21 1:58 PM, Kees Cook wrote: In preparation for FORTIFY_SOURCE performing compile-time and run-time field bounds checking for memset(), avoid intentionally writing across neighboring fields. Add a struct_group() for the algs so that memset() can correctly reason about the size. Signed-o

Re: [PATCH 01/64] media: omap3isp: Extract struct group for memcpy() region

2021-07-28 Thread Bart Van Assche
On 7/28/21 2:14 AM, Dan Carpenter wrote: On Wed, Jul 28, 2021 at 10:59:22AM +0200, David Sterba wrote: drivers/media/platform/omap3isp/ispstat.c | 5 +-- include/uapi/linux/omap3isp.h | 44 +-- 2 files changed, 36 insertions(+), 13 deletions(-) diff --git a/

Re: [PATCH 33/64] lib: Introduce CONFIG_TEST_MEMCPY

2021-07-27 Thread Bart Van Assche
On 7/27/21 1:58 PM, Kees Cook wrote: +static int __init test_memcpy_init(void) +{ + int err = 0; + + err |= test_memcpy(); + err |= test_memmove(); + err |= test_memset(); + + if (err) { + pr_warn("FAIL!\n"); + err = -EINVAL; + } els

Re: [PATCH v3 03/24] drivers/block/z2ram: use ioremap_wt() instead of __ioremap(_PAGE_WRITETHRU)

2018-10-10 Thread Bart Van Assche
On Tue, 2018-10-09 at 13:51 +, Christophe Leroy wrote: > _PAGE_WRITETHRU is a target specific flag. Prefer generic functions. > > Acked-by: Geert Uytterhoeven > Signed-off-by: Christophe Leroy Hi Geert, All patches that have been applied to this driver since 2005 are API refactoring patche

Re: [Cluster-devel] [PATCH 00/12] drop unneeded newline

2018-01-03 Thread Bart Van Assche
On Tue, 2018-01-02 at 15:00 +0100, Julia Lawall wrote: > On Tue, 2 Jan 2018, Bob Peterson wrote: > > - Original Message - > > > - Original Message - > > > > > Still, the GFS2 and DLM code has a plethora of broken-up printk messages, > > and I don't like the thought of re-combining t

[PATCH] linux/types.h: enable endian checks for all sparse builds

2016-12-09 Thread Bart Van Assche
On 12/08/16 22:40, Madhani, Himanshu wrote: > We’ll take a look and send patches to resolve these warnings. Thanks! Bart.

[PATCH] linux/types.h: enable endian checks for all sparse builds

2016-12-08 Thread Bart Van Assche
On 12/07/16 21:54, Michael S. Tsirkin wrote: > On Thu, Dec 08, 2016 at 05:21:47AM +0000, Bart Van Assche wrote: >> Additionally, there are notable exceptions to the rule that most drivers >> are endian-clean, e.g. drivers/scsi/qla2xxx. I would appreciate it if it >> would rem

[PATCH] linux/types.h: enable endian checks for all sparse builds

2016-12-08 Thread Bart Van Assche
On 12/07/16 18:29, Michael S. Tsirkin wrote: > By now, linux is mostly endian-clean. Enabling endian-ness > checks for everyone produces about 200 new sparse warnings for me - > less than 10% over the 2000 sparse warnings already there. > > Not a big deal, OTOH enabling this helps people notice > t

Enabling peer to peer device transactions for PCIe devices

2016-11-23 Thread Bart Van Assche
On 11/23/2016 09:13 AM, Logan Gunthorpe wrote: > IMO any memory that has been registered for a P2P transaction should be > locked from being evicted. So if there's a get_user_pages call it needs > to be pinned until the put_page. The main issue being with the RDMA > case: handling an eviction when