9d7
drm/amd/display: fix documentation warnings for mpc.h
--
Thanks & Regards,
Aurabindo Pillai
Reviewed-by: Aurabindo Pillai
On 7/12/24 1:45 PM, Abhishek Tamboli wrote:
Add detail description for the read_mpcc_state function in the
mpc_funcs struct to resolve the documentation warning.
A kernel-doc warning was addressed:
./drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:547: warning
state,
curr_pipe->plane_state);
+ if (!phantom_plane)
+ return;
}
memcpy(&phantom_plane->address, &curr_pipe->plane_state->address, sizeof(phantom_plane->address));
--
--
Thanks & Regards,
Aurabindo Pillai
Patch has been merged to amd-staging-drm-next.
On 4/28/24 12:09 PM, Aurabindo Pillai wrote:
Thanks for the fix!
Reviewed-by: Aurabindo Pillai
On 4/28/24 8:42 AM, Dan Carpenter wrote:
Smatch complains because some lines are indented more than they should
be. I went a bit crazy re-indenting
Thanks for the fix!
Reviewed-by: Aurabindo Pillai
On 4/28/24 8:42 AM, Dan Carpenter wrote:
Smatch complains because some lines are indented more than they should
be. I went a bit crazy re-indenting this. ;)
The comments were not useful except as a marker of things which are left
to
*/
+ DMUB_GPINT__GET_TRACE_BUFFER_MASK_WORD2 = 118,
+
+ /**
+* DESC: Updates the trace buffer mask bit32~bit63.
+*/
+ DMUB_GPINT__GET_TRACE_BUFFER_MASK_WORD3 = 119,
};
/**
Reviewed-by: Aurabindo Pillai
On 2023-11-10 12:18, Hamza Mahfooz wrote:
For features that are implemented primarily in DMUB (e.g. PSR), it is
useful to be able to trace them at a DMUB level from the kernel,
especially when debugging issues. So, introduce a debugfs interface that
is able to read and set the DMUB trace mask
On 2023-10-29 05:39, José Pekkarinen wrote:
Spotted by coccicheck, there is a redundant check for
v->SourcePixelFormat[k] != dm_444_16. This patch will
remove it. The corresponding output follows.
drivers/gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.c:5130:86-122: duplicated
argument
On 2023-10-31 08:32, José Pekkarinen wrote:
On 2023-10-31 14:20, Greg KH wrote:
On Tue, Oct 31, 2023 at 01:42:17PM +0200, José Pekkarinen wrote:
On 2023-10-31 07:48, Greg KH wrote:
> On Mon, Oct 30, 2023 at 07:17:48PM +0200, José Pekkarinen wrote:
> > This patch addresses the following warni
} else if (AllowForPStateChangeOrStutterInVBlankFinal ==
- dm_prefetch_support_uclk_fclk_and_stutter_if_possible) {
- *MinPrefetchMode = 0;
- *MaxPrefetchMode = 3;
} else {
*MinPrefetchMode = 0;
*MaxPrefetchMode = 3;
Reviewed-by:
On 2023-10-30 12:26, José Pekkarinen wrote:
On 2023-10-30 15:52, Aurabindo Pillai wrote:
On 10/29/2023 8:44 AM, José Pekkarinen wrote:
This patch addresses the following warning spotted by
using coccinelle where the case checked does the same
than the else case.
drivers/gpu/drm/amd/display
wportWidthChroma[k] > v->SurfaceWidthC[k] ||
v->ViewportHeightChroma[k] > v->SurfaceHeightC[k]) {
ViewportExceedsSurface = true;
}
Thanks for catching.
Reviewed-by: Aurabindo Pillai
On 10/29/2023 8:44 AM, José Pekkarinen wrote:
This patch addresses the following warning spotted by
using coccinelle where the case checked does the same
than the else case.
drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c:4664:8-10:
WARNING: possible condition with no eff
to_insert &&
+ (last_render_time_in_us / frames_to_insert) <
+ in_out_vrr->min_duration_in_us){
frames_to_insert -= (frames_to_insert > 1) ?
1 : 0;
}
Reviewed-by: Aurabindo Pillai
--
Thanks & Regards,
Jay
On 7/12/2023 12:24 PM, Melissa Wen wrote:
On 07/12, Pillai, Aurabindo wrote:
[Public]
Hi Guilherme,
Sorry there was one more patch which I missed to attach. Please add this 3rd
patch and retry.
Reverting that patch would cause high power consumption on Navi2x GPU also
cause hangs on cert
On 7/12/2023 11:50 AM, Guilherme G. Piccoli wrote:
On 12/07/2023 11:47, Pillai, Aurabindo wrote:
Hi Guilherme,
Sorry there was one more patch which I missed to attach. Please add this
3^rd patch and retry.
Reverting that patch would cause high power consumption on Navi2x GPU
also cause han
done timed out"
>
> No other error is observed, it just stays like that. After bisecting
> amd-staging-drm-next, we narrowed it down to this commit. Seems it
> makes sense to revert it to have the tree bootable until a proper
> solution is worked.
>
> Cc: Aurabindo Pil
-2225,4 +2225,7 @@ void dc_process_dmub_dpia_hpd_int_enable(const struct dc
*dc,
/* Disable acc mode Interfaces */
void dc_disable_accelerated_mode(struct dc *dc);
+bool dc_is_timing_changed(struct dc_stream_state *cur_stream,
+ struct dc_stream_state *new_stream);
+
#endif /* DC_INTERFACE_H_ */
Reviewed-by: Aurabindo Pillai
uot;phy repeater mode: non-transparent\n");
- else if ((uint8_t)*data == 0x00)
- seq_printf(m, "phy repeater mode: non lttpr\n");
- else
- seq_printf(m, "phy repeater mode: read error\n");
-
- kfree(data);
+ seq_puts(m, "\n");
return 0;
}
Reviewed-by: Aurabindo Pillai
/
(MaximumTvmPlus2Tr0PlusTsw - MinimumTvmPlus2Tr0 - PrefetchPixelLinesTime[k] /
4),
(2 * ExtraLatencyCycles +
PixelDCFCLKCyclesRequiredInPrefetch[k]) / (MaximumTvmPlus2Tr0PlusTsw -
MinimumTvmPlus2Tr0));
}
}
- DCFCLKState[i][j] = dml_min(DCFCLKPerState[i], 1.05 * (1 +
mode_lib->vba.PercentMarginOverMinimumRequiredDCFCLK / 100)
+ v->DCFCLKState[i][j] = dml_min(v->DCFCLKPerState[i], 1.05
* (1 + mode_lib->vba.PercentMarginOverMinimumRequiredDCFCLK / 100)
*
dml_max(DCFCLKRequiredForAverageBandwidth, DCFCLKRequiredForPeakBandwidth));
}
}
Reviewed-by: Aurabindo Pillai
36,7 @@
#define DCN_BASE__INST0_SEG2 0x34C0
-enum dc_irq_source to_dal_irq_source_dcn32(
+static enum dc_irq_source to_dal_irq_source_dcn32(
struct irq_service *irq_service,
uint32_t src_id,
uint32_t ext_id)
Reviewed-by: Aurabindo Pillai
id decide_link_settings(struct dc_stream_state *stream,
struct dc_link_settings *link_setting)
{
Reviewed-by: Aurabindo Pillai
0%7C0%7C637561717696066502%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000&sdata=vUFEeBJwjTDnI9l8MGDiW8%2FoX7LINZi%2FfD4A004QfLs%3D&reserved=0
--
Regards,
Aurabindo Pillai
(system_highpri_wq, &handler_data_add->work))
+ DRM_DEBUG("__func__: a work_struct is allocated and
queued, "
+ "src %d\n", irq_source);
+ else
+ DRM_ERROR("__func__: a new work_struct cannot be
queued,
f the mode natively.
Signed-off-by: Aurabindo Pillai
Acked-by: Christian König
Reviewed-by: Shashank Sharma
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 159 ++
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 2 +
2 files changed, 161 insertions(+)
diff --git a/driver
ff-by: Aurabindo Pillai
Acked-by: Christian König
Reviewed-by: Shashank Sharma
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 +
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 12
2 files changed, 13 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h
b/drivers/gpu/dr
refresh rate matching the video.
[How]
Skip full modeset if userspace requested a compatible freesync mode which only
differs in the front porch timing from the current mode.
Signed-off-by: Aurabindo Pillai
Acked-by: Christian König
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 220
ne of these modes.
---
---
Aurabindo Pillai (3):
drm/amd/display: Add module parameter for freesync video mode
drm/amd/display: Add freesync video modes based on preferred modes
drm/amd/display: Skip modeset for front porch change
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 +
driver
On 2021-02-08 10:06 a.m., Kazlauskas, Nicholas wrote:
On 2021-01-24 11:00 p.m., Aurabindo Pillai wrote:
On 2021-01-21 2:05 p.m., Kazlauskas, Nicholas wrote:
On 2021-01-19 10:50 a.m., Aurabindo Pillai wrote:
[Why]
A seamless transition between modes can be performed if the new
incoming
On 2021-01-21 2:05 p.m., Kazlauskas, Nicholas wrote:
On 2021-01-19 10:50 a.m., Aurabindo Pillai wrote:
[Why]
A seamless transition between modes can be performed if the new incoming
mode has the same timing parameters as the optimized mode on a display
with a
variable vtotal min/max
f the mode natively.
Signed-off-by: Aurabindo Pillai
Acked-by: Christian König
Reviewed-by: Shashank Sharma
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 170 ++
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 2 +
2 files changed, 172 insertions(+)
diff --git a/driver
refresh rate matching the video.
[How]
Skip full modeset if userspace requested a compatible freesync mode which only
differs in the front porch timing from the current mode.
Signed-off-by: Aurabindo Pillai
Acked-by: Christian König
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 233
modes that are within the connected monitor's VRR range
corresponding to common video modes, which media players can use for a seamless
experience while making use of freesync.
Signed-off-by: Aurabindo Pillai
Acked-by: Christian König
Reviewed-by: Shashank Sharma
---
drivers/gpu/drm/amd/a
driver
modelist, and also enables the optimization to skip modeset when using
one of these modes.
--
Aurabindo Pillai (3):
drm/amd/display: Add module parameter for freesync video mode
drm/amd/display: Add freesync video modes based on preferred modes
drm/amd/display: Skip modeset for front
hatever mode they want. So I dont see a reason
why this cant be in the kernel.
--
Regards,
Aurabindo Pillai
>
>
> Thanks,
> pq
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Thanks & Regards,
Aurabindo Pillai
On Wed, Jan 6, 2021 at 15:02, "Kazlauskas, Nicholas"
wrote:
On 2021-01-04 4:08 p.m., Aurabindo Pillai wrote:
[Why&How]
Inorder to enable freesync video mode, driver adds extra
modes based on preferred modes for common freesync
the base freesync mode
based off which timings have been generated for the rest of the freesync modes)
since these modes only differ from the base mode with front porch timing.
Signed-off-by: Aurabindo Pillai
Acked-by: Christian König
Reviewed-by: Shashank Sharma
---
.../gpu/drm/amd/display/
same stream.
Signed-off-by: Aurabindo Pillai
Acked-by: Christian König
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 219 +++---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 1 +
2 files changed, 188 insertions(+), 32 deletions(-)
diff --git a/drivers/gpu/drm/amd/dis
cted monitor's VRR range.
Signed-off-by: Aurabindo Pillai
Acked-by: Christian König
Reviewed-by: Shashank Sharma
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 +
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 12
2 files changed, 13 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu
to this
mode does not trigger blanking.
This feature is guarded by a module parameter which is disabled by
default. Enabling this paramters adds additional modes to the driver
modelist, and also enables the optimization to skip modeset when using
one of these modes.
--
Aurabindo Pillai (3):
drm
On Thu, Dec 17, 2020 at 14:11, Alex Deucher
wrote:
On Mon, Dec 14, 2020 at 5:21 PM Aurabindo Pillai
wrote:
[Why&How]
Adds a module parameter to enable experimental freesync video mode
modeset
optimization. Enabling this mode allows the driver to skip a full
modeset when
free
On Tue, 2020-12-15 at 08:32 +0530, Shashank Sharma wrote:
>
> On 15/12/20 3:50 am, Aurabindo Pillai wrote:
> > [Why&How]
> > If experimental freesync video mode module parameter is enabled,
> > add
> > few extra display modes into the driver's mode list corr
same stream.
Signed-off-by: Aurabindo Pillai
Acked-by: Christian König
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 210 +++---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 1 +
2 files changed, 179 insertions(+), 32 deletions(-)
diff --git a/drivers/gpu/drm/amd/dis
the base freesync mode
based off which timings have been generated for the rest of the freesync modes)
since these modes only differ from the base mode with front porch timing.
Signed-off-by: Aurabindo Pillai
Acked-by: Christian König
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_d
cted monitor's VRR range.
Signed-off-by: Aurabindo Pillai
Acked-by: Christian König
Reviewed-by: Shashank Sharma
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 +
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 12
2 files changed, 13 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu
guarded by a module parameter which is disabled by
default. Enabling this paramters adds additional modes to the driver
modelist, and also enables the optimization to skip modeset when using
one of these modes.
--
Aurabindo Pillai (3):
drm/amd/display: Add module parameter for freesync video mode
On 05/20, Felix Kuehling wrote:
> Am 2020-05-20 um 9:53 a.m. schrieb Aurabindo Pillai:
> > The buffer allocated is of 1024 bytes. Allocate this from
> > heap instead of stack.
> >
> > Also remove check for stack size since we're allocating from heap
> &g
The buffer allocated is of 1024 bytes. Allocate this from
heap instead of stack.
Also remove check for stack size since we're allocating from heap
Signed-off-by: Aurabindo Pillai
Tested-by: Amber Lin
---
drivers/gpu/drm/amd/amdkfd/kfd_smi_events.c | 26 +++--
1 file ch
When DPCD access errors occur, knowing the register and request
associated with the error helps debugging, so print the
details in the debug message.
Signed-off-by: Aurabindo Pillai
---
drivers/gpu/drm/drm_dp_helper.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a
When DPCD access errors occur, knowing the register and request
associated with the error helps debugging, so print the
details in the debug message.
Signed-off-by: Aurabindo Pillai
---
drivers/gpu/drm/drm_dp_helper.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a
Let format prefixes take care of printing the module name
through pr_fmt and dev_fmt definitions.
Signed-off-by: Aurabindo Pillai
---
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 6 +++---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 ++--
drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c
amdgpu uses lots of pr_* calls for printing error messages.
With this prefix, errors shall be more obvious to the end
use regarding its origin, and may help debugging.
Prefix format:
[xxx.x] amdgpu: ...
Signed-off-by: Aurabindo Pillai
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 6 ++
1
Changes in v2
* Add dev_fmt format prefix
* Removed hardcoded module names in pr_* and dev_* prints
Aurabindo Pillai (3):
drm/amd/amdgpu: add prefix for pr_* prints
drm/amd/amdgpu: add print prefix for dev_* variants
drm/amd/amdgpu: remove hardcoded module name in prints
drivers/gpu/drm
Hi Joe,
On Wed, Apr 8, 2020 at 11:37 AM Joe Perches wrote:
>
> All the embedded uses of "amdgpu:" in logging
> messages should also be deleted.
>
> $ git grep -P '(?:dev_|pr_).*"amdgpu:' drivers/gpu/drm/amd/amdgpu/
> drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c:
> pr_err("amdgp
amdgpu uses lots of pr_* calls for printing error messages.
With this prefix, errors shall be more obvious to the end
use regarding its origin, and may help debugging.
Prefix format:
[xxx.x] amdgpu: ...
Signed-off-by: Aurabindo Pillai
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 6 ++
1
Define dev_fmt macro for informative print messages
Signed-off-by: Aurabindo Pillai
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h
b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
index 67d654a89..7a52d37e6 100644
Execution will only reach here if the asserted condition is true.
Hence there is no need for the additional check.
Signed-off-by: Aurabindo Pillai
---
drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/amd
57 matches
Mail list logo
