[PATCH v2 1/2] ARM: dts: exynos4212-tab3: add samsung,invert-vclk flag to fimd

2024-01-04 Thread Artur Weber
os: Add Samsung Galaxy Tab 3 8.0 boards") Signed-off-by: Artur Weber --- arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi b/arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi index d7954ff466b4..e5254

[PATCH v2 0/2] Fix panel polarity mixup in S6D7AA0 panel driver and Galaxy Tab 3 8.0 DTSI

2024-01-04 Thread Artur Weber
Two small one-line patches to address a mixup in the Samsung S6D7AA0 panel driver and the Samsung Galaxy Tab 3 8.0 board it was initially added for. Signed-off-by: Artur Weber --- Changes in v2: - Add "Fixes" tag to both commits. - Link to v1: https://lore.kernel.org/r/20240101-ta

[PATCH v2 2/2] drm/panel: samsung-s6d7aa0: drop DRM_BUS_FLAG_DE_HIGH for lsl080al02

2024-01-04 Thread Artur Weber
dd Samsung S6D7AA0 panel controller driver") Reviewed-by: Jessica Zhang Signed-off-by: Artur Weber --- drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c b/drivers/gpu/drm/pane

[PATCH 2/2] drm/panel: samsung-s6d7aa0: drop DRM_BUS_FLAG_DE_HIGH for lsl080al02

2024-01-01 Thread Artur Weber
It turns out that I had misconfigured the device I was using the panel with; the bus data polarity is not high for this panel, I had to change the config on the display controller's side. Fix the panel config to properly reflect its accurate settings. Signed-off-by: Artur Weber --- driver

[PATCH 1/2] ARM: dts: exynos4212-tab3: add samsung,invert-vclk flag to fimd

2024-01-01 Thread Artur Weber
After more investigation, I've found that it's not the panel driver config that needs to be modified to invert the data polarity, but the FIMD config. Add the missing invert-vclk option that is required to get the display to work correctly. Signed-off-by: Artur Weber --- arch/ar

[PATCH 0/2] Fix panel polarity mixup in S6D7AA0 panel driver and Galaxy Tab 3 8.0 DTSI

2024-01-01 Thread Artur Weber
Two small one-line patches to address a mixup in the Samsung S6D7AA0 panel driver and the Samsung Galaxy Tab 3 8.0 board it was initially added for. Signed-off-by: Artur Weber --- Artur Weber (2): ARM: dts: exynos4212-tab3: add samsung,invert-vclk flag to fimd drm/panel: samsung

[PATCH] backlight: lp855x: Drop ret variable in brightness change function

2023-08-09 Thread Artur Weber
Fixes the following warning: drivers/video/backlight/lp855x_bl.c:252:7: warning: variable 'ret' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized] Signed-off-by: Artur Weber Fixes: 5145531be5fb ("backlight: lp855x: Catch errors when chang

Re: [PATCH] drm/panel: samsung-s6d7aa0: Add MODULE_DEVICE_TABLE

2023-08-02 Thread Artur Weber
t;drm/panel: Add Samsung S6D7AA0 panel controller driver") Signed-off-by: Nikita Travkin --- drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c | 1 + 1 file changed, 1 insertion(+) Acked-by: Artur Weber Best regards Artur

[PATCH 2/2] backlight: lp855x: Catch errors when changing brightness

2023-07-14 Thread Artur Weber
rrors. Signed-off-by: Artur Weber --- drivers/video/backlight/lp855x_bl.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/video/backlight/lp855x_bl.c b/drivers/video/backlight/lp855x_bl.c index 349ec324bc1e..61a7f45bfad8 100644 --- a/drivers/video/back

[PATCH 1/2] backlight: lp855x: Initialize PWM state on first brightness change

2023-07-14 Thread Artur Weber
been done. [1] https://lore.kernel.org/lkml/20230614083953.e4kkweddjz7wz...@pengutronix.de/ Fixes: c1ff7da03e16 ("video: backlight: lp855x: Get PWM for PWM mode during probe") Signed-off-by: Artur Weber --- drivers/video/backlight/lp855x_bl.c | 20 1 file changed,

[PATCH 0/2] backlight: lp855x: Fixes after c1ff7da03e16

2023-07-14 Thread Artur Weber
Two small fixes after commit c1ff7da03e16 ("video: backlight: lp855x: Get PWM for PWM mode during probe"), stemming from a review[1] by Uwe Kleine-König. [1] https://lore.kernel.org/all/20230614083953.e4kkweddjz7wz...@pengutronix.de/ Signed-off-by: Artur Weber Artur Weber (2):

Re: [PATCH] gpu: drm: Optimize the unused variable ret

2023-06-20 Thread Artur Weber
On 19/06/2023 13:31, Li Dong wrote: > Use zero as the return value instead of the unused variable ret > > Signed-off-by: Li Dong > --- > drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-samsung-s

Re: [PATCH 2/4] video: backlight: lp855x: get PWM for PWM mode during probe

2023-06-16 Thread Artur Weber
On 14/06/2023 10:39, Uwe Kleine-König wrote: > On Sat, Apr 29, 2023 at 12:45:32PM +0200, Artur Weber wrote: >> Also deprecate the pwm-period DT property, as it is now redundant >> (pwms property already contains period value). >> >> Signed-off-by: Artur Weber >>

Re: [PATCH] drm/panel: s6d7aa0: remove the unneeded variable in s6d7aa0_lock

2023-06-08 Thread Artur Weber
,7 +79,7 @@ static int s6d7aa0_lock(struct s6d7aa0 *ctx, bool lock) > mipi_dsi_dcs_write_seq(dsi, MCS_PASSWD3, 0xa5, 0xa5); > } > > - return ret; > + return 0; > } > > static int s6d7aa0_on(struct s6d7aa0 *ctx) Reviewed-by: Artur Weber Best regards Artur

Re: [PATCH] drm/panel: s6d7aa0: remove the unneeded variable in s6d7aa0_lock

2023-06-08 Thread Artur Weber
On 08/06/2023 11:36, Andi Shyti wrote: > Hi Jianzheng, > > On Thu, Jun 08, 2023 at 11:34:46AM +0800, Wang Jianzheng wrote: >> Remove unneeded variable and directly return 0. >> >> Signed-off-by: Wang Jianzheng >> --- >> drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c | 3 +-- >> 1 file changed, 1

[PATCH v2] drm/panel: samsung-s6d7aa0: use pointer for drm_mode in panel desc struct

2023-05-24 Thread Artur Weber
.a70a0220.58c1a.9...@mx.google.com Fixes: 6810bb390282 ("drm/panel: Add Samsung S6D7AA0 panel controller driver") Signed-off-by: Artur Weber --- v2: expanded commit message --- drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff -

Re: [PATCH v5 2/3] drm/panel: Add Samsung S6D7AA0 panel controller driver

2023-05-23 Thread Artur Weber
Hi, On 23/05/2023 20:02, Nathan Chancellor wrote: > Hi Artur, > > On Fri, May 19, 2023 at 07:03:53PM +0200, Artur Weber wrote: >> Initial driver for S6D7AA0-controlled panels. Currently, the following >> panels are supported: >> >> - S6D7AA0-LSL080AL02 (Samsun

[PATCH] drm/panel: samsung-s6d7aa0: use pointer for drm_mode in panel desc struct

2023-05-23 Thread Artur Weber
Fixes compilation errors on older GCC versions (before 8.x) and Clang after changes introduced in commit 6810bb390282 ("drm/panel: Add Samsung S6D7AA0 panel controller driver"). Tested with GCC 13.1.1, GCC 6.4.0 and Clang 16.0.3. Signed-off-by: Artur Weber --- drivers/gpu/drm/p

[PATCH v2 2/4] video: backlight: lp855x: get PWM for PWM mode during probe

2023-05-19 Thread Artur Weber
Also deprecate the pwm-period DT property, as it is now redundant (pwms property already contains period value). Signed-off-by: Artur Weber --- drivers/video/backlight/lp855x_bl.c | 48 - 1 file changed, 26 insertions(+), 22 deletions(-) diff --git a/drivers/video

[PATCH v2 4/4] arm64: dts: adapt to LP855X bindings changes

2023-05-19 Thread Artur Weber
Change underscores in ROM node names to dashes, and remove deprecated pwm-period property. Signed-off-by: Artur Weber --- arch/arm64/boot/dts/nvidia/tegra210-p2371-2180.dts | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/arch/arm64/boot/dts/nvidia/tegra210-p2371-2180

[PATCH v2 1/4] dt-bindings: backlight: lp855x: convert to YAML and modernize

2023-05-19 Thread Artur Weber
ccept the property, so this should not break ABI. Signed-off-by: Artur Weber Reviewed-by: Rob Herring --- Changed in v2: - Added additionalProperties to ROM patternProperties --- .../leds/backlight/lp855x-backlight.yaml | 149 ++ .../bindings/leds/backlight/lp855x.txt

[PATCH v2 0/4] video: backlight: lp855x: modernize bindings

2023-05-19 Thread Artur Weber
Convert TI LP855X backlight controller bindings from TXT to YAML and, while we're at it, rework some of the code related to PWM handling. Also correct existing DTS files to avoid introducing new dtb_check errors. Signed-off-by: Artur Weber Changed in v2: - Added additionalProperties t

[PATCH v5 3/3] MAINTAINERS: Add entry for Samsung S6D7AA0 LCD panel controller driver

2023-05-19 Thread Artur Weber
Add myself as maintainer of the Samsung S6D7AA0 panel driver. Signed-off-by: Artur Weber --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 402e26d0cdbc..7cc2bfa4af6f 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -6663,6 +6663,12 @@ S

[PATCH v5 2/3] drm/panel: Add Samsung S6D7AA0 panel controller driver

2023-05-19 Thread Artur Weber
work with other panels using this IC. Tested-by: Nikita Travkin #ltl101at01 Signed-off-by: Artur Weber --- Changed in v2: - Removed unused panel_name property from desc struct Changed in v4: - Added LSL080AL03 and LTL101AT01 panels - Added DSI-controlled backlight support for panels that

[PATCH v5 1/3] dt-bindings: display: panel: Add Samsung S6D7AA0 LCD panel controller

2023-05-19 Thread Artur Weber
Add bindings for the S6D7AA0 LCD panel controller, including the S6D7AA0-LSL080AL02 panel used in the Samsung Galaxy Tab 3 8.0 family of tablets, and the S6D7AA0-LSL080AL03 and S6D7AA0-LTL101AT01 panels used in the Samsung Galaxy Tab A 8.0 and 9.7 2015. Signed-off-by: Artur Weber --- Changed in

[PATCH v5 0/3] Add Samsung S6D7AA0 panel controller driver

2023-05-19 Thread Artur Weber
'|' from multiline descriptions in DT schema - Fixed DT bindings license Tested-by: Nikita Travkin #ltl101at01 Signed-off-by: Artur Weber Artur Weber (3): dt-bindings: display: panel: Add Samsung S6D7AA0 LCD panel controller drm/panel: Add Samsung S6D7AA0 panel controller driver M

[PATCH v4 3/3] MAINTAINERS: Add entry for Samsung S6D7AA0 LCD panel controller driver

2023-05-01 Thread Artur Weber
Add myself as maintainer of the Samsung S6D7AA0 panel driver. Signed-off-by: Artur Weber --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 59a9a22a69fc..d1bc2f8b6e34 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -6641,6 +6641,12 @@ S

[PATCH v4 2/3] drm/panel: Add Samsung S6D7AA0 panel controller driver

2023-05-01 Thread Artur Weber
work with other panels using this IC. Tested-by: Nikita Travkin #ltl101at01 Signed-off-by: Artur Weber --- Changed in v2: - Removed unused panel_name property from desc struct Changed in v4: - Added LSL080AL03 and LTL101AT01 panels - Added DSI-controlled backlight support for panels that

[PATCH v4 0/3] Add Samsung S6D7AA0 panel controller driver

2023-05-01 Thread Artur Weber
LTL101AT01 panels - Added DSI-controlled backlight support for panels that support it - Added vmipi-supply - Dropped s6d7aa0_bl_ctl_on function (not universal across all panels) - Removed MIPI_DSI_MODE_LPM flag Artur Weber (3): dt-bindings: display: panel: Add Samsung S6D7AA0 LCD panel

[PATCH v4 1/3] dt-bindings: display: panel: Add Samsung S6D7AA0 LCD panel controller

2023-05-01 Thread Artur Weber
Add bindings for the S6D7AA0 LCD panel controller, including the S6D7AA0-LSL080AL02 panel used in the Samsung Galaxy Tab 3 8.0 family of tablets, and the S6D7AA0-LSL080AL03 and S6D7AA0-LTL101AT01 panels used in the Samsung Galaxy Tab A 8.0 and 9.7 2015. Signed-off-by: Artur Weber --- Changed in

[PATCH 4/4] arm64: dts: adapt to LP855X bindings changes

2023-04-29 Thread Artur Weber
Change underscores in ROM node names to dashes, and remove deprecated pwm-period property. Signed-off-by: Artur Weber --- arch/arm64/boot/dts/nvidia/tegra210-p2371-2180.dts | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/arch/arm64/boot/dts/nvidia/tegra210-p2371-2180

[PATCH 1/4] dt-bindings: backlight: lp855x: convert to YAML and modernize

2023-04-29 Thread Artur Weber
ccept the property, so this should not break ABI. Signed-off-by: Artur Weber --- .../leds/backlight/lp855x-backlight.yaml | 148 ++ .../bindings/leds/backlight/lp855x.txt| 72 - 2 files changed, 148 insertions(+), 72 deletions(-) create mode 100644 Document

[PATCH 2/4] video: backlight: lp855x: get PWM for PWM mode during probe

2023-04-29 Thread Artur Weber
Also deprecate the pwm-period DT property, as it is now redundant (pwms property already contains period value). Signed-off-by: Artur Weber --- drivers/video/backlight/lp855x_bl.c | 48 - 1 file changed, 26 insertions(+), 22 deletions(-) diff --git a/drivers/video

[PATCH 3/4] ARM: dts: adapt to LP855X bindings changes

2023-04-29 Thread Artur Weber
Change underscores in ROM node names to dashes, and remove deprecated pwm-period property. Signed-off-by: Artur Weber --- .../dts/qcom-apq8026-samsung-matisse-wifi.dts | 1 - ...-msm8974pro-sony-xperia-shinano-castor.dts | 23 ++- 2 files changed, 12 insertions(+), 12 deletions

[PATCH 0/4] video: backlight: lp855x: modernize bindings

2023-04-29 Thread Artur Weber
Convert TI LP855X backlight controller bindings from TXT to YAML and, while we're at it, rework some of the code related to PWM handling. Also correct existing DTS files to avoid introducing new dtb_check errors. Signed-off-by: Artur Weber Artur Weber (4): dt-bindings: backlight: l

Re: [PATCH v3 2/3] drm/panel: Add Samsung S6D7AA0 panel controller driver

2023-04-22 Thread Artur Weber
... but I just re-tested without it and it seems that it might've fixed some odd issues I'd get sometimes when going out of sleep mode. I'll get rid of it in the next version. (I based my panel driver off that driver; now that I think about it, it might be worth mentioning somewhere

[PATCH v2 2/3] drm/panel: Add Samsung S6D7AA0 panel controller driver

2023-04-17 Thread Artur Weber
Initial driver for S6D7AA0-controlled panels, currently only for the LSL080AL02 panel used in the Samsung Galaxy Tab 3 8.0 family of tablets. It should be possible to extend this driver to work with other panels using this IC. Signed-off-by: Artur Weber --- Changed in v2: - Removed unused

[PATCH 3/3] MAINTAINERS: Add myself as Samsung S6D7AA0 panel driver maintainer

2023-04-17 Thread Artur Weber
Signed-off-by: Artur Weber --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 90abe83c02f3..6a55e6e3ac59 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -6623,6 +6623,12 @@ S: Maintained F: Documentation/devicetree/bindings/display

[PATCH 0/3] Add Samsung S6D7AA0 panel controller driver

2023-04-17 Thread Artur Weber
This patchset adds initial support for Samsung S6D7AA0-based panels. Currently, only the S6D7AA0-LSL080AL02 panel used in the Samsung Galaxy Tab 3 8.0 family of tablets is supported; other panels can be added in the future. Signed-off-by: Artur Weber Artur Weber (3): dt-bindings: panel: Add

Re: [PATCH v2 1/3] dt-bindings: display: panel: Add Samsung S6D7AA0 LCD panel controller

2023-04-17 Thread Artur Weber
On 16/04/2023 15:07, Artur Weber wrote: Add bindings for the S6D7AA0 LCD panel controller, including the S6D7AA0-LSL080AL02 panel used in the Samsung Galaxy Tab 3 8.0 family of tablets. Signed-off-by: Artur Weber --- Changed in v2: - Updated commit message - Applied suggestions from

[PATCH 1/3] dt-bindings: panel: Add Samsung S6D7AA0 LCD controller bindings

2023-04-17 Thread Artur Weber
Signed-off-by: Artur Weber --- .../display/panel/samsung,s6d7aa0.yaml| 51 +++ 1 file changed, 51 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/samsung,s6d7aa0.yaml diff --git a/Documentation/devicetree/bindings/display/panel/samsung

[PATCH v3 1/3] dt-bindings: display: panel: Add Samsung S6D7AA0 LCD panel controller

2023-04-17 Thread Artur Weber
Add bindings for the S6D7AA0 LCD panel controller, including the S6D7AA0-LSL080AL02 panel used in the Samsung Galaxy Tab 3 8.0 family of tablets. Signed-off-by: Artur Weber --- Changed in v2: - Updated commit message - Applied suggestions from Krzysztof Kozlowski Changed in v3: - Correctly

[PATCH v2 1/3] dt-bindings: display: panel: Add Samsung S6D7AA0 LCD panel controller

2023-04-17 Thread Artur Weber
Add bindings for the S6D7AA0 LCD panel controller, including the S6D7AA0-LSL080AL02 panel used in the Samsung Galaxy Tab 3 8.0 family of tablets. Signed-off-by: Artur Weber --- Changed in v2: - Updated commit message - Applied suggestions from Krzysztof Kozlowski --- .../display/panel

[PATCH v3 3/3] MAINTAINERS: Add entry for Samsung S6D7AA0 LCD panel controller driver

2023-04-17 Thread Artur Weber
Add myself as maintainer of the Samsung S6D7AA0 panel driver. Signed-off-by: Artur Weber --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 90abe83c02f3..6a55e6e3ac59 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -6623,6 +6623,12 @@ S

[PATCH v2 0/3] Add Samsung S6D7AA0 panel controller driver

2023-04-17 Thread Artur Weber
entry commits - dt-bindings: Applied suggestions from Krzysztof Kozlowski - driver: Removed unused panel_name property from desc struct Artur Weber (3): dt-bindings: panel: Add Samsung S6D7AA0 LCD controller bindings drm/panel: Add Samsung S6D7AA0 panel controller driver MAINTAINERS: Add

[PATCH v3 2/3] drm/panel: Add Samsung S6D7AA0 panel controller driver

2023-04-17 Thread Artur Weber
Initial driver for S6D7AA0-controlled panels, currently only for the LSL080AL02 panel used in the Samsung Galaxy Tab 3 8.0 family of tablets. It should be possible to extend this driver to work with other panels using this IC. Signed-off-by: Artur Weber --- Changed in v2: - Removed unused

[PATCH v3 0/3] Add Samsung S6D7AA0 panel controller driver

2023-04-17 Thread Artur Weber
entry commits - dt-bindings: Applied suggestions from Krzysztof Kozlowski - driver: Removed unused panel_name property from desc struct Changed in v3: - Correctly applied patch for dt-bindings Artur Weber (3): dt-bindings: display: panel: Add Samsung S6D7AA0 LCD panel controller drm/panel

[PATCH v2 3/3] MAINTAINERS: Add entry for Samsung S6D7AA0 LCD panel controller driver

2023-04-17 Thread Artur Weber
Add myself as maintainer of the Samsung S6D7AA0 panel driver. Signed-off-by: Artur Weber --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 90abe83c02f3..6a55e6e3ac59 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -6623,6 +6623,12 @@ S

[PATCH 2/3] drm/panel: Add Samsung S6D7AA0 panel controller driver

2023-04-17 Thread Artur Weber
Initial driver for S6D7AA0-controlled panels, currently only for the LSL080AL02 panel used in the Samsung Galaxy Tab 3 8.0 family of boards. It should be possible to extend this driver to work with other panels using this IC. Signed-off-by: Artur Weber --- drivers/gpu/drm/panel/Kconfig