[PATCH v2 04/12] dt-bindings: ASoC: Convert MediaTek RT5650 codecs bindings to DT schema

2025-09-20 Thread Ariel D'Alessandro
Convert the existing text-based DT bindings for Mediatek MT8173 RT5650 codecs to a DT schema. Signed-off-by: Ariel D'Alessandro --- .../sound/mediatek,mt8173-rt5650.yaml | 73 +++ .../bindings/sound/mt8173-rt5650.txt | 31 2 files changed, 73 inser

Re: [PATCH v1 07/14] dt-bindings: display: mediatek,ufoe: Add mediatek,gce-client-reg property

2025-09-20 Thread Ariel D'Alessandro
Krzysztof, On 8/21/25 3:50 AM, Krzysztof Kozlowski wrote: On Wed, Aug 20, 2025 at 02:12:55PM -0300, Ariel D'Alessandro wrote: Current, the DT bindings for Mediatek UFOe (Unified Frame Optimization engine) is missing the mediatek,gce-client-reg property. Add it and Why is it missing? I

[PATCH v2 00/12] MediaTek dt-bindings sanitization (MT8173)

2025-09-20 Thread Ariel D'Alessandro
* melfas,mip4_ts: Dropped unnecessary quotes. Added "active high" to ce-gpios property description. * mediatek,jpeg: Dropped patch as it doesn't apply. Signed-off-by: Ariel D'Alessandro Ariel D'Alessandro (12): dt-bindings: media: Convert MediaTek mt8173-mdp bindings t

[PATCH v2 12/12] dt-bindings: input: Convert MELFAS MIP4 Touchscreen to DT schema

2025-09-20 Thread Ariel D'Alessandro
Convert the existing text-based DT bindings for MELFAS MIP4 Touchscreen controller to a DT schema. Signed-off-by: Ariel D'Alessandro Reviewed-by: Rob Herring (Arm) --- .../input/touchscreen/melfas,mip4_ts.yaml | 56 +++ .../input/touchscreen/melfas_mip4.txt

[PATCH v2 08/12] dt-bindings: pinctrl: mt65xx: Allow gpio-line-names

2025-09-20 Thread Ariel D'Alessandro
Current, the DT bindings for MediaTek's MT65xx Pin controller is missing the gpio-line-names property, add it to the associated schema. Signed-off-by: Ariel D'Alessandro --- .../devicetree/bindings/pinctrl/mediatek,mt65xx-pinctrl.yaml| 2 ++ 1 file changed, 2 insertions(+) dif

Re: [PATCH v1 01/14] media: dt-bindings: Convert MediaTek mt8173-mdp bindings to YAML

2025-09-18 Thread Ariel D'Alessandro
Krzysztof, On 8/21/25 3:46 AM, Krzysztof Kozlowski wrote: On Wed, Aug 20, 2025 at 02:12:49PM -0300, Ariel D'Alessandro wrote: Convert the existing text-based DT bindings for MediaTek MT8173 Media Data Path to a YAML schema. Please wrap commit message according to Linux coding

Re: [PATCH v1 03/14] dt-bindings: arm: mediatek: mmsys: Add assigned-clocks/rates properties

2025-09-18 Thread Ariel D'Alessandro
Krzysztof, On 8/21/25 3:43 AM, Krzysztof Kozlowski wrote: On Wed, Aug 20, 2025 at 02:12:51PM -0300, Ariel D'Alessandro wrote: Current, the DT bindings for MediaTek mmsys controller is missing the assigned-clocks and assigned-clocks-rates properties. Add these and No, they do not miss th

Re: [PATCH v1 04/14] net: dt-bindings: Convert Marvell 8897/8997 bindings to YAML

2025-09-17 Thread Ariel D'Alessandro
Hi Rob, On 8/21/25 11:28 AM, Rob Herring wrote: On Wed, Aug 20, 2025 at 12:15 PM Ariel D'Alessandro wrote: Convert the existing text-based DT bindings for Marvell 8897/8997 (sd8897/sd8997) bluetooth devices controller to a YAML schema. While here, bindings for "usb1286,204e"

[PATCH v2 03/12] dt-bindings: net: Convert Marvell 8897/8997 bindings to DT schema

2025-09-17 Thread Ariel D'Alessandro
ding users are updated to use bluetooth generic name recommendation. [0] Documentation/devicetree/bindings/net/btusb.txt Signed-off-by: Ariel D'Alessandro --- .../net/bluetooth/marvell,sd8897-bt.yaml | 79 ++ .../devicetree/bindings/net/btusb.txt | 2 +- .

Re: [PATCH v1 02/14] media: dt-bindings: Convert MediaTek mt8173-vpu bindings to YAML

2025-09-12 Thread Ariel D'Alessandro
Krzysztof, On 8/21/25 3:47 AM, Krzysztof Kozlowski wrote: On Wed, Aug 20, 2025 at 02:12:50PM -0300, Ariel D'Alessandro wrote: Convert the existing text-based DT bindings for Mediatek MT8173 Video Processor Unit to a YAML schema. DT schema, not YAML. Don't say YAML at all, neither h

Re: [PATCH v1 03/14] dt-bindings: arm: mediatek: mmsys: Add assigned-clocks/rates properties

2025-09-11 Thread Ariel D'Alessandro
Krzysztof, On 9/9/25 3:29 AM, Krzysztof Kozlowski wrote: On 08/09/2025 21:19, Ariel D'Alessandro wrote: Krzysztof, On 8/21/25 3:43 AM, Krzysztof Kozlowski wrote: On Wed, Aug 20, 2025 at 02:12:51PM -0300, Ariel D'Alessandro wrote: Current, the DT bindings for MediaTek mmsys con

[PATCH v2 10/12] arm64: dts: mediatek: mt8173-elm: Drop unused bank supply

2025-09-11 Thread Ariel D'Alessandro
The mediatek,mt8173-thermal device tree binding schema doesn't allow regulator supplies like the ones defined in mt8173-elm.dtsi. Drop these as the associated driver doesn't implement them either. Signed-off-by: Ariel D'Alessandro --- arch/arm64/boot/dts/mediatek/mt8173-elm.dt

[PATCH v2 01/12] dt-bindings: media: Convert MediaTek mt8173-mdp bindings to DT schema

2025-09-11 Thread Ariel D'Alessandro
Convert the existing text-based DT bindings for MediaTek MT8173 Media Data Path to a DT schema. Signed-off-by: Ariel D'Alessandro --- .../bindings/media/mediatek,mt8173-mdp.yaml | 169 ++ .../bindings/media/mediatek-mdp.txt | 95 -- 2 files changed

Re: [PATCH v1 01/14] media: dt-bindings: Convert MediaTek mt8173-mdp bindings to YAML

2025-09-11 Thread Ariel D'Alessandro
Krzysztof, On 9/9/25 3:32 AM, Krzysztof Kozlowski wrote: On 08/09/2025 19:52, Ariel D'Alessandro wrote: Krzysztof, On 8/21/25 3:46 AM, Krzysztof Kozlowski wrote: On Wed, Aug 20, 2025 at 02:12:49PM -0300, Ariel D'Alessandro wrote: [...] + - enum: + - media

[PATCH v2 11/12] dt-bindings: soc: mediatek: pwrap: Add power-domains property

2025-09-11 Thread Ariel D'Alessandro
Currently, the DT bindings for Mediatek PMIC Wrapper is missing the power-domains property, which is used in the MT8173 E1 evaluation board as it needs USB power domain. Signed-off-by: Ariel D'Alessandro Acked-by: Rob Herring (Arm) --- .../bindings/soc/mediatek/mediatek,pwrap.yaml

[PATCH v2 09/12] dt-bindings: regulator: Convert Dialog DA9211 Regulators to DT schema

2025-09-11 Thread Ariel D'Alessandro
Convert the existing text-based DT bindings for Dialog Semiconductor DA9211 Voltage Regulators family to a DT schema. Examples are simplified, as these are all equal. Signed-off-by: Ariel D'Alessandro --- .../devicetree/bindings/regulator/da9211.txt | 205 -- .../bin

[PATCH v2 06/12] dt-bindings: display: mediatek, ufoe: Add mediatek, gce-client-reg property

2025-09-11 Thread Ariel D'Alessandro
he regexes: '^pinctrl-[0-9]+$' ``` This commit adds the missing node property in the DT schema and updates the example as well. Signed-off-by: Ariel D'Alessandro --- .../bindings/display/mediatek/mediatek,ufoe.yaml | 15 +++ 1 file changed, 15 insertions(+) di

[PATCH v2 07/12] arm64: dts: mediatek: mt8173: Fix mt8173-pinctrl node names

2025-09-11 Thread Ariel D'Alessandro
According to the mediatek,mt8173-pinctrl device tree binding schema, the pinctrl node names should match pattern 'pins$'. Fix this. Signed-off-by: Ariel D'Alessandro Reviewed-by: Linus Walleij Acked-by: Rob Herring (Arm) --- .../boot/dts/mediatek/mt8173-elm-hana.dtsi| 2

[PATCH v2 05/12] dt-bindings: display: mediatek, od: Add mediatek, gce-client-reg property

2025-09-11 Thread Ariel D'Alessandro
7;^pinctrl-[0-9]+$' ``` This commit adds the missing node property in the DT schema and updates the example as well. Signed-off-by: Ariel D'Alessandro --- .../bindings/display/mediatek/mediatek,od.yaml | 14 ++ 1 file changed, 14 insertions(+) diff --git a/Documentation/de

[PATCH v2 02/12] dt-bindings: media: Convert MediaTek mt8173-vpu bindings to DT schema

2025-09-11 Thread Ariel D'Alessandro
Convert the existing text-based DT bindings for Mediatek MT8173 Video Processor Unit to a DT schema. Signed-off-by: Ariel D'Alessandro --- .../bindings/media/mediatek,mt8173-vpu.yaml | 74 +++ .../bindings/media/mediatek-vpu.txt | 31 2 files change

Re: [PATCH v1 00/14] MediaTek dt-bindings sanitization (MT8173)

2025-09-11 Thread Ariel D'Alessandro
Mark, On 8/20/25 2:19 PM, Mark Brown wrote: On Wed, Aug 20, 2025 at 02:12:48PM -0300, Ariel D'Alessandro wrote: This patch series continues the effort to address Device Tree validation warnings for MediaTek platforms, with a focus on MT8173. It follows the initial cleanup series by A

Re: [PATCH v1 13/14] dt-bindings: input/touchscreen: Convert MELFAS MIP4 Touchscreen to YAML

2025-09-10 Thread Ariel D'Alessandro
Ariel D'Alessandro wrote: + ce-gpios: +description: GPIO connected to the CE (chip enable) pin of the chip +maxItems: 1 Mention that this should always have the flag GPIO_ACTIVE_HIGH as this is required by the hardware. Unfortunately we have no YAML syntax for enforcing

Re: [PATCH v1 13/14] dt-bindings: input/touchscreen: Convert MELFAS MIP4 Touchscreen to YAML

2025-09-10 Thread Ariel D'Alessandro
Rob, On 8/22/25 12:52 PM, Rob Herring wrote: On Wed, Aug 20, 2025 at 02:13:01PM -0300, Ariel D'Alessandro wrote: Convert the existing text-based DT bindings for MELFAS MIP4 Touchscreen controller to a YAML schema. Signed-off-by: Ariel D'Alessandro --- .../input/touchscr

Re: [PATCH v1 07/14] dt-bindings: display: mediatek,ufoe: Add mediatek,gce-client-reg property

2025-09-10 Thread Ariel D'Alessandro
Krzysztof, On 9/10/25 11:21 AM, Krzysztof Kozlowski wrote: On 10/09/2025 16:04, Ariel D'Alessandro wrote: Krzysztof, On 8/21/25 3:50 AM, Krzysztof Kozlowski wrote: On Wed, Aug 20, 2025 at 02:12:55PM -0300, Ariel D'Alessandro wrote: Current, the DT bindings for Mediatek UFOe (Uni

Re: [PATCH v1 14/14] dt-bindings: media: mediatek,jpeg: Fix jpeg encoder/decoder ranges

2025-09-10 Thread Ariel D'Alessandro
Rob, On 8/20/25 3:55 PM, Rob Herring wrote: On Wed, Aug 20, 2025 at 02:13:02PM -0300, Ariel D'Alessandro wrote: Commit 14176e94bb35d ("arm64: dts: mediatek: mt8195: Fix ranges for jpeg That commit is not in any upstream tree. Ugh, indeed. Dropping this patch. enc/dec

Re: [PATCH v1 10/14] regulator: dt-bindings: Convert Dialog Semiconductor DA9211 Regulators to YAML

2025-09-10 Thread Ariel D'Alessandro
Krzysztof, On 8/21/25 3:53 AM, Krzysztof Kozlowski wrote: On Wed, Aug 20, 2025 at 02:12:58PM -0300, Ariel D'Alessandro wrote: Convert the existing text-based DT bindings for Dialog Semiconductor DA9211 Voltage Regulators family to a YAML schema. Examples are simplified, as these are all

Re: [PATCH v1 05/14] sound: dt-bindings: Convert MediaTek RT5650 codecs bindings to YAML

2025-09-08 Thread Ariel D'Alessandro
Rob, On 8/22/25 12:14 PM, Rob Herring wrote: On Wed, Aug 20, 2025 at 02:12:53PM -0300, Ariel D'Alessandro wrote: Convert the existing text-based DT bindings for Mediatek MT8173 RT5650 codecs to a YAML schema. Signed-off-by: Ariel D'Alessandro --- .../sound/mediatek,mt8173-r

[PATCH v1 11/14] arm64: dts: mediatek: mt8173-elm: Drop unused bank supply

2025-08-20 Thread Ariel D'Alessandro
The mediatek,mt8173-thermal device tree binding schema doesn't allow regulator supplies like the ones defined in mt8173-elm.dtsi. Drop these as the associated driver doesn't implement them either. Signed-off-by: Ariel D'Alessandro --- arch/arm64/boot/dts/mediatek/mt8173-elm.dt

[PATCH v1 06/14] dt-bindings: display: mediatek, od: Add mediatek, gce-client-reg property

2025-08-20 Thread Ariel D'Alessandro
Current, the DT bindings for Mediatek OD (display overdrive) is missing the mediatek,gce-client-reg property. Add it and update the example as well. Signed-off-by: Ariel D'Alessandro --- .../bindings/display/mediatek/mediatek,od.yaml | 10 ++ 1 file changed, 10 inser

[PATCH v1 02/14] media: dt-bindings: Convert MediaTek mt8173-vpu bindings to YAML

2025-08-20 Thread Ariel D'Alessandro
Convert the existing text-based DT bindings for Mediatek MT8173 Video Processor Unit to a YAML schema. Signed-off-by: Ariel D'Alessandro --- .../bindings/media/mediatek,mt8173-vpu.yaml | 76 +++ .../bindings/media/mediatek-vpu.txt | 31 2 files change

[PATCH v1 12/14] dt-bindings: soc: mediatek: pwrap: Add power-domains property

2025-08-20 Thread Ariel D'Alessandro
Currently, the DT bindings for Mediatek PMIC Wrapper is missing the power-domains property, which is used in the MT8173 E1 evaluation board as it needs USB power domain. Signed-off-by: Ariel D'Alessandro --- .../bindings/soc/mediatek/mediatek,pwrap.yaml | 15 +++ 1 file ch

[PATCH v1 14/14] dt-bindings: media: mediatek, jpeg: Fix jpeg encoder/decoder ranges

2025-08-20 Thread Ariel D'Alessandro
Commit 14176e94bb35d ("arm64: dts: mediatek: mt8195: Fix ranges for jpeg enc/decoder nodes") redefined jpeg encoder/decoder children node ranges. Update the related device tree binding yaml definition to match mediatek/mt8195.dtsi, as this is currently the only one using it. Signed-off

[PATCH v1 13/14] dt-bindings: input/touchscreen: Convert MELFAS MIP4 Touchscreen to YAML

2025-08-20 Thread Ariel D'Alessandro
Convert the existing text-based DT bindings for MELFAS MIP4 Touchscreen controller to a YAML schema. Signed-off-by: Ariel D'Alessandro --- .../input/touchscreen/melfas,mip4_ts.yaml | 55 +++ .../input/touchscreen/melfas_mip4.txt | 20 --- 2 files change

[PATCH v1 09/14] dt-bindings: pinctrl: mediatek, mt65xx-pinctrl: Allow gpio-line-names

2025-08-20 Thread Ariel D'Alessandro
Current, the DT bindings for MediaTek's MT65xx Pin controller is missing the gpio-line-names property, add it to the associated schema. Signed-off-by: Ariel D'Alessandro --- .../devicetree/bindings/pinctrl/mediatek,mt65xx-pinctrl.yaml| 2 ++ 1 file changed, 2 insertions(+) dif

[PATCH v1 10/14] regulator: dt-bindings: Convert Dialog Semiconductor DA9211 Regulators to YAML

2025-08-20 Thread Ariel D'Alessandro
Convert the existing text-based DT bindings for Dialog Semiconductor DA9211 Voltage Regulators family to a YAML schema. Examples are simplified, as these are all equal. Signed-off-by: Ariel D'Alessandro --- .../devicetree/bindings/regulator/da9211.txt | 205 -- .../bin

[PATCH v1 08/14] arm64: dts: mediatek: mt8173: Fix mt8173-pinctrl node names

2025-08-20 Thread Ariel D'Alessandro
According to the mediatek,mt8173-pinctrl device tree binding schema, the pinctrl node names should match pattern 'pins$'. Fix this. Signed-off-by: Ariel D'Alessandro --- .../boot/dts/mediatek/mt8173-elm-hana.dtsi| 2 +- arch/arm64/boot/dts/mediatek/mt8173

[PATCH v1 07/14] dt-bindings: display: mediatek, ufoe: Add mediatek, gce-client-reg property

2025-08-20 Thread Ariel D'Alessandro
Current, the DT bindings for Mediatek UFOe (Unified Frame Optimization engine) is missing the mediatek,gce-client-reg property. Add it and update the example as well. Signed-off-by: Ariel D'Alessandro --- .../bindings/display/mediatek/mediatek,ufoe.yaml | 11 +++ 1 file change

[PATCH v1 05/14] sound: dt-bindings: Convert MediaTek RT5650 codecs bindings to YAML

2025-08-20 Thread Ariel D'Alessandro
Convert the existing text-based DT bindings for Mediatek MT8173 RT5650 codecs to a YAML schema. Signed-off-by: Ariel D'Alessandro --- .../sound/mediatek,mt8173-rt5650.yaml | 73 +++ .../bindings/sound/mt8173-rt5650.txt | 31 2 files change

[PATCH v1 04/14] net: dt-bindings: Convert Marvell 8897/8997 bindings to YAML

2025-08-20 Thread Ariel D'Alessandro
devicetree/bindings/net/btusb.txt Signed-off-by: Ariel D'Alessandro --- .../bindings/net/marvell,sd8897-bt.yaml | 91 +++ .../bindings/net/marvell-bt-8xxx.txt | 83 - 2 files changed, 91 insertions(+), 83 deletions(-) create mode 100644 Documenta

[PATCH v1 03/14] dt-bindings: arm: mediatek: mmsys: Add assigned-clocks/rates properties

2025-08-20 Thread Ariel D'Alessandro
Current, the DT bindings for MediaTek mmsys controller is missing the assigned-clocks and assigned-clocks-rates properties. Add these and update the example as well. Signed-off-by: Ariel D'Alessandro --- .../devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml | 9 + 1 file chang

[PATCH v1 01/14] media: dt-bindings: Convert MediaTek mt8173-mdp bindings to YAML

2025-08-20 Thread Ariel D'Alessandro
Convert the existing text-based DT bindings for MediaTek MT8173 Media Data Path to a YAML schema. Signed-off-by: Ariel D'Alessandro --- .../bindings/media/mediatek,mt8173-mdp.yaml | 174 ++ .../bindings/media/mediatek-mdp.txt | 95 -- 2 files changed

[PATCH v1 00/14] MediaTek dt-bindings sanitization (MT8173)

2025-08-20 Thread Ariel D'Alessandro
patchset eliminates several of the remaining warnings by improving or converting DT bindings to YAML, adding missing properties, and updating device tree files accordingly. Signed-off-by: Ariel D'Alessandro Ariel D'Alessandro (14): media: dt-bindings: Convert MediaTek mt8173-mdp b

[PATCH v5 4/6] drm/panfrost: Add support for AARCH64_4K page table format

2025-04-05 Thread Ariel D'Alessandro
page table format. To achieve that, a "GPU optional quirks" field was added to `struct panfrost_features` with the related flag. Note that, in order to enable AARCH64_4K mode, the GPU variant must have the HW_FEATURE_AARCH64_MMU feature flag present. Signed-off-by: Ariel D'A

Re: [PATCH v5 4/6] drm/panfrost: Add support for AARCH64_4K page table format

2025-04-04 Thread Ariel D'Alessandro
Hi Steven, On 3/31/25 8:15 AM, Steven Price wrote: On 24/03/2025 18:57, Ariel D'Alessandro wrote: Currently, Panfrost only supports MMU configuration in "LEGACY" (as Bifrost calls it) mode, a (modified) version of LPAE "Large Physical Address Extension", which in Linu

[PATCH v5 6/6] drm/panfrost: Force AARCH64_4K page table format on MediaTek MT8192

2025-03-25 Thread Ariel D'Alessandro
this commit. Tested on a Mediatek (MT8395) Genio 1200 EVK board. [0] https://github.com/glmark2/glmark2 Signed-off-by: Ariel D'Alessandro Reviewed-by: Boris Brezillon Reviewed-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/panfrost/panfrost_drv.c | 1 + 1 file changed, 1 insertion(+)

[PATCH v5 3/6] drm/panfrost: Set HW_FEATURE_AARCH64_MMU feature flag on Bifrost models

2025-03-24 Thread Ariel D'Alessandro
Set this feature flag on all Mali Bifrost platforms as the MMU supports AARCH64 4K page table format. Signed-off-by: Ariel D'Alessandro Reviewed-by: Boris Brezillon Reviewed-by: Steven Price Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Adrián Larumbe --- drivers/gpu/drm/pan

[PATCH v5 1/6] drm/panfrost: Set IOMMU_CACHE flag

2025-03-24 Thread Ariel D'Alessandro
Panfrost does not support uncached mappings, so flag them properly. Also flag the pages that are mapped as response to a page fault as cached. Signed-off-by: Boris Brezillon Signed-off-by: Ariel D'Alessandro Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Steven Price Review

[PATCH v5 5/6] drm/panfrost: Force AARCH64_4K page table format on MediaTek MT8188

2025-03-24 Thread Ariel D'Alessandro
fined caching policy" is good enough... ``` Now that Panfrost supports AARCH64_4K page table format, let's enable it on Mediatek MT8188 and configure the cache/shareability policies properly. Signed-off-by: Ariel D'Alessandro Reviewed-by: AngeloGioacchino Del Regno Reviewed

[PATCH v5 2/6] drm/panfrost: Use GPU_MMU_FEATURES_VA_BITS/PA_BITS macros

2025-03-24 Thread Ariel D'Alessandro
As done in panthor, define and use these GPU_MMU_FEATURES_* macros, which makes code easier to read and reuse. Signed-off-by: Ariel D'Alessandro Reviewed-by: Boris Brezillon Reviewed-by: Steven Price Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Adrián Larumbe --- drivers/gp

[PATCH v5 0/6] drm/panfrost: Add support for AARCH64_4K page table format

2025-03-24 Thread Ariel D'Alessandro
ot; patch. * Replaced `panfrost_mmu->enable()` function pointer by `cfg` struct prepared during init time. * Made mali_lpae/aarch64_4k name more clear. * Added GPU_CONFIG_AARCH64_4K flag to enable AARCH64_4K page table format. * Enabled AARCH64_4K mode only on mediatek-mt8188. Ariel D'Ales

Re: [PATCH v4 4/6] drm/panfrost: Add support for AARCH64_4K page table format

2025-03-24 Thread Ariel D'Alessandro
Adrian, On 3/22/25 3:48 PM, Adrian Larumbe wrote: On 17.03.2025 11:52, Ariel D'Alessandro wrote: Currently, Panfrost only supports MMU configuration in "LEGACY" (as Bifrost calls it) mode, a (modified) version of LPAE "Large Physical Address Extension", which in Linu

[PATCH v4 0/6] drm/panfrost: Add support for AARCH64_4K page table format

2025-03-17 Thread Ariel D'Alessandro
pointer by `cfg` struct prepared during init time. * Made mali_lpae/aarch64_4k name more clear. * Added GPU_CONFIG_AARCH64_4K flag to enable AARCH64_4K page table format. * Enabled AARCH64_4K mode only on mediatek-mt8188. Ariel D'Alessandro (6): drm/panfrost: Set IOMMU_CACHE flag drm/panfrost:

[PATCH v4 5/6] drm/panfrost: Force AARCH64_4K page table format on MediaTek MT8188

2025-03-17 Thread Ariel D'Alessandro
fined caching policy" is good enough... ``` Now that Panfrost supports AARCH64_4K page table format, let's enable it on Mediatek MT8188 and configure the cache/shareability policies properly. Signed-off-by: Ariel D'Alessandro Reviewed-by: AngeloGioacchino Del Regno Reviewed

[PATCH v4 6/6] drm/panfrost: Force AARCH64_4K page table format on MediaTek MT8192

2025-03-17 Thread Ariel D'Alessandro
this commit. Tested on a Mediatek (MT8395) Genio 1200 EVK board. [0] https://github.com/glmark2/glmark2 Signed-off-by: Ariel D'Alessandro Reviewed-by: Boris Brezillon Reviewed-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/panfrost/panfrost_drv.c | 1 + 1 file changed, 1 insertion(+)

[PATCH v4 4/6] drm/panfrost: Add support for AARCH64_4K page table format

2025-03-17 Thread Ariel D'Alessandro
page table format. To achieve that, a "GPU optional quirks" field was added to `struct panfrost_features` with the related flag. Note that, in order to enable AARCH64_4K mode, the GPU variant must have the HW_FEATURE_AARCH64_MMU feature flag present. Signed-off-by: Ariel D'A

[PATCH v4 1/6] drm/panfrost: Set IOMMU_CACHE flag

2025-03-17 Thread Ariel D'Alessandro
Panfrost does not support uncached mappings, so flag them properly. Also flag the pages that are mapped as response to a page fault as cached. Signed-off-by: Boris Brezillon Signed-off-by: Ariel D'Alessandro Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Steven Price --- driver

[PATCH v4 3/6] drm/panfrost: Set HW_FEATURE_AARCH64_MMU feature flag on Bifrost models

2025-03-17 Thread Ariel D'Alessandro
Set this feature flag on all Mali Bifrost platforms as the MMU supports AARCH64 4K page table format. Signed-off-by: Ariel D'Alessandro Reviewed-by: Boris Brezillon Reviewed-by: Steven Price Reviewed-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/panfrost/panfrost_features.h | 3 +

[PATCH v4 2/6] drm/panfrost: Use GPU_MMU_FEATURES_VA_BITS/PA_BITS macros

2025-03-17 Thread Ariel D'Alessandro
As done in panthor, define and use these GPU_MMU_FEATURES_* macros, which makes code easier to read and reuse. Signed-off-by: Ariel D'Alessandro Reviewed-by: Boris Brezillon Reviewed-by: Steven Price Reviewed-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/panfrost/panfrost_mmu.c

Re: [PATCH v3 4/6] drm/panfrost: Add support for AARCH64_4K page table format

2025-03-17 Thread Ariel D'Alessandro
Boris, On 3/17/25 10:44 AM, Boris Brezillon wrote: On Mon, 17 Mar 2025 09:40:42 -0300 Ariel D'Alessandro wrote: +static int panfrost_mmu_cfg_init(struct panfrost_mmu *mmu, + enum io_pgtable_fmt fmt) +{ + struct panfrost_device *pfdev = mmu-&

[PATCH v3 6/6] drm/panfrost: Force AARCH64_4K page table format on MediaTek MT8192

2025-03-17 Thread Ariel D'Alessandro
this commit. Tested on a Mediatek (MT8395) Genio 1200 EVK board. [0] https://github.com/glmark2/glmark2 Signed-off-by: Ariel D'Alessandro Reviewed-by: Boris Brezillon Reviewed-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/panfrost/panfrost_drv.c | 1 + 1 file changed, 1 insertion(+)

[PATCH v3 2/6] drm/panfrost: Use GPU_MMU_FEATURES_VA_BITS/PA_BITS macros

2025-03-17 Thread Ariel D'Alessandro
As done in panthor, define and use these GPU_MMU_FEATURES_* macros, which makes code easier to read and reuse. Signed-off-by: Ariel D'Alessandro Reviewed-by: Boris Brezillon Reviewed-by: Steven Price Reviewed-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/panfrost/panfrost_mmu.c

[PATCH v3 5/6] drm/panfrost: Force AARCH64_4K page table format on MediaTek MT8188

2025-03-17 Thread Ariel D'Alessandro
fined caching policy" is good enough... ``` Now that Panfrost supports AARCH64_4K page table format, let's enable it on Mediatek MT8188 and configure the cache/shareability policies properly. Signed-off-by: Ariel D'Alessandro Reviewed-by: AngeloGioacchino Del Regno Reviewed

[PATCH v3 4/6] drm/panfrost: Add support for AARCH64_4K page table format

2025-03-17 Thread Ariel D'Alessandro
page table format. To achieve that, a "GPU optional quirks" field was added to `struct panfrost_features` with the related flag. Note that, in order to enable AARCH64_4K mode, the GPU variant must have the HW_FEATURE_AARCH64_MMU feature flag present. Signed-off-by: Ariel D'A

[PATCH v3 1/6] drm/panfrost: Set IOMMU_CACHE flag

2025-03-17 Thread Ariel D'Alessandro
Panfrost does not support uncached mappings, so flag them properly. Also flag the pages that are mapped as response to a page fault as cached. Signed-off-by: Boris Brezillon Signed-off-by: Ariel D'Alessandro Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Steven Price --- driver

[PATCH v3 3/6] drm/panfrost: Set HW_FEATURE_AARCH64_MMU feature flag on Bifrost models

2025-03-17 Thread Ariel D'Alessandro
Set this feature flag on all Mali Bifrost platforms as the MMU supports AARCH64 4K page table format. Signed-off-by: Ariel D'Alessandro Reviewed-by: Boris Brezillon Reviewed-by: Steven Price Reviewed-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/panfrost/panfrost_features.h | 3 +

[PATCH v3 0/6] drm/panfrost: Add support for AARCH64_4K page table format

2025-03-17 Thread Ariel D'Alessandro
_4k name more clear. * Added GPU_CONFIG_AARCH64_4K flag to enable AARCH64_4K page table format. * Enabled AARCH64_4K mode only on mediatek-mt8188. Ariel D'Alessandro (6): drm/panfrost: Set IOMMU_CACHE flag drm/panfrost: Use GPU_MMU_FEATURES_VA_BITS/PA_BITS macros drm/panfrost: Set HW_FEATUR

Re: [PATCH v2 4/6] drm/panfrost: Add support for AARCH64_4K page table format

2025-03-17 Thread Ariel D'Alessandro
Boris, On 3/15/25 5:43 AM, Boris Brezillon wrote: On Fri, 14 Mar 2025 14:38:56 -0300 Ariel D'Alessandro wrote: Currently, Panfrost only supports MMU configuration in "LEGACY" (as Bifrost calls it) mode, a (modified) version of LPAE "Large Physical Address Extension&qu

[PATCH v2 0/6] drm/panfrost: Add support for AARCH64_4K page table format

2025-03-15 Thread Ariel D'Alessandro
_4K page table format. * Enabled AARCH64_4K mode only on mediatek-mt8188. Ariel D'Alessandro (6): drm/panfrost: Set IOMMU_CACHE flag drm/panfrost: Use GPU_MMU_FEATURES_VA_BITS/PA_BITS macros drm/panfrost: Set HW_FEATURE_AARCH64_MMU feature flag on Bifrost models drm/panfrost: Add

Re: [PATCH v1 5/6] drm/panfrost: Enable AARCH64_4K page table format on mediatek_mt8188

2025-03-15 Thread Ariel D'Alessandro
Angelo, On 3/11/25 6:09 AM, AngeloGioacchino Del Regno wrote: Il 10/03/25 20:59, Ariel D'Alessandro ha scritto: Now that Panfrost supports AARCH64_4K page table format, let's enable it on Mediatek MT8188. Signed-off-by: Ariel D'Alessandro ---   drivers/gpu/drm/panfrost/pan

[PATCH v2 3/6] drm/panfrost: Set HW_FEATURE_AARCH64_MMU feature flag on Bifrost models

2025-03-15 Thread Ariel D'Alessandro
Set this feature flag on all Mali Bifrost platforms as the MMU supports AARCH64 4K page table format. Signed-off-by: Ariel D'Alessandro Reviewed-by: Boris Brezillon Reviewed-by: Steven Price --- drivers/gpu/drm/panfrost/panfrost_features.h | 3 +++ 1 file changed, 3 insertions(+) diff

Re: [RFC PATCH 3/4] drm/panfrost: Support ARM_64_LPAE_S1 page table

2025-03-15 Thread Ariel D'Alessandro
Hi Steven, On 2/27/25 11:44 AM, Steven Price wrote: On 26/02/2025 18:30, Ariel D'Alessandro wrote: Bifrost MMUs support AArch64 4kB granule specification. However, panfrost only enables MMU in legacy mode, despite the presence of the HW_FEATURE_AARCH64_MMU feature flag. This commit

[PATCH v2 1/6] drm/panfrost: Set IOMMU_CACHE flag

2025-03-14 Thread Ariel D'Alessandro
Panfrost does not support uncached mappings, so flag them properly. Also flag the pages that are mapped as response to a page fault as cached. Signed-off-by: Boris Brezillon Signed-off-by: Ariel D'Alessandro Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Steven Price --- driver

[PATCH v2 6/6] drm/panfrost: Force AARCH64_4K page table format on MediaTek MT8192

2025-03-14 Thread Ariel D'Alessandro
this commit. Tested on a Mediatek (MT8395) Genio 1200 EVK board. [0] https://github.com/glmark2/glmark2 Signed-off-by: Ariel D'Alessandro --- drivers/gpu/drm/panfrost/panfrost_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c b/drivers/gpu/dr

[PATCH v2 2/6] drm/panfrost: Use GPU_MMU_FEATURES_VA_BITS/PA_BITS macros

2025-03-14 Thread Ariel D'Alessandro
As done in panthor, define and use these GPU_MMU_FEATURES_* macros, which makes code easier to read and reuse. Signed-off-by: Ariel D'Alessandro Reviewed-by: Boris Brezillon Reviewed-by: Steven Price --- drivers/gpu/drm/panfrost/panfrost_mmu.c | 6 -- drivers/gpu/drm/pan

[PATCH v2 5/6] drm/panfrost: Force AARCH64_4K page table format on MediaTek MT8188

2025-03-14 Thread Ariel D'Alessandro
fined caching policy" is good enough... ``` Now that Panfrost supports AARCH64_4K page table format, let's enable it on Mediatek MT8188 and configure the cache/shareability policies properly. Signed-off-by: Ariel D'Alessandro Reviewed-by: AngeloGioacchino Del Regno --- driv

[PATCH v2 4/6] drm/panfrost: Add support for AARCH64_4K page table format

2025-03-14 Thread Ariel D'Alessandro
page table format. To achieve that, a "GPU optional quirks" field was added to `struct panfrost_features` with the related flag. Note that, in order to enable AARCH64_4K mode, the GPU variant must have the HW_FEATURE_AARCH64_MMU feature flag present. Signed-off-by: Ariel D'Alessandr

Re: [PATCH v1 5/6] drm/panfrost: Enable AARCH64_4K page table format on mediatek_mt8188

2025-03-13 Thread Ariel D'Alessandro
Boris, On 3/11/25 5:06 AM, Boris Brezillon wrote: On Mon, 10 Mar 2025 16:59:20 -0300 Ariel D'Alessandro wrote: Now that Panfrost supports AARCH64_4K page table format, let's enable it on Mediatek MT8188. Can you maybe give more details on why this is needed (legacy sh

Re: [PATCH v1 4/6] drm/panfrost: Add support for AARCH64_4K page table format

2025-03-12 Thread Ariel D'Alessandro
Boris, Angelo, On 3/11/25 7:05 AM, Boris Brezillon wrote: On Tue, 11 Mar 2025 10:14:44 +0100 AngeloGioacchino Del Regno wrote: Il 11/03/25 09:05, Boris Brezillon ha scritto: On Mon, 10 Mar 2025 16:59:19 -0300 Ariel D'Alessandro wrote: Currently, Panfrost only support

Re: [PATCH v1 4/6] drm/panfrost: Add support for AARCH64_4K page table format

2025-03-12 Thread Ariel D'Alessandro
Boris, On 3/11/25 5:05 AM, Boris Brezillon wrote: On Mon, 10 Mar 2025 16:59:19 -0300 Ariel D'Alessandro wrote: Currently, Panfrost only supports MMU configuration in "LEGACY" (as Bifrost calls it) mode, a (modified) version of LPAE "Large Physical Address Extension&qu

Re: [PATCH v1 4/6] drm/panfrost: Add support for AARCH64_4K page table format

2025-03-12 Thread Ariel D'Alessandro
Angelo, On 3/11/25 6:10 AM, AngeloGioacchino Del Regno wrote: Il 10/03/25 20:59, Ariel D'Alessandro ha scritto: Currently, Panfrost only supports MMU configuration in "LEGACY" (as Bifrost calls it) mode, a (modified) version of LPAE "Large Physical Address Extension&qu

Re: [PATCH v1 3/6] drm/panfrost: Unify panfrost_mmu_enable/disable common code

2025-03-12 Thread Ariel D'Alessandro
Boris, On 3/11/25 4:51 AM, Boris Brezillon wrote: On Mon, 10 Mar 2025 16:59:18 -0300 Ariel D'Alessandro wrote: Both these functions write to MMU_AS_CONTROL register in the same way. Define a common _panfrost_mmu_as_control_write function with the shared code. Signed-off-by:

[PATCH v1 1/6] drm/panfrost: Set IOMMU_CACHE flag

2025-03-11 Thread Ariel D'Alessandro
Panfrost does not support uncached mappings, so flag them properly. Also flag the pages that are mapped as response to a page fault as cached. Signed-off-by: Boris Brezillon Signed-off-by: Ariel D'Alessandro --- drivers/gpu/drm/panfrost/panfrost_mmu.c | 4 ++-- 1 file changed, 2 inser

[PATCH v1 0/6] drm/panfrost: Add support for AARCH64_4K page table format

2025-03-11 Thread Ariel D'Alessandro
e/aarch64_4k name more clear. * Added GPU_CONFIG_AARCH64_4K flag to enable AARCH64_4K page table format. * Enabled AARCH64_4K mode only on mediatek-mt8188. Ariel D'Alessandro (6): drm/panfrost: Set IOMMU_CACHE flag drm/panfrost: Use GPU_MMU_FEATURES_VA_BITS/PA_BITS macros drm/panfrost: Unify p

[PATCH v1 6/6] drm/panfrost: Set HW_FEATURE_AARCH64_MMU feature flag on Bifrost models

2025-03-11 Thread Ariel D'Alessandro
Set this feature flag on all Mali Bifrost platforms as the MMU supports AARCH64 4K page table format. Signed-off-by: Ariel D'Alessandro --- drivers/gpu/drm/panfrost/panfrost_features.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/panfrost/panfrost_features.h b/dr

[PATCH v1 4/6] drm/panfrost: Add support for AARCH64_4K page table format

2025-03-11 Thread Ariel D'Alessandro
page table format. To achieve that, a "GPU optional configurations" field was added to `struct panfrost_features` with the related flag. Note that, in order to enable AARCH64_4K mode, the GPU variant must have the HW_FEATURE_AARCH64_MMU feature flag present. Signed-off-by: Arie

[PATCH v1 2/6] drm/panfrost: Use GPU_MMU_FEATURES_VA_BITS/PA_BITS macros

2025-03-10 Thread Ariel D'Alessandro
As done in panthor, define and use these GPU_MMU_FEATURES_* macros, which makes code easier to read and reuse. Signed-off-by: Ariel D'Alessandro Reviewed-by: Boris Brezillon Reviewed-by: Steven Price --- drivers/gpu/drm/panfrost/panfrost_mmu.c | 6 -- drivers/gpu/drm/pan

Re: [RFC PATCH 3/4] drm/panfrost: Support ARM_64_LPAE_S1 page table

2025-03-10 Thread Ariel D'Alessandro
Hi Boris, On 2/27/25 11:55 AM, Boris Brezillon wrote: On Wed, 26 Feb 2025 15:30:42 -0300 Ariel D'Alessandro wrote: @@ -642,8 +713,15 @@ struct panfrost_mmu *panfrost_mmu_ctx_create(struct panfrost_device *pfdev) .iommu_dev = pfdev->dev, }; - mmu-&g

[PATCH v1 5/6] drm/panfrost: Enable AARCH64_4K page table format on mediatek_mt8188

2025-03-10 Thread Ariel D'Alessandro
Now that Panfrost supports AARCH64_4K page table format, let's enable it on Mediatek MT8188. Signed-off-by: Ariel D'Alessandro --- drivers/gpu/drm/panfrost/panfrost_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c b/drivers/gpu/dr

[PATCH v1 3/6] drm/panfrost: Unify panfrost_mmu_enable/disable common code

2025-03-10 Thread Ariel D'Alessandro
Both these functions write to MMU_AS_CONTROL register in the same way. Define a common _panfrost_mmu_as_control_write function with the shared code. Signed-off-by: Ariel D'Alessandro --- drivers/gpu/drm/panfrost/panfrost_mmu.c | 33 - 1 file changed, 16 insertions(+

Re: [RFC PATCH 3/4] drm/panfrost: Support ARM_64_LPAE_S1 page table

2025-03-07 Thread Ariel D'Alessandro
Boris, On 2/27/25 5:30 AM, Boris Brezillon wrote: On Wed, 26 Feb 2025 15:30:42 -0300 Ariel D'Alessandro wrote: Bifrost MMUs support AArch64 4kB granule specification. However, panfrost only enables MMU in legacy mode, despite the presence of the HW_FEATURE_AARCH64_MMU feature flag.

Re: [RFC PATCH 2/4] drm/panfrost: Split LPAE MMU TRANSTAB register values

2025-03-07 Thread Ariel D'Alessandro
Boris, On 2/27/25 5:25 AM, Boris Brezillon wrote: On Wed, 26 Feb 2025 15:30:41 -0300 Ariel D'Alessandro wrote: [snip] diff --git a/drivers/gpu/drm/panfrost/panfrost_regs.h b/drivers/gpu/drm/panfrost/panfrost_regs.h index b5f279a19a08..4e6064d5feaa 100644 --- a/drivers/gpu/drm/pan

[RFC PATCH 3/4] drm/panfrost: Support ARM_64_LPAE_S1 page table

2025-02-26 Thread Ariel D'Alessandro
conditionally based on the GPU model's HW_FEATURE_AARCH64_MMU feature flag. Signed-off-by: Ariel D'Alessandro --- drivers/gpu/drm/panfrost/panfrost_device.h | 1 + drivers/gpu/drm/panfrost/panfrost_mmu.c| 118 + drivers/gpu/drm/panfrost/panfrost_regs.h | 29

[RFC PATCH 4/4] drm/panfrost: Set HW_FEATURE_AARCH64_MMU feature flag on Bifrost models

2025-02-26 Thread Ariel D'Alessandro
Mali Bifrost MMU support AArch64 4kB page tables. This feature is in panfrost based the HW_FEATURE_AARCH64_MMU feature flag. Signed-off-by: Ariel D'Alessandro --- drivers/gpu/drm/panfrost/panfrost_features.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/pan

[RFC PATCH 2/4] drm/panfrost: Split LPAE MMU TRANSTAB register values

2025-02-26 Thread Ariel D'Alessandro
The TRANSTAB (Translation table base address) layout is different depending on the legacy mode configuration. Currently, the defined values apply to the legacy mode. Let's rename them so we can add the ones for no-legacy mode. Signed-off-by: Ariel D'Alessandro --- drivers/gpu/dr

[RFC PATCH 0/4] drm/panfrost: Support ARM_64_LPAE_S1 page table

2025-02-26 Thread Ariel D'Alessandro
[0] https://lists.freedesktop.org/archives/dri-devel/2019-May/217617.html Thanks! Ariel D'Alessandro (4): drm/panfrost: Use GPU_MMU_FEATURES_VA_BITS/PA_BITS macros drm/panfrost: Split LPAE MMU TRANSTAB register values drm/panfrost: Support ARM_64_LPAE_S1 page table drm/panfrost: Set HW_FEAT

[RFC PATCH 1/4] drm/panfrost: Use GPU_MMU_FEATURES_VA_BITS/PA_BITS macros

2025-02-26 Thread Ariel D'Alessandro
As done in panthor, define and use these GPU_MMU_FEATURES_* macros, which makes code easier to read and reuse. Signed-off-by: Ariel D'Alessandro --- drivers/gpu/drm/panfrost/panfrost_mmu.c | 6 -- drivers/gpu/drm/panfrost/panfrost_regs.h | 2 ++ 2 files changed, 6 insertions(