[PATCH] MAINTAINERS: drm: Remove myself as drm-bridge maintainer

2018-09-13 Thread Archit Taneja
p.org/drm/drm-misc DRM DRIVERS FOR BRIDGE CHIPS -M: Archit Taneja M: Andrzej Hajda R: Laurent Pinchart S: Maintained -- 2.18.0 ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/lis

Re: [PATCH v5 5/9] drm/bridge: tc358764: Add DSI to LVDS bridge driver

2018-07-26 Thread Archit Taneja
ot;); + return ret; + } + + drm_connector_helper_add(&ctx->connector, +&tc358764_connector_helper_funcs); + drm_mode_connector_attach_encoder(&ctx->connector, bridge->encoder); + drm_panel_attach(ctx->pan

Re: [PATCH v2] drm/msm/display: negative x/y in cursor move

2018-07-26 Thread Archit Taneja
Thanks, I'll give this a try. The patch looks good, anyway. Rob's queued it for msm-next. Archit Therefore, I asked the X11 people where to fix: https://www.spinics.net/lists/xorg/msg58969.html Best regards -Carsten 2018-07-24 19:33 GMT+02:00 Archit Taneja <mailto:arch...

Re: [PATCH v3 2/2] dt-bindings: mipi-dsi: Add dual-channel DSI related info

2018-07-25 Thread Archit Taneja
On Wednesday 11 July 2018 09:18 PM, Rob Herring wrote: On Mon, Jul 09, 2018 at 02:37:51PM +0530, Archit Taneja wrote: Add binding info for peripherals that support dual-channel DSI. Add corresponding optional bindings for DSI host controllers that may be configured in this mode. Add an

Re: [PATCH v3 1/2] dt-bindings: mipi-dsi: Add info about peripherals with non-DSI control bus

2018-07-25 Thread Archit Taneja
On Monday 09 July 2018 02:37 PM, Archit Taneja wrote: Add a section that describes dt-bindings for peripherals that support MIPI DSI, but have a different bus as the primary control bus, or no control bus at all. Add an example for a peripheral with a non-DSI control bus. Reviewed-by: Rob

Re: [PATCH v2] drm/msm/display: negative x/y in cursor move

2018-07-24 Thread Archit Taneja
Hi, On Tuesday 17 July 2018 04:33 AM, Carsten Behling wrote: modesetting X11 driver may provide negative x/y cordinates in mdp5_crtc_cursor_move call when rotation is enabled. Cursor buffer can overlap down to its negative width/height. ROI has to be recalculated for negative x/y indicating us

Re: [PATCH 11/21] drm/msm: higher values of pclk can exceed 32 bits when multiplied by a factor

2018-07-16 Thread Archit Taneja
On Monday 09 July 2018 11:01 PM, Sean Paul wrote: From: Abhinav Kumar Make the pclk_rate u64 to accommodate higher pixel clock rates. Changes in v4: - fixed commit message Signed-off-by: Abhinav Kumar Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/dsi/dsi_host.c | 9 ++--- 1 fi

Re: [Freedreno] [PATCH 09/21] drm/msm/mdp5: subclass msm_mdss for mdp5

2018-07-16 Thread Archit Taneja
mdss derivations to include any extensions. Add mdss helper interface (msm_mdss_funcs) to msm_mdss base for mdp5/dpu mdss specific implementation calls. This change subclasses msm_mdss for mdp5, dpu specific changes will be done separately. Reviewed-by: Archit Taneja Changes in v3

Re: [PATCH 07/21] drm/msm/dsi: initialize postdiv_lock before use for 10nm pll

2018-07-16 Thread Archit Taneja
On Monday 09 July 2018 11:01 PM, Sean Paul wrote: From: Rajesh Yadav postdiv_lock spinlock was used before initialization for 10nm pll. It causes following spin_bug: "BUG: spinlock bad magic on CPU#0". Initialize spinlock before its usage. Reviewed-by: Archit Taneja

Re: [PATCH 05/21] drm/msm/dsi: adjust dsi timing for dual dsi mode

2018-07-16 Thread Archit Taneja
On Monday 09 July 2018 11:01 PM, Sean Paul wrote: From: Chandan Uddaraju For dual dsi mode, the horizontal timing needs to be divided by half since both the dsi controllers will be driving this panel. Adjust the pixel clock and DSI timing accordingly. Reviewed-by: Archit Taneja Changes

[PATCH v3 1/2] dt-bindings: mipi-dsi: Add info about peripherals with non-DSI control bus

2018-07-09 Thread Archit Taneja
Cornu Reviewed-by: Sean Paul Signed-off-by: Archit Taneja --- .../devicetree/bindings/display/mipi-dsi-bus.txt | 71 +++--- 1 file changed, 64 insertions(+), 7 deletions(-) diff --git a/Documentation/devicetree/bindings/display/mipi-dsi-bus.txt b/Documentation/devicetree

[PATCH v3 0/2] dt-bindings: mipi-dsi: dual-channel DSI bindings

2018-07-09 Thread Archit Taneja
nges in v2: - Incorported Rob's comments. Archit Taneja (2): dt-bindings: mipi-dsi: Add info about peripherals with non-DSI control bus dt-bindings: mipi-dsi: Add dual-channel DSI related info .../devicetree/bindings/display/mipi-dsi-bus.txt | 153 +++-- 1 file

[PATCH v3 2/2] dt-bindings: mipi-dsi: Add dual-channel DSI related info

2018-07-09 Thread Archit Taneja
Reviewed-by: Heiko Stuebner Signed-off-by: Archit Taneja --- .../devicetree/bindings/display/mipi-dsi-bus.txt | 80 ++ 1 file changed, 80 insertions(+) diff --git a/Documentation/devicetree/bindings/display/mipi-dsi-bus.txt b/Documentation/devicetree/bindings/display/mipi-dsi

Re: [PATCH] drm/bridge: adv7511: Reset registers on hotplug

2018-07-04 Thread Archit Taneja
lly be false, and avoid us trying to configure the registers again, but I'm not entirely sure. if (status == connector_status_connected && hpd && adv7511->powered) { regcache_mark_dirty(adv7511->regmap); ... In any case: Reviewed-by: Archit Taneja Arguabl

Re: [DPU PATCH] drm/msm/dsi: add only dsi nodes with a valid device to list

2018-06-19 Thread Archit Taneja
current implementation even inactive nodes get added resulting in creation of redundant connectors. Reviewed-by: Archit Taneja Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/dsi/dsi.c | 6 +- drivers/gpu/drm/msm/dsi/dsi.h | 1 + drivers/gpu/drm/msm/dsi/dsi_host.c | 10

Re: [DPU PATCH] drm/msm/dsi: set encoder mode for DRM bridge explicitly

2018-06-19 Thread Archit Taneja
On Saturday 16 June 2018 11:26 AM, Abhinav Kumar wrote: Currently, DRM bridge for DPU relies on the default video mode setting to set the encoder mode. Add an explicit call to set the encoder mode for bridges. Reviewed-by: Archit Taneja Signed-off-by: Abhinav Kumar --- drivers/gpu

Re: [RFC v2 2/2] dt-bindings: mipi-dsi: Add dual-channel DSI related info

2018-06-06 Thread Archit Taneja
On Wednesday 06 June 2018 04:16 PM, Heiko Stübner wrote: Hi Archit, Am Mittwoch, 6. Juni 2018, 12:21:16 CEST schrieb Archit Taneja: On Wednesday 06 June 2018 02:00 PM, Heiko Stübner wrote: Am Mittwoch, 6. Juni 2018, 07:59:29 CEST schrieb Archit Taneja: On Monday 04 June 2018 05:47 PM

Re: [RFC v2 2/2] dt-bindings: mipi-dsi: Add dual-channel DSI related info

2018-06-06 Thread Archit Taneja
On Wednesday 06 June 2018 02:00 PM, Heiko Stübner wrote: Am Mittwoch, 6. Juni 2018, 07:59:29 CEST schrieb Archit Taneja: On Monday 04 June 2018 05:47 PM, Heiko Stuebner wrote: Am Donnerstag, 18. Januar 2018, 05:53:55 CEST schrieb Archit Taneja: Add binding info for peripherals that support

Re: [RFC v2 2/2] dt-bindings: mipi-dsi: Add dual-channel DSI related info

2018-06-05 Thread Archit Taneja
On Monday 04 June 2018 05:47 PM, Heiko Stuebner wrote: Am Donnerstag, 18. Januar 2018, 05:53:55 CEST schrieb Archit Taneja: Add binding info for peripherals that support dual-channel DSI. Add corresponding optional bindings for DSI host controllers that may be configured in this mode. Add an

Re: [PATCH v2 08/10] drm/bridge: tc358764: Add DSI to LVDS bridge driver

2018-05-30 Thread Archit Taneja
return ret; +} + +static int tc358764_probe(struct mipi_dsi_device *dsi) +{ + struct device *dev = &dsi->dev; + struct tc358764 *ctx; + int ret; + + ctx = devm_kzalloc(dev, sizeof(struct tc358764), GFP_KERNEL); + if (!ctx) + retur

Re: [PATCH] drm/bridge/synopsys: dw-hdmi: fix dw_hdmi_setup_rx_sense

2018-05-30 Thread Archit Taneja
since v4.17-rc1 : Reviewed-by: Archit Taneja Internal error: Oops: 9607 [#1] PREEMPT SMP [...] CPU: 0 PID: 124 Comm: irq/32-dw_hdmi_ Not tainted 4.17.0-rc7 #2 Hardware name: Libre Technology CC (DT) [...] pc : osq_lock+0x54/0x188 lr : __mutex_lock.isra.0+0x74/0x530 [...] Process irq/32

Re: [PATCH] drm/bridge: adv7511: fix spelling of driver name in Kconfig

2018-05-03 Thread Archit Taneja
On Friday 27 April 2018 03:11 AM, Laurent Pinchart wrote: Hi Peter, Thank you for the patch. On Friday, 27 April 2018 00:36:44 EEST Peter Rosin wrote: Could perhaps prevent some confusion. queued to drm-misc-next Thanks, Archit Signed-off-by: Peter Rosin Reviewed-by: Laurent Pinchar

Re: [PATCH] gpu: drm: bridge: adv7511: Replace mdelay with usleep_range in adv7511_probe

2018-05-03 Thread Archit Taneja
On Friday 27 April 2018 03:46 AM, Laurent Pinchart wrote: Hi Jia-Ju, Thank you for the patch. On Wednesday, 11 April 2018 11:33:42 EEST Jia-Ju Bai wrote: adv7511_probe() is never called in atomic context. This function is only set as ".probe" in struct i2c_driver. Despite never getting call

Re: [PATCH v4 2/5] dt-bindings: adv7511: Extend bindings to allow specifying slave map addresses

2018-04-25 Thread Archit Taneja
On Tuesday 13 February 2018 11:18 PM, Kieran Bingham wrote: From: Kieran Bingham The ADV7511 has four 256-byte maps that can be accessed via the main I2C ports. Each map has it own I2C address and acts as a standard slave device on the I2C bus. Extend the device tree node bindings to be able

Re: [PATCH v4 5/5] drm: adv7511: Add support for i2c_new_secondary_device

2018-04-25 Thread Archit Taneja
On Tuesday 13 February 2018 11:18 PM, Kieran Bingham wrote: From: Kieran Bingham The ADV7511 has four 256-byte maps that can be accessed via the main I2C ports. Each map has it own I2C address and acts as a standard slave device on the I2C bus. Allow a device tree node to override the defaul

Re: [PATCH v6 1/2] drm/bridge: Add Cadence DSI driver

2018-04-23 Thread Archit Taneja
On Saturday 21 April 2018 11:50 AM, Boris Brezillon wrote: Hi Archit, On Sun, 15 Apr 2018 13:39:44 +0530 Archit Taneja wrote: +static int cdns_dsi_get_dphy_pll_cfg(struct cdns_dphy *dphy, +struct cdns_dphy_cfg *cfg

Re: [DPU PATCH v2 1/2] drm/panel: Add Truly NT35597 panel

2018-04-19 Thread Archit Taneja
Hi, On Saturday 14 April 2018 12:55 PM, Abhinav Kumar wrote: From: Archit Taneja You can drop DPU from the subject. Also, you'd need to add Theirry Reading for panel related patches, and Rob Herring for an Ack on the DT bindings. I think you can change the author to yourself. You'

Re: [DPU PATCH v3 2/2] drm/msm/dsi: Use one connector for dual DSI mode

2018-04-19 Thread Archit Taneja
V2: -Removed Change-Id from the commit text tags. -Remove extra parentheses Changes in V3: -None Reviewed-by: Archit Taneja Signed-off-by: Chandan Uddaraju --- drivers/gpu/drm/msm/dsi/dsi.c | 3 + drivers/gpu/drm/msm/dsi/dsi.h | 1 + drivers/gpu/drm

Re: [DPU PATCH v3 1/2] drm/msm/dsi: adjust dsi timing for dual dsi mode

2018-04-19 Thread Archit Taneja
On Thursday 19 April 2018 01:15 AM, Chandan Uddaraju wrote: For dual dsi mode, the horizontal timing needs to be divided by half since both the dsi controllers will be driving this panel. Adjust the pixel clock and DSI timing accordingly. Reviewed-by: Archit Taneja Changes in V2

Re: [PATCH] drm: clarify adjusted_mode documentation for bridges

2018-04-19 Thread Archit Taneja
dges. Reviewed-by: Archit Taneja Signed-off-by: Philippe Cornu Signed-off-by: Laurent Pinchart --- This patch follows discussions in: - "drm: clarify adjusted_mode for a bridge connected to a crtc" https://patchwork.freedesktop.org/patch/206801/ - "drm: bridge: Constify mode

Re: GPU/DRM issue with DSI commands on msm 8916

2018-04-18 Thread Archit Taneja
On Wednesday 18 April 2018 01:58 PM, Daniel Mack wrote: On Wednesday, April 18, 2018 10:06 AM, Archit Taneja wrote: On Tuesday 17 April 2018 05:51 PM, Daniel Mack wrote: Thanks for debugging this so thoroughly. It shows an underlying problem in the msm driver's clock components t

Re: GPU/DRM issue with DSI commands on msm 8916

2018-04-18 Thread Archit Taneja
Hi Daniel, On Tuesday 17 April 2018 05:51 PM, Daniel Mack wrote: (cc Stephen) Hi Archit, On Monday, April 16, 2018 07:06 PM, Daniel Mack wrote: On Monday, April 09, 2018 03:08 PM, Archit Taneja wrote: You could comment out the pm_runtime_put_sync() calls in drivers/gpu/drm/msm/dsi

Re: [PATCH v6 1/2] drm/bridge: Add Cadence DSI driver

2018-04-15 Thread Archit Taneja
else if (dlane_bps >= 125000) + cfg->pll_opdiv = 1; + else if (dlane_bps >= 63000) + cfg->pll_opdiv = 2; + else if (dlane_bps >= 32000) + cfg->pll_opdiv = 4; + else if (dlane_bps >= 16000) + cfg->pll_opdiv = 8; + + /* +* Allow a deviation of 0.2% on the per-lane data rate to try to +* recover a potential mismatch between DPI and PPI clks. +*/ + dlane_bps_max = dlane_bps + (dlane_bps / 500); kbuild reported an error for 32 bit archs. I'm guessing it's because of this divide above? + + fbdiv_max = DIV_ROUND_DOWN_ULL((dlane_bps + (dlane_bps / 500)) * 2 * You could use dlane_bps_max here instead. Otherwise, Reviewed-by: Archit Taneja Thanks, Archit ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: GPU/DRM issue with DSI commands on msm 8916

2018-04-09 Thread Archit Taneja
On Monday 09 April 2018 04:28 PM, Daniel Mack wrote: Hi Archit, Thanks a lot for your reply. On Friday, April 06, 2018 01:25 PM, Archit Taneja wrote: On Thursday 05 April 2018 08:28 PM, Daniel Mack wrote: I'm having issues with the GPU/DRM drivers on a msm8916 based platform which is

Re: [DPU PATCH 1/2] drm/panel: Add Truly Dual DSI video mode panel

2018-04-08 Thread Archit Taneja
Hi Abhinav, Thanks for posting this driver. Some comments below. On Saturday 07 April 2018 12:36 PM, Abhinav Kumar wrote: From: Archit Taneja Add support for truly dual DSI video mode panel panel used in MSM reference platforms > Signed-off-by: Archit Taneja Signed-off-by: Abhinav Ku

Re: [DPU PATCH 2/2] drm/msm/dsi: implement auto PHY timing calculator for 10nm PHY

2018-04-08 Thread Archit Taneja
On Saturday 07 April 2018 01:20 PM, Abhinav Kumar wrote: Currently the DSI PHY timings are hard-coded for a specific panel for the 10nm PHY. Replace this with the auto PHY timing calculator which can calculate the PHY timings for any panel. Reviewed-by: Archit Taneja Signed-off-by

Re: GPU/DRM issue with DSI commands on msm 8916

2018-04-06 Thread Archit Taneja
Hi, On Thursday 05 April 2018 08:28 PM, Daniel Mack wrote: Hi, I'm having issues with the GPU/DRM drivers on a msm8916 based platform which is very similar to the DragonBoard 410c. In my setup, a DSI display is directly connected to the SoC, and the video link is stable. However, when the host

Re: [PATCH v2 4/6] drm/msm: Issue queued events when disabling crtc

2018-04-01 Thread Archit Taneja
On Thursday 29 March 2018 12:36 AM, Sean Paul wrote: Ensure that any queued events are issued when disabling the crtc. This avoids timeouts when we come back and wait for dependencies (like the previous frame's flip_done). Reviewed-by: Archit Taneja Changes in v2: - None Signed-o

Re: [PATCH v2 3/6] drm/msm: Mark the crtc->state->event consumed

2018-04-01 Thread Archit Taneja
On Thursday 29 March 2018 12:36 AM, Sean Paul wrote: Don't leave the event != NULL once it's consumed, this is used a signal s/used a/used as a ? to the atomic helpers that the event will be handled by the driver. Reviewed-by: Archit Taneja Changes in v2: - None Cc: Jeykuma

Re: [PATCH v2 2/6] drm/msm: Refactor complete_commit() to look more the helpers

2018-04-01 Thread Archit Taneja
On Thursday 29 March 2018 12:36 AM, Sean Paul wrote: Factor out the commit_tail() portions of complete_commit() into a separate function to facilitate moving to the atomic helpers in future patches. Reviewed-by: Archit Taneja Changes in v2: - None Cc: Jeykumar Sankaran Signed-off-by

Re: [PATCH v2 1/6] drm/msm: Use drm_private_obj/state instead of subclassing

2018-04-01 Thread Archit Taneja
- None Cc: Jeykumar Sankaran Cc: Archit Taneja Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 77 ++- drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.h | 11 +-- drivers/gpu/drm/msm/disp/mdp5/mdp5_mixer.c | 12 ++- drivers/gpu/drm/msm/disp/mdp5/mdp5_pipe

Re: [PATCH] drm/msm/dsi: use correct enum in dsi_get_cmd_fmt

2018-03-24 Thread Archit Taneja
Signed-off-by: Stefan Agner Reviewed-by: Archit Taneja Archit --- drivers/gpu/drm/msm/dsi/dsi_host.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c index 0f7324a686ca..d729b2b4b66d 1006

Re: [PATCH v2 0/3] Cleanup excessive DSI host controller version checks

2018-03-23 Thread Archit Taneja
replaced with the corresponding helper function. Reviewed-by: Archit Taneja V2: Removes command broadcast support for DSI 6G v2.0+ controllers from the patch series and incorporates all the suggested corrections Sibi S (3): drm/msm/dsi: add dsi host helper functions support

Re: [DPU PATCH v3] drm/msm: Use atomic private_obj instead of subclassing

2018-03-20 Thread Archit Taneja
Hi, On Tuesday 20 March 2018 01:28 AM, Sean Paul wrote: Instead of subclassing atomic state, store driver private data in private_obj/state. This allows us to remove the swap_state driver hook for mdp5 and get closer to using the atomic helpers entirely. Changes in v2: - Use state->state in d

Re: [PATCH 1/2] dt-bindings: analogix-dp: Add backlight-pwm-passthru

2018-03-16 Thread Archit Taneja
ler or the eDP panel. I don't have any strong opinion about it, though. Reviewed-by: Archit Taneja Thanks, Archit Signed-off-by: Alexandru M Stan --- Documentation/devicetree/bindings/display/bridge/analogix_dp.txt | 4 1 file changed, 4 insertions(+) diff --git a/Documenta

Re: [PATCH v5 21/36] drm/bridge: analogix_dp: Fix timeout of video streamclk config

2018-03-14 Thread Archit Taneja
streamclk is ok if we wait enough time, it does no effect on display. Let's change this error to warn. Reviewed-by: Archit Taneja Thanks, Archit Cc: Douglas Anderson Signed-off-by: zain wang Signed-off-by: Sean Paul Signed-off-by: Thierry Escande Reviewed-by: Andrzej Hajda Signe

Re: [PATCH v5 23/36] drm/bridge: analogix_dp: Move fast link training detect to set_bridge

2018-03-13 Thread Archit Taneja
On Saturday 10 March 2018 03:53 AM, Enric Balletbo i Serra wrote: From: zain wang It's too early to detect fast link training, if other step after it failed, we will set fast_link flag to 1, and retry set_bridge again. In this case we will power down and power up panel power supply, and we wi

Re: [PATCH v5 24/36] drm/bridge: analogix_dp: Reorder plat_data->power_off to happen sooner

2018-03-13 Thread Archit Taneja
was finding AUX channel errors and eventually reported "Failed to apply PSR", where I had a kgdb breakpoint. Presumably the device would have eventually given up and shut down anyway, but it seems better to fix the order to be more correct. Reviewed-by: Archit Taneja Thanks, Archit C

Re: [PATCH v5 25/36] drm/bridge: analogix_dp: Properly log AUX CH errors

2018-03-13 Thread Archit Taneja
bug. Reviewed-by: Archit Taneja Thanks, Archit Cc: 征增 王 Signed-off-by: Douglas Anderson Signed-off-by: Sean Paul Signed-off-by: Thierry Escande Reviewed-by: Andrzej Hajda Signed-off-by: Enric Balletbo i Serra Tested-by: Marek Szyprowski --- drivers/gpu/drm/bridge/analogix/analogi

Re: [PATCH v5 26/36] drm/bridge: analogix_dp: Properly disable aux chan retries on rockchip

2018-03-13 Thread Archit Taneja
could adjust the comment, but it seems more likely that we want the same retry behavior across all platforms. Reviewed-by: Archit Taneja Thanks, Archit Cc: Stéphane Marchesin Cc: 征增 王 Signed-off-by: Douglas Anderson Signed-off-by: Sean Paul Signed-off-by: Thierry Escande Signed-off-by:

Re: [PATCH v5 22/36] drm/bridge: analogix_dp: Fix incorrect operations with register ANALOGIX_DP_FUNC_EN_1

2018-03-13 Thread Archit Taneja
edp phy, BIT 7 reserved BIT 6 RK_VID_CAP_FUNC_EN_N BIT 5 RK_VID_FIFO_FUNC_EN_N So, we should do some private operations to Rockchip. Reviewed-by: Archit Taneja Thanks, Archit Cc: Tomasz Figa Signed-off-by: zain wang Signed-off-by: Sean Paul Signed-off-by

Re: [PATCH v5 20/36] drm/bridge: analogix_dp: Don't use ANALOGIX_DP_PLL_CTL to control pll

2018-03-13 Thread Archit Taneja
On Saturday 10 March 2018 03:53 AM, Enric Balletbo i Serra wrote: From: zain wang There is no register named ANALOGIX_DP_PLL_CTL in Rockchip edp phy reg list. We should use BIT_4 in ANALOGIX_DP_PD to control the pll power instead of ANALOGIX_DP_PLL_CTL. Reviewed-by: Archit Taneja

Re: [PATCH v5 19/36] drm/rockchip: Restore psr->state when enable/disable psr failed

2018-03-13 Thread Archit Taneja
On Saturday 10 March 2018 03:53 AM, Enric Balletbo i Serra wrote: From: zain wang If we failed disable psr, it would hang the display until next psr cycle coming. So we should restore psr->state when it failed. For the bridge part, Reviewed-by: Archit Taneja Thanks, Archit Cc: Tom

Re: [PATCH v5 18/36] drm/bridge: analogix_dp: Reset aux channel if an error occurred

2018-03-13 Thread Archit Taneja
EMOTEIO; A couple of ETIMEDOUTs have been replaced with EREMOTEIOs after this change. Maybe we set it the error no in ret and return ret? With those changes, Reviewed-by: Archit Taneja Thanks, Archit } ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v5 17/36] drm/bridge: analogix_dp: Fix AUX_PD bit for Rockchip

2018-03-13 Thread Archit Taneja
ht? AUX_PD sounds like just one of the fields of the register. With that, Reviewed-by: Archit Taneja Thanks, Archit Cc: Douglas Anderson Signed-off-by: zain wang Signed-off-by: Sean Paul Signed-off-by: Thierry Escande Reviewed-by: Andrzej Hajda Signed-off-by: Enric Balletbo i Serra Tested

Re: [PATCH v5 16/36] drm/bridge: analogix_dp: Check dpcd write/read status

2018-03-13 Thread Archit Taneja
On Saturday 10 March 2018 03:53 AM, Enric Balletbo i Serra wrote: From: Lin Huang We need to check the dpcd write/read return value to see whether the write/read was successful Reviewed-by: Archit Taneja Thanks, Archit Cc: Kristian H. Kristensen Signed-off-by: Lin Huang Signed-off

Re: [PATCH v5 15/36] drm/bridge: analogix_dp: Fix incorrect usage of enhanced mode

2018-03-13 Thread Archit Taneja
, we just enable it at the beginning of link training and then keep it on all the time. Reviewed-by: Archit Taneja Thanks, Archit Cc: Tomasz Figa Signed-off-by: zain wang Signed-off-by: Sean Paul Signed-off-by: Thierry Escande Reviewed-by: Andrzej Hajda Signed-off-by: Enric Balletbo i

Re: [PATCH v5 14/36] drm/bridge: analogix_dp: Extend hpd check time to 100ms

2018-03-13 Thread Archit Taneja
On Saturday 10 March 2018 03:53 AM, Enric Balletbo i Serra wrote: From: Lin Huang There was a 1ms delay to detect the hpd signal, which is too short to detect a short pulse. This patch extends this delay to 100ms. Reviewed-by: Archit Taneja Thanks, Archit Cc: Stéphane Marchesin Cc: 征

Re: [PATCH v5 13/36] drm/bridge: analogix_dp: Ensure edp is disabled when shutting down the panel

2018-03-13 Thread Archit Taneja
On Saturday 10 March 2018 03:53 AM, Enric Balletbo i Serra wrote: From: Lin Huang When panel is shut down, we should make sure edp can be disabled to avoid undefined behavior. Reviewed-by: Archit Taneja Thanks, Archit Cc: Stéphane Marchesin Signed-off-by: Lin Huang Signed-off-by

Re: [PATCH v5 12/36] drm/bridge: analogix_dp: Set PD_INC_BG first when powering up edp phy

2018-03-13 Thread Archit Taneja
On Saturday 10 March 2018 03:53 AM, Enric Balletbo i Serra wrote: From: zain wang Following the correct power up sequence: dp_pd=ff => dp_pd=7f => wait 10us => dp_pd=00 Reviewed-by: Archit Taneja Thanks, Archit Cc: Stéphane Marchesin Signed-off-by: zain wang Signed-off-by:

Re: [PATCH v5 11/36] drm/bridge: analogix_dp: Wait for HPD signal before configuring link

2018-03-13 Thread Archit Taneja
On Saturday 10 March 2018 03:53 AM, Enric Balletbo i Serra wrote: From: zain wang According to DP spec v1.3 chap 3.5.1.2 Link Training, Link Policy Maker must first detect that the HPD signal is asserted high by the Downstream Device before establishing a link with it. Reviewed-by: Archit

Re: [PATCH v5 10/36] drm/bridge: analogix_dp: Retry bridge enable when it failed

2018-03-13 Thread Archit Taneja
On Saturday 10 March 2018 03:53 AM, Enric Balletbo i Serra wrote: From: zain wang When we enable bridge failed, we have to retry it, otherwise we would get the abnormal display. Reviewed-by: Archit Taneja Thanks, Archit Cc: Stéphane Marchesin Signed-off-by: zain wang Signed-off-by

Re: [PATCH v5 09/36] drm/bridge: analogix_dp: Don't use fast link training when panel just powered up

2018-03-13 Thread Archit Taneja
27;s reset fast_train_enable in analogix_dp_bridge_disable(); Reviewed-by: Archit Taneja Thanks, Archit Cc: Stéphane Marchesin Signed-off-by: zain wang Signed-off-by: Sean Paul Signed-off-by: Thierry Escande Signed-off-by: Enric Balletbo i Serra Tested-by: Marek Szyprowski --- drivers/gpu/

Re: [PATCH v5 08/36] drm/bridge: analogix_dp: Check AUX_EN status when doing AUX transfer

2018-03-13 Thread Archit Taneja
On Saturday 10 March 2018 03:52 AM, Enric Balletbo i Serra wrote: From: Lin Huang We should check AUX_EN bit to confirm the AUX CH operation is completed. Reviewed-by: Archit Taneja Thanks, Archit Cc: Stéphane Marchesin Signed-off-by: Lin Huang Signed-off-by: zain wang Signed-off

Re: [PATCH v5 07/36] drm/bridge: analogix_dp: Move enable video into config_video()

2018-03-13 Thread Archit Taneja
On Saturday 10 March 2018 03:52 AM, Enric Balletbo i Serra wrote: From: Lin Huang We need to enable video before analogix_dp_is_video_stream_on(), so we can get the right video stream status. Cc: 征增 王 Cc: Stéphane Marchesin Signed-off-by: Lin Huang Signed-off-by: Sean Paul Signed-off-by:

Re: [PATCH v5 06/36] drm/rockchip: Only wait for panel ACK on PSR entry

2018-03-13 Thread Archit Taneja
exiting. With the subject fix: Reviewed-by: Archit Taneja Thanks, Archit Cc: Stéphane Marchesin Cc: Sonny Rao Signed-off-by: zain wang Signed-off-by: Sean Paul Signed-off-by: Thierry Escande Signed-off-by: Enric Balletbo i Serra Tested-by: Marek Szyprowski --- drivers/gpu

Re: [PATCH v5 05/36] drm/bridge: analogix_dp: add fast link train for eDP

2018-03-13 Thread Archit Taneja
this patch, you can let it stay if it happens to cause conflicts with future patches. Other than that: Reviewed-by: Archit Taneja Thanks, Archit #include #include @@ -35,6 +36,8 @@ #define to_dp(nm) container_of(nm, struct analogix_dp_device, nm) +static const

Re: [PATCH v5 03/36] drm/bridge: analogix_dp: Don't change psr while bridge is disabled

2018-03-13 Thread Archit Taneja
On Saturday 10 March 2018 03:52 AM, Enric Balletbo i Serra wrote: From: zain wang There is a race between AUX CH bring-up and enabling bridge which will cause link training to fail. To avoid hitting it, don't change psr state while enabling the bridge. Reviewed-by: Archit Taneja

Re: [PATCH v5 01/36] drm/bridge: analogix_dp: detect Sink PSR state after configuring the PSR

2018-03-13 Thread Archit Taneja
On Saturday 10 March 2018 03:52 AM, Enric Balletbo i Serra wrote: From: Yakir Yang Make sure the request PSR state takes effect in analogix_dp_send_psr_spd() function, or print the sink PSR error state if we failed to apply the requested PSR setting. Reviewed-by: Archit Taneja Cc: 征增 王

Re: [PATCH 4/5] drm/msm/dsi: implement 6G v2.0+ DSI command broadcast

2018-03-12 Thread Archit Taneja
On Monday 12 March 2018 06:53 PM, Sibi S wrote: From: Archit Taneja I'm a bit uncertain about using this patch in its current state. Some reasons below. Add command broadcast support for DSI 6G v2.0+ controller on SDM845 Signed-off-by: Sibi S --- drivers/gpu/drm/msm/dsi/

Re: [PATCH 3/5] drm/msm/dsi: replace version checks with helper functions

2018-03-12 Thread Archit Taneja
On Monday 12 March 2018 06:53 PM, Sibi S wrote: Replace version checks with the helper functions bound to cfg_handler for DSI v2 and DSI 6G 1.x controllers With the ops set up for DSI6G 2.x too: Reviewed-by: Archit Taneja Thanks, Archit Signed-off-by: Sibi S --- drivers/gpu/drm/msm

Re: [Freedreno] [PATCH 2/5] drm/msm/dsi: add implementation for helper functions

2018-03-12 Thread Archit Taneja
On Monday 12 March 2018 06:53 PM, Sibi S wrote: Add dsi host helper function implementation for DSI v2 and DSI 6G 1.x controllers Signed-off-by: Sibi S --- drivers/gpu/drm/msm/dsi/dsi.h | 15 +++ drivers/gpu/drm/msm/dsi/dsi_cfg.c | 44 +-- drivers/gpu/drm/msm/dsi/dsi_host.c |

Re: [PATCH v2 0/3] drm: Add LVDS decoder bridge

2018-03-09 Thread Archit Taneja
Hi, On Friday 09 March 2018 07:21 PM, Jacopo Mondi wrote: Hello, after some discussion on the proposed bindings for generic lvds decoder and Thine THC63LVD1024, I decided to drop the THC63 specific part and just live with a transparent decoder that does not support any configuration from DT.

Re: [[RFC]DPU PATCH] drm/msm/dsi: Use one connector for dual DSI mode

2018-03-07 Thread Archit Taneja
On Friday 02 March 2018 05:57 AM, chand...@codeaurora.org wrote: On 2018-03-01 07:53, Sean Paul wrote: On Wed, Feb 28, 2018 at 04:44:49PM -0800, Chandan Uddaraju wrote: Current DSI driver uses two connectors for dual DSI case even though we only have one panel. Fix this by implementing one co

Re: [PATCH] drm: bridge: dw-hdmi: Fix overflow workaround for Amlogic Meson GX SoCs

2018-03-06 Thread Archit Taneja
Hi, On Tuesday 06 March 2018 03:23 PM, Neil Armstrong wrote: Hi Architt, On 23/02/2018 12:44, Neil Armstrong wrote: The Amlogic Meson GX SoCs, embedded the v2.01a controller, has been also identified needing this workaround. This patch adds the corresponding version to enable a single iteratio

Re: [PATCH] drm: of: simplify component probe code

2018-03-06 Thread Archit Taneja
On Tuesday 06 March 2018 01:46 PM, Philipp Zabel wrote: On Thu, 2018-02-22 at 21:22 +0200, Baruch Siach wrote: Use positive logic for better readability. This also eliminates one of_node_put() call, making the code shorter. Signed-off-by: Baruch Siach Reviewed-by: Philipp Zabel Tested-by:

Re: [RFC][PATCH 04/11] drm: Split the display info into static and dynamic parts

2018-02-27 Thread Archit Taneja
_format, 1); drm_mode_connector_attach_encoder(&tc->connector, tc->bridge.encoder); The sii902x driver sets the bus_formats in get_modes, but it's a fixed value and we may as well do it in bridge's attach op. For the bridge drivers: Reviewed-by: Archit Taneja Tha

Re: [PATCH] drm/pl111: Remove reverse dependency on DRM_DUMB_VGA_DAC

2018-02-26 Thread Archit Taneja
On Tuesday 20 February 2018 04:44 PM, Archit Taneja wrote: On Tuesday 20 February 2018 03:59 PM, Thierry Reding wrote: From: Thierry Reding DRM_DUMB_VGA_DAC is a user-visible symbol. Selecting it can cause unmet direct dependencies such as this (on i386, randconfig): warning

Re: [PATCH] drm/pl111: Remove reverse dependency on DRM_DUMB_VGA_DAC

2018-02-20 Thread Archit Taneja
ndencies". +Linus. I guess this needs to go in drm-misc-fixes once it is updated to 4.16-rc2. Thanks, Archit Fixes: 49f81d80ab84 ("drm/pl111: Support handling bridge timings") Reported-by: Randy Dunlap Cc: Laurent Pinchart Cc: Archit Taneja Cc: Eric Anholt Signed-off-

Re: [PATCH v5 05/12] drm/bridge/synopsys: dw-hdmi: don't clobber drvdata

2018-02-15 Thread Archit Taneja
structure when needed. Idea was taken from the following commit: 8242ecbd597d ("drm/bridge/synopsys: stop clobbering drvdata") Reviewed-by: Archit Taneja Cc: p.za...@pengutronix.de Cc: narmstr...@baylibre.com Cc: laurent.pinch...@ideasonboard.com Cc: h...@rock-chips.com Cc: he..

Re: [PATCH v5 04/12] drm/bridge/synopsys: dw-hdmi: Export some PHY related functions

2018-02-15 Thread Archit Taneja
reused. Functions exported here are actually not specific to Synopsys PHYs but to DWC HDMI controller PHY interface. This means that even if the PHY is completely custom, i.e. not designed by Synopsys, exported functions can be useful. Reviewed-by: Archit Taneja Reviewed-by: Neil Armstrong

Re: [PATCH v5 03/12] drm/bridge/synopsys: dw-hdmi: Enable workaround for v1.32a

2018-02-15 Thread Archit Taneja
On Thursday 15 February 2018 01:38 AM, Jernej Skrabec wrote: Allwinner SoCs have dw hdmi controller v1.32a which exhibits same magenta line issue as i.MX6Q and i.MX6DL. Enable workaround for it. Tests show that one iteration is enough. Acked-by: Laurent Pinchart Reviewed-by: Archit Taneja

Re: [PATCH 6/7] dt-bindings: display: msm/dsi: Add compatible for 14nm DSI PHY

2018-01-31 Thread Archit Taneja
On 01/31/2018 09:50 PM, Rob Clark wrote: On Wed, Jan 31, 2018 at 1:40 AM, Archit Taneja wrote: On 01/29/2018 10:45 PM, Rob Herring wrote: On Wed, Jan 17, 2018 at 03:04:47PM +0530, Archit Taneja wrote: Add the compatible string for 14nm DSI PHY (used in MSM8996/APQ8096). From 14nm PHY

Re: [PATCH 6/7] dt-bindings: display: msm/dsi: Add compatible for 14nm DSI PHY

2018-01-30 Thread Archit Taneja
On 01/29/2018 10:45 PM, Rob Herring wrote: On Wed, Jan 17, 2018 at 03:04:47PM +0530, Archit Taneja wrote: Add the compatible string for 14nm DSI PHY (used in MSM8996/APQ8096). From 14nm PHY onwards, the "dsi_phy_regulator" reg-name is not required, but "dsi_phy_lane" reg

Re: [PATCH v2 1/2] drm/bridge/synopsys: dsi: Add a warning msg on dsi read requests

2018-01-30 Thread Archit Taneja
On 01/26/2018 06:14 AM, Brian Norris wrote: On Thu, Jan 25, 2018 at 11:37:59AM +0100, Philippe Cornu wrote: The dcs/generic dsi read feature is not yet implemented so it is important to warn the host_transfer() caller in case of read operation requests. Signed-off-by: Philippe Cornu Awesom

Re: [PATCH v2 2/2] drm/bridge/synopsys: dsi: Fix dsi_host_transfer() return value

2018-01-30 Thread Archit Taneja
On 01/26/2018 06:16 AM, Brian Norris wrote: On Thu, Jan 25, 2018 at 11:38:00AM +0100, Philippe Cornu wrote: The dw_mipi_dsi_host_transfer() must return the number of bytes transmitted/received on success instead of 0. Note: As the read feature is not implemented, only the transmitted number of

Re: [PATCH] drm/bridge/synopsys: dsi: use adjusted_mode in mode_set

2018-01-28 Thread Archit Taneja
On 01/26/2018 03:24 PM, Philippe CORNU wrote: Hi Brian, And a big thanks for your Tested-by On 01/25/2018 11:47 PM, Brian Norris wrote: On Thu, Jan 25, 2018 at 7:55 AM, Philippe Cornu wrote: The "adjusted_mode" clock value (ie the real pixel clock) is more accurate than "mode" clock value (

Re: [PATCH 2/2] drm: adv7511: Add support for i2c_new_secondary_device

2018-01-28 Thread Archit Taneja
Hi, On 01/22/2018 06:20 PM, Kieran Bingham wrote: The ADV7511 has four 256-byte maps that can be accessed via the main I²C ports. Each map has it own I²C address and acts as a standard slave device on the I²C bus. Allow a device tree node to override the default addresses so that address confli

Re: [PATCH 08/12] drm: msm: Use drm_atomic_helper_shutdown() to disable planes on removal

2018-01-18 Thread Archit Taneja
On 01/18/2018 03:25 AM, Laurent Pinchart wrote: The plane cleanup handler currently calls drm_plane_helper_disable(), which is a legacy helper function. Replace it with a call to drm_atomic_helper_shutdown() at removal time. Reviewed-by: Archit Taneja Signed-off-by: Laurent Pinchart

[RFC v2 1/2] dt-bindings: mipi-dsi: Add info about peripherals with non-DSI control bus

2018-01-18 Thread Archit Taneja
Add a section that describes dt-bindings for peripherals that support MIPI DSI, but have a different bus as the primary control bus, or no control bus at all. Add an example for a peripheral with a non-DSI control bus. Signed-off-by: Archit Taneja --- v2: - Mentioned what to do if peripheral has

[RFC v2 2/2] dt-bindings: mipi-dsi: Add dual-channel DSI related info

2018-01-18 Thread Archit Taneja
Add binding info for peripherals that support dual-channel DSI. Add corresponding optional bindings for DSI host controllers that may be configured in this mode. Add an example of an I2C controlled device operating in dual-channel DSI mode. Signed-off-by: Archit Taneja --- v2: - Specify that

[RFC v2 0/2] dt-bindings: mipi-dsi: dual-channel DSI bindings

2018-01-18 Thread Archit Taneja
eady started using, but didn't have properly documented anywhere. The second patch proposes bindings for DSI hosts/peripherals that implement dual-channel DSI. Changes in v2: - Incorported Rob's comments. Archit Taneja (2): dt-bindings: mipi-dsi: Add info about peripherals with no

[PATCH 7/7] dt-bindings: display: msm/dsi: Add updates for SDM845

2018-01-17 Thread Archit Taneja
address/regulator supply needs. Cc: Rob Herring Cc: devicet...@vger.kernel.org Signed-off-by: Archit Taneja --- Documentation/devicetree/bindings/display/msm/dsi.txt | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/display/msm/dsi.txt b

[PATCH 3/7] drm/msm/dsi: Add byte_intf_clk

2018-01-17 Thread Archit Taneja
t its rate only after we configure byte_clk. This is required for the ancestor clocks in the CC to be configured correctly. Signed-off-by: Archit Taneja --- drivers/gpu/drm/msm/dsi/dsi_host.c | 32 1 file changed, 32 insertions(+) diff --git a/drivers/gpu/drm/ms

[PATCH 6/7] dt-bindings: display: msm/dsi: Add compatible for 14nm DSI PHY

2018-01-17 Thread Archit Taneja
er.kernel.org Signed-off-by: Archit Taneja --- Documentation/devicetree/bindings/display/msm/dsi.txt | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/display/msm/dsi.txt b/Documentation/devicetree/bindings/display/msm/dsi.tx

[PATCH 4/7] dt-bindings: display: msm/dsi: Remove unused properties

2018-01-17 Thread Archit Taneja
"qcom,dsi-host-index" and "qcom,dsi-phy-index" DT props aren't acceptable and have never been used in any DT files. Remove them. Cc: Rob Herring Cc: devicet...@vger.kernel.org Signed-off-by: Archit Taneja --- Documentation/devicetree/bindings/display/msm/dsi.txt |

[PATCH 5/7] dt-bindings: display: msm/dsi: Fix the PHY regulator supply props

2018-01-17 Thread Archit Taneja
The PHY regulator supply names vary across different PHY versions. Mention explicitly which PHYs require which supplies. Cc: Rob Herring Cc: devicet...@vger.kernel.org Signed-off-by: Archit Taneja --- Documentation/devicetree/bindings/display/msm/dsi.txt | 4 1 file changed, 4 insertions

[PATCH 1/7] drm/msm/dsi: Use msm_clk_get in dsi_get_config

2018-01-17 Thread Archit Taneja
We try to get the interface clock in dsi_get_config early during DSI's component bind. Try getting both the "iface" and "iface_clk" clock name variants so that we are compatible with both new and legacy DT. Signed-off-by: Archit Taneja --- drivers/gpu/drm/msm/dsi/dsi_

[PATCH 0/7] drm/msm/dsi: SDM845 DSI host controller and DT updates

2018-01-17 Thread Archit Taneja
This series adds some of the host controller changes needed for SDM845.\ The DT patches in the series do some minor clean ups and add missing bindings for 14nm DSI PHY (8x96) and new bindings for 10nm PHY. Archit Taneja (7): drm/msm/dsi: Use msm_clk_get in dsi_get_config drm/msm/dsi: Add

[PATCH 2/7] drm/msm/dsi: Add SDM845 in dsi_cfg

2018-01-17 Thread Archit Taneja
SDM845 contains 2 DSI6G v2.2.1 host controllers. Add them in dsi_cfg. Cc: Jordan Crouse Signed-off-by: Archit Taneja --- drivers/gpu/drm/msm/dsi/dsi_cfg.c | 19 +++ drivers/gpu/drm/msm/dsi/dsi_cfg.h | 1 + 2 files changed, 20 insertions(+) diff --git a/drivers/gpu/drm/msm/dsi

  1   2   3   4   5   6   7   8   9   10   >