Re: [PATCH v2 00/12] Generate CPER records for RAS and commit to CPER ring

2025-04-16 Thread Aravind Iddamsetty
Hi, I would appreciate it if you could kindly let me know your thoughts. Thanks, Aravind. On 28-03-2025 17:42, Aravind Iddamsetty wrote: > ++ dri-devel > > On 28-03-2025 15:57, Aravind Iddamsetty wrote: >> Hi, >> >> Based on the discussions around using Netlink for RAS

Re: [PATCH v2 00/12] Generate CPER records for RAS and commit to CPER ring

2025-03-28 Thread Aravind Iddamsetty
++ dri-devel On 28-03-2025 15:57, Aravind Iddamsetty wrote: > Hi, > > Based on the discussions around using Netlink for RAS purposes, as > summarized in this blog post [1] by Dave Airlie. I had proposed a series > regarding RAS infrastructure in DRM [2]. > > I came across you

Re: [PATCH v9 1/4] drm: Introduce device wedged event

2024-11-24 Thread Aravind Iddamsetty
On 22/11/24 21:32, Raag Jadav wrote: > On Fri, Nov 22, 2024 at 11:09:32AM +0100, Christian König wrote: >> Am 22.11.24 um 08:07 schrieb Raag Jadav: >>> On Mon, Nov 18, 2024 at 08:26:37PM +0530, Aravind Iddamsetty wrote: >>>> On 15/11/24 10:37, Raag Jadav wrote:

Re: [PATCH v9 4/4] drm/i915: Use device wedged event

2024-11-18 Thread Aravind Iddamsetty
> + else > + drm_dev_wedged_event(>->i915->drm, > + DRM_WEDGE_RECOVERY_REBIND | > DRM_WEDGE_RECOVERY_BUS_RESET); Reviewed-by: Aravind Iddamsetty Thanks, Aravind. > } > > /**

Re: [PATCH v9 3/4] drm/xe: Use device wedged event

2024-11-18 Thread Aravind Iddamsetty
.0/:03:00.0/drm/card0 > SUBSYSTEM=drm > WEDGED=rebind,bus-reset > DEVNAME=/dev/dri/card0 > DEVTYPE=drm_minor > SEQNUM=5208 > MAJOR=226 > MINOR=0 LGTM. Reviewed-by: Aravind Iddamsetty Thanks, Aravind. > > v2: Change authorship to Himal (Aravind) > Add uevent fo

Re: [PATCH v9 1/4] drm: Introduce device wedged event

2024-11-18 Thread Aravind Iddamsetty
On 15/11/24 10:37, Raag Jadav wrote: > Introduce device wedged event, which notifies userspace of 'wedged' > (hanged/unusable) state of the DRM device through a uevent. This is > useful especially in cases where the device is no longer operating as > expected and has become unrecoverable from dri

Re: [PATCH v5 3/4] drm/xe: Use device wedged event

2024-09-17 Thread Aravind Iddamsetty
On 17/09/24 13:33, Ghimiray, Himal Prasad wrote: > > > On 17-09-2024 12:08, Raag Jadav wrote: >> On Tue, Sep 17, 2024 at 10:11:05AM +0530, Ghimiray, Himal Prasad wrote: >>> On 17-09-2024 09:32, Raag Jadav wrote: This was previously attempted as xe specific reset uevent but dropped in co

Re: [PATCH v3 1/3] drm: Introduce device wedged event

2024-09-02 Thread Aravind Iddamsetty
On 02/09/24 13:18, Raag Jadav wrote: > Introduce device wedged event, which will notify userspace of wedged > (hanged/unusable) state of the DRM device through a uevent. This is > useful especially in cases where the device is in unrecoverable state > and requires userspace intervention for recov

Re: [PATCH v3 2/3] drm/xe: Use device wedged event

2024-09-02 Thread Aravind Iddamsetty
On 02/09/24 13:18, Raag Jadav wrote: This patch looks entirely new from what was sent earlier so you could send it as a fresh patch. Thanks, Aravind, > From: Himal Prasad Ghimiray > > This was previously attempted as xe specific reset uevent but dropped > in commit 77a0d4d1cea2 ("drm/xe/uapi:

Re: [PATCH v3 3/3] drm/i915: Use device wedged event

2024-09-02 Thread Aravind Iddamsetty
On 02/09/24 13:18, Raag Jadav wrote: > Now that we have device wedged event supported by DRM core, make use > of it. With this in place, userspace will be notified of wedged device > on gt reset failure. > > Signed-off-by: Raag Jadav > --- > drivers/gpu/drm/i915/gt/intel_reset.c | 2 ++ > 1 fil

Re: [PATCH v2] drm/xe/uapi: Bring back reset uevent

2024-08-15 Thread Aravind Iddamsetty
On 14/08/24 19:54, Lucas De Marchi wrote: > On Wed, Aug 14, 2024 at 12:16:41PM GMT, Aravind Iddamsetty wrote: >>>>> i see that this is even called from xe_guc_exec_queue_lr_cleanup which is >>>>> for long running queue >>>>> from various call pa

Re: [PATCH v2] drm/xe/uapi: Bring back reset uevent

2024-08-14 Thread Aravind Iddamsetty
On 14/08/24 14:42, Raag Jadav wrote: > On Wed, Aug 14, 2024 at 12:16:41PM +0530, Aravind Iddamsetty wrote: >> On 13/08/24 22:24, Rodrigo Vivi wrote: >>> On Tue, Aug 13, 2024 at 04:28:32PM +0300, Raag Jadav wrote: >>>> On Mon, Aug 12, 2024 at 03:08:14PM +0530, Arav

Re: [PATCH v2] drm/xe/uapi: Bring back reset uevent

2024-08-13 Thread Aravind Iddamsetty
On 13/08/24 22:24, Rodrigo Vivi wrote: > On Tue, Aug 13, 2024 at 04:28:32PM +0300, Raag Jadav wrote: >> On Mon, Aug 12, 2024 at 03:08:14PM +0530, Aravind Iddamsetty wrote: >>> On 12/08/24 13:18, Raag Jadav wrote: >>>> From: Himal Prasad Ghimiray >>>> &g

Re: [PATCH v2] drm/xe/uapi: Bring back reset uevent

2024-08-13 Thread Aravind Iddamsetty
On 13/08/24 19:43, Lucas De Marchi wrote: > On Mon, Aug 12, 2024 at 01:18:12PM GMT, Raag Jadav wrote: >> From: Himal Prasad Ghimiray >> >> This was dropped in commit 77a0d4d1cea2 ("drm/xe/uapi: Remove reset >> uevent for now") as part of refactoring. >> >> Now that we have better uapi semantics

Re: [PATCH v2] drm/xe/uapi: Bring back reset uevent

2024-08-12 Thread Aravind Iddamsetty
On 12/08/24 13:18, Raag Jadav wrote: > From: Himal Prasad Ghimiray > > This was dropped in commit 77a0d4d1cea2 ("drm/xe/uapi: Remove reset > uevent for now") as part of refactoring. > > Now that we have better uapi semantics and naming for the uevent, > bring it back. With this in place, userspac

Re: [PATCH v1] drm/xe/uapi: Bring back reset uevent

2024-08-06 Thread Aravind Iddamsetty
On 06/08/24 10:02, Raag Jadav wrote: This change  was originally sent by Himal, so may be you should keep his authorship. > From: Lucas De Marchi > > Bring back uevent for gt reset failure with better uapi naming. > With this in place we can receive failure event using udev. > > $ udevadm mo

Re: [PATCH v3 1/4] drm: add devm release action

2024-04-25 Thread Aravind Iddamsetty
4 at 02:25:06PM +0530, Aravind Iddamsetty wrote: >>>>> On 23/04/24 02:24, Rodrigo Vivi wrote: >>>>>> On Mon, Apr 22, 2024 at 12:27:53PM +0530, Aravind Iddamsetty wrote: >>>>>>> In scenarios where drm_dev_put is directly called by drive

Re: [PATCH v3 4/4] drm/xe/FLR: Support PCIe FLR

2024-04-24 Thread Aravind Iddamsetty
On 25/04/24 04:59, Michał Winiarski wrote: > On Wed, Apr 24, 2024 at 10:42:59AM +0530, Aravind Iddamsetty wrote: >> On 24/04/24 05:19, Michał Winiarski wrote: >>> On Mon, Apr 22, 2024 at 12:27:56PM +0530, Aravind Iddamsetty wrote: >>>> PCI subsystem provides callba

Re: [PATCH v3 4/4] drm/xe/FLR: Support PCIe FLR

2024-04-24 Thread Aravind Iddamsetty
On 24/04/24 16:42, Nilawar, Badal wrote: > > > On 24-04-2024 08:42, Aravind Iddamsetty wrote: >> >> On 23/04/24 20:34, Nilawar, Badal wrote: >>> >>> >>> On 22-04-2024 12:27, Aravind Iddamsetty wrote: >>>> PCI subsystem provides callba

Re: [PATCH v3 1/4] drm: add devm release action

2024-04-24 Thread Aravind Iddamsetty
On 24/04/24 17:21, Maxime Ripard wrote: > On Mon, Apr 22, 2024 at 12:27:53PM +0530, Aravind Iddamsetty wrote: >> In scenarios where drm_dev_put is directly called by driver we want to >> release devm_drm_dev_init_release action associated with struct >> drm_device. >>

Re: [PATCH v3 1/4] drm: add devm release action

2024-04-24 Thread Aravind Iddamsetty
On 23/04/24 23:12, Rodrigo Vivi wrote: > On Tue, Apr 23, 2024 at 02:25:06PM +0530, Aravind Iddamsetty wrote: >> On 23/04/24 02:24, Rodrigo Vivi wrote: >>> On Mon, Apr 22, 2024 at 12:27:53PM +0530, Aravind Iddamsetty wrote: >>>> In scenarios where drm_dev_put is dir

Re: [PATCH v3 4/4] drm/xe/FLR: Support PCIe FLR

2024-04-23 Thread Aravind Iddamsetty
On 24/04/24 05:19, Michał Winiarski wrote: > On Mon, Apr 22, 2024 at 12:27:56PM +0530, Aravind Iddamsetty wrote: >> PCI subsystem provides callbacks to inform the driver about a request to >> do function level reset by user, initiated by writing to sysfs entry >> /sys/bus/

Re: [PATCH v3 4/4] drm/xe/FLR: Support PCIe FLR

2024-04-23 Thread Aravind Iddamsetty
On 23/04/24 20:34, Nilawar, Badal wrote: > > > On 22-04-2024 12:27, Aravind Iddamsetty wrote: >> PCI subsystem provides callbacks to inform the driver about a request to >> do function level reset by user, initiated by writing to sysfs entry >> /sys/bus/pci/devices/...

Re: [PATCH v3 1/4] drm: add devm release action

2024-04-23 Thread Aravind Iddamsetty
On 23/04/24 02:24, Rodrigo Vivi wrote: > On Mon, Apr 22, 2024 at 12:27:53PM +0530, Aravind Iddamsetty wrote: >> In scenarios where drm_dev_put is directly called by driver we want to >> release devm_drm_dev_init_release action associated with struct >> drm_device. >>

[PATCH v3 4/4] drm/xe/FLR: Support PCIe FLR

2024-04-21 Thread Aravind Iddamsetty
: Rodrigo Vivi Signed-off-by: Aravind Iddamsetty --- drivers/gpu/drm/xe/Makefile | 1 + drivers/gpu/drm/xe/xe_device_types.h | 3 + drivers/gpu/drm/xe/xe_guc_pc.c | 4 ++ drivers/gpu/drm/xe/xe_pci.c | 9 ++- drivers/gpu/drm/xe/xe_pci.h | 2 + drivers/gpu/drm/xe

[PATCH v2 3/4] drm/xe: Extract xe_gt_idle() helper

2024-04-21 Thread Aravind Iddamsetty
This would be used in other places outside of gt_reset path. v2: 1. Add kernel doc for xe_gt_idle (Michal) 2. fix return as no actual error is reported by xe_uc_stop (Himal) Cc: Lucas De Marchi Cc: Michal Wajdeczko Cc: Himal Prasad Ghimiray Reviewed-by: Rodrigo Vivi Signed-off-by: Aravind

[PATCH 2/4] drm/xe: Save and restore PCI state

2024-04-21 Thread Aravind Iddamsetty
Save and restore PCI states where ever needed. Cc: Lucas De Marchi Reviewed-by: Rodrigo Vivi Signed-off-by: Aravind Iddamsetty --- drivers/gpu/drm/xe/xe_device_types.h | 3 ++ drivers/gpu/drm/xe/xe_pci.c | 48 ++-- drivers/gpu/drm/xe/xe_pci.h | 4

[PATCH v3 1/4] drm: add devm release action

2024-04-21 Thread Aravind Iddamsetty
: Thomas Hellstr_m Cc: Rodrigo Vivi Reviewed-by: Rodrigo Vivi Signed-off-by: Aravind Iddamsetty --- drivers/gpu/drm/drm_drv.c | 13 + include/drm/drm_drv.h | 2 ++ 2 files changed, 15 insertions(+) diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c index 243cacb3575c

[PATCH v4 0/4] drm/xe: Support PCIe FLR

2024-04-21 Thread Aravind Iddamsetty
27] Console: switching to colour frame buffer device 128x48 Aravind Iddamsetty (4): drm: add devm release action drm/xe: Save and restore PCI state drm/xe: Extract xe_gt_idle() helper drm/xe/FLR: Support PCIe FLR drivers/gpu/drm/drm_drv.c| 13 drivers/gpu/drm/xe/Makefile

Re: [PATCH v2 1/4] drm: add devm release action

2024-04-20 Thread Aravind Iddamsetty
On 19/04/24 14:41, Maxime Ripard wrote: > On Fri, Apr 19, 2024 at 02:28:23PM +0530, Aravind Iddamsetty wrote: >> In scenarios where drm_dev_put is directly called by driver we want to >> release devm_drm_dev_init_release action associated with struct >> drm_device. >>

[PATCH v3 4/4] drm/xe/FLR: Support PCIe FLR

2024-04-19 Thread Aravind Iddamsetty
: Rodrigo Vivi Signed-off-by: Aravind Iddamsetty --- drivers/gpu/drm/xe/Makefile | 1 + drivers/gpu/drm/xe/xe_device_types.h | 3 + drivers/gpu/drm/xe/xe_guc_pc.c | 4 ++ drivers/gpu/drm/xe/xe_pci.c | 9 ++- drivers/gpu/drm/xe/xe_pci.h | 2 + drivers/gpu/drm/xe

[PATCH v2 3/4] drm/xe: Extract xe_gt_idle() helper

2024-04-19 Thread Aravind Iddamsetty
This would be used in other places outside of gt_reset path. v2: 1. Add kernel doc for xe_gt_idle (Michal) 2. fix return as no actual error is reported by xe_uc_stop (Himal) Cc: Lucas De Marchi Cc: Michal Wajdeczko Cc: Himal Prasad Ghimiray Reviewed-by: Rodrigo Vivi Signed-off-by: Aravind

[PATCH 2/4] drm/xe: Save and restore PCI state

2024-04-19 Thread Aravind Iddamsetty
Save and restore PCI states where ever needed. Cc: Lucas De Marchi Reviewed-by: Rodrigo Vivi Signed-off-by: Aravind Iddamsetty --- drivers/gpu/drm/xe/xe_device_types.h | 3 ++ drivers/gpu/drm/xe/xe_pci.c | 48 ++-- drivers/gpu/drm/xe/xe_pci.h | 4

[PATCH v2 1/4] drm: add devm release action

2024-04-19 Thread Aravind Iddamsetty
Vivi Signed-off-by: Aravind Iddamsetty --- drivers/gpu/drm/drm_drv.c | 6 ++ include/drm/drm_drv.h | 2 ++ 2 files changed, 8 insertions(+) diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c index 243cacb3575c..ba60cbb0725f 100644 --- a/drivers/gpu/drm/drm_drv.c +++ b

[PATCH v3 0/4] drm/xe: Support PCIe FLR

2024-04-19 Thread Aravind Iddamsetty
g to colour frame buffer device 128x48 Aravind Iddamsetty (4): drm: add devm release action drm/xe: Save and restore PCI state drm/xe: Extract xe_gt_idle() helper drm/xe/FLR: Support PCIe FLR drivers/gpu/drm/drm_drv.c| 6 ++ drivers/gpu/drm/xe/Makefile | 1 + drivers

Re: [PATCH 3/4] drm/xe: Extract xe_gt_idle() helper

2024-04-18 Thread Aravind Iddamsetty
On 17/04/24 19:20, Michal Wajdeczko wrote: > > On 17.04.2024 10:41, Aravind Iddamsetty wrote: >> This would be used in other places outside of gt_reset path. >> >> Cc: Lucas De Marchi >> >> Reviewed-by: Rodrigo Vivi >> Signed-off-by: Aravind Iddamse

Re: [PATCH v2 4/4] drm/xe/FLR: Support PCIe FLR

2024-04-18 Thread Aravind Iddamsetty
On 17/04/24 19:29, Michal Wajdeczko wrote: > > On 17.04.2024 10:41, Aravind Iddamsetty wrote: >> PCI subsystem provides callbacks to inform the driver about a request to >> do function level reset by user, initiated by writing to sysfs entry >> /sys/bus/pci/devices/.../re

[PATCH v2 4/4] drm/xe/FLR: Support PCIe FLR

2024-04-17 Thread Aravind Iddamsetty
device afresh post FLR. v2: 1. separate out gt idle and pci save/restore to a separate patch (Lucas) 2. Fixed the warnings seen around xe_guc_submit_stop, xe_guc_puc_fini Cc: Rodrigo Vivi Cc: Lucas De Marchi Reviewed-by: Rodrigo Vivi Signed-off-by: Aravind Iddamsetty --- drivers/gpu/drm/xe

[PATCH 3/4] drm/xe: Extract xe_gt_idle() helper

2024-04-17 Thread Aravind Iddamsetty
This would be used in other places outside of gt_reset path. Cc: Lucas De Marchi Reviewed-by: Rodrigo Vivi Signed-off-by: Aravind Iddamsetty --- drivers/gpu/drm/xe/xe_gt.c | 31 +-- drivers/gpu/drm/xe/xe_gt.h | 1 + 2 files changed, 22 insertions(+), 10 deletions

[PATCH 2/4] drm/xe: Save and restore PCI state

2024-04-17 Thread Aravind Iddamsetty
Save and restore PCI states where ever needed. Cc: Lucas De Marchi Reviewed-by: Rodrigo Vivi Signed-off-by: Aravind Iddamsetty --- drivers/gpu/drm/xe/xe_device_types.h | 3 ++ drivers/gpu/drm/xe/xe_pci.c | 48 ++-- drivers/gpu/drm/xe/xe_pci.h | 4

[PATCH v2 1/4] drm: add devm release action

2024-04-17 Thread Aravind Iddamsetty
Vivi Signed-off-by: Aravind Iddamsetty --- drivers/gpu/drm/drm_drv.c | 6 ++ include/drm/drm_drv.h | 2 ++ 2 files changed, 8 insertions(+) diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c index 243cacb3575c..ba60cbb0725f 100644 --- a/drivers/gpu/drm/drm_drv.c +++ b

[PATCH v2 0/4] drm/xe: Support PCIe FLR

2024-04-17 Thread Aravind Iddamsetty
27] Console: switching to colour frame buffer device 128x48 Aravind Iddamsetty (4): drm: add devm release action drm/xe: Save and restore PCI state drm/xe: Extract xe_gt_idle() helper drm/xe/FLR: Support PCIe FLR drivers/gpu/drm/drm_drv.c| 6 ++ drivers/gpu/drm/xe/Makefile

Re: [PATCH v2 1/4] drm: add devm release action

2024-04-16 Thread Aravind Iddamsetty
Hi Daniel/ Maarten, Could you please ack this patch. Thanks, Aravind. On 02/04/24 14:28, Aravind Iddamsetty wrote: > In scenarios where drm_dev_put is directly called by driver we want to > release devm_drm_dev_init_release action associated with struct > drm_device. > > v2:

Re: [PATCH v2 1/4] drm: add devm release action

2024-04-14 Thread Aravind Iddamsetty
Hi Thomas, Could you share your thoughts on this please. Thanks, Aravind. On 02/04/24 14:28, Aravind Iddamsetty wrote: > In scenarios where drm_dev_put is directly called by driver we want to > release devm_drm_dev_init_release action associated with struct > drm_device. > &g

Re: [PATCH v2 0/4] drm/xe: Support PCIe FLR

2024-04-07 Thread Aravind Iddamsetty
On 05/04/24 10:30, Aravind Iddamsetty wrote: > On 05/04/24 03:55, Rodrigo Vivi wrote: >> On Tue, Apr 02, 2024 at 02:28:55PM +0530, Aravind Iddamsetty wrote: >>> PCI subsystem provides callbacks to inform the driver about a request to >>> do function level reset by us

Re: [PATCH v2 0/4] drm/xe: Support PCIe FLR

2024-04-04 Thread Aravind Iddamsetty
On 05/04/24 03:55, Rodrigo Vivi wrote: > On Tue, Apr 02, 2024 at 02:28:55PM +0530, Aravind Iddamsetty wrote: >> PCI subsystem provides callbacks to inform the driver about a request to >> do function level reset by user, initiated by writing to sysfs entry >> /sys/bus/pci/de

[PATCH v2 4/4] drm/xe/FLR: Support PCIe FLR

2024-04-02 Thread Aravind Iddamsetty
device afresh post FLR. v2: 1. separate out gt idle and pci save/restore to a separate patch (Lucas) 2. Fixed the warnings seen around xe_guc_submit_stop, xe_guc_puc_fini Cc: Rodrigo Vivi Cc: Lucas De Marchi Signed-off-by: Aravind Iddamsetty --- drivers/gpu/drm/xe/Makefile | 1

[PATCH 3/4] drm/xe: Extract xe_gt_idle() helper

2024-04-02 Thread Aravind Iddamsetty
This would be used in other places outside of gt_reset path. Cc: Lucas De Marchi Signed-off-by: Aravind Iddamsetty --- drivers/gpu/drm/xe/xe_gt.c | 31 +-- drivers/gpu/drm/xe/xe_gt.h | 1 + 2 files changed, 22 insertions(+), 10 deletions(-) diff --git a/drivers

[PATCH 2/4] drm/xe: Save and restore PCI state

2024-04-02 Thread Aravind Iddamsetty
Save and restore PCI states where ever needed. Cc: Lucas De Marchi Signed-off-by: Aravind Iddamsetty --- drivers/gpu/drm/xe/xe_device_types.h | 3 ++ drivers/gpu/drm/xe/xe_pci.c | 48 ++-- drivers/gpu/drm/xe/xe_pci.h | 4 ++- 3 files changed, 51

[PATCH v2 1/4] drm: add devm release action

2024-04-02 Thread Aravind Iddamsetty
In scenarios where drm_dev_put is directly called by driver we want to release devm_drm_dev_init_release action associated with struct drm_device. v2: Directly expose the original function, instead of introducing a helper (Rodrigo) Cc: Thomas Hellstr_m Cc: Rodrigo Vivi Signed-off-by: Aravind

[PATCH v2 0/4] drm/xe: Support PCIe FLR

2024-04-02 Thread Aravind Iddamsetty
] [IGT] xe_exec_basic: starting subtest once-basic [ 665.968899] [IGT] xe_exec_basic: finished subtest once-basic, SUCCESS [ 665.969534] [IGT] xe_exec_basic: exiting, ret=0 [ 665.981027] Console: switching to colour frame buffer device 128x48 Aravind Iddamsetty (4): drm: add devm release action

Re: [RFC 2/2] drm/xe/FLR: Support PCIe FLR

2024-03-21 Thread Aravind Iddamsetty
On 21/03/24 04:31, Lucas De Marchi wrote: > On Wed, Mar 20, 2024 at 04:14:26PM +0530, Aravind Iddamsetty wrote: >> PCI subsystem provides callbacks to inform the driver about a request to >> do function level reset by user, initiated by writing to sysfs entry >> /sys/bus/

Re: [RFC 2/2] drm/xe/FLR: Support PCIe FLR

2024-03-21 Thread Aravind Iddamsetty
On 21/03/24 02:22, Rodrigo Vivi wrote: > On Wed, Mar 20, 2024 at 04:14:26PM +0530, Aravind Iddamsetty wrote: >> PCI subsystem provides callbacks to inform the driver about a request to >> do function level reset by user, initiated by writing to sysfs entry >> /sys/bus/pci/de

Re: [RFC 1/2] drm: add devm release action

2024-03-21 Thread Aravind Iddamsetty
On 21/03/24 12:17, Jani Nikula wrote: > On Thu, 21 Mar 2024, Aravind Iddamsetty > wrote: >> On 21/03/24 02:23, Rodrigo Vivi wrote: >>> On Wed, Mar 20, 2024 at 04:14:25PM +0530, Aravind Iddamsetty wrote: >>>> In scenarios where drm_dev_put is directly called

Re: [RFC 1/2] drm: add devm release action

2024-03-20 Thread Aravind Iddamsetty
On 21/03/24 02:23, Rodrigo Vivi wrote: > On Wed, Mar 20, 2024 at 04:14:25PM +0530, Aravind Iddamsetty wrote: >> In scenarios where drm_dev_put is directly called by driver we want to >> release devm_drm_dev_init_release action associated with struct >> drm_device. >&

[RFC 0/2] drm/xe: Support PCIe FLR

2024-03-20 Thread Aravind Iddamsetty
itching to colour dummy device 80x25 [ 3159.484422] [IGT] xe_exec_basic: executing [ 3159.502594] [IGT] xe_exec_basic: starting subtest once-basic [ 3159.526649] [IGT] xe_exec_basic: finished subtest once-basic, SUCCESS [ 3159.526929] [IGT] xe_exec_basic: exiting, ret=0 Aravind Iddamsetty (2): drm:

[RFC 2/2] drm/xe/FLR: Support PCIe FLR

2024-03-20 Thread Aravind Iddamsetty
device afresh post FLR. Cc: Rodrigo Vivi Cc: Lucas De Marchi Signed-off-by: Aravind Iddamsetty --- drivers/gpu/drm/xe/Makefile | 1 + drivers/gpu/drm/xe/xe_device_types.h | 3 + drivers/gpu/drm/xe/xe_gt.c | 31 ++--- drivers/gpu/drm/xe/xe_gt.h | 1 + drivers

[RFC 1/2] drm: add devm release action

2024-03-20 Thread Aravind Iddamsetty
In scenarios where drm_dev_put is directly called by driver we want to release devm_drm_dev_init_release action associated with struct drm_device. Cc: Thomas Hellstr_m Signed-off-by: Aravind Iddamsetty --- drivers/gpu/drm/drm_drv.c | 6 ++ include/drm/drm_drv.h | 4 2 files

Re: [RFC v2 5/5] drm/xe/RAS: send multicast event on occurrence of an error

2023-11-22 Thread Aravind Iddamsetty
On 11/12/23 20:58, Tomer Tayar wrote: > On 10/11/2023 14:27, Tomer Tayar wrote: >> On 20/10/2023 18:58, Aravind Iddamsetty wrote: >>> Whenever a correctable or an uncorrectable error happens an event is sent >>> to the corresponding listeners of these groups. >&g

Re: [RFC v3 3/5] drm/xe/RAS: Expose the error counters

2023-11-22 Thread Aravind Iddamsetty
On 11/10/23 17:57, Tomer Tayar wrote: > On 20/10/2023 18:58, Aravind Iddamsetty wrote: >> We expose the various error counters supported on a hardware via genl >> subsytem through the registered commands to userspace. The >> DRM_RAS_CMD_QUERY lists the error

Re: [RFC v4 1/5] drm/netlink: Add netlink infrastructure

2023-11-22 Thread Aravind Iddamsetty
On 11/10/23 17:54, Tomer Tayar wrote: > On 20/10/2023 18:58, Aravind Iddamsetty wrote: >> Define the netlink registration interface and commands, attributes that >> can be commonly used across by drm drivers. This patch intends to use >> the generic netlink family to ex

Re: [RFC v4 0/5] Proposal to use netlink for RAS and Telemetry across drm subsystem

2023-11-22 Thread Aravind Iddamsetty
On 11/10/23 17:53, Tomer Tayar wrote: > On 20/10/2023 18:58, Aravind Iddamsetty wrote: >> Our hardware supports RAS(Reliability, Availability, Serviceability) by >> reporting the errors to the host, which the KMD processes and exposes a >> set of error counters which can be

Re: [RFC v4 0/5] Proposal to use netlink for RAS and Telemetry across drm subsystem

2023-11-08 Thread Aravind Iddamsetty
On 07/11/23 11:00, Lazar, Lijo wrote: > > > On 11/1/2023 1:36 PM, Aravind Iddamsetty wrote: >> >> On 30/10/23 20:41, Lazar, Lijo wrote: >>> >>> >>> On 10/30/2023 11:49 AM, Aravind Iddamsetty wrote: >>>> >>>> On 26/10/23 1

Re: [RFC v4 0/5] Proposal to use netlink for RAS and Telemetry across drm subsystem

2023-11-01 Thread Aravind Iddamsetty
On 30/10/23 20:41, Lazar, Lijo wrote: > > > On 10/30/2023 11:49 AM, Aravind Iddamsetty wrote: >> >> On 26/10/23 15:34, Lazar, Lijo wrote: >> >> Hi Lijo, >> >> Thank you for your comments. >> >>> >>> >>> On 10/23/

Re: [RFC v4 0/5] Proposal to use netlink for RAS and Telemetry across drm subsystem

2023-10-29 Thread Aravind Iddamsetty
On 26/10/23 15:34, Lazar, Lijo wrote: Hi Lijo, Thank you for your comments. > > > On 10/23/2023 8:59 PM, Alex Deucher wrote: >> On Fri, Oct 20, 2023 at 7:42 PM Aravind Iddamsetty >> wrote: >>> >>> Our hardware supports RAS(Reliability, Availabilit

Re: [RFC v4 0/5] Proposal to use netlink for RAS and Telemetry across drm subsystem

2023-10-26 Thread Aravind Iddamsetty
ample, > error-gt0-soc-fatal-hbm-ss0-0 might be converted to non-fatal or deferred > error, so driver doesn't need to be response immediately. > > Regards, > Hawking > > -Original Message- > From: Alex Deucher > Sent: Monday, October 23, 2023 23:29 >

Re: [RFC v4 1/5] drm/netlink: Add netlink infrastructure

2023-10-20 Thread Aravind Iddamsetty
On 21/10/23 02:06, Ruhl, Michael J wrote: >> -Original Message- >> From: Aravind Iddamsetty >> Sent: Friday, October 20, 2023 11:59 AM >> To: intel...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; >> alexander.deuc...@amd.com; airl

[RFC v2 5/5] drm/xe/RAS: send multicast event on occurrence of an error

2023-10-20 Thread Aravind Iddamsetty
Whenever a correctable or an uncorrectable error happens an event is sent to the corresponding listeners of these groups. v2: Rebase Signed-off-by: Aravind Iddamsetty --- drivers/gpu/drm/xe/xe_hw_error.c | 33 1 file changed, 33 insertions(+) diff --git a

[RFC 4/5] drm/netlink: Define multicast groups

2023-10-20 Thread Aravind Iddamsetty
ff-by: Aravind Iddamsetty --- drivers/gpu/drm/drm_netlink.c | 7 +++ include/drm/drm_netlink.h | 5 + include/uapi/drm/drm_netlink.h | 4 3 files changed, 16 insertions(+) diff --git a/drivers/gpu/drm/drm_netlink.c b/drivers/gpu/drm/drm_netlink.c index 8add249c1da3..425a7355a573 1

[RFC v3 3/5] drm/xe/RAS: Expose the error counters

2023-10-20 Thread Aravind Iddamsetty
counters for all errors along with their names and config ids. v2: Rebase v3: 1. presently xe_list_errors fills blank data for IGFX, prevent it by having an early check of IS_DGFX (Michael J. Ruhl) 2. update errors from all sources Cc: Ruhl, Michael J Signed-off-by: Aravind Iddamsetty

[RFC v2 2/5] drm/xe/RAS: Register netlink capability

2023-10-20 Thread Aravind Iddamsetty
Register netlink capability with the DRM and register the driver callbacks to DRM RAS netlink commands. v2: Move the netlink registration parts to DRM susbsytem (Tomer Tayar) Cc: Tomer Tayar Signed-off-by: Aravind Iddamsetty --- drivers/gpu/drm/xe/Makefile | 1 + drivers/gpu/drm/xe

[RFC v4 1/5] drm/netlink: Add netlink infrastructure

2023-10-20 Thread Aravind Iddamsetty
xa_store and handle appropriately Cc: Tomer Tayar Cc: Daniel Vetter Cc: Michael J. Ruhl Signed-off-by: Aravind Iddamsetty --- drivers/gpu/drm/Makefile | 1 + drivers/gpu/drm/drm_drv.c | 7 ++ drivers/gpu/drm/drm_netlink.c | 188 + include/drm

[RFC v4 0/5] Proposal to use netlink for RAS and Telemetry across drm subsystem

2023-10-20 Thread Aravind Iddamsetty
Felix Cc: Tuikov Luben Cc: Ruhl, Michael J Aravind Iddamsetty (5): drm/netlink: Add netlink infrastructure drm/xe/RAS: Register netlink capability drm/xe/RAS: Expose the error counters drm/netlink: Define multicast groups drm/xe/RAS: send multicast event on occurrence of an error drive

[RFC v1 4/5] drm/netlink: Define multicast groups

2023-10-08 Thread Aravind Iddamsetty
ff-by: Aravind Iddamsetty --- drivers/gpu/drm/drm_netlink.c | 2 ++ include/drm/drm_netlink.h | 10 ++ include/uapi/drm/drm_netlink.h | 4 3 files changed, 16 insertions(+) diff --git a/drivers/gpu/drm/drm_netlink.c b/drivers/gpu/drm/drm_netlink.c index 843b2919b6ed..0c2dd62a9a8e 1

[RFC v2 5/5] drm/xe/RAS: send multicast event on occurrence of an error

2023-10-08 Thread Aravind Iddamsetty
Whenever a correctable or an uncorrectable error happens an event is sent to the corresponding listeners of these groups. v2: Rebase Signed-off-by: Aravind Iddamsetty --- drivers/gpu/drm/xe/xe_hw_error.c | 33 1 file changed, 33 insertions(+) diff --git a

[RFC v2 3/5] drm/xe/RAS: Expose the error counters

2023-10-08 Thread Aravind Iddamsetty
counters for all errors along with their names and config ids. v2: Rebase Signed-off-by: Aravind Iddamsetty --- drivers/gpu/drm/xe/xe_netlink.c | 396 +++- include/uapi/drm/xe_drm.h | 61 + 2 files changed, 455 insertions(+), 2 deletions(-) diff --git a

[RFC v2 2/5] drm/xe/RAS: Register netlink capability

2023-10-08 Thread Aravind Iddamsetty
Register netlink capability with the DRM and register the driver callbacks to DRM RAS netlink commands. v2: Move the netlink registration parts to DRM susbsytem (Tomer Tayar) Cc: Tomer Tayar Signed-off-by: Aravind Iddamsetty --- drivers/gpu/drm/xe/Makefile | 1 + drivers/gpu/drm/xe

[RFC v3 1/5] drm/netlink: Add netlink infrastructure

2023-10-08 Thread Aravind Iddamsetty
: define common interfaces to genl netlink subsystem that all drm drivers can leverage.(Tomer Tayar) v3: drop DRIVER_NETLINK flag and use the driver_genl_ops structure to register to netlink subsystem (Daniel Vetter) Cc: Tomer Tayar Cc: Daniel Vetter Signed-off-by: Aravind Iddamsetty --- drivers/gpu

[RFC v3 0/5] Proposal to use netlink for RAS and Telemetry across drm subsystem

2023-10-08 Thread Aravind Iddamsetty
3 error-gt1-soc-fatal-hbm-ss3-7 0x1044 Cc: Alex Deucher Cc: David Airlie Cc: Daniel Vetter Cc: Joonas Lahtinen Cc: Oded Gabbay Cc: Tomer Tayar Cc: Hawking Zhang Cc: Harish Kasiviswanathan Cc: Kuehling Felix Cc: Tuikov Luben Aravind Iddamsetty (5)

[RFC v2 5/5] drm/xe/RAS: send multicast event on occurrence of an error

2023-08-25 Thread Aravind Iddamsetty
Whenever a correctable or an uncorrectable error happens an event is sent to the corresponding listeners of these groups. Signed-off-by: Aravind Iddamsetty --- drivers/gpu/drm/xe/xe_irq.c | 32 1 file changed, 32 insertions(+) diff --git a/drivers/gpu/drm/xe

[RFC v2 4/5] drm/netlink: Define multicast groups

2023-08-25 Thread Aravind Iddamsetty
ff-by: Aravind Iddamsetty --- drivers/gpu/drm/drm_netlink.c | 2 ++ include/drm/drm_netlink.h | 10 ++ include/uapi/drm/drm_netlink.h | 3 +++ 3 files changed, 15 insertions(+) diff --git a/drivers/gpu/drm/drm_netlink.c b/drivers/gpu/drm/drm_netlink.c index e41127963968..6895b8741eaf 1

[RFC v2 1/5] drm/netlink: Add netlink infrastructure

2023-08-25 Thread Aravind Iddamsetty
: define common interfaces to genl netlink subsystem that all drm drivers can leverage.(Tomer Tayar) Cc: Tomer Tayar Signed-off-by: Aravind Iddamsetty --- drivers/gpu/drm/Makefile | 1 + drivers/gpu/drm/drm_drv.c | 7 ++ drivers/gpu/drm/drm_netlink.c | 175

[RFC v2 2/5] drm/xe/RAS: Register netlink capability

2023-08-25 Thread Aravind Iddamsetty
Register netlink capability with the DRM and register the driver callbacks to DRM RAS netlink commands. v2: Move the netlink registration parts to DRM susbsytem (Tomer Tayar) Cc: Tomer Tayar Signed-off-by: Aravind Iddamsetty --- drivers/gpu/drm/xe/Makefile | 1 + drivers/gpu/drm/xe

[RFC v2 3/5] drm/xe/RAS: Expose the error counters

2023-08-25 Thread Aravind Iddamsetty
counters for all errors along with their names and config ids. Signed-off-by: Aravind Iddamsetty --- drivers/gpu/drm/xe/xe_netlink.c | 401 +++- include/uapi/drm/xe_drm.h | 64 + 2 files changed, 463 insertions(+), 2 deletions(-) diff --git a/drivers/gpu

[RFC v2 0/5] Proposal to use netlink for RAS and Telemetry across drm subsystem

2023-08-25 Thread Aravind Iddamsetty
or-gt1-soc-fatal-hbm-ss3-7 0x1044 Cc: Alex Deucher Cc: David Airlie Cc: Daniel Vetter Cc: Joonas Lahtinen Cc: Oded Gabbay Cc: Tomer Tayar Cc: Hawking Zhang Cc: Harish Kasiviswanathan Cc: Kuehling Felix Cc: Tuikov Luben Aravind Iddamsetty (5): d

[RFC 5/5] drm/xe/RAS: send multicast event on occurrence of an error

2023-05-26 Thread Aravind Iddamsetty
Whenever a correctable or an uncorrectable error happens an event is sent to the corresponding listeners of these groups. Signed-off-by: Aravind Iddamsetty --- drivers/gpu/drm/xe/xe_irq.c | 32 drivers/gpu/drm/xe/xe_netlink.c | 2 ++ 2 files changed, 34

[RFC 4/5] drm/netlink: define multicast groups

2023-05-26 Thread Aravind Iddamsetty
ff-by: Aravind Iddamsetty --- include/uapi/drm/drm_netlink.h | 13 + 1 file changed, 13 insertions(+) diff --git a/include/uapi/drm/drm_netlink.h b/include/uapi/drm/drm_netlink.h index 28e7a334d0c7..bd3a8b293979 100644 --- a/include/uapi/drm/drm_netlink.h +++ b/include/uapi/drm/drm_netl

[RFC 3/5] drm/xe/RAS: Expose the error counters

2023-05-26 Thread Aravind Iddamsetty
for all errors along with their names and config ids. Signed-off-by: Aravind Iddamsetty --- drivers/gpu/drm/xe/xe_netlink.c | 439 +++- include/uapi/drm/xe_drm.h | 64 + 2 files changed, 501 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/xe

[RFC 1/5] drm/netlink: Add netlink infrastructure

2023-05-26 Thread Aravind Iddamsetty
Define the netlink commands and attributes that can be commonly used across by drm drivers. Signed-off-by: Aravind Iddamsetty --- include/uapi/drm/drm_netlink.h | 68 ++ 1 file changed, 68 insertions(+) create mode 100644 include/uapi/drm/drm_netlink.h diff

[RFC 2/5] drm/xe/RAS: Register a genl netlink family

2023-05-26 Thread Aravind Iddamsetty
. Signed-off-by: Aravind Iddamsetty --- drivers/gpu/drm/xe/Makefile | 1 + drivers/gpu/drm/xe/xe_device.c | 3 + drivers/gpu/drm/xe/xe_device_types.h | 2 + drivers/gpu/drm/xe/xe_module.c | 2 + drivers/gpu/drm/xe/xe_netlink.c | 89 drivers

[RFC 0/5] Proposal to use netlink for RAS and Telemetry across drm subsystem

2023-05-26 Thread Aravind Iddamsetty
-fatal-hbm-ss3-6 0x1043 error-gt1-soc-fatal-hbm-ss3-7 0x1044 Cc: Alex Deucher Cc: David Airlie Cc: Daniel Vetter Cc: Joonas Lahtinen Cc: Oded Gabbay Aravind Iddamsetty (5): drm/netlink: Add netlink infrastructure

[PATCH v2] drm/i915: Initialize the obj flags for shmem objects

2023-02-03 Thread Aravind Iddamsetty
ko Ursulin Reviewed-by: Matthew Auld Signed-off-by: Aravind Iddamsetty --- drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_shmem.c b/drivers/gpu/drm/i915/gem/i915_gem_shmem.c index 114443096841..37

[PATCH] Initialize the obj flags for shmem objects

2023-02-03 Thread Aravind Iddamsetty
Obj flags for shmem objects is not being set correctly. Cc: Matthew Auld Signed-off-by: Aravind Iddamsetty --- drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_shmem.c b/drivers/gpu/drm/i915/gem

[PATCH v4] drm/i915/mtl: Media GT and Render GT share common GGTT

2022-11-21 Thread Aravind Iddamsetty
list (Matt Roper) Cc: Matt Roper Signed-off-by: Aravind Iddamsetty --- drivers/gpu/drm/i915/gt/intel_ggtt.c | 54 +-- drivers/gpu/drm/i915/gt/intel_gt.c| 13 +- drivers/gpu/drm/i915/gt/intel_gt_types.h | 3 ++ drivers/gpu/drm/i915/gt/intel_gtt.h

[PATCH v3] drm/i915/mtl: Media GT and Render GT share common GGTT

2022-11-15 Thread Aravind Iddamsetty
ggtt->gt_list, as suggested by Lucas 3. as ggtt_flush() is used only for ggtt drop i915_is_ggtt check within it. 4. setup_private_pat moved out of intel_gt_tiles_init v3: 1. Move out for_each_gt from i915_driver.c (Jani Nikula) Cc: Matt Roper Signed-off-by: Aravind Iddamsetty --- drivers/gpu/

[PATCH v2] drm/i915/mtl: Media GT and Render GT share common GGTT

2022-11-09 Thread Aravind Iddamsetty
ggtt->gt_list, as suggested by Lucas 3. as ggtt_flush() is used only for ggtt drop i915_is_ggtt check within it. 4. setup_private_pat moved out of intel_gt_tiles_init Cc: Matt Roper Signed-off-by: Aravind Iddamsetty --- drivers/gpu/drm/i915/gt/intel_ggtt.c | 47 ++--- dri

[PATCH] drm/i915/mtl: Media GT and Render GT share common GGTT

2022-10-31 Thread Aravind Iddamsetty
On XE_LPM+ platforms the media engines are carved out into a separate GT but have a common GGTMMADR address range which essentially makes the GGTT address space to be shared between media and render GT. BSPEC: 63834 Cc: Matt Roper Signed-off-by: Aravind Iddamsetty --- drivers/gpu/drm/i915/gt

[PATCH v5] drm/i915/mtl: enable local stolen memory

2022-09-29 Thread Aravind Iddamsetty
ikula Signed-off-by: CQ Tang Signed-off-by: Aravind Iddamsetty Original-author: CQ Tang --- drivers/gpu/drm/i915/gem/i915_gem_stolen.c | 83 ++ drivers/gpu/drm/i915/gt/intel_ggtt.c | 2 +- drivers/gpu/drm/i915/i915_drv.h| 3 + drivers/gpu/drm/i915/i915_re

[PATCH v4] drm/i915/mtl: enable local stolen memory

2022-09-28 Thread Aravind Iddamsetty
d-off-by: CQ Tang Signed-off-by: Aravind Iddamsetty Original-author: CQ Tang --- drivers/gpu/drm/i915/gem/i915_gem_stolen.c | 83 ++ drivers/gpu/drm/i915/gt/intel_ggtt.c | 2 +- drivers/gpu/drm/i915/i915_drv.h| 3 + drivers/gpu/drm/i915/i915_reg.h

[PATCH v3] drm/i915/mtl: enable local stolen memory

2022-09-26 Thread Aravind Iddamsetty
as GEN12_LMEM_BAR (Lucas) v3:(Jani) 1. rename get_mtl_gms_size to mtl_get_gms_size 2. define register for MMIO address Cc: Matt Roper Cc: Lucas De Marchi Cc: Jani Nikula Signed-off-by: CQ Tang Signed-off-by: Aravind Iddamsetty Original-author: CQ Tang --- drivers/gpu/drm/i915/g

  1   2   >