Re: [PATCH v2] amdgpu: prevent NULL pointer dereference if ATIF is not supported

2024-11-01 Thread Antonio Quartulli
On 31/10/2024 20:37, Mario Limonciello wrote: On 10/31/2024 10:28, Antonio Quartulli wrote: acpi_evaluate_object() may return AE_NOT_FOUND (failure), which would result in dereferencing buffer.pointer (obj) while being NULL. Although this case may be unrealistic for the current code, it is

Re: [PATCH] amdgpu: prevent NULL pointer dereference if ATIF is not supported

2024-10-31 Thread Antonio Quartulli
Hi Mario, On 30/10/2024 02:41, Mario Limonciello wrote: On 10/29/2024 18:32, Antonio Quartulli wrote: acpi_evaluate_object() may return AE_NOT_FOUND (failure), which would result in dereferencing buffer.pointer (obj) while being NULL. Bail out also when status is AE_NOT_FOUND with a proper

[PATCH v2] amdgpu: prevent NULL pointer dereference if ATIF is not supported

2024-10-31 Thread Antonio Quartulli
fixes 1 FORWARD_NULL issue reported by Coverity Report: CID 1600951: Null pointer dereferences (FORWARD_NULL) Signed-off-by: Antonio Quartulli --- drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu

Re: [PATCH] amdgpu: prevent NULL pointer dereference if ATIF is not supported

2024-10-31 Thread Antonio Quartulli
On 31/10/2024 15:41, Mario Limonciello wrote: On 10/30/2024 16:06, Antonio Quartulli wrote: Hi Mario, On 30/10/2024 02:41, Mario Limonciello wrote: On 10/29/2024 18:32, Antonio Quartulli wrote: acpi_evaluate_object() may return AE_NOT_FOUND (failure), which would result in dereferencing

[PATCH] amdgpu: prevent NULL pointer dereference if ATIF is not supported

2024-10-30 Thread Antonio Quartulli
dereferences (FORWARD_NULL) Signed-off-by: Antonio Quartulli --- drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c index cce85389427f

warn_slowpath_common with linux-3.4

2012-05-31 Thread Antonio Quartulli
[170934.182212] [] ? retint_restore_args+0xe/0xe [170934.182215] [] ? __init_kthread_worker+0x70/0x70 [170934.182218] [] ? gs_change+0xb/0xb [170934.182219] ---[ end trace e93713a9d40cd07a ]--- -- Antonio Quartulli ..each of us alone is worth nothing.. Ernesto "Che" Guevara --