Re:Re: [PATCH drm-misc-next] rockchip/drm: vop2: don't check color_mgmt_changed in atomic_enable

2025-06-19 Thread Andy Yan
HI Piotr, 在 2025-06-19 19:54:12,"Piotr Zalewski" 写道: >Hi Andy > >> >> The root case for the problem is now clear。 >> >> Most of the registers in VOP need to write the cfd_done register(call >> vop2_cfg_done) >> after you have configured the registers. Then, they will take effect only >> when

[PATCH v4 8/9] arm64: dts: rockchip: Enable DisplayPort for rk3588s Cool Pi 4B

2025-06-18 Thread Andy Yan
From: Andy Yan Enable the Mini DisplayPort on this board. Note that ROCKCHIP_VOP2_EP_DP0 is defined as 10 in dt-binding header, but it will trigger a dtc warning like "graph node unit address error, expected "a"" if we use it directly after endpoint, so we use "a"

[PATCH v4 7/9] arm64: dts: rockchip: Add DP1 for rk3588

2025-06-18 Thread Andy Yan
From: Andy Yan The DP1 is compliant with the DisplayPort Specification Version 1.4, and share the USBDP combo PHY1 with USB 3.1 HOST1 controller. Signed-off-by: Andy Yan --- (no changes since v1) .../arm64/boot/dts/rockchip/rk3588-extra.dtsi | 30 +++ 1 file changed, 30

[PATCH v4 5/9] drm/birdge: simple-bridge: Add support for radxa ra620

2025-06-18 Thread Andy Yan
From: Andy Yan The RA620 is an active DP to HDMI converter chip, basically no software is involved to drive it. Add it to simple bridge to make it can be find by the drm bridge chain. Signed-off-by: Andy Yan Reviewed-by: Dmitry Baryshkov --- (no changes since v3) Changes in v3: - First

[PATCH v4 3/9] drm/rockchip: Add RK3588 DPTX output support

2025-06-18 Thread Andy Yan
From: Andy Yan Add driver extension for Synopsys DesignWare DPTX IP used on Rockchip RK3588 SoC. Signed-off-by: Andy Yan Acked-by: Dmitry Baryshkov Tested-by: Nicolas Frattaroli --- Changes in v4: - Drop unused function - Add platform_set_drvdata Changes in v2: - no include uapi path

[PATCH v4 9/9] arm64: dts: rockchip: Enable DP2HDMI for ROCK 5 ITX

2025-06-18 Thread Andy Yan
From: Andy Yan The HDMI0(Port next to Headphone Jack) is drived by DP1 on rk3588 via RA620(a dp2hdmi converter). Add related dt nodes to enable it. Note: ROCKCHIP_VOP2_EP_DP1 is defined as 11 in dt-binding header, but it will trigger a dtc warning like "graph node unit address error, exp

[PATCH v4 1/9] dt-bindings: display: rockchip: Add schema for RK3588 DPTX Controller

2025-06-18 Thread Andy Yan
From: Andy Yan The Rockchip RK3588 SoC integrates the Synopsys DesignWare DPTX controller. And this DPTX controller need share a USBDP PHY with the USB 3.0 OTG controller during operation. Signed-off-by: Andy Yan Reviewed-by: Rob Herring (Arm) --- (no changes since v2) Changes in v2

[PATCH v4 4/9] dt-bindings: display: simple-bridge: Add ra620 compatible

2025-06-18 Thread Andy Yan
From: Andy Yan RA620 is a DP to HDMI bridge converter from RADXA, which first found be used on ROCK 5 ITX. This chip can be used without involving software. Signed-off-by: Andy Yan Acked-by: Krzysztof Kozlowski --- (no changes since v3) Changes in v3: - First introduced in this version

[PATCH v4 2/9] drm/bridge: synopsys: Add DW DPTX Controller support library

2025-06-18 Thread Andy Yan
From: Andy Yan The DW DP TX Controller is compliant with the DisplayPort Specification Version 1.4 with the following features: * DisplayPort 1.4a * Main Link: 1/2/4 lanes * Main Link Support 1.62Gbps, 2.7Gbps, 5.4Gbps and 8.1Gbps * AUX channel 1Mbps * Single Stream Transport(SST) * Multistream

[PATCH v4 6/9] arm64: dts: rockchip: Add DP0 for rk3588

2025-06-18 Thread Andy Yan
From: Andy Yan The DP0 is compliant with the DisplayPort Specification Version 1.4, and share the USBDP combo PHY0 with USB 3.1 HOST0 controller. Signed-off-by: Andy Yan --- (no changes since v1) arch/arm64/boot/dts/rockchip/rk3588-base.dtsi | 30 +++ 1 file changed, 30

[PATCH v4 0/9] Add support for RK3588 DisplayPort Controller

2025-06-18 Thread Andy Yan
From: Andy Yan There are two DW DPTX based DisplayPort Controller on rk3588 which are compliant with the DisplayPort Specification Version 1.4 with the following features: * DisplayPort 1.4a * Main Link: 1/2/4 lanes * Main Link Support 1.62Gbps, 2.7Gbps, 5.4Gbps and 8.1Gbps * AUX channel 1Mbps

[PATCH] drm/panel: raydium-rm67200: Move initialization from enable() to prepare stage

2025-06-18 Thread Andy Yan
From: Andy Yan The DSI host has different modes in prepare() and enable() functions, prepare() is in LP command mode and enable() is in HS video mode. >From our experience, generally the initialization sequence needs to be sent in the LP command mode. Move the setup init function from ena

[PATCH] drm/panel: raydium-rm67200: Add missing drm_display_mode flags

2025-06-18 Thread Andy Yan
From: Andy Yan Add missing drm_display_mode DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC flags. Those are used by various bridges(e.g. dw-mipi-dsi) in the pipeline to correctly configure its sync signals polarity. Tested on rk3568/rk3576/rk3588 EVB. Signed-off-by: Andy Yan --- drivers/gpu

Re:[PATCH v5 02/25] drm/dumb-buffers: Provide helper to set pitch and size

2025-06-18 Thread Andy Yan
ument the UAPI semantics >- compute scanline pitch from for unknown color modes (Andy, Tomi) > >Signed-off-by: Thomas Zimmermann >Reviewed-by: Tomi Valkeinen Reviewed-by: Andy Yan >--- > Documentation/gpu/todo.rst | 27 ++ > drivers/gpu/drm/drm_dumb_buffers.c

[PATCH 2/2] drivers/panel: raydium-rm67200: Make reset-gpio optional

2025-06-16 Thread Andy Yan
From: Andy Yan Although the datasheet of the panel module describes that it has a reset pin, in the actual hardware design, we often use an RC circuit to control the reset, and rarely use GPIO to control the reset. This is the way it is done on our numerous development boards (such as RK3568

[PATCH 1/2] dt-bindings: display: panel: Make reset-gpio as optional for Raydium RM67200

2025-06-16 Thread Andy Yan
From: Andy Yan Although the datasheet of the panel module describes that it has a reset pin, in the actual hardware design, we often use an RC circuit to control the reset, and rarely use GPIO to control the reset. This is the way it is done on our numerous development boards (such as RK3568

Re:[PATCH] drm/rockchip: vop2: fail cleanly if missing a primary plane for a video-port

2025-06-11 Thread Andy Yan
the issue to light and ended in a >null-pointer dereference further down. > >As we expect a primary-plane to exist for a video-port, add a check at >the end of the window-iteration and fail probing if none was found. > >Fixes: 604be85547ce ("drm/rockchip: Add VOP2 driver&qu

Re:Re: [PATCH drm-misc-next] rockchip/drm: vop2: don't check color_mgmt_changed in atomic_enable

2025-06-11 Thread Andy Yan
Hi Deiderik and Piotr, At 2025-06-11 20:26:38, "Diederik de Haas" wrote: >Hi, > >On Wed Jun 11, 2025 at 2:15 PM CEST, Andy Yan wrote: >> At 2025-06-11 18:56:31, "Diederik de Haas" wrote: >>>On Wed Jun 11, 2025 at 9:41 AM CEST, Andy Yan wrote: &g

Re:Re: [PATCH drm-misc-next] rockchip/drm: vop2: don't check color_mgmt_changed in atomic_enable

2025-06-11 Thread Andy Yan
Hi Diederik, At 2025-06-11 18:56:31, "Diederik de Haas" wrote: >Hi Andy, > >On Wed Jun 11, 2025 at 9:41 AM CEST, Andy Yan wrote: >> At 2025-06-10 19:02:11, "Diederik de Haas" wrote: >>>On Tue Jun 10, 2025 at 11:07 AM CEST, Andy Yan wrote: >>&g

Re:Re: [PATCH drm-misc-next] rockchip/drm: vop2: don't check color_mgmt_changed in atomic_enable

2025-06-11 Thread Andy Yan
Hi Diederik, At 2025-06-10 19:02:11, "Diederik de Haas" wrote: >Hi Andy, > >On Tue Jun 10, 2025 at 11:07 AM CEST, Andy Yan wrote: >> At 2025-06-09 20:36:41, "Diederik de Haas" wrote: >>>On Mon Jun 9, 2025 at 11:15 AM CEST, Andy Yan wrote: >>&g

Re:Re: [PATCH drm-misc-next] rockchip/drm: vop2: don't check color_mgmt_changed in atomic_enable

2025-06-09 Thread Andy Yan
Hi Diederik, At 2025-06-08 20:53:37, "Diederik de Haas" wrote: >Hi Andy, > >On Sun Jun 8, 2025 at 2:10 PM CEST, Andy Yan wrote: >> At 2025-06-08 19:08:50, "Diederik de Haas" wrote: >>>On Sat Jun 7, 2025 at 5:32 PM CEST, Piotr Zalewski wrote:

Re:Re: [PATCH drm-misc-next] rockchip/drm: vop2: don't check color_mgmt_changed in atomic_enable

2025-06-08 Thread Andy Yan
Hello, At 2025-06-08 19:08:50, "Diederik de Haas" wrote: >Hi Piotr, > >On Sat Jun 7, 2025 at 5:32 PM CEST, Piotr Zalewski wrote: >> On Thursday, June 5th, 2025 at 10:13 PM, Diederik de Haas >> wrote: >>> Since kernel 6.14-rc1 I have the problem that visual output is no longer >>> shown on my P

Re:Re: [PATCH v3 3/9] drm/rockchip: Add RK3588 DPTX output support

2025-05-29 Thread Andy Yan
k you very much for your review. >On Thursday, 3 April 2025 05:37:31 Central European Summer Time Andy Yan wrote: >> From: Andy Yan >> >> Add driver extension for Synopsys DesignWare DPTX IP used >> on Rockchip RK3588 SoC. >> >> Signed-off-by: An

Re:Re: [PATCH v3 2/9] drm/bridge: synopsys: Add DW DPTX Controller support library

2025-05-24 Thread Andy Yan
Hello Dmitry, 在 2025-05-24 15:46:15,"Dmitry Baryshkov" 写道: >On Wed, May 14, 2025 at 08:15:55PM +0800, Andy Yan wrote: >> Hello Dmitry, >> >> Would it be convenient for you to continue reviewing this patch at your >> convenience? >>

Re:Re: [PATCH] drm/rockchip: Use dev_err_probe() to simplify code

2025-05-23 Thread Andy Yan
Hi, 在 2025-05-22 16:45:08,"Krzysztof Kozlowski" 写道: >On 16/05/2025 11:58, Heiko Stübner wrote: >> Am Donnerstag, 15. Mai 2025, 17:54:20 Mitteleuropäische Sommerzeit schrieb >> Krzysztof Kozlowski: >>> On 15/05/2025 14:35, long.yunj...@zte.com.cn wrote: From: Yumeng Fang In the pr

Re:Re: [PATCH] drm/gem-framebuffer: log errors when gem size < afbc_size

2025-05-22 Thread Andy Yan
Hello, At 2025-05-08 17:11:01, "Daniel Stone" wrote: >Hi Andy, > >On Thu, 8 May 2025 at 11:49, Andy Yan wrote: >> Let the user know what went wrong in drm_gem_fb_afbc_init >> failure paths. > >Thanks for this, and thanks also for using drm_dbg_kms() to make

Re:[PATCH] drm/rockchip: cdn-dp: Convert to drm bridge

2025-05-21 Thread Andy Yan
Hi Chaoyi, At 2025-05-07 11:51:48, "Chaoyi Chen" wrote: >From: Chaoyi Chen > >Convert it to drm bridge driver, it will be convenient for us to >migrate the connector part to the display driver later. > >Tested with RK3399 EVB IND board. > >Signed-off-by: Chaoyi Chen >--- > drivers/gpu/drm/rock

Re:Re:[RFC PATCH v2 1/3] drm/bridge: cadence: cdns-mhdp8546-core: Remove legacy support for connector initialisation in bridge

2025-05-21 Thread Andy Yan
Hello Jayesh, At 2025-05-21 16:15:33, "Andy Yan" wrote: > > >Hello Javesh, > >At 2025-05-21 15:32:35, "Jayesh Choudhary" wrote: >>Now that we have DBANC framework, remove the connector initialisation code >>as that piece of code is not called i

Re:[RFC PATCH v2 1/3] drm/bridge: cadence: cdns-mhdp8546-core: Remove legacy support for connector initialisation in bridge

2025-05-21 Thread Andy Yan
Hello Javesh, At 2025-05-21 15:32:35, "Jayesh Choudhary" wrote: >Now that we have DBANC framework, remove the connector initialisation code >as that piece of code is not called if DRM_BRIDGE_ATTACH_NO_CONNECTOR flag >is used. Only TI K3 platforms consume this driver and tidss (their display >co

[PATCH] drm: Fix one indentation issue in drm_auth.h

2025-05-16 Thread Andy Yan
This should be one space. Signed-off-by: Andy Yan --- include/drm/drm_auth.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/drm/drm_auth.h b/include/drm/drm_auth.h index 50131383ed81..830386804f91 100644 --- a/include/drm/drm_auth.h +++ b/include/drm/drm_auth.h

Re:[PATCH v3 2/9] drm/bridge: synopsys: Add DW DPTX Controller support library

2025-05-14 Thread Andy Yan
dw_dp_has_sink_count. But there is no response on my patch try to Pass down connector to drm bridge detect hook[0]. I don't know how to proceed with this patch at the moment. [0]https://lore.kernel.org/dri-devel/20250321085345.136380-1-andys...@163.com/ Thank you. At 2025-04-03 11:37:30, "Andy Y

[PATCH v5 00/10] Convert inno hdmi to drm bridge

2025-05-12 Thread Andy Yan
From: Andy Yan Convert it to drm bridge driver, it will be convenient for us to migrate the connector part to the display driver later. Patches that have already been merged in drm-misc-next are dropped. PATCH 1~8 are some cleanup and refactor. PATCH 9 converts the curren driver to drm bridge

[PATCH v5 04/10] drm/rockchip: inno_hdmi: Rename function inno_hdmi_reset to inno_hdmi_init_hw

2025-05-12 Thread Andy Yan
From: Andy Yan This function not only configure hardware reset register, but also do some other configurations. Therefore, it is more appropriate to name it inno_hdmi_init_hw, which will also facilitate the addition of other functions to this function in the following patch. Signed-off-by: Andy

[PATCH v5 08/10] drm/rockchip: inno_hdmi: Simpify clk get/enable by devm_clk_get_enabled api

2025-05-12 Thread Andy Yan
From: Andy Yan Make use of devm_clk_get_enabled() to replace devm_clk_get() and clk_prepare_enable(), which will make the cleanup of clk code simpler. Signed-off-by: Andy Yan --- Changes in v5: - Split from PATCH 9/10 drivers/gpu/drm/rockchip/inno_hdmi.c | 50

[PATCH v5 09/10] drm/rockchip: inno-hdmi: Convert to drm bridge

2025-05-12 Thread Andy Yan
From: Andy Yan Convert it to drm bridge driver, it will be convenient for us to migrate the connector part to the display driver later. Signed-off-by: Andy Yan --- Changes in v5: - Split cleanup code to separate patch - Switch to devm_drm_bridge_alloc() API Changes in v4: - Do not store

[PATCH v5 05/10] drm/rockchip: inno_hdmi: Move ddc/i2c configuration and HOTPLUG unmute to inno_hdmi_init_hw

2025-05-12 Thread Andy Yan
From: Andy Yan Putting these scattered initialization code together is helpful for the following migration to the DRM bridge driver mode. Signed-off-by: Andy Yan --- Changes in v5: - Split from PATCH 9/10 drivers/gpu/drm/rockchip/inno_hdmi.c | 30 ++-- 1 file

[PATCH v5 06/10] drm/rockchip: inno_hdmi: Use sleep_range instead of udelay

2025-05-12 Thread Andy Yan
From: Andy Yan usleep_range is preferred over udelay. Signed-off-by: Andy Yan --- Changes in v5: - Split from PATCH 9/10 drivers/gpu/drm/rockchip/inno_hdmi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/rockchip/inno_hdmi.c b/drivers/gpu/drm

[PATCH v5 07/10] drm/rockchip: inno_hdmi: switch i2c registration to devm functions

2025-05-12 Thread Andy Yan
From: Andy Yan Switch from i2c_add_adapter() to resource managed devm_i2c_add_adapter(), which will make the cleanup code more simpler. Signed-off-by: Andy Yan --- Changes in v5: - Split from PATCH 9/10 drivers/gpu/drm/rockchip/inno_hdmi.c | 8 ++-- 1 file changed, 2 insertions(+), 6

[PATCH v5 03/10] drm/rockchip: inno_hdmi: Remove unnecessary parentheses to make checkpatch happy

2025-05-12 Thread Andy Yan
From: Andy Yan Remove unnecessary parentheses to make checkpatch happy. Signed-off-by: Andy Yan --- Changes in v5: - Split from PATCH 9/10 drivers/gpu/drm/rockchip/inno_hdmi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/rockchip/inno_hdmi.c b

[PATCH v5 02/10] drm/rockchip: inno_hdmi: Refactor register macros to make checkpatch happy

2025-05-12 Thread Andy Yan
From: Andy Yan 1. Prefer using the BIT macro 2. Macro argument 'n' as '(n)' to avoid precedence issues 3. Add a blank line after enum declarations Signed-off-by: Andy Yan --- Changes in v5: - Split from patch 9/10 drivers/gpu/drm/rockchip/inno_hdmi.c | 214 ++

[PATCH v5 01/10] drm/rockchip: inno_hdmi: Merge register definition to c file

2025-05-12 Thread Andy Yan
From: Andy Yan Since this register definition is only use in one single c file, there is no need to put it in a separate header. Signed-off-by: Andy Yan --- Changes in v5: - Split from patch 9/10 drivers/gpu/drm/rockchip/inno_hdmi.c | 343 +- drivers/gpu/drm

[PATCH v5 10/10] MAINTAINERS: Add entry for Innosilicon hdmi bridge library

2025-05-12 Thread Andy Yan
From: Andy Yan Add entry for Innosilicon hdmi bridge library Signed-off-by: Andy Yan --- Changes in v5: - First included in this version MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 81b81cc68ca24..3718e570b4739 100644 --- a

[PATCH] drm/rockchip: cleanup fb when drm_gem_fb_afbc_init failed

2025-05-08 Thread Andy Yan
From: Andy Yan In the function drm_gem_fb_init_with_funcs, the framebuffer (fb) and its corresponding object ID have already been registered. So we need to cleanup the drm framebuffer if the subsequent execution of drm_gem_fb_afbc_init fails. Directly call drm_framebuffer_put to ensure that

Re:Re: [PATCH v4 0/7] Convert inno hdmi to drm bridge

2025-05-08 Thread Andy Yan
Hi Dmitry, Thanks for you review. 在 2025-05-05 00:16:35,"Dmitry Baryshkov" 写道: >On Sat, May 03, 2025 at 04:42:04PM +0200, Heiko Stübner wrote: >> Am Dienstag, 22. April 2025, 09:04:39 Mitteleuropäische Sommerzeit schrieb >> Andy Yan: >> > From: Andy Yan &g

[PATCH] drm/gem-framebuffer: log errors when gem size < afbc_size

2025-05-08 Thread Andy Yan
Let the user know what went wrong in drm_gem_fb_afbc_init failure paths. Signed-off-by: Andy Yan --- drivers/gpu/drm/drm_gem_framebuffer_helper.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_gem_framebuffer_helper.c b/drivers/gpu/drm

Re:Re:Re: [PATCH 1/1] drm/bridge: Pass down connector to drm bridge detect hook

2025-05-06 Thread Andy Yan
Ping.. At 2025-04-22 15:59:27, "Andy Yan" wrote: > >Hi all, > >At 2025-03-21 17:48:04, "Maxime Ripard" wrote: >>On Fri, Mar 21, 2025 at 04:53:38PM +0800, Andy Yan wrote: >>> From: Andy Yan >>> >>> In some application s

Re:[PATCH v2 01/34] drm: convert many bridge drivers from devm_kzalloc() to devm_drm_bridge_alloc() API

2025-04-28 Thread Andy Yan
if (!C) > -return ERR_PTR(-ENOMEM); > +C = devm_drm_bridge_alloc(DEV, T, BR, FUNCS); > +if (IS_ERR(C)) > + return PTR_ERR(C); > ) > ... > -C->BR.funcs = FUNCS; > >Signed-off-by: Luca Ceresoli > >--- > >Cc: Adam Ford >Cc: Adrien Grassein

Re:[PATCH v2 03/34] drm/bridge: analogix-anx6345: convert to devm_drm_bridge_alloc() API

2025-04-28 Thread Andy Yan
Hi, At 2025-04-25 02:59:10, "Luca Ceresoli" wrote: >This is the new API for allocating DRM bridges. > >Signed-off-by: Luca Ceresoli Reviewed-by: Andy Yan > >--- > >Cc: "Uwe Kleine-König" >Cc: Andy Yan >Cc: Dmitry Baryshkov >Cc: Jani

[PATCH] drm/rockchip: rk3066_hdmi: switch to drm bridge

2025-04-28 Thread Andy Yan
From: Andy Yan Convert it to drm bridge driver, it will be convenient for us to migrate the connector part to the display driver later. Note: I don't have the hardware to test this driver, so for now I can only do the compilation test. Signed-off-by: Andy Yan --- drivers/gpu/drm/roc

Re:Re: [PATCH] drm/rockchip: add CONFIG_OF dependency

2025-04-23 Thread Andy Yan
ALOGIX_DP [=y] >> >> Rockchip platforms all depend on OF anyway, so add the dependency here >> for compile testing. >> >> Fixes: d7b4936b2bc0 ("drm/rockchip: analogix_dp: Add support to get panel >> from the DP AUX bus") >> Signed-off-by: Arnd Berg

Re:Re: [PATCH 1/1] drm/bridge: Pass down connector to drm bridge detect hook

2025-04-22 Thread Andy Yan
Hi all, At 2025-03-21 17:48:04, "Maxime Ripard" wrote: >On Fri, Mar 21, 2025 at 04:53:38PM +0800, Andy Yan wrote: >> From: Andy Yan >> >> In some application scenarios, we hope to get the corresponding >> connector when the bridge's detect hook is inv

[PATCH v4 3/7] drm/rockchip: inno-hdmi: Simplify error handler with dev_err_probe

2025-04-22 Thread Andy Yan
From: Andy Yan Use dev_err_probe simplify the error handle. Signed-off-by: Andy Yan --- (no changes since v2) Changes in v2: - First included in this series drivers/gpu/drm/rockchip/inno_hdmi.c | 19 ++- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a

[PATCH v4 2/7] dt-bindings: display: rockchip, inno-hdmi: Document GRF for RK3036 HDMI

2025-04-22 Thread Andy Yan
From: Andy Yan HDMI on RK3036 use GRF control the HSYNC/VSYNC polarity, but this part is missing when it first landing upstream. Document that it is mandatory for RK3036 HDMI. Signed-off-by: Andy Yan Reviewed-by: Krzysztof Kozlowski --- (no changes since v2) Changes in v2: - First

[PATCH v4 7/7] drm/rockchip: inno-hdmi: Convert to drm bridge

2025-04-22 Thread Andy Yan
From: Andy Yan Convert it to drm bridge driver, it will be convenient for us to migrate the connector part to the display driver later. Signed-off-by: Andy Yan --- Changes in v4: - Do not store colorimetry within inno_hdmi struct Changes in v3: - First included in v3 drivers/gpu/drm

[PATCH v4 0/7] Convert inno hdmi to drm bridge

2025-04-22 Thread Andy Yan
From: Andy Yan When preparing to convert the current inno hdmi driver into a bridge driver, I found that there are several issues currently existing with it: 1. When the system starts up, the first time it reads the EDID, it will fail. This is because RK3036 HDMI DDC bus requires it's

[PATCH v4 5/7] ARM: dts: rockchip: Add ref clk for hdmi

2025-04-22 Thread Andy Yan
From: Andy Yan The RK3036 HDMI DDC bus requires it's PHY's reference clock to be enabled first before normal DDC communication can be carried out. Signed-off-by: Andy Yan --- (no changes since v1) arch/arm/boot/dts/rockchip/rk3036.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH v4 4/7] drm/rockchip: inno-hdmi: Fix video timing HSYNC/VSYNC polarity setting for rk3036

2025-04-22 Thread Andy Yan
From: Andy Yan The HSYNC/VSYNC polarity of rk3036 HDMI are controlled by GRF. Without the polarity configuration in GRF, it can be observed from the HDMI protocol analyzer that the H/V front/back timing output by RK3036 HDMI are currently not in line with the specifications. Signed-off-by: Andy

[PATCH v4 6/7] Revert "ARM: dts: rockchip: drop grf reference from rk3036 hdmi"

2025-04-22 Thread Andy Yan
From: Andy Yan This reverts commit 1580ccb6ed9dc76b8ff3e2d8912e8215c8b0fa6d. The HSYNC/VSYNC polarity of rk3036 HDMI are controlled by GRF. Without the polarity configuration in GRF, it can be observed from the HDMI protocol analyzer that the H/V front/back timing output by RK3036 HDMI are

[PATCH v4 1/7] dt-bindings: display: rockchip, inno-hdmi: Fix Document of RK3036 compatible

2025-04-22 Thread Andy Yan
From: Andy Yan The RK3036 HDMI DDC bus requires it's PHY's reference clock to be enabled first before normal DDC communication can be carried out. Therefore, both RK3036 and RK3128 HDMI require two identical clocks. Signed-off-by: Andy Yan Reviewed-by: Rob Herring (Arm) --- (

[PATCH] drm/rockchip: vop2: Fix the update of LAYER/PORT select registers when there are multi display output on rk3588/rk3568

2025-04-21 Thread Andy Yan
From: Andy Yan The all video ports of rk3568/rk3588 share the same OVL_LAYER_SEL and OVL_PORT_SEL registers, and the configuration of these two registers can be set to take effect when the vsync signal arrives at a certain Video Port. If two threads for two display output choose to update these

Re:[PATCH v4] drm/rockchip: Disable AFBC for res >2560 on rk3399

2025-04-18 Thread Andy Yan
switching works correctly in sway > >Signed-off-by: Konstantin Shabanov >Cc: Daniel Stone >Cc: Andy Yan >Reported-by: Dan Callaghan >Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/7968 > >[1]: >https://opensource.rock-chips.com/images/d/d7/Rockchip_RK3399_Data

Re:Re: [PATCH v4] drm/rockchip: Disable AFBC for res >2560 on rk3399

2025-04-18 Thread Andy Yan
Hi At 2025-04-18 17:43:19, "Daniel Stone" wrote: >Hi Andy, > >On Fri, 18 Apr 2025 at 01:16, Andy Yan wrote: >> I prefer the V1 version PATCH[0]. This is because we do not deal with >> hardware-related >> differences at this level. It involves a VOP-

Re:Re: [PATCH 05/11] drm/rockchip: Test for imported buffers with drm_gem_is_imported()

2025-04-15 Thread Andy Yan
Hi, 在 2025-04-15 15:51:31,"Thomas Zimmermann" 写道: >Hi > >Am 15.04.25 um 09:15 schrieb Andy Yan: >> Hi Thomas, >> >> 在 2025-04-15 14:54:21,"Thomas Zimmermann" 写道: >>> Hi >>> >>> Am 15.04.25 um 06:00 schrieb Andy Yan: &g

Re:Re: [PATCH 05/11] drm/rockchip: Test for imported buffers with drm_gem_is_imported()

2025-04-15 Thread Andy Yan
Hi Thomas, 在 2025-04-15 14:54:21,"Thomas Zimmermann" 写道: >Hi > >Am 15.04.25 um 06:00 schrieb Andy Yan: >> >> Hi Thomas, >> >> At 2025-04-14 21:48:12, "Thomas Zimmermann" wrote: >>> Instead of testing import_attach for imported GEM

Re:[PATCH 05/11] drm/rockchip: Test for imported buffers with drm_gem_is_imported()

2025-04-14 Thread Andy Yan
;to make import_attach optional. > >Signed-off-by: Thomas Zimmermann >Cc: Sandy Huang >Cc: "Heiko Stübner" >Cc: Andy Yan >--- > drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/drivers/gp

Re:[PATCH v2] (drm/rockchip) Reject AFBC for resolutions >2560x1600

2025-04-14 Thread Andy Yan
Hi Konstantin, the Subject should be: drm/rockchip: At 2025-04-14 17:53:31, "Konstantin Shabanov" wrote: >As it isn't supported by hardware. At least, RK3399 doesn't support >it. From the datasheet[1] >("1.2.10 Video IN/OUT", "Display Interface", p. 17): > > Support AFBC function

[PATCH v2] drm/bridge: dw-hdmi: Avoid including uapi headers

2025-04-11 Thread Andy Yan
From: Andy Yan It is not recommended for drivers to include UAPI header directly. Signed-off-by: Andy Yan Reviewed-by: Heiko Stuebner --- Changes in v2: - Collect R-b from Heiko. drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

Re:[PATCH v8 00/13] Add eDP support for RK3588

2025-04-10 Thread Andy Yan
Hello Heiko, Could you take this series ? They have already got the necessary R-B and Ack. I think Damon still has some patches for connector decoupling. With this series have been merged earlier. His new patches can have fewer dependencies. At 2025-03-10 18:41:01, "Damon Ding" wrote

Re:Re: [PATCH v3 7/7] drm/rockchip: inno-hdmi: Convert to drm bridge

2025-04-08 Thread Andy Yan
Hi Alex, At 2025-04-03 01:24:22, "Alex Bee" wrote: > >Hi Andy, > >> From: Andy Yan >> >> Convert it to drm bridge driver, it will be convenient for us to >> migrate the connector part to the display driver later. >> >> Signed-off-by

Re:Re: [PATCH v5 04/16] drm/atomic: Introduce helper to lookup connector by encoder

2025-04-07 Thread Andy Yan
gt; > > On Fri, Mar 14, 2025 at 08:45:17AM +0100, Maxime Ripard wrote: >> > > > > > > On Fri, Mar 14, 2025 at 07:52:35AM +0200, Dmitry Baryshkov wrote: >> > > > > > > > On Fri, Mar 14, 2025 at 08:50:29AM +0800, Andy Yan wrote: >> > >

[PATCH v3 6/9] arm64: dts: rockchip: Add DP0 for rk3588

2025-04-05 Thread Andy Yan
From: Andy Yan The DP0 is compliant with the DisplayPort Specification Version 1.4, and share the USBDP combo PHY0 with USB 3.1 HOST0 controller. Signed-off-by: Andy Yan --- (no changes since v1) arch/arm64/boot/dts/rockchip/rk3588-base.dtsi | 30 +++ 1 file changed, 30

Re:Re: [PATCH v2 1/5] drm/dp: Pull drm_dp_link_power_up/down from Tegra to common drm_dp_helper

2025-04-05 Thread Andy Yan
Gentle ping.. At 2025-03-27 20:54:37, "Dmitry Baryshkov" wrote: >On 27/03/2025 14:39, Andy Yan wrote: >> >> Hello Dmitry, >> Could you take this series? If so, merging it earlier can avoid future >> conflicts from other patches. >> Besi

Re:Re: [PATCH 1/1] drm/bridge: Pass down connector to drm bridge detect hook

2025-04-05 Thread Andy Yan
Hi Maxime, At 2025-03-21 17:48:04, "Maxime Ripard" wrote: >On Fri, Mar 21, 2025 at 04:53:38PM +0800, Andy Yan wrote: >> From: Andy Yan >> >> In some application scenarios, we hope to get the corresponding >> connector when the bridge's detect hook is

[PATCH v3 1/7] dt-bindings: display: rockchip, inno-hdmi: Fix Document of RK3036 compatible

2025-04-04 Thread Andy Yan
From: Andy Yan The RK3036 HDMI DDC bus requires it's PHY's reference clock to be enabled first before normal DDC communication can be carried out. Therefore, both RK3036 and RK3128 HDMI require two identical clocks. Signed-off-by: Andy Yan Reviewed-by: Rob Herring (Arm) --- (

[PATCH v3 9/9] arm64: dts: rockchip: Enable DP2HDMI for ROCK 5 ITX

2025-04-04 Thread Andy Yan
From: Andy Yan The HDMI0(Port next to Headphone Jack) is drived by DP1 on rk3588 via RA620(a dp2hdmi converter). Add related dt nodes to enable it. Note: ROCKCHIP_VOP2_EP_DP1 is defined as 11 in dt-binding header, but it will trigger a dtc warning like "graph node unit address error, exp

[PATCH v3 0/9] Add support for RK3588 DisplayPort Controller

2025-04-03 Thread Andy Yan
From: Andy Yan There are two DW DPTX based DisplayPort Controller on rk3588 which are compliant with the DisplayPort Specification Version 1.4 with the following features: * DisplayPort 1.4a * Main Link: 1/2/4 lanes * Main Link Support 1.62Gbps, 2.7Gbps, 5.4Gbps and 8.1Gbps * AUX channel 1Mbps

[PATCH v3 1/9] dt-bindings: display: rockchip: Add schema for RK3588 DPTX Controller

2025-04-02 Thread Andy Yan
From: Andy Yan The Rockchip RK3588 SoC integrates the Synopsys DesignWare DPTX controller. And this DPTX controller need share a USBDP PHY with the USB 3.0 OTG controller during operation. Signed-off-by: Andy Yan Reviewed-by: Rob Herring (Arm) --- (no changes since v2) Changes in v2

[PATCH v3 5/9] drm/birdge: simple-bridge: Add support for radxa ra620

2025-04-02 Thread Andy Yan
From: Andy Yan The RA620 is an active DP to HDMI converter chip, basically no software is involved to drive it. Add it to simple bridge to make it can be find by the drm bridge chain. Signed-off-by: Andy Yan --- Changes in v3: - First introduced in this version. drivers/gpu/drm/bridge

[PATCH v3 8/9] arm64: dts: rockchip: Enable DisplayPort for rk3588s Cool Pi 4B

2025-04-02 Thread Andy Yan
From: Andy Yan Enable the Mini DisplayPort on this board. Note that ROCKCHIP_VOP2_EP_DP0 is defined as 10 in dt-binding header, but it will trigger a dtc warning like "graph node unit address error, expected "a"" if we use it directly after endpoint, so we use "a"

[PATCH v3 2/9] drm/bridge: synopsys: Add DW DPTX Controller support library

2025-04-02 Thread Andy Yan
From: Andy Yan The DW DP TX Controller is compliant with the DisplayPort Specification Version 1.4 with the following features: * DisplayPort 1.4a * Main Link: 1/2/4 lanes * Main Link Support 1.62Gbps, 2.7Gbps, 5.4Gbps and 8.1Gbps * AUX channel 1Mbps * Single Stream Transport(SST) * Multistream

[PATCH v3 4/9] dt-bindings: display: simple-bridge: Add ra620 compatible

2025-04-02 Thread Andy Yan
From: Andy Yan RA620 is a DP to HDMI bridge converter from RADXA, which first found be used on ROCK 5 ITX. This chip can be used without involving software. Signed-off-by: Andy Yan --- Changes in v3: - First introduced in this version. .../devicetree/bindings/display/bridge/simple

[PATCH v3 7/9] arm64: dts: rockchip: Add DP1 for rk3588

2025-04-02 Thread Andy Yan
From: Andy Yan The DP1 is compliant with the DisplayPort Specification Version 1.4, and share the USBDP combo PHY1 with USB 3.1 HOST1 controller. Signed-off-by: Andy Yan --- (no changes since v1) .../arm64/boot/dts/rockchip/rk3588-extra.dtsi | 30 +++ 1 file changed, 30

[PATCH v3 3/9] drm/rockchip: Add RK3588 DPTX output support

2025-04-02 Thread Andy Yan
From: Andy Yan Add driver extension for Synopsys DesignWare DPTX IP used on Rockchip RK3588 SoC. Signed-off-by: Andy Yan Acked-by: Dmitry Baryshkov --- (no changes since v2) Changes in v2: - no include uapi path - switch to drmm_encoder_init drivers/gpu/drm/rockchip/Kconfig

Re:[PATCH] drm/bridge: dw-hdmi: Avoid including uapi headers

2025-04-02 Thread Andy Yan
Gentle ping.. At 2025-03-14 15:57:47, "Andy Yan" wrote: >From: Andy Yan > >It is not recommended for drivers to include UAPI header >directly. > >Signed-off-by: Andy Yan >--- > > drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 4 ++-- > 1 file changed,

[PATCH v3 2/7] dt-bindings: display: rockchip, inno-hdmi: Document GRF for RK3036 HDMI

2025-04-02 Thread Andy Yan
From: Andy Yan HDMI on RK3036 use GRF control the HSYNC/VSYNC polarity, but this part is missing when it first landing upstream. Document that it is mandatory for RK3036 HDMI. Signed-off-by: Andy Yan --- (no changes since v2) Changes in v2: - First included in v2 .../bindings/display

[PATCH v3 7/7] drm/rockchip: inno-hdmi: Convert to drm bridge

2025-04-02 Thread Andy Yan
From: Andy Yan Convert it to drm bridge driver, it will be convenient for us to migrate the connector part to the display driver later. Signed-off-by: Andy Yan --- Changes in v3: - First included in v3 - Link to V2: https://lore.kernel.org/dri-devel/20250325132944.17-1-andys...@163.com

[PATCH v3 6/7] Revert "ARM: dts: rockchip: drop grf reference from rk3036 hdmi"

2025-04-02 Thread Andy Yan
From: Andy Yan This reverts commit 1580ccb6ed9dc76b8ff3e2d8912e8215c8b0fa6d. The HSYNC/VSYNC polarity of rk3036 HDMI are controlled by GRF. Without the polarity configuration in GRF, it can be observed from the HDMI protocol analyzer that the H/V front/back timing output by RK3036 HDMI are

[PATCH v3 5/7] ARM: dts: rockchip: Add ref clk for hdmi

2025-04-02 Thread Andy Yan
From: Andy Yan The RK3036 HDMI DDC bus requires it's PHY's reference clock to be enabled first before normal DDC communication can be carried out. Signed-off-by: Andy Yan --- (no changes since v1) arch/arm/boot/dts/rockchip/rk3036.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH v3 0/7] Convert inno hdmi to drm bridge

2025-04-02 Thread Andy Yan
From: Andy Yan When preparing to convert the current inno hdmi driver into a bridge driver, I found that there are several issues currently existing with it: 1. When the system starts up, the first time it reads the EDID, it will fail. This is because RK3036 HDMI DDC bus requires it's

[PATCH v3 3/7] drm/rockchip: inno-hdmi: Simplify error handler with dev_err_probe

2025-04-02 Thread Andy Yan
From: Andy Yan Use dev_err_probe simplify the error handle. Signed-off-by: Andy Yan --- (no changes since v2) Changes in v2: - First included in this series drivers/gpu/drm/rockchip/inno_hdmi.c | 19 ++- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a

[PATCH v3 4/7] drm/rockchip: inno-hdmi: Fix video timing HSYNC/VSYNC polarity setting for rk3036

2025-04-02 Thread Andy Yan
From: Andy Yan The HSYNC/VSYNC polarity of rk3036 HDMI are controlled by GRF. Without the polarity configuration in GRF, it can be observed from the HDMI protocol analyzer that the H/V front/back timing output by RK3036 HDMI are currently not in line with the specifications. Signed-off-by: Andy

[PATCH 1/1] drm/bridge: Pass down connector to drm bridge detect hook

2025-03-27 Thread Andy Yan
From: Andy Yan In some application scenarios, we hope to get the corresponding connector when the bridge's detect hook is invoked. In most cases, we can get the connector by drm_atomic_get_connector_for_encoder if the encoder attached to the bridge is enabled, however there will still be

Re:[PATCH v2 1/5] drm/dp: Pull drm_dp_link_power_up/down from Tegra to common drm_dp_helper

2025-03-27 Thread Andy Yan
Hello Dmitry, Could you take this series? If so, merging it earlier can avoid future conflicts from other patches. Besides, I can update my DP driver based on drm-misc-next. At 2025-03-18 14:34:35, "Andy Yan" wrote: >From: Andy Yan > >The helper functions drm_dp_link

[PATCH 0/1] Pass down connector to drm bridge detect hook

2025-03-26 Thread Andy Yan
From: Andy Yan In some application scenarios, we hope to get the corresponding connector when the bridge's detect hook is invoked. For example, we may want to call drm_dp_read_sink_count_cap(which needs a drm_connector) at the dp deteck hook, intel_dp and nouveau_dp do this at it's c

Re:Re: [PATCH v2 2/6] dt-bindings: display: rockchip,inno-hdmi: Document GRF for RK3036 HDMI

2025-03-26 Thread Andy Yan
Hi At 2025-03-26 15:59:25, "Krzysztof Kozlowski" wrote: >On Tue, Mar 25, 2025 at 09:29:36PM +0800, Andy Yan wrote: >> From: Andy Yan >> >> HDMI on RK3036 use GRF control the HSYNC/VSYNC polarity, but this part >> is missing when it first landing upstream.

[PATCH v2 1/6] dt-bindings: display: rockchip, inno-hdmi: Fix Document of RK3036 compatible

2025-03-25 Thread Andy Yan
From: Andy Yan The RK3036 HDMI DDC bus requires it's PHY's reference clock to be enabled first before normal DDC communication can be carried out. Therefore, both RK3036 and RK3128 HDMI require two identical clocks. Signed-off-by: Andy Yan Reviewed-by: Rob Herring (Arm) --- (

[PATCH v2 2/6] dt-bindings: display: rockchip, inno-hdmi: Document GRF for RK3036 HDMI

2025-03-25 Thread Andy Yan
From: Andy Yan HDMI on RK3036 use GRF control the HSYNC/VSYNC polarity, but this part is missing when it first landing upstream. Document that it is mandatory for RK3036 HDMI. Signed-off-by: Andy Yan --- (no changes since v1) .../bindings/display/rockchip/rockchip,inno-hdmi.yaml| 9

[PATCH v2 0/6] Two fixes of RK3036 HDMI

2025-03-25 Thread Andy Yan
From: Andy Yan When preparing to convert the current inno hdmi driver into a bridge driver, I found that there are several issues currently existing with it: 1. When the system starts up, the first time it reads the EDID, it will fail. This is because RK3036 HDMI DDC bus requires it&#

[PATCH v2 4/6] drm/rockchip: inno-hdmi: Fix video timing HSYNC/VSYNC polarity setting for rk3036

2025-03-25 Thread Andy Yan
From: Andy Yan The HSYNC/VSYNC polarity of rk3036 HDMI are controlled by GRF. Without the polarity configuration in GRF, it can be observed from the HDMI protocol analyzer that the H/V front/back timing output by RK3036 HDMI are currently not in line with the specifications. Signed-off-by: Andy

[PATCH v2 5/6] ARM: dts: rockchip: Add ref clk for hdmi

2025-03-25 Thread Andy Yan
From: Andy Yan The RK3036 HDMI DDC bus requires it's PHY's reference clock to be enabled first before normal DDC communication can be carried out. Signed-off-by: Andy Yan --- (no changes since v1) arch/arm/boot/dts/rockchip/rk3036.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2

  1   2   3   4   5   6   7   8   9   10   >